Re: [linux-usb-devel] Kconfig troubles when using menuconfig - Was: [patch]Re: linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Andreas Herrmann
On Fri, Jun 22, 2007 at 10:22:46AM -0300, Mauro Carvalho Chehab wrote:
 Hi Roman,
 
 Several instabilities on Kconfig started to happen after replacing
 Kconfig menus to use menuconfig, as this one, reported by Oliver:
 
 Em Qui, 2007-06-21 às 13:50 +0200, Oliver Neukum escreveu:
  Am Donnerstag, 21. Juni 2007 schrieb Toralf Förster:
   Right, but IMHO this issue is typical for a problem with the Kconfig 
   definitions of this module.
   
   I'll set USB devs as Cc: therefore.
  
  The Kconfig there is incomplete.
  Mauro, please apply.
  
  Regards
  Oliver
  Signed-off-by: Oliver Neukum [EMAIL PROTECTED]
 
  --- a/drivers/media/video/zc0301/Kconfig2007-06-21 
  13:44:14.0 +0200
  +++ b/drivers/media/video/zc0301/Kconfig2007-06-21 
  13:44:33.0 +0200
  @@ -1,6 +1,6 @@
   config USB_ZC0301
  tristate USB ZC0301[P] Image Processor and Control Chip support
  -   depends on VIDEO_V4L1
  +   depends on VIDEO_V4L1  USB
  ---help---
Say Y here if you want support for cameras based on the ZC0301 or
ZC0301P Image Processors and Control Chips.
  
 
 In this specific case, all V4L USB drivers depends on V4L_USB_DRIVERS,
 that depends, in turn, on USB. So, if USB is not selected,
 V4L_USB_DRIVERS should be unselected, unselecting zc0301.
 
 Unfortunately, the Kernel building system is not properly handling it.
 
 This is the (snipped) media/video/Kconfig:
 
 menuconfig V4L_USB_DRIVERS
 bool V4L USB devices
 depends on USB
 default y
 
 if V4L_USB_DRIVERS
 
 source drivers/media/video/pvrusb2/Kconfig
 
 snip/
 
 source drivers/media/video/zc0301/Kconfig
 
 snip/
 
 endif # V4L_USB_DRIVERS
 
 -- 
 Cheers,
 Mauro
 


Hi,

I am not sure whether it is related or not
But if you select USB as module but build your v4l_usb driver
into the kernel you also get compile errors.
Attached is a patch which will prevent this by changing the menuconfig
from bool to tristate.


Regards,

Andreas

--
Correct Kconfig to avoid compile errors like

 drivers/built-in.o: In function `sn9c102_usb_disconnect':
 sn9c102_core.c:(.text+0x8d840): undefined reference to `usb_get_dev'

Signed-off-by: Andreas Herrmann [EMAIL PROTECTED]

diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 4cca551..4754d98 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -687,7 +687,7 @@ config VIDEO_CAFE_CCIC
 #
 
 menuconfig V4L_USB_DRIVERS
-   bool V4L USB devices
+   tristate V4L USB devices
depends on USB
default y
 




-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] [patch] usbnet: fix kconfig for usbnet drivers

2007-06-22 Thread Andreas Herrmann
Fix kernel build error:

 drivers/built-in.o: In function `usbnet_set_settings':
 : undefined reference to `mii_ethtool_sset'
 drivers/built-in.o: In function `usbnet_get_settings':
 : undefined reference to `mii_ethtool_gset'
 drivers/built-in.o: In function `usbnet_get_link':
 : undefined reference to `mii_link_ok'
 drivers/built-in.o: In function `usbnet_nway_reset':
 : undefined reference to `mii_nway_restart'

This occurs when an USBNET device is built-in but MII is
selected as module.

Signed-off-by: Andreas Herrmann [EMAIL PROTECTED]

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 8dc09a3..5a38fa2 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -68,6 +68,7 @@ config USB_KAWETH
 
 config USB_PEGASUS
tristate USB Pegasus/Pegasus-II based ethernet device support
+   select NET_ETHERNET
select MII
---help---
  Say Y here if you know you have Pegasus or Pegasus-II based adapter.
@@ -84,6 +85,7 @@ config USB_PEGASUS
 config USB_RTL8150
tristate USB RTL8150 based ethernet device support (EXPERIMENTAL)
depends on EXPERIMENTAL
+   select NET_ETHERNET
select MII
help
  Say Y here if you have RTL8150 based usb-ethernet adapter.
@@ -93,13 +95,8 @@ config USB_RTL8150
  To compile this driver as a module, choose M here: the
  module will be called rtl8150.
 
-config USB_USBNET_MII
-   tristate
-   default n
-
 config USB_USBNET
tristate Multi-purpose USB Networking Framework
-   select MII if USB_USBNET_MII != n
---help---
  This driver supports several kinds of network links over USB,
  with minidrivers built around a common network driver core
@@ -135,7 +132,7 @@ config USB_NET_AX8817X
tristate ASIX AX88xxx Based USB 2.0 Ethernet Adapters
depends on USB_USBNET  NET_ETHERNET
select CRC32
-   select USB_USBNET_MII
+   select MII
default y
help
  This option adds support for ASIX AX88xxx based USB 2.0
@@ -190,7 +187,8 @@ config USB_NET_DM9601
tristate Davicom DM9601 based USB 1.1 10/100 ethernet devices
depends on USB_USBNET
select CRC32
-   select USB_USBNET_MII
+   select NET_ETHERNET
+   select MII
help
  This option adds support for Davicom DM9601 based USB 1.1
  10/100 Ethernet adapters.
@@ -225,7 +223,8 @@ config USB_NET_PLUSB
 config USB_NET_MCS7830
tristate MosChip MCS7830 based Ethernet adapters
depends on USB_USBNET
-   select USB_USBNET_MII
+   select NET_ETHERNET
+   select MII
help
  Choose this option if you're using a 10/100 Ethernet USB2
  adapter based on the MosChip 7830 controller. This includes




-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


Re: [linux-usb-devel] Kconfig troubles when using menuconfig - Was: [patch]Re: linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Andreas Herrmann
On Fri, Jun 22, 2007 at 03:51:34PM +0200, Jan Engelhardt wrote:
 
 On Jun 22 2007 15:46, Andreas Herrmann wrote:
 Hi,
 
 I am not sure whether it is related or not
 But if you select USB as module but build your v4l_usb driver
 into the kernel you also get compile errors.
 Attached is a patch which will prevent this by changing the menuconfig
 from bool to tristate.
 
 A config option that is not referenced in the Makefile...
 should it really be a tristate? In my opinion, changing it
 to tristate is just a workaround, but I don't know kconfig
 well enough to make bool Do The Right Thing in these situations myself :(

dito

Same problem occurred with menuconfig NET_PCMCIA.
See http://marc.info/?l=linux-kernelm=118244569131373


Regards,

Andreas

-- 
Operating | AMD Saxony Limited Liability Company  Co. KG,
  System  | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 Research | Register Court Dresden: HRA 4896, General Partner authorized
  Center  | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
  (OSRC)  | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy




-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


Re: [linux-usb-devel] Kconfig troubles when using menuconfig - Was: [patch]Re: linux-2.6.22-rc5-gf1518a0 build #300 failed in zc0301_core.c

2007-06-22 Thread Andreas Herrmann
On Fri, Jun 22, 2007 at 12:03:19PM -0300, Mauro Carvalho Chehab wrote:
 Em Sex, 2007-06-22 às 15:51 +0200, Jan Engelhardt escreveu:
  On Jun 22 2007 15:46, Andreas Herrmann wrote:
  Hi,
  
  I am not sure whether it is related or not
  But if you select USB as module but build your v4l_usb driver
  into the kernel you also get compile errors.
  Attached is a patch which will prevent this by changing the menuconfig
  from bool to tristate.
 
 
  A config option that is not referenced in the Makefile...
  should it really be a tristate? In my opinion, changing it
  to tristate is just a workaround, but I don't know kconfig
  well enough to make bool Do The Right Thing in these situations myself :(
 
 If USB is built as a module, the V4L USB modules should also be built as
 a module. Otherwise, you will have compile errors, since some required
 symbols on the drivers won't be linked into the kernel.
 

Sure.

And the patch should prevent user selection of such
a broken kernel configuration.

Regards,

Andreas

-- 
Operating | AMD Saxony Limited Liability Company  Co. KG,
  System  | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 Research | Register Court Dresden: HRA 4896, General Partner authorized
  Center  | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
  (OSRC)  | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy




-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


[linux-usb-devel] usb-storage

2004-05-09 Thread Andreas Herrmann
May  9 11:29:19 feynman usb 1-1: new full speed USB device using address 2
May  9 11:29:19 feynman usb-storage: This device (07cf,1001,1000 S 05 P 01) 
has an unneeded Protocol entry in unusual_devs.h
May  9 11:29:19 feynman Please send a copy of this message to 
[EMAIL PROTECTED]
May  9 11:29:19 feynman scsi0 : SCSI emulation for USB Mass Storage devices
May  9 11:29:19 feynman Vendor: Casio Model: QV DigitalCamera  Rev: 1000
May  9 11:29:19 feynman Type:   Direct-Access  ANSI SCSI 
revision: 02
May  9 11:29:19 feynman USB Mass Storage device found at 2
May  9 11:29:20 feynman scsi.agent[22237]: disk 
at /devices/pci:00/:00:1d.0/usb1/1-1/1-1:1.0/host0/0:0:0:0


---
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson  Lucent use to 
deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
___
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel