[PATCH 4/4] usb: add usb_alloc_urb_node to use use kmalloc_node
If you're fixing things up, change use use to use while you're at it...
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE
The negative is the sheer number of helper functions in list.h. Personally,
I find it difficult to retain a working knowledge of them. Iterators are
particularly nasty that way. I'm thinking about dropping all of these
list_for_each_with_murky_argument_requirements_and_odd_side_effects()
The negative is the sheer number of helper functions in list.h.
Personally,
I find it difficult to retain a working knowledge of them. Iterators are
particularly nasty that way. I'm thinking about dropping all of these
If I just see
for (pos = list_entry((head)-next, typeof(*pos), member),
n = list_entry(pos-member.next, typeof(*pos), member);
pos-member != (head);
pos = n, n = list_entry(n-member.next, typeof(*n), member))
then what am I to think?
You
/* The first entry is a placeholder for the insmod-specified device */
-{ USB_DEVICE(0x049F, 0x0003) },
Is it obvious why this patch is correct? Especially given the
comment just before the line you delete, and the code
if (vendor) {
This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19
with patches available.
Subject: KVM: guest crash
References : http://lkml.org/lkml/2007/1/8/163
Submitter : Roland Dreier [EMAIL PROTECTED]
Handled-By : Avi Kivity [EMAIL PROTECTED]
Patch : http
this works well on my kyocera kpc650 -- throughput is up to about 1
mbit/sec vs. ~250 kbit/sec with the stock airprime driver.
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM
+/* something happened, so free up the memory for this urb /*
an obvious glitch here at the end of the line...
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM
or:
- send a patch against 2.6.17 that is my changes + your fixes to
actually make it work.
My patch was just a throw it out there and see what works or not, as I
don't even have the device to test it with.
I would love to see such a patch. I have a Kyocera KPC650 and I would
So you are saying that, for example
spin_lock_irqsave(cs-ev_lock, flags);
head = cs-ev_head;
tail = cs-ev_tail;
spin_unlock_irqrestore(cs-ev_lock, flags);
is (mutatis mutandis) actually cheaper than
head = atomic_read(cs-ev_head);
tail =
+/**
+ * execute_in_process_context - reliably execute the routine with user
context
+ * @fn: the function to execute
+ * @data: data to pass to the function
+ *
+ * Executes the function immediately if process context is available,
+ * otherwise schedules the
Here is the non-controversial part of the patch I posted last week.
It just gets rid of a few places where DMA is done to variables on the
stack. After discussion on lkml, I think we agreed that DMA into the
middle of kmalloc()'ed structs is wrong and should be fixed with
alignment macros. I'll
Use __dma_buffer to align buffer in struct usb_hub and descriptor in
struct usb_device since both are used for DMA.
Patch is against 2.4.19-pre10.
Thanks,
Roland
drivers/usb/hub.h |3 ++-
include/linux/usb.h |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff -Naur
Johannes == Johannes Erdfelt [EMAIL PROTECTED] writes:
Johannes All of the uses of usb_get_descriptor in usb.c are
Johannes safe. I'd much rather make the calling routine require a
Johannes DMA capable buffer than in usb_get_descriptor.
I just looked back at usb.c. Some of the
Oliver == Oliver Neukum [EMAIL PROTECTED] writes:
Oliver This can be used in error handling by storage devices. You
Oliver must use GFP_NOIO. And you should check for a failure due
Oliver to OOM.
Yep, I caught those missed checks for allocation failure. And I will
change to using
David == David Brownell [EMAIL PROTECTED] writes:
Roland Note that this might not work perfectly on all
Roland cache-incoherent processors, since kmalloc could
Roland potentially allocate a chunk of memory that is smaller
Roland than the processor's cache line size. However it
I just got USB working on my PPC440GP (IBM Ebony eval board). I'm
using an Opti 82C861 OHCI controller, and so far I've tried an Alcor
SD card reader (mass storage) and a Belkin usbnet device. My kernel
is 2.4.19-pre10 from the bk://ppc.bkbits.net/linuxppc_2_4_devel
BitKeeper tree.
I had to
Johannes == Johannes Erdfelt [EMAIL PROTECTED] writes:
Johannes Nope, the HCD's do that. This patch looks good, but
Johannes could use a little bit of cleaning up.
What cleaning up would you like to see? I would definitely like to
get these fixes into the main tree so just let me
18 matches
Mail list logo
