Re: [linux-usb-devel] Possible bug in isp116x-hcd

2007-06-20 Thread ok
On Mon, Jun 18, 2007 at 11:00:10AM -0400, Alan Stern wrote: Olav, What would be involved in refactoring isp116x-hcd so that the driver called usb_hcd_giveback_urb() as soon as the URB was completed? If I understand the current code correctly, postproc_atl_queue() goes through all the

Re: [linux-usb-devel] Possible bug in isp116x-hcd

2007-06-22 Thread ok
On Thu, Jun 21, 2007 at 05:17:42PM -0400, Alan Stern wrote: On Thu, 21 Jun 2007, ok wrote: Do you mean something like that below? I haven't tested it. Yes, something very much like this. It could be simplified a little; in a couple of places where you have finish_request

Re: [linux-usb-devel] Possible bug in isp116x-hcd

2007-06-25 Thread ok
succeeded or correctly NAK'ed retransmission attempt */ if (ep-error_count (cc == TD_CC_NOERROR || cc == TD_NOTACCESSED)) ep-error_count = 0; there's no need to test ep-error_count; it's easier just to set it to 0. OK