On Tue, 26 Jun 2007, ok wrote:
I took out the references to urb-lock in preproc_atl_queue and
isp116x_urb_enqueue. They didn't seem to serve any purpose; is that
correct?
Seems to be correct. urb-hcpriv is already protected by isp116x-lock.
Is urb-lock entirely to guard only
On Sat, Jun 23, 2007 at 08:25:55PM -0400, Alan Stern wrote:
Below is a patch based on your work. There's a number of differences,
plus some things I left as-is but which look suspicious.
Thanks for the review.
You touched the part of the code that took the lognest time to
stabilize. It
On Sat, 23 Jun 2007, ok wrote:
If you like, I'll try revising your patch. You'll have to test it
Yes, thanks.
though; I don't have the hardware.
Olav:
Below is a patch based on your work. There's a number of differences,
plus some things I left as-is but which look suspicious.
I
On Thu, Jun 21, 2007 at 05:17:42PM -0400, Alan Stern wrote:
On Thu, 21 Jun 2007, ok wrote:
Do you mean something like that below? I haven't tested it.
Yes, something very much like this. It could be simplified a little;
in a couple of places where you have
finish_request();
On Thu, 21 Jun 2007, ok wrote:
Hi Alan,
Do you mean something like that below? I haven't tested it.
Yes, something very much like this. It could be simplified a little;
in a couple of places where you have
finish_request();
spin_unlock();
continue;
you ought to
On Mon, Jun 18, 2007 at 11:00:10AM -0400, Alan Stern wrote:
Olav,
What would be involved in refactoring isp116x-hcd so that the driver
called usb_hcd_giveback_urb() as soon as the URB was completed? If I
understand the current code correctly, postproc_atl_queue() goes
through all the
On Thu, 14 Jun 2007, Olav Kongas wrote:
Hi Alan,
Index: usb-2.6/drivers/usb/host/isp116x-hcd.c
===
--- usb-2.6.orig/drivers/usb/host/isp116x-hcd.c
+++ usb-2.6/drivers/usb/host/isp116x-hcd.c
@@ -583,12 +583,15 @@ static
Hi Alan,
Index: usb-2.6/drivers/usb/host/isp116x-hcd.c
===
--- usb-2.6.orig/drivers/usb/host/isp116x-hcd.c
+++ usb-2.6/drivers/usb/host/isp116x-hcd.c
@@ -583,12 +583,15 @@ static void
finish_atl_transfers(struct
On Thu, 14 Jun 2007, Olav Kongas wrote:
Hi Alan,
Index: usb-2.6/drivers/usb/host/isp116x-hcd.c
===
--- usb-2.6.orig/drivers/usb/host/isp116x-hcd.c
+++ usb-2.6/drivers/usb/host/isp116x-hcd.c
@@ -583,12 +583,15 @@ static
