Re: [PATCH 2/4] usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove()

2013-08-01 Thread Peter Chen
On Wed, Jul 31, 2013 at 04:21:14PM +0200, Lothar Waßmann wrote: This prevents the USB PHY refcount to be decremented below zero upon unloading the ci-hdrc-imx module. Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- drivers/usb/chipidea/ci_hdrc_imx.c |4 +--- 1 files

Re: [PATCH 3/4] usb: chipidea: don't clobber return value of ci_role_start()

2013-08-01 Thread Peter Chen
On Wed, Jul 31, 2013 at 04:21:15PM +0200, Lothar Waßmann wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- drivers/usb/chipidea/core.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index

Re: [PATCH 4/4] usb: chipidea: Prevent endless loop registering platform_devices when ci_hdrc_probe() fails.

2013-08-01 Thread Peter Chen
On Wed, Jul 31, 2013 at 04:21:16PM +0200, Lothar Waßmann wrote: commit 40dcd0e introduced the following code to the ci_hdrc_probe() function: + if (!dev-of_node dev-parent) + dev-of_node = dev-parent-of_node; This inadvertently associates the ci_hdrc device with the

[PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Boris BREZILLON
The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c, but this implementation will be removed

Re: Audio I/O parameters

2013-08-01 Thread Clemens Ladisch
Alan Stern wrote: On Wed, 31 Jul 2013, James Stone wrote: On Wed, Jul 31, 2013 at 4:48 PM, Alan Stern st...@rowland.harvard.edu wrote: James, see what happens with this patch. It will print a warning message in the system log every time it detects an underrun, but it won't cause an URB

Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue

2013-08-01 Thread Dan Carpenter
On Wed, Jul 31, 2013 at 10:26:15PM +0200, Julia Lawall wrote: On Wed, 31 Jul 2013, Kumar Gaurav wrote: Fixed String splitted into multiple line issue using macro I'm not an expert on this kind of style issue, but I prefer strings that look like strings. Yeah. This patch makes the

Re: [PATCH 2/8] pl2303: fix+improve the divsor based baud rate encoding method

2013-08-01 Thread Greg KH
On Tue, Jul 30, 2013 at 09:49:05PM +0200, Frank Schäfer wrote: Based on the formula in the code description, Reinhard Max and me have investigated the devices behavior / functional principle of the divisor based baud rate encoding method. It turned out, that (although beeing a good starting

Re: lsusb doesn't handle 32 bits Usage tags.

2013-08-01 Thread Greg KH
On Sun, Jul 07, 2013 at 09:32:55PM +0200, pchavent wrote: On Sun, 7 Jul 2013 10:37:59 -0700, Greg KH wrote: On Sun, Jul 07, 2013 at 07:17:40PM +0200, pchavent wrote: Hi. lsusb doesn't handle 32 bits Usage tags. I've tried to do a patch but i'm not confident in its implementation. Do

Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework

2013-08-01 Thread Greg KH
On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote: +static int phy_get_id(void) +{ + int ret; + int id; + + ret = ida_pre_get(phy_ida, GFP_KERNEL); + if (!ret) + return -ENOMEM; + + ret = ida_get_new(phy_ida, id); + if (ret 0) +

Re: [PATCH] usb: gadget: audio file: wake up sleep thread when device unbind

2013-08-01 Thread Clemens Ladisch
Qiao Zhou wrote: when usb audio device removes, it doesn't notify the ALSA read / write thread. due to no data transmitting any more, those threads wait for a long timeout(10s), then detects IO error. it causes long time blocking in upper layer read/write. to fix this issue, wake up

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-08-01 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2013 at 09:40:26AM -0700, Sarah Sharp wrote: On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous buffers. Cc: Sarah Sharp sarah.a.sh...@linux.intel.com

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-08-01 Thread Greg KH
On Wed, Jul 31, 2013 at 04:44:43PM -0400, Alan Stern wrote: On Wed, 31 Jul 2013, Tomasz Figa wrote: Alan, Greg, On Tuesday 23 of July 2013 01:49:23 Tomasz Figa wrote: This patch modifies the ohci-s3c2410 driver to prepare and unprepare clocks in addition to enabling and disabling,

[PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Joe Perches
There are several drivers in drivers/net/usb/ that do not have specific MAINTAINERS that should have emails forwarded to the linux-usb mailing list. Add a section for those drivers. Signed-off-by: Joe Perches j...@perches.com --- In the future, you do not need to send drivers/net/usb/ patches

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 12:48:48AM -0700, Joe Perches wrote: There are several drivers in drivers/net/usb/ that do not have specific MAINTAINERS that should have emails forwarded to the linux-usb mailing list. Add a section for those drivers. Signed-off-by: Joe Perches j...@perches.com

Re: [PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-01 Thread Matthieu CASTET
Hi, Le Wed, 31 Jul 2013 18:41:57 +0100, Tuomas Tynkkynen ttynkky...@nvidia.com a écrit : The has_hostpc capability bit indicates that the host controller has the HOSTPC register extensions, but at the same time enables clock disabling power saving features with the PHY Low Power Clock Disable

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Joe Perches
On Thu, 2013-08-01 at 15:56 +0800, Greg KH wrote: On Thu, Aug 01, 2013 at 12:48:48AM -0700, Joe Perches wrote: There are several drivers in drivers/net/usb/ that do not have specific MAINTAINERS that should have emails forwarded to the linux-usb mailing list. diff --git a/MAINTAINERS

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Ming Lei
On Thu, Aug 1, 2013 at 1:04 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2013-08-01 at 12:41 +0800, Ming Lei wrote: From my trace result, lots of linear SKBs are cloned or header-cloned, so it needs skb copy too. Is it normal in xmit path to see cloned SKBs for driver? If not, I

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-08-01 Thread Oliver Neukum
On Thu, 2013-08-01 at 15:30 +0800, Greg Kroah-Hartman wrote: On Wed, Jul 31, 2013 at 09:40:26AM -0700, Sarah Sharp wrote: On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous

Re: [PATCH 2/4] usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove()

2013-08-01 Thread Lothar Waßmann
Hi, Peter Chen writes: On Wed, Jul 31, 2013 at 04:21:14PM +0200, Lothar Waßmann wrote: This prevents the USB PHY refcount to be decremented below zero upon unloading the ci-hdrc-imx module. Signed-off-by: Lothar Waßmann l...@karo-electronics.de ---

Re: [PATCH 3/4] usb: chipidea: don't clobber return value of ci_role_start()

2013-08-01 Thread Lothar Waßmann
Hi, Peter Chen writes: On Wed, Jul 31, 2013 at 04:21:15PM +0200, Lothar Waßmann wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- drivers/usb/chipidea/core.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/core.c

Re: [PATCH 4/4] usb: chipidea: Prevent endless loop registering platform_devices when ci_hdrc_probe() fails.

2013-08-01 Thread Lothar Waßmann
Hi, Peter Chen writes: On Wed, Jul 31, 2013 at 04:21:16PM +0200, Lothar Waßmann wrote: commit 40dcd0e introduced the following code to the ci_hdrc_probe() function: + if (!dev-of_node dev-parent) + dev-of_node = dev-parent-of_node; This inadvertently

Re: [PATCH] usb: gadget: audio file: wake up sleep thread when device unbind

2013-08-01 Thread Qiao Zhou
On 08/01/2013 03:33 PM, Clemens Ladisch wrote: Qiao Zhou wrote: when usb audio device removes, it doesn't notify the ALSA read / write thread. due to no data transmitting any more, those threads wait for a long timeout(10s), then detects IO error. it causes long time blocking in upper layer

question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Chen Wang
hello, I'm reading code of usb core and driver model/sysfs. I believe they are designed with OOP. So, do we have any UML design diagrams for better understanding? I can't image newbies can ramp up quickly in front of such tons of codes without a high-level design guidance, though I believe I can

[PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-01 Thread Boris BREZILLON
The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c, but this implementation will be removed

Re: [PATCH 2/4] usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove()

2013-08-01 Thread Peter Chen
On Thu, Aug 01, 2013 at 10:38:18AM +0200, Lothar Waßmann wrote: Hi, Peter Chen writes: On Wed, Jul 31, 2013 at 04:21:14PM +0200, Lothar Waßmann wrote: This prevents the USB PHY refcount to be decremented below zero upon unloading the ci-hdrc-imx module. Signed-off-by: Lothar

Re: [PATCH 3/4] usb: chipidea: don't clobber return value of ci_role_start()

2013-08-01 Thread Peter Chen
On Thu, Aug 01, 2013 at 10:40:42AM +0200, Lothar Waßmann wrote: Hi, Peter Chen writes: On Wed, Jul 31, 2013 at 04:21:15PM +0200, Lothar Waßmann wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- drivers/usb/chipidea/core.c |1 - 1 files changed, 0

[RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Felipe Balbi
Hi folks, as we all know naming conventions are fragile and easy to break. We've had weird endpoint naming conventions for far too long in the gadget framework. I'm trying to come up with means to get rid of that and, one of the ideas, was to add transfer support flags to our struct usb_ep which

[PATCH 1/1] usb: samsung: Update Exynos ehci/ohci bindings documentation

2013-08-01 Thread Sachin Kamat
Updated the document as per the latest implementation. While at it also fixed some trivial typos. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- .../devicetree/bindings/usb/exynos-usb.txt | 38 +++- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git

Re: [PATCH 3/4] usb: chipidea: don't clobber return value of ci_role_start()

2013-08-01 Thread Lothar Waßmann
Peter Chen writes: On Thu, Aug 01, 2013 at 10:40:42AM +0200, Lothar Waßmann wrote: Hi, Peter Chen writes: On Wed, Jul 31, 2013 at 04:21:15PM +0200, Lothar Waßmann wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- drivers/usb/chipidea/core.c |1 -

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 12:29:55PM +0300, Felipe Balbi wrote: Hi folks, as we all know naming conventions are fragile and easy to break. We've had weird endpoint naming conventions for far too long in the gadget framework. I'm trying to come up with means to get rid of that and, one

[PATCH 1/1] usb: phy: samsung: Update usbphy documentation

2013-08-01 Thread Sachin Kamat
Updated the documentation as per the latest driver implementation. While at it also fixed some trivial typos. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- .../devicetree/bindings/usb/samsung-usbphy.txt | 48 ++-- 1 file changed, 23 insertions(+), 25 deletions(-)

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Sebastian Andrzej Siewior
On 08/01/2013 11:29 AM, Felipe Balbi wrote: Hi folks, Hi felipe, as we all know naming conventions are fragile and easy to break. We've had weird endpoint naming conventions for far too long in the gadget framework. I'm trying to come up with means to get rid of that and, one of the

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Oliver Neukum
On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: hello, I'm reading code of usb core and driver model/sysfs. I believe they are designed with OOP. Yes, much of the code is OO. However, we usually don't overwrite methods. So, do we have any UML design diagrams for better No. The code was

Re: [PATCH 4/4] usb: chipidea: Prevent endless loop registering platform_devices when ci_hdrc_probe() fails.

2013-08-01 Thread Peter Chen
On Thu, Aug 01, 2013 at 10:43:52AM +0200, Lothar Waßmann wrote: Hi, Peter Chen writes: On Wed, Jul 31, 2013 at 04:21:16PM +0200, Lothar Waßmann wrote: commit 40dcd0e introduced the following code to the ci_hdrc_probe() function: + if (!dev-of_node dev-parent) +

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Felipe Balbi
On Thu, Aug 01, 2013 at 11:47:56AM +0200, Sebastian Andrzej Siewior wrote: On 08/01/2013 11:29 AM, Felipe Balbi wrote: Hi folks, Hi felipe, as we all know naming conventions are fragile and easy to break. We've had weird endpoint naming conventions for far too long in the gadget

[PATCH] usb: gadget: audio file: wake up sleep thread when device unbind

2013-08-01 Thread Qiao Zhou
when usb audio device removes, we need to stop the current pcm substream when detecting hw disconnects. otherwise the read / write thread may sleep for long time before timeout, thus upper layer is blocked for long time and can't repsond quickly to the hw disconnection. also substream pcm may

[PATCH v2] usb-gadget-audio-file-wake-up-sleep-thread

2013-08-01 Thread Qiao Zhou
v2-v1: stop pcm stream instead of wake up the sleep thread, which is more reasonable. Qiao Zhou (1): usb: gadget: audio file: wake up sleep thread when device unbind drivers/usb/gadget/f_audio_source.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) -- To unsubscribe

RE: Patch ' usb: gadget: cdc2: convert to new interface of f_ecm' applied to my tree

2013-08-01 Thread Andrzej Pietrasiewicz
On Wednesday, June 12, 2013 5:17 PM Felipe Balbi wrote: Hi, This is a note to let you know that the patch: usb: gadget: cdc2: convert to new interface of f_ecm has been applied to my tree and can be found at: http://bit.ly/172DRHC a snapshot of the tree can be

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Sebastian Andrzej Siewior
On 08/01/2013 12:18 PM, Felipe Balbi wrote: yeah, I want to drop gadget_is_*() altogether and add feature flags for the struct usb_gadget too. I mean, gadget driver shouldn't need to know that it's running on dwc3, it needs to know if the UDC supports alternate settings. One of them is to

Re: Patch ' usb: gadget: cdc2: convert to new interface of f_ecm' applied to my tree

2013-08-01 Thread Felipe Balbi
Hi On Thu, Aug 01, 2013 at 12:31:55PM +0200, Andrzej Pietrasiewicz wrote: On Wednesday, June 12, 2013 5:17 PM Felipe Balbi wrote: Hi, This is a note to let you know that the patch: usb: gadget: cdc2: convert to new interface of f_ecm has been applied to my tree and can

[PATCH] usb/gadget: cdc2: convert to new interface of f_ecm

2013-08-01 Thread Andrzej Pietrasiewicz
This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e. The invocation of usb_get_function_instance() is in cdc_bind() and should not be repeated in cdc_do_config(). Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH] usb/gadget: cdc2: convert to new interface of f_ecm

2013-08-01 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 12:40:47PM +0200, Andrzej Pietrasiewicz wrote: This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e. The invocation of usb_get_function_instance() is in cdc_bind() and should not be repeated in cdc_do_config(). Signed-off-by: Andrzej Pietrasiewicz

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-08-01 Thread Sebastian Andrzej Siewior
On 08/01/2013 07:24 AM, George Cherian wrote: b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..0f756ca 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -333,21 +337,85 @@ status = disabled; }; -usb@4740 { -

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-08-01 Thread Sebastian Andrzej Siewior
On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote: On 08/01/2013 07:24 AM, George Cherian wrote: b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..0f756ca 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -333,21 +337,85 @@ status = disabled;

Haswell C2, xHCI and S3

2013-08-01 Thread Andre Heider
Hi list, blunt question, because I'm about to assemble a new Haswell box and I wonder if waiting for C2 boards makes sense: Does Linux care about the apparent C1 stepping xHCI bug [1]? Are workarounds required for the kernel? If so, does C2 get rid of them? [1]

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-01 Thread Sergei Shtylyov
Hello. On 01-08-2013 3:29, Stephen Warren wrote: Don't they cause numerous resource conflicts while device nodes being instantiated as the platform devices? No; the driver knows that the HW is screwy and there's lots of register-range sharing going on, so it simply maps the registers,

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Eric Dumazet
On Thu, 2013-08-01 at 16:10 +0800, Ming Lei wrote: On Thu, Aug 1, 2013 at 1:04 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2013-08-01 at 12:41 +0800, Ming Lei wrote: From my trace result, lots of linear SKBs are cloned or header-cloned, so it needs skb copy too. Is it

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 11:51:07AM +0200, Oliver Neukum wrote: On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: hello, I'm reading code of usb core and driver model/sysfs. I believe they are designed with OOP. Yes, much of the code is OO. However, we usually don't overwrite methods.

[PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-01 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com ax88179_tx_fixup() has quite complex code trying to push 8 bytes of control data (len/mss), but fails to do it properly for TCP packets, incurring an extra copy and point of memory allocation failure. Lets use the simple and approved way.

Re: [PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-01 Thread Eric Dumazet
On Thu, 2013-08-01 at 06:49 -0700, Eric Dumazet wrote: From: Eric Dumazet eduma...@google.com ax88179_tx_fixup() has quite complex code trying to push 8 bytes of control data (len/mss), but fails to do it properly for TCP packets, incurring an extra copy and point of memory allocation

[PATCH 3/7] usb: phy: omap-usb3: Don't use omap_get_control_dev()

2013-08-01 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node

[PATCH 6/7] ARM: dts: omap4: update omap-control-usb nodes

2013-08-01 Thread Roger Quadros
Split otghs_ctrl and USB2 PHY power down into separate omap-control-usb nodes. Update ti,mode property. CC: Benoit Cousson benoit.cous...@linaro.org Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 17 - 1 files changed, 12 insertions(+), 5

[PATCH 7/7] ARM: dts: omap5: update omap-control-usb node

2013-08-01 Thread Roger Quadros
Split USB2 PHY and USB3 PHY into separate omap-control-usb nodes. Update ti,mode property. CC: Benoit Cousson benoit.cous...@linaro.org Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff

[PATCH 4/7] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-01 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/usb/musb/omap2430.c

[PATCH 1/7] usb: phy: omap: Add new PHY types and remove omap_control_usb3_phy_power()

2013-08-01 Thread Roger Quadros
TYPE2 meaning has changed. It is now a USB2 phy with Power down bit in control_dev_conf register. Introduce TYPE3 and TYPE4 PHY. TYPE3 is USB3 phy with DPLL and individual TX/RX power control. TYPE4 is USB2 phy with power aux register. Update DT binding information to reflect these changes.

[PATCH 2/7] usb: phy: omap-usb2: Don't use omap_get_control_dev()

2013-08-01 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node

[PATCH 0/7] phy: omap-usb: Support multiple instances and new types

2013-08-01 Thread Roger Quadros
Hi, This patchset does the following: * Restructure and add support for new PHY types. We now support the follwing four types TYPE1 - if it has otghs_control mailbox register (e.g. on OMAP4) TYPE2 - if it has Power down bit in control_dev_conf register. e.g. USB2 PHY TYPE3 - if it has DPLL

[PATCH v2] usb/gadget: cdc2: fix conversion to new interface of f_ecm

2013-08-01 Thread Andrzej Pietrasiewicz
This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e (usb: gadget: cdc2: convert to new interface of f_ecm) The invocation of usb_get_function_instance() is in cdc_bind() and should not be repeated in cdc_do_config(). Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com

[PATCH 5/7] usb: phy: omap: get rid of omap_get_control_dev()

2013-08-01 Thread Roger Quadros
This function was preventing us from supporting multiple instances. Get rid of it. Since we support DT boots only, users can get the control device phandle from the DT node. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/usb/phy/phy-omap-control.c | 31 ++-

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-01 Thread Oliver Neukum
On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: More importantly, if we already know that the medium is not present or has been changed since it was last used, then there's no reason to call sd_sync_cache() at all. Like this? Regards Oliver From

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Oliver Neukum wrote: On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: hello, I'm reading code of usb core and driver model/sysfs. I believe they are designed with OOP. Yes, much of the code is OO. However, we usually don't overwrite methods. So, do we have

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Boris BREZILLON wrote: The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in

Re: Audio I/O parameters

2013-08-01 Thread Alan Stern
On Wed, 31 Jul 2013, James Stone wrote: It seems likely that the error is caused by an SMI taking too much time. At least, we seem to have ruled out everything else. Besides, this change has to be made eventually in any case -- underruns can occur at any time, in principle, and they

[PATCH v2 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-01 Thread Tuomas Tynkkynen
From: Mikko Perttunen mperttu...@nvidia.com Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- arch/arm/boot/dts/tegra114-dalmore.dts | 9 +

[PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-01 Thread Tuomas Tynkkynen
Add device tree entries for the 3 USB controllers and PHYs and enable the third controller on Cardhu and Beaver boards. Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. Also, internal pullups need to be enabled on those pins. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com

Re: [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-01 Thread Tuomas Tynkkynen
On 08/01/2013 01:13 AM, Stephen Warren wrote: On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: Add device tree entries for the 3 USB controllers and PHYs and enable the third controller on Cardhu and Beaver boards. Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. That much is

Re: Audio I/O parameters

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, James Stone wrote: I've got some error messages written to syslog now - with no audible effect on audio processing: Aug 1 01:12:36 blueberry kernel: [ 6233.028335] ehci-pci :00:12.2: iso underrun 8800c872db00 (1407+0 1471) That's an impressive one. It

Re: Audio I/O parameters

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Clemens Ladisch wrote: It seems likely that the error is caused by an SMI taking too much time. At least, we seem to have ruled out everything else. Besides, this change has to be made eventually in any case -- underruns can occur at any time, in principle, and they

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Grant Grundler
On Wed, Jul 31, 2013 at 3:51 AM, Ming Lei ming@canonical.com wrote: This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so both frame header and skb data buffers can be passed

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Eric Dumazet
On Thu, 2013-08-01 at 08:30 -0700, Grant Grundler wrote: http://lxr.free-electrons.com/source/include/linux/byteorder/generic.h#L111 http://lxr.free-electrons.com/ident?i=__cpu_to_le32s IIRC, cpu_to_leXX() macros return the endian corrected value. In other words, they need to be assigned to

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Felipe Balbi wrote: Hi folks, as we all know naming conventions are fragile and easy to break. We've had weird endpoint naming conventions for far too long in the gadget framework. I'm trying to come up with means to get rid of that and, one of the ideas, was to add

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 11:44:59AM -0400, Alan Stern wrote: On Thu, 1 Aug 2013, Felipe Balbi wrote: Hi folks, as we all know naming conventions are fragile and easy to break. We've had weird endpoint naming conventions for far too long in the gadget framework. I'm trying to

[PATCH v2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-01 Thread Boris BREZILLON
The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c, but this implementation will be removed

[PATCH v2] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Boris BREZILLON
The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c, but this implementation will be removed

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-01 Thread Eldad Zack
On Tue, 30 Jul 2013, Takashi Iwai wrote: At Mon, 29 Jul 2013 21:23:15 +0200, Daniel Mack wrote: On 29.07.2013 20:20, Alan Stern wrote: data_ep_set_params() checks snd_usb_endpoint_implicit_feedback_sink() in three places. It looks like only the second place is correct. Can

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Sergei Shtylyov
Hello. On 08/01/2013 07:56 PM, Alan Stern wrote: What happens if uclk isn't found but it is needed? It will not fail but I guess the usb host won't work as the clock won't be correctly configured. I agree with you: this is not a good solution. Another option is to keep the previous

Re: Buffer size for ALSA USB PCM audio

2013-08-01 Thread Alan Stern
On Mon, 29 Jul 2013, Clemens Ladisch wrote: Alan Stern wrote: Clemens remarked some time ago that keeping the queue full would be trivial, if only he knew how full it needed to be. The answer to that is given above. I have been trying to make the appropriate changes, but I'm not

Re: [PATCH v2] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Boris BREZILLON wrote: The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in

Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Sergei Shtylyov wrote: Yes. However, a more elegant approach is to protect the relevant statements with: if (defined(CONFIG_COMMON_CLK)). This preprocessor You probably meant IS_ENABLED() or IS_BUIILTIN()? Or is there something I don't know about gcc

[PATCH 2/6] staging: ozwpan: Mark string as const

2013-08-01 Thread Rupesh Gujare
Make sure that we mark const string so that it does not get modified. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozproto.c |6 +++--- drivers/staging/ozwpan/ozproto.h |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 3/6] staging: ozwpan: Use kernel strncmp function.

2013-08-01 Thread Rupesh Gujare
Use kernel's strncmp() function instead of defining same within driver. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozproto.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c

[PATCH 1/6] staging: ozwpan: Use kernel list function for managing interface list.

2013-08-01 Thread Rupesh Gujare
Managing interface list, is easier if we use kernel list_* API than managing it on our own. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozproto.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git

[PATCH 4/6] staging: ozwpan: Drop oldest ISOC frame instead of dropping latest.

2013-08-01 Thread Rupesh Gujare
In case of ISOC transfer, if TX queue is full then we start dropping latest frame, instead we should drop oldest frame add latest frame to TX queue. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozpd.c | 13 - 1 file changed, 12 insertions(+), 1

[PATCH 0/6] staging: ozwpan: Use Kernel API Bug fixes

2013-08-01 Thread Rupesh Gujare
This patch series removes duplicate code, replaces it with kernel library functions, and few bug fixes. Rupesh Gujare (6): staging: ozwpan: Use kernel list function for managing interface list. staging: ozwpan: Mark string as const staging: ozwpan: Use kernel strncmp function.

[PATCH 5/6] staging: ozwpan: Increase farewell report size.

2013-08-01 Thread Rupesh Gujare
Farewell report size can be bigger than one byte, increase array size to accomodate maximum 32 bytes of farewell report. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozpd.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 6/6] staging: ozwpan: Set farewell report length.

2013-08-01 Thread Rupesh Gujare
Fixes a bug where we were not setting length field causing wrong report size to be copied. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozproto.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ozwpan/ozproto.c

Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-08-01 Thread Mauro Carvalho Chehab
Em Sun, 28 Jul 2013 22:29:04 -0700 Joe Perches j...@perches.com escreveu: It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). Add #include linux/if_ether.h as necessary.

Re: [PATCH 2/6] staging: ozwpan: Mark string as const

2013-08-01 Thread Joe Perches
On Thu, 2013-08-01 at 18:40 +0100, Rupesh Gujare wrote: Make sure that we mark const string so that it does not get modified. [] diff --git a/drivers/staging/ozwpan/ozproto.h b/drivers/staging/ozwpan/ozproto.h [] -void oz_binding_add(char *net_dev); -void oz_binding_remove(char *net_dev);

Re: Audio I/O parameters

2013-08-01 Thread Clemens Ladisch
Alan Stern wrote: On Thu, 1 Aug 2013, Clemens Ladisch wrote: It seems likely that the error is caused by an SMI taking too much time. At least, we seem to have ruled out everything else. Besides, this change has to be made eventually in any case -- underruns can occur at any time, in

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-01 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 11:58:30AM -0400, Alan Stern wrote: The endpoint naming convention currently determines type and direction. It works okay for simple cases but not for more complicated ones. For example, it can't handle endpoints that support bulk or interrupt but not

[PATCH] usb: gadget: amd5536udc: unconditionally use GFP_ATOMIC in udc_queue()

2013-08-01 Thread Alexey Khoroshilov
As far as prep_dma() is called with spinlock held, we have to pass GFP_ATOMIC regardless of gfp argument. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/usb/gadget/amd5536udc.c | 4 ++-- 1 file changed, 2

[PATCH V2 0/3] networking: Use ETH_ALEN where appropriate

2013-08-01 Thread Joe Perches
Convert the uses mac addresses to ETH_ALEN so it's easier to find and verify where mac addresses need to be __aligned(2) Change from initial submission: - Remove include/acpi/actbl2.h conversion It's a file copied from outside ACPI sources Joe Perches (3): uapi: Convert some uses of 6 to

[PATCH V2 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

2013-08-01 Thread Joe Perches
It's convenient to have ethernet mac addresses use ETH_ALEN to be able to grep for them a bit easier and also to ensure that the addresses are __aligned(2). Add #include linux/if_ether.h as necessary. Signed-off-by: Joe Perches j...@perches.com Acked-by: Mauro Carvalho Chehab

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-08-01 Thread Sarah Sharp
On Thu, Aug 01, 2013 at 10:15:51AM +0200, Oliver Neukum wrote: On Thu, 2013-08-01 at 15:30 +0800, Greg Kroah-Hartman wrote: On Wed, Jul 31, 2013 at 09:40:26AM -0700, Sarah Sharp wrote: On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: This patch marks all xHCI controllers as

Re: [PATCH V5] usb: Add Device Tree support to XHCI Platform driver

2013-08-01 Thread Sarah Sharp
On Wed, Jul 31, 2013 at 11:45:48PM +0400, Sergei Shtylyov wrote: Hello. On 07/31/2013 10:48 PM, Sarah Sharp wrote: Sergei, Felipe, do you have a strong preference on this name? Or should I take the patch as is? I've already said I don't have a strong preference. Ok, I will take the

[PATCH 1/2] USB: EHCI: keep better track of resuming ports

2013-08-01 Thread Alan Stern
The ehci-hcd driver isn't as careful as it should be about the way it uses ehci-resuming_ports. One of the omissions was fixed recently by commit 47a64a13d54 (USB: EHCI: Fix resume signalling on remote wakeup), but there are other places that need attention: When a port's suspend feature

[PATCH 2/2] USB: EHCI: don't depend on hardware for tracking port resets and resumes

2013-08-01 Thread Alan Stern
In theory, an EHCI controller can turn off the PORT_RESUME or PORT_RESET bits in a port status register all by itself (and some controllers actually do this). We shouldn't depend on these bits being set correctly. This patch rearranges the code in ehci-hcd that handles completion of port resets

Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set in host mode and cleared in device mode -

Re: [PATCH 4/6] usb: phy: tegra: Program new PHY parameters

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The Tegra30 TRM recommends configuration of certain PHY parameters for optimal quality. Program the following registers based on device tree parameters: - UTMIP_XCVR_HSSLEW: HS slew rate control. - UTMIP_HSSQUELCH_LEVEL: HS squelch detector

Re: [PATCH 5/6] Documentation: New DT parameters for tegra30-usb-phy

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: Document the new device tree parameters for Tegra30 USB PHY. Very minor nit: It would make sense to move this patch before the previous patch (or squash them together) so that the documentation is updated first. But, it makes no difference to the

  1   2   >