Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-09 Thread Fernandes, Joel
Some temporary issues with my mua so forgive any artifacts in this email. On Oct 9, 2013, at 12:14 AM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: On Wednesday 09 October 2013 09:58 AM, Joel Fernandes wrote: On 10/01/2013 10:04 AM, Daniel Mack wrote: This patch makes the edma driver resume

Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-09 Thread Gururaja Hebbar
On Wednesday 09 October 2013 11:33 AM, Fernandes, Joel wrote: Some temporary issues with my mua so forgive any artifacts in this email. On Oct 9, 2013, at 12:14 AM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: On Wednesday 09 October 2013 09:58 AM, Joel Fernandes wrote: On 10/01/2013

[PATCH] USB: gadget: s3c-hsotg: fix set_ep_maxpacket function

2013-10-09 Thread Robert Baldyga
This patch fixes max packet size check in s3c_hsotg_set_ep_maxpacket() function. According USB specification, bits 10..0 of mps specifies maximum packet size, so there is bitwise AND between mps and 0x7ff value. Also added check if maxpacket isn't grater than 1024 which is maximum size od single

Re: [PATCH 0/3] dma: cppi41: more suspend/resume patches

2013-10-09 Thread Sebastian Andrzej Siewior
* Daniel Mack | 2013-10-01 15:31:08 [+0200]: Patch #1 restores more registers on resume time. Patch #2 is a cosmetic cleanup that emerged while digging through the driver and gaining a basic idea of how it's implemented. Nothing fancy. I'm fine with those two. Patch #3, however, gives me

[PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support

2013-10-09 Thread Robert Baldyga
This patch adds isochronous transfer support. It adds few modifications: - Modify s3c_hsotg_epint() function. Some interrupts are ignored for isochronous endpoints, (e.g. INTknTXFEmpMsk) becouse isochronous request is always transfered in single transaction, which ends with XferCompl

[PATCH 1/1] usb: chipidea: udc: Fix spinlock recursion during bus reset

2013-10-09 Thread Peter Chen
After configuration, the host also possible sends bus reset at any time, at such situation, it will trigger below spinlock recursion dump. This commit unlocks the spinlock before calling gadget's disconnect. BUG: spinlock recursion on CPU#0, swapper/0/0 lock: 0xbf128014, .magic: dead4ead,

Re: [PATCH 1/1] usb: chipidea: udc: Fix spinlock recursion during bus reset

2013-10-09 Thread Greg KH
On Wed, Oct 09, 2013 at 02:39:52PM +0800, Peter Chen wrote: After configuration, the host also possible sends bus reset at any time, at such situation, it will trigger below spinlock recursion dump. This commit unlocks the spinlock before calling gadget's disconnect. BUG: spinlock recursion

Re: [PATCH 1/1] usb: chipidea: udc: Fix calling spin_lock_irqsave at sleep context

2013-10-09 Thread Greg KH
On Tue, Oct 08, 2013 at 10:30:17AM +0800, Peter Chen wrote: Fixing the below dump: root@freescale ~$ modprobe g_serial g_serial gadget: Gadget Serial v2.4 g_serial gadget: g_serial ready BUG: sleeping function called from invalid context at

[PATCH] USB: gadget: s3c-hsotg: add Multi Count support

2013-10-09 Thread Robert Baldyga
This patch adds Multi Count support. It adds few modifications: - Fix s3c_hsotg_set_ep_maxpacket() function. Field wMaxPacketSize of endpoint descriptor is now splitted into maximum packet size value and number of additional transaction per microframe. - Modify s3c_hsotg_write_fifo() function.

Re: [PATCH 1/1] usb: chipidea: udc: Fix calling spin_lock_irqsave at sleep context

2013-10-09 Thread Peter Chen
On Tue, Oct 08, 2013 at 11:58:10PM -0700, Greg KH wrote: On Tue, Oct 08, 2013 at 10:30:17AM +0800, Peter Chen wrote: Fixing the below dump: root@freescale ~$ modprobe g_serial g_serial gadget: Gadget Serial v2.4 g_serial gadget: g_serial ready BUG: sleeping function called from

Re: [PATCH 1/1] usb: chipidea: udc: Fix spinlock recursion during bus reset

2013-10-09 Thread Peter Chen
On Tue, Oct 08, 2013 at 11:58:33PM -0700, Greg KH wrote: On Wed, Oct 09, 2013 at 02:39:52PM +0800, Peter Chen wrote: After configuration, the host also possible sends bus reset at any time, at such situation, it will trigger below spinlock recursion dump. This commit unlocks the spinlock

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-09 Thread Bjørn Mork
Thomas Schäfer tschae...@t-online.de writes: Am Montag, 7. Oktober 2013, 16:04:49 schrieben Sie: Have you verified that the latest version of usb-modeswitch doesn't fix this issue? I think I've seen reports that it does, but it would be good if you could test that out and verify it. May be

Re: [PATCH v2 5/6] Revert ARM: OMAP2+: Provide alias to USB PHY clock

2013-10-09 Thread Roger Quadros
Hi Tony, On 10/08/2013 01:06 PM, Roger Quadros wrote: This reverts commit 741532c4a995be11815cb72d4d7a48f442a22fea. The proper clock reference is provided in device tree so we no longer need this. Could you please Ack this one? I think it is best if it goes through Benoit's tree. cheers,

Re: [PATCH 0/3] dma: cppi41: more suspend/resume patches

2013-10-09 Thread Daniel Mack
On 09.10.2013 08:41, Sebastian Andrzej Siewior wrote: * Daniel Mack | 2013-10-01 15:31:08 [+0200]: Patch #1 restores more registers on resume time. Patch #2 is a cosmetic cleanup that emerged while digging through the driver and gaining a basic idea of how it's implemented. Nothing fancy.

Re: [PATCH 0/3] dma: cppi41: more suspend/resume patches

2013-10-09 Thread Sebastian Andrzej Siewior
On 10/09/2013 09:23 AM, Daniel Mack wrote: Ok, thank you very much for the update :) I can of course test alternative patches if you have any. Could you actually reproduce the issue I described by sending your board to suspend? No, I don't have mem, just freeze. I try to test if this is a

Re: [PATCH 0/3] dma: cppi41: more suspend/resume patches

2013-10-09 Thread Daniel Mack
On 09.10.2013 09:28, Sebastian Andrzej Siewior wrote: On 10/09/2013 09:23 AM, Daniel Mack wrote: Ok, thank you very much for the update :) I can of course test alternative patches if you have any. Could you actually reproduce the issue I described by sending your board to suspend? No, I

Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-09 Thread Daniel Mack
Hi everyone, On 09.10.2013 08:18, Gururaja Hebbar wrote: On Wednesday 09 October 2013 11:33 AM, Fernandes, Joel wrote: Some temporary issues with my mua so forgive any artifacts in this email. On Oct 9, 2013, at 12:14 AM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: On Wednesday 09

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Takashi Iwai
At Tue, 8 Oct 2013 13:38:26 -0400 (EDT), Alan Stern wrote: On Tue, 8 Oct 2013 baum...@hotmail.com wrote: Hello, please help me with the bug for my Logitech Headset; https://bugzilla.kernel.org/show_bug.cgi?id=62691 Bug ID: 62691 Summary: no reset_resume for driver

[PATCH v6 08/14] usb/gadget: f_mass_storage: create fsg_common_set_inquiry_string for use in fsg_common_init

2013-10-09 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Factor a portion of it out. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_mass_storage.c | 29

[PATCH v6 09/14] usb/gadget: f_mass_storage: create fsg_common_run_thread for use in fsg_common_init

2013-10-09 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Factor a portion of it out. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_mass_storage.c | 32

[PATCH v6 06/14] usb/gadget: f_mass_storage: create fsg_common_set_cdev for use in fsg_common_init

2013-10-09 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Factor a portion of it out. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_mass_storage.c | 50

[PATCH v6 12/14] usb/gadget: storage_common: make attribute operations more generic

2013-10-09 Thread Andrzej Pietrasiewicz
Show/store methods for sysfs attributes contain code which can be used also by configfs. Make them abstract the source the lun and rw_semaphore are taken from. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v6 11/14] usb/gadget: mass_storage: convert to new interface of f_mass_storage

2013-10-09 Thread Andrzej Pietrasiewicz
Convert old mass_storage gadget to use the new interface of f_mass_storage so that later the compatibility layer in f_mass_storage can be removed. struct fsg_common is not known to mass_storage.c, so a setter method is added to f_mass_storage. Signed-off-by: Andrzej Pietrasiewicz

[PATCH v6 05/14] usb/gadget: f_mass_storage: create lun handling helpers for use in fsg_common_init

2013-10-09 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Factor portions of it out. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_mass_storage.c | 80

[PATCH v6 10/14] usb/gadget: f_mass_storage: convert to new function interface with backward compatibility

2013-10-09 Thread Andrzej Pietrasiewicz
Converting mass storage to the new function interface requires converting the USB mass storage's function code and its users. This patch converts the f_mass_storage.c to the new function interface. The file is now compiled into a separate usb_f_mass_storage.ko module. The old function interface is

[PATCH v6 07/14] usb/gadget: f_mass_storage: create lun creation helpers for use in fsg_common_init

2013-10-09 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Factor portions of it out. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_mass_storage.c | 238

[PATCH v6 03/14] usb/gadget: f_mass_storage: create fsg_common_setup for use in fsg_common_init

2013-10-09 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Factor a portion of it out. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_mass_storage.c | 40

[PATCH v6 13/14] usb/gadget: storage_common: add methods to show/store 'cdrom' and 'removable'

2013-10-09 Thread Andrzej Pietrasiewicz
This will be required by configfs integration. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/storage_common.c | 42 +++ drivers/usb/gadget/storage_common.h |5 2

[PATCH v6 04/14] usb/gadget: f_mass_storage: create fsg_common_set_num_buffers for use in fsg_common_init

2013-10-09 Thread Andrzej Pietrasiewicz
fsg_common_init is a lengthy function. Factor a portion of it out. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_mass_storage.c | 72

[PATCH v6 02/14] usb/gadget: f_mass_storage: make sysfs interface optional

2013-10-09 Thread Andrzej Pietrasiewicz
When configfs is in place, the luns will not be represented in sysfs, so there will be no struct device associated with a lun. In order to maintain compatibility and allow configfs adoption sysfs is made optional in this patch. As a consequence some debug macros need to be adjusted. Two new

[PATCH v6 00/14] Equivalent of g_mass_storage with configfs

2013-10-09 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into mass storage, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex and phonet. It contains everything that is required to provide the equivalent of g_mass_storage.ko with configfs. Mass storage itself is quite large, so the

[PATCH v6 01/14] usb/gadget: f_mass_storage: create _fsg_common_free_buffers

2013-10-09 Thread Andrzej Pietrasiewicz
When configfs is in place, gadgets will have to be able to free fsg buffers. Add a helper function. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com ---

[PATCH v6 14/14] usb/gadget: f_mass_storage: add configfs support

2013-10-09 Thread Andrzej Pietrasiewicz
From this commit on f_mass_storage is available through configfs. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../ABI/testing/configfs-usb-gadget-mass-storage | 31 ++ drivers/usb/gadget/Kconfig

[PATCH v5 0/1] Equivalent of g_acm_ms.ko with configfs

2013-10-09 Thread Andrzej Pietrasiewicz
Here I present the conversion of everything that is required to provide the equivalent of g_acm_ms.ko with configfs. In fact this series consists of just one patch; everything required to provide the equivalent of g_acm_ms.ko with configfs has been done in the series related to the

[PATCH v5 1/1] usb/gadget: acm_ms: convert to new interface of f_mass_storage

2013-10-09 Thread Andrzej Pietrasiewicz
Convert the legacy acm_ms gadget to use the new function interface of f_mass_storage, so that later the compatibility layer in f_mass_storage can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v5 4/5] usb/gadget: f_mass_storage: remove compatibility layer

2013-10-09 Thread Andrzej Pietrasiewicz
There are no more old interface users left. Remove it. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_mass_storage.c | 150 +-- drivers/usb/gadget/f_mass_storage.h | 21

[PATCH v5 1/5] usb/gadget: multi: convert to new interface of f_ecm

2013-10-09 Thread Andrzej Pietrasiewicz
Convert the legacy multi gadget to the new interface of f_ecm, so that later the compatibility layer in f_ecm can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 +

[PATCH v5 2/5] usb/gadget: multi: convert to new interface of f_rndis

2013-10-09 Thread Andrzej Pietrasiewicz
Convert the legacy multi gadget to the new interface of f_rndis, so that later the compatibility layer in f_rndis can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |3 +-

[PATCH v5 3/5] usb/gadget: multi: convert to new interface of f_mass_storage

2013-10-09 Thread Andrzej Pietrasiewicz
Convert the legacy multi gadget to the new interface of f_mass_storage, so that later the compatibility layer in f_mass_storage can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1

[PATCH v5 5/5] usb/gadget: mass_storage: merge usb_f_mass_storage module with u_ms module

2013-10-09 Thread Andrzej Pietrasiewicz
u_ms.ko is needed only together with usb_f_mass_storage.ko. Merge them. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |7 --- drivers/usb/gadget/Makefile |4 +--- 2 files changed, 1

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Clemens Ladisch
Takashi Iwai wrote: On Tue, 8 Oct 2013 baum...@hotmail.com wrote: https://bugzilla.kernel.org/show_bug.cgi?id=62691 Summary: no reset_resume for driver snd-usb-audio for logitech headset H600 How about simply applying the same resume for reset_resume like below? --- diff --git

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-09 Thread Thomas Schäfer
Am 09.10.2013 09:03, schrieb Bjørn Mork: modprobe cdc_mbim echo 12d1 1f16 /sys/bus/usb/drivers_mbim/new_id has had no effect. Well, it shouldn't have any effect. The driver should already be autoloaded based on the class. Is it not? Does the probe fail? The driver is not already loaded.

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-09 Thread Bjørn Mork
Thomas Schäfer tschae...@t-online.de writes: Am 09.10.2013 09:03, schrieb Bjørn Mork: modprobe cdc_mbim echo 12d1 1f16 /sys/bus/usb/drivers_mbim/new_id has had no effect. Well, it shouldn't have any effect. The driver should already be autoloaded based on the class. Is it not? Does the

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Takashi Iwai
At Wed, 09 Oct 2013 10:41:57 +0200, Clemens Ladisch wrote: Takashi Iwai wrote: On Tue, 8 Oct 2013 baum...@hotmail.com wrote: https://bugzilla.kernel.org/show_bug.cgi?id=62691 Summary: no reset_resume for driver snd-usb-audio for logitech headset H600 How about simply applying the

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Takashi Iwai
At Wed, 09 Oct 2013 11:13:44 +0200, Takashi Iwai wrote: At Wed, 09 Oct 2013 10:41:57 +0200, Clemens Ladisch wrote: Takashi Iwai wrote: On Tue, 8 Oct 2013 baum...@hotmail.com wrote: https://bugzilla.kernel.org/show_bug.cgi?id=62691 Summary: no reset_resume for driver

Re: [PATCH] HID: logitech - lg2ff: Add IDs for Formula Vibration Feedback Wheel

2013-10-09 Thread Jiri Kosina
On Mon, 7 Oct 2013, si...@mungewell.org wrote: The lg2ff force feedback subdriver is used for vibration and HID_GD_MULTIAXIS is set to avoid deadzone like other Logitech wheels. Kconfig description etc are also updated accordingly. Signed-off-by: Elias Vanderstuyft elias@gmail.com

Re: [PATCH 2/2] HID: usbhid: quirk for SiS Touchscreen

2013-10-09 Thread Jiri Kosina
On Wed, 2 Oct 2013, AceLan Kao wrote: BugLink: http://bugs.launchpad.net/bugs/1180881 This device needs to be added to the quirks list with HID_QUIRK_NO_INIT_REPORTS, otherwise it causes 10 seconds timeout during report initialization. [12431.828467] hid-multitouch 0003:0457:1013.0475:

Re: [PATCH 1/2] HID: usbhid: quirk for Synaptics Large Touchccreen

2013-10-09 Thread Jiri Kosina
On Wed, 2 Oct 2013, AceLan Kao wrote: BugLink: http://bugs.launchpad.net/bugs/1180881 Synaptics large touchscreen doesn't support some of the report request while initializing. The unspoorted request will make the device unreachable, and will lead to the following usb_submit_urb() function

Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-09 Thread Joel Fernandes
On 10/09/2013 02:38 AM, Daniel Mack wrote: Hi everyone, On 09.10.2013 08:18, Gururaja Hebbar wrote: On Wednesday 09 October 2013 11:33 AM, Fernandes, Joel wrote: Some temporary issues with my mua so forgive any artifacts in this email. On Oct 9, 2013, at 12:14 AM, Hebbar, Gururaja

Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-09 Thread Joel Fernandes
On 10/09/2013 01:18 AM, Gururaja Hebbar wrote: On Wednesday 09 October 2013 11:33 AM, Fernandes, Joel wrote: Some temporary issues with my mua so forgive any artifacts in this email. On Oct 9, 2013, at 12:14 AM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: On Wednesday 09 October 2013

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Alan Stern
On Wed, 9 Oct 2013, Clemens Ladisch wrote: And why does the kernel whine about the lack of a callback that is documented as being optional? It might indeed be a good idea to change that dev_warn() statement to dev_dbg(). On the other hand, without that message this particular failure might

Re: Fwd: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-10-09 Thread Eric Verdonck
Met vriendelijke groeten, Eric Verdonck Driver Development Option nv, Gaston Geenslaan 14, B-3001 Leuven T: +32 16 311 597 F: +32 16 207 164 E-mail: e.verdo...@option.com Website: www.option.com Disclaimer:http://www.option.com/company/disclaimer.shtml RPR Leuven 0429.375.448 On 10/09/2013

[PATCH 4/4] USB: serial: export usb_serial_generic_write_start

2013-10-09 Thread Johan Hovold
Export usb_serial_generic_write_start which is needed when implementing a custom resume function while still relying on the generic write implementation. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/generic.c | 3 ++- include/linux/usb/serial.h | 2 ++ 2 files changed,

[PATCH 0/2] usb-anchor: avoid usb_wait_anchor_empty_timeout returning too soon

2013-10-09 Thread Hans de Goede
Hi All, While working on uas (to test usb 3 bulk streams) I added a LOGICAL_UNIT_RESET at uas probe time for testing purposes, this exercises the uas driver task mgmt code, and sometimes fails because usb_wait_anchor_empty_timeout (unexpectedly) returns before the last anchored urbs completion

[PATCH 3/4] USB: serial: add memory flags to usb_serial_generic_write_start

2013-10-09 Thread Johan Hovold
Add memory-flags parameter to usb_serial_generic_write_start which is called from write, resume and completion handler, all with different allocation requirements. Note that by using the memory flag to determine when called from the completion handler, everything will work as before even if the

[PATCH 2/4] USB: serial: clean up comments in generic driver

2013-10-09 Thread Johan Hovold
Clean up some comments, drop excessive comments and fix-up style. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/generic.c | 57 +++- 1 file changed, 25 insertions(+), 32 deletions(-) diff --git a/drivers/usb/serial/generic.c

[PATCH 0/4] USB: serial: patches for v3.13

2013-10-09 Thread Johan Hovold
Here are four patches for v3.13. One bugfix, some comment clean ups, and a new memory-flags parameter for usb_serial_generic_write_start, which is also exported. Thanks, Johan Johan Hovold (4): USB: mos7840: fix tiocmget error handling USB: serial: clean up comments in generic driver USB:

[PATCH 1/2] usb-anchor: Ensure poisened gets initialized to 0

2013-10-09 Thread Hans de Goede
And do so in a way which ensures that any fields added in the future will also get properly zero-ed. Signed-off-by: Hans de Goede hdego...@redhat.com --- include/linux/usb.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/usb.h b/include/linux/usb.h index 8ad6e7e..2b5d08b

[PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Hans de Goede
usb_wait_anchor_empty_timeout() should wait till the completion handler has run. Both the zd1211rw driver and the uas driver (in its task mgmt) depend on the completion handler having completed when usb_wait_anchor_empty_timeout() returns, as they read state set by the completion handler after an

[PATCH 1/4] USB: mos7840: fix tiocmget error handling

2013-10-09 Thread Johan Hovold
Make sure to return errors from tiocmget rather than rely on uninitialised stack data. Cc: sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/mos7840.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/serial/mos7840.c

Re: [PATCH v2 5/6] Revert ARM: OMAP2+: Provide alias to USB PHY clock

2013-10-09 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [131009 00:19]: Hi Tony, On 10/08/2013 01:06 PM, Roger Quadros wrote: This reverts commit 741532c4a995be11815cb72d4d7a48f442a22fea. The proper clock reference is provided in device tree so we no longer need this. Could you please Ack this one? I think

[PATCH 0/9] usbfs: Add support for usb3 bulk streams v2

2013-10-09 Thread Hans de Goede
Hi all, Here is v2 of my patch-set for adding bulk stream support to usbfs. I've tested this using an uas device redirected to a qemu vm (which uses usbfs to access the device), and with the xhci fixes I send a while back this works well. This patch set has the following changes compared to v1:

[PATCH 1/9] usb-core: Fix usb_free_streams return value documentation

2013-10-09 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 149cdf1..15d935d 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -2080,8

[PATCH 7/9] usbfs: Add support for bulk stream ids

2013-10-09 Thread Hans de Goede
This patch makes it possible to specify a bulk stream id when submitting an urb using the async usbfs API. It overloads the number_of_packets usbdevfs_urb field for this. This is not pretty, but given other constraints it is the best we can do. The reasoning leading to this goes as follows: 1) We

[PATCH 3/9] usb-core: Track if an endpoint has streams

2013-10-09 Thread Hans de Goede
This is a preparation patch for adding support for bulk streams to usbfs. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/hcd.c | 40 +++- include/linux/usb.h| 1 + 2 files changed, 32 insertions(+), 9 deletions(-) diff --git

[PATCH 6/9] usbfs: proc_do_submiturb use a local variable for number_of_packets

2013-10-09 Thread Hans de Goede
This is a preparation patch for adding support for bulk streams. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/devio.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index

[PATCH 5/9] usbfs: Kill urbs on interface before doing a set_interface

2013-10-09 Thread Hans de Goede
The usb_set_interface documentation says: * Also, drivers must not change altsettings while urbs are scheduled for * endpoints in that interface; all such urbs must first be completed * (perhaps forced by unlinking). For in kernel drivers we trust the drivers to get this right, but we cannot

[PATCH 4/9] usb-core: Free bulk streams on interface release

2013-10-09 Thread Hans de Goede
Documentation/usb/bulk-streams.txt says: All stream IDs will be deallocated when the driver releases the interface, to ensure that drivers that don't support streams will be able to use the endpoint This commit actually implements this. Signed-off-by: Hans de Goede hdego...@redhat.com ---

[PATCH 8/9] usbfs: Add ep_to_host_endpoint helper function

2013-10-09 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/devio.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 00487a0..bfb2821 100644 --- a/drivers/usb/core/devio.c +++

[PATCH v2 0/5] Disable USB 2.0 LPM for buggy devices

2013-10-09 Thread Sarah Sharp
Changes since v1: * Push all manipulation of udev-usb2_hw_lpm_allowed and udev-usb2_hw_lpm_enabled into the USB core: - Move the BESL or internal port check into the USB core. This allows us to avoid exporting the port connection type function. - Move the USB 2.0 Link PM disable

[PATCH v2 1/5] usb: Disable USB 2.0 Link PM before device reset.

2013-10-09 Thread Sarah Sharp
Before the USB core resets a device, we need to disable the L1 timeout for the roothub, if USB 2.0 Link PM is enabled. Otherwise the port may transition into L1 in between descriptor fetches, before we know if the USB device descriptors changed. LPM will be re-enabled after the full device

[PATCH v2 2/5] xhci: Set L1 device slot on USB2 LPM enable/disable.

2013-10-09 Thread Sarah Sharp
To enable USB 2.0 Link Power Management (LPM), the xHCI host controller needs the device slot ID to generate the device address used in L1 entry tokens. That information is set in the L1 device slot ID field of the USB 2.0 LPM registers. Currently, the L1 device slot ID is overwritten when the

[PATCH v2 4/5] xhci: Enable LPM support only for hardwired or BESL devices

2013-10-09 Thread Sarah Sharp
From: Mathias Nyman mathias.ny...@linux.intel.com Some usb3 devices falsely claim they support usb2 hardware Link PM when connected to a usb2 port. We only trust hardwired devices or devices with the later BESL LPM support to be LPM enabled as default. [Note: Sarah re-worked the original patch

[PATCH v2 3/5] usb: Don't enable USB 2.0 Link PM by default.

2013-10-09 Thread Sarah Sharp
How it's supposed to work: -- USB 2.0 Link PM is a lower power state that some newer USB 2.0 devices support. USB 3.0 devices certified by the USB-IF are required to support it if they are plugged into a USB 2.0 only port, or a USB 2.0 cable is used. USB 2.0 Link PM

[PATCH v2 5/5] usb: Push USB2 LPM disable on disconnect into USB core.

2013-10-09 Thread Sarah Sharp
The USB core currently handles enabling and disabling optional USB power management features during device transitions (device suspend/resume, driver bind/unbind, device reset, and device disconnect). Those optional power features include Latency Tolerance Messaging (LTM), USB 3.0 Link PM, and

[PATCH 9/9] usbfs: Add support for allocating / freeing streams

2013-10-09 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/devio.c | 118 ++ include/uapi/linux/usbdevice_fs.h | 7 +++ 2 files changed, 125 insertions(+) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index

[PATCH 2/9] usb-core: Move USB_MAXENDPOINTS definitions to usb.h

2013-10-09 Thread Hans de Goede
So that it can be used in other places too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/config.c | 1 - include/linux/usb.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index

Re: [PATCH 1/2] usb-anchor: Ensure poisened gets initialized to 0

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: And do so in a way which ensures that any fields added in the future will also get properly zero-ed. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send the

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: So I have come up with this patch instead, which adds the ability to suspend wakeups of usb_wait_anchor_empty_timeout() waiters to the usb_anchor functionality, and uses this in __usb_hcd_giveback_urb() to delay wake-ups until the

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-09 Thread Johan Hovold
On Wed, Oct 09, 2013 at 12:57:45PM +0200, Johan Hovold wrote: On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: [...] +#define MX_INT_RS232 0 +#define MX_INT_2W_RS4851 +#define MX_INT_RS422 2 +#define MX_INT_4W_RS485

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Hans de Goede
Hi, Thanks for the quick review! On 10/09/2013 07:00 PM, Oliver Neukum wrote: On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: So I have come up with this patch instead, which adds the ability to suspend wakeups of usb_wait_anchor_empty_timeout() waiters to the usb_anchor

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 19:45 +0200, Hans de Goede wrote: Hi, Thanks for the quick review! On 10/09/2013 07:00 PM, Oliver Neukum wrote: On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: So I have come up with this patch instead, which adds the ability to suspend wakeups of

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: usb_wait_anchor_empty_timeout() should wait till the completion handler has run. Both the zd1211rw driver and the uas driver (in its task mgmt) depend on the completion handler having completed when usb_wait_anchor_empty_timeout()

[PATCH 3/5] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

2013-10-09 Thread Sarah Sharp
From: Xenia Ragiadakou burzalod...@gmail.com The function pci_write_config_dword() sets the appropriate byteordering internally so the value argument should not be converted to little-endian. This bug was found by sparse. This patch is not suitable for stable. Since cpu_to_lei32 is a no-op on

[PATCH 1/5] xhci: Don't enable/disable RWE on bus suspend/resume.

2013-10-09 Thread Sarah Sharp
The RWE bit of the USB 2.0 PORTPMSC register is supposed to enable remote wakeup for devices in the lower power link state L1. It has nothing to do with the device suspend remote wakeup from L2. The RWE bit is designed to be set once (when USB 2.0 LPM is enabled for the port) and cleared only

[PATCH 4/5] usb: xhci: Staticize xhci_del_comp_mod_timer

2013-10-09 Thread Sarah Sharp
From: Sachin Kamat sachin.ka...@linaro.org 'xhci_del_comp_mod_timer' is local to this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Pull Request] xhci: Bug fixes and quirks for 3.12

2013-10-09 Thread Sarah Sharp
The following changes since commit d0e639c9e06d44e713170031fe05fb60ebe680af: Linux 3.12-rc4 (2013-10-06 14:00:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-linus-2012-10-09 for you to fetch changes up to

[PATCH 2/5] xhci: quirk for extra long delay for S4

2013-10-09 Thread Sarah Sharp
From: Oliver Neukum oneu...@suse.de It has been reported that this chipset really cannot sleep without this extraordinary delay. This patch should be backported, in order to ensure this host functions under stable kernels. The last quirk for Fresco Logic hosts (commit

[PATCH 5/5] xhci: Fix spurious wakeups after S5 on Haswell

2013-10-09 Thread Sarah Sharp
From: Takashi Iwai ti...@suse.de Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show mysterious wakeups after shutdown occasionally. After discussing with BIOS engineers, they explained that the new BIOS expects that the wakeup sources are cleared and set to D3 for all wakeup

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-09 Thread Andrew Lunn
On Wed, Oct 09, 2013 at 07:27:42PM +0200, Johan Hovold wrote: On Wed, Oct 09, 2013 at 12:57:45PM +0200, Johan Hovold wrote: On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: [...] +#define MX_INT_RS232 0 +#define MX_INT_2W_RS485 1 +#define

Re: Cannot load snd-usb-audio on 3.12-rc2

2013-10-09 Thread Sarah Sharp
On Thu, Sep 26, 2013 at 10:36:29AM +0200, Takashi Iwai wrote: At Mon, 23 Sep 2013 16:41:07 -0700, Sarah Sharp wrote: The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I plug in my USB headset. It worked fine on 3.11-rc4 (not sure about vanilla 3.11). Trying to

Re: [PATCH v3] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-09 Thread Joel Fernandes
On 10/09/2013 09:12 AM, Joel Fernandes wrote: On 10/09/2013 02:38 AM, Daniel Mack wrote: [..] (And the 'v3' in the subject is really my bad, sorry - I only sent one version of this patch ever). I can respin the patch on top of the proper driver once all the edma bits have eventually been

Re: [PATCH 4/5] usb: xhci: Staticize xhci_del_comp_mod_timer

2013-10-09 Thread Greg Kroah-Hartman
On Wed, Oct 09, 2013 at 12:53:51PM -0700, Sarah Sharp wrote: From: Sachin Kamat sachin.ka...@linaro.org 'xhci_del_comp_mod_timer' is local to this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com ---

Re: [PATCH] xhci-hub.c: handle command_trb that may be link TRB

2013-10-09 Thread Sarah Sharp
Hi Xiao, Thanks for taking the time to submit this patch. Comments below. On Wed, Oct 09, 2013 at 09:42:36AM +0800, Xiao Jin wrote: From: xiao jin jin.x...@intel.com Date: Wed, 9 Oct 2013 09:38:45 +0800 Subject: [PATCH] xhci-hub.c: handle command_trb that may be link TRB I won't be able to

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-09 Thread Laurent Pinchart
Hi Valentine, Thank you for the patch. On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote: This adds RCAR Gen2 USB phy support. The driver configures USB channels 0/2 which are shared between PCI USB hosts and USBHS/USBSS devices. It also controls internal USBHS phy.

Re: [PATCH] xhci: correct the usage of USB_CTRL_SET_TIMEOUT

2013-10-09 Thread Sarah Sharp
Hi Xiao, On Wed, Oct 09, 2013 at 09:25:19AM +0800, Xiao Jin wrote: From: xiao jin jin.x...@intel.com Date: Wed, 9 Oct 2013 09:09:46 +0800 Subject: [PATCH] xhci: correct the usage of USB_CTRL_SET_TIMEOUT As I mentioned in another email, you need to use `git send-email` to avoid putting these

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-09 Thread Thomas Schäfer
Am Mittwoch, 9. Oktober 2013, 10:50:38 schrieben Sie: Could you mount debugfs and send the relevant part of /sys/kernel/debug/usb/devices ? I'd like to verify which configuration and altsettings are currently active (1 and 2 before and after plug in of the device) diff -u 1.txt 2.txt ---

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-09 Thread Valentine
On 10/10/2013 12:32 AM, Laurent Pinchart wrote: Hi Valentine, Hi Laurent, Thank you for the patch. On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote: This adds RCAR Gen2 USB phy support. The driver configures USB channels 0/2 which are shared between PCI USB hosts and

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-09 Thread Laurent Pinchart
Hi Valentine, On Thursday 10 October 2013 01:21:27 Valentine wrote: On 10/10/2013 12:32 AM, Laurent Pinchart wrote: Hi Valentine, Hi Laurent, Thank you for the patch. On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote: This adds RCAR Gen2 USB phy support. The driver

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-09 Thread Bjørn Mork
Thomas Schäfer tschae...@t-online.de writes: +T: Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 3 Spd=480 MxCh= 0 +D: Ver= 2.00 Cls=00(ifc ) Sub=00 Prot=ff MxPS=64 #Cfgs= 2 +P: Vendor=12d1 ProdID=1f16 Rev= 1.02 +S: Manufacturer=Vodafone (Huawei) +S: Product=K5150 +S:

  1   2   >