[PATCH 2/3 v4] Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-03 Thread Chris Ruehl
Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * fix write the real bit not sts value * Set PORTCS_STS and DEVLC_STS only if sts = 1 (prefered solution by Mr. Peter Chen, Maintainer of ChipIdea subsystem) Signed-off-by: Chris Ruehl

[PATCH 1/3 v4] usb: chipidea: Reallocate regmap only if lpm is detected

2013-12-03 Thread Chris Ruehl
usb: chipidea: Reallocate regmap only if lpm is detected The regmap only needs to reallocate if the hw_read on the CAP register shows lpm is used. Therefore the if() statement check the change. Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk Acked-by: Peter Chen peter.c...@freescale.com ---

[PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

2013-12-03 Thread Chris Ruehl
usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init hw_phymode_configure configures the PORTSC registers and allow the following phy_inits to operate on the right parameters. This fix a problem where the UPLI (ISP1504) could not detected, because the Viewport was not available and

[PATCH v4 03/17] usb: phy-mxs: Add auto clock and power setting

2013-12-03 Thread Peter Chen
With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff

[PATCH v4 01/17] usb: doc: phy-mxs: Add more compatible strings

2013-12-03 Thread Peter Chen
Add fsl,imx6q-usbphy for imx6dq and imx6dl, add fsl,imx6sl-usbphy for imx6sl. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Peter Chen
The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 58 ++-- 1 files changed, 49 insertions(+), 9

[PATCH v4 00/17] Add power management support for mxs phy

2013-12-03 Thread Peter Chen
Hi Felipe Shawn, The serial adds power management support for MXS PHY, it includes: - Add three common PHY APIs, .set_wakeup, .notify_suspend, notify_resume. - Related above API implementation at mxs phy driver - misc changes and bug fixes for mxs phy to support low power mode and wakeup. It

[PATCH v4 13/17] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-03 Thread Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH v4 17/17] usb: phy-mxs: do not set PWD.RXPWD1PT1 for low speed connection

2013-12-03 Thread Peter Chen
At very rare cases, the SoF will not send out after resume with low speed connection. The workaround is do not power down PWD.RXPWD1PT1 bit during the suspend. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 47 - 1

[PATCH v4 09/17] usb: phy-mxs: Enable IC fixes for related SoCs

2013-12-03 Thread Peter Chen
Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git

[PATCH v4 11/17] usb: phy-mxs: Add implementation of set_wakeup

2013-12-03 Thread Peter Chen
When we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB PHY and controller, after that, the line state from controller is SE0. Once the PHY is out of power, without calling

[PATCH v4 05/17] ARM: dts: imx6: add anatop phandle for usbphy

2013-12-03 Thread Peter Chen
Add anatop phandle for usbphy Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx6qdl.dtsi |2 ++ arch/arm/boot/dts/imx6sl.dtsi |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi

[PATCH v4 07/17] usb: phy: add notify suspend and resume callback

2013-12-03 Thread Peter Chen
They are used to notify PHY that the controller enters suspend or finishes resume. Signed-off-by: Peter Chen peter.c...@freescale.com --- include/linux/usb/phy.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/include/linux/usb/phy.h

[PATCH v4 15/17] usb: phy-mxs: add controller id

2013-12-03 Thread Peter Chen
It is used to access un-regulator registers according to different controllers. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH v4 16/17] usb: phy-mxs: fix the problem by only using 1st controller's register

2013-12-03 Thread Peter Chen
We fix the problem that we only use the 1st controller's related registers at mxs_phy_disconnect_line, but in fact, it needs to access registers according to different PHYs. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 89

[PATCH v4 12/17] usb: phy-mxs: Add system suspend/resume API

2013-12-03 Thread Peter Chen
We need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to save power. Signed-off-by: Peter Chen peter.c...@freescale.com ---

[PATCH v4 08/17] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-12-03 Thread Peter Chen
Implementation of notify_suspend and notify_resume will be different according to mxs_phy_data-flags. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 55 ++--- 1 files changed, 51 insertions(+), 4 deletions(-) diff

[PATCH v4 06/17] usb: phy-mxs: Add anatop regmap

2013-12-03 Thread Peter Chen
It is needed by imx6 SoC series, but not for imx23 and imx28. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH v4 04/17] usb: doc: phy-mxs: update binding for adding anatop phandle

2013-12-03 Thread Peter Chen
Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH v4 10/17] usb: phy: Add set_wakeup API

2013-12-03 Thread Peter Chen
This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events, like vbus change, dp/dm change and id change. Signed-off-by: Peter Chen peter.c...@freescale.com --- include/linux/usb/phy.h | 16 1 files

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-03 Thread Heikki Krogerus
On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote: @@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_gen_xceiv *nop, { int err; + if (nop-ulpi_vbus 0) { + unsigned int flags = 0; + + if (nop-ulpi_vbus 0x1)

Re: [PATCH v4 09/17] usb: phy-mxs: Enable IC fixes for related SoCs

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 08:37 AM, Peter Chen wrote: Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 20 1 files changed, 20

Re: [PATCH v4 16/17] usb: phy-mxs: fix the problem by only using 1st controller's register

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 08:37 AM, Peter Chen wrote: We fix the problem that we only use the 1st controller's related registers at mxs_phy_disconnect_line, but in fact, it needs to access registers according to different PHYs. Are you fixing the code that has been added in this series before? If so,

Re: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 08:36 AM, Peter Chen wrote: The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 58

RE: [PATCH v4 09/17] usb: phy-mxs: Enable IC fixes for related SoCs

2013-12-03 Thread Peter Chen
On 12/03/2013 08:37 AM, Peter Chen wrote: Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 20 1 files

Re: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Peter Chen
On Tue, Dec 03, 2013 at 09:38:20AM +0100, Marc Kleine-Budde wrote: On 12/03/2013 08:36 AM, Peter Chen wrote: The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [PATCH v4 16/17] usb: phy-mxs: fix the problem by only using 1st controller's register

2013-12-03 Thread Peter Chen
On Tue, Dec 03, 2013 at 09:34:09AM +0100, Marc Kleine-Budde wrote: On 12/03/2013 08:37 AM, Peter Chen wrote: We fix the problem that we only use the 1st controller's related registers at mxs_phy_disconnect_line, but in fact, it needs to access registers according to different PHYs. Are

Re: [PATCH v4 09/17] usb: phy-mxs: Enable IC fixes for related SoCs

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 09:38 AM, Peter Chen wrote: On 12/03/2013 08:37 AM, Peter Chen wrote: Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 20

Re: [PATCH 2/2] Indent with tab instead of spaces.

2013-12-03 Thread Oliver Neukum
On Mon, 2013-12-02 at 13:19 +0100, David Cluytens wrote: From: David Cluytens david.cluytens_...@softathome.com Please see the FAQ on submitting kernel patches in the Documentation directory of the kernel. Your patches need a Signed-off-by line. Regards Oliver -- To

RE: [PATCH v4 09/17] usb: phy-mxs: Enable IC fixes for related SoCs

2013-12-03 Thread Peter Chen
On 12/03/2013 09:38 AM, Peter Chen wrote: On 12/03/2013 08:37 AM, Peter Chen wrote: Some PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [PATCH v4 17/17] usb: phy-mxs: do not set PWD.RXPWD1PT1 for low speed connection

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 08:37 AM, Peter Chen wrote: At very rare cases, the SoF will not send out after resume with low speed connection. The workaround is do not power down PWD.RXPWD1PT1 bit during the suspend. Is this also a fix for newly added code? If so please also squash. Signed-off-by: Peter

RE: [PATCH v4 17/17] usb: phy-mxs: do not set PWD.RXPWD1PT1 for low speed connection

2013-12-03 Thread Peter Chen
On 12/03/2013 08:37 AM, Peter Chen wrote: At very rare cases, the SoF will not send out after resume with low speed connection. The workaround is do not power down PWD.RXPWD1PT1 bit during the suspend. Is this also a fix for newly added code? If so please also squash. No, it is a

Re: [PATCH v4 17/17] usb: phy-mxs: do not set PWD.RXPWD1PT1 for low speed connection

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 10:19 AM, Peter Chen wrote: On 12/03/2013 08:37 AM, Peter Chen wrote: At very rare cases, the SoF will not send out after resume with low speed connection. The workaround is do not power down PWD.RXPWD1PT1 bit during the suspend. Is this also a fix for newly added code? If so

Re: [PATCH] ARM: dts: omap3-beagle: Fix USB host on beagle boards (for 3.13)

2013-12-03 Thread Roger Quadros
Hi Laurent, On 12/03/2013 05:54 AM, Laurent Pinchart wrote: Hi Roger, On Monday 25 November 2013 15:55:45 Roger Quadros wrote: Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply for the USB PHY. As the generic PHY driver can't handle more than one supply at the moment, we

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-03 Thread Roger Quadros
On 12/02/2013 06:28 PM, David Laight wrote: From: Roger Quadros [mailto:rog...@ti.com] On 11/29/2013 03:17 PM, David Laight wrote: ... + timeout = jiffies + msecs_to_jiffies(100); + while (!(usbhs_read(omap-uhh_base, OMAP_UHH_SYSSTATUS) + OMAP_UHH_SYSSTATUS_RESETDONE)) {

RE: [PATCH v4 17/17] usb: phy-mxs: do not set PWD.RXPWD1PT1 for low speed connection

2013-12-03 Thread Peter Chen
On 12/03/2013 10:19 AM, Peter Chen wrote: On 12/03/2013 08:37 AM, Peter Chen wrote: At very rare cases, the SoF will not send out after resume with low speed connection. The workaround is do not power down PWD.RXPWD1PT1 bit during the suspend. Is this also a fix for newly added

Re: [PATCH v2 1/7] usb: dwc3: get usb_phy only if the platform indicates the presence of PHY's

2013-12-03 Thread Kishon Vijay Abraham I
Hi, On Tuesday 26 November 2013 03:02 AM, Felipe Balbi wrote: Hi, On Mon, Nov 11, 2013 at 08:06:12PM +0530, Kishon Vijay Abraham I wrote: diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h index 7db34f0..49ffa6d 100644 --- a/drivers/usb/dwc3/platform_data.h

Re: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Michael Grzeschik
On Tue, Dec 03, 2013 at 03:36:56PM +0800, Peter Chen wrote: The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 58

Re: [PATCH v2 1/7] usb: dwc3: get usb_phy only if the platform indicates the presence of PHY's

2013-12-03 Thread Heikki Krogerus
Hi, On Thu, Oct 17, 2013 at 09:54:26AM -0500, Felipe Balbi wrote: On Wed, Oct 16, 2013 at 04:27:26PM +0300, Roger Quadros wrote: On 10/16/2013 04:10 PM, Kishon Vijay Abraham I wrote: Do you know if there are users of dwc3 other than exynos5250 and omap5? If not, we should get rid of the

Re: [PATCH] ARM: dts: omap3-beagle: Fix USB host on beagle boards (for 3.13)

2013-12-03 Thread Laurent Pinchart
Hi Roger, On Tuesday 03 December 2013 11:36:57 Roger Quadros wrote: On 12/03/2013 05:54 AM, Laurent Pinchart wrote: Hi Roger, On Monday 25 November 2013 15:55:45 Roger Quadros wrote: Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply for the USB PHY. As the generic

Re: [PATCH 1/3 v4] usb: chipidea: Reallocate regmap only if lpm is detected

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 09:01 AM, Chris Ruehl wrote: usb: chipidea: Reallocate regmap only if lpm is detected The regmap only needs to reallocate if the hw_read on the CAP register shows lpm is used. Therefore the if() statement check the change. Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk

Re: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Alexander Shishkin
Greg KH gre...@linuxfoundation.org writes: From: Greg Kroah-Hartman gre...@linuxfoundation.org Alexander isn't able to maintain the Chipidea code anymore, and as Peter has been acting as the de-facto maintainer anyway, make it official. Cc: Alexander Shishkin

Re: [PATCH v2 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-12-03 Thread Heikki Krogerus
Hi Kishon, On Wed, Oct 16, 2013 at 01:24:12AM +0530, Kishon Vijay Abraham I wrote: + count = of_property_match_string(node, phy-names, usb2-phy); + if (count = 0 || (pdata pdata-usb2_generic_phy)) { + dwc-usb2_generic_phy = devm_phy_get(dev, usb2-phy); + if

Strange behavior with ZTE MF821D (and possible other MDM9200 devices)

2013-12-03 Thread Kristian Evensen
Hello, I am currently working on a project where we are building devices that will be placed on moving objects (buses, trains, etc.). The devices are routers (TP-Link WDR4300) based on the Atheros AR9344 SoC and running OpenWrt with kernel 3.10.18. The purpose of these devices is to measure the

[PATCH] Added support for the Lenovo RD02-D400 USB Modem

2013-12-03 Thread David Cluytens
From: David Cluytens david.cluytens_...@softathome.com Signed-off-by: David Cluytens david.cluyt...@gmail.com --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 8ad4e94..e840431

Re: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 06:21 AM, Peter Chen wrote: On Mon, Dec 02, 2013 at 07:38:46PM -0800, Greg KH wrote: On Tue, Dec 03, 2013 at 11:00:30AM +0800, Peter Chen wrote: On Mon, Dec 02, 2013 at 03:43:48PM -0800, Greg KH wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Alexander isn't able to

Re: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 04:38 AM, Greg KH wrote: On Tue, Dec 03, 2013 at 11:00:30AM +0800, Peter Chen wrote: On Mon, Dec 02, 2013 at 03:43:48PM -0800, Greg KH wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Alexander isn't able to maintain the Chipidea code anymore, and as Peter has been

Re: [PATCH] Added support for the Lenovo RD02-D400 USB Modem

2013-12-03 Thread Sergei Shtylyov
Hello. On 03-12-2013 16:34, David Cluytens wrote: From: David Cluytens david.cluytens_...@softathome.com Signed-off-by: David Cluytens david.cluyt...@gmail.com --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

RE: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Peter Chen
On 12/03/2013 06:21 AM, Peter Chen wrote: On Mon, Dec 02, 2013 at 07:38:46PM -0800, Greg KH wrote: On Tue, Dec 03, 2013 at 11:00:30AM +0800, Peter Chen wrote: On Mon, Dec 02, 2013 at 03:43:48PM -0800, Greg KH wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Alexander isn't

RE: [PATCH 1/3 v4] usb: chipidea: Reallocate regmap only if lpm is detected

2013-12-03 Thread Peter Chen
Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk Acked-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index

Re: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 02:54 PM, Peter Chen wrote: Great! Do you have the names for those branches, yet? I'm especially interested in branches for usb and usb-next, which will have only final patches applied. So that these trees don't need to be rebased. I plan to create branch ci-for-usb-next which

[PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-03 Thread Boris BREZILLON
Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com --- drivers/usb/host/ohci-at91.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git

RE: [PATCH v4 02/17] usb: phy-mxs: Add platform judgement code

2013-12-03 Thread Peter Chen
+ +static const struct mxs_phy_data imx23_phy_data = { + .flags = MXS_PHY_ABNORAML_IN_SUSPEND | MXS_PHY_SENDING_SOF_TOO_FAST, +}; ABNORAML? - ABNORMAL My careless, will change. Thanks. Peter + +static const struct mxs_phy_data imx6q_phy_data = { + .flags =

Re: [PATCH 2/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

2013-12-03 Thread Nicolas Ferre
On 03/12/2013 15:07, Boris BREZILLON : Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com

Re: [PATCH 1/3] usb: ohci-at91: fix irq and iomem resource retrieval

2013-12-03 Thread Nicolas Ferre
On 03/12/2013 15:07, Boris BREZILLON : When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resource table. Retrieve resources using the platform_get_resource function instead of direct resource table entries to

Re: [PATCH v2 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-12-03 Thread Kishon Vijay Abraham I
Hi, On Tuesday 03 December 2013 05:29 PM, Heikki Krogerus wrote: Hi Kishon, On Wed, Oct 16, 2013 at 01:24:12AM +0530, Kishon Vijay Abraham I wrote: +count = of_property_match_string(node, phy-names, usb2-phy); +if (count = 0 || (pdata pdata-usb2_generic_phy)) { +

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-03 Thread Nicolas Ferre
On 03/12/2013 15:07, Boris BREZILLON : Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks Boris for these fixes. Alan, Greg, can you take

[PATCH v5 06/16] usb/gadget: f_subset: remove compatibility layer

2013-12-03 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_subset.c | 60

[PATCH v5 01/16] usb/gadget: configfs: allow setting function instance's name

2013-12-03 Thread Andrzej Pietrasiewicz
USB function's configfs config group is created in a generic way in usb/gadget/configfs.c:function_make(), which in turn delegates actual allocation and setup of the USB function instance to a particular implementation, e.g. in f_acm.c. The said implementation does its job in a parameter-less

[PATCH v5 07/16] usb/gadget: g_ffs: convert to new interface of f_rndis

2013-12-03 Thread Andrzej Pietrasiewicz
There is a new interface of f_rndis and g_ffs is the last to use the old one. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/Kconfig |1 +

[PATCH v5 11/16] usb/gadget: FunctionFS: create utility file

2013-12-03 Thread Andrzej Pietrasiewicz
A header file to be used by f_fs.c and g_ffs.c will be required when f_fs.c is converted into a module. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_fs.c |

[PATCH v5 16/16] usb/gadget: FunctionFS: add configfs support

2013-12-03 Thread Andrzej Pietrasiewicz
Add support for using FunctionFS in configfs-based USB gadgets. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- Documentation/ABI/testing/configfs-usb-gadget-ffs |9 +++

[PATCH v5 00/16] Equivalent of g_ffs with configfs

2013-12-03 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into FunctionFS, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet and mass_storage. It contains everything that is required to provide the equivalent of g_ffs.ko with configfs. Configfs support in FunctionFS has been awaited

[PATCH v5 05/16] usb/gadget: g_ffs: convert to new interface of f_subset

2013-12-03 Thread Andrzej Pietrasiewicz
There is a new function interface of f_subset and g_ffs is the last to use the old one. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/Kconfig |1 +

[PATCH v5 14/16] usb/gadget: g_ffs: convert to new interface of f_fs

2013-12-03 Thread Andrzej Pietrasiewicz
Prepare for configfs integration. Use the new interface so that f_fs can be made a module. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/g_ffs.c | 151

[PATCH v5 10/16] usb/gadget: FunctionFS: Remove VLAIS usage from gadget code

2013-12-03 Thread Andrzej Pietrasiewicz
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This alternate patch calculates offsets into the kmalloc-ed memory buffer using macros. The previous patch required multiple

[PATCH v5 04/16] usb/gadget: f_ecm: remove compatibility layer

2013-12-03 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmim Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_ecm.c | 73

[PATCH v5 02/16] usb/gadget: g_ffs: remove a reduntant gfs_ether_setup variable

2013-12-03 Thread Andrzej Pietrasiewicz
Since d6a0143985489e470a118605352f4b18df0ce142 usb: gadget: move the global the_dev variable to their users the_dev variable can be used as a setup done flag; non-NULL meaning setup done, NULL meaning setup not done. Moreover, gether_cleanup() can be safely called with a NULL argument. Corrected

[PATCH v5 13/16] usb/gadget: FunctionFS: convert to new function interface with backward compatibility

2013-12-03 Thread Andrzej Pietrasiewicz
This is required in order to integrate configfs support. f_fs needs to be a separately compiled module and so it needs to use the new interface. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |

[PATCH v5 15/16] usb/gadget: FunctionFS: Remove compatibility layer

2013-12-03 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_fs.c | 114

[PATCH v5 09/16] usb/gadget: rndis: merge u_rndis.ko with usb_f_rndis.ko

2013-12-03 Thread Andrzej Pietrasiewicz
The rndis function's users use only the new interface, so the two modules can be merged. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/Kconfig |7 ---

Re: 答复: Re: 答复: Re: 答复: Re: 答复: Re: 【PATCH】USB:add new zte 3g-modem's pid to option.c

2013-12-03 Thread Greg KH
On Tue, Dec 03, 2013 at 04:50:17PM +0800, zhang.ju...@zte.com.cn wrote: This was in html format, and line-wrapped, with no signed-off-by: line :( And your responses are still in html, making the mailing list reject them. Re:with no signed-off-by: line:(, it means there are no signed-off-by

[PATCH v5 08/16] usb/gadget: f_rndis: remove compatibility layer

2013-12-03 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_rndis.c | 72

Re: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Greg KH
On Tue, Dec 03, 2013 at 01:38:10PM +0100, Marc Kleine-Budde wrote: On 12/03/2013 04:38 AM, Greg KH wrote: On Tue, Dec 03, 2013 at 11:00:30AM +0800, Peter Chen wrote: On Mon, Dec 02, 2013 at 03:43:48PM -0800, Greg KH wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Alexander

[PATCH 2/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

2013-12-03 Thread Boris BREZILLON
Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com --- drivers/usb/host/ohci-at91.c | 24

[PATCH 2/3] ARM: OMAP2+: hwmod: Fix RESET logic

2013-12-03 Thread Roger Quadros
In _ocp_softreset(), after _set_softreset() + write_sysconfig(), the hwmod's sysc_cache will always contain SOFTRESET bit set so all further writes to sysconfig using this cache will initiate a repeated SOFTRESET e.g. enable_sysc(). This is true for OMAP3 like platforms that have RESET_DONE status

[PATCH 1/3] ARM: OMAP4+: hwmod data: Don't prevent RESET of USB Host module

2013-12-03 Thread Roger Quadros
Without this, the USB devices are sometimes not detected on OMAP4 Panda with u-boot v2013.10. Unlike what the comment states, errata i660 does not state that we can't RESET the USB host module. Instead it states that RESET is the only way to recover from a deadlock situation. RESET ensures that

RE: [PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

2013-12-03 Thread Peter Chen
usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init usb: chipidea: put hw_phymode_configure before ci_usb_phy_init Besides, a blank line is needed between your subject and commit log. hw_phymode_configure configures the PORTSC registers and allow the following phy_inits to

[PATCH v2 0/3] ARM: OMAP2+: USB Host bug fixes for 3.13 rc

2013-12-03 Thread Roger Quadros
Hi, This is a follow up solution to the original series in [1] The first patch fixes the OMAP4 Panda USB detection problems on 3.13-rc1 with u-boot v2013.10. The remaining 2 patches are required if SOFTRESET needs to be done for the USB Host module on OMAP3 platforms. Patch 2 fixes the hwmod

[PATCH 3/3] ARM: OMAP3: hwmod data: Don't prevent RESET of USB Host module

2013-12-03 Thread Roger Quadros
Unlike what the comment states, errata i660 does not state that we can't RESET the USB host module. Instead it states that RESET is the only way to recover from a deadlock situation. RESET ensures that the module is in a known good state irrespective of what bootloader does with the module, so it

Re: [3.8-rc3 - 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-12-03 Thread Josh Hunt
On Tue, Nov 26, 2013 at 4:29 PM, Tejun Heo t...@kernel.org wrote: Hello, On Tue, Nov 26, 2013 at 04:12:41PM -0600, Josh Hunt wrote: I should have clarified that I'm not using dm/md in my setup. I know the modules are getting loaded in the log I attached, but root is not a md/dm device. Can

Re: Strange behavior with ZTE MF821D (and possible other MDM9200 devices)

2013-12-03 Thread Bjørn Mork
Kristian Evensen kristian.even...@gmail.com writes: We are currently facing a USB problem that we have not been able to solve. A USB ACK is not sent and the following messages appear in the kernel logs: Thu Nov 21 09:44:53 2013 kern.err kernel: [ 490.60] qmi_wwan 1-1.1.2:1.4: nonzero

Re: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Marc Kleine-Budde
On 12/03/2013 03:21 PM, Greg KH wrote: Ugh, github, really? I'm not going to pull from a github tree, sorry. Can you apply for a kernel.org one? github can be used without all that fancy web-2.0 interface. I know, I use it all the time, even with that interface, that's not what I'm

[PATCH 1/3] usb: ohci-at91: fix irq and iomem resource retrieval

2013-12-03 Thread Boris BREZILLON
When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resource table. Retrieve resources using the platform_get_resource function instead of direct resource table entries to avoid resource type mismatch.

[PATCH 0/3] usb: ohci-at91: various fixes and improvements

2013-12-03 Thread Boris BREZILLON
Hello, This patch series fixes a bug detected in 3.13-rc1 caused by a wrong assumption on platform device resources order in the platform device resource table. It also move the different driver resources (clks and iomem) retrieval to the device managed versions (devm_ functions). Best Regards,

Re: Strange behavior with ZTE MF821D (and possible other MDM9200 devices)

2013-12-03 Thread Kristian Evensen
Hei Bjørn, On Tue, Dec 3, 2013 at 3:37 PM, Bjørn Mork bj...@mork.no wrote: The most likely cause of this is a modem firmware crash. I don't think there is much you can do about that, except trying to avoid the situations which causes the crash or getting another modem. Ok, that is what I

Re: [3.8-rc3 - 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-12-03 Thread Tejun Heo
Hello, On Tue, Dec 03, 2013 at 08:28:43AM -0600, Josh Hunt wrote: You're right. Thanks for pointing this out. I did not realize there was a bug in the init script. The version of initramfs-tools I was using had the following bug:

Re: xhci regression: usb 3.0 hdd disconnects immediately

2013-12-03 Thread Alan Stern
On Mon, 2 Dec 2013, Sarah Sharp wrote: Pleas check this, thi seems to be the exact same problem, but on ubuntu https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1254261 There's many reasons why a USB device would not respond to device descriptor requests, and disconnect. That

Re: some question about EXDEV status in period schedule

2013-12-03 Thread Alan Stern
On Tue, 3 Dec 2013, yoma sophian wrote: This isn't a race condition, because the driver does not terminate isochronous URBs before they are scheduled to end. For example, suppose there was an isochronous URB that was scheduled to transmit packets during microframes 100, 180, 260, and

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-03 Thread Alan Stern
On Tue, 3 Dec 2013, Nicolas Ferre wrote: On 03/12/2013 15:07, Boris BREZILLON : Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com

Re: [PATCH v5 12/16] usb/gadget: FunctionFS: add devices management code

2013-12-03 Thread Michal Nazarewicz
On Tue, Dec 03 2013, Andrzej Pietrasiewicz wrote: This will be required in order to use the new function interface (usb_get_function_instance/usb_put_function_instance) Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyunmgin Park kyungmin.p...@samsung.com Acked-by:

Re: [PATCH v5 14/16] usb/gadget: g_ffs: convert to new interface of f_fs

2013-12-03 Thread Michal Nazarewicz
On Tue, Dec 03 2013, Andrzej Pietrasiewicz wrote: Prepare for configfs integration. Use the new interface so that f_fs can be made a module. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal Nazarewicz

Re: zte_ev not properly handling ZTE AC2726 CDMA modems

2013-12-03 Thread Dan Williams
On Mon, 2013-12-02 at 21:46 -0800, 'Greg KH' wrote: On Mon, Nov 25, 2013 at 07:46:40PM -0800, Dmitry Kunilov wrote: Hi Greg, All of them are the same model (AC2726), device ID is 19d2:fff1. Moving just that one line fixes my problem. Given that fixing this would be good to have, can

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-03 Thread Sergei Shtylyov
Hello. On 12/03/2013 05:07 PM, Boris BREZILLON wrote: Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com --- drivers/usb/host/ohci-at91.c | 32 1 file

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-03 Thread boris brezillon
Hello Sergei, On 03/12/2013 19:01, Sergei Shtylyov wrote: Hello. On 12/03/2013 05:07 PM, Boris BREZILLON wrote: Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com ---

[PATCH v2 1/4] usb: ohci-at91: fix irq and iomem resource retrieval

2013-12-03 Thread Boris BREZILLON
When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resources table. Retrieve resources using the platform_get_resource function instead of direct resource table entries to avoid resource type mismatch.

[PATCH v2 3/4] usb: ohci-at91: use dev variable instead of pdev-dev

2013-12-03 Thread Boris BREZILLON
Make use of the dev variable instead of referencing the dev field of the pdev struct. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/host/ohci-at91.c | 18 +- 1 file changed, 9 insertions(+), 9

Re: Xhci Host not allowed to send get device desc at addr zero

2013-12-03 Thread Sarah Sharp
On Wed, Nov 27, 2013 at 05:07:04PM +0100, Aymen BOUATTAY wrote: Hi Pratyush, Douglas Turner pointed me to this thread discussion http://www.spinics.net/lists/linux-usb/msg95103.html seems there is some issue to use new scheme enumeration with super speed devices Hi Sarah, Any

[PATCH v2 2/4] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

2013-12-03 Thread Boris BREZILLON
Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/host/ohci-at91.c | 24

[PATCH v2 0/4] usb: ohci-at91: various fixes and improvements

2013-12-03 Thread Boris BREZILLON
Hello, This patch series fixes a bug detected in 3.13-rc1 caused by a wrong assumption on platform device resources order in the platform device resource table. It also move the different driver resources (clks and iomem) retrieval to the device managed versions (devm_ functions). Best Regards,

  1   2   >