Re: [PATCH V5 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-11-24 Thread Jassi Brar
On 18 November 2014 at 04:11, Andrew Bresticker abres...@chromium.org wrote: + +static int tegra_xusb_mbox_send_data(struct mbox_chan *chan, void *data) +{ + struct tegra_xusb_mbox *mbox = to_tegra_mbox(chan-mbox); + struct tegra_xusb_mbox_msg *msg = data; + unsigned long

[xHCI bug report]: some USB3.0 devices will be re-enumerated immediately after we safely remove it(but not plug out the cable)

2014-11-24 Thread CobeChen
Hi All, On Intel Z77(Fresco xHCI host controller integrated) platform and VIA VT3456 platform, indeed with almost all the vendor's xHCI host controller, some USB3.0 storage devices, such as WD/HGST TURBO mobile MX3, will be re-enumerated immediately after we safely remove it in Ubuntu

Re: USB: serial: Deletion of an unnecessary check before the function call release_firmware

2014-11-24 Thread Johan Hovold
On Fri, Nov 21, 2014 at 06:59:00PM +0100, Julia Lawall wrote: On Fri, 21 Nov 2014, SF Markus Elfring wrote: diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c index ab1d690..3653ec1 100644 --- a/drivers/usb/serial/mxuport.c +++ b/drivers/usb/serial/mxuport.c

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-24 Thread Oliver Neukum
On Fri, 2014-11-21 at 17:00 -0800, Benson Leung wrote: If devices are already asleep with this flag enabled, that means that they are presently configured for remote wake. Yes, but that doesn't matter. The drivers must be ready for a device being resumed at any time. Remote wakeup just adds

Re: [PATCH V5 07/12] pinctrl: tegra-xusb: Add USB PHY support

2014-11-24 Thread Jassi Brar
On 18 November 2014 at 04:11, Andrew Bresticker abres...@chromium.org wrote: In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI

Re: [PATCH V5 04/12] of: Add NVIDIA Tegra XUSB mailbox binding

2014-11-24 Thread Jassi Brar
On 18 November 2014 at 04:11, Andrew Bresticker abres...@chromium.org wrote: Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra xHCI controller's firmware and the host processor. Signed-off-by: Andrew Bresticker abres...@chromium.org

[PATCH] usb-quirks: Add reset-resume quirk for MS Wireless Laser Mouse 6000

2014-11-24 Thread Hans de Goede
This wireless mouse receiver needs a reset-resume quirk to properly come out of reset. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1165206 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

re: usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-24 Thread Dan Carpenter
Hello Dinh Nguyen, The patch 8d736d8a9c44: usb: dwc2: gadget: Do not fail probe if there isn't a clock node from Nov 11, 2014, leads to the following static checker warning: drivers/usb/dwc2/gadget.c:3436 dwc2_gadget_init() warn: passing zero to 'PTR_ERR'

Re: usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-24 Thread Dan Carpenter
On Mon, Nov 24, 2014 at 01:46:56PM +0300, Dan Carpenter wrote: Hello Dinh Nguyen, The patch 8d736d8a9c44: usb: dwc2: gadget: Do not fail probe if there isn't a clock node from Nov 11, 2014, leads to the following static checker warning: drivers/usb/dwc2/gadget.c:3436

Re: [xHCI bug report]: some USB3.0 devices will be re-enumerated immediately after we safely remove it(but not plug out the cable)

2014-11-24 Thread Lu, Baolu
Hi, Have you tried the latest kernel? Can below commit change anything? commit bb86cf569bbd7ad4dce581a37c7fbd748057e9dc Author: Gavin Guo gavin@canonical.com Date: Fri Jul 18 01:12:13 2014 +0800 usb: Check if port status is equal to RxDetect When using USB 3.0 pen drive

xhci: xhci_handle_cmd_stop_ep might give back urb incorrectly

2014-11-24 Thread Lu, Baolu
Hi Mathias, Alan and all, During xhci handling a completion event for stop endpoint command , xhci_handle_cmd_stop_ep() always gives back a urb with status set to 0. The comment says, /* Doesn't matter what we pass for status, since the core will * just

[PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-11-24 Thread Vivek Gautam
USB and Power regulator on Exynos7 require gpios available in BUS1 pin controller block. So adding the BUS1 pinctrl support. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org --- This patch

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Thierry Reding
On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: When __of_usb_find_phy() fails, it returns -ENODEV - its error code has to be returned by devm_usb_get_phy_by_phandle(). Only when the former function succeeds and try_module_get() fails should -EPROBE_DEFER be returned.

[PATCH V2 2/2] arm64: exynos: Add bus1 pinctrl node on exynos7

2014-11-24 Thread Vivek Gautam
BUS1 pinctrl provides gpios for usb and power regulator available on exynos7-espresso board. So add relevant device node for pinctrl-bus1. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- This patch was part of series: [PATCH

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Felipe Balbi
Hi, On Fri, Nov 21, 2014 at 09:13:00PM +0530, Kiran Raparthy wrote: On 21 November 2014 20:41, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 21, 2014 at 11:31:21AM +0530, Kiran Raparthy wrote: usb: phy: Handle per-PHY event for connnect and disconnect events When usb is connected and

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Felipe Balbi
Hi, On Mon, Nov 24, 2014 at 02:10:41PM +0100, Thierry Reding wrote: On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: When __of_usb_find_phy() fails, it returns -ENODEV - its error code has to be returned by devm_usb_get_phy_by_phandle(). Only when the former function

[PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Felipe Balbi
debugfs_remove() is safe against NULL pointers, so let's remove the unnecessary NULL check before calling it. Cc: Daniel Mack dan...@zonque.org Cc: Robert Jarzmik robert.jarz...@free.fr Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/udc/pxa25x_udc.c | 3 +-- 1 file changed, 1

[PATCH 1/2] usb: gadget: udc: lpc32xx: remove unnecessary NULL check

2014-11-24 Thread Felipe Balbi
debugfs_remove() is safe against NULL pointers, so let's remove the unnecessary NULL check before calling it. Cc: Peter Chen peter.c...@freescale.com Cc: Jingoo Han jg1@samsung.com Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/udc/lpc32xx_udc.c | 3 +-- 1 file changed, 1

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Thierry Reding
On Mon, Nov 24, 2014 at 08:36:46AM -0600, Felipe Balbi wrote: Hi, On Mon, Nov 24, 2014 at 02:10:41PM +0100, Thierry Reding wrote: On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: When __of_usb_find_phy() fails, it returns -ENODEV - its error code has to be returned by

Re: xhci: xhci_handle_cmd_stop_ep might give back urb incorrectly

2014-11-24 Thread Alan Stern
On Mon, 24 Nov 2014, Lu, Baolu wrote: Hi Mathias, Alan and all, During xhci handling a completion event for stop endpoint command , xhci_handle_cmd_stop_ep() always gives back a urb with status set to 0. The comment says, /* Doesn't matter what we pass for status,

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Felipe Balbi
Hi, On Mon, Nov 24, 2014 at 04:16:46PM +0100, Thierry Reding wrote: On Mon, Nov 24, 2014 at 08:36:46AM -0600, Felipe Balbi wrote: Hi, On Mon, Nov 24, 2014 at 02:10:41PM +0100, Thierry Reding wrote: On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: When

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Felipe Balbi
Hi again, On Mon, Nov 24, 2014 at 09:36:21AM -0600, Felipe Balbi wrote: When __of_usb_find_phy() fails, it returns -ENODEV - its error code has to be returned by devm_usb_get_phy_by_phandle(). Only when the former function succeeds and try_module_get() fails should

Re: USB storage device cause usb bus can't enter runtime suspend

2014-11-24 Thread Alan Stern
On Mon, 24 Nov 2014, tianjulin wrote: Hi Stern, 1:Thanks your kind support,but how to turn off media-change polling? echo -1 /sys/block/sdX/events_poll_msecs Replace the X with the drive letter for your card reader. or may I change the polling time for long time to fixed this

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Sumit Semwal
Hi Felipe, On 24 November 2014 at 20:08, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Nov 21, 2014 at 09:13:00PM +0530, Kiran Raparthy wrote: On 21 November 2014 20:41, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 21, 2014 at 11:31:21AM +0530, Kiran Raparthy wrote: usb: phy: Handle

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 09:19:09PM +0530, Sumit Semwal wrote: Hi Felipe, On 24 November 2014 at 20:08, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Nov 21, 2014 at 09:13:00PM +0530, Kiran Raparthy wrote: On 21 November 2014 20:41, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 21,

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Sumit Semwal
On 24 November 2014 at 21:24, Felipe Balbi ba...@ti.com wrote: On Mon, Nov 24, 2014 at 09:19:09PM +0530, Sumit Semwal wrote: Hi Felipe, On 24 November 2014 at 20:08, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Nov 21, 2014 at 09:13:00PM +0530, Kiran Raparthy wrote: On 21 November 2014

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Felipe Balbi
Hi, On Mon, Nov 24, 2014 at 09:45:35PM +0530, Sumit Semwal wrote: On 24 November 2014 at 21:24, Felipe Balbi ba...@ti.com wrote: On Mon, Nov 24, 2014 at 09:19:09PM +0530, Sumit Semwal wrote: Hi Felipe, On 24 November 2014 at 20:08, Felipe Balbi ba...@ti.com wrote: Hi, On Fri,

[RFC PATCH] USB: usbtest: fix wrong buffer_offset() computation

2014-11-24 Thread Sebastian Andrzej Siewior
the following error pops up during testusb -a -t 10 | musb-hdrc musb-hdrc.1.auto: dma_pool_free buffer-128, f134e000/be842000 (bad dma) hcd_buffer_create() creates a few buffers, the smallest has 32 bytes of size. ARCH_KMALLOC_MINALIGN is set to 64 bytes. This combo results in hcd_buffer_alloc()

Re: usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 10:49:57AM -0600, Dinh Nguyen wrote: +CC: Felipe Balbi On 11/24/2014 04:48 AM, Dan Carpenter wrote: On Mon, Nov 24, 2014 at 01:46:56PM +0300, Dan Carpenter wrote: Hello Dinh Nguyen, The patch 8d736d8a9c44: usb: dwc2: gadget: Do not fail probe if there isn't a

Re: [RFC PATCH] USB: usbtest: fix wrong buffer_offset() computation

2014-11-24 Thread Alan Stern
On Mon, 24 Nov 2014, Sebastian Andrzej Siewior wrote: the following error pops up during testusb -a -t 10 | musb-hdrc musb-hdrc.1.auto: dma_pool_free buffer-128, f134e000/be842000 (bad dma) hcd_buffer_create() creates a few buffers, the smallest has 32 bytes of size.

[PATCH] usb: dwc2: remove early return on clock query

2014-11-24 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Since we have assigned clk=NULL, which is a valid clk, we should not be returning when a clock node is not provide. Instead, we should return only when we cannot enable the clock. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com ---

Re: usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-24 Thread Dinh Nguyen
+CC: Felipe Balbi On 11/24/2014 04:48 AM, Dan Carpenter wrote: On Mon, Nov 24, 2014 at 01:46:56PM +0300, Dan Carpenter wrote: Hello Dinh Nguyen, The patch 8d736d8a9c44: usb: dwc2: gadget: Do not fail probe if there isn't a clock node from Nov 11, 2014, leads to the following static checker

Re: [PATCH V5 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-11-24 Thread Andrew Bresticker
On Mon, Nov 24, 2014 at 12:34 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 18 November 2014 at 04:11, Andrew Bresticker abres...@chromium.org wrote: + +static int tegra_xusb_mbox_send_data(struct mbox_chan *chan, void *data) +{ + struct tegra_xusb_mbox *mbox =

[PATCH v3 1/3] usb: phy: introduce usb_phy_set_event interface

2014-11-24 Thread Kiran Raparthy
PHY drivers require a generic interface to handle per-PHY events. usb_phy_set_event interface sets event to phy event. PHY drivers call this interface for each phy event. Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-ker...@vger.kernel.org Cc:

[PATCH v3 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

2014-11-24 Thread Kiran Raparthy
usb: phy: hold wakeupsource when USB is enumerated in peripheral mode Some systems require a mechanism to prevent system to enter into suspend state when USB is connected and enumerated in peripheral mode. This patch provides an interface to hold a wakeupsource to prevent suspend. PHY drivers

[PATCH v3 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Kiran Raparthy
usb: phy: Handle per-PHY event for connnect and disconnect events When usb is connected and enumerated in device mode or when usb is disconnected,call usb_phy_set_event from phy drivers to handle per-PHY event. Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc:

[ANNOUNCE] tree will be closed for v3.19 today

2014-11-24 Thread Felipe Balbi
Hi, I'm caught up with my linux-usb queue and I'm right now running my randbuild tests. I know Tony Lindgren has some pretty important cleanup work coming for MUSB, so I'll wait until the end of the day for that. Tony, if you can't manage to send your patches by today, then we'll delay until

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Sebastian Andrzej Siewior
On 11/18/2014 10:17 PM, Felipe Balbi wrote: while this helps the situation it doesn't solve the problem I'm having with testusb on BBB when host port is connected to peripheral port on the same BBB. Exactly. On the same device. I see the same problem if I connect host to peripheral port on

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Sebastian Andrzej Siewior
On 11/18/2014 10:17 PM, Felipe Balbi wrote: I think the driver is mis-detecting Babble. A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than packet_size bytes. Not really helping, I know… Sebastian -- To

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 06:49:50PM +0100, Sebastian Andrzej Siewior wrote: On 11/18/2014 10:17 PM, Felipe Balbi wrote: I think the driver is mis-detecting Babble. A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device

[PATCH 8/8] usb: musb: Use IS_ENABLED for tusb6010

2014-11-24 Thread Tony Lindgren
This removes the ifdef clutter a bit and saves few lines. It also makes it easier to detect the remaining places where we have conditional building of code done based on if defined for things like DMA. Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/usb/musb/musb_core.c | 2 +-

[PATCH 4/8] usb: musb: Change to use new IO access

2014-11-24 Thread Tony Lindgren
Change to use new IO access. This allows us to build in multiple MUSB glue layers. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/usb/musb/am35x.c | 3 +-

[PATCH 0/8] Allow multiple MUSB glue layers to be built in

2014-11-24 Thread Tony Lindgren
Hi all, I noticed MUSB did not work for me as loadable modules and it was because of the iffdeffery that breaks things with multiple glue layers enabled as loadable modules. I've set up function pointers for the PIO functions that now allow building in multiple glue layers as modules or

[PATCH 7/8] usb: musb: Allow multiple glue layers to be built in

2014-11-24 Thread Tony Lindgren
There's no reason any longer to keep it as a choice now that the IO access has been fixed. Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/usb/musb/Kconfig | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index

[PATCH 5/8] usb: musb: Change end point selection to use new IO access

2014-11-24 Thread Tony Lindgren
This allows the endpoints to work when multiple MUSB glue layers are built in. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Apelete Seketeli apel...@seketeli.net Cc: Lars-Peter Clausen l...@metafoo.de Signed-off-by:

[PATCH 3/8] usb: musb: Populate new IO functions for blackfin

2014-11-24 Thread Tony Lindgren
Populate new IO functions for blackfin Cc: Bryan Wu coolo...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/usb/musb/blackfin.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/drivers/usb/musb/blackfin.c

[PATCH 2/8] usb: musb: Populate new IO functions for tusb6010

2014-11-24 Thread Tony Lindgren
Let's populate the new IO functions for tusb6010 but not use them yet. Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/usb/musb/tusb6010.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/usb/musb/tusb6010.c

Re: [ANNOUNCE] tree will be closed for v3.19 today

2014-11-24 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [141124 09:40]: Hi, I'm caught up with my linux-usb queue and I'm right now running my randbuild tests. I know Tony Lindgren has some pretty important cleanup work coming for MUSB, so I'll wait until the end of the day for that. Tony, if you can't manage to

Re: [PATCH 4/8] usb: musb: Change to use new IO access

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 11:05:02AM -0800, Tony Lindgren wrote: @@ -312,10 +345,40 @@ void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst) ioread8_rep(fifo, dst, len); } } -#endif -#endif /* normal PIO */ +/* + * Old style IO functions + */ +u8

[PATCH 6/8] usb: musb: Pass fifo_mode in platform data

2014-11-24 Thread Tony Lindgren
This allows setting the correct fifo_mode when multiple MUSB glue layers are built-in. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Apelete Seketeli apel...@seketeli.net Cc: Lars-Peter Clausen l...@metafoo.de

[PATCH 1/8] usb: musb: Add function pointers for IO access functions

2014-11-24 Thread Tony Lindgren
MUSB currently breaks badly if we try to build in support for multiple platforms. This also happens if done as loadable modules, which is not nice for distros. Let's fix the issue by adding new struct musb_io for the IO access functions that the platform code can populate. Note that we don't want

Re: [ANNOUNCE] tree will be closed for v3.19 today

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 11:08:39AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [141124 09:40]: Hi, I'm caught up with my linux-usb queue and I'm right now running my randbuild tests. I know Tony Lindgren has some pretty important cleanup work coming for MUSB, so I'll wait

Re: [PATCH 4/8] usb: musb: Change to use new IO access

2014-11-24 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [141124 11:13]: On Mon, Nov 24, 2014 at 11:05:02AM -0800, Tony Lindgren wrote: @@ -312,10 +345,40 @@ void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst) ioread8_rep(fifo, dst, len); } } -#endif -#endif /* normal PIO

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Peter Stuge
Felipe Balbi wrote: A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than packet_size bytes. Not really helping, I know… hmm, why would the device move more than wMaxPacketSize at a time ?

[PATCH] usb: core: buffer: smallest buffer should start at ARCH_DMA_MINALIGN

2014-11-24 Thread Sebastian Andrzej Siewior
the following error pops up during testusb -a -t 10 | musb-hdrc musb-hdrc.1.auto: dma_pool_free buffer-128, f134e000/be842000 (bad dma) hcd_buffer_create() creates a few buffers, the smallest has 32 bytes of size. ARCH_KMALLOC_MINALIGN is set to 64 bytes. This combo results in hcd_buffer_alloc()

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Sebastian Andrzej Siewior
On 11/24/2014 09:39 PM, Peter Stuge wrote: Felipe Balbi wrote: A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than packet_size bytes. Not really helping, I know… hmm, why would the device move more

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Robert Jarzmik
Felipe Balbi ba...@ti.com writes: @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { } while (0) #define remove_debug_files(dev) \ do { \ - if (dev-debugfs_udc) \ - debugfs_remove(dev-debugfs_udc); \ +

Re: [PATCH] usb: core: buffer: smallest buffer should start at ARCH_DMA_MINALIGN

2014-11-24 Thread Alan Stern
On Mon, 24 Nov 2014, Sebastian Andrzej Siewior wrote: the following error pops up during testusb -a -t 10 | musb-hdrc musb-hdrc.1.auto: dma_pool_free buffer-128, f134e000/be842000 (bad dma) hcd_buffer_create() creates a few buffers, the smallest has 32 bytes of size.

Re: [PATCH] usb: core: buffer: smallest buffer should start at ARCH_DMA_MINALIGN

2014-11-24 Thread Sebastian Andrzej Siewior
On 11/24/2014 11:00 PM, Alan Stern wrote: diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c index 684ef70dc09d..a80d1ec8b1b0 100644 --- a/drivers/usb/core/buffer.c +++ b/drivers/usb/core/buffer.c @@ -26,7 +26,11 @@ static const size_t pool_max[HCD_BUFFER_POOLS] = {

Re: [PATCH 5/8] usb: musb: Change end point selection to use new IO access

2014-11-24 Thread Apelete Seketeli
Hi Tony, Thanks for the patch. On Mon, Nov-24-2014 at 11:05:03 AM -0800, Tony Lindgren wrote: This allows the endpoints to work when multiple MUSB glue layers are built in. Applied on top of 3.18-rc6 mainline and tested successfully on JZ4740. Been able to use ethernet-over-usb to access the

Re: [PATCH 6/8] usb: musb: Pass fifo_mode in platform data

2014-11-24 Thread Apelete Seketeli
Hi Tony, Thanks for this one too. On Mon, Nov-24-2014 at 11:05:04 AM -0800, Tony Lindgren wrote: This allows setting the correct fifo_mode when multiple MUSB glue layers are built-in. Applied on top of 3.18-rc6 mainline and tested successfully on JZ4740. Been able to use ethernet-over-usb to

Re: [PATCH 5/8] usb: musb: Change end point selection to use new IO access

2014-11-24 Thread Tony Lindgren
* Apelete Seketeli apel...@seketeli.net [141124 15:40]: Hi Tony, Thanks for the patch. On Mon, Nov-24-2014 at 11:05:03 AM -0800, Tony Lindgren wrote: This allows the endpoints to work when multiple MUSB glue layers are built in. Applied on top of 3.18-rc6 mainline and tested

[PATCH V6 04/12] of: Add NVIDIA Tegra XUSB mailbox binding

2014-11-24 Thread Andrew Bresticker
Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra xHCI controller's firmware and the host processor. Signed-off-by: Andrew Bresticker abres...@chromium.org Reviewed-by: Stephen Warren swar...@nvidia.com Acked-by: Jassi Brar

[PATCH V6 09/12] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2014-11-24 Thread Andrew Bresticker
Add support for the on-chip xHCI host controller present on Tegra SoCs. The controller requires external firmware which must be loaded before using the controller. This driver loads the firmware, starts the controller, and is able to service host-specific messages sent by the controller's

[PATCH V6 06/12] of: Update Tegra XUSB pad controller binding for USB

2014-11-24 Thread Andrew Bresticker
Add new bindings used for USB support by the Tegra XUSB pad controller. This includes additional PHY types, USB-specific pinconfig properties, etc. Signed-off-by: Andrew Bresticker abres...@chromium.org Acked-by: Linus Walleij linus.wall...@linaro.org Reviewed-by: Stephen Warren

[PATCH V6 10/12] ARM: tegra: jetson-tk1: Add xHCI support

2014-11-24 Thread Andrew Bresticker
Assign USB ports previously owned by the EHCI controllers to the xHCI controller. There is a mini-PCIe USB port (UTMI port 1) and a USB A connector (UTMI port 2, USB3 port 0). PCIe lane 0 is used for USB3 port 0. Signed-off-by: Andrew Bresticker abres...@chromium.org Reviewed-by: Stephen Warren

[PATCH V6 11/12] ARM: tegra: Add Tegra124 XUSB mailbox and xHCI controller

2014-11-24 Thread Andrew Bresticker
Add nodes for the Tegra XUSB mailbox and Tegra xHCI controller and add the PHY mailbox channel to the XUSB padctl node. Signed-off-by: Andrew Bresticker abres...@chromium.org Reviewed-by: Stephen Warren swar...@nvidia.com --- No changes from v3/v4/v5. Changes from v2: - Dropped channel specifier

[PATCH V6 08/12] of: Add NVIDIA Tegra xHCI controller binding

2014-11-24 Thread Andrew Bresticker
Add device-tree binding documentation for the xHCI controller present on Tegra124 and later SoCs. Signed-off-by: Andrew Bresticker abres...@chromium.org Reviewed-by: Stephen Warren swar...@nvidia.com --- No changes from v5. Changes from v4: - Updated regulator names, as suggested by Thierry. No

[PATCH V6 07/12] pinctrl: tegra-xusb: Add USB PHY support

2014-11-24 Thread Andrew Bresticker
In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI controller will also send messages intended for the PHY driver, so request and listen

[PATCH V6 12/12] ARM: tegra: venice2: Add xHCI support

2014-11-24 Thread Andrew Bresticker
Assign ports previously owned by the EHCI controllers to the xHCI controller. There are two external USB ports (UTMI ports 0/2 and USB3 ports 0/1) and an internal USB port (UTMI port 1). PCIe lanes 0 and 1 are used by the USB3 ports. Signed-off-by: Andrew Bresticker abres...@chromium.org

[PATCH V6 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-11-24 Thread Andrew Bresticker
The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single physical channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intended for the host-controller

[PATCH V6 02/12] mailbox: Make struct mbox_controller's ops field const

2014-11-24 Thread Andrew Bresticker
The mailbox controller's channel ops ought to be read-only. Signed-off-by: Andrew Bresticker abres...@chromium.org --- No changes from v5. New for v5. --- include/linux/mailbox_controller.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mailbox_controller.h

[PATCH V6 01/12] xhci: Set shared HCD's hcd_priv in xhci_gen_setup

2014-11-24 Thread Andrew Bresticker
xhci_gen_setup() sets the hcd_priv field for the primary HCD, but not for the shared HCD, requiring xHCI host-controller drivers to set it between usb_create_shared_hcd() and usb_add_hcd(). There's no reason xhci_gen_setup() can't set the shared HCD's hcd_priv as well, so move that bit out of the

[PATCH V6 03/12] mailbox: Fix up error handling in mbox_request_channel()

2014-11-24 Thread Andrew Bresticker
From: Benson Leung ble...@chromium.org mbox_request_channel() currently returns EBUSY in the event the controller is not present or if of_xlate() fails, but in neither case is EBUSY really appropriate. Return EPROBE_DEFER if the controller is not yet present and change of_xlate() to return an

[PATCH V6 00/12] Tegra xHCI support

2014-11-24 Thread Andrew Bresticker
This series adds support for xHCI on NVIDIA Tegra SoCs. This includes: - patches 1, 2, and 3: minor cleanups for mailbox framework and xHCI, - patches 4 and 5: adding a driver for the mailbox used to communicate with the xHCI controller's firmware, - patches 6 and 7: extending the XUSB pad

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-24 Thread Benson Leung
Hi Oliver, On Mon, Nov 24, 2014 at 1:13 AM, Oliver Neukum oneu...@suse.de wrote: But there is very little to be gained by switching off remote wakeup. The additional energy consumption devices with remote wakeup enabled will be dwarfed by the energy needed for an additional wakeup. That

net2280: is use_dma_chaining obsolete?

2014-11-24 Thread Ricardo Ribalda Delgado
Hello I cannot make work the parameter use_dma_chaining with g_mass_storage and a usb3380 device. The initial enumeration works, but after a couple of frames the enumeration is restarted. If I compare usbmon with and without the parameter I can see that the device fails to reply to the host.

Re: hard lockup with USB3380

2014-11-24 Thread Ricardo Ribalda Delgado
Hello Could you check if the code is stalled at this loop ? https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/gadget/udc/net2280.c#n2594 Regards! On Thu, Nov 13, 2014 at 3:37 PM, Paul Jones p.jo...@teclyn.com wrote: Hi, using the latest kernel from

Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 09:56:28PM +0100, Sebastian Andrzej Siewior wrote: On 11/24/2014 09:39 PM, Peter Stuge wrote: Felipe Balbi wrote: A babble only occurs when the device side tries to move data without the host asking for anything. It also occurs if the device moves more than

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { } while (0) #define remove_debug_files(dev) \ do { \ - if (dev-debugfs_udc) \ -

Re: [PATCH] usb: ehci-orion: enable big-endian support

2014-11-24 Thread Greg Kroah-Hartman
On Thu, Nov 20, 2014 at 10:12:56AM -0500, Alan Stern wrote: On Wed, 19 Nov 2014, Thomas Petazzoni wrote: Dear Marcin Wojtas, On Thu, 13 Nov 2014 00:49:50 +0100, Marcin Wojtas wrote: This commit fixes ehci-orion operation in big-endian mode by enabling byteswap when accessing

Re: net2280: is use_dma_chaining obsolete?

2014-11-24 Thread Felipe Balbi
On Tue, Nov 25, 2014 at 01:56:38AM +0100, Ricardo Ribalda Delgado wrote: Hello I cannot make work the parameter use_dma_chaining with g_mass_storage and a usb3380 device. The initial enumeration works, but after a couple of frames the enumeration is restarted. If I compare usbmon with and

Re: [PATCH 1/3] USB: host: Remove ehci-octeon and ohci-octeon drivers

2014-11-24 Thread Greg KH
On Thu, Nov 13, 2014 at 10:36:28PM +0100, Andreas Herrmann wrote: From: Alan Stern st...@rowland.harvard.edu Remove special-purpose octeon drivers and instead use ehci-platform and ohci-platform as suggested with http://marc.info/?l=linux-mipsm=140139694721623w=2 [andreas.herrmann:

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-24 Thread Benson Leung
Hi Alan, On Sat, Nov 22, 2014 at 7:55 AM, Alan Stern st...@rowland.harvard.edu wrote: There is no USB wrapper for pm_runtime_idle calls, but one could be added. Still, in the meantime can you check to see what happens if you add pm_runtime_idle(usbhid-intf-dev); in usbhid_close()

Re: xhci: xhci_handle_cmd_stop_ep might give back urb incorrectly

2014-11-24 Thread Lu, Baolu
On 2014年11月24日 23:33, Alan Stern wrote: On Mon, 24 Nov 2014, Lu, Baolu wrote: Hi Mathias, Alan and all, During xhci handling a completion event for stop endpoint command , xhci_handle_cmd_stop_ep() always gives back a urb with status set to 0. The comment says, /* Doesn't

Re: [ANNOUNCE] tree will be closed for v3.19 today

2014-11-24 Thread Felipe Balbi
Hi, On Mon, Nov 24, 2014 at 11:38:47AM -0600, Felipe Balbi wrote: I'm caught up with my linux-usb queue and I'm right now running my randbuild tests. I know Tony Lindgren has some pretty important cleanup work coming for MUSB, so I'll wait until the end of the day for that. Tony, if you

Re: net2280: is use_dma_chaining obsolete?

2014-11-24 Thread Ricardo Ribalda Delgado
Hello Felipe might be better if you can fix the code, instead. We have a better scatter-gather support in the framework itself. As I understand it, the code was designed to reduce the number of irqs when you expect to send X consecutive packages. In that scenario you only want an irq at the

RE: [PATCH 1/2] usb: gadget: udc: lpc32xx: remove unnecessary NULL check

2014-11-24 Thread Peter Chen
debugfs_remove() is safe against NULL pointers, so let's remove the unnecessary NULL check before calling it. Cc: Peter Chen peter.c...@freescale.com Cc: Jingoo Han jg1@samsung.com Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/udc/lpc32xx_udc.c | 3 +-- 1 file

RE: [PATCH v3 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

2014-11-24 Thread Peter Chen
usb: phy: hold wakeupsource when USB is enumerated in peripheral mode Some systems require a mechanism to prevent system to enter into suspend state when USB is connected and enumerated in peripheral mode. This patch provides an interface to hold a wakeupsource to prevent suspend. PHY

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Robert Jarzmik
Felipe Balbi ba...@ti.com writes: On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { } while (0) #define remove_debug_files(dev) \ do { \ - if