Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

Hi Oliver, On Wed, Oct 14, 2015 at 3:33 PM, Oliver Neukum wrote: > On Wed, 2015-10-14 at 15:13 +0200, dave penkler wrote: > > Hi, > > just a few remarks. thank you. > >> >> +static int usbtmc488_ioctl_read_stb(struct usbtmc_device_data *data, >> +

[PATCH] usb: gadget: function: acm: return zlp for OUT setup

From: Jassi Brar We must return 0 for any OUT setup request, otherwise protocol error may occur. Signed-off-by: Jassi Brar --- drivers/usb/gadget/function/f_acm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

On Wed, Oct 14, 2015 at 8:42 PM, Felipe Balbi wrote: > > Hi, > > jaswinder.si...@linaro.org writes: >> From: Jassi Brar >> >> We must return 0 for any OUT setup request, otherwise >> protocol error may occur. > > have you seen any such errors ? > Yes.

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

Hi, Jassi Brar writes: > On Wed, Oct 14, 2015 at 8:42 PM, Felipe Balbi wrote: >> >> Hi, >> >> jaswinder.si...@linaro.org writes: >>> From: Jassi Brar >>> >>> We must return 0 for any OUT setup request, otherwise >>> protocol

Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

Hi dave, [auto build test WARNING on usb/usb-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/dave-penkler/USB-usbtmc-Add-support-for-missing-USBTMC-USB488-spec/20151014-211711 reproduce

Re: musb: communication issue with more than 12 FTDI ports

Hi, On 10/13/2015 01:22 PM, Felipe Balbi wrote: Yegor Yefremov writes: On Mon, Oct 12, 2015 at 11:34 AM, Yegor Yefremov wrote: We have a problem, when using more than 12 FTDI ports. Kernels tried: 3.18.1, 4.2.3 and 4.3-rc5. SoC am335x

Re: musb: communication issue with more than 12 FTDI ports

On 10/14/2015 10:56 AM, Felipe Balbi wrote: Hi, Bin Liu writes: Hi, On 10/13/2015 01:22 PM, Felipe Balbi wrote: Yegor Yefremov writes: On Mon, Oct 12, 2015 at 11:34 AM, Yegor Yefremov wrote: We have a problem, when

Re: musb: communication issue with more than 12 FTDI ports

Hi, Bin Liu writes: > Hi, > > On 10/13/2015 01:22 PM, Felipe Balbi wrote: >> Yegor Yefremov writes: >>> On Mon, Oct 12, 2015 at 11:34 AM, Yegor Yefremov >>> wrote: We have a problem, when using more than 12 FTDI ports.

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

Hi, jaswinder.si...@linaro.org writes: > From: Jassi Brar > > We must return 0 for any OUT setup request, otherwise > protocol error may occur. have you seen any such errors ? composite.c treats >=0 as success: if (value >= 0 && value !=

Re: Fwd: [Bug 105901] OOPS using symbolserial

Am 13.10.2015 um 21:08 schrieb Johan Hovold: On Tue, Oct 13, 2015 at 08:37:58PM +0200, Stephan Althaus wrote: Weitergeleitete Nachricht Betreff:[Bug 105901] OOPS using symbolserial Datum: Tue, 13 Oct 2015 18:05:06 + Von:bugzilla-dae...@bugzilla.kernel.org An:

Re: [RFT PATCH] xhci: don't finish a TD if we get a short transfer event mid TD

On 13.10.2015 23:23, Alexey Brodkin wrote: Hi Mathias, On Fri, 2015-09-18 at 22:45 +0300, Alexey Brodkin wrote: Hi Mathias, On Fri, 2015-09-18 at 18:07 +0300, Mathias Nyman wrote: If the difference is big enough between the bytes asked and received in a bulk tranfer we can get a short

Re: Enumerating the USB device more than the capability of Host in the Linux Platform

Mathias Nyman wrote: > it's possible that the failing "0" returned by xhci_alloc_dev() is > not properly propageated/translated through usb core, the used usb > libarary and whatever other userspace components on top. Does any userspace API receive notification of this failure? I don't think so.

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

Hi, Alan Stern writes: > On Wed, 14 Oct 2015, Jassi Brar wrote: > >> BTW, should the gadget stack ever queue a Non-ZLP as reply to some >> setup request that has USB_DIR_IN not set? > > Yes. If USB_DIR_IN is not set then the control transfer is OUT, so the > gadget

[PATCH] usb: dwc2: host: Fix use after free w/ simultaneous irqs

While plugging / unplugging on a DWC2 host port with "slub_debug=FZPUA" enabled, I found a crash that was quite obviously a use after free. It appears that in some cases when we handle the various sub-cases of HCINT we may end up freeing the QTD. If there is more than one bit set in HCINT we may

Re: Fwd: [Bug 105901] OOPS using symbolserial

On Wed, Oct 14, 2015 at 06:08:23PM +0200, Stephan Althaus wrote: > Am 13.10.2015 um 21:08 schrieb Johan Hovold: > > Please try using a more recent kernel than 4.1.5. The oops you're > > hitting should already have been fixed in mainline (and the fix has also > > been backported to 4.1.8). >

Re: musb: communication issue with more than 12 FTDI ports

Hi, Bin Liu writes: > On 10/14/2015 10:56 AM, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu writes: >>> Hi, >>> >>> On 10/13/2015 01:22 PM, Felipe Balbi wrote: Yegor Yefremov writes: > On Mon, Oct 12, 2015 at 11:34 AM, Yegor

Re: musb: communication issue with more than 12 FTDI ports

Hi, Bin Liu writes: > On 10/14/2015 12:05 PM, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu writes: >>> Felipe, >>> >>> On 10/14/2015 11:25 AM, Felipe Balbi wrote: Hi, Bin Liu writes: > On 10/14/2015 10:56 AM, Felipe Balbi wrote:

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

On Wed, 14 Oct 2015, Jassi Brar wrote: > BTW, should the gadget stack ever queue a Non-ZLP as reply to some > setup request that has USB_DIR_IN not set? Yes. If USB_DIR_IN is not set then the control transfer is OUT, so the gadget needs to queue a request to receive some data from the host.

Re: musb: communication issue with more than 12 FTDI ports

On 10/14/2015 12:19 PM, Felipe Balbi wrote: Hi, Bin Liu writes: On 10/14/2015 12:05 PM, Felipe Balbi wrote: Hi, Bin Liu writes: Felipe, On 10/14/2015 11:25 AM, Felipe Balbi wrote: Hi, Bin Liu writes: On 10/14/2015 10:56 AM, Felipe Balbi

Re: musb: communication issue with more than 12 FTDI ports

On 10/14/2015 12:05 PM, Felipe Balbi wrote: Hi, Bin Liu writes: Felipe, On 10/14/2015 11:25 AM, Felipe Balbi wrote: Hi, Bin Liu writes: On 10/14/2015 10:56 AM, Felipe Balbi wrote: Hi, Bin Liu writes: Hi, On 10/13/2015 01:22 PM, Felipe

Re: musb: communication issue with more than 12 FTDI ports

Hi, Bin Liu writes: > Felipe, > > On 10/14/2015 11:25 AM, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu writes: >>> On 10/14/2015 10:56 AM, Felipe Balbi wrote: Hi, Bin Liu writes: > Hi, > > On 10/13/2015 01:22 PM, Felipe

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

Hi, Jassi Brar writes: > On Wed, Oct 14, 2015 at 9:18 PM, Felipe Balbi wrote: >> >> Hi, >> >> Jassi Brar writes: >>> On Wed, Oct 14, 2015 at 8:42 PM, Felipe Balbi wrote: Hi,

[PATCH v6 2/2] usb: dwc2: refactor common low-level hw code to platform.c

DWC2 module on some platforms needs three additional hardware resources: phy controller, clock and power supply. All of them must be enabled/activated to properly initialize and operate. This was initially handled in s3c-hsotg driver, which has been converted to 'gadget' part of dwc2 driver.

[PATCH v6 1/2] usb: dwc2: remove no longer needed init_mutex

init_mutex is a leftover from the time, when s3c-hsotg driver did not implement proper pull up/down control and emulated it by enabling enabling/disabling usb phy. Proper pull up/down control has been added by commit 5b9451f8c4fbaf0549139755fb45ff2b57975b7f ("usb: dwc2: gadget: use soft-disconnect

Re: [PATCH 14/20] target: Remove the write_pending_status() callback function

On 10/12/2015 8:28 PM, Felipe Balbi wrote: Hi, Bart Van Assche writes: Due to the previous patch the write_pending_status() callback function is no longer called. Hence remove it. Signed-off-by: Bart Van Assche Looks Good

Re: [PATCH v4 2/2] usb: chipidea: imx: refine clock operations to adapt for all platforms

On Wed, Oct 14, 2015 at 10:07:59AM +0200, Marc Kleine-Budde wrote: > On 10/14/2015 03:57 AM, Peter Chen wrote: > > Some i.mx platforms need three clocks to let controller work, but > > others only need one, refine clock operation to adapt for all > > platforms, it fixes a regression found at

Re: Enumerating the USB device more than the capability of Host in the Linux Platform

Hi Currently the Linux xhci driver will always try to enable a slot, if no slot is available xhci will return a "No slot available" error command completion code. If the command completion code is anything else than "Success" for the enable slot command, the driver will print out the

Re: [PATCH v4 2/2] usb: chipidea: imx: refine clock operations to adapt for all platforms

On 10/14/2015 03:57 AM, Peter Chen wrote: > Some i.mx platforms need three clocks to let controller work, but > others only need one, refine clock operation to adapt for all > platforms, it fixes a regression found at i.mx27. > > Signed-off-by: Peter Chen > Tested-by:

Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling

Hi Felipe, On 09/24/2015 06:49 PM, Felipe Balbi wrote: > On Thu, Sep 24, 2015 at 05:23:09PM +0200, Robert Baldyga wrote: >> Move function parameters to struct f_sourcesink to make them per instance >> instead of having them as global variables. Since we can have multiple >> instances of USB

Re: [GIT PULL] On-demand device probing

On Wed, Oct 14, 2015 at 10:34:00AM +0200, Tomeu Vizoso wrote: > git+ssh://git.collabora.co.uk/git/user/tomeu/linux.git > on-demand-probes-for-next In don't think that's the URL you intended to use (also everything looks word wrapped here)? signature.asc Description: PGP signature

[GIT PULL] On-demand device probing

Hi Rob, here is the pull request you asked for, with no changes from the version that I posted last to the list. The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at:

Re: Crash in usb_f_mass_storage

On 14 Oct 2015, at 14:57, Felipe Balbi wrote: > > Hi, > > Paul Jones writes: >> Hi, >> >> On 12 Oct 2015, at 14:16, Felipe Balbi wrote: >> >>> >>> Hi, >>> >>> Paul Jones writes: On 10 Oct 2015, at 16:32, Paul

Re: Crash in usb_f_mass_storage

On Wed, 14 Oct 2015, Paul Jones wrote: > On 12 Oct 2015, at 14:16, Felipe Balbi wrote: > > > > > Hi, > > > > Paul Jones writes: > >> On 10 Oct 2015, at 16:32, Paul Jones wrote: > >> > >>> I came across the following kernel message on

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

On Wed, 14 Oct 2015, Felipe Balbi wrote: > Hi, > > Alan Stern writes: > > On Wed, 14 Oct 2015, Jassi Brar wrote: > > > >> BTW, should the gadget stack ever queue a Non-ZLP as reply to some > >> setup request that has USB_DIR_IN not set? > > > > Yes. If USB_DIR_IN is

Re: Crash in usb_f_mass_storage

Hi, Paul Jones writes: > On 14 Oct 2015, at 14:57, Felipe Balbi wrote: > >> >> Hi, >> >> Paul Jones writes: >>> Hi, >>> >>> On 12 Oct 2015, at 14:16, Felipe Balbi wrote: >>> Hi, Paul Jones

Re: [PATCH] usb: dwc2: host: Fix use after free w/ simultaneous irqs

Hi Douglas, [auto build test WARNING on balbi-usb/next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Douglas-Anderson/usb-dwc2-host-Fix-use-after-free-w-simultaneous-irqs/20151015-024824 reproduce:

[RFC PATCH] usb: dwc2: host: dwc2_check_qtd_still_ok() can be static

Signed-off-by: Fengguang Wu --- hcd_intr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c index 57e71f9d..b31a1fb 100644 --- a/drivers/usb/dwc2/hcd_intr.c +++ b/drivers/usb/dwc2/hcd_intr.c

[PATCH v4] usb: gadget: loopback: Fix looping back logic implementation

Since commit e0857ce58e8658657f5f12fe25272b93cfeb16aa ("usb: gadget: loopback: don't queue requests to bogus endpoints") Loopback function is not realy working as that commit removed all looping back logic. After that commit ep-out works like /dev/null and ep-in works like /dev/zero. This commit

Re: Crash in usb_f_mass_storage

Hi, Paul Jones writes: > Hi, > > On 12 Oct 2015, at 14:16, Felipe Balbi wrote: > >> >> Hi, >> >> Paul Jones writes: >>> On 10 Oct 2015, at 16:32, Paul Jones wrote: >>> I came across the following kernel message

Re: Crash in usb_f_mass_storage

On 12 Oct 2015, at 14:16, Felipe Balbi wrote: > > Hi, > > Paul Jones writes: >> On 10 Oct 2015, at 16:32, Paul Jones wrote: >> >>> I came across the following kernel message on the latest 4.3-rc4 whilst >>> performance testing on a

Re: Crash in usb_f_mass_storage

On 14 Oct 2015, at 15:37, Alan Stern wrote: > On Wed, 14 Oct 2015, Paul Jones wrote: > >> On 12 Oct 2015, at 14:16, Felipe Balbi wrote: >> >>> >>> Hi, >>> >>> Paul Jones writes: On 10 Oct 2015, at 16:32, Paul Jones

Re: Crash in usb_f_mass_storage

On 14 Oct 2015, at 15:37, Alan Stern wrote: > On Wed, 14 Oct 2015, Paul Jones wrote: > >> On 12 Oct 2015, at 14:16, Felipe Balbi wrote: >> >>> >>> Hi, >>> >>> Paul Jones writes: On 10 Oct 2015, at 16:32, Paul Jones

Re: Problems with printk logs and my driver

On 4 October 2015 at 16:28, Alan Stern wrote: > On Sun, 4 Oct 2015, Eric Curtin wrote: > >> Ok so for the fun of it, I changed the VENDOR_ID and DEVICE_ID of my >> keyboard to use the driver for this samsung Wireless keyboard and >> mouse, crazy I know since I have a

[PATCH] usb: dwc2: host: Protect PCGCTL with lock in dwc2_port_resume()

>From code inspection, it appears to be unsafe to do a read-modify-write of PCGCTL in dwc2_port_resume(). Let's make sure the spinlock is held around this operation. Signed-off-by: Douglas Anderson --- drivers/usb/dwc2/hcd.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs

While plugging / unplugging on a DWC2 host port with "slub_debug=FZPUA" enabled, I found a crash that was quite obviously a use after free. It appears that in some cases when we handle the various sub-cases of HCINT we may end up freeing the QTD. If there is more than one bit set in HCINT we may

Re: [RFC PATCH] usb: dwc2: host: dwc2_check_qtd_still_ok() can be static

Hi, On Wed, Oct 14, 2015 at 1:44 PM, kbuild test robot wrote: > > Signed-off-by: Fengguang Wu > --- > hcd_intr.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c > index

[PATCH v4] usb: gadget: loopback: fix: Don't share qlen and buflen between instances

Each instance of loopback function may have different qlen and buflen attributes values. When linking function to configuration those values had been assigned to global variables. Linking other instance to config overwrites those values. This commit moves those values to f_loopback structure to

Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

On Wed, 2015-10-14 at 15:13 +0200, dave penkler wrote: Hi, just a few remarks. > > +static int usbtmc488_ioctl_read_stb(struct usbtmc_device_data *data, > + unsigned long arg) > +{ > + u8 *buffer; > + struct device *dev; > + int rv; > + u8 tag, stb;

Re: [PATCH v2] usb: gadget: f_sourcesink: fix function params handling

Hi, Robert Baldyga writes: > Hi Felipe, > > On 09/24/2015 06:49 PM, Felipe Balbi wrote: >> On Thu, Sep 24, 2015 at 05:23:09PM +0200, Robert Baldyga wrote: >>> Move function parameters to struct f_sourcesink to make them per instance >>> instead of having them as global

Killing USBNET as an independent Konfig option

Hi, would anybody mind me killing the separate config option of usbnet? I can see no sense in having it as a separate option, as it is just infrastructure. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

On Wed, Oct 14, 2015 at 11:18 PM, Alan Stern wrote: > On Wed, 14 Oct 2015, Jassi Brar wrote: > >> BTW, should the gadget stack ever queue a Non-ZLP as reply to some >> setup request that has USB_DIR_IN not set? > > Yes. If USB_DIR_IN is not set then the control

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

On Wed, Oct 14, 2015 at 9:18 PM, Felipe Balbi wrote: > > Hi, > > Jassi Brar writes: >> On Wed, Oct 14, 2015 at 8:42 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> jaswinder.si...@linaro.org writes: From: Jassi Brar

Re: musb: communication issue with more than 12 FTDI ports

Felipe, On 10/14/2015 11:25 AM, Felipe Balbi wrote: Hi, Bin Liu writes: On 10/14/2015 10:56 AM, Felipe Balbi wrote: Hi, Bin Liu writes: Hi, On 10/13/2015 01:22 PM, Felipe Balbi wrote: Yegor Yefremov writes: On Mon, Oct 12,

[PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

Implement support for the USB488 defined READ_STATUS_BYTE and SRQ notifications with ioctl, fasync and poll/select in order to be able to synchronize with variable duration instrument operations. Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and LOCAL_LOCKOUT. Add convenience

Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup

On Wed, Oct 14, 2015 at 10:40 PM, Felipe Balbi wrote: > > Hi, > > Jassi Brar writes: >> On Wed, Oct 14, 2015 at 9:18 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Jassi Brar writes: On Wed, Oct 14, 2015 at 8:42

[PATCH v3] usb: gadget: f_sourcesink: fix function params handling

Move function parameters to struct f_sourcesink to make them per instance instead of having them as global variables. Since we can have multiple instances of USB function we also want to have separate set of parameters for each instance. Signed-off-by: Robert Baldyga ---

Re: Killing USBNET as an independent Konfig option

On Wed, Oct 14, 2015 at 12:45:31PM +0200, Oliver Neukum wrote: > Hi, > > would anybody mind me killing the separate config option > of usbnet? I can see no sense in having it as a separate > option, as it is just infrastructure. No objection from me. -- To unsubscribe from this list: send the