Re: Queries regrading USB-driver software-architecture

2016-08-30 Thread Ajay Garg
Hi Greg. Thanks for your support so far. I also contacted the support-personnel of the pc-in-a-box, and they too suggested upgrading the kernel. So, through yours and theirs inspiration, I did the following :: a) Upgraded from Ubuntu-14.04.2 to Ubuntu-14.04.3. b) Then (on 14.04.3), I upgraded

Re: [PATCH 1/1] mfd: rtsx_usb: avoid setting ucr->current_sg.status

2016-08-30 Thread Lee Jones
On Thu, 11 Aug 2016, Lu Baolu wrote: > Member "status" of struct usb_sg_request is managed by usb core. A > spin lock is used to serialize the change of it. The driver could > check the value of req->status, but should avoid changing it without > the hold of the spinlock. Otherwise, it could

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Guenter Roeck
Hello Heikki, On Tue, Aug 30, 2016 at 11:22:27AM +0300, Heikki Krogerus wrote: > > > > If you are only interested in accessory mode support, maybe we don't need > > the 'type' attribute at all. We could make the 'accessory' attribute always > > visible and display one of "none", "Audio",

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Guenter Roeck
Heikki, On Tue, Aug 30, 2016 at 01:04:37PM +0300, Heikki Krogerus wrote: > Hi Oliver, > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//current_data_role > > > +Date:

[PATCH V3 2/2] usb: phy: phy-brcm-usb: Add Broadcom STB USB Phy driver

2016-08-30 Thread Al Cooper
Add a new USB Phy driver for Broadcom STB SoCs. This driver supports all Broadcom STB ARM SoCs. This driver in combination with the generic ohci, ehci and xhci platform drivers will enable USB1.1, USB2.0 and USB3.0 support. This Phy driver also supports the Broadcom UDC gadget driver.

[PATCH V3 1/2] soc: brcmstb: Add Product ID and Family ID helper functions

2016-08-30 Thread Al Cooper
Signed-off-by: Al Cooper --- drivers/soc/bcm/brcmstb/common.c| 12 include/linux/soc/brcmstb/brcmstb.h | 10 ++ 2 files changed, 22 insertions(+) diff --git a/drivers/soc/bcm/brcmstb/common.c b/drivers/soc/bcm/brcmstb/common.c index 94e7335..454f4c2

[PATCH V3 0/2] Add Broadcom USB PHY driver for Broadcom STB SoCs

2016-08-30 Thread Al Cooper
Add Broadcom USB PHY driver for Broadcom STB SoCs. This driver in combination with the generic ohci, ehci and xhci platform drivers will enable USB1.1, USB2.0 and USB3.0 support. V3 - Rebase to latest V2 - Change compatible name from "brcm,usb-phy" to "brcm,brcmstb-usb-phy" Al Cooper (2):

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Heikki Krogerus
On Tue, Aug 30, 2016 at 06:46:24AM -0700, Guenter Roeck wrote: > On 08/30/2016 03:04 AM, Heikki Krogerus wrote: > > Hi Oliver, > > > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > > +What:

Re: [PATCH] usb: renesas_usbhs: add a compatible string for r8a7796

2016-08-30 Thread Rob Herring
On Wed, Aug 24, 2016 at 04:39:53PM +0900, Yoshihiro Shimoda wrote: > This patch adds support for r8a7796 (R-Car M3-W). > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 + >

Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue

2016-08-30 Thread Petko Manolov
On 16-08-30 22:02:47, Bhaktipriya Shridhar wrote: > The workqueue "pegasus_workqueue" queues a single work item per pegasus > instance and hence it doesn't require execution ordering. Hence, > alloc_workqueue has been used to replace the deprecated > create_singlethread_workqueue instance. > >

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Guenter Roeck
Heikki, On Tue, Aug 30, 2016 at 11:22:27AM +0300, Heikki Krogerus wrote: > > How about if I add the "supports_usb_power_delivery" attribute for the > partners instead to give some details about them. Any objections? > After looking into the code again, I assume the idea is to have the existing

Re: chipidea: udc: kernel panic in isr_setup_status_phase

2016-08-30 Thread Clemens Gruber
On Mon, Aug 29, 2016 at 06:24:03PM +0800, Peter Chen wrote: > Would you please measure the voltage of vbus within 1s at below two > conditions: > > - Just connect cable > - Just disconnect cable We found out that there was a problem with our hardware design! But first, here is the VBUS

Re: [PATCH] usb-storage: MAINTAINERS: Alan Stern is the new maintainer

2016-08-30 Thread Greg KH
On Thu, Aug 25, 2016 at 08:52:38AM -0700, Matthew Dharm wrote: > On Thu, Aug 25, 2016 at 8:30 AM, Alan Stern wrote: > > At Matt Dharm's request, I am taking over maintainership of the > > usb-storage driver. > > Alan is being too modest. I think he's been the de facto

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-08-30 Thread moshe green
I was testing a patchset and I accidently sent it to a mailing list (I only intended to send it to myself) Apologies for the mixup. On 30 August 2016 at 08:36, Greg KH wrote: > On Mon, Aug 29, 2016 at 11:50:01PM +0300, Moshe Green wrote: >> Fix a line length warning found by the

Re: [PATCH v4 08/10] usb: gadget: remove useless parameter in alloc_ep_req()

2016-08-30 Thread Felipe Ferreri Tonello
On 29/08/16 08:55, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: >>> Felipe Ferreri Tonello writes: > "Felipe F. Tonello" writes: >> The default_length parameter of alloc_ep_req was not really

[PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue

2016-08-30 Thread Bhaktipriya Shridhar
The workqueue "pegasus_workqueue" queues a single work item per pegasus instance and hence it doesn't require execution ordering. Hence, alloc_workqueue has been used to replace the deprecated create_singlethread_workqueue instance. The WQ_MEM_RECLAIM flag has been set to ensure forward progress

Re: [PATCH 00/28] media: don't print error when allocating urb fails

2016-08-30 Thread Greg KH
On Thu, Aug 11, 2016 at 11:03:36PM +0200, Wolfram Sang wrote: > This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses > kmalloc which already prints enough information on failure. So, let's simply > remove those "allocation failed" messages from drivers like we did already

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-08-30 Thread Greg KH
On Tue, Aug 30, 2016 at 08:21:28PM +0300, moshe green wrote: > I was testing a patchset and I accidently sent it to a mailing list (I > only intended to send it to myself) > Apologies for the mixup. Ok, but it's odd that this even went to this mailing list, how did that even happen? Anyway, not

crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-08-30 Thread Richard van der Hoff
I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, which hangs the entire system. It appears that the first unplug is successful; the second one normally triggers a crash. The situation is complicated by the fact that this USB bridge is behind a chain of PCI bridges,

Re: [RESEND PATCH, v5 4/5] usb: Add MediaTek USB3 DRD Driver

2016-08-30 Thread Greg Kroah-Hartman
On Fri, Aug 26, 2016 at 05:38:27PM +0800, chunfeng yun wrote: > Hi, > > On Thu, 2016-08-25 at 10:32 +0200, Oliver Neukum wrote: > > On Thu, 2016-08-25 at 11:05 +0800, Chunfeng Yun wrote: > > > This patch adds support for the MediaTek USB3 controller > > > integrated into MT8173. It can be

Re: musb: isoc pkt loss with pwc

2016-08-30 Thread Bin Liu
Hi, On Sun, Aug 28, 2016 at 01:13:55PM +0300, Matwey V. Kornilov wrote: > Hello Bin, > > I would like to start new thread on my issue. Let me recall where the issue > is: > There is 100% frame lost in pwc webcam driver due to lots of > zero-length packages coming from musb driver. What is the

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-08-30 Thread Alan Stern
On Tue, 30 Aug 2016, Richard van der Hoff wrote: > I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, > which hangs the entire system. It appears that the first unplug is > successful; the second one normally triggers a crash. > > The situation is complicated by the fact

Re: [PATCH] usb-storage: MAINTAINERS: Alan Stern is the new maintainer

2016-08-30 Thread Matthew Dharm
On Tue, Aug 30, 2016 at 10:19 AM, Greg KH wrote: > On Thu, Aug 25, 2016 at 08:52:38AM -0700, Matthew Dharm wrote: >> On Thu, Aug 25, 2016 at 8:30 AM, Alan Stern >> wrote: >> > At Matt Dharm's request, I am taking over maintainership of the >> >

Re: musb: isoc pkt loss with pwc

2016-08-30 Thread Matwey V. Kornilov
2016-08-30 21:30 GMT+03:00 Bin Liu : > Hi, > > On Sun, Aug 28, 2016 at 01:13:55PM +0300, Matwey V. Kornilov wrote: >> Hello Bin, >> >> I would like to start new thread on my issue. Let me recall where the issue >> is: >> There is 100% frame lost in pwc webcam driver due to lots of

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-08-30 Thread Rafał Miłecki
On 30 August 2016 at 14:05, Greg KH wrote: > On Fri, Aug 26, 2016 at 05:38:05PM +0200, Rafał Miłecki wrote: >> On 25 August 2016 at 14:49, Greg KH wrote: >> > On Thu, Aug 25, 2016 at 10:03:52AM +0200, Rafał Miłecki wrote: >> >> +static void

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-08-30 Thread Alan Stern
On Tue, 30 Aug 2016, Rafał Miłecki wrote: > Please take a look at Documentation to get some idea of LED triggers: > Documentation/leds/leds-class.txt > > Basically a LED (/sys/class/leds/foo/) can be controller with > "brightness" sysfs file like this: > echo 0 > brightness > echo 5 > brightness

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-08-30 Thread Rafał Miłecki
On 30 August 2016 at 22:54, Alan Stern wrote: > On Tue, 30 Aug 2016, Rafał Miłecki wrote: > >> Please take a look at Documentation to get some idea of LED triggers: >> Documentation/leds/leds-class.txt >> >> Basically a LED (/sys/class/leds/foo/) can be controller with

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-08-30 Thread Richard van der Hoff
On 30/08/16 19:48, Alan Stern wrote: On Tue, 30 Aug 2016, Richard van der Hoff wrote: I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, which hangs the entire system. It appears that the first unplug is successful; the second one normally triggers a crash. Please try

Re: [PATCH V3 2/2] usb: phy: phy-brcm-usb: Add Broadcom STB USB Phy driver

2016-08-30 Thread kbuild test robot
ell-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Al-Cooper/soc-brcmstb-Add-Product-ID-and-Family-ID-helper-functions/20160830-224057 base: https://git.kernel.org/pub/scm/li

Re: [PATCH 2/2] dmaengine: cppi41: Add basic PM runtime support

2016-08-30 Thread Vinod Koul
On Fri, Aug 19, 2016 at 03:59:40PM -0700, Tony Lindgren wrote: > Let's keep the device enabled between cppi41_dma_issue_pending() > and dmaengine_desc_get_callback_invoke() and rely on the PM runtime > autoidle timeout elsewhere. > > As the PM runtime is for whole device, not for each channel, >

Re: [PATCH 1/2] dmaengine: cppi41: Prepare to add PM runtime support

2016-08-30 Thread Vinod Koul
On Fri, Aug 19, 2016 at 03:59:39PM -0700, Tony Lindgren wrote: > Let's just move code from cppi41_dma_issue_pending() to > push_desc_queue() as that's the only call to push_desc_queue(). > > We want to do this for PM runtime as we need to call push_desc_queue() > also for pending queued transfers

Re: Problem(s) with Seagate Backup Plus 4TB portable drive in UAS mode

2016-08-30 Thread Robert Krawitz
On Tue, 30 Aug 2016 12:40:48 +0200, Oliver Neukum wrote: > On Thu, 2016-08-25 at 22:55 -0400, Robert Krawitz wrote: >> Then, when I write large volumes of data to the drive, I get the >> following every few minutes or so, with the drive temporarily >> stalling. The result is that on a drive

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Guenter Roeck
On 08/30/2016 06:11 AM, Heikki Krogerus wrote: Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: Error reporting does not require a synchronous operation. Reporting it in the next read() or write() and making it

Re: [PATCHv6 3/3] mfd: intel_soc_pmic_bxtwc: add support for USB Type-C PHY on WhiskeyCove

2016-08-30 Thread Lee Jones
On Tue, 30 Aug 2016, Lee Jones wrote: > On Mon, 29 Aug 2016, Heikki Krogerus wrote: > > > Intel WhiskeyCove PMIC has also a USB Type-C PHY, so let's > > create a device for it. > > > > Signed-off-by: Heikki Krogerus > > Cc: Lee Jones > >

Re: [GIT PULL] usb: chipidea fixes for v4.8

2016-08-30 Thread Greg KH
On Fri, Aug 19, 2016 at 10:11:22AM +0800, Peter Chen wrote: > The following changes since commit f1f6d9a8b540df22b87a5bf6bc104edaade81f47: > > xhci: don't dereference a xhci member after removing xhci (2016-08-16 > 09:42:47 +0200) > > are available in the git repository at: > >

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Heikki Krogerus
Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: > On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > > Error reporting does not require a synchronous operation. Reporting > > it in the next read() or write() and making it pollable is perfectly > > viable. It

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Guenter Roeck
On 08/30/2016 03:04 AM, Heikki Krogerus wrote: Hi Oliver, On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: +What: /sys/class/typec//current_data_role +Date: June 2016 +Contact: Heikki Krogerus

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Heikki Krogerus
On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > On Tue, 2016-08-30 at 13:04 +0300, Heikki Krogerus wrote: > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > Hi, > > > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > > +What:

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-08-30 Thread Greg KH
On Fri, Aug 26, 2016 at 05:38:05PM +0200, Rafał Miłecki wrote: > On 25 August 2016 at 14:49, Greg KH wrote: > > On Thu, Aug 25, 2016 at 10:03:52AM +0200, Rafał Miłecki wrote: > >> +static void usbport_trig_activate(struct led_classdev *led_cdev) > >> +{ > >> +

Re: [PATCH 1/4] usb: host: xhci: Move the xhci quirks checking to the right place

2016-08-30 Thread Baolin Wang
Hi Mathias, On 18 August 2016 at 15:17, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> It will reset the xhci quirks in xhci_gen_setup() function when xhci try to >> add one hcd, thus we need to move the XHCI_LPM_SUPPORT quirk checking after >>

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-30 Thread Ulf Hansson
On 25 August 2016 at 19:17, Alan Stern wrote: > Ulf: > > Ritesh has collected logs showing that his Realtek RTS5129 USB card > reader (drivers/mfd/rtsx_usb.c, drivers/mmc/host/rtsx_usb_sdmmc.c) goes > into runtime autosuspend every 3 seconds and then immediately

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Oliver Neukum
On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > +What: /sys/class/typec//current_data_role > +Date: June 2016 > +Contact: Heikki Krogerus > +Description: > + The current USB data role the port is operating in. >

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Heikki Krogerus
Hi Guenter, On Mon, Aug 29, 2016 at 11:50:49AM -0700, Guenter Roeck wrote: > Hello Heikki, > > On Mon, Aug 29, 2016 at 05:07:39PM +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > > > Overall this is quite vague and, especially for chargers, most of the > > > > time > > > > misses the

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Heikki Krogerus
Hi Oliver, On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > +What: /sys/class/typec//current_data_role > > +Date: June 2016 > > +Contact: Heikki Krogerus > >

Re: Problem(s) with Seagate Backup Plus 4TB portable drive in UAS mode

2016-08-30 Thread Oliver Neukum
On Thu, 2016-08-25 at 22:55 -0400, Robert Krawitz wrote: > Then, when I write large volumes of data to the drive, I get the > following every few minutes or so, with the drive temporarily > stalling. The result is that on a drive capable of about 120 MB/sec I > actually get 40-60 MB/sec (it

Re: [PATCHv6 3/3] mfd: intel_soc_pmic_bxtwc: add support for USB Type-C PHY on WhiskeyCove

2016-08-30 Thread Lee Jones
On Mon, 29 Aug 2016, Heikki Krogerus wrote: > Intel WhiskeyCove PMIC has also a USB Type-C PHY, so let's > create a device for it. > > Signed-off-by: Heikki Krogerus > Cc: Lee Jones > --- > drivers/mfd/intel_soc_pmic_bxtwc.c | 11

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Oliver Neukum
On Tue, 2016-08-30 at 13:04 +0300, Heikki Krogerus wrote: > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: Hi, > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//current_data_role > > > +Date: June 2016 > > > +Contact: