Re: [PATCH] CB/CBI storage devices not working with CONFIG_VMAP_STACK=y

2016-11-10 Thread Alan Stern
On Thu, 10 Nov 2016, Petr Vandrovec wrote: > Hi, >I've built 4.9.0-rc4 with CONFIG_VMAP_STACK=y, and while I can use bulk > storage drives, I cannot use CB-based USB floppy drive: kernel complains > (once) that DMA address is invalid, and after that log is full of device > resets: > > Nov

[PATCH v2] Fix USB CB/CBI storage devices with CONFIG_VMAP_STACK=y

2016-11-10 Thread Petr Vandrovec
From: Petr Vandrovec Some code (all error handling) submits CDBs that are allocated on the stack. This breaks with CB/CBI code that tries to create URB directly from SCSI command buffer - which happens to be in vmalloced memory with vmalloced kernel stacks. Let's make copy

[PATCH] CB/CBI storage devices not working with CONFIG_VMAP_STACK=y

2016-11-10 Thread Petr Vandrovec
Hi, I've built 4.9.0-rc4 with CONFIG_VMAP_STACK=y, and while I can use bulk storage drives, I cannot use CB-based USB floppy drive: kernel complains (once) that DMA address is invalid, and after that log is full of device resets: Nov 7 12:18:42 petr-dev3 kernel: [ 25.929808] scsi 12:0:0:1:

cdc_acm - fragmented notifications

2016-11-10 Thread Tobias Herzog
Hi, I'm trying to build an usb device conforming to the CDC ACM device class. The device uses an interrupt IN endpoint with a max packet size of 8 bytes. I tried to send a SERIAL_STATE notification to the host (to report parity errors, etc.) and noticed, that it is not handled as I would expect:

Re: [PATHCv10 0/2] USB Type-C Connector class

2016-11-10 Thread Guenter Roeck
On Mon, Sep 19, 2016 at 02:16:55PM +0300, Heikki Krogerus wrote: > The USB Type-C class is meant to provide unified interface to the > userspace to present the USB Type-C ports in a system. > Any idea what is happening with this patch series ? There was no further feedback (at least as far as I

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Tony Lindgren
* Laurent Pinchart [161110 14:26]: > On Thursday 10 Nov 2016 22:29:34 Laurent Pinchart wrote: > Actually disabling CONFIG_USB_MUSB_HDRC gets rid of the problem, quite > understandably. It's not a fix though, just a workaround. Are you interested > in

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
Hi Tony, On Thursday 10 Nov 2016 22:29:34 Laurent Pinchart wrote: > On Thursday 10 Nov 2016 10:50:33 Tony Lindgren wrote: > > * Laurent Pinchart [161110 10:18]: > > > I'll try to give it a go, but right now I'm stuck with a different MUSB > > > problem :-) I'm

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-10 Thread Rob Herring
On Sun, Nov 6, 2016 at 7:56 PM, Chen-Yu Tsai wrote: > On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen wrote: >> On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: >>> Quoting Peter Chen (2016-10-24 18:16:32) >>> > On Mon, Oct 24, 2016 at 12:48:24PM

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
Hi Tony, On Thursday 10 Nov 2016 13:42:34 Tony Lindgren wrote: > * Laurent Pinchart [161110 13:29]: > > I had to disable CONFIG_USB_GADGET is compiling it as a module prevents > > selecting CONFIG_NOP_USB_XCEIV=y, which is a dependency for > >

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
Hi Tony, On Thursday 10 Nov 2016 10:50:33 Tony Lindgren wrote: > * Laurent Pinchart [161110 10:18]: > > I'll try to give it a go, but right now I'm stuck with a different MUSB > > problem :-) I'm trying to boot my panda board over the SMSC95xx ethernet, > > and

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-10 Thread Bjørn Mork
Alan Stern writes: > On Thu, 10 Nov 2016, Kai-Heng Feng wrote: > >> Is there a way to force XHCI run at HighSpeed? > > Yes, like I said above: Use a USB-2 cable instead of a USB-3 cable. It's an m.2 form factor modem, so there most likely isn't any cable involved. But

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Tony Lindgren
* Laurent Pinchart [161110 13:29]: > I had to disable CONFIG_USB_GADGET is compiling it as a module prevents > selecting CONFIG_NOP_USB_XCEIV=y, which is a dependency for > CONFIG_USB_EHCI_HCD_OMAP=m. > > The new configuration resulted in a few changes, among

Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-10 Thread Lu Baolu
Hi Peter, On 11/10/2016 07:44 PM, Peter Zijlstra wrote: > On Thu, Nov 10, 2016 at 09:56:41AM +0100, Thomas Gleixner wrote: >> On Thu, 10 Nov 2016, Lu Baolu wrote: >>> This seems to be a common issue for all early printk drivers. >> No. The other early printk drivers like serial do not have that

Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-10 Thread Lu Baolu
Hi, On 11/10/2016 04:56 PM, Thomas Gleixner wrote: > On Thu, 10 Nov 2016, Lu Baolu wrote: >> On 11/09/2016 05:37 PM, Thomas Gleixner wrote: >>> On Tue, 1 Nov 2016, Lu Baolu wrote: +static void early_xdbc_write(struct console *con, const char *str, u32 n) +{ + int chunk, ret;

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-10 Thread Masahiro Yamada
2016-11-10 22:35 GMT+09:00 Greg Kroah-Hartman : > On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: >> >> sdhci_alloc_host() returns an error pointer when it fails. >> but mmc_alloc_host() cannot. >> >> This series allow to propagate a proper error code

Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-10 Thread Lu Baolu
Hi, On 11/11/2016 10:24 AM, Lu Baolu wrote: >> The only thing you can do to make this work is to prevent printing in NMI >> > context: >> > >> > write() >> > { >> >if (in_nmi()) >> >return; >> > >> >raw_spinlock_irqsave(, flags); >> > >> > >> > That fully

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-10 Thread Chen-Yu Tsai
On Fri, Nov 11, 2016 at 5:42 AM, Rob Herring wrote: > On Sun, Nov 6, 2016 at 7:56 PM, Chen-Yu Tsai wrote: >> On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen wrote: >>> On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: Quoting

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-10 Thread Javier Martinez Canillas
Hello ChenYu On Fri, Nov 11, 2016 at 12:01 AM, Chen-Yu Tsai wrote: > On Fri, Nov 11, 2016 at 5:42 AM, Rob Herring wrote: [snip] >> >> Do you have patches using this already. If not, it is starting to get >> a bit late for v4.10. >> >> I can apply this, but then

[PATCH 1/1] usb: xhci: handle endpoint error caused by TRB error

2016-11-10 Thread Lu Baolu
When xHCI host sees a malformed TRB in a transfer ring, it will generate a transfer event with the completion code set to COMP_TRB_ERR (5), and sets the endpoint state in output endpoint context to EP_STATE_ERROR. The endpoint enters ERROR state as the result. XHCI specification requires that Set

[PATCH v3 3/5] usb: dwc3: gadget: Write GEVNTCOUNT in interrupt

2016-11-10 Thread John Youn
Currently GEVNTCOUNT is written in the threaded interrupt handler while processing each event. This commit moves the GEVNTCOUNT write to the hard IRQ. We then copy the events to a separate buffer for the event handler to read from. This change is in preparation of working around an issue in core

[PATCH v3 1/5] usb: dwc3: Add a check for the DWC_usb3 core

2016-11-10 Thread John Youn
Add a helper function to check if we are running on a DWC_usb3 core. Signed-off-by: John Youn --- drivers/usb/dwc3/core.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index b9903c6..354de24 100644 ---

[PATCH v3 2/5] usb: dwc3: Add a function to check properties

2016-11-10 Thread John Youn
Add a function to check properties and call it from probe. This will allow us to add check code without bloating the probe function. This needs to be done after dwc3_get_properties() and dwc3_core_init() so that all the properties and hardware configs are available. Signed-off-by: John Youn

[PATCH v3 4/5] usb: dwc3: Implement interrupt moderation

2016-11-10 Thread John Youn
Implement interrupt moderation which allows the interrupt rate to be throttled. To enable this feature the dwc->imod_interval must be set to 1 or greater. This value specifies the minimum inter-interrupt interval, in 250 ns increments. A value of 0 disables interrupt moderation. This applies for

[PATCH v3 5/5] usb: dwc3: Workaround for irq mask issue

2016-11-10 Thread John Youn
This is a workaround for STAR 9000961433 which affects only version 3.00a of the DWC_usb3 core. This prevents the controller interrupt from being masked while handling events. Enabling interrupt moderation allows us to work around this issue because once the GEVNTCOUNT.count is written the IRQ is

[PATCH v3 0/5] usb: dwc3: Interrupt moderation

2016-11-10 Thread John Youn
This patch series implements interrupt moderation and also uses it in implementing a workaround for STAR 9000961433. Felipe, I've implemented it with a full copy of the events as it started to get messy with just one. Let me know if you still want just one. v3: * Cache the events between irq

[PATCH 2/2] usb: dwc2: Fix coverity issue in hcd_queue.c

2016-11-10 Thread John Youn
From: Vardan Mikayelyan This fixes the coverity issues related to unreachable code with debugging off. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn --- drivers/usb/dwc2/hcd_queue.c | 69

[PATCH 1/2] usb: dwc2: Fix dead code in hcd.c

2016-11-10 Thread John Youn
From: Vardan Mikayelyan Because usb_pipetype() masks urb->pipe, the default case can never be hit. Remove it. This cleans up a coverity warning. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn ---

[PATCH] usb: dwc3: gadget: Fix dead code writing GCTL.RAMCLKSEL

2016-11-10 Thread John Youn
The register programming code in dwc2_updated_ram_clk_sel() will never be executed. And in fact the entire function can be removed as there is no way to override the default value of GCTL.RAMCLKSEL. Remove the function and add a comment explaining where GCTL.RAMCLKSEL should be programmed if

[PATCH v2 1/1] usb: xhci: handle endpoint error caused by TRB error

2016-11-10 Thread Lu Baolu
When xHCI host sees a malformed TRB in a transfer ring, it will generate a transfer event with the completion code set to COMP_TRB_ERR (5), and sets the endpoint state in output endpoint context to EP_STATE_ERROR. The endpoint enters ERROR state as the result. XHCI specification requires that Set

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
Hello, On Friday 11 Nov 2016 00:27:52 Laurent Pinchart wrote: > On Thursday 10 Nov 2016 13:42:34 Tony Lindgren wrote: > > * Laurent Pinchart [161110 13:29]: > >> I had to disable CONFIG_USB_GADGET is compiling it as a module prevents > >> selecting

Re: [PATCH v9 2/8] power: add power sequence library

2016-11-10 Thread Rafael J. Wysocki
On Tue, Nov 8, 2016 at 3:51 AM, Peter Chen wrote: > We have an well-known problem that the device needs to do some power > sequence before it can be recognized by related host, the typical > example like hard-wired mmc devices and usb devices. > > This power sequence is hard

Re: [PATCH v9 2/8] power: add power sequence library

2016-11-10 Thread Peter Chen
On Fri, Nov 11, 2016 at 02:05:01AM +0100, Rafael J. Wysocki wrote: > On Tue, Nov 8, 2016 at 3:51 AM, Peter Chen wrote: > > We have an well-known problem that the device needs to do some power > > sequence before it can be recognized by related host, the typical > > example

Re: [PATCH 1/1] usb: xhci: handle endpoint error caused by TRB error

2016-11-10 Thread Lu Baolu
Hi, On 11/11/2016 09:03 AM, Lu Baolu wrote: > When xHCI host sees a malformed TRB in a transfer ring, > it will generate a transfer event with the completion > code set to COMP_TRB_ERR (5), and sets the endpoint > state in output endpoint context to EP_STATE_ERROR. > The endpoint enters ERROR

Re: [PATCH v5 00/23] Support qcom's HSIC USB and rewrite USB2 HS support

2016-11-10 Thread Peter Chen
On Tue, Oct 18, 2016 at 01:51:39PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-18 02:31:40) > > On Mon, Oct 17, 2016 at 06:56:13PM -0700, Stephen Boyd wrote: > > > I've also sent separate patches for other minor pieces to make this > > > all work. The full tree can be found here[2],

[PATCH net 0/2] r8152: rx patches

2016-11-10 Thread Hayes Wang
Let the rx sw checksum available and add some checks for rx desc. Hayes Wang (2): r8152: fix the sw rx checksum is unavailable r8152: rx descriptor check drivers/net/usb/r8152.c | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) -- 2.7.4

[PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-10 Thread Hayes Wang
Fix the hw rx checksum is always enabled, and the user couldn't switch it to sw rx checksum. Note that the RTL_VER_01 only supports sw rx checksum only. Besides, the hw rx checksum for RTL_VER_02 is disabled after commit b9a321b48af4 ("r8152: Fix broken RX checksums."). Re-enable it.

[PATCH net 2/2] r8152: rx descriptor check

2016-11-10 Thread Hayes Wang
For some platforms, the data in memory is not the same with the one from the device. That is, the data of memory is unbelievable. The check is used to find out this situation. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 49

[PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-10 Thread Masahiro Yamada
sdhci_alloc_host() returns an error pointer when it fails. but mmc_alloc_host() cannot. This series allow to propagate a proper error code when host-allocation fails. Masahiro Yamada (2): mmc: allow mmc_alloc_host() to return proper error code mmc: tmio: allow tmio_mmc_host_alloc() to

[PATCH 1/2] mmc: allow mmc_alloc_host() to return proper error code

2016-11-10 Thread Masahiro Yamada
Currently, mmc_alloc_host() returns NULL on error, so its callers cannot return anything but -ENOMEM when it fails, assuming the most failure cases are due to memory shortage, but it is not true. Allow mmc_alloc_host() to return an error pointer, then propagate the proper error code to its

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-10 Thread Jon Hunter
Hi Robert, On 29/08/16 14:32, robert.f...@collabora.com wrote: > From: Robert Foss > > From: Allan Chou > > The change fixes AX88772x resume failure by > - Restore incorrect AX88772A PHY registers when resetting > - Need to stop MAC operation when

RE: [PATCH v2 03/30] usb: dwc2: Make the DMA descriptor structure packed

2016-11-10 Thread David Laight
From: John Youn > Sent: 10 November 2016 03:28 > From: Vahram Aharonyan > > Make the DMA descriptor structure packed to guarantee alignment and size > in memory. > > Signed-off-by: John Youn > --- > drivers/usb/dwc2/hw.h | 2 +- > 1 file changed, 1

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
Hi Tony, Thank you for the patches. On Monday 07 Nov 2016 14:50:16 Tony Lindgren wrote: > Hi all, > > Here are musb fixes for the issues that I've been able to track down. > Not sure if these will help with the problem Ladis was seeing as I'm > not able to reproduce that one it seems. > > As

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-10 Thread Greg Kroah-Hartman
On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: > > sdhci_alloc_host() returns an error pointer when it fails. > but mmc_alloc_host() cannot. > > This series allow to propagate a proper error code > when host-allocation fails. Why? What can we really do about the error except

Re: [PATCH 2/2] usb: dwc3: gadget: Remove descriptor arguments to ep_config

2016-11-10 Thread Felipe Balbi
Hi, John Youn writes: > This function has access to the descriptors via the usb_ep. > > Signed-off-by: John Youn > --- > drivers/usb/dwc3/gadget.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v12 0/9] usbip: exporting devices

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:04PM +0900, Nobuo Iwata wrote: > Dear all, > > This series of patches adds exporting device operation to USB/IP. What do you mean by "exporting"? You never really explain that, so again, I don't understand why this patchset is needed :( thanks, greg k-h -- To

Re: [PATCH v12 1/9] usbip: exporting devices: modifications to network header

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:05PM +0900, Nobuo Iwata wrote: > Modification to export and un-export response in > tools/usb/usbip/src/usbip_network.h. It just changes return code type > from int to uint32_t as same as other responses. > > Added export and un-export request/response to >

Re: [PATCH v12 2/9] usbip: exporting devices: modifications to host side libraries

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:06PM +0900, Nobuo Iwata wrote: > usbip_get_device() method in usbip_host_driver_ops was not used. It is > modified as a function to find an exported device for new operations > 'connect' and 'disconnect'. > > bind and unbind function are exported for the new

Re: [PATCH v12 4/9] usbip: exporting devices: new disconnect operation

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:08PM +0900, Nobuo Iwata wrote: > New disconnect operation. We need a lot more text here than just this, as it does not explain why this patch is needed at all :( > > Signed-off-by: Nobuo Iwata > --- > tools/usb/usbip/src/Makefile.am

Re: [PATCH v12 7/9] usbip: exporting devices: new application-side daemon

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:11PM +0900, Nobuo Iwata wrote: > New application(vhci)-side daemon. Again, more text here please. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v4] USB hub_probe: rework ugly goto-into-compound-statement

2016-11-10 Thread Greg Kroah-Hartman
On Wed, Nov 09, 2016 at 06:35:21PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Changes since v3: fix typo > Changes since v2: extract the code to static function >

Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-10 Thread Peter Zijlstra
On Thu, Nov 10, 2016 at 09:56:41AM +0100, Thomas Gleixner wrote: > On Thu, 10 Nov 2016, Lu Baolu wrote: > > This seems to be a common issue for all early printk drivers. > > No. The other early printk drivers like serial do not have that problem as > they simply do: > >while (*buf) { >

Re: [PATCH v6 2/2] usbip: vhci extension: dynamic extension

2016-11-10 Thread Greg KH
On Fri, Sep 30, 2016 at 02:41:54PM +0900, Nobuo Iwata wrote: > Modification for dynamic device registration and unregistration. > > 1. kernel config > > Followings are added. > > USBIP_VHCI_HC_PORTS: Number of ports per USB/IP virtual host > controller. The default is 8 - same as current

Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-10 Thread Baolin Wang
Hi, On 10 November 2016 at 16:20, Sriram Dash wrote: > From: Arnd Bergmann > > The dma ops for dwc3 devices are not set properly. So, use a > physical device sysdev, which will be inherited from parent, > to set the hardware / firmware parameters like dma. >

Re: [PATCH v12 3/9] usbip: exporting devices: new connect operation

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:07PM +0900, Nobuo Iwata wrote: > New connect operation. Again, we need more text. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v12 6/9] usbip: exporting devices: modifications to attach and detach

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:10PM +0900, Nobuo Iwata wrote: > Refactoring to attach and detatch operation. Common parts to new > application(vhci)-side daemon are moved to libsrc/vhci_driver.c. why do this refactoring? please say so why here. thanks, greg k-h -- To unsubscribe from this

Re: [PATCH v12 5/9] usbip: exporting devices: modifications to daemon

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:09PM +0900, Nobuo Iwata wrote: > Refactoring to the daemon. why? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v12 8/9] usbip: exporting devices: change to usbip_list.c

2016-11-10 Thread Greg KH
On Thu, Oct 13, 2016 at 12:52:12PM +0900, Nobuo Iwata wrote: > Correction to wording inconsistency around import and export in > usbip_list.c. > > Please, see also cover letter about wording. there is no cover letter when the commits are merged, so please put it here as well. thanks, greg k-h

Re: [PATCH v2 3/5] usb: dwc3: gadget: Write the event count in interrupt

2016-11-10 Thread Felipe Balbi
Hi, Janusz Dziedzic writes: >> John Youn writes: + dwc3_writel(dwc->regs, DWC3_GEVNTCOUNT(0), count); + >> After that evt->buf[lpos, lpos + count] seems goes back to HW, so >> thread should not rely on this?

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-10 Thread Baolin Wang
Hi On 8 November 2016 at 04:36, NeilBrown wrote: > On Mon, Nov 07 2016, Baolin Wang wrote: > >> On 3 November 2016 at 09:25, NeilBrown wrote: >>> On Tue, Nov 01 2016, Baolin Wang wrote: >> >> I agree with your most opinions, but these are optimization. > > I see

Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-10 Thread Felipe Balbi
Hi, Sriram Dash writes: > From: Arnd Bergmann > > The dma ops for dwc3 devices are not set properly. So, use a > physical device sysdev, which will be inherited from parent, > to set the hardware / firmware parameters like dma. > > Signed-off-by: Arnd

Re: [PATCH 1/2] usb: dwc3: gadget: Remove descriptor arguments to ep_enable

2016-11-10 Thread Felipe Balbi
Hi, John Youn writes: > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index 2322863..b9903c6 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -539,7 +539,6 @@ struct dwc3_ep { > > struct dwc3_trb *trb_pool; >

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-10 Thread Oliver Neukum
On Thu, 2016-11-10 at 12:09 +0100, Bjørn Mork wrote: > Kai-Heng Feng writes: > > On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > >> Oliver Neukum writes: > >> > >>> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: > >>> >

Re: [PATCH v3 00/10] Add DT support for ohci-da8xx

2016-11-10 Thread Greg KH
On Tue, Nov 08, 2016 at 05:37:41PM +0100, Axel Haslam wrote: > Hi, > > On Mon, Nov 7, 2016 at 9:39 PM, Axel Haslam wrote: > > The purpose of this patch series is to add DT support for the davinci > > ohci driver. > > > > To make it easier to review. I will split the

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-10 Thread Alan Stern
On Thu, 10 Nov 2016, Kai-Heng Feng wrote: > Hi, > > On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > > Oliver Neukum writes: > > > >> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: > >> > >>> These problems could very well be caused by running at

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-10 Thread Johan Hovold
On Wed, Nov 09, 2016 at 10:54:38AM -0700, Tony Lindgren wrote: > * Johan Hovold [161109 08:40]: > > On Tue, Nov 08, 2016 at 06:26:07PM -0700, Tony Lindgren wrote: > > > * Johan Hovold [161108 12:03]: > > > > On Tue, Nov 08, 2016 at 10:34:13AM -0700, Tony

Re: Multiple chatty devices on Intel 5 Series/3400 USB2 EHCI controller act erratic

2016-11-10 Thread Alan Stern
On Wed, 9 Nov 2016 sonofa...@openmailbox.org wrote: > Back to our subject, I think there is something we can do for intel dual > EHCI chipsets so that it is easier to debug similar issues in the > future. PCI dumps from the machine that had the issue are needed. I don't see how PCI dumps would

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Tony Lindgren
* Laurent Pinchart [161110 05:46]: > Hi Tony, > > Thank you for the patches. > > On Monday 07 Nov 2016 14:50:16 Tony Lindgren wrote: > > Hi all, > > > > Here are musb fixes for the issues that I've been able to track down. > > Not sure if these will help with

Re: [PATCH v3 00/10] Add DT support for ohci-da8xx

2016-11-10 Thread Axel Haslam
On Thu, Nov 10, 2016 at 1:02 PM, Greg KH wrote: > On Tue, Nov 08, 2016 at 05:37:41PM +0100, Axel Haslam wrote: >> Hi, >> >> On Mon, Nov 7, 2016 at 9:39 PM, Axel Haslam wrote: >> > The purpose of this patch series is to add DT support for the

Re: [PATCH] ARM: OMAP2+: Remove unused MUSB initialization code

2016-11-10 Thread Tony Lindgren
* Laurent Pinchart [161110 10:56]: > Hi Tony, > > On Thursday 10 Nov 2016 10:54:02 Tony Lindgren wrote: > > * Laurent Pinchart [161110 10:43]: > > > With the removal of board-ldp.c and board-rx51.c, the last users of the > >

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-10 Thread Tony Lindgren
* Tony Lindgren [161110 10:50]: > * Johan Hovold [161110 09:04]: > > Yes, and make sure to stop polling in musb_suspend(). Would it be > > possible to use the enable and disable ops for this until then? > > Hmm care to explain a bit more? That is assuming

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-10 Thread Bjørn Mork
Kai-Heng Feng writes: > On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: >> Oliver Neukum writes: >> >>> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >>> These problems could very well be caused by running at SuperSpeed

Re: [PATCH 1/2] usb: dwc3: gadget: Remove descriptor arguments to ep_enable

2016-11-10 Thread John Youn
On 11/10/2016 3:15 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h >> index 2322863..b9903c6 100644 >> --- a/drivers/usb/dwc3/core.h >> +++ b/drivers/usb/dwc3/core.h >> @@ -539,7 +539,6 @@ struct

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-10 Thread Johan Hovold
On Thu, Nov 10, 2016 at 10:41:50AM -0700, Tony Lindgren wrote: > * Johan Hovold [161110 09:04]: > > On Wed, Nov 09, 2016 at 10:54:38AM -0700, Tony Lindgren wrote: > > > * Johan Hovold [161109 08:40]: > > > > On Tue, Nov 08, 2016 at 06:26:07PM -0700, Tony

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
Hi Tony, On Thursday 10 Nov 2016 08:01:52 Tony Lindgren wrote: > * Laurent Pinchart [161110 05:46]: > > On Monday 07 Nov 2016 14:50:16 Tony Lindgren wrote: > > > Hi all, > > > > > > Here are musb fixes for the issues that I've been able to track down. > > >

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
On Thursday 10 Nov 2016 19:18:23 Laurent Pinchart wrote: > On Thursday 10 Nov 2016 08:01:52 Tony Lindgren wrote: > > * Laurent Pinchart [161110 05:46]: > >> On Monday 07 Nov 2016 14:50:16 Tony Lindgren wrote: > >>> Hi all, > >>> > >>> Here are musb fixes for

[PATCH] ARM: OMAP2+: Remove unused MUSB initialization code

2016-11-10 Thread Laurent Pinchart
With the removal of board-ldp.c and board-rx51.c, the last users of the MUSB initialization board code are gone. Remove it. Signed-off-by: Laurent Pinchart --- arch/arm/mach-omap2/Makefile | 1 - arch/arm/mach-omap2/usb-musb.c | 106

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-10 Thread Tony Lindgren
* Johan Hovold [161110 09:04]: > On Wed, Nov 09, 2016 at 10:54:38AM -0700, Tony Lindgren wrote: > > * Johan Hovold [161109 08:40]: > > > On Tue, Nov 08, 2016 at 06:26:07PM -0700, Tony Lindgren wrote: > > > > * Johan Hovold [161108 12:03]: >

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Laurent Pinchart
On Thursday 10 Nov 2016 19:18:23 Laurent Pinchart wrote: > Hi Tony, > > On Thursday 10 Nov 2016 08:01:52 Tony Lindgren wrote: > > * Laurent Pinchart [161110 05:46]: > > > On Monday 07 Nov 2016 14:50:16 Tony Lindgren wrote: > > > > Hi all, > > > > > > > > Here

Re: [PATCH] ARM: OMAP2+: Remove unused MUSB initialization code

2016-11-10 Thread Tony Lindgren
* Laurent Pinchart [161110 10:43]: > With the removal of board-ldp.c and board-rx51.c, the last users of the > MUSB initialization board code are gone. Remove it. Thanks, I have the same patch already from 3 years ago in omap-for-v3.14/omap3-board-removal

Re: [PATCH] ARM: OMAP2+: Remove unused MUSB initialization code

2016-11-10 Thread Laurent Pinchart
Hi Tony, On Thursday 10 Nov 2016 10:54:02 Tony Lindgren wrote: > * Laurent Pinchart [161110 10:43]: > > With the removal of board-ldp.c and board-rx51.c, the last users of the > > MUSB initialization board code are gone. Remove it. > > Thanks, I have the same

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-10 Thread Johan Hovold
On Thu, Nov 10, 2016 at 11:02:35AM -0700, Tony Lindgren wrote: > * Tony Lindgren [161110 10:50]: > > * Johan Hovold [161110 09:04]: > > > Yes, and make sure to stop polling in musb_suspend(). Would it be > > > possible to use the enable and disable ops for

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-11-10 Thread Tony Lindgren
* Laurent Pinchart [161110 10:18]: > I'll try to give it a go, but right now I'm stuck with a different MUSB > problem :-) I'm trying to boot my panda board over the SMSC95xx ethernet, and > have switched gadget support from being compiled in to being compiled

[PATCH v3 3/6] usb: ehci: fsl: use bus->sysdev for DMA configuration

2016-11-10 Thread Sriram Dash
From: Arnd Bergmann For the dual role ehci fsl driver, sysdev will handle the dma config. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash --- Changes in v3: - fix compile errors Changes in v2: - fix compile warnings

[PATCH v3 0/6] inherit dma configuration from parent dev

2016-11-10 Thread Sriram Dash
For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. The idea here is that you pass in the parent of_node along with the child device pointer, so it would behave exactly like the parent already does. The difference is that it also

[PATCH v3 1/6] usb: separate out sysdev pointer from usb_bus

2016-11-10 Thread Sriram Dash
From: Arnd Bergmann For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. The idea here is that you pass in the parent of_node along with the child device pointer, so it would behave exactly like the parent already

[PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-10 Thread Sriram Dash
From: Arnd Bergmann The dma ops for dwc3 devices are not set properly. So, use a physical device sysdev, which will be inherited from parent, to set the hardware / firmware parameters like dma. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash

[PATCH v3 2/6] usb: chipidea: use bus->sysdev for DMA configuration

2016-11-10 Thread Sriram Dash
From: Arnd Bergmann Set the dma for chipidea from sysdev. This is inherited from its parent node. Also, do not set dma mask for child as it is not required now. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash Acked-by: Peter Chen

[PATCH v3 4/6] usb: xhci: use bus->sysdev for DMA configuration

2016-11-10 Thread Sriram Dash
From: Arnd Bergmann For xhci-hcd platform device, all the DMA parameters are not configured properly, notably dma ops for dwc3 devices. So, set the dma for xhci from sysdev. sysdev is pointing to device that is known to the system firmware or hardware. Signed-off-by: Arnd

[PATCH v3 6/6] usb: dwc3: Do not set dma coherent mask

2016-11-10 Thread Sriram Dash
From: Arnd Bergmann The dma mask is correctly set up by the DT probe function, no need to override it any more. Signed-off-by: Arnd Bergmann Signed-off-by: Sriram Dash --- Changes in v3: - No update Changes in v2: - club the cleanup for

Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-10 Thread Thomas Gleixner
On Thu, 10 Nov 2016, Lu Baolu wrote: > On 11/09/2016 05:37 PM, Thomas Gleixner wrote: > > On Tue, 1 Nov 2016, Lu Baolu wrote: > >> +static void early_xdbc_write(struct console *con, const char *str, u32 n) > >> +{ > >> + int chunk, ret; > >> + static char buf[XDBC_MAX_PACKET]; > >> + int use_cr

[patch] usb: xhci-mem: use passed in GFP flags instead of GFP_KERNEL

2016-11-10 Thread Dan Carpenter
We normally use the passed in gfp flags for allocations, it's just these two which were missed. Fixes: 22d45f01a836 ("usb/xhci: replace pci_*_consistent() with dma_*_coherent()") Signed-off-by: Dan Carpenter --- >From static analysis. Not tested. diff --git

Re: [PATCH 2/4] usb: musb: Fix sleeping function called from invalid context for hdrc glue

2016-11-10 Thread Tony Lindgren
* Johan Hovold [161110 11:43]: > On Thu, Nov 10, 2016 at 10:41:50AM -0700, Tony Lindgren wrote: > > * Johan Hovold [161110 09:04]: > > > I'm afraid that won't work as pm_runtime_get() would still succeed (i.e. > > > even after musb_suspend()). > > > > > > See

Re: [PATCH v2 03/30] usb: dwc2: Make the DMA descriptor structure packed

2016-11-10 Thread John Youn
On 11/10/2016 4:28 AM, David Laight wrote: > From: John Youn >> Sent: 10 November 2016 03:28 >> From: Vahram Aharonyan >> >> Make the DMA descriptor structure packed to guarantee alignment and size >> in memory. >> >> Signed-off-by: John Youn >> ---

Re: [PATCH v2 11/13] Documentation: devicetree: dwc2: Add host DMA binding

2016-11-10 Thread Rob Herring
On Thu, Nov 03, 2016 at 05:56:10PM -0700, John Youn wrote: > Add the snps,host-dma-disable binding. This controls whether to disable > DMA in host mode. > > Signed-off-by: John Youn > --- > Documentation/devicetree/bindings/usb/dwc2.txt | 1 + > 1 file changed, 1