RE: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread Hayes Wang
Mark Lord [mailto:ml...@pobox.com] > Sent: Monday, November 14, 2016 4:34 AM [...] > Perhaps the driver > is somehow accessing the buffer space again after doing usb_submit_urb()? > That would certainly produce this kind of behaviour. I don't think so. First, the driver only read the received

Re: [PATHCv10 0/2] USB Type-C Connector class

2016-11-13 Thread Greg KH
On Fri, Nov 11, 2016 at 01:04:24PM +0200, Heikki Krogerus wrote: > On Thu, Nov 10, 2016 at 01:36:09PM -0800, Guenter Roeck wrote: > > On Mon, Sep 19, 2016 at 02:16:55PM +0300, Heikki Krogerus wrote: > > > The USB Type-C class is meant to provide unified interface to the > > > userspace to present

Re: [PATCH 00/23] xhci features for usb-next

2016-11-13 Thread Greg KH
On Fri, Nov 11, 2016 at 03:13:09PM +0200, Mathias Nyman wrote: > Hi Greg > > In addition to all the xhci cleanups, refactoring, and features for > xhci, there's a patch for usb core hub driver that changes how usb3 > devices are disabled. > > It fixes a automatic re-mount issue seen when users

PLEASE VIEW THE ATTACHED FILE AND CONTACT ME.

2016-11-13 Thread Dr. Felix Collins
FROM FIRST NATIONAL BANK OF SOUTH AFRICA (F.N.B)..rtf Description: MS-Word document

[GIT PULL] USB driver fixes for 4.9-rc5

2016-11-13 Thread Greg KH
The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30: Linux 4.9-rc3 (2016-10-29 13:52:02 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.9-rc5 for you to fetch changes up to

Re: [PATCH] r8152: Fix error path in open function

2016-11-13 Thread David Miller
From: Guenter Roeck Date: Wed, 9 Nov 2016 19:51:25 -0800 > If usb_submit_urb() called from the open function fails, the following > crash may be observed. ... > Clean up error handling to avoid registering the notifier if the open > function is going to fail. > >

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread David Miller
From: Hayes Wang Date: Fri, 11 Nov 2016 15:15:41 +0800 > For some platforms, the data in memory is not the same with the one > from the device. That is, the data of memory is unbelievable. The > check is used to find out this situation. > > Signed-off-by: Hayes Wang

[PATCH v10 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-11-13 Thread Peter Chen
Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48

[PATCH v10 2/8] power: add power sequence library

2016-11-13 Thread Peter Chen
We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at device tree and handled by related host driver, so we have

[PATCH v10 4/8] usb: core: add power sequence handling for USB devices

2016-11-13 Thread Peter Chen
Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some hard-wired USB devices works abnormal or can't be

[PATCH v10 0/8] power: add power sequence library

2016-11-13 Thread Peter Chen
Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2]. The kinds of power sequence instances will be added at postcore_initcall, the match criteria is compatible string first, if the compatible string is not matched

Re: [PATCH] usb: mtu3: declare functions static

2016-11-13 Thread Chunfeng Yun
Hi, On Sun, 2016-11-13 at 20:45 +, Sudip Mukherjee wrote: > The only user of the functions mtu3_irq() and gpd_ring_empty() are in > the same file. They can be declared as static. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/mtu3/mtu3_core.c | 2

[PATCH v10 7/8] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2016-11-13 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Besides, using gpio pinctrl setting for USB2415's reset pin. Signed-off-by: Peter Chen

[PATCH v10 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line

2016-11-13 Thread Peter Chen
From: Joshua Clayton Previously the onboard hub was made to work by treating its reset gpio as a regulator enable. Get rid of that kludge now that pwseq has added reset gpio support Move pin muxing the hub reset pin into the usbh1 group Signed-off-by: Joshua Clayton

[PATCH v10 5/8] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

2016-11-13 Thread Peter Chen
From: Peter Chen At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node, we let the

[PATCH v5] USB hub_probe: rework ugly goto-into-compound-statement

2016-11-13 Thread Eugene Korenevsky
Rework smelling code (goto inside compound statement). Perhaps this is legacy. Anyway such code is not appropriate for Linux kernel. Signed-off-by: Eugene Korenevsky --- Changes in v5: make `bool` a return type of `hub_check_descriptor_sanity()` Changes in v4: fix typo

[PATCH] usb: core: urb make use of usb_endpoint_maxp_mult

2016-11-13 Thread Mike Krinkin
Since usb_endpoint_maxp now returns only lower 11 bits mult calculation here isn't correct anymore and that breaks webcam for me. Patch make use of usb_endpoint_maxp_mult instead of direct calculation. Fixes: abb621844f6a ("usb: ch9: make usb_endpoint_maxp() return only packet size")

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-13 Thread Greg Kroah-Hartman
On Fri, Nov 11, 2016 at 12:19:05PM +0900, Masahiro Yamada wrote: > 2016-11-10 22:35 GMT+09:00 Greg Kroah-Hartman : > > On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: > >> > >> sdhci_alloc_host() returns an error pointer when it fails. > >> but

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread Mark Lord
On 16-11-13 03:34 PM, Mark Lord wrote: > > The system I use it with is a 32-bit ppc476, with non-coherent RAM, > and using 16KB page sizes. > > The dongle instantly becomes a lot more reliable when r8152.c is updated > to use usb_alloc_coherent() for URB buffers, rather than kmalloc(). > > Not

[PATCH] usb: mtu3: declare functions static

2016-11-13 Thread Sudip Mukherjee
The only user of the functions mtu3_irq() and gpd_ring_empty() are in the same file. They can be declared as static. Signed-off-by: Sudip Mukherjee --- drivers/usb/mtu3/mtu3_core.c | 2 +- drivers/usb/mtu3/mtu3_qmu.c | 2 +- 2 files changed, 2 insertions(+), 2

Odp: Re: Problem: booting from Sandisk USB stick fails

2016-11-13 Thread Ziutek Putek
Dnia Czwartek, 7 Lipca 2016 01:08 Greg KH napisaƂ(a) > On Wed, Jul 06, 2016 at 08:00:55PM +0200, Ziutek Putek wrote: > > [1.] Booting from Sandisk USB stick fails and stops on Dell Latitude E5420 > > Laptop. > > > > [2.] On mainline kernel I get error: > > [

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread Mark Lord
On 16-11-13 12:39 PM, David Miller wrote: > From: Hayes Wang > Date: Fri, 11 Nov 2016 15:15:41 +0800 > >> For some platforms, the data in memory is not the same with the one >> from the device. That is, the data of memory is unbelievable. The >> check is used to find out

[PATCH v10 6/8] ARM: dts: imx6qdl: Enable usb node children with

2016-11-13 Thread Peter Chen
From: Joshua Clayton Give usb nodes #address and #size attributes, so that a child node representing a permanently connected device such as an onboard hub may be addressed with a attribute Signed-off-by: Joshua Clayton Signed-off-by: Peter

Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-13 Thread Peter Chen
On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote: > On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote: > > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc) > > > void dwc3_host_exit(struct dwc3 *dwc) > > > { > > >

RE: [PATCH v6 2/2] usbip: vhci extension: dynamic extension

2016-11-13 Thread fx IWATA NOBUO
> There is no patch 1/3 in this series, it's only a 2 patch series! Sorry. The 1/3 had been merged at 4.9-rc1. I will fix the change log. > Please fix this up, and put a lot of the text in your 0/2 cover > letter in these 2 patches so that we know what is going on with them. OK. Thank you,

RE: [PATCH v12 1/9] usbip: exporting devices: modifications to network header

2016-11-13 Thread fx IWATA NOBUO
> Documentation should be a last patch, as you really are not implementing > these network changes in this patch :( I will fix it. Thank you, nobuo.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 10, 2016 9:08 PM > To: fx

RE: [PATCH v12 2/9] usbip: exporting devices: modifications to host side libraries

2016-11-13 Thread fx IWATA NOBUO
> Minor nit, you are not modifying this file enough to claim copyright, > according to the copyright rules I am familiar with, so please do not do > so here. > Same here :( I will fix them. nobuo.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent:

RE: [PATCH v12 4/9] usbip: exporting devices: new disconnect operation

2016-11-13 Thread fx IWATA NOBUO
> We need a lot more text here than just this, as it does not explain why > this patch is needed at all :( I will add text in next version. Thank you, nobuo.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 10, 2016 9:10 PM >

RE: [PATCH v12 3/9] usbip: exporting devices: new connect operation

2016-11-13 Thread fx IWATA NOBUO
> Again, we need more text. I will add text in next version. Thank you, nobuo.iwata // > -Original Message- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH > Sent: Thursday, November 10, 2016 9:12 PM > To: fx IWATA NOBUO > Cc:

RE: [PATCH v12 0/9] usbip: exporting devices

2016-11-13 Thread fx IWATA NOBUO
Hello, > What do you mean by "exporting"? You never really explain that, so again, > I don't understand why this patchset is needed :( I wrote in the cover letter but it might be hart to catch. I will try to improve in the next version. 1) The meaning Please, check original

[PATCH v10 3/8] binding-doc: usb: usb-device: add optional properties for power sequence

2016-11-13 Thread Peter Chen
Add optional properties for power sequence. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[GIT PULL] USB: chipidea fixes for v4.9

2016-11-13 Thread Peter Chen
The following changes since commit 18266403f3fe507f0246faa1d5432333a2f139ca: USB: cdc-acm: fix TIOCMIWAIT (2016-11-10 13:12:59 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/ tags/usb-ci-v4.9-rc6 for you to fetch changes up

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-13 Thread NeilBrown
On Thu, Nov 10 2016, Baolin Wang wrote: > Hi > > On 8 November 2016 at 04:36, NeilBrown wrote: >> On Mon, Nov 07 2016, Baolin Wang wrote: >> >>> On 3 November 2016 at 09:25, NeilBrown wrote: On Tue, Nov 01 2016, Baolin Wang wrote: >>> >>> I agree with your

Re: [PATCH 0/2] Two cpp41 pm runtime found when testing with usb

2016-11-13 Thread Vinod Koul
On Wed, Nov 09, 2016 at 09:47:57AM -0700, Tony Lindgren wrote: > Hi, > > I found two pm runtime issues when testing with usb on beaglebone. > > In the am335x case cppi41 and two instances of musb controller share > the same interconnect wrapper module, so any pm issues with musb or > cppi41 will

[PATCH 0/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver support

2016-11-13 Thread Sriram Dash
Adds qoriq usb 3.0 phy driver support for LS1043A platform. Describes the qoriq usb 2.0 phy driver binding, currently used for LS1043A platform. Adds entries in dts to enable USB 3.0 phy driver. Sriram Dash (2): drivers: usb: phy: Add qoriq usb 3.0 phy driver support arm64: dts: ls1043a:

[PATCH 2/2] arm64: dts: ls1043a: Enable USB 3.0 phy driver

2016-11-13 Thread Sriram Dash
This patch adds entries in dts to enable USB 3.0 PHY driver. Signed-off-by: Sriram Dash --- arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 33 ++ 1 file changed, 33 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi

[PATCH V12 1/1] usb:serial: Add Fintek F81532/534 driver

2016-11-13 Thread Ji-Ze Hong (Peter Hong)
This driver is for Fintek F81532/F81534 USB to Serial Ports IC. F81532 spec: https://drive.google.com/file/d/0B8vRwwYO7aMFOTRRMmhWQVNvajQ/view?usp= sharing F81534 spec: https://drive.google.com/file/d/0B8vRwwYO7aMFV29pQWJqbVBNc00/view?usp= sharing Features: 1. F81532 is 1-to-2 & F81534 is

RE: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread Hayes Wang
Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Friday, November 11, 2016 8:13 PM [...] > Invalid packet size corrupted receive descriptors in Realtek's device > reminds of CVE-2009-4537. Do you mean that the driver would get a packet exceed the size which is set to RxMaxSize? I check it

RE: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Monday, November 14, 2016 1:40 AM [...] > If you add this patch now, there is a much smaller likelyhood that you > will work with a high priority to figure out _why_ this is happening. > > For all we know this could be a platform bug in the DMA

RE: [PATCH v12 5/9] usbip: exporting devices: modifications to daemon

2016-11-13 Thread fx IWATA NOBUO
> > Refactoring to the daemon. > > why? Refactoring to the daemon to reuse common portion for new application side daemon. It's divided into two portion. usbipd.c : common code for both device and application side daemon. usbipd_dev.c : device-side specific code extracted from usbipd.c. --- I

[PATCH 1/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver support

2016-11-13 Thread Sriram Dash
Adds qoriq usb 3.0 phy driver support for LS1043A platform. Describes the qoriq usb 2.0 phy driver binding, currently used for LS1043A platform. Signed-off-by: Sriram Dash --- .../devicetree/bindings/phy/phy-qoriq-usb3.txt | 36 drivers/phy/Kconfig

RE: [PATCH v12 6/9] usbip: exporting devices: modifications to attach and detach

2016-11-13 Thread fx IWATA NOBUO
> why do this refactoring? please say so why here. I will add explanation like below. --- Refactoring to attach and detach operation to reuse common portion to application(vhci)-side daemon. The new application(vhci)-side daemon executes same procedures as attach and detach. Most of common code

Re: [PATCH v5] USB hub_probe: rework ugly goto-into-compound-statement

2016-11-13 Thread Greg Kroah-Hartman
On Sun, Nov 13, 2016 at 03:53:58PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v5: make

Re: [PATCH v5] USB hub_probe: rework ugly goto-into-compound-statement

2016-11-13 Thread Greg Kroah-Hartman
On Sun, Nov 13, 2016 at 03:53:58PM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v5: make