[PATCH 9/9] usb: dwc2: Fix sizeof in kzalloc

Take the sizeof '*req' instead of 'struct dwc2_hsotg_req'. Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 01c87e8..d867cb5 100644 ---

[PATCH 5/9] usb: dwc2: Fix brace usage

* Remove braces for one-line statements * Add missing braces where another arm in if-statement uses braces Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 10 -- drivers/usb/dwc2/platform.c | 12 ++-- 2 files changed, 10 insertions(+), 12

[PATCH 1/9] usb: dwc2: Cleanup some checkpatch issues

This commmit is the result of running checkpatch --fix. The results were verified for correctness. Some of the fixes result in line over 80 char which we will fix manually later. The following is a summary of what was done by checkpatch: * Remove externs on function prototypes. * Replace

[PATCH 6/9] usb: dwc2: Fix lines over 80 characters

Fix lines over 80 characters. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 13 + drivers/usb/dwc2/gadget.c | 14 +- drivers/usb/dwc2/hcd.c | 4 ++-- drivers/usb/dwc2/hcd_intr.c | 13 +++-- drivers/usb/dwc2/params.c |

[PATCH 2/9] usb: dwc2: Add identifier in prototypes

Fixes checkpatch warning: WARNING: function definition argument 'struct dwc2_hsotg *' should also have an identifier name Signed-off-by: John Youn --- drivers/usb/dwc2/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/9] usb: dwc2: Fix comment alignment and format

Fix misaligned and over 80-character comments. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 19 ++- drivers/usb/dwc2/gadget.c | 43 +++ drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/dwc2/hcd_intr.c

[PATCH 8/9] usb: dwc2: Remove 'return' from void function

The function returns void so a return is unnecessary. Signed-off-by: John Youn --- drivers/usb/dwc2/hcd_queue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c index faf45df..b1fc9fe 100644 ---

[PATCH 4/9] usb: dwc2: Fix logical continuations

Fix the formatting of logical statements to end the line with the logical operator. Signed-off-by: John Youn --- drivers/usb/dwc2/core_intr.c | 5 ++--- drivers/usb/dwc2/hcd_ddma.c | 8 drivers/usb/dwc2/hcd_queue.c | 5 ++--- 3 files changed, 8 insertions(+), 10

[PATCH 0/9] usb: dwc2: Fix checkpatch issues

The dwc2 driver triggers several hundred checkpatch warnings and checks. None of them are actual problems but this is still very noisy. This series fixes most of those issues. The first patch in the series is the result of running checkpatch with '--fix'. All of these changes were inspected for

[PATCH 7/9] usb: dwc2: Fix code indentation after conditionals

The indent should be only one tab. Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 4fc115e..01c87e8 100644 ---

PROBLEM: Oops when

Hello, in 4.8.11 and 4.9-rc7, I get an Oops (see below), when I try to activate and afterward deactivate a second gadget configfs configuration, like this: mkdir /sys/kernel/config/usb_gadget/acm cd /sys/kernel/config/usb_gadget/acm echo 0x0200 > bcdUSB echo 0x0525 > idVendor echo 0xa4a7 >

Re: XHCI's lock usage on hardirq handler

Hi, Alan Stern writes: > On Tue, 29 Nov 2016, Felipe Balbi wrote: > >> Hi Greg, >> >> Greg KH writes: >> > On Tue, Nov 29, 2016 at 03:58:57PM +0200, Felipe Balbi wrote: >> >> >> >> Hi, >> >> >> >> Greg KH writes: >> >> > On Tue,

PROBLEM: Oops when unbinding an inactive gadget configfs configuration from UDC

Hello, in 4.8.11 and 4.9-rc7, I get an Oops (see below), when I try to activate and afterward deactivate a second gadget configfs configuration, like this: mkdir /sys/kernel/config/usb_gadget/acm cd /sys/kernel/config/usb_gadget/acm echo 0x0200 > bcdUSB echo 0x0525 > idVendor echo 0xa4a7 >

Re: [PATCH] usb: musb: Fix trying to free already-free IRQ 4

On Wed, Nov 23, 2016 at 08:51:27AM -0800, Tony Lindgren wrote: > When unloading omap2430, we can get the following splat: > > WARNING: CPU: 1 PID: 295 at kernel/irq/manage.c:1478 __free_irq+0xa8/0x2c8 > Trying to free already-free IRQ 4 > ... > [] (free_irq) from [] >

Donation

Hello, My name is Gloria C. Mackenzie, i have a Monetary Donation to make for less privilege and yourself and your organization, am writing you with a friend's email, please contact me on g_macken...@rogers.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

[PATCH] extcon: Split out the extcon APIs for extcon provider driver

This patchs split out the extcon APIs of extcon provider driver in order to prevent the direct access of struct extcon_dev by extcon consumer driver. The extcon consumer driver don't need to handle the extcon provider APIs. The extcon subsystem has two type of extcon drivers as following: -

cdc_ether flooding kernel logs since bfe9b9d2d

Hi, commit bfe9b9d2d introduced a workaround for link status detection. That workaround seems to cause a tight loop of usbnet_cdc_status being called all the time, which in turn prints "kevent 11 may have been dropped" in the kernel log all the time. I am not sure about the semantics, i just

RE: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Dear Jon , We can reproduce your issue on x86 Linux kernel 4.9.0-rc system in our site and modified the following code can fix this issue. Please let us know if you still have problems. Thanks a lot. static void ax88772_suspend(struct usbnet *dev) { struct asix_common_private *priv =

Re: [PATCH] extcon: Split out the extcon APIs for extcon provider driver

On Tue, Nov 29, 2016 at 07:02:23PM +0900, Chanwoo Choi wrote: > This patchs split out the extcon APIs of extcon provider driver in order to > prevent the direct access of struct extcon_dev by extcon consumer driver. > The extcon consumer driver don't need to handle the extcon provider APIs. > >

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Hi Allan, On 29/11/16 08:54, ASIX_Allan [Office] wrote: > Dear Jon , > > We can reproduce your issue on x86 Linux kernel 4.9.0-rc system in our site > and modified the following code can fix this issue. Please let us know if > you still have problems. Thanks a lot. > > static void

Re: [PATCH] b: re-queue tx dma request on herror

Hello Bin, thanks for decoding errors. I was able to reproduce it with the latest master while logs are for 4.1 kernel. The main reason was 25 mhz generator instead of 24 on remote hid device. With replacing everything looks better, i.e. hidraw can operate 3-4 days and then the same continuous

Re: [PATCH V12 1/1] usb:serial: Add Fintek F81532/534 driver

On Tue, Nov 29, 2016 at 10:33:16AM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2016/11/24 下午 11:04 寫道: > > On Mon, Nov 14, 2016 at 01:37:59PM +0800, Ji-Ze Hong (Peter Hong) wrote: > >> This driver is for Fintek F81532/F81534 USB to Serial Ports IC. > > >> + } > >> + >

[PATCH 0/2] usb: dwc3: fix full speed gadget mode configuration

Hi, Although full speed gadget mode isn't really broken on my boards, we are not strictly following the dwc3 manual with regards to the DCFG.DEVSPD configuration. This series fixes that. cheers, -roger Roger Quadros (2): usb: dwc3: gadget: Fix full speed mode usb: dwc3: gadget: Clean up

[PATCH 2/2] usb: dwc3: gadget: Clean up DCFG/DSTS FULLSPEED macro

DCFG/DSTS.FULLSPEED can be either 0x1 or 0x3. Let's call 0x1 as DCFG/DSTS_FULLSPEED1 and 0x3 as DCFG/DSTS_FULLSPEED3. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 8 drivers/usb/dwc3/gadget.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-)

[PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

DCFG.DEVSPD == 0x3 is not valid and we need to set DCFG.DEVSPD to 0x1 for full speed mode. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index

[PATCH 05/12] usb: chipdata: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/chipidea/core.c | 30

[PATCH 07/12] usb: sunxi: Uses the resource-managed extcon API when registering extcon notifier

This patch just uses the resource-managed extcon API when registering the extcon notifier. Signed-off-by: Chanwoo Choi --- drivers/usb/musb/sunxi.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/usb/musb/sunxi.c

[PATCH 00/12] extcon: Replace the deprecated extcon API

This patches just replace the deprecated extcon API without any change of extcon operation and use the resource-managed function for extcon_register_notifier(). The new extcon API instead of deprecated API. - extcon_set_cable_state_() -> extcon_set_state_sync(); - extcon_get_cable_state_() ->

[PATCH 08/12] usb: phy: msm: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-msm-usb.c | 33

[PATCH 06/12] usb: dwc3: omap: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/dwc3/dwc3-omap.c | 20 +++- 1

[PATCH 02/12] phy: sun4i-usb: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Cc: Kishon Vijay Abraham I Cc: Maxime Ripard Cc: Chen-Yu Tsai Signed-off-by: Chanwoo Choi

[PATCH 01/12] phy: rcar-gen3-usb2: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi --- drivers/phy/phy-rcar-gen3-usb2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/renesas_usbhs/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 11/12] usb: phy: tahvo: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-tahvo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 03/12] power_supply: axp288_charger: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/power/supply/axp288_charger.c | 51

[PATCH 09/12] usb: phy: omap-otg: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-omap-otg.c | 24

[PATCH 10/12] usb: phy: qcom-8x16-usb: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi --- drivers/usb/phy/phy-qcom-8x16-usb.c | 13 - 1

[PATCH 04/12] power_supply: qcom_smbb: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi --- drivers/power/supply/qcom_smbb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

This is driver for Synopsys Designware Cores USB Device Controller (UDC) Subsystem with the AMBA Advanced High-Performance Bus (AHB). This driver works with Synopsys UDC20 products. Signed-off-by: Raviteja Garimella --- drivers/usb/gadget/udc/Kconfig| 12 +

[PATCH 0/2] Support for Synopsys UDC for ARM platforms

This patchset adds support for Synposys Designware core AHB-UDC (USB Device controller) for Arm platfoms. New UDC driver is added to drivers/usb/gadget directory along with updating the Kconfig and Makefile. DT bindings documentation is also added for the same. Device tree entry for the same in

[PATCH 1/2] Add DT bindings documentation for Synopsys UDC driver

This patch adds documentation for Synopsis Designware Cores AHB Subsystem Device Controller (UDC). Signed-off-by: Raviteja Garimella --- .../devicetree/bindings/usb/snps,dw-ahb-udc.txt| 29 ++ 1 file changed, 29 insertions(+) create mode

[PATCH v4 3/5] net: asix: Fix AX88772x resume failures

The change fixes AX88772x resume failure by - Restore incorrect AX88772A PHY registers when resetting - Need to stop MAC operation when suspending - Need to restart MII when restoring PHY Signed-off-by: Allan Chou Signed-off-by: Robert Foss

[PATCH 1/1] usb: return error code when platform_get_irq fails

In function xhci_mtk_probe(), variable ret takes the return value. Its value should be negative on failures. However, when the call to function platform_get_irq() fails, it does not set the error code, and 0 will be returned. 0 indicates no error. As a result, the callers of function

Re: [PATCHv12 2/3] usb: USB Type-C connector class

Hi Guenter, On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote: > Personally I don't really care about a module parameter; as mentioned above, > I would expect the preference, if it needs to be selectable, to be configured > with devicetree or ACPI properties (or by a platform driver

[PATCH 1/1] usb: abort on exception path

Function klsi_105_open() calls usb_control_msg() and checks its return value. When the return value is unexpected, it only assigns the error code to the return variable retval, but does not terminate the exception path. This patch fixes the bug by inserting "goto exit;" when the call to

XHCI's lock usage on hardirq handler

Hi folks, I've been staring at this part of the code for a while. To make things easier here's the part of XHCI I mean: > irqreturn_t xhci_irq(struct usb_hcd *hcd) > { > struct xhci_hcd *xhci = hcd_to_xhci(hcd); > union xhci_trb *event_ring_deq; > irqreturn_t ret = IRQ_NONE; >

[PATCH 2/5] usb: host: xhci: simplify irq handler return

Instead of having several return points, let's use a local variable and a single place to return. This makes the code slightly easier to read. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 31 --- 1 file changed, 16

[PATCH 3/5] usb: host: xhci: clear only STS_EINT

Many other bits in USBSTS register are "clear-by-writing-1". Let's make sure that we clear *only* STS_EINT and not any of the other bits as they might be needed later. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 3 +-- 1 file changed, 1

[PATCH 5/5] usb: host: xhci: use slightly better list helpers

Replace list_entry() with list_first_entry() and list_for_each() with list_for_each_entry(). This makes the code slightly more readable. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)

[PATCH 4/5] usb: host: xhci: remove unneded semicolon

it does no good, let's remove it. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ext-caps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ext-caps.h b/drivers/usb/host/xhci-ext-caps.h index

[PATCH 1/5] usb: host: xhci: WARN() if we interrupt without event_ring

If we get an interrupt while we don't have an allocated event_ring, that means we're enabling IRQs far too early. Instead of just printing an error message, let's make sure to add a scary-looking Stack Trace so people report these things and we fix them. Eventually, when we're happy that this

[PATCH 1/1] usb: fix improper return value when kzalloc fails

The comment says function wa_nep_queue() should return 0 if ok, and <0 errno code on error. However, its implementation always returns 0, even if the call to kzalloc() fails. As a result, the return value may be inconsistent with the execution status, which may mislead the callers. This patch

[PATCH 1/1] usb: return correct errno on failures

In function __wa_xfer_setup_segs(), variable result takes the return value. Its value should be a negative errno on failures. Because result may be reassigned in a loop, and its value is guaranteed to be not less than 0 during the following repeats of the loop. So when the call to kmalloc() or

Re: [PATCHv12 2/3] usb: USB Type-C connector class

On Tue, Nov 29, 2016 at 02:59:58PM +0200, Heikki Krogerus wrote: > Hi Guenter, > > On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote: > > Personally I don't really care about a module parameter; as mentioned above, > > I would expect the preference, if it needs to be selectable, to be

Re: cdc_ether flooding kernel logs since bfe9b9d2d

Hi, On Tue, Nov 29, 2016 at 11:27 AM, Henning Schild wrote: > commit bfe9b9d2d introduced a workaround for link status detection. > That workaround seems to cause a tight loop of usbnet_cdc_status being > called all the time, which in turn prints > "kevent 11 may have

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, On 29/11/16 13:51, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> DCFG.DEVSPD == 0x3 is not valid and we need to set >> DCFG.DEVSPD to 0x1 for full speed mode. > > seems like it has been made invalid somewhere between 1.73a and > 2.60a. Can you figure it out from

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, Roger Quadros writes: > DCFG.DEVSPD == 0x3 is not valid and we need to set > DCFG.DEVSPD to 0x1 for full speed mode. seems like it has been made invalid somewhere between 1.73a and 2.60a. Can you figure it out from Documentation why and when it was made invalid? We might

[PATCH 1/1] usb: return correct errno code when krealloc fails

In function wusb_dev_sec_add(), variable result takes the return value. Its value should be negative on failures. When function krealloc() is called, an earlier check of variable result guarantees that the value of result must not be less than "sizeof(*secd)", and result is not reassigned when

Re: XHCI's lock usage on hardirq handler

On Tue, Nov 29, 2016 at 01:48:59PM +0200, Felipe Balbi wrote: > > Hi folks, > > I've been staring at this part of the code for a while. To make things > easier here's the part of XHCI I mean: > > > irqreturn_t xhci_irq(struct usb_hcd *hcd) > > { > > struct xhci_hcd *xhci = hcd_to_xhci(hcd);

Re: [PATCHv12 2/3] usb: USB Type-C connector class

On Tue, 2016-11-29 at 14:20 +0100, Greg KH wrote: > On Tue, Nov 29, 2016 at 02:59:58PM +0200, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote: > > > Personally I don't really care about a module parameter; as mentioned > > > above, > >

Re: XHCI's lock usage on hardirq handler

On Tue, Nov 29, 2016 at 03:58:57PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH writes: > > On Tue, Nov 29, 2016 at 01:48:59PM +0200, Felipe Balbi wrote: > >> > >> Hi folks, > >> > >> I've been staring at this part of the code for a while. To make things > >> easier here's

Re: XHCI's lock usage on hardirq handler

Hi, Greg KH writes: > On Tue, Nov 29, 2016 at 01:48:59PM +0200, Felipe Balbi wrote: >> >> Hi folks, >> >> I've been staring at this part of the code for a while. To make things >> easier here's the part of XHCI I mean: >> >> > irqreturn_t xhci_irq(struct usb_hcd *hcd) >> > {

Re: [PATCH] USB: OHCI: use module_platform_driver macro

On Tue, Nov 22, 2016 at 01:49:22PM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > Use the module_platform_driver macro to do module init/exit. > This eliminates a lot of boilerplate.This also removes > checkpatch.pl errors. > > Signed-off-by: Manjunath

Re: XHCI's lock usage on hardirq handler

On Tue, 29 Nov 2016, Felipe Balbi wrote: > Hi Greg, > > Greg KH writes: > > On Tue, Nov 29, 2016 at 03:58:57PM +0200, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Greg KH writes: > >> > On Tue, Nov 29, 2016 at 01:48:59PM +0200, Felipe Balbi wrote: > >> >> > >>

Re: [PATCHv12 2/3] usb: USB Type-C connector class

On Tue, Nov 29, 2016 at 02:48:46PM +0100, Oliver Neukum wrote: > On Tue, 2016-11-29 at 14:20 +0100, Greg KH wrote: > > On Tue, Nov 29, 2016 at 02:59:58PM +0200, Heikki Krogerus wrote: > > > Hi Guenter, > > > > > > On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote: > > > > Personally I

Re: XHCI's lock usage on hardirq handler

Hi Greg, Greg KH writes: > On Tue, Nov 29, 2016 at 03:58:57PM +0200, Felipe Balbi wrote: >> >> Hi, >> >> Greg KH writes: >> > On Tue, Nov 29, 2016 at 01:48:59PM +0200, Felipe Balbi wrote: >> >> >> >> Hi folks, >> >> >> >> I've been staring at this part of

Re: [PATCH 1/1] usb: abort on exception path

On Tue, Nov 29, 2016 at 08:53:35PM +0800, Pan Bian wrote: > Function klsi_105_open() calls usb_control_msg() and checks its return > value. When the return value is unexpected, it only assigns the error > code to the return variable retval, but does not terminate the exception > path. This patch

[PATCH 2/2] USB: serial: kl5kusb105: abort on open exception path

From: Pan Bian Function klsi_105_open() calls usb_control_msg() (to "enable read") and checks its return value. When the return value is unexpected, it only assigns the error code to the return variable retval, but does not terminate the exception path. This patch fixes the

[PATCH 0/2] USB: serial: kl5kusb105: fix open error paths

Pan Bian found an issue with the kl5kusb105 open error handling, which would not abort an open attempt when a vendor command to "enable read" failed. Turns out there were more issues with this function, specifically any urbs submitted would not be killed before returning on failures to retrieve

[PATCH 1/2] USB: serial: kl5kusb105: fix open error path

Kill urbs and disable read before returning from open on failure to retrieve the line state. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/kl5kusb105.c | 33 - 1

Re: [PATCHv13 2/3] usb: USB Type-C connector class

On Thu, Nov 24, 2016 at 02:21:43PM +0200, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCH 2/3] usb: musb: Add a quirk to preserve MUSB_DEVCTL during suspend

Hi, On Mon, Nov 28, 2016 at 05:26:20PM +0100, Alexandre Bailon wrote: > On da8xx, VBUS is not maintained during suspend when musb is in host mode. > On resume, all the connected devices will be disconnected and then will > be enumerated again. > This happens because MUSB_DEVCTL is cleared during

Re: [PATCH 2/3] usb: musb: Add a quirk to preserve MUSB_DEVCTL during suspend

On Tue, Nov 29, 2016 at 06:41:04PM +0100, Alexandre Bailon wrote: > On 11/29/2016 05:16 PM, Bin Liu wrote: > > Hi, > > > > On Mon, Nov 28, 2016 at 05:26:20PM +0100, Alexandre Bailon wrote: > >> On da8xx, VBUS is not maintained during suspend when musb is in host mode. > >> On resume, all the

Re: [PATCH 2/3] usb: musb: Add a quirk to preserve MUSB_DEVCTL during suspend

On 11/29/2016 05:16 PM, Bin Liu wrote: > Hi, > > On Mon, Nov 28, 2016 at 05:26:20PM +0100, Alexandre Bailon wrote: >> On da8xx, VBUS is not maintained during suspend when musb is in host mode. >> On resume, all the connected devices will be disconnected and then will >> be enumerated again. >>