Re: cdc_ether flooding kernel logs since bfe9b9d2d

Hi, On Wed, Nov 30, 2016 at 4:17 PM, Oliver Neukum wrote: > On Tue, 2016-11-29 at 14:41 +0100, Kristian Evensen wrote: >> I don't know which of the two behaviors (if any) are "correct" or what >> the best way to solve this problem is. One options is to remove the >> code from

Re: cdc_ether flooding kernel logs since bfe9b9d2d

On Tue, 2016-11-29 at 14:41 +0100, Kristian Evensen wrote: > I don't know which of the two behaviors (if any) are "correct" or what > the best way to solve this problem is. One options is to remove the > code from the generic usbnet_cdc_status() function and move it to a > ZTE-specific status

Re: [PATCH v4] fsl/usb: Workarourd for USB erratum-A005697

On Tue, 29 Nov 2016, Changming Huang wrote: > The EHCI specification states the following in the SUSP bit description: > In the Suspend state, the port is sensitive to resume detection. > Note that the bit status does not change until the port is suspended and > that there may be a delay in

[PATCH net] cdc_ether: Fix handling connection notification

Commit bfe9b9d2df66 ("cdc_ether: Improve ZTE MF823/831/910 handling") introduced a work-around in usbnet_cdc_status() for devices that exported cdc carrier on twice on connect. Before the commit, this behavior caused the link state to be incorrect. It was assumed that all CDC Ethernet devices

Re: [PATCH net] cdc_ether: Fix handling connection notification

Am Wed, 30 Nov 2016 19:42:16 +0100 schrieb Kristian Evensen : > Commit bfe9b9d2df66 ("cdc_ether: Improve ZTE MF823/831/910 handling") > introduced a work-around in usbnet_cdc_status() for devices that > exported cdc carrier on twice on connect. Before the commit, this

Re: [PATCH] USB: OHCI: ohci-pxa27x: remove unuseful functions

By the way, "unuseful" is not an English word. It should be "useless". On Wed, 30 Nov 2016 csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > The ohci_hcd_pxa27x_drv_probe function is not doing anything other > than calling usb_hcd_pxa27x_probe function so

Re: [PATCH 1/2] dt-bindings: usb: add DT binding for s3c2410 USB OHCI controller

On Fri, Nov 25, 2016 at 12:47:28PM -0200, Sergio Prado wrote: > Adds the device tree bindings description for Samsung S3C2410 and > compatible USB OHCI controller. > > Signed-off-by: Sergio Prado > --- > .../devicetree/bindings/usb/s3c2410-usb.txt| 22 >

Re: [PATCH net] cdc_ether: Fix handling connection notification

On Wed, Nov 30, 2016 at 10:51 PM, Bjørn Mork wrote: > Kristian Evensen writes: > >> +void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb) >> +{ >> + struct usb_cdc_notification *event; >> + >> + if (urb->actual_length <

Re: [PATCH net] cdc_ether: Fix handling connection notification

Kristian Evensen writes: > +void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb) > +{ > + struct usb_cdc_notification *event; > + > + if (urb->actual_length < sizeof(*event)) > + return; > + > + event = urb->transfer_buffer; > + > +

[RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

If the hardware never responds to the stop endpoint command, the URBs will never be completed, and we might hang the USB subsystem. The original watchdog timer is used to watch if one stop endpoint command is timeout, if timeout, then the watchdog timer will set XHCI_STATE_DYING, try to halt the

Re: [PATCH 07/12] usb: sunxi: Uses the resource-managed extcon API when registering extcon notifier

On Wed, Nov 30, 2016 at 02:57:35PM +0900, Chanwoo Choi wrote: > This patch just uses the resource-managed extcon API when registering > the extcon notifier. > > Signed-off-by: Chanwoo Choi Acked-by: Maxime Ripard Thanks! Maxime --

[PATCH] net: asix: Fix AX88772_suspend() USB vendor commands failure issues

The change fixes AX88772_suspend() USB vendor commands failure issues. Signed-off-by: Allan Chou Tested-by: Allan Chou Tested-by: Jon Hunter --- --- a/drivers/net/usb/asix_devices.c2016-11-28 05:08:04.0 +0800 +++

RE: [PATCH v4 3/5] net: asix: Fix AX88772x resume failures

Dear Jon, Thanks a lot for your reminding. I will submit a new driver patch soon. --- Best regards, Allan Chou -Original Message- From: Jon Hunter [mailto:jonath...@nvidia.com] Sent: Wednesday, November 30, 2016 4:08 PM To: al...@asix.com.tw; fre...@asix.com.tw;

Re: [PATCH v4 3/5] net: asix: Fix AX88772x resume failures

Hi Allan, On 30/11/16 03:03, ASIX_Allan [Office] wrote: > The change fixes AX88772x resume failure by > - Restore incorrect AX88772A PHY registers when resetting > - Need to stop MAC operation when suspending > - Need to restart MII when restoring PHY > > Signed-off-by: Allan Chou

Re: [PATCHv13 2/3] usb: USB Type-C connector class

Hi Greg, On Tue, Nov 29, 2016 at 05:27:44PM +0100, Greg KH wrote: > > +struct typec_cable { > > + struct device dev; > > + enum typec_plug_typetype; > > + u32 vdo; > > + unsigned intusb_pd:1; > > + unsigned intactive:1; > > +

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi

Re: [PATCH 08/12] usb: phy: msm: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi

[PATCH v6 2/4] usb: xhci: Add helper function xhci_disable_slot().

Refactoring slot disable related code into a helper function xhci_disable_slot() which can be used when enabling test mode. Signed-off-by: Guoqing Zhang --- drivers/usb/host/xhci.c | 49 +++-- drivers/usb/host/xhci.h | 2 ++

[PATCH v6 4/4] usb: xhci: Add port test modes support for usb2.

For usb2 ports, the port test mode Test_J_State, Test_K_State, Test_Packet, Test_SE0_NAK and Test_Force_En can be enabled as described in usb2 spec. Signed-off-by: Guoqing Zhang --- drivers/usb/host/xhci-hub.c | 84 +

Re: [PATCH 11/12] usb: phy: tahvo: Replace the deprecated extcon API

Hi, Chanwoo Choi writes: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi -- balbi

[PATCH v6 1/4] usb: xhci: Add helper function xhci_set_power_on().

Refactoring port power on/off related code into a helper function xhci_set_power_on() which can be reused when enabling test mode. Signed-off-by: Guoqing Zhang --- drivers/usb/host/xhci-hub.c | 64 ++--- 1 file changed, 43

Re: [PATCH 09/12] usb: phy: omap-otg: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi

Re: [PATCH 10/12] usb: phy: qcom-8x16-usb: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi

[PATCH v6 3/4] usb: xhci: Expose xhci_start() function.

Change the visability of xhci_start() so that it can be used when enabling test mode. Signed-off-by: Guoqing Zhang --- drivers/usb/host/xhci.c | 2 +- drivers/usb/host/xhci.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c

Re: [RFT PATCH 1/1] xhci: free xhci virtual devices with leaf nodes first

On 28.11.2016 22:24, Guenter Roeck wrote: On Wed, Nov 23, 2016 at 02:24:27PM +0200, Mathias Nyman wrote: the tt_info provided by a HS hub might be in use to by a child device Make sure we free the devices in the correct order. This is needed in special cases such as when xhci controller is

Re: [PATCH v2 2/4] usb: host: xhci: handle COMP_STOP from SETUP phase too

Hi, Felipe Balbi writes: > Stop Endpoint command can come at any point and we > have no control of that. We should make sure to > handle COMP_STOP on SETUP phase as well, otherwise > urb->actual_lenght might be set to negative values > in some occasions such as

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

Mark Lord [...] > > Not sure why, because there really is no other way for the data to > > appear where it does at the beginning of that URB buffer. > > > > This does seem a rather unexpected burden to place upon someone > > reporting a regression in a USB network driver that

Re: [PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

Hi, Chanwoo Choi writes: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi -- balbi

Re: [PATCH 0/2] USB: serial: kl5kusb105: fix open error paths

On Tue, Nov 29, 2016 at 04:55:00PM +0100, Johan Hovold wrote: > Pan Bian found an issue with the kl5kusb105 open error handling, which > would not abort an open attempt when a vendor command to "enable read" > failed. > > Turns out there were more issues with this function, specifically any >

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, Raviteja Garimella writes: > This is driver for Synopsys Designware Cores USB Device > Controller (UDC) Subsystem with the AMBA Advanced High-Performance > Bus (AHB). This driver works with Synopsys UDC20 products. > > Signed-off-by: Raviteja Garimella

Re: [PATCH 1/1] usb: return error code when platform_get_irq fails

On 29/11/16 13:57, Pan Bian wrote: In function xhci_mtk_probe(), variable ret takes the return value. Its value should be negative on failures. However, when the call to function platform_get_irq() fails, it does not set the error code, and 0 will be returned. 0 indicates no error. As a

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi Balbi, On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: > > Hi, > > Raviteja Garimella writes: >> This is driver for Synopsys Designware Cores USB Device >> Controller (UDC) Subsystem with the AMBA Advanced High-Performance >> Bus (AHB).

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, Raviteja Garimella writes: > Hi Balbi, > > On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >> >> Hi, >> >> Raviteja Garimella writes: >>> This is driver for Synopsys Designware Cores USB Device >>>

Re: [RFC][PATCH 0/3] Try to connect hikey's usb phy to dwc2 driver

On Tue, Nov 22, 2016 at 7:46 PM, John Stultz wrote: > After earlier attempts[1] at submitting somewhat hackish fixes > to the dwc2 driver, I realized the core issue seemed to be the > overly simplistic phy driver. > > I've connected the phy-hi6220-usb.c driver to extcon so

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

On Wed, 2016-11-23 at 19:32 +0100, Matthias Brugger wrote: > Hi Hongzhou, > > On 12/05/16 04:55, Hongzhou Yang wrote: > > On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: > >> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > >>> Hi, > >>> > >>> On Wed, 2016-05-11 at 11:32 -0700,

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

On 11/30/2016 4:47 AM, Felipe Balbi wrote: > > Hi, > > Raviteja Garimella writes: >> Hi Balbi, >> >> On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Raviteja Garimella writes:

[PATCH] usb: gadget: udc: core: fix return code of usb_gadget_probe_driver()

This fixes a regression which was introduced by commit f1bddbb, by reverting a small fragment of commit 855ed04. If the following conditions were met, usb_gadget_probe_driver() returned 0, although the call was unsuccessful: 1. A particular UDC was specified by thge gadget driver (using member

Re: PROBLEM: Oops when unbinding an inactive gadget configfs configuration from UDC

Hello, > I had expected that writing "dummy_udc.0" to > /sys/kernel/config/usb_gadget/gser/UDC would fail, because the UDC is > already bound to another gadget configuration > (/sys/kernel/config/usb_gadget/acm/UDC). However, this doesn't give me > an error, but the ACM configuration remains

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

Hi, On 12/01/2016 02:04 PM, Baolin Wang wrote: > Hi Baolu, > > On 1 December 2016 at 13:45, Lu Baolu wrote: >> Hi, >> >> On 11/30/2016 05:02 PM, Baolin Wang wrote: >>> If the hardware never responds to the stop endpoint command, the >>> URBs will never be completed, and

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

Hi Baolu, On 1 December 2016 at 13:45, Lu Baolu wrote: > Hi, > > On 11/30/2016 05:02 PM, Baolin Wang wrote: >> If the hardware never responds to the stop endpoint command, the >> URBs will never be completed, and we might hang the USB subsystem. >> The original watchdog

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

On 1 December 2016 at 14:04, Baolin Wang wrote: > Hi Baolu, > > On 1 December 2016 at 13:45, Lu Baolu wrote: >> Hi, >> >> On 11/30/2016 05:02 PM, Baolin Wang wrote: >>> If the hardware never responds to the stop endpoint command, the >>> URBs

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

Hi, On 12/01/2016 03:35 PM, Baolin Wang wrote: > On 1 December 2016 at 14:35, Lu Baolu wrote: >> Hi, >> >> On 12/01/2016 02:04 PM, Baolin Wang wrote: >>> Hi Baolu, >>> >>> On 1 December 2016 at 13:45, Lu Baolu wrote: Hi, On

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

Hi, On 11/30/2016 05:02 PM, Baolin Wang wrote: > If the hardware never responds to the stop endpoint command, the > URBs will never be completed, and we might hang the USB subsystem. > The original watchdog timer is used to watch if one stop endpoint > command is timeout, if timeout, then the

Re: [PATCH v2] USB: OHCI: ohci-pxa27x: remove useless functions

On Wed, Nov 30, 2016 at 11:59:49PM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > The ohci_hcd_pxa27x_drv_probe function is not doing anything other > than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe > function is useless that is

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

On 1 December 2016 at 14:35, Lu Baolu wrote: > Hi, > > On 12/01/2016 02:04 PM, Baolin Wang wrote: >> Hi Baolu, >> >> On 1 December 2016 at 13:45, Lu Baolu wrote: >>> Hi, >>> >>> On 11/30/2016 05:02 PM, Baolin Wang wrote: If the hardware

Re: [PATCH] usb: hub: no error logs in case of enomem

On Wed, Nov 30, 2016 at 02:32:07PM +, Atul Raj wrote: > All kmalloc-based functions print enough information on failures. > > Signed-off-by: Atul Raj > --- > drivers/usb/core/hub.c | 1 - > 1 file changed, 1 deletion(-) I told you to wait, relax, and work on

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

On 30 November 2016 at 22:09, Mathias Nyman wrote: > On 30.11.2016 11:02, Baolin Wang wrote: >> >> If the hardware never responds to the stop endpoint command, the >> URBs will never be completed, and we might hang the USB subsystem. >> The original watchdog timer

Re: [PATCH] usb: host: replace symbolic permission with octal

On Wed, Nov 30, 2016 at 01:49:02PM +, Amit Kumar Kushwaha wrote: > This patch handles warning message for preferring octal > permissions over Symbolic permission for module parameter That makes no sense at all. What warning message? Build time? Run time? Please do cleanup patches on

Re: [PATCH 1/1] usb: return error code when platform_get_irq fails

On 30.11.2016 15:41, Matthias Brugger wrote: On 29/11/16 13:57, Pan Bian wrote: In function xhci_mtk_probe(), variable ret takes the return value. Its value should be negative on failures. However, when the call to function platform_get_irq() fails, it does not set the error code, and 0 will

[PATCH] usb: host: replace symbolic permission with octal

This patch handles warning message for preferring octal permissions over Symbolic permission for module parameter Signed-off-by: Amit Kushwaha --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

On 30.11.2016 11:02, Baolin Wang wrote: If the hardware never responds to the stop endpoint command, the URBs will never be completed, and we might hang the USB subsystem. The original watchdog timer is used to watch if one stop endpoint command is timeout, if timeout, then the watchdog timer

[PATCH] usb: hub: no error logs in case of enomem

All kmalloc-based functions print enough information on failures. Signed-off-by: Atul Raj --- drivers/usb/core/hub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index cbb1467..82059f26 100644 --- a/drivers/usb/core/hub.c