Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Mathias Nyman
On 01.12.2016 06:54, Baolin Wang wrote: On 30 November 2016 at 22:09, Mathias Nyman wrote: On 30.11.2016 11:02, Baolin Wang wrote: If the hardware never responds to the stop endpoint command, the URBs will never be completed, and we might hang the USB

[PATCH 00/25] usb: host: xhci: cleanup series

2016-12-01 Thread Felipe Balbi
hi Mathias, here's a much longer series of cleanups which I have been working on for the past few days. Let me know what you think about it. I did some light tests SKL and everything still works as before. I know you have some reservations about my changes to trb_in_td() but IMHO, if we can

[PATCH 03/25] usb: host: xhci: change pre-increments to post-increments

2016-12-01 Thread Felipe Balbi
This is a cleanup patch only, no functional changes. The idea is just to make sure for loops look the same all over the driver. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-dbg.c | 20 ++-- drivers/usb/host/xhci-mem.c | 10 +-

[PATCH 02/25] usb: host: xhci: handle COMP_STOP from SETUP phase too

2016-12-01 Thread Felipe Balbi
Stop Endpoint command can come at any point and we have no control of that. We should make sure to handle COMP_STOP on SETUP phase as well, otherwise urb->actual_lenght might be set to negative values in some occasions such as below: urb->length = 4; build_control_transfer_td_for(urb, ep);

Re: [PATCH v2] USB: OHCI: ohci-s3c2410: remove useless functions

2016-12-01 Thread Alan Stern
On Thu, 1 Dec 2016 csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > The ohci_hcd_s3c2410_drv_probe and ohci_hcd_s3c2410_drv_remove > functions are removed as these are useless functions except calling > usb_hcd_s3c2410_probe and usb_hcd_s3c2410_remove

[PATCH 0/1] USB: serial: option: add support for Telit LE922A PIDs 0x1040, 0x1041

2016-12-01 Thread Daniele Palmas
This patch adds support for PIDs 0x1040, 0x1041 of Telit LE922A. Since the interface positions are the same than the ones used for other Telit compositions, previous defined blacklists are used. Following verbose lsusb output of the two compositions: Bus 003 Device 006: ID 1bc7:1040 Telit

[PATCH 1/1] USB: serial: option: add support for Telit LE922A PIDs 0x1040, 0x1041

2016-12-01 Thread Daniele Palmas
This patch adds support for PIDs 0x1040, 0x1041 of Telit LE922A. Since the interface positions are the same than the ones used for other Telit compositions, previous defined blacklists are used. Signed-off-by: Daniele Palmas --- drivers/usb/serial/option.c | 6 ++ 1 file

[PATCH 23/25] usb: host: xhci: introduce helper to convert a single TRB in no-op

2016-12-01 Thread Felipe Balbi
this will be used in several places to convert a single TRB into No-Op. No functional changes in this patch. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff

[RFC/PATCH 25/25] usb: xhci: host: simplify implementation of trb_in_td()

2016-12-01 Thread Felipe Balbi
trb_in_td() has the task of checking whether a given TRB belongs to a given TD. Currently implementation is far too complex and used wrongly in some places. Let's simplify the implementation to the point that we can assume it to be working always, this means we can remove xhci_test_trb_in_td()

[PATCH 15/25] usb: host: xhci: reorder variable definitions

2016-12-01 Thread Felipe Balbi
no functional changes. Simple cleanup to make sure variables are ordered in a 'reverse christmas tree' fashion. While at that, also remove an obsolete comment which doesn't apply anymore. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 12

[PATCH 18/25] usb: host: xhci: check for a valid ring when unmapping bounce buffer

2016-12-01 Thread Felipe Balbi
This way we can remove checks for valid ring from call sites of xhci_unmap_td_bounce_buffer() Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c

[PATCH 20/25] usb: host: xhci: don't try to mask critical errors

2016-12-01 Thread Felipe Balbi
Instead of fixing actual_length and setting status to 0, let's make sure the error is propagated and we print a big scary stack trace so errors are reported and we have a chance of fixing them. While at that, also remove unnecessary initialization of urb variable. Signed-off-by: Felipe Balbi

[PATCH 24/25] usb: host: xhci: use trb_to_noop() from xhci_handle_stopped_cmd_ring()

2016-12-01 Thread Felipe Balbi
instead of open coding how to convert a TRB to no-op, let's use our newly introduced helper. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c

[PATCH 16/25] usb: host: xhci: introduce xhci_td_cleanup()

2016-12-01 Thread Felipe Balbi
By extracting xhci_td_cleanup() from finish_td(), code before clearer and easier to follow. There are no functional changes with this patch. It's merely a cleanup. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 92

[PATCH 21/25] usb: host: xhci: remove debug argument from trb_in_td()

2016-12-01 Thread Felipe Balbi
By just replacing xhci_warn() with xhci_dbg() we can get rid of the extra argument. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-mem.c | 5 ++--- drivers/usb/host/xhci-ring.c | 10 -- drivers/usb/host/xhci.h | 2 +- 3 files changed, 7

[PATCH 17/25] usb: host: xhci: remove bogus __releases()/__acquires() annotation

2016-12-01 Thread Felipe Balbi
handle_tx_event() is not releasing xhci->lock nor reacquiring it, remove the bogus annotation. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c

[PATCH 19/25] usb: host: xhci: unconditionally call xhci_unmap_td_bounce_buffer()

2016-12-01 Thread Felipe Balbi
xhci_unmap_td_bounce_buffer() already checks for a valid td->bounce_seg and bails out early if that's invalid. There's no need to check for this twice. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 9 +++-- 1 file changed, 3 insertions(+), 6

Re: USB gadget: configfs hid mouse device

2016-12-01 Thread Krzysztof Opasiak
On 12/01/2016 02:35 PM, Sven Geggus wrote: > Hello, > > I'm trying to setup a custom mouse-like device on a pi zero. > > As I have never been using the USB gadget stack before, the following > problem might likely be a configuration failure on my side as well as a > driver issue. > > Using

Re: [BUG 4.9] New led trigger usbport gets the kernel to panic

2016-12-01 Thread Ralph Sennhauser
On Mon, 28 Nov 2016 23:20:13 +0100 Rafal Milecki wrote: > Hi Ralph, > > On 11/21/2016 09:40 AM, Ralph Sennhauser wrote: > > I tried your new usbport trigger in Linux 4.9 with little luck as > > can be seen in the following output of the serial console. > > I'm really happy

Re: [GIT PULL] USB-serial updates for v4.10-rc1

2016-12-01 Thread Greg Kroah-Hartman
On Thu, Dec 01, 2016 at 12:18:49PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are my updates for 4.10. Details below. > > Thanks, > Johan > > > The following changes since commit 07d9a380680d1c0eb51ef87ff2eab5c994949e69: > > Linux 4.9-rc2 (2016-10-23 17:10:14 -0700) > > are available

[PATH net v2] cdc_ether: Fix handling connection notification

2016-12-01 Thread Kristian Evensen
Commit bfe9b9d2df66 ("cdc_ether: Improve ZTE MF823/831/910 handling") introduced a work-around in usbnet_cdc_status() for devices that exported cdc carrier on twice on connect. Before the commit, this behavior caused the link state to be incorrect. It was assumed that all CDC Ethernet devices

Re: [PATCH v3] USB: OHCI: ohci-pxa27x: remove useless functions

2016-12-01 Thread Alan Stern
On Thu, 1 Dec 2016 csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > The ohci_hcd_pxa27x_drv_probe function is not doing anything other > than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe > function is useless that is why removed

[PATCH 22/25] usb: host: xhci: remove unnecessary list_for_each_entry_safe()

2016-12-01 Thread Felipe Balbi
the _save() version of list iterators are supposed to be used when list_entry is going to be removed from the list while iterating. Since xhci_handle_stopped_cmd_ring() is not removing anything from the list, just converting commands into No-Op TRBs, we don't need to use the safe version.

USB gadget: configfs hid mouse device

2016-12-01 Thread Sven Geggus
Hello, I'm trying to setup a custom mouse-like device on a pi zero. As I have never been using the USB gadget stack before, the following problem might likely be a configuration failure on my side as well as a driver issue. Using the documentation from kernel source

[PATCH 05/25] usb: host: xhci: rename completion codes to match spec

2016-12-01 Thread Felipe Balbi
Cleanup only. This patch is a mechaninal rename to make sure our macros for TRB completion codes match what the specification uses to refer to such errors. The idea behind this is that it makes it far easier to grep the specification and match it with implementation. Signed-off-by: Felipe Balbi

[PATCH 06/25] usb: host: xhci: WARN on unexpected COMP_SUCCESS

2016-12-01 Thread Felipe Balbi
COMP_SUCCESS should only be asserted on a *true* sucessful transfer. Any other cases are bogus and we should aim to catch them. One easy way to get bug reports is to trigger a WARN_ONCE() on such cases. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c |

[PATCH 12/25] usb: host: xhci: major rewrite of process_ctrl_td()

2016-12-01 Thread Felipe Balbi
process_ctrl_td() is too complex and difficult to read. We can clean it up a lot and maintain same functionality as before. Note that while cleaning up, one comment was introduced to explain the special case - it wasn't clear before from code. Much of the changes are related to removal of

[PATCH 07/25] usb: host: xhci: WARN() if we interrupt without event_ring

2016-12-01 Thread Felipe Balbi
If we get an interrupt while we don't have an allocated event_ring, that means we're enabling IRQs far too early. Instead of just printing an error message, let's make sure to add a scary-looking Stack Trace so people report these things and we fix them. Eventually, when we're happy that this

[PATCH 04/25] usb: host: xhci: print HCIVERSION on debug

2016-12-01 Thread Felipe Balbi
When calling xhci_dbg_regs() we actually _do_ want to know XHCI's version. This might help figure out why certain problems only happen in some cases. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-dbg.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 01/25] usb: host: xhci: dynamically allocate devs array

2016-12-01 Thread Felipe Balbi
Instead of always defaulting to a 256-entry array, we can dynamically allocate devs based on what HW tells us it supports. Note that we can't, yet, purge MAX_HC_SLOTS completely because of struct xhci_device_context_array reliance on it. Signed-off-by: Felipe Balbi

[PATCH 13/25] usb: host: xhci: major rewrite of process_bulk_intr_td()

2016-12-01 Thread Felipe Balbi
Similar to previous patch on process_ctrl_td(), we can also clean up process_bulk_intr_td() and turn it into an easier to read and maintain function. This patch shuffles code around, defines each variable in one line, removes unnecessary debugging messages and an unnecessary goto statement.

[PATCH 11/25] usb: host: xhci: use slightly better list helpers

2016-12-01 Thread Felipe Balbi
Replace list_entry() with list_first_entry() and list_for_each() with list_for_each_entry(). This makes the code slightly more readable. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)

[PATCH 14/25] usb: host: xhci: cleanup finish_td()

2016-12-01 Thread Felipe Balbi
Now that finish_td() is the only place calling xhci_requires_manual_halt_cleanup() we can remove that function and use that to cleanup finish_td() by converting it into a switch statement using trb_comp_code. Signed-off-by: Felipe Balbi ---

[PATCH 09/25] usb: host: xhci: clear only STS_EINT

2016-12-01 Thread Felipe Balbi
Many other bits in USBSTS register are "clear-by-writing-1". Let's make sure that we clear *only* STS_EINT and not any of the other bits as they might be needed later. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 3 +-- 1 file changed, 1

[PATCH 08/25] usb: host: xhci: simplify irq handler return

2016-12-01 Thread Felipe Balbi
Instead of having several return points, let's use a local variable and a single place to return. This makes the code slightly easier to read. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 31 --- 1 file changed, 16

[PATCH 10/25] usb: host: xhci: remove unneded semicolon

2016-12-01 Thread Felipe Balbi
it does no good, let's remove it. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ext-caps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ext-caps.h b/drivers/usb/host/xhci-ext-caps.h index

[PATCH] usbip: vudc: fix: Clear already_seen flag also for ep0

2016-12-01 Thread Krzysztof Opasiak
ep_list inside gadget structure doesn't contain ep0. It is stored separately in ep0 field. This causes an urb hang if gadget driver decides to delay setup handling. On host side this is visible as timeout error when setting configuration. This bug can be reproduced using for example any gadget

Re: [BUG 4.9] New led trigger usbport gets the kernel to panic

2016-12-01 Thread Rafał Miłecki
On 12/01/2016 03:28 PM, Ralph Sennhauser wrote: Below the oops with your debug patch applied. (...) root@wrt1900acs:/# cd sys/class/leds/pca963x\:shelby\:white\:usb2/ root@wrt1900acs:/sys/devices/platform/soc/soc:internal-regs/f1011000.i2c/i2c-0/0-0068/leds/pca963x:shelby:white:usb2# echo

[PATCH] usbip: vudc: Refactor init_vudc_hw() to be more obvious

2016-12-01 Thread Krzysztof Opasiak
Current implementation of init_vudc_hw() adds ep0 to ep_list and then after looping through all endpoints removes it from that list. As this may be misleading let's refactor this function and avoid adding and removing ep0 to eplist and place it immediately in correct place. Signed-off-by:

Re: [PATCH] usbip: vudc: fix: Clear already_seen flag also for ep0

2016-12-01 Thread Krzysztof Opasiak
Hi, On 12/01/2016 06:26 PM, Sergei Shtylyov wrote: > Hello! > > On 12/01/2016 07:20 PM, Krzysztof Opasiak wrote: > >> ep_list inside gadget structure doesn't contain ep0. >> It is stored separately in ep0 field. >> >> This causes an urb hang if gadget driver decides to >> delay setup handling.

Re: [PATCH] usb: host: xhci: remove braces for single statement

2016-12-01 Thread Greg KH
On Thu, Dec 01, 2016 at 10:42:59PM +0530, Amit Kushwaha wrote: > This patch fixes checkpatch.pl warning: > braces {} are not necessary for single statement blocks > > Signed-off-by: Amit Kushwaha {sigh} Why are you now not using your samsung email address? Please

[PATCH v2] usbip: vudc: fix: Clear already_seen flag also for ep0

2016-12-01 Thread Krzysztof Opasiak
ep_list inside gadget structure doesn't contain ep0. It is stored separately in ep0 field. This causes an urb hang if gadget driver decides to delay setup handling. On host side this is visible as timeout error when setting configuration. This bug can be reproduced using for example any gadget

[PATCH] usb: host: xhci: remove braces for single statement

2016-12-01 Thread Amit Kushwaha
This patch fixes checkpatch.pl warning: braces {} are not necessary for single statement blocks Signed-off-by: Amit Kushwaha --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c

Re: [PATCH] usbip: vudc: fix: Clear already_seen flag also for ep0

2016-12-01 Thread Sergei Shtylyov
Hello! On 12/01/2016 07:20 PM, Krzysztof Opasiak wrote: ep_list inside gadget structure doesn't contain ep0. It is stored separately in ep0 field. This causes an urb hang if gadget driver decides to delay setup handling. On host side this is visible as timeout error when setting

Re: [PATCH v13 03/10] usbip: exporting devices: new connect operation

2016-12-01 Thread Krzysztof Opasiak
Hi, On 11/22/2016 07:48 AM, Nobuo Iwata wrote: > Implementation of new connect operation. This is linked as a part of > usbip commnad. With this patch, usbip command has following operations. > > bind > unbind > list (local/remote) > attach > detach > port > connect ... this patch In

Re: [PATCH v13 01/10] usbip: exporting devices: modifications to network header

2016-12-01 Thread Krzysztof Opasiak
Hi, On 11/22/2016 07:48 AM, Nobuo Iwata wrote: > Modification to export and un-export response in > tools/usb/usbip/src/usbip_network.h. It just changes return code type > from int to uint32_t as same as other responses. > > Signed-off-by: Nobuo Iwata > --- >

Re: [PATCH v13 02/10] usbip: exporting devices: modifications to host side libraries

2016-12-01 Thread Krzysztof Opasiak
On 11/24/2016 06:59 AM, fx IWATA NOBUO wrote: > Hello, > >> This doesn't look like a simple change to rename and reuse an unused >> function. This patch does lot more and is changing the user interface. >> Looks like instead of taking an integer value for device lookup, you >> are changing it

Re: [PATCH] net: asix: Fix AX88772_suspend() USB vendor commands failure issues

2016-12-01 Thread David Miller
From: "ASIX_Allan [Office]" Date: Wed, 30 Nov 2016 16:29:08 +0800 > The change fixes AX88772_suspend() USB vendor commands failure issues. > > Signed-off-by: Allan Chou > Tested-by: Allan Chou > Tested-by: Jon Hunter

Re: [RFC][PATCH 1/3] phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver

2016-12-01 Thread John Stultz
On Thu, Dec 1, 2016 at 12:23 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 23 November 2016 09:16 AM, John Stultz wrote: >> This wires extconn support to hikey's phy driver, and >> connects it to the usb UDC layer via a usb_phy structure. >> >> Not sure if this is the

Re: [PATCH v13 04/10] usbip: exporting devices: new disconnect operation

2016-12-01 Thread Krzysztof Opasiak
On 11/22/2016 07:48 AM, Nobuo Iwata wrote: (...) > + > +static int send_unexport_device(int sockfd, struct usbip_usb_device *udev) > +{ > + int rc; > + struct op_unexport_request request; > + struct op_unexport_reply reply; > + uint16_t code = OP_REP_UNEXPORT; > + > +

Re: [PATCH] usb: gadget: udc: core: fix return code of usb_gadget_probe_driver()

2016-12-01 Thread Felix Hädicke
Hi, > Hi, > > Good catch but I have a few comments to commit message: > > On 12/01/2016 12:24 AM, Felix Hädicke wrote: >> This fixes a regression which was introduced by commit f1bddbb, by >> reverting a small fragment of commit 855ed04. >> > Not exactly. The regression has been introduced by

Re: [PATCH v10 2/8] power: add power sequence library

2016-12-01 Thread Rafael J. Wysocki
On Tue, Nov 22, 2016 at 4:53 AM, Peter Chen wrote: > On Tue, Nov 22, 2016 at 03:23:12AM +0100, Rafael J. Wysocki wrote: >> > @@ -0,0 +1,237 @@ >> > +/* >> > + * core.c power sequence core file >> > + * >> > + * Copyright (C) 2016 Freescale Semiconductor, Inc. >> > + *

Re: [PATCH v13 00/10] usbip: exporting devices

2016-12-01 Thread Krzysztof Opasiak
On 11/23/2016 10:30 AM, Greg KH wrote: > On Tue, Nov 22, 2016 at 03:48:09PM +0900, Nobuo Iwata wrote: >> Dear all, >> >> This series of patches adds exporting device operation to USB/IP. > > I would _love_ it if some of the people who are listed as MAINTAINERS of > this code could actually

[PATCH] usb: hub: Wait for connection to be reestablished after port reset

2016-12-01 Thread Guenter Roeck
On a system with a defective USB device connected to an USB hub, an endless sequence of port connect events was observed. The sequence of events as observed is as follows: - Port reports connected event (port status=USB_PORT_STAT_CONNECTION). - Event handler debounces port and resets it by

Re: [PATCH v13 05/10] usbip: exporting devices: modifications to daemon

2016-12-01 Thread Krzysztof Opasiak
Hi, On 11/22/2016 07:48 AM, Nobuo Iwata wrote: (...) > > -static int do_accept(int listenfd) > +static int do_accept(int listenfd, char *host, char *port) > { > int connfd; > struct sockaddr_storage ss; > socklen_t len = sizeof(ss); > - char host[NI_MAXHOST],

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Baolin Wang
On 2 December 2016 at 09:17, Lu Baolu wrote: > Hi, > > On 12/01/2016 04:03 PM, Baolin Wang wrote: >> On 1 December 2016 at 15:44, Lu Baolu wrote: >>> Hi, >>> >>> On 12/01/2016 03:35 PM, Baolin Wang wrote: On 1 December 2016 at 14:35, Lu

Re: [PATCH 1/1] usb: xhci: fix possible wild pointer

2016-12-01 Thread Baolin Wang
On 2 December 2016 at 10:29, Lu Baolu wrote: > handle_cmd_completion() frees a command structure which might > be still referenced by xhci->current_cmd. This might cause > problem when xhci->current_cmd is accessed after that. > > A real-life case could be like this. The

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Baolin Wang
On 1 December 2016 at 21:28, Mathias Nyman wrote: > On 01.12.2016 06:54, Baolin Wang wrote: >> >> On 30 November 2016 at 22:09, Mathias Nyman >> wrote: >>> >>> On 30.11.2016 11:02, Baolin Wang wrote: If the hardware

[PATCH 1/1] usb: xhci: fix possible wild pointer

2016-12-01 Thread Lu Baolu
handle_cmd_completion() frees a command structure which might be still referenced by xhci->current_cmd. This might cause problem when xhci->current_cmd is accessed after that. A real-life case could be like this. The host takes a very long time to respond to a command, and the command timer is

Re: [PATCH v13 00/10] usbip: exporting devices

2016-12-01 Thread Shuah Khan
On 11/23/2016 10:01 PM, fx IWATA NOBUO wrote: > Hello, > Looks like you removed the text. Let's go back to the goals. Can we use server and client terminology which is we use in instead of App and Dev. It makes lot easier to understand. https://www.kernel.org/doc/readme/tools-usb-usbip-README

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Lu Baolu
Hi, On 12/01/2016 04:03 PM, Baolin Wang wrote: > On 1 December 2016 at 15:44, Lu Baolu wrote: >> Hi, >> >> On 12/01/2016 03:35 PM, Baolin Wang wrote: >>> On 1 December 2016 at 14:35, Lu Baolu wrote: Hi, On 12/01/2016 02:04 PM,

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

2016-12-01 Thread Chanwoo Choi
Hi Felipe, On 2016년 11월 30일 19:36, Felipe Balbi wrote: > > Hi, > > Chanwoo Choi writes: >> This patch uses the resource-managed extcon API for >> extcon_register_notifier() >> and replaces the deprecated extcon API as following: >> - extcon_get_cable_state_() ->

RE: [PATCH v13 03/10] usbip: exporting devices: new connect operation

2016-12-01 Thread fx IWATA NOBUO
Hello, > In my humble opinion connect is not a best name for this operation. Yes. I think connect is not perfect. > it not only starts the connection to a remote server but also> exports > a device. I think that a name like export or attach_to_remote would be > more suitable. (...) I think one

RE: [PATCH v13 04/10] usbip: exporting devices: new disconnect operation

2016-12-01 Thread fx IWATA NOBUO
> > + memset(, 0, sizeof(request)); > > + memset(, 0, sizeof(reply)); > > As in previous patch, you don't need to 0 the reply. I will remove the memset. > sizeof(request.udev)? I will modify. > > + /* check the reply */ > > + if (reply.returncode) { > > + err("recv error

Re: [RFC] usb: host: xhci: Remove the watchdog timer and use command timer to watch stop endpoint command

2016-12-01 Thread Baolin Wang
On 1 December 2016 at 15:44, Lu Baolu wrote: > Hi, > > On 12/01/2016 03:35 PM, Baolin Wang wrote: >> On 1 December 2016 at 14:35, Lu Baolu wrote: >>> Hi, >>> >>> On 12/01/2016 02:04 PM, Baolin Wang wrote: Hi Baolu, On 1 December

Re: [RFC][PATCH 1/3] phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver

2016-12-01 Thread Kishon Vijay Abraham I
Hi, On Wednesday 23 November 2016 09:16 AM, John Stultz wrote: > This wires extconn support to hikey's phy driver, and > connects it to the usb UDC layer via a usb_phy structure. > > Not sure if this is the right way to connect phy -> UDC, > but I'm lacking a clear example. > > Cc: Wei Xu

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

2016-12-01 Thread Felipe Balbi
Hi, John Youn writes: > On 11/30/2016 4:47 AM, Felipe Balbi wrote: >> >> Hi, >> >> Raviteja Garimella writes: >>> Hi Balbi, >>> >>> On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: Hi,

[PATCH] usb: dwc2: fix flags for DMA descriptor allocation in dwc2_hsotg_ep_enable

2016-12-01 Thread Marek Szyprowski
dwc2_hsotg_ep_enable can be called from interrupt context, so all allocations should be done with GFP_ATOMIC flags. This fixes following issue on ARM architecture: [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0x74/0x94) [] (dump_stack) from []

[GIT PULL] USB-serial updates for v4.10-rc1

2016-12-01 Thread Johan Hovold
Hi Greg, Here are my updates for 4.10. Details below. Thanks, Johan The following changes since commit 07d9a380680d1c0eb51ef87ff2eab5c994949e69: Linux 4.9-rc2 (2016-10-23 17:10:14 -0700) are available in the git repository at:

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

2016-12-01 Thread Nicolas Ferre
Le 01/12/2016 à 11:26, Alexandre Belloni a écrit : > Use devm_kasprintf instead of simple kasprintf to free the allocated memory > when needed. > > Suggested-by: Peter Rosin > Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre

[PATCH] usb: gadget: udc: atmel: used managed kasprintf

2016-12-01 Thread Alexandre Belloni
Use devm_kasprintf instead of simple kasprintf to free the allocated memory when needed. Suggested-by: Peter Rosin Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH 1/1] xhci: Put warning message on a single line

2016-12-01 Thread Mathias Nyman
On 01.12.2016 12:17, Alexander Stein wrote: This allows someone to grep for the complete warning message as in; xhci-hcd xhci-hcd.0.auto: USB core suspending device not in U0/U1/U2. Signed-off-by: Alexander Stein --- Thanks, added to queue for 4.11

Re: [PATCH] usb: gadget: udc: core: fix return code of usb_gadget_probe_driver()

2016-12-01 Thread Krzysztof Opasiak
Hi, Good catch but I have a few comments to commit message: On 12/01/2016 12:24 AM, Felix Hädicke wrote: > This fixes a regression which was introduced by commit f1bddbb, by > reverting a small fragment of commit 855ed04. > Not exactly. The regression has been introduced by commit 855ed04

Re: [PATCH] fs: configfs: don't return anything from drop_link

2016-12-01 Thread Christoph Hellwig
Thanks a lot Andrzej! I've applied the patch, but I undid the reformatting of the nvmet code to keep the patch as simple as possible. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 1/1] xhci: Put warning message on a single line

2016-12-01 Thread Alexander Stein
This allows someone to grep for the complete warning message as in; xhci-hcd xhci-hcd.0.auto: USB core suspending device not in U0/U1/U2. Signed-off-by: Alexander Stein --- drivers/usb/host/xhci-hub.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-01 Thread Jassi Brar
From: Jassi Brar Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents creation of streaming_{interval,maxpacket,maxburst} nodes for invalid 'aname' node. Signed-off-by: Jassi Brar --- drivers/usb/gadget/function/uvc_configfs.c

Re: [PATCH v10 2/8] power: add power sequence library

2016-12-01 Thread Peter Chen
On Thu, Dec 01, 2016 at 10:57:24PM +0100, Rafael J. Wysocki wrote: > On Tue, Nov 22, 2016 at 4:53 AM, Peter Chen wrote: > > On Tue, Nov 22, 2016 at 03:23:12AM +0100, Rafael J. Wysocki wrote: > >> > @@ -0,0 +1,237 @@ > >> > +/* > >> > + * core.c power sequence core file

Re: [PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-01 Thread Greg KH
On Fri, Dec 02, 2016 at 11:52:02AM +0530, Jassi Brar wrote: > From: Jassi Brar > > Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents > creation of streaming_{interval,maxpacket,maxburst} nodes for > invalid 'aname' node. > > Signed-off-by: Jassi Brar

Re: [PATCH 05/12] usb: chipdata: Replace the extcon API

2016-12-01 Thread Peter Chen
On Wed, Nov 30, 2016 at 02:57:33PM +0900, Chanwoo Choi wrote: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi

Re: [PATCH 1/1] usb: xhci: fix possible wild pointer

2016-12-01 Thread Lu Baolu
Hi, On 12/02/2016 12:18 PM, Baolin Wang wrote: > On 2 December 2016 at 10:29, Lu Baolu wrote: >> handle_cmd_completion() frees a command structure which might >> be still referenced by xhci->current_cmd. This might cause >> problem when xhci->current_cmd is accessed

Re: [PATCH 1/1] usb: xhci: fix possible wild pointer

2016-12-01 Thread Baolin Wang
On 2 December 2016 at 12:40, Lu Baolu wrote: > Hi, > > On 12/02/2016 12:18 PM, Baolin Wang wrote: >> On 2 December 2016 at 10:29, Lu Baolu wrote: >>> handle_cmd_completion() frees a command structure which might >>> be still referenced by

RE: [PATCH v13 01/10] usbip: exporting devices: modifications to network header

2016-12-01 Thread fx IWATA NOBUO
Hello, > + if (!error) > + reply.returncode = 0; > + else > + reply.returncode = -1; > > It looks a little bit ugly to me that we change the value to be unsigned > and then assign a signed number to it. In addition your compiler is going > to complain if

RE: [PATCH v13 02/10] usbip: exporting devices: modifications to host side libraries

2016-12-01 Thread fx IWATA NOBUO
Hello, > In my humble opinion the code itself is good. The problem is commit > message. Current commit massage has nothing to do with patch content > and should be totally changed. > > Please elaborate that this function is unused, write that using > indexes on a list is generally not a good