Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

On 2 January 2017 at 22:57, Mathias Nyman wrote: > On 27.12.2016 05:07, Baolin Wang wrote: >> >> Hi, >> >> On 21 December 2016 at 21:00, Mathias Nyman >> wrote: >>> >>> On 21.12.2016 04:22, Baolin Wang wrote: Hi

[PATCH 0/8] power: add power sequence library

Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2]. The kinds of power sequence instances will be added at postcore_initcall, the match criteria is compatible string first, if the compatible string is not matched

[PATCH 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48

[PATCH 7/8] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Besides, using gpio pinctrl setting for USB2415's reset pin. Signed-off-by: Peter Chen

[PATCH 3/8] binding-doc: usb: usb-device: add optional properties for power sequence

Add optional properties for power sequence. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH 6/8] ARM: dts: imx6qdl: Enable usb node children with

From: Joshua Clayton Give usb nodes #address and #size attributes, so that a child node representing a permanently connected device such as an onboard hub may be addressed with a attribute Signed-off-by: Joshua Clayton Signed-off-by: Peter

[PATCH 4/8] usb: core: add power sequence handling for USB devices

Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some hard-wired USB devices works abnormal or can't be

[PATCH 5/8] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

From: Peter Chen At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node, we let the

[PATCH 2/8] power: add power sequence library

We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at device tree and handled by related host driver, so we have

[PATCH 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line

From: Joshua Clayton Previously the onboard hub was made to work by treating its reset gpio as a regulator enable. Get rid of that kludge now that pwseq has added reset gpio support Move pin muxing the hub reset pin into the usbh1 group Signed-off-by: Joshua Clayton

[PATCH v2 1/1] usb: xhci: clear EINT bit in status correctly

EINT(Event Interrupt) is a write-1-to-clear type of bit in xhci status register. It should be cleared by writing a 1. Writing 0 to this bit has no effect. Xhci driver tries to clear this bit by writing 0 to it. This is not the right way to go. This patch corrects this by reading the register

Re: [PATCH v6 22/25] usb: chipidea: Drop lock across event_notify during gadget stop

On Wed, Dec 28, 2016 at 02:57:08PM -0800, Stephen Boyd wrote: > The CI_HDRC_CONTROLLER_STOPPED_EVENT may want to call sleeping > APIs similar to how _gadget_stop_activity() may. Let's drop the > lock across the event so that glue drivers can make sleeping > calls. > > Cc: Peter Chen

Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

On Wed, Dec 28, 2016 at 02:57:09PM -0800, Stephen Boyd wrote: > If the phy supports it, call phy_set_mode() to pull up D+ when > required by setting the mode to PHY_MODE_USB_DEVICE. If we want > to remove the pullup, set the mode to PHY_MODE_USB_HOST. > > Cc: Peter Chen > Cc:

Re: [PATCH] USB: cypress_m8: remove unused variable

On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote: > On Sun, Dec 18, 2016 at 10:29:27PM +, Sudip Mukherjee wrote: > > The variable havedata was only being set but never used afterwards. > > > > Signed-off-by: Sudip Mukherjee > > Thanks, I'll queue

Re: [PATCH 09/37] usb: host: xhci: clear only STS_EINT

Hi, Lu Baolu writes: > Hi, > > On 12/30/2016 03:52 PM, Felipe Balbi wrote: >> Hi, >> >> Lu Baolu writes: >>> On 12/29/2016 07:00 PM, Felipe Balbi wrote: Many other bits in USBSTS register are "clear-by-writing-1". Let's make sure

RE: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

Hi Greg, I need to have this infrastructure while implementing DWC3 OTG driver. The current scenario is that we are using xHCI drivers with High-Speed OTG because DWC3 uses xHCI framework. So I wanted to confirm that before adding DWC3 OTG driver, this support should be already there. I am

Re: xHCI issues Reset Device Command at invalid states

On 30.12.2016 14:01, Felipe Balbi wrote: Hi Mathias, So the problem I found with v4.10-rc1 doesn't appear to be a regression. I can't, however, trigger it with Broadwell, only Skylake and Kabylake. According to tracepoints, our Reset Device Command sometimes completes with "Context State

Re: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Jan 02, 2017 at 09:35:21AM +, Manish Narani wrote: > Hi Greg, > > > I need to have

MIDI keyboard doesn't work when USB 3.0 controller is enabled in BIOS

Hello, After switching to a newer laptop my USB MIDI keyboard didn't work anymore. Other USB devices that I have (memory stick and mouse) work well. 2 out of 3 USB ports couldn't keep keyboard turned on (keyboard turns on for a second and then turns off). Only one USB port was able to keep

Re: [PATCH] USB: cypress_m8: remove unused variable

On Mon, Jan 02, 2017 at 10:41:03AM +0100, Johan Hovold wrote: > On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote: > > On Sun, Dec 18, 2016 at 10:29:27PM +, Sudip Mukherjee wrote: > > > The variable havedata was only being set but never used afterwards. > > > > > > Signed-off-by:

Re: xHCI issues Reset Device Command at invalid states

Hi, Felipe Balbi writes: > Hi Mathias, > > So the problem I found with v4.10-rc1 doesn't appear to be a > regression. I can't, however, trigger it with Broadwell, only Skylake > and Kabylake. > > According to tracepoints, our Reset Device Command sometimes

Re: MIDI keyboard doesn't work when USB 3.0 controller is enabled in BIOS

I have tried kernels 4.8.0 and 4.9.0 from Ubuntu repositories. Probably I don't have latest BIOS. BR, Karmo 2017-01-02 15:20 GMT+02:00 Greg KH : > On Mon, Jan 02, 2017 at 11:35:55AM +0200, Karmo Rosental wrote: >> Hello, >> >> After switching to a newer laptop my USB MIDI

Re: [PATCH 30/37] usb: host: xhci: make a generic TRB tracer

Hi, Lu Baolu writes: > Hi, > > On 12/30/2016 03:47 PM, Felipe Balbi wrote: >> Hi, >> >> Lu Baolu writes: +DEFINE_EVENT(xhci_log_trb, xhci_handle_event, + TP_PROTO(struct xhci_ring *ring, struct xhci_generic_trb *trb), +

Re: MIDI keyboard doesn't work when USB 3.0 controller is enabled in BIOS

On Mon, Jan 02, 2017 at 11:35:55AM +0200, Karmo Rosental wrote: > Hello, > > After switching to a newer laptop my USB MIDI keyboard didn't work > anymore. Other USB devices that I have (memory stick and mouse) work > well. > > 2 out of 3 USB ports couldn't keep keyboard turned on (keyboard turns

Re: [PATCH v2] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

On Mon, Dec 19, 2016 at 12:11:15PM +0100, Johan Hovold wrote: > On Sun, Dec 18, 2016 at 10:19:28AM +0100, Geert Uytterhoeven wrote: > > With gcc 4.1.2: > > > > drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’: > > drivers/usb/serial/f81534.c:1250: warning: comparison is always

Re: xHCI issues Reset Device Command at invalid states

On 02.01.2017 14:13, Felipe Balbi wrote: Hi, Felipe Balbi writes: Hi Mathias, So the problem I found with v4.10-rc1 doesn't appear to be a regression. I can't, however, trigger it with Broadwell, only Skylake and Kabylake. According to tracepoints, our Reset

[PATCH] usb: host: xhci: don't issue Reset Device from invalid states

According to Figure 10 Slot State Diagram on xHCI Specification revision 1.1 page 83, it's stated that Reset Device Command is only valid from Slot Context States Configured and Addressed. We shouldn't issue Reset Device Command from any other states. This patch makes sure we're compliant with

[PATCH] USB: ohci-omap: defer probe if PHY is missing

Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs to be loaded to get the PHY going and ohci-omap should wait for those. Signed-off-by: Aaro Koskinen --- drivers/usb/host/ohci-omap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: Thunderbolt adapter fails to instantiate USB and device enumeration if already connected at boot time

On Mon, 2 Jan 2017, Chris Murphy wrote: > crossposting linux-usb@ and linux-pci@ > > I filed a bug https://bugzilla.kernel.org/show_bug.cgi?id=191681 but > was told I need to post to the list first. I'm not actually sure this > is a USB bug, as filed in the bug report, because I think this >

Re: Thunderbolt adapter fails to instantiate USB and device enumeration if already connected at boot time

On Mon, Jan 2, 2017 at 2:28 PM, Alan Stern wrote: > On Mon, 2 Jan 2017, Chris Murphy wrote: > >> crossposting linux-usb@ and linux-pci@ >> >> I filed a bug https://bugzilla.kernel.org/show_bug.cgi?id=191681 but >> was told I need to post to the list first. I'm not

Re: [RFC PATCH] usb: host: xhci: plat: add support for otg_set_host() call

On Mon, Jan 02, 2017 at 06:30:02AM +, Manish Narani wrote: > Ping !! > > -Original Message- > From: Manish Narani [mailto:manish.nar...@xilinx.com] > Sent: Thursday, December 15, 2016 1:24 PM > To: mathias.ny...@intel.com; gre...@linuxfoundation.org; > linux-usb@vger.kernel.org;

Re: dwc3 gadget broken on 4.10-rc1 + Andy's Edison patches

On Sat, 2016-12-31 at 08:34 +0100, Vincent Pelletier wrote: > ...and I should have checked balbi/usb.git:testing/fixes, which > already has a fix for it: >   https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h > =testing/fixes=a3543b33edc746870a540d40bda2916a1d107185 > > Sorry

Re: xHCI issues Reset Device Command at invalid states

Hi, Mathias Nyman writes: > On 30.12.2016 14:01, Felipe Balbi wrote: >> >> Hi Mathias, >> >> So the problem I found with v4.10-rc1 doesn't appear to be a >> regression. I can't, however, trigger it with Broadwell, only Skylake >> and Kabylake. >> >> According to

Thunderbolt adapter fails to instantiate USB and device enumeration if already connected at boot time

crossposting linux-usb@ and linux-pci@ I filed a bug https://bugzilla.kernel.org/show_bug.cgi?id=191681 but was told I need to post to the list first. I'm not actually sure this is a USB bug, as filed in the bug report, because I think this USB-C/Thunderbolt port is really a PCIe port that needs

[PATCH] [PATCH] usb: storage: unusual_uas: Add JMicron JMS56x to unusual device

This device gives the following error on detection. xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or incorrect stream ring The same error is not seen when it is added to unusual_device list with US_FL_NO_REPORT_OPCODES passed. Signed-off-by: George Cherian

Re: MIDI keyboard doesn't work when USB 3.0 controller is enabled in BIOS

On Mon, Jan 02, 2017 at 03:38:40PM +0200, Karmo Rosental wrote: > I have tried kernels 4.8.0 and 4.9.0 from Ubuntu repositories. > Probably I don't have latest BIOS. Try updating it and see if that resolves this issue. thanks, greg k-h -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

On 27.12.2016 05:07, Baolin Wang wrote: Hi, On 21 December 2016 at 21:00, Mathias Nyman wrote: On 21.12.2016 04:22, Baolin Wang wrote: Hi Mathias, On 20 December 2016 at 23:13, Mathias Nyman wrote: On 20.12.2016 09:30, Baolin

Re: [PATCH] [PATCH] usb: storage: unusual_uas: Add JMicron JMS56x to unusual device

On Mon, 2 Jan 2017, Oliver Neukum wrote: > This device gives the following error on detection. > xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or > incorrect stream ring Did you ever determine the reason for this ERROR message? Exactly what is going wrong? Is there a bug

[PATCH] Hi Oliver,

I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or incorrect stream ring This was eliminated using the following scissor patch.

Strange behaviour of U2F usb key

Hello, Kernels 4.1.35 and 4.4.39, on Gentoo boxes. We are trying to set up Yubikey-compatible (made by Plugup) U2F usb keys on our systems, and the keys seems to be randomly detected by the usbhid driver. Since it's for authentication, this seemingly random behaviour is bothersome... Sometimes,

Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

On Sat, Dec 31, 2016 at 4:07 PM, Ansis Atteka wrote: > On Wed, Nov 30, 2016 at 3:58 AM, Hayes Wang wrote: >> Mark Lord >> [...] >>> > Not sure why, because there really is no other way for the data to >>> > appear where it does at the

[PATCH] Revert "usb: gadget: f_hid: use alloc_ep_req()"

This reverts commit ba1582f22231821c57534e87b077d84adbc15dbd. I am getting a null pointer dereference when setting up an hid gadget using configfs. Reverting this commit fixes the crash. dmesg: [ 382.406622] Unable to handle kernel NULL pointer dereference at virtual address 0002 [

[PATCH] usb: gadget: Fix copy/pasted error message

This fixes an error message that was probably copied and pasted. The same message is used for both the in and out endpoints, so it makes it impossible to know which one actually failed because both cases say "IN". Make the out endpoint error message say "OUT". Signed-off-by: David Lechner

Re: xHCI issues Reset Device Command at invalid states

On Mon, 2 Jan 2017, Mathias Nyman wrote: > On 30.12.2016 14:01, Felipe Balbi wrote: > > > > Hi Mathias, > > > > So the problem I found with v4.10-rc1 doesn't appear to be a > > regression. I can't, however, trigger it with Broadwell, only Skylake > > and Kabylake. > > > > According to

Re: [PATCH 09/37] usb: host: xhci: clear only STS_EINT

Hi, On 01/02/2017 04:47 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> Hi, >> >> On 12/30/2016 03:52 PM, Felipe Balbi wrote: >>> Hi, >>> >>> Lu Baolu writes: On 12/29/2016 07:00 PM, Felipe Balbi wrote: > Many other bits in

Re: [PATCH 30/37] usb: host: xhci: make a generic TRB tracer

Hi, On 01/02/2017 04:53 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> Hi, >> >> On 12/30/2016 03:47 PM, Felipe Balbi wrote: >>> Hi, >>> >>> Lu Baolu writes: > +DEFINE_EVENT(xhci_log_trb, xhci_handle_event, > + TP_PROTO(struct

Re: xHCI issues Reset Device Command at invalid states

Hi, Alan Stern writes: > On Mon, 2 Jan 2017, Mathias Nyman wrote: > >> On 30.12.2016 14:01, Felipe Balbi wrote: >> > >> > Hi Mathias, >> > >> > So the problem I found with v4.10-rc1 doesn't appear to be a >> > regression. I can't, however, trigger it with Broadwell,