Re: [PATCH 36/37] usb: host: xhci: add xhci_virt_device tracer

Hi, On 12/29/2016 07:01 PM, Felipe Balbi wrote: > Let's start tracing at least part of an xhci_virt_device lifetime. We > might want to extend this tracepoint class later, but for now it already > exposes quite a bit of valuable information. > > Signed-off-by: Felipe Balbi

RE: [PATCH v3 2/3] USB3/DWC3: Add property "snps, incr-burst-type-adjustment" for INCR burst type

Hi, Jerry Huang writes: >> > On Thu, Dec 22, 2016 at 8:52 PM, Jerry Huang >> wrote: >> > > Hi, Rob, >> > >> -Original Message- >> > >> From: Rob Herring [mailto:r...@kernel.org] >> > >> Sent: Friday, December 23, 2016 2:45 AM >> > >> To: Jerry

RE: [PATCH v3 2/3] USB3/DWC3: Add property "snps, incr-burst-type-adjustment" for INCR burst type

> -Original Message- > From: Jerry Huang > Sent: Wednesday, January 04, 2017 10:25 AM > To: 'Rob Herring' > Cc: ba...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; li...@armlinux.org.uk; devicet...@vger.kernel.org; >

Re: [PATCH 1/9] usb: dwc2: Cleanup some checkpatch issues

John Youn writes: > This commmit is the result of running checkpatch --fix. > > The results were verified for correctness. Some of the fixes result in > line over 80 char which we will fix manually later. > > The following is a summary of what was done by checkpatch: > *

Re: [PATCH 30/37] usb: host: xhci: make a generic TRB tracer

Hi, Lu Baolu writes: + __entry->type = ring->type; + __entry->field0 = le32_to_cpu(trb->field[0]); + __entry->field1 = le32_to_cpu(trb->field[1]); + __entry->field2 = le32_to_cpu(trb->field[2]); +

Re: [PATCH 31/37] usb: host: xhci: add urb_enqueue/dequeue/giveback tracers

Hi, Lu Baolu writes: > Hi, > > On 12/29/2016 07:01 PM, Felipe Balbi wrote: >> These three new tracers will help us tie TRBs into URBs by *also* >> looking into URB lifetime. > > I didn't see anything related to TRBs in the patch. > Anything I missed? yes. Ordering of

Re: [PATCH 1/4] phy: sun4i-usb: add support for V3s USB PHY

On Friday 06 January 2017 07:26 PM, Maxime Ripard wrote: > On Tue, Jan 03, 2017 at 11:25:31PM +0800, Icenowy Zheng wrote: >> Allwinner V3s come with a USB PHY controller slightly different to other >> SoCs, with only one PHY. >> >> Add support for it. >> >> Signed-off-by: Icenowy Zheng

Re: [PATCH 36/37] usb: host: xhci: add xhci_virt_device tracer

Hi, Lu Baolu writes: > Hi, > > On 12/29/2016 07:01 PM, Felipe Balbi wrote: >> Let's start tracing at least part of an xhci_virt_device lifetime. We >> might want to extend this tracepoint class later, but for now it already >> exposes quite a bit of valuable

Re: [PATCH v2 1/6] usb: dwc3: omap: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi >

Re: [PATCH 01/21] usb: dwc2: Cleanup some checkpatch issues

John Youn writes: > This commmit is the result of running checkpatch --fix. > > The results were verified for correctness. Some of the fixes result in > line over 80 char which we will fix manually later. > > The following is a summary of what was done by checkpatch: > *

Re: [PATCH v2 1/2] dt-bindings: usb: add DT binding for s3c2410 USB device controller

Hi, Sergio Prado writes: > Adds the device tree bindings description for Samsung S3C2410 and > compatible USB device controller. > > Signed-off-by: Sergio Prado without Ack from DT folks, I can't take this. -- balbi signature.asc

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

Hi, John Stultz writes: > Basically when plugging in various cables in different orders, I'm > occasionally seeing the following BUG splat: > > [ 86.215403] BUG: scheduling while atomic: kworker/u16:2/53/0x0002 > [ 86.219164] usb 1-1: USB disconnect, device

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

Hi Mathias, On 13 December 2016 at 15:49, Baolin Wang wrote: > Enable the xhci plat runtime PM for parent device to suspend/resume xhci. > Also call pm_runtime_get_noresume() in probe() function in case the parent > device doesn't call suspend/resume callback by runtime

Re: [RFC][PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

Hi, John Stultz writes: > I just wanted to re-send my current queue of patches for dwc2 > controller on the HiKey board, as my last patchset ended up > colliding with a number of changes that landed in the 4.10-rc > merge window. > > I've fixed things up and validated

Re: [PATCH v5 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: > For some mobile devices with strict power management, we also want to suspend > the host when the slave is detached for power saving. Thus we add the host > suspend/resume functions to support this requirement. > > Signed-off-by: Baolin Wang

Re: [PATCH v5 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, On 16 January 2017 at 18:28, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> For some mobile devices with strict power management, we also want to suspend >> the host when the slave is detached for power saving. Thus we add the host >>

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

On 16/01/2017 at 12:27:04 +0200, Felipe Balbi wrote : > > Hi, > > David Laight writes: > > From: Alexandre Belloni > >> Sent: 02 December 2016 16:19 > >> On 02/12/2016 at 15:59:57 +, David Laight wrote : > >> > From: Alexandre Belloni > >> > > Sent: 01 December 2016

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

Hi, Alexandre Belloni writes: >> David Laight writes: >> > From: Alexandre Belloni >> >> Sent: 02 December 2016 16:19 >> >> On 02/12/2016 at 15:59:57 +, David Laight wrote : >> >> > From: Alexandre Belloni >> >> > > Sent: 01

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, On 16 January 2017 at 19:29, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi, >> >> On 16 January 2017 at 18:56, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Baolin Wang writes: When handing the

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: > Hi, > > On 16 January 2017 at 19:29, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> Hi, >>> >>> On 16 January 2017 at 18:56, Felipe Balbi wrote: Hi,

RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

Hi, David Laight writes: > From: Alexandre Belloni >> Sent: 02 December 2016 16:19 >> On 02/12/2016 at 15:59:57 +, David Laight wrote : >> > From: Alexandre Belloni >> > > Sent: 01 December 2016 10:27 >> > > Use devm_kasprintf instead of simple kasprintf to free the

Re: Standard USB Descriptor question

On Sun, Jan 15, 2017 at 07:03:34PM -0800, bruce m beach wrote: > On 1/13/17, Greg KH wrote: > > On Fri, Jan 13, 2017 at 07:24:10PM -0800, bruce m beach wrote: > >> Hello everybody > >> > >> I have been stuck for ages trying to figure out something > >> in the

Re: [PATCH 2/2] usb: gadget: uac2: add req_number as parameter

Hi, Peter Chen writes: > There are only two requests for uac2, it may not be enough at high > loading system which usb interrupt handler can't be serviced on > time, then the data will be lost since it is isoc transfer for audio. > > In this patch, we introduce a parameter

Re: [PATCH v2] USB: cypress_m8: remove unused variable

On Tue, Jan 03, 2017 at 09:01:10PM +, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > The variable havedata was only being set but never used afterwards. > > Signed-off-by: Sudip Mukherjee > --- > > v2: changed the from

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: > Hi, > > On 16 January 2017 at 18:56, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> When handing the SETUP packet by composite_setup(), we will release the >>> dwc->lock. If we get the

[PATCH 3/4] usb: dwc3: gadget: allocate bounce buffer for unaligned xfers

Allocate a coherent buffer of 1024 bytes (size of a single superspeed bulk packet) to serve as bounce buffer for an extra TRB needed to align transfers to wMaxPacketSize. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/gadget.c

Re: [PATCH v2 09/14] USB: serial: ch341: fix control-message error handling

On Wed, Jan 11, 2017 at 12:08:23PM +0100, Johan Hovold wrote: > On Fri, Jan 06, 2017 at 07:15:18PM +0100, Johan Hovold wrote: > > A short control transfer would currently fail to be detected, something > > which could lead to stale buffer data being used as valid input. > > > > Check for short

[PATCH 4/4] usb: dwc3: gadget: align transfers to wMaxPacketSize

Instead of passing quirk_ep_out_aligned_size, we can use one extra TRB to align transfer to wMaxPacketSize. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/gadget.c | 69 +-- 2 files

[PATCH 1/4] usb: dwc3: gadget: simplify dwc3_prepare_one_trb()

We are already passing struct dwc3_request * to dwc3_prepare_one_trb(), because of that there's no need to extract dma address and length in the caller. We can let dwc3_prepare_one_trb() itself handle that part. This simplifies the prototype of the function by removing two arguments.

Re: [PATCH] usb: dwc2: host: use msleep() for long delays

Hi, John Youn writes: > On 1/12/2017 7:52 AM, Nicholas Mc Guire wrote: >> ulseep_range() uses hrtimers and provides no advantage over msleep() >> for larger delays. Fix up the 20+ ms delays here passing the adjusted "min" >> value to msleep(). This helps reduce the load

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

Hi, John Youn writes: >> Baolin Wang writes: Baolin Wang writes: > When dwc3 controller acts as host role with attaching slow speed device > (like mouse or keypad). Then if we plugged out the slow speed

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: > When handing the SETUP packet by composite_setup(), we will release the > dwc->lock. If we get the 'USB_GADGET_DELAYED_STATUS' result from setup > function, which means we need to delay handling the STATUS phase. this sentence needs a little

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, On 16 January 2017 at 18:56, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> When handing the SETUP packet by composite_setup(), we will release the >> dwc->lock. If we get the 'USB_GADGET_DELAYED_STATUS' result from setup >> function, which

[PATCH 2/4] usb: dwc3: gadget: extract __dwc3_prepare_one_trb()

This new internal function will be used to solve a minor issue with dwc3 which exists in regards to short packets with OUT endpoints. Currently we're asking gadget driver to *always* send us aligned requests; however if we have enough TRBs we can easily append one extra TRB chained to the previous

Re: [PATCH 6/6] USB: serial: kl5kusb105: fix port-settings error handling

On Tue, Jan 10, 2017 at 12:05:42PM +0100, Johan Hovold wrote: > Fix port-settings error handling in order to detect a short transfer. > > Note that this currently only implies that an error is logged. > > Signed-off-by: Johan Hovold > > --- > drivers/usb/serial/kl5kusb105.c |

[PATCH] media/usb: Fix pctv452e

Commit 73d5c5c864f40 made sure that media/usb drivers don't do DMA on stack. That made pctv452e oops while initialising: [...] BUG: unable to handle kernel NULL pointer dereference at (null) [...] [9.051527] [] mutex_lock+0x17/0x30 [9.051531] [] pctv452e_power_ctrl+0x85/0x190

[PATCH v3 3/6] usb: phy: omap-otg: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Cc: linux-o...@vger.kernel.org Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi

[PATCH v3 1/6] usb: dwc3: omap: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Cc: linux-o...@vger.kernel.org Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi

Re: [PATCH] usb: dwc3 dwc3_exynos_probe() change goto labels to meaningful names

Hi, Shuah Khan writes: > Change goto labels to meaningful names from a series of errNs. > > Signed-off-by: Shuah Khan doesn't apply to testing/next, please rebase. -- balbi signature.asc Description: PGP signature

Re: Memory barrier needed with wake_up_process()?

Hi, Alan Stern writes: > On Tue, 20 Sep 2016, Felipe Balbi wrote: > >> And here's trace output (complete, scroll to bottom). It seems to me >> like the thread didn't wake up at all. It didn't even try to >> execute. I'll add some more traces and try to get better

[PATCH v3 4/6] usb: phy: qcom-8x16-usb: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi ---

[PATCH v3 2/6] usb: phy: msm: Replace the extcon API

This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi ---

[PATCH v3 5/6] usb: phy: tahvo: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_set_cable_state_() -> extcon_set_state_sync() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi --- drivers/usb/phy/phy-tahvo.c | 10 +- 1 file changed, 5

[PATCH v3 6/6] usb: renesas_usbhs: Replace the deprecated extcon API

This patch replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi Acked-by: Yoshihiro Shimoda ---

Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver

Hi, Arnd Bergmann writes: > On Friday, January 6, 2017 12:29:12 PM CET Raviteja Garimella wrote: >> Hi Arnd, >> >> On Fri, Jan 6, 2017 at 3:33 AM, Arnd Bergmann wrote: >> > On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: >> >> The UDC is

usb: gadger: f_fs: Do not copy past descriptor end.

Endpoint descriptors come in 2 sizes, struct usb_endpoint_descriptor being the largest. Take bLength into account to not copy past the endpoint descriptor end, which could be the next descriptor or past interface descriptor (by 2 bytes). Signed-off-by: Vincent Pelletier

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

Hi, Heiner Kallweit writes: > Set the iomem parameters in the usb_hcd to fix this misleading > message during driver load: > dwc2 c910.usb: irq 22, io mem 0x > > Signed-off-by: Heiner Kallweit > --- > drivers/usb/dwc2/core.h | 3 ++-

[PATCH v3 0/6] usb: Replace the deprecated extcon API

This patches just replace the deprecated extcon API without any change of extcon operation and use the resource-managed function for extcon_register_notifier(). The new extcon API instead of deprecated API. - extcon_set_cable_state_() -> extcon_set_state_sync(); - extcon_get_cable_state_() ->

Re: usb: gadger: f_fs: Do not copy past descriptor end.

Hi, Vincent Pelletier writes: > Endpoint descriptors come in 2 sizes, struct usb_endpoint_descriptor being > the largest. Take bLength into account to not copy past the endpoint > descriptor end, which could be the next descriptor or past interface > descriptor (by 2

[PATCHv2] usb: dwc2: gadget: Fix GUSBCFG.USBTRDTIM value

USBTrdTim must be programmed to 0x5 when phy has a UTMI+ 16-bit wide interface or 0x9 when it has a 8-bit wide interface. GUSBCFG reset value (Value After Reset: 0x1400) sets USBTrdTim to 0x5. In case of 8-bit UTMI+, without clearing GUSBCFG.USBTRDTIM mask, USBTrdTim results in 0xD (0x5 | 0x9).

Re: [PATCHv15 2/3] usb: USB Type-C connector class

On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCH] USB: serial: opticon: fix CTS retrieval at open

On Fri, Jan 13, 2017 at 01:41:47PM +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 13, 2017 at 01:21:08PM +0100, Johan Hovold wrote: > > The opticon driver used a control request at open to trigger a CTS > > status notification to be sent over the bulk-in pipe. When the driver > > was converted to

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

Obviously there is some sort of communications problem. Either the device stopped transferring data or else the xHCI host controller stopped receiving it. From the usbmon trace, there's no way to tell which. However, if the device works okay with an EHCI host controller or on another

[PATCHv15 1/3] lib/string: add sysfs_match_string helper

Make a simple helper for matching strings with sysfs attribute files. In most parts the same as match_string(), except sysfs_match_string() uses sysfs_streq() instead of strcmp() for matching. This is more convenient when used with sysfs attributes. Signed-off-by: Heikki Krogerus

[PATCHv15 2/3] usb: USB Type-C connector class

The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and

[PATCHv15 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

This adds driver for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. Signed-off-by: Heikki Krogerus Reviewed-by: Mika Westerberg --- drivers/usb/typec/Kconfig

[PATCHv15 0/3] USB Type-C Connector class

The USB Type-C class is meant to provide unified interface to the userspace to present the USB Type-C ports in a system. Changes since v14: - Fixes proposed by Mika - "identity" directory for all discover identity VDOs instead of "vdo" attribute - alternate mode device names to just "svid-"

Re: functionfs on dwc3, xhci host: endpoint cannot be used in both directions ?

On Mon, 16 Jan 2017 09:06:20 +0200, Felipe Balbi wrote: > it's actually pretty important :-) Will do then, although maybe not before this week-end. There is something I do not get about this though: the protocol analyser does find IN tokens directed at the right

Re: USB: OHCI: high softirq load

[ +CC: linux-usb ] On Mon, Jan 16, 2017 at 12:14:03PM +0100, Boris Brezillon wrote: > On Mon, 16 Jan 2017 11:54:23 +0100 > Antoine Aubert wrote: > > > Also, I made a big misunderstanding > > > > With EHCI + OHCI = high level of softirq (USB2.0) > > Well, the number of

Re: usb: gadger: f_fs: Do not copy past descriptor end.

On Mon, 16 Jan 2017 15:30:15 +0200, Felipe Balbi wrote: > so we need min() here? desc->bLength should always contain correct size. It should, yes, there is a check when parsing descriptors. I was a bit worried at removing the "natural" maximum size (the one declared

Re: [PATCHv15 2/3] usb: USB Type-C connector class

On Mon, Jan 16, 2017 at 04:35:24PM +0100, Greg KH wrote: > On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C connectors

Re: [PATCH 32/37] usb: host: xhci: switch to running avg trb length

On 29.12.2016 13:01, Felipe Balbi wrote: It's unlikely that we will ever know the avg so instead of assuming it'll be something really large, we will calculate the avg as we go as mentioned in XHCI specification section 4.14.1.1. Signed-off-by: Felipe Balbi ---

Re: Memory barrier needed with wake_up_process()?

On Mon, 16 Jan 2017, Felipe Balbi wrote: > Sorry for the long delay, I finally have more information on this. All > this time I was doing something that I never considered to matter: I've > been running host and peripheral on the same machine. Now that I have > tracepoints on xHCI as well, I

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

On Mon, 16 Jan 2017, Felipe Balbi wrote: > Another point here is that the really robust way of fixing this is to > get rid of USB_GADGET_DELAYED_STATUS altogether and just make sure > gadget drivers know how to queue requests for all three phases of a > Control Transfer. >

Re: [PATCH 36/37] usb: host: xhci: add xhci_virt_device tracer

Hi, On 01/16/2017 05:08 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> Hi, >> >> On 12/29/2016 07:01 PM, Felipe Balbi wrote: >>> Let's start tracing at least part of an xhci_virt_device lifetime. We >>> might want to extend this tracepoint class later, but for

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, On 16 January 2017 at 20:06, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi, >> >> On 16 January 2017 at 19:29, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Baolin Wang writes: Hi, On

Re: [PATCH 2/2] usb: gadget: uac2: add req_number as parameter

On Mon, Jan 16, 2017 at 12:40:06PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > There are only two requests for uac2, it may not be enough at high > > loading system which usb interrupt handler can't be serviced on > > time, then the data will be lost since

RE: [PATCH v14 02/10] usbip: exporting devices: modifications to host side libraries

Hello Shuah, > Way too many changes in this one patch. > This is not an accurate description. You are really changing look ups using > bus-id instead bus-num and whether usbip_get_device() is used or not is > irrelevant. > Please don't include exporting bind_device() and unbind_device() and >

[PATCH v2] usb: host: xhci: plat: check hcc_params after add hcd

From: William wu The commit 4ac53087d6d4 ("usb: xhci: plat: Create both HCDs before adding them") move add hcd to the end of probe, this cause hcc_params uninitiated, because xHCI driver sets hcc_params in xhci_gen_setup() called from usb_add_hcd(). This patch checks

RE: [PATCH v14 02/10] usbip: exporting devices: modifications to host side libraries

Dear Krzysztof, > Great. Now make this a separate patch and send separated from this > series. I'd like to separate a patch to remove unused old usbip_get_device() method from this series. Exported bind/unbind() and new finding device method are used only by new operations. So I'd like to

Re: [PATCH 31/37] usb: host: xhci: add urb_enqueue/dequeue/giveback tracers

Hi, On 01/16/2017 04:59 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> Hi, >> >> On 12/29/2016 07:01 PM, Felipe Balbi wrote: >>> These three new tracers will help us tie TRBs into URBs by *also* >>> looking into URB lifetime. >> I didn't see anything related to

Re: [PATCH 30/37] usb: host: xhci: make a generic TRB tracer

Hi, On 01/16/2017 04:55 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: > + __entry->type = ring->type; > + __entry->field0 = le32_to_cpu(trb->field[0]); > + __entry->field1 = le32_to_cpu(trb->field[1]); > +

RE: [PATCH v14 01/10] usbip: exporting devices: modifications to network header

Hello, > > This patch set implements operations to export and unexport device > > using pre-defined but un-used export and un-export request and reply. > > Get rid of the above from the changelog. I will remove it. > Please don't use file names, instead reference the structures. I see. I will

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Alan Stern writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> Another point here is that the really robust way of fixing this is to >> get rid of USB_GADGET_DELAYED_STATUS altogether and just make sure >> gadget drivers know how to queue

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

Am 16.01.2017 um 15:05 schrieb Felipe Balbi: > > Hi, > > Heiner Kallweit writes: >> Set the iomem parameters in the usb_hcd to fix this misleading >> message during driver load: >> dwc2 c910.usb: irq 22, io mem 0x >> >> Signed-off-by: Heiner Kallweit

Re: Memory barrier needed with wake_up_process()?

Hi, Alan Stern writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> Sorry for the long delay, I finally have more information on this. All >> this time I was doing something that I never considered to matter: I've >> been running host and peripheral on the same

Re: Memory barrier needed with wake_up_process()?

Hi, Felipe Balbi writes: > Alan Stern writes: >> On Mon, 16 Jan 2017, Felipe Balbi wrote: >> >>> Sorry for the long delay, I finally have more information on this. All >>> this time I was doing something that I never considered to

Re: [RFC][PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On Mon, Jan 16, 2017 at 2:29 AM, Felipe Balbi wrote: > > Hi, > > John Stultz writes: >> I just wanted to re-send my current queue of patches for dwc2 >> controller on the HiKey board, as my last patchset ended up >> colliding with a number of

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

On Mon, Jan 16, 2017 at 2:36 AM, Felipe Balbi wrote: > > Hi, > > John Stultz writes: >> Basically when plugging in various cables in different orders, I'm >> occasionally seeing the following BUG splat: >> >> [ 86.215403] BUG: scheduling

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

On Mon, Jan 16, 2017 at 12:57 PM, John Youn wrote: > > >> On Jan 16, 2017, at 12:37 PM, John Stultz wrote: >> >> On Mon, Jan 16, 2017 at 2:36 AM, Felipe Balbi >> wrote: >>> >>> Hi, >>> >>> John Stultz

Re: [linux-sunxi] [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode

Dne 16.1.2017 v 20:14 Icenowy Zheng napsal(a): > The PHY0 on H3 can be wired either to MUSB controller or OHCI/EHCI > controller. > > The original driver wired it to OHCI/EHCI controller; however, as the > code to use PHY0 as OHCI/EHCI is missing, it makes the PHY fully > unusable. > > Rename

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Tony Lindgren [170113 14:00]: > * Grygorii Strashko [170113 13:37]: > > > Simplified diff with fix on top of your patch: > > > > > > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c > > > index ce37a1a..9e9403a 100644 > > > ---

Re: USB: OHCI: high softirq load

Thanks Johan, you save my day. Indeed, soft irq coming from ftdi_sio updates, with very high rate. (dyndbg='file drivers/usb/* +p') reducing latency timer = reducing sofirq. Problem solved. Antoine Aubert a.aub...@overkiz.com Le 16/01/2017 à 15:47, Johan Hovold a écrit : > [ +CC: linux-usb ]

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

> On Jan 16, 2017, at 12:37 PM, John Stultz wrote: > > On Mon, Jan 16, 2017 at 2:36 AM, Felipe Balbi > wrote: >> >> Hi, >> >> John Stultz writes: >>> Basically when plugging in various cables in different orders,

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Tony Lindgren [170116 15:36]: > * Tony Lindgren [170113 14:00]: > > * Grygorii Strashko [170113 13:37]: > > > > Simplified diff with fix on top of your patch: > > > > > > > > diff --git a/drivers/dma/cppi41.c