Re: [PATCH v2 13/17] phy: qcom-qmp: Add support for QMP V3 USB3 PHY

On 9/27/2017 11:29 PM, Jack Pham wrote: > On Wed, Sep 27, 2017 at 02:29:09PM +0530, Manu Gautam wrote: >> QMP V3 USB3 PHY is a DP USB combo PHY with >> dual RX/TX lanes to support type-c. There is a >> separate block DP_COM for configuration related >> to type-c or DP. Add support for dp_com

Re: Issue with Gadget UVC and dummy_hcd

On 26 September 2017 at 06:28, Alan Stern wrote: > > On Mon, 25 Sep 2017, David Tulloh wrote: > > > Hi, > > > > I have been trying to get a UVC gadget running through configfs and > > wired in to dummy_hcd. > > ... > > Does uvc use isochronous transfers? I assume it

Re: [PATCHv2 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

-method/20171005-144320 base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next config: x86_64-randconfig-b0-10051313 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save the attached .config to linux build tree make ARCH=x86_64

RE: [PATCH] usb: renesas_usbhs: Use of_device_get_match_data() helper

Hi, > From: Geert Uytterhoeven, Sent: Wednesday, October 4, 2017 9:27 PM > > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven Thank you for the patch! Reviewed-by: Yoshihiro Shimoda

[PATCH 11/13] xhci: allow TRACE to work with EVENT ring dequeue

From: Adam Wallis inc_deq() currently bails earlier for EVENT rings than the common return point of the function, due to the fact that EVENT rings do not have link TRBs. The unfortunate side effect of this is that the very useful trace_xhci_inc_deq() function is not

[PATCH 07/13] usb: xhci: Return error when host is dead in xhci_disable_slot()

From: Lu Baolu xhci_disable_slot() is a helper for disabling a slot when a device goes away or recovers from error situations. Currently, it returns success when it sees a dead host. This is not the right way to go. It should return error and let the invoker know that

[PATCH 08/13] usb: xhci: Remove xhci->mutex from xhci_alloc_dev()

From: Lu Baolu xhci->mutex was added in xhci_alloc_dev() to protect two race sources (xhci->slot_id and xhci->addr_dev) by commit a00918d0521d ("usb: host: xhci: add mutex for non-thread-safe data"). While xhci->slot_id has been discarded in commit c2d3d49bba08 ("usb:

[PATCH 05/13] usb: xhci: Fix potential memory leak in xhci_disable_slot()

From: Lu Baolu xhci_disable_slot() allows the invoker to pass a command pointer as paramenter. Otherwise, it will allocate one. This will cause memory leak when a command structure was allocated inside of this function while queuing command trb fails. Another problem

[PATCH 12/13] xhci: trace slot context when calling xhci_configure_endpoint()

Add trace showing content of input slot context for configure endpoint and evaluate context commands Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-trace.h | 5 + drivers/usb/host/xhci.c | 4 2 files changed, 9 insertions(+) diff --git

[PATCH 10/13] usb: xhci: reduce device initiated resume time variance.

From: Anshuman Gupta This patch will improve the variable auto-resume latency of an usb-port. The attempt to sync the start of root hub polling with resume time signaling finish was ruined by a later request to start immediate root hub polling. When xhci gets a port

[PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

From: Geert Uytterhoeven Use the of_device_get_match_data() helper instead of open coding. Signed-off-by: Geert Uytterhoeven Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-plat.c | 8 1 file

[PATCH 06/13] usb: xhci: Fix memory leak when xhci_disable_slot() returns error

From: Lu Baolu If xhci_disable_slot() returns success, a disable slot command trb was queued in the command ring. The command completion handler will free the virtual device data structure associated with the slot. On the other hand, when xhci_disable_slot() returns

[PATCH 09/13] usb: xhci: Handle USB transaction error on address command

From: Lu Baolu Xhci driver handles USB transaction errors on transfer events, but transaction errors are possible on address device command completion events as well. The xHCI specification (section 4.6.5) says: A USB Transaction Error Completion Code for an Address

[PATCH 00/13] xhci features for usb-next

Hi Greg Some xhci features for 4.15. Adds debugfs and more tracing for xhci, improves resume time among other changes. -Mathias Adam Wallis (1): xhci: allow TRACE to work with EVENT ring dequeue Anshuman Gupta (1): usb: xhci: reduce device initiated resume time variance. Geert

Re: [PATCH v2 14/17] phy: qcom-qusb2: Set vbus sw-override signal in device mode

Hi Jack, On 9/28/2017 10:23 PM, Jack Pham wrote: > Hi Manu, > > On Thu, Sep 28, 2017 at 09:30:38AM +0530, Manu Gautam wrote: >> On 9/28/2017 12:46 AM, Jack Pham wrote: >>> On Wed, Sep 27, 2017 at 10:57:41AM -0700, Jack Pham wrote: On Wed, Sep 27, 2017 at 02:29:10PM +0530, Manu Gautam wrote:

Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper

On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman -- To unsubscribe from this list: send

Re: Random xHCI HC died on device disconnect

Hi, On Wed, Oct 4, 2017 at 12:16 PM, Mathias Nyman wrote: > This is the xhci->cmd_timer (delayed work) that has a five second timeout > for the currently processing command on the command ring. > When triggered it will abort the current command by stopping the

RE: [PATCH] usb: gadget: udc: renesas_usb3: Use of_device_get_match_data() helper

Hi, > From: Geert Uytterhoeven, Sent: Wednesday, October 4, 2017 9:24 PM > > Use the of_device_get_match_data() helper instead of open coding, > postponing the matching until when it's really needed. > Note that the renesas_usb3 driver is used with DT only, so there's > always a valid match. >

Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper

On 05.10.2017 12:19, Simon Horman wrote: On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: Use the of_device_get_match_data() helper instead of open coding. Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman

Re: [PATCH v4 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

On Thu, 28 Sep 2017 11:46:23 +0200 Romain Izard wrote: > During backup mode, the contents of all registers will be cleared as the > SoC will be completely powered down. For a product that boots on NAND > Flash memory, the bootloader will obviously use the related

Re: Random xHCI HC died on device disconnect

Hi Mathias, On 10/4/2017 3:46 PM, Mathias Nyman wrote: > On 03.10.2017 18:27, Kristian Evensen wrote: >> On Tue, Oct 3, 2017 at 4:51 PM, Kristian Evensen >> wrote: > This is the xhci->cmd_timer (delayed work) that has a five second timeout > for the currently

[PATCH 02/13] xhci: add port speed ID to portsc tracing

Shows the port speed protocol speed ID (PSID) in use. speed ID may map to custom speeds, but in most cases it uses default 1 = Full-Speed12 MB/s 2 = Low-Speed 1.5 Mb/s 3 = High-speed480 Mb/s 4 = SuperSpeed5 Gb/s 5 = SuperSpeedPlus10 Gb/s Signed-off-by: Mathias

[PATCH 01/13] usb: host: xhci support option to disable the xHCI USB2 HW LPM

From: "Thang Q. Nguyen" XHCI specification 1.1 does not require xHCI-compliant controllers to always enable hardware USB2 LPM. However, the current xHCI driver always enable it when seeing HLC=1. This patch supports an option for users to control disabling USB2 Hardware LPM via

[PATCH 04/13] usb: xhci: Disable slot even when virt-dev is null

From: Lu Baolu xhci_disable_slot() is a helper for disabling a slot when a device goes away or recovers from error situations. Currently, it checks the corespoding virt-dev pointer and returns directly (w/o issuing disable slot command) if it's null. This is

[PATCH 03/13] usb: xhci: Add debugfs interface for xHCI driver

From: Lu Baolu This adds debugfs consumer for xHCI driver. The debugfs entries read all host registers, device/endpoint contexts, command ring, event ring and various endpoint rings. With these entries, users can check the registers and memory spaces used by a host

Re: [PATCH v2 0/2] USB: musb: PM fixes

On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote: > These patches fix a couple of bugs introduced by the recent runtime-PM > work (details in the individual commit messages). > > Note that the external abort was due to the irq work never being flushed > on suspend, and that we may

Re: [PATCH] usb: renesas_usbhs: Use of_device_get_match_data() helper

On Wed, Oct 04, 2017 at 02:26:48PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman -- To unsubscribe from this list: send

RE: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper

Hi, > From: Geert Uytterhoeven, Sent: Wednesday, October 4, 2017 9:25 PM > > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven Thank you for the patch! Reviewed-by: Yoshihiro Shimoda

Re: Random xHCI HC died on device disconnect

On Thu, Oct 05, 2017 at 01:50:35PM +0530, Manu Gautam wrote: > Hi Mathias, > > > On 10/4/2017 3:46 PM, Mathias Nyman wrote: > > On 03.10.2017 18:27, Kristian Evensen wrote: > >> On Tue, Oct 3, 2017 at 4:51 PM, Kristian Evensen > >> wrote: > > This is the

Re: [PATCH] usb: gadget: udc: renesas_usb3: Use of_device_get_match_data() helper

On Wed, Oct 04, 2017 at 02:23:31PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding, > postponing the matching until when it's really needed. > Note that the renesas_usb3 driver is used with DT only, so there's > always a valid match. > >

Re: [PATCH v3][for 4.14] xhci: allow TRACE to work with EVENT ring dequeue

On 04.10.2017 19:07, Adam Wallis wrote: On 9/26/2017 2:44 AM, Mathias Nyman wrote: On 25.09.2017 19:09, David Laight wrote: From: Adam Wallis Sent: 25 September 2017 13:26 inc_deq() currently bails earlier for EVENT rings than the common return point of the function, due to the fact that

Re: [PATCH 12/12] dt-bindings: usb: mtu3: remove optional pinctrls

On Thu, Sep 28, 2017 at 08:17:20AM +0800, Chunfeng Yun wrote: > Remove optional pinctrls due to using FORCE/RG_IDDIG to implement > manual switch function. Another not backwards compatible change. Please explain why that is okay. > > Signed-off-by: Chunfeng Yun >

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: > These bindings allows to describe most known standard USB connectors > and it should be possible to extend it if necessary. > USB connectors, beside USB can be used to route other protocols, > for example UART, Audio, MHL. In such

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

Hi Biju-san, (+ Felipe-san) Thank you for the patch! > From: Biju Das, Sent: Friday, October 6, 2017 12:13 AM > > This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME] > (R8A7743/5) usbhs is identical to the R-Car Gen2 family. > > This doesn't change the driver, so it does nothing

Re: [PATCH v2 08/17] dt-bindings: phy-qcom-qusb2: Update binding for QUSB2 V2 version

On Wed, Sep 27, 2017 at 02:29:04PM +0530, Manu Gautam wrote: > Update generic compatible string for QUSB2 V2 PHY. This will allow > all targets using QUSB2 V2 use same string. > > Signed-off-by: Manu Gautam > --- > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt

Re: Issue with Gadget UVC and dummy_hcd

On 6 October 2017 at 06:55, Alan Stern wrote: > David, please try the patch below. It should fix this problem. And I > have no idea why I didn't encounter exactly the same recursive locking > error in my own testing... Thanks Alan, the patch works. Is it still

Re: [PATCH 8/9] dt-bindings: usb: mtk-xhci: add a optional property to disable u3ports

On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote: > Add a new optional property to disable u3ports > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt |2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks and add optional ones

On Wed, Sep 27, 2017 at 05:23:05PM +0800, Chunfeng Yun wrote: > Remove dummy clocks for usb wakeup and add optional ones for > MCU_BUS_CK and DMA_BUS_CK. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 18

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

On 05.10.2017 16:00, Geert Uytterhoeven wrote: Hi Greg, On Thu, Oct 5, 2017 at 2:52 PM, Greg KH wrote: On Thu, Oct 05, 2017 at 11:21:49AM +0300, Mathias Nyman wrote: From: Geert Uytterhoeven Use the of_device_get_match_data() helper

[PATCHv3 0/2] dwc3 on XU3

Hi all, This is the third version of patches in this thread. The series fixes problems with enumerating of SuperSpeed devices on an Odroid XU3. There was a patch series from Vivek Gautam in circulation, but it got lost somehow. Please see: https://lkml.org/lkml/2014/9/2/166

Re: [PATCHv3 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

On 10/05/2017 02:11 PM, Andrzej Pietrasiewicz wrote: > +static int crport_handshake(struct exynos5_usbdrd_phy *phy_drd, > + u32 val, u32 cmd) > +{ > + u32 usec = 100; > + unsigned int result; > + > + writel(val | cmd, phy_drd->reg_phy +

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

On 05.10.2017 16:59, Mathias Nyman wrote: On 05.10.2017 16:00, Geert Uytterhoeven wrote: Hi Greg, On Thu, Oct 5, 2017 at 2:52 PM, Greg KH wrote: On Thu, Oct 05, 2017 at 11:21:49AM +0300, Mathias Nyman wrote: From: Geert Uytterhoeven Use

[PATCHv3 1/2] drivers: phy: add calibrate method

Some quirky UDCs (like dwc3 on exynos) need to have heir phys calibrated e.g. for using super speed. Signed-off-by: Andrzej Pietrasiewicz --- drivers/phy/phy-core.c | 15 +++ include/linux/phy/phy.h | 10 ++ 2 files changed, 25 insertions(+) diff

[PATCHv3 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

From: Vivek Gautam Adding phy calibration sequence for USB 3.0 DRD PHY present on Exynos5420/5800 systems. This calibration facilitates setting certain PHY parameters viz. the Loss-of-Signal (LOS) Detector Threshold Level, as well as Tx-Vboost-Level for Super-Speed

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

On Thu, Oct 05, 2017 at 11:21:49AM +0300, Mathias Nyman wrote: > From: Geert Uytterhoeven > > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven > Signed-off-by: Mathias Nyman

Re: [PATCH v3 07/14] xhci: Add Intel cherrytrail extended cap / otg phy mux handling

On 22.09.2017 21:37, Hans de Goede wrote: The Intel cherrytrail xhci controller has an extended cap mmio-range which contains registers to control the muxing to the xhci (host mode) or the dwc3 (device mode) and vbus-detection for the otg usb-phy. Having a mux driver included in the xhci code

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

Hi Greg, On Thu, Oct 5, 2017 at 2:52 PM, Greg KH wrote: > On Thu, Oct 05, 2017 at 11:21:49AM +0300, Mathias Nyman wrote: >> From: Geert Uytterhoeven >> >> Use the of_device_get_match_data() helper instead of open coding. >> >> Signed-off-by:

[usb:usb-testing 9/39] drivers/usb/host/max3421-hcd.c:1707:2-8: preceding lock on line 1702 (fwd)

It looks like an unlock is needed before line 1707. julia -- Forwarded message -- Date: Thu, 5 Oct 2017 19:35:31 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [usb:usb-testing 9/39]

Re: [PATCH v2 0/2] USB: musb: PM fixes

On Thu, Oct 05, 2017 at 08:11:55AM -0700, Tony Lindgren wrote: > * Johan Hovold [171005 02:15]: > > On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote: > > > These patches fix a couple of bugs introduced by the recent runtime-PM > > > work (details in the individual

RE: [PATCH 02/13] xhci: add port speed ID to portsc tracing

From: Mathias Nyman > Sent: 05 October 2017 09:22 > Shows the port speed protocol speed ID (PSID) in use. > speed ID may map to custom speeds, but in most cases it uses default > > 1 = Full-Speed12 MB/s > 2 = Low-Speed 1.5 Mb/s > 3 = High-speed480 Mb/s > 4 = SuperSpeed

Re: [PATCH v2 0/2] USB: musb: PM fixes

* Johan Hovold [171005 02:15]: > On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote: > > These patches fix a couple of bugs introduced by the recent runtime-PM > > work (details in the individual commit messages). > > > > Note that the external abort was due to the

[PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME] (R8A7743/5) usbhs is identical to the R-Car Gen2 family. This doesn't change the driver, so it does nothing by itself. But it does mean that checkpatch won't complain about a future patch that adds "renesas,usbhs-r8a7743" or

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

On Thu, Oct 05, 2017 at 05:03:36PM +0300, Mathias Nyman wrote: > On 05.10.2017 16:59, Mathias Nyman wrote: > > On 05.10.2017 16:00, Geert Uytterhoeven wrote: > > > Hi Greg, > > > > > > On Thu, Oct 5, 2017 at 2:52 PM, Greg KH > > > wrote: > > > > On Thu, Oct 05, 2017

Re: [PATCH 10/12] dt-bindings: usb: mtu3: add a optional property to disable u3ports

On Thu, Sep 28, 2017 at 08:17:18AM +0800, Chunfeng Yun wrote: > Add a new optional property to disable u3ports > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mediatek,mtu3.txt |2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: the imfamous asix ax88179 iommu error

Hello, Just reporting that it looks like this patch may fix the error (so people having issues with VIA controller hosts may also want to try it): https://lists.linuxfoundation.org/pipermail/iommu/2017-September/024371.html It appears that my ax88179 is working just fine now with the vendor

Re: the imfamous asix ax88179 iommu error

sorry, I mean this commit: commit 469d417b68958a064c09e7875646c97c6e783dfc https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=469d417b68958a064c09e7875646c97c6e783dfc -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: the imfamous asix ax88179 iommu error

On Fri, Oct 06, 2017 at 11:29:19AM +1100, Will Trives wrote: > sorry, I mean this commit: > > commit469d417b68958a064c09e7875646c97c6e783dfc > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=469d417b68958a064c09e7875646c97c6e783dfc revert the revert?

Re: [PATCH 00/18] use ARRAY_SIZE macro

On Mon, Oct 02, 2017 at 09:33:12PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 15:22:24 -0400 > bfie...@fieldses.org (J. Bruce Fields) wrote: > > > Mainly I'd just like to know which you're asking for. Do you want me to > > apply this, or to ACK it so someone else can? If it's sent as a

[PATCH] usb: xhci: Handle error condition in xhci_stop_device()

From: Mayank Rana xhci_stop_device() calls xhci_queue_stop_endpoint() multiple times without checking the return value. xhci_queue_stop_endpoint() can return error if the HC is already halted or unable to queue commands. This can cause a deadlock condition as

Re: [usb:usb-testing 9/39] drivers/usb/host/max3421-hcd.c:1707:2-8: preceding lock on line 1702 (fwd)

On Thu, Oct 05, 2017 at 06:08:19PM +0200, Julia Lawall wrote: > It looks like an unlock is needed before line 1707. > > julia > > -- Forwarded message -- > Date: Thu, 5 Oct 2017 19:35:31 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc: Julia

Re: [PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

* Kees Cook [171004 17:57]: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Felipe Balbi > Cc:

Re: Issue with Gadget UVC and dummy_hcd

On Thu, 5 Oct 2017, David Tulloh wrote: > Thanks Alan, > > I was facing a different problem but your suggestion put me on the right path. > > Sorry it took me so long to update the thread, it has taken me a while > to get a basic understanding of the debugging tools and processes > built into

Re: [PATCH resend 02/12] usb: typec: add basic typec properties

On Tue, Sep 26, 2017 at 12:05:13PM +0800, Li Jun wrote: > port-type is required for any typec port; default-role is only required > for drp; power source capable needs src-pdos; power sink capable needs > snk-pdos, max-snk-mv, max-snk-ma, op-snk-mw. "dt-bindings: usb: ..." for the subject prefix.

Re: [PATCH v2 12/17] dt-bindings: phy-qcom-qmp: Update bindings for QMP V3 USB PHY

On Wed, Sep 27, 2017 at 02:29:08PM +0530, Manu Gautam wrote: > Update compatible string and clock names for QMP version V3 > USB PHY. > > Signed-off-by: Manu Gautam > --- > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 6 +- > 1 file changed, 5