Hi johnyoun:
I found a suspected bug, and I am writing to confirm with you.
In the function
dwc2_gadget_complete_isoc_request_ddma(drivers/usb/dwc2/gadget.c).
Only the first request from the eq queue is processed while maybe there are
more than one descriptors done by the HW.
1. Each usb reque
Hi Baolin,
On 28/02/18 05:04, Baolin Wang wrote:
> Hi Roger,
>
> On 27 February 2018 at 19:22, Roger Quadros wrote:
>> In the following test we get stuck by sleeping forever in _dwc3_set_mode()
>> after which dual-role switching doesn't work.
>>
>> On dra7-evm's dual-role port,
>> - Load g_zero
Felipe,
On 28/02/18 09:53, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros writes:
>> In the following test we get stuck by sleeping forever in _dwc3_set_mode()
>> after which dual-role switching doesn't work.
>>
>> On dra7-evm's dual-role port,
>> - Load g_zero gadget driver and enumerate to hos
Am Montag, den 26.02.2018, 18:09 +0200 schrieb Ran Shalit:
> On Mon, Feb 26, 2018 at 5:59 PM, Oliver Neukum wrote:
> >
> > Am Donnerstag, den 15.02.2018, 11:00 +0200 schrieb Ran Shalit:
> > >
> > > I actually asked about DMA, because I see that it is possible to send
> > > urb using DMA allocate
Hi,
On 2/28/2018 1:00 PM, Zengtao (B) wrote:
> Hi johnyoun:
>
> I found a suspected bug, and I am writing to confirm with you.
>
> In the function
> dwc2_gadget_complete_isoc_request_ddma(drivers/usb/dwc2/gadget.c).
> Only the first request from the eq queue is processed while maybe there are
Hi Amelie,
On 23/02/18 15:46, Amelie Delaunay wrote:
> On some boards, especially when vbus supply requires large current,
> and the charge pump on the PHY isn't enough, an external vbus power switch
> may be used.
> Add support for optional external vbus supply per port in ehci-platform.
>
> Sig
Hi Amelie,
Just a couple of drive-by coding style comments...
On 23/02/18 13:46, Amelie Delaunay wrote:
On some boards, especially when vbus supply requires large current,
and the charge pump on the PHY isn't enough, an external vbus power switch
may be used.
Add support for optional external v
On 27.02.2018 23:26, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 02월 27일 21:05, Andrzej Hajda wrote:
>> On 27.02.2018 12:08, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 2018년 02월 27일 16:11, Andrzej Hajda wrote:
From: Maciej Purski
Currently MHL chip must be turned on permanently to detect MHL
Hi
On 23.02.2018 04:55, Cyril Roelandt wrote:
Hello,
On 02/21/18 17:04, Mathias Nyman wrote:
could you change one flag in the xhci driver and take the same
set of logs? It will add more details about the URB and xHC hw position check.
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/h
Hi Mathias,
On mer., févr. 14 2018, Gregory CLEMENT wrote:
> Hello,
>
> The purpose of this series is to allow xhci-plat using a second
> clock. It is needed on the Armada 7K/8K but could be used by other
> SoCs.
Do you have some comments on this series and especially on the second
patch?
Th
On Mon, Feb 26, 2018 at 11:04:57PM +0800, Kai-Heng Feng wrote:
> +static char quirks_param[128];
> +module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
> +MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying
> quirks=vendorID:productID:quirks");
> +
> +static char quirk
The AXP288 BC1.2 charger detection / extcon code may seem like a strange
place to add code to control the USB role-switch on devices with an AXP288,
but there are 2 reasons to do this inside the axp288 extcon code:
1) On many devices the USB role is controlled by ACPI AML code, but the AML
code
The xHCI controller on various Intel SoCs has an extended cap mmio-range
which contains registers to control the muxing to the xHCI (host mode)
or the dwc3 (device mode) and vbus-detection for the otg usb-phy.
Having a role-sw driver included in the xHCI code (under drivers/usb/host)
is not desira
Setting the mux to MUX_NONE and the switch to USB_SWITCH_DISCONNECT when
the data-role is device is not correct. Plenty of devices support
operating as USB device through a (separate) USB device controller.
We really need 2 different versions of USB_SWITCH_CONNECT,
USB_SWITCH_CONNECT_HOST and USB_
Add a driver for the Pericom PI3USB30532 Type-C cross switch /
mux chip found on some devices with a Type-C port.
Reviewed-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v4:
-Add Andy's Reviewed-by
Changes in v2:
-Cleanup pi3usb30532_set_conf() err
From: Mathias Nyman
Modify xhci_find_next_ext_cap(base, offset, id) to return the next
capability offset if 0 is passed for id. Otherwise it will behave as
previously and return the offset of the next capability with matching id
capability id 0 is not used by xHCI (reserved)
This is useful when
From: Heikki Krogerus
USB role switch is a device that can be used to choose the
data role for USB connector. With dual-role capable USB
controllers, the controller itself will be the switch, but
on some platforms the USB host and device controllers are
separate IPs and there is a mux between the
We need to add device-connections for the Type-C mux/switch and usb-role
code to be able to find the PI3USB30532 Type-C cross-switch and the
device/host role-switch integrated in the CHT SoC.
Reviewed-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
---
Changes in v
Various Intel SoCs (Cherry Trail, Broxton and others) have an internal USB
role switch for swiching the OTG USB data lines between the xHCI host
controller and the dwc3 gadget controller.
Note on some Cherry Trail systems there is ACPI/AML code listening to
edge interrupts on the id-pin (through a
On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote:
> This is a small series that cleans up struct consw a bit and
> prepares it for Control Flow Integrity checking (i.e. Clang's
> -fsanitize=cfi).
for drivers/video/ parts:
Acked-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Z
From: Heikki Krogerus
USB Type-C connectors consist of various muxes and switches
that route the pins on the connector to the right locations.
The USB Type-C drivers need to be able to control the muxes,
as they are the ones that know things like the cable plug
orientation, and the current mode t
Remove the unused (not implemented anywhere) tcpc_mux_dev abstraction
and replace it with calling the new typec_set_orientation,
usb_role_switch_set and typec_set_mode functions.
Reviewed-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
Reviewed-by: Andy Shevchenko
Signed-off-by: Hans de Goede
-
From: Heikki Krogerus
In order to allow the USB Type-C Class driver take care of
things like muxes and other possible dependencies for the
port drivers, returning ERR_PTR instead of NULL from the
registration functions in case of failure.
The reason for taking over control of the muxes for examp
Hi All,
Here is version 5 of Heikki's and my USB Type-C device-connection, mux and
switch support series. Versions 2 - 5 bring various small code and style
fixes based on review (no major changes).
Here is the original cover-letter of v1:
Some devices with an USB Type-C connector have a bunch of
From: Heikki Krogerus
Several frameworks - clk, gpio, phy, pmw, etc. - maintain
lookup tables for describing connections and provide custom
API for handling them. This introduces a single generic
lookup table and API for the connections.
The motivation for this commit is centralizing the
connect
Hi,
On 26-02-18 20:34, Randy Dunlap wrote:
On 02/26/2018 10:39 AM, Hans de Goede wrote:
diff --git a/include/linux/connection.h b/include/linux/connection.h
new file mode 100644
index ..0b4430eae53a
--- /dev/null
+++ b/include/linux/connection.h
@@ -0,0 +1,33 @@
+// SPDX-License-Ide
On Wednesday, February 28, 2018 04:09:47 PM Bartlomiej Zolnierkiewicz wrote:
> On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote:
> > This is a small series that cleans up struct consw a bit and
> > prepares it for Control Flow Integrity checking (i.e. Clang's
> > -fsanitize=cfi).
>
> for d
On Wed, Feb 28, 2018 at 04:07:45PM +0100, Hans de Goede wrote:
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 96099a245c69..5917e3095e2a 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1825,6 +1825,7 @@ struct xhci_hcd {
> /* Reserved. It was
On Wed, Feb 28, 2018 at 04:14:38PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, February 28, 2018 04:09:47 PM Bartlomiej Zolnierkiewicz wrote:
> > On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote:
> > > This is a small series that cleans up struct consw a bit and
> > > prepares i
Hi,
On 28-02-18 16:15, Heikki Krogerus wrote:
On Wed, Feb 28, 2018 at 04:07:45PM +0100, Hans de Goede wrote:
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 96099a245c69..5917e3095e2a 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1825,6 +1825,7 @@ s
On 14.02.2018 18:16, Gregory CLEMENT wrote:
On Armada 7K/8K we need to explicitly enable the register clock. This
clock is optional because not all the SoCs using this IP need it but at
least for Armada 7K/8K it is actually mandatory.
The change was done at xhci-plat level and not at a xhci-mveb
On 28 Feb 2018, at 10:47 PM, Matthew Wilcox wrote:
On Mon, Feb 26, 2018 at 11:04:57PM +0800, Kai-Heng Feng wrote:
+static char quirks_param[128];
+module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644);
+MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying
quirks=ve
Hi,
On 2/14/2018 9:46 PM, Gregory CLEMENT wrote:
> On Armada 7K/8K we need to explicitly enable the register clock. This
> clock is optional because not all the SoCs using this IP need it but at
> least for Armada 7K/8K it is actually mandatory.
>
> The change was done at xhci-plat level and not
Hi Manu,
On mer., févr. 28 2018, Manu Gautam wrote:
> Hi,
>
>
> On 2/14/2018 9:46 PM, Gregory CLEMENT wrote:
>> On Armada 7K/8K we need to explicitly enable the register clock. This
>> clock is optional because not all the SoCs using this IP need it but at
>> least for Armada 7K/8K it is actua
On Thu, Mar 01, 2018 at 12:01:40AM +0800, Kai Heng Feng wrote:
> > Also, you won't need to use a linked list for this; you can just allocate
> > an array of quirks.
>
> I use linked list because the total quirks number is known after the entire
> string gets parsed.
> Do you suggest that I should
Hi,
i'm not sure this is related, but i noticed something ugly in
driver/usb/chipidea/usbmisc_imx.c.
The compatible "fsl,imx6ul-usbmisc" uses imx6sx_usbmisc_ops, which uses
usbmisc_imx6sx_init (which also calls usbmisc_imx6q_init).
Within usbmisc_imx6q_init the flag MX6_BM_NON_BURST_SETTING is en
Hi,
On 28 February 2018 4:43 AM, Peter Chen wrote:
> You mean you measure it after echo "mem" > /sys/power/state, right?
Yes, I've put my multimeter to some grounded part of the board and the other
measuring head(or is it called test prod in English?) to the right pin of the
usb port (if watch
On 02/22/2018 07:20 AM, Andy Shevchenko wrote:
On Thu, Feb 22, 2018 at 1:57 AM, Thinh Nguyen wrote:
On 2/21/2018 6:46 AM, Andy Shevchenko wrote:
On Tue, Feb 20, 2018 at 11:12 PM, Thinh Nguyen
wrote:
On 2/17/2018 7:29 AM, Andy Shevchenko wrote:
On Fri, Feb 16, 2018 at 11:55 PM, Thinh Nguyen
Hi Stefan,
On Wed, Feb 28, 2018 at 2:08 PM, Stefan Wahren wrote:
> Hi,
>
> i'm not sure this is related, but i noticed something ugly in
> driver/usb/chipidea/usbmisc_imx.c.
>
> The compatible "fsl,imx6ul-usbmisc" uses imx6sx_usbmisc_ops, which uses
> usbmisc_imx6sx_init (which also calls usbmisc
Remove the duplicated code for asix88179_178a bind and reset methods.
Signed-off-by: Alexander Kurz
---
drivers/net/usb/ax88179_178a.c | 117 +++--
1 file changed, 31 insertions(+), 86 deletions(-)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb
The permanent address of asix88179_178a devices is read at probe time
and should not be overwritten later. Otherwise it may be overwritten
unintentionally with a configured address.
Signed-off-by: Alexander Kurz
---
drivers/net/usb/ax88179_178a.c | 1 -
1 file changed, 1 deletion(-)
diff --git
* Merlijn Wajer [180227 22:29]:
> Without pm_runtime_{get,put}_sync calls in place, reading
> vbus status via /sys causes the following error:
>
> Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060
> pgd = b333e822
> [fa0ab060] *pgd=48011452(bad)
>
> [] (musb_default_readb)
Hi Kai-Heng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
Hi Kai-Heng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
Hi,
> -Original Message-
> +struct device *device_find_connection(struct device *dev, const char
> +*con_id) {
> + return __device_find_connection(dev, con_id, generic_match, NULL); }
- return __device_find_connection(dev, con_id, generic_match, NULL);
+ return __device_fi
On Wed, Feb 28, 2018 at 06:08:20PM +0100, Stefan Wahren wrote:
> Hi,
>
> i'm not sure this is related, but i noticed something ugly in
> driver/usb/chipidea/usbmisc_imx.c.
>
> The compatible "fsl,imx6ul-usbmisc" uses imx6sx_usbmisc_ops, which uses
> usbmisc_imx6sx_init (which also calls usbmisc_i
* Rob Herring [180219 20:41]:
> On Sat, Feb 17, 2018 at 01:07:23PM -0800, Tony Lindgren wrote:
> > The GPIOs controlling MDM6600 are used to power MDM660 on and off, to
>
> MDM660 a typo?
Thanks fixing.
> > +Required properties:
> > +- compatible Must be "motorola,mapphone-mdm6600"
> > +-
* kbuild test robot [180219 07:47]:
> > 354if (reset_gpio >= 0)
>355gpiod_set_value_cansleep(reset_gpio, 1);
Thanks this test can be just dropped. Will send out an updated
version shortly.
Regards,
Tony
--
To unsubscribe from this list: send the line
From: ShuFanLee
Handle vendor defined behavior in tcpci_init, tcpci_set_vconn and export
tcpci_irq.
More operations can be extended in tcpci_data if needed.
According to TCPCI specification, 4.4.5.2 ROLE_CONTROL,
TCPC shall not start DRP toggling until subsequently the TCPM
writes to the COMMAND
Let's add support for the GPIO controlled USB PHY on the MDM6600 modem.
It is used on some Motorola Mapphone series of phones and tablets such
as Droid 4.
The MDM6600 is hardwired to the first OHCI port in the Droid 4 case, and
is controlled by several GPIOs. The USB PHY is integrated into the MDM
From: ShuFan Lee
Handle vendor defined behavior in tcpci_init, tcpci_set_vconn and export
tcpci_irq.
More operations can be extended in tcpci_data if needed.
According to TCPCI specification, 4.4.5.2 ROLE_CONTROL,
TCPC shall not start DRP toggling until subsequently the TCPM
writes to the COMMAN
> -Original Message-
> From: Stefan Agner [mailto:ste...@agner.ch]
> Sent: Monday, February 12, 2018 7:15 AM
> To: Leo Li ; ba...@kernel.org
> Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; Stefan Agner
>
> Subject: [PATCH] usb: gadget: fsl_udc_core: fix ep valid checks
>
>
Hi
> -Original Message-
> From: shufan_lee(李��帆) [mailto:shufan_...@richtek.com]
> Sent: 2018年2月28日 11:41
> To: Jun Li ; ShuFanLee ;
> heikki.kroge...@linux.intel.com; li...@roeck-us.net; g...@kroah.com
> Cc: cy_huang(�S�⒃�) ;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; dl-li
On Wed, Feb 28, 2018 at 04:42:32PM +0100, Hans de Goede wrote:
> Hi,
>
> On 28-02-18 16:15, Heikki Krogerus wrote:
> > On Wed, Feb 28, 2018 at 04:07:45PM +0100, Hans de Goede wrote:
> > > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> > > index 96099a245c69..5917e3095e2a 100644
>
Hi,
On Thu, Mar 01, 2018 at 12:56:57AM +, Jun Li wrote:
> > +struct device *device_find_connection(struct device *dev, const char
> > +*con_id) {
> > + return __device_find_connection(dev, con_id, generic_match, NULL); }
>
> - return __device_find_connection(dev, con_id, generic_match
GPL v2 is the original license according to the old license text.
See f64cdd0e94f1faf3b7f2b03af71f70dc6d8da0c2.
Signed-off-by: Marcus Folkesson
---
drivers/usb/usb-skeleton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton
56 matches
Mail list logo
