[PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

2018-04-04 Thread Patong Yang
The driver is based on the CDC-ACM driver. In addition to supporting the features of the MaxLinear/Exar USB UART devices, the driver also has support for 2 other functions per customer requirements: - Specific entries are checked in the BIOS to detect if the board is a "Caracalla" board before

Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-04 Thread Masahiro Yamada
2018-04-04 15:04 GMT+09:00 Felipe Balbi : > > Hi, > > Masahiro Yamada writes: >> 2018-04-04 14:36 GMT+09:00 Felipe Balbi : >>> >>> Hi, >>> >>> Masahiro Yamada writes: Currently, DWC3 core IP (drivers/usb/dwc3/core.c) can take only one PHY phandle for each of SS, HS. (phy-names DT p

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

2018-04-04 Thread Oliver Neukum
Am Mittwoch, den 04.04.2018, 00:06 -0700 schrieb Patong Yang: > The driver is based on the CDC-ACM driver. In addition to supporting > the features of the MaxLinear/Exar USB UART devices, the driver also Hi, it is rather drastic a measure to duplicate a driver just for a low number of devices.

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 12:06:34AM -0700, Patong Yang wrote: > The driver is based on the CDC-ACM driver. In addition to supporting > the features of the MaxLinear/Exar USB UART devices, the driver also > has support for 2 other functions per customer requirements: > > - Specific entries are che

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 12:06:34AM -0700, Patong Yang wrote: > - When specific IOCTLs are called by a user-space application, a > port_config file is created for the /dev/ttyXRUSB device at a > specific USB tree location, and some configuration data is stored. > The driver checks for the po

Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-04 Thread Felipe Balbi
Hi, Masahiro Yamada writes: >>> Each DWC3 instance is connected with >>> multiple HS PHYs and multiple SS PHYs, >>> depending on the number of ports. >> >> in that case, you shouldn't need dwc3 at all. A Host-only dwc3 is xHCI >> compliant. If you really don't have the gadget block, there's no n

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-04 Thread Philipp Zabel
On Wed, 2018-04-04 at 10:25 +0900, Masahiro Yamada wrote: > 2018-04-03 19:35 GMT+09:00 Vivek Gautam : > > > > > > On 4/3/2018 3:49 PM, Masahiro Yamada wrote: > > > > > > 2018-04-03 17:46 GMT+09:00 Philipp Zabel : > > > > > > > > On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: > > > >

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

2018-04-04 Thread Oliver Neukum
Am Dienstag, den 03.04.2018, 09:56 -0600 schrieb Shuah Khan: > This is a virtual device associated to a real physical device on a different > system. My concern is that if the module gets removed accidentally then it > could disrupt access to the remote device. The remote nature of the device > wit

Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-04 Thread Arnd Bergmann
On Wed, Apr 4, 2018 at 10:00 AM, Felipe Balbi wrote: > > Hi, > > Masahiro Yamada writes: Each DWC3 instance is connected with multiple HS PHYs and multiple SS PHYs, depending on the number of ports. >>> >>> in that case, you shouldn't need dwc3 at all. A Host-only dwc3 is xHCI >>>

[GIT PULL] USB/PHY driver patches for 4.17-rc1

2018-04-04 Thread Greg KH
The following changes since commit c698ca5278934c0ae32297a8725ced2e27585d7f: Linux 4.16-rc6 (2018-03-18 17:48:42 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.17-rc1 for you to fetch changes up to 5267c5e09c25e2ee624

Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-04 Thread Masahiro Yamada
Hi Arnd, 2018-04-04 17:43 GMT+09:00 Arnd Bergmann : > On Wed, Apr 4, 2018 at 10:00 AM, Felipe Balbi > wrote: >> >> Hi, >> >> Masahiro Yamada writes: > Each DWC3 instance is connected with > multiple HS PHYs and multiple SS PHYs, > depending on the number of ports. in that c

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread tnimkar
Hi Oliver/Greg, I am able to duplicated the UAS issue on 4.16 as well. The behavior is same new usb device detects and reset after aprox 30 sec(SD_TIMEOUT) Logs are already shared below. We are using Synopsys dwc3 as host controller, May I know have tested it with dwc3? I have tried it on Lin

Re: [PATCH -next] usb: dwc2: pci: Fix error return code in dwc2_pci_probe()

2018-04-04 Thread Minas Harutyunyan
On 3/30/2018 11:35 AM, Grigor Tovmasyan wrote: > On 3/28/2018 5:36 PM, Wei Yongjun wrote: >> Fix to return error code -ENOMEM from the alloc fail error handling >> case instead of 0, as done elsewhere in this function. >> >> Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") >> S

Re: [PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-04 Thread Mats Karrman
Hi Li, On 2018-03-23 15:58, Li Jun wrote: Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Signed-off-by: Li Jun --- drivers/usb/typec/fusb302/fusb302.c | 51 +++-- 1 file changed, 37 insertions(+), 14 deleti

Re: [usb-next PATCH v11 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

2018-04-04 Thread Masahiro Yamada
2018-03-04 6:43 GMT+09:00 Martin Blumenstingl : > Many SoC platforms have separate devices for the USB PHY which are > registered through the generic PHY framework. These PHYs have to be > enabled to make the USB controller actually work. They also have to be > disabled again on shutdown/suspend. >

[PATCH] usb: select USB_COMMON for usb role switch config

2018-04-04 Thread Arnd Bergmann
The new axp288 extcon driver has no dependency on USB itself but calls the usb role switch helper functions. This causes a link error when USB_COMMON is disabled, as that subdirectory never gets entered: drivers/extcon/extcon-axp288.o: In function `axp288_usb_role_work': extcon-axp288.c:(.text+0x4

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org wrote: > Hi Oliver/Greg, > > I am able to duplicated the UAS issue on 4.16 as well. > The behavior is same new usb device detects and reset after aprox 30 > sec(SD_TIMEOUT) > Logs are already shared below. > > We are using Synopsys

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread tnimkar
On 2018-04-04 18:07, Greg KH wrote: On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org wrote: Hi Oliver/Greg, I am able to duplicated the UAS issue on 4.16 as well. The behavior is same new usb device detects and reset after aprox 30 sec(SD_TIMEOUT) Logs are already shared below.

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-04 Thread Tomeu Vizoso
Could this patch be picked up, please? Thanks, Tomeu On 26 March 2018 at 13:51, Heiko Stübner wrote: > Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso: >> devm_regulator_get_optional returns -ENODEV if the regulator isn't >> there, so if that's the case we have to make sure not to

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 06:41:41PM +0530, tnim...@codeaurora.org wrote: > On 2018-04-04 18:07, Greg KH wrote: > > On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org wrote: > > > Hi Oliver/Greg, > > > > > > I am able to duplicated the UAS issue on 4.16 as well. > > > The behavior is s

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

2018-04-04 Thread Shuah Khan
On 04/04/2018 02:25 AM, Oliver Neukum wrote: > Am Dienstag, den 03.04.2018, 09:56 -0600 schrieb Shuah Khan: >> This is a virtual device associated to a real physical device on a different >> system. My concern is that if the module gets removed accidentally then it >> could disrupt access to the re

Re: [PATCH v2] lan78xx: Connect phy early

2018-04-04 Thread David Miller
From: Alexander Graf Date: Wed, 4 Apr 2018 00:19:35 +0200 > When using wicked with a lan78xx device attached to the system, we > end up with ethtool commands issued on the device before an ifup > got issued. That lead to the following crash: > ... > The culprit is quite simple: The driver trie

Re: [PATCH] usb: select USB_COMMON for usb role switch config

2018-04-04 Thread Hans de Goede
Hi, On 04-04-18 14:21, Arnd Bergmann wrote: The new axp288 extcon driver has no dependency on USB itself but calls the usb role switch helper functions. This causes a link error when USB_COMMON is disabled, as that subdirectory never gets entered: drivers/extcon/extcon-axp288.o: In function `ax

Re: [PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-04 Thread Hans de Goede
Hi, On 04-04-18 14:06, Mats Karrman wrote: Hi Li, On 2018-03-23 15:58, Li Jun wrote: Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Signed-off-by: Li Jun ---   drivers/usb/typec/fusb302/fusb302.c | 51 +++--

RE: usb: usbtmc: Proposal for new ioctl functions

2018-04-04 Thread Guido Kiener
Greg, Before sending patches we want to be sure doing the right things. I'm not sure how we should deal with the sysfs parameters for USBTMC devices: See https://github.com/torvalds/linux/blob/master/Documentation/ABI/stable/sysfs-driver-usb-usbtmc There are some parameters defined for each dev

Re: [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-04 Thread Sasha Levin
Hi Yoshihiro Shimoda. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: 279d4bc64060 usb: gadget: udc: renesas_usb3: add support for generic phy. The bot has also determined it's probably a bug fixing patch. (score: 99.1076) The bot

Re: [PATCH 1/4] usb: gadget: udc: renesas_usb3: fix double phy_put()

2018-04-04 Thread Sasha Levin
Hi Yoshihiro Shimoda. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: 279d4bc64060 usb: gadget: udc: renesas_usb3: add support for generic phy. The bot has also determined it's probably a bug fixing patch. (score: 96.8529) The bot

Re: [PATCH 2/4] usb: gadget: udc: renesas_usb3: should remove debugfs

2018-04-04 Thread Sasha Levin
Hi Yoshihiro Shimoda. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: 43ba968b00ea usb: gadget: udc: renesas_usb3: add debugfs to set the b-device mode. The bot has also determined it's probably a bug fixing patch. (score: 94.9837)

Re: [PATCH 3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc

2018-04-04 Thread Sasha Levin
Hi Yoshihiro Shimoda. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: cf06df3fae28 usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able(). The bot has also determined it's probably a bug fixing patch. (score: 98.8092) The b

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread Felipe Balbi
Hi, Greg KH writes: > On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org wrote: >> Hi Oliver/Greg, >> >> I am able to duplicated the UAS issue on 4.16 as well. >> The behavior is same new usb device detects and reset after aprox 30 >> sec(SD_TIMEOUT) >> Logs are already shared bel

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread tnimkar
On 2018-04-04 19:28, Greg KH wrote: On Wed, Apr 04, 2018 at 06:41:41PM +0530, tnim...@codeaurora.org wrote: On 2018-04-04 18:07, Greg KH wrote: > On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org wrote: > > Hi Oliver/Greg, > > > > I am able to duplicated the UAS issue on 4.16 as w

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread Felipe Balbi
Hi, it would help if you would Cc XHCI's maintainer :-) tnim...@codeaurora.org writes: > On 2018-04-04 19:28, Greg KH wrote: >> On Wed, Apr 04, 2018 at 06:41:41PM +0530, tnim...@codeaurora.org wrote: >>> On 2018-04-04 18:07, Greg KH wrote: >>> > On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 12:03:51PM -0700, Patong Yang wrote: > Thanks for the quick reply and feedback. This needs to be a different > driver because although the USB UARTs can work with the CDC-ACM driver, > there are limitations in the CDC-ACM spec and therefore the driver that > prevents it fro

Re: 4.16 repeating message xhci_hcd Root hub is not suspended

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 07:33:41PM -0600, Chris Murphy wrote: > Every few seconds I'm getting this in dmesg/journal -k > > Apr 04 17:26:10 f28h.local kernel: xhci_hcd :00:14.0: Root hub is > not suspended > > And occasionally also: > > [67135.656238] xhci_hcd :00:14.0: Secondary root hub

Re: [GIT PULL] USB/PHY driver patches for 4.17-rc1

2018-04-04 Thread Kees Cook
On Wed, Apr 4, 2018 at 3:31 AM, Greg KH wrote: > Lars-Peter Clausen (2): > usb: gadget: ffs: Execute copy_to_user() with USER_DS set https://git.kernel.org/linus/4058ebf33cb0be88ca516f968eda24ab7b6b93e4 Isn't there a better way to do this without the set_fs() usage? We've been try to elimi

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-04 Thread tnimkar
On 2018-04-05 11:24, Felipe Balbi wrote: Hi, Greg KH writes: On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org wrote: Hi Oliver/Greg, I am able to duplicated the UAS issue on 4.16 as well. The behavior is same new usb device detects and reset after aprox 30 sec(SD_TIMEOUT) Log