Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-05 Thread Felipe Balbi
Hi, tnim...@codeaurora.org writes: > On 2018-04-05 11:24, Felipe Balbi wrote: >> Hi, >> >> Greg KH writes: >>> On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org >>> wrote: Hi Oliver/Greg, I am able to duplicated the UAS issue on 4.16 as well. The behavior is

Re: [GIT PULL] USB/PHY driver patches for 4.17-rc1

2018-04-05 Thread Lars-Peter Clausen
On 04/05/2018 08:31 AM, Kees Cook wrote: > On Wed, Apr 4, 2018 at 3:31 AM, Greg KH wrote: >> Lars-Peter Clausen (2): >> usb: gadget: ffs: Execute copy_to_user() with USER_DS set > > https://git.kernel.org/linus/4058ebf33cb0be88ca516f968eda24ab7b6b93e4 > > Isn't there a better way to do thi

Re: [GIT PULL] USB/PHY driver patches for 4.17-rc1

2018-04-05 Thread Christoph Hellwig
On Thu, Apr 05, 2018 at 09:19:28AM +0200, Lars-Peter Clausen wrote: > On 04/05/2018 08:31 AM, Kees Cook wrote: > > On Wed, Apr 4, 2018 at 3:31 AM, Greg KH wrote: > >> Lars-Peter Clausen (2): > >> usb: gadget: ffs: Execute copy_to_user() with USER_DS set > > > > https://git.kernel.org/linus/

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

2018-04-05 Thread Oliver Neukum
Am Donnerstag, den 05.04.2018, 08:26 +0200 schrieb Greg KH: > > The USB device can describe itself properly.  The SMBIOS function is a > > requirement from our customer who designed a board using our device where > > their CPU reads from a specific BIOS location and initializes GPIOs based > > on t

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-05 Thread Minas Harutyunyan
Hi Tomeu, On 3/26/2018 1:01 PM, Tomeu Vizoso wrote: > devm_regulator_get_optional returns -ENODEV if the regulator isn't > there, so if that's the case we have to make sure not to leave -ENODEV > in the regulator pointer. > > Also, make sure we return 0 in that case, but correctly propagate any >

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-05 Thread Tomeu Vizoso
Hi Minas, On 04/05/2018 09:54 AM, Minas Harutyunyan wrote: Hi Tomeu, On 3/26/2018 1:01 PM, Tomeu Vizoso wrote: devm_regulator_get_optional returns -ENODEV if the regulator isn't there, so if that's the case we have to make sure not to leave -ENODEV in the regulator pointer. Also, make sure we

Re: [PATCH usb-next v4 0/2] fix HCD PHY suspend handling

2018-04-05 Thread Roger Quadros
Greg, On 28/03/18 00:26, Martin Blumenstingl wrote: > This is a follow-up to my previous series "initialize (multiple) PHYs > for a HCD": [0]. > > Roger Quadros reported [1] that it "is breaking low power cases on TI > SoCs when USB is in host mode". He further explains that "Not doing the > phy_

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-05 Thread Grigor Tovmasyan
On 3/26/2018 1:01 PM, Tomeu Vizoso wrote: > devm_regulator_get_optional returns -ENODEV if the regulator isn't > there, so if that's the case we have to make sure not to leave -ENODEV > in the regulator pointer. > > Also, make sure we return 0 in that case, but correctly propagate any > other erro

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-05 Thread Grigor Tovmasyan
On 4/5/2018 12:11 PM, Tomeu Vizoso wrote: > Hi Minas, > > On 04/05/2018 09:54 AM, Minas Harutyunyan wrote: >> Hi Tomeu, >> >> On 3/26/2018 1:01 PM, Tomeu Vizoso wrote: >>> devm_regulator_get_optional returns -ENODEV if the regulator isn't >>> there, so if that's the case we have to make sure not t

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-05 Thread Minas Harutyunyan
On 4/5/2018 12:59 PM, Grigor Tovmasyan wrote: > On 3/26/2018 1:01 PM, Tomeu Vizoso wrote: >> devm_regulator_get_optional returns -ENODEV if the regulator isn't >> there, so if that's the case we have to make sure not to leave -ENODEV >> in the regulator pointer. >> >> Also, make sure we return 0 in

Re: [PATCH usb-next v4 0/2] fix HCD PHY suspend handling

2018-04-05 Thread Greg KH
On Thu, Apr 05, 2018 at 11:47:11AM +0300, Roger Quadros wrote: > Greg, > > On 28/03/18 00:26, Martin Blumenstingl wrote: > > This is a follow-up to my previous series "initialize (multiple) PHYs > > for a HCD": [0]. > > > > Roger Quadros reported [1] that it "is breaking low power cases on TI > >

Re: usb: usbtmc: Proposal for new ioctl functions

2018-04-05 Thread Greg KH
On Wed, Apr 04, 2018 at 10:03:22PM +, Guido Kiener wrote: > Greg, > > Before sending patches we want to be sure doing the right things. I'm not > sure how we should deal with the sysfs parameters for USBTMC devices: > See > https://github.com/torvalds/linux/blob/master/Documentation/ABI/sta

Re: Logitech webcam USB audio breakage during the 4.10 merge window

2018-04-05 Thread Marius Cirsta
Adding the linux-usb mailing , maybe someone from there will be able to help with this. On Sun, Feb 25, 2018 at 12:45 PM, Marius Cirsta wrote: > Hi, > > Thanks for your answer. > > Yes, I tried reverting just that commit on top of kernel 4.15.5 and > there was no change so I too suspect it's so

Re: Logitech webcam USB audio breakage during the 4.10 merge window

2018-04-05 Thread Greg KH
On Thu, Apr 05, 2018 at 07:05:29PM +0300, Marius Cirsta wrote: > Adding the linux-usb mailing , maybe someone from there will be able > to help with this. Can you run 'git bisect' to find the offending patch? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb

Re: [PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks

2018-04-05 Thread Sasha Levin
Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 10.6103) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.32: Build OK!

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

2018-04-05 Thread Sasha Levin
Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 13.1846) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.32: Build OK!

Re: [PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks

2018-04-05 Thread Shuah Khan
On 04/05/2018 10:42 AM, Sasha Levin wrote: > Hi. > > [This is an automated email] > > This commit has been processed by the -stable helper bot and determined > to be a high probability candidate for -stable trees. (score: 10.6103) > > The bot has tested the following trees: v4.15.15, v4.14.32, v

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

2018-04-05 Thread Shuah Khan
On 04/05/2018 10:42 AM, Sasha Levin wrote: > Hi. > > [This is an automated email] > > This commit has been processed by the -stable helper bot and determined > to be a high probability candidate for -stable trees. (score: 13.1846) > > The bot has tested the following trees: v4.15.15, v4.14.32, v

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

2018-04-05 Thread Sasha Levin
On Thu, Apr 05, 2018 at 10:54:59AM -0600, Shuah Khan wrote: >On 04/05/2018 10:42 AM, Sasha Levin wrote: >> Hi. >> >> [This is an automated email] >> >> This commit has been processed by the -stable helper bot and determined >> to be a high probability candidate for -stable trees. (score: 13.1846) >

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

2018-04-05 Thread Greg KH
On Thu, Apr 05, 2018 at 04:42:46PM +, Sasha Levin wrote: > Hi. > > [This is an automated email] Why are you running this against patches that are not yet in Linus's tree? That feels odd. Only about 1/3 of the patches posted end up being merged (at best), so don't do extra work by running th

Re: [usb-next PATCH v11 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

2018-04-05 Thread Martin Blumenstingl
Hello, (great to hear that this might be useful on Socionext SoCs as well :)) On Wed, Apr 4, 2018 at 2:10 PM, Masahiro Yamada wrote: > 2018-03-04 6:43 GMT+09:00 Martin Blumenstingl > : >> Many SoC platforms have separate devices for the USB PHY which are >> registered through the generic PHY fra

Re: [PATCH usb-next v4 0/2] fix HCD PHY suspend handling

2018-04-05 Thread Martin Blumenstingl
Hi Greg, On Thu, Apr 5, 2018 at 3:38 PM, Greg KH wrote: > On Thu, Apr 05, 2018 at 11:47:11AM +0300, Roger Quadros wrote: >> Greg, >> >> On 28/03/18 00:26, Martin Blumenstingl wrote: >> > This is a follow-up to my previous series "initialize (multiple) PHYs >> > for a HCD": [0]. >> > >> > Roger Qu

Re: [PATCH usb-next v4 0/2] fix HCD PHY suspend handling

2018-04-05 Thread Greg KH
On Thu, Apr 05, 2018 at 10:08:23PM +0200, Martin Blumenstingl wrote: > Hi Greg, > > On Thu, Apr 5, 2018 at 3:38 PM, Greg KH wrote: > > On Thu, Apr 05, 2018 at 11:47:11AM +0300, Roger Quadros wrote: > >> Greg, > >> > >> On 28/03/18 00:26, Martin Blumenstingl wrote: > >> > This is a follow-up to my

RE: Re: usb: usbtmc: Proposal for new ioctl functions

2018-04-05 Thread Guido Kiener
[gk] See below -Original Message- From: Greg KH Sent: Thursday, April 05, 2018 3:45 PM To: Kiener Guido Subject: Re: usb: usbtmc: Proposal for new ioctl functions On Wed, Apr 04, 2018 at 10:03:22PM +, Guido Kiener wrote: > Greg, > > Before sending patches we want to be sure doing t

[PATCH] usbip: usbip_host: fix to hold parent lock for device_attach() calls

2018-04-05 Thread Shuah Khan
usbip_host calls device_attach() without holding dev->parent lock. Fix it. Signed-off-by: Shuah Khan Cc: stable --- drivers/usb/usbip/stub_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/usbip/stub_main.c b/drivers/usb/usbip/stub_main.c index c31c8402a0c5..d41d0cdeec

[PATCH] usbip: usbip_event: fix to not print kernel pointer address

2018-04-05 Thread Shuah Khan
Fix it to not print kernel pointer address. Remove the conditional and debug message as it isn't very useful. Signed-off-by: Shuah Khan Cc: stable --- drivers/usb/usbip/usbip_event.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/usbip/usbip_event.c b/drivers/usb/usbip/usbip

[PATCH] usbip: vhci_hcd: check rhport before using in vhci_hub_control()

2018-04-05 Thread Shuah Khan
Validate !rhport < 0 before using it to access port_status array. Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_hcd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 20e3d4609583..d11f3f8dad40 100644 ---

Re: [GIT PULL] USB/PHY driver patches for 4.17-rc1

2018-04-05 Thread Al Viro
On Thu, Apr 05, 2018 at 12:31:11AM -0700, Christoph Hellwig wrote: > On Thu, Apr 05, 2018 at 09:19:28AM +0200, Lars-Peter Clausen wrote: > > On 04/05/2018 08:31 AM, Kees Cook wrote: > > > On Wed, Apr 4, 2018 at 3:31 AM, Greg KH > > > wrote: > > >> Lars-Peter Clausen (2): > > >> usb: gadget:

make xmldocs failed with error after 4.17 merge period

2018-04-05 Thread Masanari Iida
After merge following patch during 4.17 merger period, make xmldocs start to fail with error. [bdecb33af34f79cbfbb656661210f77c8b8b5b5f] usb: typec: API for controlling USB Type-C Multiplexers Error messages. reST markup error: /home/iida/Repo/linux-2.6/Documentation/driver-api/usb/typec.rst:215

Re: [usb-next PATCH v11 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

2018-04-05 Thread Masahiro Yamada
2018-04-06 5:04 GMT+09:00 Martin Blumenstingl : > Hello, > > (great to hear that this might be useful on Socionext SoCs as well :)) > > On Wed, Apr 4, 2018 at 2:10 PM, Masahiro Yamada > wrote: >> 2018-03-04 6:43 GMT+09:00 Martin Blumenstingl >> : >>> Many SoC platforms have separate devices for th

Re: [usb-next PATCH v11 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

2018-04-05 Thread Martin Blumenstingl
On Fri, Apr 6, 2018 at 5:48 AM, Masahiro Yamada wrote: > 2018-04-06 5:04 GMT+09:00 Martin Blumenstingl > : >> Hello, >> >> (great to hear that this might be useful on Socionext SoCs as well :)) >> >> On Wed, Apr 4, 2018 at 2:10 PM, Masahiro Yamada >> wrote: >>> 2018-03-04 6:43 GMT+09:00 Martin Bl