Re: [PATCH v2 6/6] usb: gadget: udc: renesas_usb3: disable the controller's irqs for reconnecting

2018-04-10 Thread Simon Horman
On Tue, Apr 10, 2018 at 02:38:54PM +0900, Yoshihiro Shimoda wrote: > This patch fixes an issue that reconnection is possible to fail > because unexpected state handling happens by the irqs. To fix the issue, > the driver disables the controller's irqs when disconnected. > > Fixes: 746bfe63bba3

Re: [PATCH v2 5/6] usb: gadget: udc: renesas_usb3: should fail if devm_phy_get() returns error

2018-04-10 Thread Simon Horman
On Tue, Apr 10, 2018 at 02:38:53PM +0900, Yoshihiro Shimoda wrote: > This patch fixes an issue that this driver ignores errors other than > the non-existence of the device, f.e. a memory allocation failure > in devm_phy_get(). So, this patch replaces devm_phy_get() with > devm_phy_optional_get().

Re: [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-10 Thread Simon Horman
On Tue, Apr 10, 2018 at 01:28:33AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Monday, April 9, 2018 8:58 PM > > > > On Mon, Apr 02, 2018 at 09:21:34PM +0900, Yoshihiro Shimoda wrote: > > > This patch fixes an issue that this driver cannot call phy_init() > >

[PATCH v1 1/2] usb: dwc2: gadget: Fix coverity issue

2018-04-10 Thread Grigor Tovmasyan
When _param is unsigned and the minimum value of range is 0, CHECK_RANGE macro gives the following warning: COVERITY NO_EFFECT: This less-than-zero comparison of an unsigned value is never true. So I changed the type of hird_threshold from u8 to int to avoid that warning. Signed-off-by: Grigor

[PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-04-10 Thread Grigor Tovmasyan
Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. Changes from version 0: 1/2: - Instead of converting parameter in the CHECK_RANGE macro to int, changed hird_threshold type from u8 to int. Grigor Tovmasyan

[PATCH] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-04-10 Thread Yoshihiro Shimoda
This patch adds role switch support for R-Car SoCs. Some R-Car SoCs (e.g. R-Car H3) have USB 3.0 dual-role device controller which has the USB 3.0 xHCI host and Renesas USB 3.0 peripheral. Unfortunately, the mode change register contains the USB 3.0 peripheral controller side only. So, the USB

Since Linux 4.13 tlp or powertop usage cause "xHCI host controller not responding, assume dead" on Dell 5855

2018-04-10 Thread russianneuromancer
Hello! On Dell Venue 8 Pro 5855 tablet installing tlp or running "powertop -- auto-tune" cause "xHCI host controller not responding, assume dead" error, when error happen two integrated USB devices (Bluetooth adapter and LTE modem) disappear until reboot. First time this issue was observer in

RE: [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-10 Thread Yoshihiro Shimoda
Hi Simon-san, > From: Simon Horman, Sent: Tuesday, April 10, 2018 6:34 PM > > On Tue, Apr 10, 2018 at 01:28:33AM +, Yoshihiro Shimoda wrote: > > Hi Simon-san, > > > > > From: Simon Horman, Sent: Monday, April 9, 2018 8:58 PM > > > > > > On Mon, Apr 02, 2018 at 09:21:34PM +0900, Yoshihiro

Re: [PATCH] usb: serial: option: add HP LT4220 support

2018-04-10 Thread Johan Hovold
On Tue, Apr 03, 2018 at 10:34:39AM +0800, Edward Chang wrote: > This patch adds support for HP LT4220. > > Signed-off-by: Edward Chang > +/* HP products */ > +#define HP_VENDOR_ID 0x03f0 > +#define HP_PRODUCT_LT42200x0857

[PATCH 1/2] usb: gadget: udc: renesas_usb3: add property "renesas,ignore-id"

2018-04-10 Thread Yoshihiro Shimoda
This patch adds a new property to ignore the ID signal on a board. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ drivers/usb/gadget/udc/renesas_usb3.c | 10 ++ 2 files changed, 12

[PATCH 2/2] usb: gadget: udc: renesas_usb3: add devm_of_platform_populate()

2018-04-10 Thread Yoshihiro Shimoda
This patch adds devm_of_platform_populate() calling to populate the rcar-usb3-role-switch driver. For now, this renesas_usb3 driver doesn't use any APIs of the usb role switch framework because the usb_role_switch_get() API depends on the device_connection framework and this framework is not good

[PATCH 0/2] usb: gadet: udc: renesas_usb3: add role switch for R-Car SoCs

2018-04-10 Thread Yoshihiro Shimoda
This patch is based on the today's Linus master branch. This patch uses the USB role switch framework to attach/detach USB 3.0 host driver when changes the role via the rcar usb switch driver [1] and "usb_role" sysfs. [1] https://patchwork.kernel.org/patch/10332865/ In the future, I will add

[PATCH v2] usb: typec: ucsi: fix tracepoint related build error

2018-04-10 Thread Tobias Regnery
There is the following build error with CONFIG_TYPEC_UCSI=m, CONFIG_FTRACE=y and CONFIG_TRACING=n: ERROR: "__tracepoint_ucsi_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_register_port" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR:

Re: [PATCH v2 1/2] clk: at91: Added more information logging.

2018-04-10 Thread Alexandre Belloni
Hi, On 09/04/2018 20:16:21-0400, Marcin Ziemianowicz wrote: > I noticed that when debugging some USB clocking issue that there weren't > many ways to tell what the state of the USB clocking system was. This > adds a few logging statements to see what the relevant code is trying to > do. > >

[PATCH v1 2/2] usb: dwc2: gadget: Change LPM default values

2018-04-10 Thread Grigor Tovmasyan
Changed default values of LPM parameters to avoid "dwc2_check_params: Invalid parameter" warnings when hardware did not support LPM feature. Cc: Stefan Wahren Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/params.c | 8 1 file

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-10 Thread Heiko Stuebner
Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso: > devm_regulator_get_optional returns -ENODEV if the regulator isn't > there, so if that's the case we have to make sure not to leave -ENODEV > in the regulator pointer. > > Also, make sure we return 0 in that case, but correctly

[PATCH] lan78xx: Don't reset the interface on open

2018-04-10 Thread Phil Elwell
Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY initialisation into lan78xx_probe, but lan78xx_open subsequently calls lan78xx_reset. As well as forcing a second round of link negotiation, this reset frequently prevents the phy interrupt from being generated (even though the link

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-10 Thread Minas Harutyunyan
Hi Heiko, On 4/10/2018 4:28 PM, Heiko Stuebner wrote: > Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso: >> devm_regulator_get_optional returns -ENODEV if the regulator isn't >> there, so if that's the case we have to make sure not to leave -ENODEV >> in the regulator pointer. >> >>

Re: [PATCH] usb: storage: Replace mdelay with msleep in init_freecom

2018-04-10 Thread Alan Stern
On Tue, 10 Apr 2018, Jia-Ju Bai wrote: > init_freecom() is never called in atomic context. > > init_freecom() is set as ".initFunction" through UNUSUAL_DEV(). > And ->initFunction() is only called by usb_stor_acquire_resources(), > which is only called by usb_stor_probe2(). > usb_stor_probe2()

Re: [PATCH] usbip: vhci_hcd: check rhport before using in vhci_hub_control()

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 8.8613) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16:

Re: [PATCH] xhci: dump event ring, testpatch for Luciano

2018-04-10 Thread kbuild test robot
Hi Mathias, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16] [also build test WARNING on next-20180410] [cannot apply to usb/usb-testing] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: bug report : TBR oveflow

2018-04-10 Thread Mathias Nyman
On 01.04.2018 15:16, ljoubl...@gmail.com wrote: Hi Again Mathias, I did a system update yesterday (using gentoo, so I build everything with distcc), and managed to get it to crash. [48292.615897] xhci_hcd :01:00.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2

Re: [PATCH] usbip: usbip_event: fix to not print kernel pointer address

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has also determined it's probably a bug fixing patch. (score: 58.4237) The bot has tested the following trees:

RE: [PATCH] lan78xx: Don't reset the interface on open

2018-04-10 Thread Nisar.Sayed
Thanks Phil, for identifying the issues. > - ret = lan78xx_reset(dev); > - if (ret < 0) > - goto done; > - > phy_start(net->phydev); > > netif_dbg(dev, ifup, dev->net, "phy initialised successfully"); > -- You may need to start the interrupts before "phy_start"

Re: Lenovo ThinkVision X1 27" USB-C occasionally hangs the kernel (usbhid) and isn't setting a proper resolution when USB 3.0 (FHD) switched to USB 2.0 (UHD)

2018-04-10 Thread Heikki Krogerus
On Tue, Apr 10, 2018 at 09:05:07AM +, andrey.ara...@nixaid.com wrote: > Dear Linux Kernel Devs, > > I have recently got a Lenovo ThinkVision X1 27" monitor, it is connected to my > laptop over a USB-C cable (DisplayPort). > > This monitor has a built-in USB hub with a toggle button, when

[PATCH] net: usb: hso: Replace GFP_ATOMIC with GFP_KERNEL in hso_create_device

2018-04-10 Thread Jia-Ju Bai
hso_create_device() is never called in atomic context. The call chains ending up at hso_create_device() are: [1] hso_create_device() <- hso_create_bulk_serial_device() <- hso_probe() [2] hso_create_device() <- hso_create_mux_serial_device() <- hso_probe() [3] hso_create_device() <-

Re: [PATCH] lan78xx: Don't reset the interface on open

2018-04-10 Thread Phil Elwell
Hi Nisar, On 10/04/2018 15:16, nisar.sa...@microchip.com wrote: > Thanks Phil, for identifying the issues. > >> -ret = lan78xx_reset(dev); >> -if (ret < 0) >> -goto done; >> - >> phy_start(net->phydev); >> >> netif_dbg(dev, ifup, dev->net, "phy initialised

Re: [PATCH] net: usb: hso: Replace GFP_ATOMIC with GFP_KERNEL in hso_create_device

2018-04-10 Thread Johan Hovold
On Tue, Apr 10, 2018 at 10:35:24PM +0800, Jia-Ju Bai wrote: > hso_create_device() is never called in atomic context. > > The call chains ending up at hso_create_device() are: > [1] hso_create_device() <- hso_create_bulk_serial_device() <- hso_probe() > [2] hso_create_device() <-

Re: Not enough bandwidth with Magewell XI100DUSB-HDMI

2018-04-10 Thread Mathias Nyman
On 09.04.2018 11:21, Michael Tretter wrote: On Tue, 20 Feb 2018 15:29:28 +0200, Mathias Nyman wrote: On 16.02.2018 15:28, Michael Tretter wrote: On Mon, 29 Jan 2018 14:02:57 +0200, Mathias Nyman wrote: On 19.01.2018 22:12, Philipp Zabel wrote: On Fri, Jan 19, 2018 at 2:10 PM, Michael Tretter

Re: [PATCH] xhci: dump event ring, testpatch for Luciano

2018-04-10 Thread kbuild test robot
Hi Mathias, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16] [also build test WARNING on next-20180410] [cannot apply to usb/usb-testing] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-04-10 Thread Andy Shevchenko
On Tue, Apr 10, 2018 at 3:03 PM, Yoshihiro Shimoda wrote: > This patch adds role switch support for R-Car SoCs. Some R-Car SoCs > (e.g. R-Car H3) have USB 3.0 dual-role device controller which has > the USB 3.0 xHCI host and Renesas USB 3.0 peripheral. > >

Re: [PATCH] usbip: usbip_host: fix to hold parent lock for device_attach() calls

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has also determined it's probably a bug fixing patch. (score: 67.5935) The bot has tested the following trees:

Re: [PATCH] xhci: dump event ring, testpatch for Luciano

2018-04-10 Thread kbuild test robot
Hi Mathias, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16] [also build test WARNING on next-20180410] [cannot apply to usb/usb-testing] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-04-10 Thread Heiko Stübner
Am Dienstag, 10. April 2018, 15:52:25 CEST schrieb Minas Harutyunyan: > Hi Heiko, > > On 4/10/2018 4:28 PM, Heiko Stuebner wrote: > > Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso: > >> devm_regulator_get_optional returns -ENODEV if the regulator isn't > >> there, so if that's the

Re: [PATCH v2 0/2] clk: at91: Added more information logging

2018-04-10 Thread Boris Brezillon
Hi Marcin On Mon, 9 Apr 2018 20:15:51 -0400 Marcin Ziemianowicz wrote: > This is a series of patches which resolves set_rate() for the PLL not > having any effect and therefore the USB Host port not working. Also, a > few messages were added which may be helpful in the

Re: [PATCH] usb: typec: ucsi: fix tracepoint related build error

2018-04-10 Thread Tobias Regnery
On 09.04.18, Tobias Regnery wrote: > On 09.04.18, Heikki Krogerus wrote: > > On Mon, Apr 09, 2018 at 09:55:17AM +0200, Tobias Regnery wrote: > > > The ucsi driver defines several tracepoints, but the header file with the > > > tracepoint definition trace.h is only conditionally built depending on

Re: [PATCH v2 1/2] clk: at91: Added more information logging.

2018-04-10 Thread Boris Brezillon
Hi Marcin, On Mon, 9 Apr 2018 20:16:21 -0400 Marcin Ziemianowicz wrote: > I noticed that when debugging some USB clocking issue that there weren't > many ways to tell what the state of the USB clocking system was. This > adds a few logging statements to see what the

Re: [PATCH v2 2/2] clk: at91: Fix for PLL set_rate changes not being actually written to PLL peripheral bits

2018-04-10 Thread Boris Brezillon
Hi Marcin, On Mon, 9 Apr 2018 20:16:49 -0400 Marcin Ziemianowicz wrote: > When a USB device is connected to the USB host port on the SAM9N12 then > you get "-62" error which seems to indicate USB replies from the device > are timing out. Looking around, I saw the USB

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-04-10 Thread Felipe Balbi
Hi, Minas Harutyunyan writes: >>> Actually to fix this issue I updated condition of wait function >>> from: >>> !(dep->flags & DWC3_EP_END_TRANSFER_PENDING) >>> to: >>> !(dep->flags & DWC3_EP_END_TRANSFER_PENDING & DWC3_EP_ENABLED) >>

[PATCH 1/2] usb: isp1760: Replace mdelay with msleep in isp1760_init_core

2018-04-10 Thread Jia-Ju Bai
isp1760_init_core() is never called in atomic context. The call chains ending up at isp1760_init_core() are: [1] isp1760_init_core() <- isp1760_register() <- isp1760_plat_probe() [2] isp1760_init_core() <- isp1760_register() <- isp1761_pci_probe() isp1760_plat_probe() is set as ".probe" in

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-04-10 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > Hi Felipe, > > On 4/9/2018 4:28 AM, Felipe Balbi wrote: >> In case we get an event with status set to Missed Isoc, this means we >> have missed an isochronous interval and should issue End Transfer >> command and wait for the following

[PATCH 2/2] usb: isp1760: Replace mdelay with msleep in isp1760_stop

2018-04-10 Thread Jia-Ju Bai
isp1760_stop() is never called in atomic context. The call chain ending up at isp1760_stop() is: [1] isp1760_stop() <- isp1760_shutdown() isp1760_shutdown() is set as ".shutdown" in struct hc_driver. isp1760_stop() is also set as ".stop" in hc_driver. These functions are not called in atomic

Re: [PATCH] usb: typec: ucsi: fix tracepoint related build error

2018-04-10 Thread Heikki Krogerus
Hi Tobias, On Mon, Apr 09, 2018 at 01:40:53PM +0200, Tobias Regnery wrote: > You are right, building a defconfig, enable the UCSI driver and disable > CONFIG_FTRACE indeed builds without problems. So it must be some other > combination of config options. Attached is the randconfig which triggers

Re: [PATCH] xhci: Fix USB ports for Dell Inspiron 5775

2018-04-10 Thread Mathias Nyman
On 10.04.2018 07:56, Kai Heng Feng wrote: Hi Matthias, On Mar 18, 2018, at 11:11 PM, Kai-Heng Feng wrote: The Dell Inspiron 5775 is a Raven Ridge. The Enable Slot command timed out when a USB device gets plugged: [ 212.156326] xhci_hcd :03:00.3: Error while

[PATCH] usb: typec: ucsi: fix link error on randconfig

2018-04-10 Thread Heikki Krogerus
If building a kernel without FTRACE but with TRACING, ucsi.ko fails to link due to missing trace events. Fix this by using the correct Kconfig symbol on Makefile. Reported-by: Tobias Regnery Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface") Cc:

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-04-10 Thread Minas Harutyunyan
Hi Filipe, On 3/19/2018 5:53 PM, Minas Harutyunyan wrote: > Hi, > > On 3/19/2018 3:36 PM, Minas Harutyunyan wrote: >> Hi, >> >> On 3/19/2018 12:55 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Minas Harutyunyan writes: > Thanks for picking this for -next.

Re: [PATCH v2] usb: dwc2: Fix kernel doc's warnings.

2018-04-10 Thread Minas Harutyunyan
Hi, On 4/3/2018 5:15 PM, Grigor Tovmasyan wrote: > Added descriptions for all not described parameters. > Fix all kernel doc's warnings. > > Signed-off-by: Grigor Tovmasyan > --- > Changes from version 1: > > Fix minor kernel-doc style issue. > > Changes from version 0:

Re: [PATCH] usb: gadget: f_midi: Add configfs attrs for card and device

2018-04-10 Thread Jerry Zhang
> url: https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_midi-Add-configfs-attrs-for-card-and-device/20180410-061518 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > > config: x86_64-randconfig-x011-201814 (attached as .config) >

RE: [PATCH] usb: role: rcar-usb3-role-switch: add support for R-Car SoCs

2018-04-10 Thread Yoshihiro Shimoda
Hi Andy, Thank you for the review! > From: Andy Shevchenko, Sent: Tuesday, April 10, 2018 9:40 PM > > On Tue, Apr 10, 2018 at 3:03 PM, Yoshihiro Shimoda > wrote: > > +#include > > +#include > > +#include > > > +#include > > Do you need this one? If

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-04-10 Thread Thinh Nguyen
Hi, On 4/10/2018 12:36 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> Hi Felipe, >> >> On 4/9/2018 4:28 AM, Felipe Balbi wrote: >>> In case we get an event with status set to Missed Isoc, this means we >>> have missed an isochronous interval and should