Re: [PATCH] Revert "xhci: plat: Register shutdown for xhci_plat"

2018-04-13 Thread Harsh Shandilya
On 13 April 2018 11:51:28 AM IST, Greg Kroah-Hartman wrote: >On Fri, Apr 13, 2018 at 08:12:31AM +0530, Harsh Shandilya wrote: >> On 13 April 2018 5:59:51 AM IST, Greg Hackmann >wrote: >> >Pixel 2 field testers reported that when they tried to reboot their >> >phones with some USB devices plugged

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-04-13 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >>> Maybe we should return the -EXDEV status every time there's a missed isoc. >> >> you mean like this? > > Yes, this will work. updated to branch -- balbi signature.asc Description: PGP signature

Chip Idea host usb hub port power switching

2018-04-13 Thread Middelschulte, Leif
Hi, I was trying to get the USB Hub Port Power Switching to work, when I came across an - apparently - odd behavior: If CI_HDRC_TURN_VBUS_EARLY_ON is enabled[0], the regulator (reg_vbus) is not remembered and thus not switchable by the ehci_ci_portpower routine[1] later on. Is this behavior inte

Re: [PATCH v3 0/5] usb: typec: remove max_snk_mv/ma/mw

2018-04-13 Thread Hans de Goede
Hi, On 13-04-18 07:55, Li Jun wrote: This patch set is to remove max_snk_mv/ma/mw configs, as we should define the sink capability by sink PDOs, the first patch update the source PDO match policy by compare the voltage range between source and sink PDOs no matter what type they are, the followin

Re: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

2018-04-13 Thread Jun Li
2018-04-03 16:29 GMT+08:00 Andrzej Hajda : > > On 28.03.2018 18:06, Li Jun wrote: > > Add bingdings supported by current typec driver, so user can pass > > all those properties via dt. > > > > Signed-off-by: Li Jun > > --- > > .../bindings/connector/usb-connector.txt | 39 > > +

[PATCH] xhci: Fix Kernel oops in xhci dbgtty

2018-04-13 Thread Mathias Nyman
From: Zhengjun Xing tty_unregister_driver may be called more than 1 time in some hotplug cases,it will cause the kernel oops. This patch checked dbc_tty_driver to make sure it is unregistered only 1 time. [ 175.741404] BUG: unable to handle kernel NULL pointer dereference at 0034 [

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-04-13 Thread Bockholdt Arne
On Thu, 2018-04-12 at 07:20 +0200, Ard Biesheuvel wrote: > On 12 April 2018 at 07:05, Bockholdt Arne > wrote: > > > > On Wed, 2018-04-11 at 15:02 +0100, Marc Zyngier wrote: > > > > On Wed, 11 Apr 2018 14:11:52 +0100, > > Bockholdt Arne wrote: > > > > > > Hi all, > > > > is there anything ne

[PATCH v4 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-13 Thread Li Jun
Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- drivers/usb/typec/fusb302/fusb302.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/dr

[PATCH v4 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-13 Thread Li Jun
This patch is a combination of commit 57e6f0d7b804 ("typec: tcpm: Only request matching pdos") and source pdo selection optimization based on it, instead of only compare between the same pdo type of sink and source, we should check source pdo voltage range is within the voltage range of one sink pd

[PATCH v4 0/5] usb: typec: remove max_snk_mv/ma/mw

2018-04-13 Thread Li Jun
This patch set is to remove max_snk_mv/ma/mw configs, as we should define the sink capability by sink PDOs, the first patch update the source PDO match policy by compare the voltage range between source and sink PDOs no matter what type they are, the following patchs remove those 3 variables from 2

[PATCH v4 5/5] usb: typec: tcpm: remove max_snk_mv/ma/mw

2018-04-13 Thread Li Jun
Since there is no user of max_snk_*, so we can remove them from tcpm. Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 12 include/linux/usb/tcpm.h | 9 - 2 files changed, 21 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/t

[PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Li Jun
Remove max-sink-* properties since they are deprecated. Reviewed-by: Rob Herring Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302

[PATCH v4 4/5] usb: typec: wcove: remove max_snk_* for sink config

2018-04-13 Thread Li Jun
Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- drivers/usb/typec/typec_wcove.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/typec/typec_wcove.c b/driver

[PATCH 2/3] USB: musb: host: prevent core phy initialisation

2018-04-13 Thread Johan Hovold
Set the new HCD flag which prevents USB core from trying to manage our phys. This is needed to be able to associate the controller platform device with the glue device device-tree node on the BBB which uses legacy USB phys. Otherwise, the generic phy lookup in usb_phy_roothub_init() and thus HCD r

[PATCH 3/3] USB: musb: dsps: propagate device-tree node

2018-04-13 Thread Johan Hovold
To be able to use DSPS-based controllers with device-tree descriptions of the USB topology, we need to associate the glue device's device-tree node with the child controller device. Note that this can also be used to eventually let USB core manage generic phys. Also note that the other glue drive

[PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support

2018-04-13 Thread Johan Hovold
I've been carrying a patch out-of-tree since my work on improving the USB device-tree support which is needed to be able to describe USB topologies for musb based controllers. This patch, which associates the platform controller device with the glue device device-tree node, did not play well with

[PATCH 1/3] USB: musb: dsps: drop duplicate phy initialisation

2018-04-13 Thread Johan Hovold
Since commit 39cee200c23e ("usb: musb: core: call init and shutdown for the usb phy") the musb USB phy is initialised by musb_core, but the original initialisation in the dsps-glue init callback was left in place resulting in two calls to phy init during probe (and similarly, two shutdowns on remov

Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Guenter Roeck
On Fri, Apr 13, 2018 at 10:18:43PM +0800, Li Jun wrote: > Remove max-sink-* properties since they are deprecated. > > Reviewed-by: Rob Herring > Reviewed-by: Hans de Goede > Signed-off-by: Li Jun > --- > Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 -- > 1 file changed, 6 dele

[PATCH v2 3/3] usb: dwc3: core: Suspend PHYs on runtime suspend in host mode

2018-04-13 Thread Manu Gautam
Some PHY drivers (e.g. for Qualcomm QUSB2 and QMP PHYs) support runtime PM to reduce PHY power consumption during bus_suspend. Add changes to let core auto-suspend PHYs on host bus-suspend using GUSB2PHYCFG register if needed for a platform. Also perform PHYs runtime suspend/resume and let platform

[PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-04-13 Thread Manu Gautam
DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. Some of its uses are described below resulting in need to have a separate glue driver instead of using dwc3-of-simple: - It exposes register interface to override vbus-override and lane0-pwr-present signals going to hardware. These mus

[PATCH v2 1/3] dt-bindings: usb: Update documentation for Qualcomm DWC3 driver

2018-04-13 Thread Manu Gautam
Existing documentation has lot of incorrect information as it was originally added for a driver that no longer exists. Signed-off-by: Manu Gautam --- .../devicetree/bindings/usb/qcom,dwc3.txt | 78 -- 1 file changed, 57 insertions(+), 21 deletions(-) diff --git a/Do

[PATCH v2 0/3] usb: dwc3: support for Qualcomm DWC3 glue

2018-04-13 Thread Manu Gautam
Add separate dwc3-qcom glue driver for Qualcomm SOCs having dwc3 core. It is needed to support peripheral mode. Patches also add support to invoke PHY runtime PM functions on host mode bus-suspend. Changes since v1: - Move dwc3 core register accesses from glue driver to dwc3 core as per review

Re: [PATCH v4 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-13 Thread Hans de Goede
Hi, On 13-04-18 17:58, Guenter Roeck wrote: On Fri, Apr 13, 2018 at 10:18:41PM +0800, Li Jun wrote: This patch is a combination of commit 57e6f0d7b804 ("typec: tcpm: Only request matching pdos") and source pdo selection optimization based on it, instead of only compare between the same pdo type

Re: [PATCH v4 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-13 Thread Guenter Roeck
On Fri, Apr 13, 2018 at 10:18:42PM +0800, Li Jun wrote: > Since max_snk_* is to be deprecated, so remove max_snk_* by adding a > variable PDO for sink config. max_snk or max_sink ? > > Reviewed-by: Hans de Goede > Signed-off-by: Li Jun > --- > drivers/usb/typec/fusb302/fusb302.c | 34

Re: [PATCH v4 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-13 Thread Guenter Roeck
On Fri, Apr 13, 2018 at 10:18:41PM +0800, Li Jun wrote: > This patch is a combination of commit 57e6f0d7b804 > ("typec: tcpm: Only request matching pdos") and source > pdo selection optimization based on it, instead of only > compare between the same pdo type of sink and source, > we should check s

Re: [PATCH v5 2/2] dt-bindings: usb: rt1711h device tree binding document

2018-04-13 Thread Rob Herring
On Mon, Apr 09, 2018 at 10:11:35AM +0800, ShuFan Lee wrote: > From: ShuFan Lee > > Add device tree binding document for Richtek RT1711H Type-C chip driver > > Signed-off-by: ShuFan Lee > --- > .../devicetree/bindings/usb/richtek,rt1711h.txt | 17 > + > 1 file changed,

Re: [PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-04-13 Thread Jack Pham
Hi Manu, On Fri, Apr 13, 2018 at 10:21:23PM +0530, Manu Gautam wrote: > DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. > Some of its uses are described below resulting in need to > have a separate glue driver instead of using dwc3-of-simple: > - It exposes register interface to override

[PATCH v1 1/1] usb: core: Add quirk for HP v222w 16GB Mini

2018-04-13 Thread sathyanarayanan . kuppuswamy
From: Kamil Lulko Add DELAY_INIT quirk to fix the following problem with HP v222w 16GB Mini: usb 1-3: unable to read config index 0 descriptor/start: -110 usb 1-3: can't read configurations, error -110 usb 1-3: can't set config #1, error -110 Signed-off-by: Kamil Lulko Signed-off-by: Kuppuswam

[PATCH v1 1/1] usb: hub: Don't wait for connect state at resume for powered-off ports

2018-04-13 Thread sathyanarayanan . kuppuswamy
From: Dominik Bozek wait_for_connected() wait till a port change status to USB_PORT_STAT_CONNECTION, but this is not possible if the port is unpowered. The loop will only exit at timeout. Such case take place if an over-current incident happen while system is in S3. Then during resume wait_for_c

Re: [PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-04-13 Thread Manu Gautam
Hi Jack, On 4/13/2018 11:03 PM, Jack Pham wrote: > Hi Manu, > > On Fri, Apr 13, 2018 at 10:21:23PM +0530, Manu Gautam wrote: >> DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. >> Some of its uses are described below resulting in need to >> have a separate glue driver instead of using dwc

Re: [PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-04-13 Thread Jack Pham
On Fri, Apr 13, 2018 at 11:32:04PM +0530, Manu Gautam wrote: > On 4/13/2018 11:03 PM, Jack Pham wrote: > > Are the extcon phandles bound to the glue node? I don't see the > > description in the bindings doc in PATCH 1/3. And if so, would it be > > a duplicate of the child node's extcon binding? The

Re: [PATCH 1/3] USB: musb: dsps: drop duplicate phy initialisation

2018-04-13 Thread Uwe Kleine-König
On Fri, Apr 13, 2018 at 05:15:03PM +0200, Johan Hovold wrote: > Since commit 39cee200c23e ("usb: musb: core: call init and shutdown for > the usb phy") the musb USB phy is initialised by musb_core, but the > original initialisation in the dsps-glue init callback was left in > place resulting in two

RE: [PATCH v4 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-13 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: 2018年4月13日 23:58 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; > yueyao@gmail.com; linux-usb@vger.kernel.org;

RE: [PATCH v4 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-13 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: 2018年4月14日 0:03 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; > yueyao@gmail.com; linux-usb@vger.kernel.org;

RE: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Jun Li
> -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: 2018年4月14日 0:04 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; > yueyao@gmail.com; linux-usb@vger.kernel.org; dl

RE: [PATCH v4 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-13 Thread Jun Li
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年4月14日 0:54 > To: Guenter Roeck ; Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; rmf...@gmail.com; yueyao@gmail.com; > linux-usb@vger.kernel.org; dl-li

Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Guenter Roeck
On 04/13/2018 04:31 PM, Jun Li wrote: -Original Message- From: Guenter Roeck [mailto:li...@roeck-us.net] Sent: 2018年4月14日 0:04 To: Jun Li Cc: gre...@linuxfoundation.org; robh...@kernel.org; heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; yueyao@gmail.com; li

RE: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Jun Li
Hi Guenter, > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年4月14日 11:03 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; > yueyao@gm

Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Guenter Roeck
On 04/13/2018 08:42 PM, Jun Li wrote: Hi Guenter, -Original Message- From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck Sent: 2018年4月14日 11:03 To: Jun Li Cc: gre...@linuxfoundation.org; robh...@kernel.org; heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf.