Re: [PATCH v2 1/3] usb: roles: intel_xhci: Always allow user control

On Wed, May 23, 2018 at 08:03:43PM +0200, Hans de Goede wrote: > Hi, > > On 23-05-18 16:37, Heikki Krogerus wrote: > > Trying to determine the USB port type with this mux is very > > difficult. To simplify the situation, always allowing user > > control, even if the port is USB Type-C port. > >

Re: [PATCH v2 1/3] usb: roles: intel_xhci: Always allow user control

On Wed, May 23, 2018 at 07:10:58PM +0300, Sergei Shtylyov wrote: > On 05/23/2018 05:37 PM, Heikki Krogerus wrote: > > > Trying to determine the USB port type with this mux is very > > difficult. To simplify the situation, always allowing user > >s/allowing/allow/? Else the statement doesn't

Re: [PATCH v3] usbip: dynamically allocate idev by nports found in sysfs

On Wed, May 23, 2018 at 10:44:57AM -0600, Shuah Khan wrote: > On 05/23/2018 03:22 AM, Michael Grzeschik wrote: > > As the amount of available ports varies by the kernels build > > configuration. To remove the limitation of the fixed 128 ports > > we allocate the amount of idevs by using the number

[PATCH v3 1/4] usb: roles: intel_xhci: Always allow user control

Trying to determine the USB port type with this mux is very difficult. To simplify the situation, always allow user control, even if the port is USB Type-C port. Reviewed-by: Hans de Goede Signed-off-by: Heikki Krogerus ---

[PATCH v3 2/4] platform: x86: intel_cht_int33fe: Fix dependencies

The driver will not probe unless bq24190 is loaded, so making it a dependency. Signed-off-by: Heikki Krogerus Cc: Wolfram Sang Cc: Darren Hart Cc: Andy Shevchenko ---

[PATCH v3 4/4] usb: roles: intel_xhci: Enable runtime PM

This fixes an issue where the mux does not get configured when the parent device is suspended. The registers for this mux are mapped to the parent device MMIO (usually xHCI PCI device), so in order for the driver to be able to program the registers, the parent device must be resumed. Reported-by:

[PATCH v3 3/4] usb: typec: fusb302: Fix debugfs issue

Removing the "fusb302" debugfs directory when unloading the driver. That allows the driver to be loaded more then one time. The directory will not get actually removed until it is empty, so only after the last instance has been removed. This fixes an issue where the driver can't be re-loaded if

[PATCH v3 0/4] usb: typec: fixes for Cherry Trails

Hi, This is third version of patches that fix various problems I encountered while testing my USB Type-C Alternate Mode patches with GPD Win board (Intel Cherry Trail based). I added one more patch to this series. Sathyanarayanan reported an issue where the mux does not get configured when xHCI

Re: [PATCH/RFC v4 2/4] usb: gadget: udc: renesas_usb3: Add register of usb role switch

Hi Rob, On Wed, May 23, 2018 at 5:00 PM, Rob Herring wrote: > On Wed, May 23, 2018 at 1:52 AM, Yoshihiro Shimoda > wrote: >>> From: Rob Herring, Sent: Wednesday, May 23, 2018 2:13 AM >>> On Tue, May 22, 2018 at 09:01:07PM +0900, Yoshihiro

Re: [PATCH v3 3/4] usb: typec: fusb302: Fix debugfs issue

On 05/24/2018 01:18 AM, Heikki Krogerus wrote: Removing the "fusb302" debugfs directory when unloading the driver. That allows the driver to be loaded more then one time. The directory will not get actually removed until it is empty, so only after the last instance has been removed. This fixes

[PATCH] usb: typec: wcove: Remove dependency on HW FSM

The USB Type-C PHY in Intel WhiskeyCove PMIC has build-in USB Type-C state machine which we were relying on to configure the CC lines correctly. This patch removes that dependency and configures the CC line according to commands from the port manager (tcpm.c) in wcove_set_cc(). This fixes an

4.16 issue with mbim modem and ping with size > 14552 bytes

Hello, I have an issue with an USB mbim modem when trying to send with ping more than 14552 bytes: it looks like to me a kernel issue, but not at the cdc_mbim or cdc_ncm level, anyway not sure, so I'm reporting the issue. My kernel is 4.16. The device is the following: root@L2122:~# ifconfig

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

Oliver, On 2018-05-17 19:04, Oliver Neukum wrote: Am Donnerstag, den 17.05.2018, 12:29 +0530 schrieb Tushar Nimkar: Those commands issued from different layers say: sd.. uas.. scsi.. so making them to go one after other. Once REPORT_LUN done go with READ_CAPACITY_16. This is only for the UAS

Re: Serdev: USB device and sysdev probing ala i2c

Hi Ricardo, On Wed, May 23, 2018 at 11:17:20AM +0200, Ricardo Ribalda Delgado wrote: > Hi > > I have a flash controller connected to the main computer via a usb to > serial. My plan is to expose it to the system as a video4linux subdevice. > > With the inclusion of serdev I was expecting that

Re: Serdev: USB device and sysdev probing ala i2c

Hi Johan, On Thu, May 24, 2018 at 2:07 PM Johan Hovold wrote: > Hi Ricardo, > On Wed, May 23, 2018 at 11:17:20AM +0200, Ricardo Ribalda Delgado wrote: > > Hi > > > > I have a flash controller connected to the main computer via a usb to > > serial. My plan is to expose it to

Re: [PATCH 02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle

Zitat von Oliver Neukum : Am Montag, den 21.05.2018, 21:00 + schrieb guido@kiener- muenchen.de: I looked for a race here, but I do not find a race between open and release, since a refcount of "file_data->data->kref" is always hold by usbtmc_probe/disconnect. However I

Re: [PATCH 04/12] usb: usbtmc: Add ioctls for trigger, EOM bit and TermChar

Zitat von Oliver Neukum : Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: +   retval = usb_bulk_msg(data->usb_dev, + usb_sndbulkpipe(data->usb_dev, + data->bulk_out), +   

Re: [PATCH 07/12] usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ

Zitat von Oliver Neukum : Am Donnerstag, den 17.05.2018, 19:03 +0200 schrieb Guido Kiener: +static int usbtmc488_ioctl_wait_srq(struct usbtmc_file_data *file_data, +   unsigned int __user *arg) +{ +   struct usbtmc_device_data *data =

Re: [PATCH] usb: gadget: f_uvc: Expose configuration name through video node

Hi Kieran, Thank you for the patch. On Wednesday, 23 May 2018 23:39:47 EEST Kieran Bingham wrote: > From: Kieran Bingham > > When utilising multiple instantiations of a UVC gadget on a composite > device, there is no clear method to link a particular

Re: [RFC] driver core: don't hold dev's parent lock when using async probe

On Thu, 24 May 2018, Martin Liu wrote: > On Tue, May 22, 2018 at 01:09:44PM -0400, Alan Stern wrote: > > On Tue, 22 May 2018, martin_liu wrote: > > > > > not sure if we still need 'bf74ad5bc417 ("[PATCH] Hold the > > > device's parent's lock during probe and remove")' since it has > > > been

Re: usb HC busted?

Hi On 24.05.2018 00:29, Sudip Mukherjee wrote: Hi Mathias, On Fri, May 18, 2018 at 04:19:02PM +0300, Mathias Nyman wrote: On 18.05.2018 16:04, Sudip Mukherjee wrote: Hi Mathias, On Fri, May 18, 2018 at 03:55:04PM +0300, Mathias Nyman wrote: Hi, Looks like event for Transfer block (TRB) at

Re: [PATCH] usb: gadget: dwc2: fix memory leak in gadget_init()

Hi Stefan, Marek Please test this patch and tell if it will cause any problem. Thanks, Grigor On 5/24/2018 6:22 PM, Grigor Tovmasyan wrote: > Freed allocated request for ep0 to prevent memory leak in case when > dwc2_driver_probe() failed. > > Signed-off-by: Grigor Tovmasyan

Re: [RFC] driver core: don't hold dev's parent lock when using async probe

On Tue, May 22, 2018 at 01:09:44PM -0400, Alan Stern wrote: > On Tue, 22 May 2018, martin_liu wrote: > > > not sure if we still need 'bf74ad5bc417 ("[PATCH] Hold the > > device's parent's lock during probe and remove")' since it has > > been there over 10 years. If we still need it and hard to

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

On Thu, 24 May 2018, Nicolas Boichat wrote: > On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman > wrote: > > On Wed, May 23, 2018 at 10:03:55AM -0400, Alan Stern wrote: > >> On Wed, 23 May 2018, Nicolas Boichat wrote: > >> > >> > The "old" enumeration scheme is

Re: [Query] checking hub port status while USB 2.0 port is resuming.

On Thu, 24 May 2018, Anshuman Gupta wrote: > On Wed, May 23, 2018 at 09:55:40AM -0400, Alan Stern wrote: > > On Wed, 23 May 2018, Anshuman Gupta wrote: > > > > > On Tue, May 22, 2018 at 11:54:19AM -0400, Alan Stern wrote: > > > > On Tue, 22 May 2018, Anshuman Gupta wrote: > > > > > > > > > On

Re: [RFC] driver core: don't hold dev's parent lock when using async probe

On Thu, May 24, 2018 at 11:02:57AM -0400, Alan Stern wrote: > On Thu, 24 May 2018, Martin Liu wrote: > > > On Tue, May 22, 2018 at 01:09:44PM -0400, Alan Stern wrote: > > > On Tue, 22 May 2018, martin_liu wrote: > > > > > > > not sure if we still need 'bf74ad5bc417 ("[PATCH] Hold the > > > >

Re: [GIT PULL] USB for v4.18 merge window

On Mon, May 21, 2018 at 11:25:09AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's my pull request for v4.18 merge window. Let me know if you want > anything to be changed. > > For the rest of the week I'll have very scarce access to email, so > replies may be delayed. > > Cheers > > The

[PATCH v2] usb: gadget: uvc: Expose configuration name through video node

From: Kieran Bingham When utilising multiple instantiations of a UVC gadget on a composite device, there is no clear method to link a particular configuration to its respective video node. Provide a means for identifying the correct video node by exposing the

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

On Thu, May 24, 2018 at 07:42:00AM +0800, Nicolas Boichat wrote: > On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman > wrote: > > On Wed, May 23, 2018 at 10:03:55AM -0400, Alan Stern wrote: > >> On Wed, 23 May 2018, Nicolas Boichat wrote: > >> > >> > The "old"

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

On Thu, May 24, 2018 at 05:04:49PM +0200, Daniele Palmas wrote: > Hello, > > I have an issue with an USB mbim modem when trying to send with ping > more than 14552 bytes: it looks like to me a kernel issue, but not at > the cdc_mbim or cdc_ncm level, anyway not sure, so I'm reporting the > issue.

Re: Serdev: USB device and sysdev probing ala i2c

On Thu, May 24, 2018 at 7:18 AM, Ricardo Ribalda Delgado wrote: > Hi Johan, > > On Thu, May 24, 2018 at 2:07 PM Johan Hovold wrote: > >> Hi Ricardo, > >> On Wed, May 23, 2018 at 11:17:20AM +0200, Ricardo Ribalda Delgado wrote: >> > Hi >> > >> > I have

Re: Serdev: USB device and sysdev probing ala i2c

Hi Rob On Thu, May 24, 2018 at 6:49 PM Rob Herring wrote: > On Thu, May 24, 2018 at 7:18 AM, Ricardo Ribalda Delgado > wrote: > > Hi Johan, > > > > On Thu, May 24, 2018 at 2:07 PM Johan Hovold wrote: > > > >> Hi Ricardo, > > > >> On

Re: [PATCH v3 4/4] usb: roles: intel_xhci: Enable runtime PM

Hi, On 05/24/2018 01:18 AM, Heikki Krogerus wrote: This fixes an issue where the mux does not get configured when the parent device is suspended. The registers for this mux are mapped to the parent device MMIO (usually xHCI PCI device), so in order for the driver to be able to program the

Re: [PATCH v2] usb: gadget: uvc: Expose configuration name through video node

Hi Kieran, Thank you for the patch. On Thursday, 24 May 2018 19:16:12 EEST Kieran Bingham wrote: > From: Kieran Bingham > > When utilising multiple instantiations of a UVC gadget on a composite > device, there is no clear method to link a particular

Re: [RFT/PATCH 00/38] usb: dwc3: gadget: Rework & Refactoring

Hi Felipe, On Friday, 20 April 2018 13:57:23 EEST Felipe Balbi wrote: > Bin Liu writes: > >> Felipe Balbi writes: > > Bin Liu writes: > >> On Mon, Apr 09, 2018 at 02:26:14PM +0300, Felipe Balbi wrote: > >>> Hi guys, >

[PATCH] usb: gadget: dwc2: fix memory leak in gadget_init()

Freed allocated request for ep0 to prevent memory leak in case when dwc2_driver_probe() failed. Signed-off-by: Grigor Tovmasyan Cc: Stefan Wahren Cc: Marek Szyprowski --- drivers/usb/dwc2/gadget.c | 7 +-- 1 file

Re: [RFT/PATCH 00/38] usb: dwc3: gadget: Rework & Refactoring

Hello again, On Thursday, 24 May 2018 22:59:18 EEST Laurent Pinchart wrote: > On Friday, 20 April 2018 13:57:23 EEST Felipe Balbi wrote: > > Bin Liu writes: > >>> Felipe Balbi writes: > >> Bin Liu writes: > >>> On Mon, Apr 09,

Re: [Query] checking hub port status while USB 2.0 port is resuming.

On Thu, 24 May 2018, Anshuman Gupta wrote: > > > > I'm not sure what you're asking. If the port's suspend feature is set, > > > > of course the kernel has to clear the feature and wait for the port to > > > > resume. If the suspend feature isn't set then the pm_wakeup_event will > > > > be

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

On Fri, May 25, 2018 at 12:21 AM, Greg Kroah-Hartman wrote: > On Thu, May 24, 2018 at 07:42:00AM +0800, Nicolas Boichat wrote: >> On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman >> wrote: >> > On Wed, May 23, 2018 at 10:03:55AM -0400,

RE: [PATCH/RFC v4 2/4] usb: gadget: udc: renesas_usb3: Add register of usb role switch

Hi Rob, Geert-san, > From: Geert Uytterhoeven, Sent: Thursday, May 24, 2018 5:18 PM > > Hi Rob, > > On Wed, May 23, 2018 at 5:00 PM, Rob Herring wrote: > >>> > Optional properties: > >>> >- phys: phandle + phy specifier pair > >>> >- phy-names: must be "usb" > >>> >

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

Hi Greg, 2018-05-24 17:53 GMT+02:00 Greg KH : > On Thu, May 24, 2018 at 05:04:49PM +0200, Daniele Palmas wrote: >> Hello, >> >> I have an issue with an USB mbim modem when trying to send with ping >> more than 14552 bytes: it looks like to me a kernel issue, but not at

[PATCH] usb: dwc2: gadget: ISOC's starting flow improvement

To start ISOC transfers in handlers dwc2_gadget_handle_nak() and dwc2_gadget_handle_out_token_ep_disabled() driver reads current frame number, based on which, set target frame number to start first ISOC transfer. In case if system's high IRQ latency and multiple EP's asserted interrupt in same

Re: [PATCH] usb: gadget: dwc2: fix memory leak in gadget_init()

Hi Grigor, On 2018-05-24 16:22, Grigor Tovmasyan wrote: > Freed allocated request for ep0 to prevent memory leak in case when > dwc2_driver_probe() failed. > > Signed-off-by: Grigor Tovmasyan > Cc: Stefan Wahren > Cc: Marek Szyprowski