Re: Query on usb/core/devio.c

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Mayuresh Kulkarni wrote: > > The only way to make the ioctl work properly is to have it do a > > runtime-PM put at the start and then a runtime-PM get before it > > returns. This is true regardless of the reason for returning: normal > > termination, timeout, signal,

Re: Query on usb/core/devio.c

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Mayuresh Kulkarni wrote: > As I understand, you seem to mention - user-space to tell the USB > device when to remote-wake. > But in our case, we cannot tell the device when to remote-wake as the > USB device needs to detect an "activity" by end user (after link goes > into

Re: [PATCH] HID: hiddev: fix potential Spectre v1

2018-10-18 Thread Breno Leitao
Hi Gustavo, On 10/17/2018 05:30 PM, Gustavo A. R. Silva wrote: > > Hi Breno, > > On 10/17/18 9:47 PM, Breno Leitao wrote: >> uref->usage_index can be indirectly controlled by userspace, hence leading >> to a potential exploitation of the Spectre variant 1 vulnerability. >> >> This problem might

Re: Query on usb/core/devio.c

2018-10-18 Thread Mayuresh Kulkarni
On Wed, 17 Oct 2018 10:32:14 -0400 Alan Stern wrote: > On Wed, 17 Oct 2018, Oliver Neukum wrote: > > > On Di, 2018-10-16 at 10:46 -0400, Alan Stern wrote: > > > On Tue, 16 Oct 2018, Mayuresh Kulkarni wrote: > > > > > > > 1. User space decides when it is time to suspend the device and calls > >

Re: [PATCH] HID: hiddev: fix potential Spectre v1

2018-10-18 Thread Greg KH
On Thu, Oct 18, 2018 at 01:50:26PM -0300, Breno Leitao wrote: > Hi Gustavo, > > On 10/17/2018 05:30 PM, Gustavo A. R. Silva wrote: > > > > Hi Breno, > > > > On 10/17/18 9:47 PM, Breno Leitao wrote: > >> uref->usage_index can be indirectly controlled by userspace, hence leading > >> to a

Re: Error reading USB camera in BeagleBone with ARM Debian

2018-10-18 Thread Alan Stern
On Thu, 18 Oct 2018, Josep M. Mirats Tur wrote: > Hi > > I've recently acquired a BeagleBone Green with AM335x processor. I 'm > connecting a USB device (actually a 3D camera from ORBBEC) to the > Beagle USB host port. It recognizes well as I can see at the dmesg > output: > > [12411.643517]

Error reading USB camera in BeagleBone with ARM Debian

2018-10-18 Thread Josep M. Mirats Tur
Hi I've recently acquired a BeagleBone Green with AM335x processor. I 'm connecting a USB device (actually a 3D camera from ORBBEC) to the Beagle USB host port. It recognizes well as I can see at the dmesg output: [12411.643517] usb 1-1: new high-speed USB device number 2 using musb-hdrc

[PATCH] usb: dwc2: pci: Fix an error code in probe

2018-10-18 Thread Dan Carpenter
We added some error handling to this function but forgot to set the error code on this path. Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") Signed-off-by: Dan Carpenter --- drivers/usb/dwc2/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/pci.c

Re: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Frieder Schrempf
On 18.10.18 03:22, Peter Chen wrote: - System suspend/resume 1. Enable USB wakeup for i in $(find /sys -name wakeup | grep usb);do echo enabled  > $i;echo "echo enabled > $i";done; 2. Let the system enter suspend using below command echo mem > /sys/power/state 3. And see if there is a wakeup

Re: [PATCH] usb: dwc2: pci: Fix an error code in probe

2018-10-18 Thread Minas Harutyunyan
On 10/18/2018 11:37 AM, Dan Carpenter wrote: > We added some error handling to this function but forgot to set the > error code on this path. > > Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") > Signed-off-by: Dan Carpenter Acked-by: Minas Harutyunyan > --- >

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Peter Chen
> > > > Thanks, Frieder, no more tests are needed. > > You could send me your dts changes as patches, I will append it at my v2 > > patch > series. > > My board is currently off-tree so I can't send any patch for the pinmux > settings in > devicetree. But I will send a patch with the changes

Re: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Frieder Schrempf
On 18.10.18 10:48, Peter Chen wrote: Thanks, Frieder, no more tests are needed. You could send me your dts changes as patches, I will append it at my v2 patch series. My board is currently off-tree so I can't send any patch for the pinmux settings in devicetree. But I will send a patch

[PATCH 1/2] usb: phy: ab8500: silence some uninitialized variable warnings

2018-10-18 Thread Dan Carpenter
Smatch complains that "reg" can be uninitialized if the abx500_get_register_interruptible() call fails. It's an interruptable function, so we should check if the user presses CTRL-C. Signed-off-by: Dan Carpenter --- drivers/usb/phy/phy-ab8500-usb.c | 8 ++-- 1 file changed, 6

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-18 Thread Peter Chen
> >> My board is currently off-tree so I can't send any patch for the > >> pinmux settings in devicetree. But I will send a patch with the > >> changes that should go to imx6qdl.dtsi, imx6sl.dtsi and imx6sx.dtsi. > >> Though I > only tested on i.MX6S. > >> > > > > No, the changes are board

[GIT PULL] USB-serial updates for v4.20-rc1

2018-10-18 Thread Johan Hovold
The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8: Linux 4.19-rc4 (2018-09-16 11:52:37 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.20-rc1 for you to fetch changes up to

Re: [GIT PULL] USB-serial updates for v4.20-rc1

2018-10-18 Thread Greg Kroah-Hartman
On Thu, Oct 18, 2018 at 12:55:42PM +0200, Johan Hovold wrote: > The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8: > > Linux 4.19-rc4 (2018-09-16 11:52:37 -0700) > > are available in the Git repository at: > >

Re: Query on usb/core/devio.c

2018-10-18 Thread Mayuresh Kulkarni
On Tue, 16 Oct 2018 10:35:47 -0400 Alan Stern wrote: > On Tue, 16 Oct 2018, Mayuresh Kulkarni wrote: > > > > How about instead having a mechanism whereby your usrspace driver can > > > tell when the device does a remote wakeup? At that point it could > > > submit an URB via usbfs and receive