Re: [PATCH 4/4] usb: dwc3: gadget: check if dep->frame_number is still valid

2018-11-09 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > In the case of interval of 1ms, it will start on the next interval. >> frame_number + max(4, interval) will start at least 4 uframes in the future. >> >> In any case, what about immediately retry the START_TRANSFER command >> with a new frame_number +

Re: [PATCH 4/4] usb: dwc3: gadget: check if dep->frame_number is still valid

2018-11-09 Thread Felipe Balbi
Hi, Thinh Nguyen writes: diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index d8c7ad0c22e8..00fe01a01977 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1268,12 +1268,22 @@ static int __dwc3_gadget_get_frame(struct dwc3

Re: [PATCH v2 2/3] spi: add FTDI MPSSE SPI controller driver

2018-11-09 Thread Mark Brown
On Fri, Nov 09, 2018 at 08:53:56AM +0100, Anatolij Gustschin wrote: > Add SPI bus controller driver for FTDI MPSSE mode. This driver > is supposed to be used together with the FT232H interface driver > for FPGA configuration in drivers/usb/misc/ft232h-intf.c which > adds an mpsse spi platform

Re: Query on usb/core/devio.c

2018-11-09 Thread Alan Stern
On Fri, 9 Nov 2018, Mayuresh Kulkarni wrote: > > The driver has no way to tell whether the resume was caused by the  > > host or by the device.  (In fact, it's possible for a resume to be  > > caused by _both_ the host and the device, if they request it at the  > > same time.)  In the end, it

Re: [PATCH 1/3] usb: dwc3: Add reference clock properties

2018-11-09 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >> Thinh Nguyen writes: Thinh Nguyen writes: > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt > b/Documentation/devicetree/bindings/usb/dwc3.txt > index 636630fb92d7..712b344c3a31 100644 > ---

Re: [PATCH 3/3] usb: dwc3: Support option to disable USB2 LPM

2018-11-09 Thread Roger Quadros
Hi, On 08/11/18 04:10, Thinh Nguyen wrote: > Support the option to disable USB2 LPM. Set xhci "usb2-lpm-disable" > property via "snps,usb2-lpm-disable" property. > > Signed-off-by: Thinh Nguyen > --- > drivers/usb/dwc3/core.c | 2 ++ > drivers/usb/dwc3/core.h | 2 ++ > drivers/usb/dwc3/host.c

Re: [PATCH] usb: gadget: f_fs: Allow scatter-gather buffers

2018-11-09 Thread kbuild test robot
Hi Andrzej, I love your patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCHv2] usb: gadget: f_fs: Allow scatter-gather buffers

2018-11-09 Thread Andrzej Pietrasiewicz
Some protocols implemented in userspace with FunctionFS might require large buffers, e.g. 64kB or more. Currently the said memory is allocated with kmalloc, which might fail should system memory be highly fragmented. On the other hand, some UDC hardware allows scatter-gather operation and this

Re: Query on usb/core/devio.c

2018-11-09 Thread Mayuresh Kulkarni
On Thu, 2018-11-08 at 10:26 -0500, Alan Stern wrote: > On Thu, 8 Nov 2018, Mayuresh Kulkarni wrote: > > > > > On Wed, 24 Oct 2018 10:10:32 -0400 > > Alan Stern wrote: > > > > > > > > On Wed, 24 Oct 2018, Mayuresh Kulkarni wrote: > > > > > > > > > > > On Mon, 22 Oct 2018 10:24:46 -0400 > > >

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> @@ -140,5 +140,6 @@ obj-$(CONFIG_I2C_SIBYTE) += i2c-sibyte.o > obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > obj-$(CONFIG_I2C_FSI)+= i2c-fsi.o > +obj-$(CONFIG_I2C_NVIDIA_GPU) += i2c-nvidia-gpu.o Oh, I fixed this up

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
On Fri, Oct 26, 2018 at 09:36:58AM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU card has USB Type-C interface. There is a > Type-C controller which can be accessed over I2C. > > This driver adds I2C bus driver to communicate with Type-C controller. > I2C client driver will be part of USB Type-C

Re: [PATCH v15 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

2018-11-09 Thread Wolfram Sang
On Mon, Oct 29, 2018 at 02:42:37PM +0200, Andy Shevchenko wrote: > On Fri, Oct 26, 2018 at 09:36:57AM -0700, Ajay Gupta wrote: > > Hi Heikki and Wolfram, > > > > These two changes add support for USB Type-C interface on latest NVIDIA GPU > > card. > > The Type-C controller used is Cypress CCGx

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > @@ -140,5 +140,6 @@ obj-$(CONFIG_I2C_SIBYTE)+= i2c-sibyte.o > > obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > > obj-$(CONFIG_I2C_FSI) += i2c-fsi.o > > +obj-$(CONFIG_I2C_NVIDIA_GPU) +=

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> > I can't send an incremental patch for this, I need to ask: did you try > > SMBUS_QUICK with it? > Tried it today using i2cdetect and it looks good to me. Yup, looks good. Thanks for checking! signature.asc Description: PGP signature

Re: [PATCH v15 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

2018-11-09 Thread Andy Shevchenko
On Fri, Nov 09, 2018 at 05:45:16PM +0100, Wolfram Sang wrote: > On Mon, Oct 29, 2018 at 02:42:37PM +0200, Andy Shevchenko wrote: > > On Fri, Oct 26, 2018 at 09:36:57AM -0700, Ajay Gupta wrote: > > > Hi Heikki and Wolfram, > > > > > > These two changes add support for USB Type-C interface on

Re: [PATCH v15 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> Hmm... It would be a bit difficult (requires to download patches again as > mbox). > I would rather give you a hint how I resolve such problem when apply a tag to > a > pile of patches. I don't mean now, for future patch series, that is... With this one, all is fine... > git filter-branch

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C > > controller which can be accessed over I2C. > > > > This driver adds I2C bus driver to communicate with Type-C controller. > > I2C client driver will be part of USB Type-C UCSI driver. > > > > Signed-off-by: Ajay

Re: [PATCH v15 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-11-09 Thread Wolfram Sang
On Fri, Oct 26, 2018 at 09:36:59AM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. > > Signed-off-by: Ajay Gupta Applied to

Re: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Wolfram Sang
> It will be good if both of them can go together either through I2C or > USB subsystem. Since USB part is reviewed and has Acked-by Heikki so please > take that also. Hmmm, technicallly, there is no need to let them go together. There is no strict dependency. Yet, since Heikki gave his ack, I

RE: [PATCH v15 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-11-09 Thread Ajay Gupta
Hi Wolfram, > > It will be good if both of them can go together either through I2C or > > USB subsystem. Since USB part is reviewed and has Acked-by Heikki so > > please take that also. > > Hmmm, technicallly, there is no need to let them go together. There is no > strict dependency. Agree. >