Re: [PATCH 2/5] USB: Make it possible to "subclass" usb_device_driver

2019-10-10 Thread Bastien Nocera
More replies inline (which I always miss) On Wed, 2019-10-09 at 10:34 -0400, Alan Stern wrote: > On Wed, 9 Oct 2019, Bastien Nocera wrote: > > > The kernel currenly has only 2 usb_device_drivers, one generic one, > one > > that completely replaces the generic one to make USB devices usable > over

Re: [PATCH 4/5] USB: Select better matching USB drivers when available

2019-10-10 Thread Bastien Nocera
On Wed, 2019-10-09 at 14:45 -0400, Alan Stern wrote: > On Wed, 9 Oct 2019, Bastien Nocera wrote: > > > > + return > device_driver_attach(usb_generic_driver.drvwrap.driver, dev); > > + return error; > > I think that's right. A little testing wouldn't hurt. device_driver_att

Re: [PATCH 2/7] usb: musb: omap2430: Wait on enable to avoid babble

2019-10-10 Thread Sergei Shtylyov
Hello! On 10.10.2019 0:21, Tony Lindgren wrote: We can babble interrupt if we attempt to switch to USB host mode too ^ verb missing? soon after enabling musb. Let's fix the issue by waiting a bit in runtime_resume. Cc: Jacopo Mondi Cc: Marcel Partap Cc: Merlijn Wajer Cc: Michael

Re: [PATCH 2/5] USB: Make it possible to "subclass" usb_device_driver

2019-10-10 Thread kbuild test robot
Hi Bastien, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [cannot apply to v5.4-rc2 next-20191010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] USB: usbfs: Suppress emission of uevents for interfaces handled via usbfs

2019-10-10 Thread Greg KH
On Wed, Oct 09, 2019 at 12:38:35PM +0200, Ingo Rohloff wrote: > >From 17d1e75543e26cfe702e7f5b0d4e07e0e45e5250 Mon Sep 17 00:00:00 2001 > From: Ingo Rohloff > Date: Tue, 8 Oct 2019 20:27:57 +0200 > Subject: [PATCH] USB: usbfs: Suppress emission of uevents for interfaces > handled via usbfs. No n

Re: [PATCH 4/5] USB: Select better matching USB drivers when available

2019-10-10 Thread kbuild test robot
Hi Bastien, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [cannot apply to v5.4-rc2 next-20191010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH 5/5] USB: yurex: fix NULL-derefs on disconnect

2019-10-10 Thread Johan Hovold
On Wed, Oct 09, 2019 at 05:38:48PM +0200, Johan Hovold wrote: > The driver was using its struct usb_interface pointer as an inverted > disconnected flag, but was setting it to NULL without making sure all > code paths that used it were done with it. > > Before commit ef61eb43ada6 ("USB: yurex: Fix

Re: [PATCH 5/5] USB: yurex: fix NULL-derefs on disconnect

2019-10-10 Thread Greg Kroah-Hartman
On Thu, Oct 10, 2019 at 01:05:32PM +0200, Johan Hovold wrote: > On Wed, Oct 09, 2019 at 05:38:48PM +0200, Johan Hovold wrote: > > The driver was using its struct usb_interface pointer as an inverted > > disconnected flag, but was setting it to NULL without making sure all > > code paths that used i

Re: [PATCH] USB: usbfs: Suppress emission of uevents for interfaces handled via usbfs

2019-10-10 Thread Ingo Rohloff
Hello Greg > > + else { > > + /* suppress uevents for devices handled by usbfs */ > > + dev_set_uevent_suppress(&intf->dev, 1); > > err = usb_driver_claim_interface(&usbfs_driver, intf, ps); > > + if (err != 0) > > + dev_set_uevent_su

Apply For Financial investment at a lower rate 2%

2019-10-10 Thread Valentina Yurina
-- Hello, We are private lenders based in UK. Do you need a loan (credit) as soon as possible. Are you in search of money to solve your personal needs or finance your business venture, then get Your desired loan today! Consult us at Sunrise Funding Ltd. * We offer personal loan & huge capital l

Re: [PATCH 4/5] USB: Select better matching USB drivers when available

2019-10-10 Thread Alan Stern
On Thu, 10 Oct 2019, Bastien Nocera wrote: > On Wed, 2019-10-09 at 14:45 -0400, Alan Stern wrote: > > > On Wed, 9 Oct 2019, Bastien Nocera wrote: > > > > > > > + return > > device_driver_attach(usb_generic_driver.drvwrap.driver, dev); > > > + return error; > > > > I think t

[PATCH] usb: usbfs: Suppress problematic bind and unbind uevents.

2019-10-10 Thread Ingo Rohloff
commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound to a driver") added bind and unbind uevents when a driver is bound or unbound to a physical device. For USB devices which are handled via the generic usbfs layer (via libusb for example), this is problematic: Each time a user spa

RE: [PATCH 00/14] usb: typec: UCSI driver overhaul

2019-10-10 Thread Ajay Gupta
Hi Heikki, > > > > Hi Ajay, > > > > > > > > Here's the pretty much complete rewrite of the I/O handling that I > > > > was talking about. The first seven patches are not actually > > > > related to this stuff, but I'm including them here because the > > > > rest of the series is made on top of the

Re: Regression: USB/xhci issues on some systems with newer kernel versions

2019-10-10 Thread Bernhard Gebetsberger
I've just noticed that this problem also occurs when unplugging an affected device. When unplugging the device the error     "WARN Set TR Deq Ptr cmd failed due to incorrect slot or ep state" gets shown, even though I don't get this error when plugging the device in. Here is a link to the dmesg a

Re: [PATCH] usb: usbfs: Suppress problematic bind and unbind uevents.

2019-10-10 Thread Greg KH
On Thu, Oct 10, 2019 at 06:48:00PM +0200, Ingo Rohloff wrote: > commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound > to a driver") added bind and unbind uevents when a driver is bound or > unbound to a physical device. > > For USB devices which are handled via the generic usbfs l

[PATCH 1/3] usb: chipidea: imx: change hsic power regulator as optional

2019-10-10 Thread Peter Chen
Not every platform needs this regulator. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 16700170bc34..25a38ed27aa8 100644 --- a/d

[PATCH 2/3] usb: chipidea: imx: refine the error handling for hsic

2019-10-10 Thread Peter Chen
- -EPROBE_DEFER is an error, but without need show error message - If pintrol is not existed, as pintrol is NULL Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c

[PATCH 3/3] usb: chipidea: imx: pinctrl for HSIC is optional

2019-10-10 Thread Peter Chen
For imx chipidea controllers, if they use mxs PHY, they need pinctrl for HSIC. Otherwise, it doesn't need pinctrl and usbmisc control. Like imx7d and imx8mm. Reported-by: AndréDraszik Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 63 +- 1 file ch

usb: dwc2: Re: Maximum packet size in dwc2 gadget HS mode < 1024

2019-10-10 Thread Minas Harutyunyan
Hi Pavel, On 10/10/2019 8:36 PM, Pavel Hofman wrote: > I forgot version information - branch 5.3 > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_raspberrypi_linux_tree_rpi-2D5.3.y_drivers_usb_dwc2&d=DwICBA&c=DPL6_X_6JkXFx7AXWqB0tg&r=cQBKt4q-qzNVC53rNAwuwplH23V61rHQhhULvdLA0U8&m=