Re: [PATCH] usb: ohci-at91: Suspend the ports while USB suspending

2016-05-11 Thread Alexandre Belloni
device *dev) > ohci_writel(ohci, ohci->hc_control, &ohci->regs->control); > ohci->rh_state = OHCI_RH_HALTED; > > + ohci_at91_port_suspend(ohci_at91->sfr_regmap); > + The main issue I see here is that you will call t

[PATCH resend] Documentation: configfs-usb-gadget-uvc: fix kernel version

2016-05-22 Thread Alexandre Belloni
v3.20 doesn't exist, it is actually v4.0. Signed-off-by: Alexandre Belloni --- Resend using correct address for Felipe Documentation/ABI/testing/configfs-usb-gadget-uvc | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/Documentation/ABI/te

Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node

2016-06-08 Thread Alexandre Belloni
nning depending on the SFR that we can lookup. My concern was only to avoid calling a function unnecessarily on !sama5d2 platforms. > > > reg = <0x0040 0x10>; > > interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>; > > clocks = <

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-08 Thread Alexandre Belloni
1rm9200-ohci" for USB controllers > > - used in host mode. > > + - compatible: Should be one of the following > > + "atmel,at91rm9200-ohci" for USB controllers used in host mode. > > + "atmel,sama5d2-ohci" for USB controllers used i

[PATCH] usb: gadget: udc: atmel: Also get regmap for at91sam9x5-pmc

2016-06-13 Thread Alexandre Belloni
The "atmel,at91sam9g45-udc" compatible UDC is also used on at91sam9x5 so it is also necessary to try to get the syscon for at91sam9x5-pmc. Fixes: 4747639f01c9 ("usb: gadget: atmel: access the PMC using regmap") Reported-by: Uwe Kleine-König Signed-off-by: Alexandre Bello

Re: [PATCH] usb: gadget: udc: atmel: Also get regmap for at91sam9x5-pmc

2016-06-13 Thread Alexandre Belloni
On 13/06/2016 at 10:56:08 +0200, Uwe Kleine-König wrote : > Hello, > > On Mon, Jun 13, 2016 at 10:47:30AM +0200, Alexandre Belloni wrote: > > The "atmel,at91sam9g45-udc" compatible UDC is also used on at91sam9x5 so it > > is also necessary to try to ge

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-17 Thread Alexandre Belloni
On 17/06/2016 at 13:44:22 +, Yang, Wenyou wrote : > Hi Alexandre, > > > -Original Message- > > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > > Sent: 2016年6月9日 4:38 > > To: Rob Herring > > Cc: Yang, Wenyou ; Alan Stern

Re: [PATCH] usb: ohci-at91: make at91_dt_syscon_sfr static

2016-06-17 Thread Alexandre Belloni
it be static? > > Signed-off-by: Ben Dooks Acked-by: Alexandre Belloni > --- > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Jean-Christophe Plagniol-Villard > --- > drivers/usb/ho

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Alexandre Belloni
u will try to get "atmel,sama5d2-sfr". It is only present on sama5d2 so you have enough information to know whether or not you can use it to suspend/resume. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe f

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-20 Thread Alexandre Belloni
On 20/06/2016 at 08:46:02 +, Yang, Wenyou wrote : > Hi Alexandre & Nicolas, > > > -Original Message- > > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > > Sent: 2016年6月20日 16:04 > > To: Yang, Wenyou > > Cc: Rob Herri

Re: [PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-21 Thread Alexandre Belloni
on must be done before the USB clock is disabled, > resume after the USB clock is enabled. > > Signed-off-by: Wenyou Yang Reviewed-by: Alexandre Belloni -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from

Re: [PATCH] usb: ohci-at91: make at91_dt_syscon_sfr static

2016-06-27 Thread Alexandre Belloni
1.c file. > >> > >> drivers/usb/host/ohci-at91.c:144:15: warning: symbol 'at91_dt_syscon_sfr' > >> was not declared. Should it be static? > >> > >> Signed-off-by: Ben Dooks > >> Acked-by: Nicolas Ferre > >> Acked-

[PATCH] usb: gadget: udc: atmel: used managed kasprintf

2016-12-01 Thread Alexandre Belloni
Use devm_kasprintf instead of simple kasprintf to free the allocated memory when needed. Suggested-by: Peter Rosin Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

2016-12-02 Thread Alexandre Belloni
On 02/12/2016 at 15:59:57 +, David Laight wrote : > From: Alexandre Belloni > > Sent: 01 December 2016 10:27 > > Use devm_kasprintf instead of simple kasprintf to free the allocated memory > > when needed. > > s/when needed/when the device is freed/ >

[PATCH] usb: gadget: udc: atmel: remove memory leak

2017-01-11 Thread Alexandre Belloni
Commit bbe097f092b0 ("usb: gadget: udc: atmel: fix endpoint name") introduced a memory leak when unbinding the driver. The endpoint names would not be freed. Solve that by including the name as a string in struct usba_ep so it is freed when the endpoint is. Signed-off-by: Alexand

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

2017-01-16 Thread Alexandre Belloni
On 16/01/2017 at 12:27:04 +0200, Felipe Balbi wrote : > > Hi, > > David Laight writes: > > From: Alexandre Belloni > >> Sent: 02 December 2016 16:19 > >> On 02/12/2016 at 15:59:57 +, David Laight wrote : > >> > From: Alexandre Belloni &g

[PATCH] usb: gadget: udc: atmel: fix endpoint name

2016-09-15 Thread Alexandre Belloni
ntry) from [] (start_kernel+0x354/0x360) [] (start_kernel) from [<20008078>] (0x20008078) ---[ end trace e7cf9dcebf4815a6 ]--- Fixes: c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes") Reported-by: Richard Genoud Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/

Re: [PATCH] dt-bindings: usb: atmel: fix a couple of copy-paste style typos

2016-10-20 Thread Alexandre Belloni
t; --- > > Documentation/devicetree/bindings/usb/atmel-usb.txt | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from t

Re: [PATCH] usb: gadget: udc: atmel: fix endpoint name

2016-10-24 Thread Alexandre Belloni
7;t see USB-fixes included... > It is in Greg's branch: http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/log/?h=usb-linus -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "

Re: [PATCH] usb: gadget: udc: atmel: fix debug output

2017-02-01 Thread Alexandre Belloni
: udc: atmel: Update endpoint allocation > scheme") > Signed-off-by: Arnd Bergmann Acked-by: Alexandre Belloni > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usb

Re: [PATCH] Revert "ARM: at91/dt: sama5d2: Use new compatible for ohci node"

2017-02-17 Thread Alexandre Belloni
uot;; > reg = <0x0040 0x100000>; > interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>; > clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>; > -- > 2.9.3 > -- Alexandre Belloni, Free

Re: [PATCH] usb: ohci-at91: Do not drop unhandled USB suspend control requests

2017-02-21 Thread Alexandre Belloni
goes into > sleep and will not wakeup when an USB devices is inserted. > > Fixes: 2e2aa1bc7eff90ec ("usb: ohci-at91: Forcibly suspend ports while USB > suspend") > Signed-off-by: Jelle Martijn Kok > Tested-by: Wenyou Yang Reviewed-by: Alexandre Belloni > Cc: Wenyou Y

Re: [PATCH] Revert "ARM: at91/dt: sama5d2: Use new compatible for ohci node"

2017-03-05 Thread Alexandre Belloni
tly in an official release, removing it should not be > breaking the stability rules. > > Fixes: cab43282682e ("ARM: at91/dt: sama5d2: Use new compatible for ohci > node") > Signed-off-by: Romain Izard > cc: > --- > arch/arm/boot/dts/sama5d2.dtsi | 2 +- > 1

Re: [PATCH v2 0/5] usb: atmel_usba_udc: Rework errata handling

2015-01-07 Thread Alexandre Belloni
Hi, The whole series looks good to me, you can add my Acked-by: Alexandre Belloni On 06/01/2015 at 14:46:57 +0100, Boris Brezillon wrote : > Hello, > > Here is a set of patches porting existing at91sam9rl erratum handling to > DT and adding new code to handle at91sam9g45/9x5 e

Re: [PATCH 05/11] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-12 Thread Alexandre Belloni
eded at 1958 (offset 13 lines). > Hunk #4 FAILED at 1960. > 1 out of 4 hunks FAILED > > please rebase on testing/next which I just pushed. > > -- > balbi -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To uns

Re: [PATCH 05/11] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-13 Thread Alexandre Belloni
ut. I would prefer not to miss 3.20, can I resend the patches now so you can review and ack them? Then they could go through the mfd tree. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the l

[PATCH 12/12] usb: gadget: at91_udc: Allocate udc instance

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon Allocate udc structure instead of relying on the statically declared object. Signed-off-by: Boris Brezillon --- drivers/usb/gadget/udc/at91_udc.c | 96 +++ 1 file changed, 26 insertions(+), 70 deletions(-) diff --git a/drivers/usb/gadg

[PATCH 11/12] usb: gadget: at91_udc: Update DT binding documentation

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon Three compatible strings have been added to the at91_udc driver. Update the documentation accordingly. Signed-off-by: Boris Brezillon --- Documentation/devicetree/bindings/usb/atmel-usb.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documenta

[PATCH 10/12] usb: gadget: at91_udc: Rework for multi-platform kernel support

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon cpu_is_at91xxx are a set of macros defined in mach/cpu.h and are here used to detect the SoC we are booting on. Use compatible string + a caps structure to replace those cpu_is_xxx tests. Remove all mach and asm headers (which are now unused). Signed-off-by: Boris Brezillo

[PATCH 09/12] usb: gadget: at91_udc: Simplify probe and remove functions

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon Make use of devm_ functions to simplify probe and remove code. Signed-off-by: Boris Brezillon --- drivers/usb/gadget/udc/at91_udc.c | 116 +- 1 file changed, 39 insertions(+), 77 deletions(-) diff --git a/drivers/usb/gadget/udc/at91_ud

[PATCH 08/12] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon Since non-DT board support has been removed from the at91 architecture we can safely remove non-DT handling code. Signed-off-by: Boris Brezillon --- drivers/usb/gadget/udc/Kconfig| 1 + drivers/usb/gadget/udc/at91_udc.c | 16 ++-- 2 files changed, 3 inser

[PATCH 02/12] mfd: syscon: Add Atmel Matrix bus DT binding documentation

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon The Matrix registers are provided to configure internal bus behavior on at91 SoCs. Some registers might be accessed by several drivers (e.g. to configure external memory bus timings), hence we declare this register set as a syscon device. Signed-off-by: Boris Brezillon Ack

[PATCH 06/12] usb: gadget: at91_udc: Drop uclk clock

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon Now that at91 system clocks forward set_rate request to their parent we can remove the uclk clock and directly call clk_set_rate on fclk. Signed-off-by: Boris Brezillon --- drivers/usb/gadget/udc/at91_udc.c | 27 +++ drivers/usb/gadget/udc/at91_udc

[PATCH 07/12] usb: gadget: at91_udc: Document DT clocks and clock-names property

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon The at91_udc driver request 2 clocks, and thus need them to be defined in the device tree. Document the clocks and clock-names properties so that everybody use the correct names. Signed-off-by: Boris Brezillon --- Documentation/devicetree/bindings/usb/atmel-usb.txt | 4 ++

[PATCH 00/12] Atmel matrix, SMC and UDC rework

2015-01-14 Thread Alexandre Belloni
Hi Felipe, The following series replace the previous series sent by Boris named: - [PATCH v5 00/11] memory: add Atmel EBI (External Bus Interface) driver - [PATCH 00/11] usb: gadget: at91_udc: Rework for multi-platform support The patches I left out are less urgent and will be resent later, pro

[PATCH 05/12] usb: gadget: at91_udc: Fix clock names

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon The driver is requesting clock by their global name (those declared in the clk_lookup list), but this only works with !CCF kernels. Now that all SoCs have moved to CCF, fix the driver to use local names (hclk and pclk). Signed-off-by: Boris Brezillon --- drivers/usb/gadg

[PATCH 01/12] mfd: syscon: Add atmel-matrix registers definition

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon AT91 SoCs have a memory range reserved for internal bus configuration. Expose those registers so that drivers can make use of the matrix syscon declared in at91 DTs. Signed-off-by: Boris Brezillon Acked-by: Lee Jones --- include/linux/mfd/syscon/atmel-matrix.h | 117

[PATCH 04/12] mfd: syscon: Add Atmel SMC binding doc

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon The SMC registers are used to configure Atmel EBI (External Bus Interface) to interface with standard memory devices (NAND, NOR, SRAM or specialized devices like FPGAs). Declare this memory region as a syscon, so that different drivers can configure the SMC interface (mostl

[PATCH 03/12] mfd: syscon: Add atmel-smc registers definition

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon Atmel AT91 SoCs have a memory range reserved for SMC (Static Memory Controller) configuration. Expose those registers so that drivers can make use of the smc syscon declared in at91 DTs. Signed-off-by: Boris Brezillon Acked-by: Lee Jones --- include/linux/mfd/syscon/atme

Re: [PATCH 08/12] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-14 Thread Alexandre Belloni
On 14/01/2015 at 11:38:12 -0600, Felipe Balbi wrote : > On Wed, Jan 14, 2015 at 05:22:00PM +0100, Alexandre Belloni wrote: > > From: Boris Brezillon > > > > Since non-DT board support has been removed from the at91 architecture we > > can safely remove non-DT handlin

[PATCH] usb: gadget: atmel_usba: fix crash when no endpoint are specified

2014-02-27 Thread Alexandre Belloni
/0x24) Code: e5950014 e1a04001 e5902008 e3a010d0 (e5922008) ---[ end trace 35c74bdd89b373d0 ]--- Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b This checks for that case and returns an error, not allowing the driver to be loaded with no endpoints. Signed-off-by: Alexandre

Re: [PATCH] usb: gadget: atmel_usba: Fix crashed during stopping when DEBUG is enabled

2014-02-28 Thread Alexandre Belloni
egistered driver `%s'\n", driver->driver.name); > + DBG(DBG_GADGET, "unregistered driver `%s'\n", udc->driver->driver.name); > + > + udc->driver = NULL; Shouldn't we get rid of that assignment as it is done in usb_gadget_remove

Re: [PATCH] usb: gadget: atmel_usba: fix crash when no endpoint are specified

2014-03-03 Thread Alexandre Belloni
Hi Felipe, On 28/02/2014 at 15:35:42 +0100, Nicolas Ferre wrote : > On 27/02/2014 16:42, Alexandre Belloni : > > If no endpoints are present in the device tree, the kernel will cras hwith > > the > > s/cras hwith/crash with/ > Do you want me to send a v2 with that typ

Re: [PATCH v2] usb: gadget: atmel_usba: Fix crashed during stopping when DEBUG is enabled

2014-03-03 Thread Alexandre Belloni
kported to the same > kernel. > > Fixes: 511f3c5326ea (usb: gadget: udc-core: fix a regression during gadget > driver unbinding) > Cc: sta...@vger.kernel.org # v3.2+ > Signed-off-by: Gregory CLEMENT Acked-by: Alexandre Belloni > --- > Changelog: > v1 -> v2

[PATCH] usb: gadget: atmel_usba: always test udc->driver

2014-05-06 Thread Alexandre Belloni
Found using smatch: drivers/usb/gadget/atmel_usba_udc.c:1689 usba_udc_irq() error: we previously assumed 'udc->driver' could be null (see line 1636) Always test udc->driver before using its members. Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/atmel_usba_udc.c | 2 +-

Re: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver

2014-06-09 Thread Alexandre Belloni
ould move to the controller stub instead. > We should use a regulator and in the case it is hardwired, use a fixed regulator. Then, we can stop if it is missing. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe

[PATCH 1/4] USB: host: ohci-at91: move at91_usbh_data definition in c file

2015-08-10 Thread Alexandre Belloni
Move struct at91_usbh_data back in ohci-at91.c as this is the only user left after switching all at91 platforms to DT only. Signed-off-by: Alexandre Belloni --- drivers/usb/host/ohci-at91.c| 11 +++ include/linux/platform_data/atmel.h | 12 2 files changed, 11

[PATCH 0/4] USB: host: ohci-at91: cleanups

2015-08-10 Thread Alexandre Belloni
Hi, Here are a few cleanups for ohci-at91. This is the fallout of AT91 now being DT only. Alexandre Belloni (4): USB: host: ohci-at91: move at91_usbh_data definition in c file USB: host: ohci-at91: depend on OF USB: host: ohci-at91: merge ohci_at91_of_init in ohci_hcd_at91_drv_probe

[PATCH 3/4] USB: host: ohci-at91: merge ohci_at91_of_init in ohci_hcd_at91_drv_probe

2015-08-10 Thread Alexandre Belloni
As device tree support is now mandatory, merge ohci_at91_of_init() in ohci_hcd_at91_drv_probe(). Signed-off-by: Alexandre Belloni --- drivers/usb/host/ohci-at91.c | 145 +++ 1 file changed, 63 insertions(+), 82 deletions(-) diff --git a/drivers/usb/host

[PATCH 4/4] USB: host: ohci-at91: merge loops in ohci_hcd_at91_drv_probe

2015-08-10 Thread Alexandre Belloni
ohci_hcd_at91_drv_probe() has four at91_for_each_port. They can be merged into two loops without changing the driver behaviour. Signed-off-by: Alexandre Belloni --- drivers/usb/host/ohci-at91.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff

[PATCH 2/4] USB: host: ohci-at91: depend on OF

2015-08-10 Thread Alexandre Belloni
Make the driver depend on CONFIG_OF and remove the now useless #ifdef Also, fix the Kconfig indentation. Signed-off-by: Alexandre Belloni --- drivers/usb/host/Kconfig | 8 drivers/usb/host/ohci-at91.c | 9 + 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a

[PATCH] usb: gadget: atmel: remove useless include

2015-08-10 Thread Alexandre Belloni
Definitions from linux/platform_data/atmel.h are not used, remove the include. Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index

[PATCH] usb: gadget: at91_udc: move at91_udc_data in at91_udc.h

2015-08-10 Thread Alexandre Belloni
struct at91_udc_data is now only used inside the driver, move it to its include. Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/at91_udc.h | 8 include/linux/platform_data/atmel.h | 9 - 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/usb

[PATCH] USB: OHCI: ohci-at91: remove unnecessary headers

2014-10-16 Thread Alexandre Belloni
Remove unnecessary mach/* headers to be able to converge to a multiplatform kernel. Signed-off-by: Alexandre Belloni --- drivers/usb/host/ohci-at91.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index e49eb4f90f5d

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-07-01 Thread Alexandre Belloni
arry '2.0' or 'usb2' in it. Or we just > > use some version number like 'chipidea,ci13000' or 'chipidea,ci13xxx'. > > > > The recommended format for compatible string is: "manufacturer,model", > I agree with "chipidea,ci13xxx

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

2014-08-07 Thread Alexandre Belloni
_unprepare(udc->fclk); > >+fail1a: > >+if (IS_ENABLED(CONFIG_COMMON_CLK)) > >+clk_unprepare(udc->uclk); > > fail1: > > if (IS_ENABLED(CONFIG_COMMON_CLK) && !IS_ERR(udc->uclk)) > > clk_put(udc->uclk); &g

Re: [PATCH v4] usb: gadget: at91_udc: move prepare clk into process context

2014-08-08 Thread Alexandre Belloni
safe to call from there for the same reason. Move clock > preparation and setting clock rate into process context (at91udc_probe). > > Signed-off-by: Ronald Wahl Acked-by: Alexandre Belloni > --- > v3 -> v4: > - no code changes > - update commit message >

Re: MUSB dual-role on AM335x behaving weirdly

2015-05-27 Thread Alexandre Belloni
Hi, On 26/05/2015 at 09:51:18 -0500, Felipe Balbi wrote : > On Thu, May 14, 2015 at 04:36:33PM -0500, Bin Liu wrote: > > Alexandre, > > > > On Thu, May 14, 2015 at 4:26 PM, Alexandre Belloni > > wrote: > > > On 14/05/2015 at 16:16:12 -0500, Bin Liu wrote : &

Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init

2015-06-18 Thread Alexandre Belloni
function, > syscon_regmap_lookup_by_phandle by checking with a call to the function, > IS_ERR and returning a error pointer if there is one for the function, > at91sam9261_udc_init. Furthermore this was found by running coccinelle > against the lastest kernel tree. > > Signed-off-by: Nicholas Krause

Re: [PATCH] usb:gadget:Simplify the error checking of the function,at91sam9261_udc_init

2015-06-18 Thread Alexandre Belloni
On 18/06/2015 at 18:41:14 +0200, Alexandre Belloni wrote : > On 03/05/2015 at 23:25:02 -0400, Nicholas Krause wrote : > > This simplifies the error checking of the function,at91sam9261_udc_init > > by using PTR_ERR_OR_ZERO in the return statement rather then a unnessary > >

[PATCH 00/16] ARM: at91: PMC driver rework

2015-09-30 Thread Alexandre Belloni
@vger.kernel.org Alexandre Belloni (13): clk: at91: utmi: use pmc_read when the at91_pmc is available clk: at91: system: don't try to free_irq when there is no IRQ ARM: at91/dt: use syscon for PMC clk: at91: clk-main: factorize irq handling clk: at91: make IRQ optional and register them

[PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

2015-09-30 Thread Alexandre Belloni
Use regmap to access the PMC to avoid using at91_pmc_read and at91_pmc_write. Signed-off-by: Alexandre Belloni --- Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org drivers/usb/gadget/udc/atmel_usba_udc.c | 20 ++-- drivers/usb/gadget/udc/atmel_usba_udc.h | 2 ++ 2 files changed

Re: [PATCH 00/16] ARM: at91: PMC driver rework

2015-09-30 Thread Alexandre Belloni
Stephen, all, Please disregard 01/16 and 02/16 as they are already in clk-next. On 30/09/2015 at 18:10:53 +0200, Alexandre Belloni wrote : > Hi, > > This patch set is a cleanup that properly separate drivers needing to access > the > PMC (PM and USB) from the clock driver by e

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

2015-09-30 Thread Alexandre Belloni
Hi, On 30/09/2015 at 11:31:02 -0500, Felipe Balbi wrote : > On Wed, Sep 30, 2015 at 06:11:08PM +0200, Alexandre Belloni wrote: > > Use regmap to access the PMC to avoid using at91_pmc_read and > > at91_pmc_write. > > > > Signed-off-by: Alexandre Belloni > > c

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

2015-09-30 Thread Alexandre Belloni
On 30/09/2015 at 18:59:17 +0200, Alexandre Belloni wrote : > Hi, > > On 30/09/2015 at 11:31:02 -0500, Felipe Balbi wrote : > > On Wed, Sep 30, 2015 at 06:11:08PM +0200, Alexandre Belloni wrote: > > > Use regmap to access the PMC to avoid using at91_pmc_read

Re: Regression, was [PATCH 4/4] USB: host: ohci-at91: merge loops in ohci_hcd_at91_drv_probe

2015-12-02 Thread Alexandre Belloni
. Can you try the following patch? 8<-- >From 402f8444bc92d218edc63dcc3c87459981a56c31 Mon Sep 17 00:00:00 2001 From: Alexandre Belloni Date: Wed, 2 Dec 2015 18:49:34 +0100 Subject: [PATCH] USB: host: ohci-at91: fix a crash in ohci_hcd_at91_overcurrent_irq Signed-off-by: Alexandre Bello

[PATCH] USB: host: ohci-at91: fix a crash in ohci_hcd_at91_overcurrent_irq

2015-12-02 Thread Alexandre Belloni
sin Tested-by: Peter Rosin Signed-off-by: Alexandre Belloni --- drivers/usb/host/ohci-at91.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 342ffd140122..8c6e15bd6ff0 100644 --- a/drivers/usb/host/o

Re: [PATCHv2 2/2] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes

2015-01-18 Thread Alexandre Belloni
save induced by this > PLL deactivation. The resume penalty is about 500 us, which is not > negligible but acceptable considering the amount of power we are saving. > > Signed-off-by: Sylvain Rochet > Reported-by: Boris Brezillon Acked-by: Alexandre Belloni > --- >

Re: [PATCH 1/3] USB: gadget: at91_udc: add at91sam9n12 support

2015-02-09 Thread Alexandre Belloni
udc->ep[0].maxpacket = 64; > udc->ep[3].maxpacket = 64; > udc->ep[4].maxpacket = 512; > -- > 2.3.0.rc0 > > > _______ > linux-arm-kernel mailing list > linux-arm-ker...@lists

[PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-02 Thread Alexandre Belloni
Since the addition of the errata handling for at91sam9rl and at91sam9g45, the atmel_usba_udc depends on the pmc driver being present. Explicitly set that dependency. Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-03 Thread Alexandre Belloni
to make it clearer ? > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91) > > And I wonder why you need that. I though this option was selected by all > at91 platforms ? > That is currently the case but maybe, one day, one of the AT91 platform will not use th

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-10 Thread Alexandre Belloni
On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote : > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > > config USB_ATMEL_USBA > > > > tristate "Atmel USBA" &g

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-12 Thread Alexandre Belloni
d it by simply having all the AT91 platform selecting COMMON_CLK_AT91. I just have the feeling that this is not quite future proof. So this is not urgent at all and I'll try to remember to resend when needed. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering

Re: [PATCH v3 1/7] drivers: Introduce device lookup variants by name

2019-07-25 Thread Alexandre Belloni
xander Aring > Cc: Alexander Shishkin > Cc: Alexandre Belloni > Cc: Arnd Bergmann > Cc: Dan Murphy > Cc: Greg Kroah-Hartman > Cc: Harald Freudenberger > Cc: Heikki Krogerus > Cc: Heiko Carstens > Cc: Jacek Anaszewski > Cc: Lee Jones > Cc: linux-l...@v

Re: [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through

2019-08-12 Thread Alexandre Belloni
> fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Gustavo A. R. Silva Acked-by: Alexandre Belloni > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c > b/drive

Re: [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

2018-03-19 Thread Alexandre Belloni
| 2 +- > drivers/net/ethernet/smsc/Kconfig| 6 +++--- > drivers/net/wireless/cisco/Kconfig | 2 +- > drivers/pwm/Kconfig | 2 +- > drivers/rtc/Kconfig | 2 +- Acked-by: Alexandre Belloni > drivers/spi/Kconfig | 4 ++-- > d

Re: [PATCH v2 1/2] clk: at91: Added more information logging.

2018-04-10 Thread Alexandre Belloni
p_clock(ohci_at91, &pdev->dev); > } > > > @@ -623,7 +627,7 @@ ohci_hcd_at91_drv_suspend(struct device *dev) > > /* flush the writes */ > (void) ohci_readl (ohci, &ohci->regs->control); > - at91_stop_clock(ohci_at9

Re: [PATCH 17/22] USB: udc: atmel_usba_udc: no need to check return value of debugfs_create functions

2018-05-30 Thread Alexandre Belloni
o keep the file dentries around at all, so remove > those variables from the device structure. > > Cc: Nicolas Ferre > Cc: Felipe Balbi > Cc: Alexandre Belloni > Signed-off-by: Greg Kroah-Hartman > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 71

Re: [PATCH 17/22] USB: udc: atmel_usba_udc: no need to check return value of debugfs_create functions

2018-05-30 Thread Alexandre Belloni
e file dentries around at all, so remove > those variables from the device structure. > > Cc: Nicolas Ferre > Cc: Felipe Balbi > Cc: Alexandre Belloni > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Alexandre Belloni > --- > drivers/usb/gadget/udc/atmel_usba_udc.c |

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-05-22 Thread Alexandre Belloni
On 22/05/2017 at 00:02:10 +0200, Wolfram Sang wrote: > include/linux/i2c is not for client devices. Move the header file to a > more appropriate location. > > Signed-off-by: Wolfram Sang Acked-by: Alexandre Belloni > --- > arch/arm/mach-omap2/common.h| 2 +- >

[PATCH] usb: gadget: udc: atmel: Remove unnecessary macros

2017-06-16 Thread Alexandre Belloni
commit 46ddd79e893b ("usb: gadget: udc: atmel: Remove AVR32 bits from the driver") left the accessor macros introduced by commit a3dd3befd7cb ("usb: gadget: atmel_usba: use endian agnostic IO on ARM"). They can now be removed. Signed-off-by: Alexandre Belloni --- dr

Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks

2017-09-13 Thread Alexandre Belloni
rs of PCK (only 2 on at91sam9x5 for > instance)... > My opinion is that it will be time to change that when multiple SoCs will need to save their registers. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this li

Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode

2017-09-20 Thread Alexandre Belloni
ided a > very long list of both developpers and mailing lists (28). I thought it > was a good idea to shorten it a little. Bad idea. Sorry. > I think the correct way of handling that would have been to send each patch to the proper subsystem as there are no dependency here. -- Alexa

Re: [PATCH v4 0/8] Various patches for SAMA5D2 backup mode

2017-09-28 Thread Alexandre Belloni
63 ++- > drivers/tty/serial/atmel_serial.c| 13 +++ > drivers/usb/host/ehci-atmel.c| 3 +- > 10 files changed, 196 insertions(+), 36 deletions(-) > > -- > 2.11.0 > -- Alexandre Belloni, Free Electrons Embedded

[PATCH] usb: gadget: udc: atmel: handle at91sam9rl PMC

2018-09-10 Thread Alexandre Belloni
The at91sam9rl PMC is not quite the same as the at91sam9g45 one and now has its own compatible string. Add support for that. Fixes: 217bace8e548 ("ARM: dts: fix PMC compatible") Signed-off-by: Alexandre Belloni --- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++ 1 file changed, 2

[PATCH RESEND] usb: gadget: udc: atmel: handle at91sam9rl PMC

2018-10-15 Thread Alexandre Belloni
The at91sam9rl PMC is not quite the same as the at91sam9g45 one and now has its own compatible string. Add support for that. Fixes: 217bace8e548 ("ARM: dts: fix PMC compatible") Signed-off-by: Alexandre Belloni Acked-by: Cristian Birsan --- Hello Greg, This is an urgent fix that w