Ejected Nook (usb mass storage) prevents suspend

This is kernel 3.9.9-302.fc19.x86_64. I plugged in a BN Nook (a usb mass storage device), used it, and ejected it. This makes suspend fail: [50135.265514] PM: Entering freeze sleep [50135.265517] Suspending console(s) (use no_console_suspend to debug) [50135.287724] sd 7:0:0:0: [sdb]

Re: Ejected Nook (usb mass storage) prevents suspend

a misleading line in the kernel log. If you prefer, just get rid of the log message. Or make it KERN_DEBUG instead of KERN_NOTICE, along with the Stopping disk message. Those two things might get pretty annoying when people start using block-layer runtime PM. Alan Stern -- Andy

ehci-pci D3cold logspam

I've been getting this on several recent kernel revisions. Is it interesting? If so, I'm happy to help diagnose it. If not, can the message be killed or severely ratelimited? I'm getting so much of this that it tends to overflow the log ring. [ 287.344991] ehci-pci :00:1d.0: power state

Multiple usb_storage problems

I have a Corsair Flash Voyager GT and a Lenovo x220 running Fedora's 3.8.2 kernel. It doesn't work very well, and the problems vary depending on whether I'm using usb2 or usb3. - On usb3, the device node can't be opened with O_DIRECT (using, for example, dd oflag=direct). It returns -EINVAL.

Re: Multiple usb_storage problems

On Sat, Mar 30, 2013 at 8:21 PM, Andy Lutomirski l...@amacapital.net wrote: I have a Corsair Flash Voyager GT and a Lenovo x220 running Fedora's 3.8.2 kernel. It doesn't work very well, and the problems vary depending on whether I'm using usb2 or usb3. - On usb3, the device node can't

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Fri, Jun 17, 2016 at 11:46 AM, <mario_limoncie...@dell.com> wrote: >> -Original Message----- >> From: Andy Lutomirski [mailto:l...@amacapital.net] >> Sent: Thursday, June 16, 2016 1:41 PM >> To: Limonciello, Mario <mario_limoncie...@dell.co

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Wed, Jun 22, 2016 at 4:35 PM, D. Jared Dominguez <jared_doming...@dell.com> wrote: > On Wed, Jun 22, 2016 at 04:21:58PM -0700, Andy Lutomirski wrote: >> >> On Wed, Jun 22, 2016 at 3:29 PM, <mario_limoncie...@dell.com> wrote: >>>> >>>> >

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Wed, Jun 22, 2016 at 3:29 PM, wrote: >> > >> > I've only got WD15 and TB15's. >> >> Do you have a link to the product page for these? I'll probably buy >> one in the next couple of weeks, but I can only find the WD15, not the >> TB15. From the FAQ >>

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Wed, Jun 22, 2016 at 3:06 PM, <mario_limoncie...@dell.com> wrote: >> -Original Message----- >> From: Andy Lutomirski [mailto:l...@amacapital.net] >> Sent: Wednesday, June 22, 2016 3:44 PM >> To: Limonciello, Mario <mario_limoncie...@dell.com> >&g

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Fri, Jun 17, 2016 at 12:25 PM, Andy Lutomirski <l...@amacapital.net> wrote: > On Fri, Jun 17, 2016 at 11:46 AM, <mario_limoncie...@dell.com> wrote: >>> -Original Message- >>> From: Andy Lutomirski [mailto:l...@amacapital.net] >>

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Sun, Mar 13, 2016 at 7:29 PM, Mario Limonciello <mario_limoncie...@dell.com> wrote: > > > On 03/12/2016 02:33 PM, Andy Lutomirski wrote: >> On Sat, Mar 12, 2016 at 11:35 AM, Andy Lutomirski <l...@amacapital.net> >> wrote: >> Got it. I was barking u

Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

I get some warnings at boot on all kernels I've tried. On 4.5-rc4, I see: [0.229429] usbcore: registered new interface driver usbfs [0.229436] usbcore: registered new interface driver hub [0.229451] usbcore: registered new device driver usb [1.057998] xhci_hcd :00:14.0: xHCI

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Tue, Feb 16, 2016 at 6:33 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Feb 16, 2016 at 10:01:13AM -0800, Andy Lutomirski wrote: >> I get some warnings at boot on all kernels I've tried. On 4.5-rc4, I see: >> >> [0.229429] usbcore: regi

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Sun, Mar 13, 2016 at 7:29 PM, Mario Limonciello <mario_limoncie...@dell.com> wrote: > > > On 03/12/2016 02:33 PM, Andy Lutomirski wrote: >> On Sat, Mar 12, 2016 at 11:35 AM, Andy Lutomirski <l...@amacapital.net> >> wrote: >> Got it. I was barking u

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Wed, Mar 9, 2016 at 5:34 PM, Mario Limonciello <mario_limoncie...@dell.com> wrote: > > > On 03/07/2016 02:42 PM, Andy Lutomirski wrote: >> On Mon, Mar 7, 2016 at 12:13 PM, Greg Kroah-Hartman >> <gre...@linuxfoundation.org> wrote: >> I'm adding a co

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Sat, Mar 12, 2016 at 11:35 AM, Andy Lutomirski <l...@amacapital.net> wrote: > On Wed, Mar 9, 2016 at 5:34 PM, Mario Limonciello > <mario_limoncie...@dell.com> wrote: >> >> >> On 03/07/2016 02:42 PM, Andy Lutomirski wrote: >>> On Mon, Mar 7,

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Tue, Mar 8, 2016 at 10:14 AM, Mathias Nyman <mathias.ny...@intel.com> wrote: > On 07.03.2016 22:13, Greg Kroah-Hartman wrote: >> >> On Mon, Mar 07, 2016 at 11:09:36AM -0800, Andy Lutomirski wrote: >>> >>> Quick ping here: this is still busted on 4.5-rc6.

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

On Mon, Mar 7, 2016 at 9:30 AM, Steven Rostedt wrote: > On Mon, 7 Mar 2016 18:24:12 +0100 (CET) > Jiri Kosina wrote: > >> > So, if Clang is producing wrong X86 code here, is it possible to turn >> > interrupts on/off manually? But, hmm that affects other

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

Quick ping here: this is still busted on 4.5-rc6. On Wed, Feb 17, 2016 at 9:40 AM, Andy Lutomirski <l...@kernel.org> wrote: > On Wed, Feb 17, 2016 at 8:18 AM, Mathias Nyman > <mathias.ny...@linux.intel.com> wrote: >> On 17.02.2016 07:19, Andy Lutomirski wrote: >>>

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

On Mon, Mar 7, 2016 at 12:13 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Mon, Mar 07, 2016 at 11:09:36AM -0800, Andy Lutomirski wrote: >> Quick ping here: this is still busted on 4.5-rc6. >> >> On Wed, Feb 17, 2016 at 9:40 AM, Andy Lutomir

wusbcore crypto stack sg

Hi Herbert, etc- drivers/usb/wusbcore/crypto.c is another sg-pointing-to-the-stack user. Want to fix it? (Does wusb hardware even exist in the wild?) --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-usb" i

[PATCH] wusb: Stop using the stack for sg crypto scratch space

Pointing an sg list at the stack is verboten and, with CONFIG_VMAP_STACK=y, will malfunction. Use kmalloc for the wusb crypto stack space instead. Untested -- I'm not entirely convinced that this hardware exists in the wild. Signed-off-by: Andy Lutomirski <l...@kernel.org> --- This is

Re: [PATCH] wusb: Stop using the stack for sg crypto scratch space

On Thu, Oct 6, 2016 at 10:25 AM, Andy Lutomirski <l...@kernel.org> wrote: > Pointing an sg list at the stack is verboten and, with > CONFIG_VMAP_STACK=y, will malfunction. Use kmalloc for the wusb > crypto stack space instead. > > Untested -- I'm not entirely convinced that

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

On Mon, Dec 12, 2016 at 2:28 PM, David Howells <dhowe...@redhat.com> wrote: > Andy Lutomirski <l...@kernel.org> wrote: > >> +static const char zero_pad[16] = {0}; > > Isn't there a global page of zeros or something that we can share? Also, you > shouldn't explicit

Re: [PATCH] wusbcore: Fix one more crypto-on-the-stack bug

On Mon, Dec 12, 2016 at 1:44 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Mon, Dec 12, 2016 at 12:52:45PM -0800, Andy Lutomirski wrote: >> The driver put a constant buffer of all zeros on the stack and >> pointed a scatterlist entry at it. This doesn't work with vir

[PATCH v2] wusbcore: Fix one more crypto-on-the-stack bug

The driver put a constant buffer of all zeros on the stack and pointed a scatterlist entry at it. This doesn't work with virtual stacks. Use ZERO_PAGE instead. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers <ebigge...@gmail.com> Signed-off-by: Andy Lutomirski <l...@k

[PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

The driver put a constant buffer of all zeros on the stack and pointed a scatterlist entry at it in two places. This doesn't work with virtual stacks. Use ZERO_PAGE instead. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers <ebigge...@gmail.com> Signed-off-by: Andy Lutomir

Re: [PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

On Tue, Dec 13, 2016 at 6:48 PM, Andy Lutomirski <l...@kernel.org> wrote: > The driver put a constant buffer of all zeros on the stack and > pointed a scatterlist entry at it in two places. This doesn't work > with virtual stacks. Use ZERO_PAGE instead. Wait a second... >

Re: [PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs

On Wed, Dec 14, 2016 at 12:37 AM, David Howells <dhowe...@redhat.com> wrote: > Andy Lutomirski <l...@amacapital.net> wrote: > >> > - sg_set_buf(_out[1], pad, sizeof pad); >> > + sg_set_buf(_out[1], empty_zero_page, 16); >> >> My fix her

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo <kv...@codeaurora.org> wrote: > Andy Lutomirski <l...@kernel.org> writes: > >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

On Tue, Dec 13, 2016 at 8:45 AM, David Howells <dhowe...@redhat.com> wrote: > Andy Lutomirski <l...@amacapital.net> wrote: > >> After all, rodata is ordinary memory, is backed by struct page, etc. > > Is that actually true? I thought some arches excluded the kerne

Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

[add some people who might know] On Tue, Dec 13, 2016 at 4:20 AM, David Laight <david.lai...@aculab.com> wrote: > From: Andy Lutomirski >> Sent: 12 December 2016 20:53 >> The driver put a constant buffer of all zeros on the stack and >> pointed a scatterlis

[PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

ed-off-by: Andy Lutomirski <l...@kernel.org> --- security/keys/encrypted-keys/encrypted.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c index 17a06105ccb6..fab2fb864002 100644 --

[PATCH] wusbcore: Fix one more crypto-on-the-stack bug

The driver put a constant buffer of all zeros on the stack and pointed a scatterlist entry at it. This doesn't work with virtual stacks. Make the buffer static to fix it. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers <ebigge...@gmail.com> Signed-off-by: Andy Lutomir

[PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers <ebigge...@gmail.com> Signed-off-by: Andy Lutomirski <l...@kernel.org> --- Compile-tested only. fs/cifs/smbencrypt.c | 40 1 file changed, 8 insertions(+), 32 deletions(-) diff --git a/fs/cifs/smben

[PATCH] orinoco: Use shash instead of ahash for MIC calculations

Eric Biggers pointed out that the orinoco driver pointed scatterlists at the stack. Fix it by switching from ahash to shash. The result should be simpler, faster, and more correct. Cc: sta...@vger.kernel.org # 4.9 only Reported-by: Eric Biggers <ebigge...@gmail.com> Signed-off-by

[PATCH] crypto: Make a few drivers depend on !VMAP_STACK

<ebigge...@gmail.com> Signed-off-by: Andy Lutomirski <l...@kernel.org> --- drivers/crypto/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 4d2b81f2b223..481e67e54ffd 100644 --- a/drivers/crypto/K