Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Wed, Aug 21, 2013 at 2:59 AM, Jussi Kivilinna jussi.kivili...@iki.fi wrote: On 21.08.2013 11:41, Brian Norris wrote: On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote

Re: usb: dwc3: host: inherit dma configuration from parent dev

2016-05-05 Thread Brian Norris
Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> Tested-by: Brian Norris <briannor...@chromium.org> What's the status of this? I see that there was some divergent discussion about the merits of a dma_inherit()

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-09 Thread Brian Norris
Hi William, Did you leave off linux-rockc...@lists.infradead.org intentionally? IMO, it's nice to have that list in CC, so interested parties can follow your work, even if they aren't as fortunate as me to have been CC'd on your patch directly. On Mon, May 09, 2016 at 07:46:14PM +0800, William

[PATCH] Documentation: dt: dwc3: note the supported phy-names

2016-08-18 Thread Brian Norris
The dwc3 driver expicitly looks for "usb2-phy" or "usb3-phy", but we never noted these names in the documentation. Signed-off-by: Brian Norris <briannor...@chromium.org> --- Documentation/devicetree/bindings/usb/dwc3.txt | 3 ++- 1 file changed, 2 insertions(+),

Re: [PACTH,v6,1/2] usb: xhci: plat: Enable runtime PM

2016-08-26 Thread Brian Norris
Hi, On Wed, Aug 24, 2016 at 04:48:01PM -0400, Robert Foss wrote: > On 2016-08-22 11:23 PM, Brian Norris wrote: > >+ others > > > >Hi Robert and Felipe, > > > >I have a few questions for one or both of you. I'm not really an expert > >on runtime PM, so please

Re: [PACTH,v6,1/2] usb: xhci: plat: Enable runtime PM

2016-08-26 Thread Brian Norris
Corrected a bouncing email address (sorry for the noise) On Fri, Aug 26, 2016 at 03:11:36PM -0700, Brian Norris wrote: > Hi, > > On Wed, Aug 24, 2016 at 04:48:01PM -0400, Robert Foss wrote: > > On 2016-08-22 11:23 PM, Brian Norris wrote: > > >+ others > &g

Re: [PACTH,v6,1/2] usb: xhci: plat: Enable runtime PM

2016-08-22 Thread Brian Norris
+ others Hi Robert and Felipe, I have a few questions for one or both of you. I'm not really an expert on runtime PM, so please take my questions with a grain of salt. On Wed, Aug 10, 2016 at 04:32:15PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > >

[RFC PATCH] usb: core: correct usb_get_dev() documentation

2016-10-27 Thread Brian Norris
model, and so it should be unnecessary for a child device to grab a refcount on its parent device. Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- This reflects my understanding (and testing), as well as the majority of usage -- there are *very* few interface drivers that ac

Re: [PATCH v5 1/6] usb: separate out sysdev pointer from usb_bus

2016-12-02 Thread Brian Norris
mail.com> > --- > Changes in v5: > - No update > > Changes in v4: > - No update > > Changes in v3: > - usb is_device_dma_capable instead of directly accessing > dma props. > > Changes in v2: > - Split the patch wrt driver I didn't notice t

[PATCH] usb: dwc3: Undo PHY init if soft reset fails

2018-01-17 Thread Brian Norris
In this function, we init the USB2 and USB3 PHYs, but if soft reset times out, we don't unwind this. Noticed by inspection. Signed-off-by: Brian Norris <briannor...@chromium.org> --- drivers/usb/dwc3/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/d

Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core

2018-01-17 Thread Brian Norris
PATCH 0/3] Reset USB3 controller before initializing Type-C PHY on rk3399 or at least mentioned there, because the series there doesn't quite right otherwise, no? Anyway, I think this patch looks OK. I don't immediately see good reasons for delaying the PHY init until later, and I do see reasons why i

Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2017-12-20 Thread Brian Norris
rks.c. > > Cc: sta...@vger.kernel.org > Cc: Leif Liddy <leif.li...@gmail.com> > Cc: Matthias Kaehlcke <m...@chromium.org> > Cc: Brian Norris <briannor...@chromium.org> > Cc: Daniel Drake <dr...@endlessm.com> > Signed-off-by: Kai-Heng Feng <kai.heng.

Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2017-12-21 Thread Brian Norris
On Thu, Dec 21, 2017 at 3:43 AM, Daniel Drake <dr...@endlessm.com> wrote: > On Wed, Dec 20, 2017 at 6:53 PM, Brian Norris <briannor...@chromium.org> > wrote: >> >> On Wed, Dec 20, 2017 at 07:00:07PM +0800, Kai-Heng Feng wrote: >> > This commit causes a reg

Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core

2018-03-08 Thread Brian Norris
Hi, On Thu, Mar 08, 2018 at 12:43:40PM +0200, Felipe Balbi wrote: > William Wu writes: > > The dwc3_core_init() gets the PHYs and initializes the PHYs with > > the usb_phy_init() and phy_init() functions before initializing > > core, and power on the PHYs after core