Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-19 Thread Chanwoo Choi
(DRA7x USB Connector driver); +MODULE_LICENSE(GPL); +MODULE_DEVICE_TABLE(of, of_dra7xx_match_tbl); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
for detection isn't appropriate for extcon device driver. Instead, I will consider whether to support polling method or not on extcon core. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
meant, you prefer interrupt method for cable detection over polling . Right, my mistake. I prefer interrupt method. Thanks, Chanwoo CHoi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread Chanwoo Choi
); + +MODULE_ALIAS(platform:gpio-usbvid); +MODULE_AUTHOR(George Cherian george.cher...@ti.com); +MODULE_DESCRIPTION(GPIO based USB Connector driver); +MODULE_LICENSE(GPL); +MODULE_DEVICE_TABLE(of, of_gpio_usbvid_match_tbl); Cheers, Chanwoo Choi -- To unsubscribe from this list: send the line

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
Hi George, On 08/29/2013 11:21 AM, George Cherian wrote: Hi Chanwoo, Thanks for the review and sorry for all the trivial mistakes. On 8/29/2013 7:05 AM, Chanwoo Choi wrote: Hi George, You didn't modify this patchset about my comment on v1 patchset. Please pay attention to comment

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
On 08/29/2013 04:30 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 11:53 AM, Chanwoo Choi wrote: [snip] You should keep following naming stlye. extcon-gpio-usbvid.c is wrong naming style. - extcon-[device name].c - extcon-gpio-usbvid.c - extcon-dra7xx.c or etc. Actually dra7xx

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
On 08/29/2013 08:48 PM, George Cherian wrote: On 8/29/2013 4:07 PM, Chanwoo Choi wrote: On 08/29/2013 04:30 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 11:53 AM, Chanwoo Choi wrote: [snip] You should keep following naming stlye. extcon-gpio-usbvid.c is wrong naming style. - extcon

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Chanwoo Choi
Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM, Chanwoo Choi wrote: [big snip ] I tested various development board based on Samsung Exynos series SoC. Although some gpio of Exynos series SoC set high state(non zero, 1) as default value

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-30 Thread Chanwoo Choi
Hi George, On 08/30/2013 03:15 PM, George Cherian wrote: Hi Chanwoo, On 8/30/2013 5:41 AM, Chanwoo Choi wrote: Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM, Chanwoo Choi wrote: [big snip ] I tested various development board based

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-30 Thread Chanwoo Choi
Hi George, In addition, I add answer about that device driver control gpio pin directly. On 08/30/2013 03:15 PM, George Cherian wrote: Hi Chanwoo, On 8/30/2013 5:41 AM, Chanwoo Choi wrote: Hi George, On 08/29/2013 10:45 PM, George Cherian wrote: Hi Chanwoo, On 8/29/2013 5:42 PM

Re: [PATCH] extcon: palmas: Handle ID interrupt properly using USB_ID_INT_SRC

2013-10-21 Thread Chanwoo Choi
IRQ_HANDLED; Applied it on next branch. Thanks. Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] extcon: of: Update OF helper function

2014-03-18 Thread Chanwoo Choi
Thisp patchset remove unnecessary function call in of_extcon_get_extcon_dev() which get the extcon device from devicetree. Also, this patchset move OF helper func to extcon core and change function name as following: - of_extcon_get_extcon_dev() - extcon_get_edev_by_phandle() Chanwoo Choi (2

[PATCH 1/2] extcon: of: Remove unnecessary function call by using the name of device_node

2014-03-18 Thread Chanwoo Choi
This patch remove unnecessary function call in of_extcon_get_extcon_dev() by using the name of device_node structure. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/extcon/of_extcon.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/extcon

[PATCH 2/2] extcon: Move OF helper function to extcon core and change function name

2014-03-18 Thread Chanwoo Choi
This patch move simply OF helper function to extcon core and change function name as following: - of_extcon_get_extcon_dev() - extcon_get_edev_by_phandle() Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/extcon/Kconfig | 4 --- drivers/extcon/Makefile | 2

Re: [PATCH 1/2] extcon: of: Remove unnecessary function call by using the name of device_node

2014-03-19 Thread Chanwoo Choi
Hi, On 03/19/2014 09:08 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 18 March 2014 05:34 PM, Chanwoo Choi wrote: This patch remove unnecessary function call in of_extcon_get_extcon_dev() by using the name of device_node structure. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com

Re: [PATCH 1/2] extcon: of: Remove unnecessary function call by using the name of device_node

2014-03-20 Thread Chanwoo Choi
Hi, On 03/20/2014 02:20 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 March 2014 07:52 AM, Chanwoo Choi wrote: Hi, On 03/19/2014 09:08 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 18 March 2014 05:34 PM, Chanwoo Choi wrote: This patch remove unnecessary function call

Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-26 Thread Chanwoo Choi
Hi Kishon, I have some comment about this patch and upload modified patch to following repository (extcon-for-palmas). - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmasid=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c This patchset include patch related to

Re: [PATCH 3/3] usb: dwc3: use extcon fwrk to receive connect/disconnect notification

2013-05-26 Thread Chanwoo Choi
/dwc3/dwc3-omap.c | 80 +-- include/linux/usb/dwc3-omap.h | 30 2 files changed, 62 insertions(+), 48 deletions(-) delete mode 100644 include/linux/usb/dwc3-omap.h I check the code about extcon framework. Acked-by: Chanwoo Choi cw00.c

Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-27 Thread Chanwoo Choi
On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: Hi Kishon, I have some comment about this patch and upload modified patch to following repository (extcon-for-palmas). - http://git.kernel.org/cgit/linux/kernel/git/chanwoo

Re: [PATCH v2] usb: dwc3: use extcon fwrk to receive connect/disconnect notification

2013-05-27 Thread Chanwoo Choi
2 files changed, 85 insertions(+), 48 deletions(-) delete mode 100644 include/linux/usb/dwc3-omap.h I think that usb or other maintainer have to confirm this patch for applying extcon-next branch. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH v6] extcon: Palmas Extcon Driver

2013-05-27 Thread Chanwoo Choi
-by: Sebastien Guiriec s-guir...@ti.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Myungjoo Ham myungjoo@samsung.com --- Changes from v5: * removed regulator calls from palmas-usb as some platforms wont need it. These are now done in dwc3-omap.c as it is needed for OMAP

Re: [PATCH 3/3] usb: dwc3: use extcon fwrk to receive connect/disconnect notification

2013-05-30 Thread Chanwoo Choi
= dwc3_omap_dma_mask; + Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework

2013-06-11 Thread Chanwoo Choi
Hi Kishon, Sorry for late reply. I applied patch1,2 on extcon-linus branch. - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-linus But, I have comment of patch 3 about dt API. I send comment on patch 3 mailing thread. Thanks, Chanwoo Choi On 06/04/2013 01:13 AM

Re: [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework

2013-06-11 Thread Chanwoo Choi
, Chanwoo Choi On 06/04/2013 01:13 AM, Kishon Vijay Abraham I wrote: The first three patches deals with cleanup of extcon inorder to get through compilation without any issues. It also adds an API to get extcon device from dt node which I felt was missing. The next two patches deals with adapt

Re: [PATCH 1/5] extcon: Add an API to get extcon device from dt node

2013-06-11 Thread Chanwoo Choi
) { return NULL; Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] extcon: Add an API to get extcon device from dt node

2013-06-11 Thread Chanwoo Choi
From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Signed-off-by: Chanwoo Choi cw00.c

Re: [PATCH] extcon: Add an API to get extcon device from dt node

2013-06-13 Thread Chanwoo Choi
On 06/12/2013 03:55 PM, Kishon Vijay Abraham I wrote: Hi Chanwoo Choi, On Wednesday 12 June 2013 07:09 AM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can

[PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Chanwoo Choi
From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Signed-off-by: Chanwoo Choi cw00.c

Re: [PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Chanwoo Choi
On 06/14/2013 05:36 PM, Kishon Vijay Abraham I wrote: Hi, On Friday 14 June 2013 12:45 PM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I kis...@ti.com Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead

Re: [PATCH v4] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-16 Thread Chanwoo Choi
a/include/linux/usb/dwc3-omap.h b/include/linux/usb/dwc3-omap.h deleted file mode 100644 index 5615f4d..000 It looks good if you add exception handler about return value of extcon_register_interest(). Acked-by: Chanwoo Choi cw00.c...@samsung.com But, we have to apply this patch after all

Re: [PATCH v5] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-24 Thread Chanwoo Choi
Balbi ba...@ti.com Acked-by: Chanwoo Choi cw00.c...@samsung.com --- This patch should be applied after all of the extcon patchset will be applied because this patch has dependency of extcon patch related to DT. http://goo.gl/Tu3qW Changes from v4: * checked the return values

Re: [PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-07-15 Thread Chanwoo Choi
-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Felipe Balbi ba...@ti.com Acked-by: Chanwoo Choi cw00.c...@samsung.com --- This patch should be applied after all of the extcon patchset will be applied because this patch has dependency of extcon patch related to DT. http://goo.gl/Tu3qW

Re: [PATCH] extcon: add MAX3355 driver

2014-12-10 Thread Chanwoo Choi
Hi Sergei, I reviewed this patch quickly. This driver has just two gpio without any registers for IP. I wonder whether MAX3355E is separate chip to detect external connector or just use gpio of AP. Could you send the datasheet of MAX3355E to me? Thanks, Chanwoo Choi On 12/11/2014 08:28 AM

Re: [PATCH] extcon: add MAX3355 driver

2014-12-11 Thread Chanwoo Choi
On 12/11/2014 09:47 PM, Sergei Shtylyov wrote: Hello. On 12/11/2014 4:46 AM, Chanwoo Choi wrote: I reviewed this patch quickly. This driver has just two gpio without any registers for IP. Because there are no registers. I wonder whether MAX3355E is separate chip to detect

Re: [PATCH] extcon: add MAX3355 driver

2014-12-16 Thread Chanwoo Choi
...@cogentembedded.com); +MODULE_DESCRIPTION(MAX3355 extcon driver); Maxim MAX3355. +MODULE_LICENSE(GPL v2); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-26 Thread Chanwoo Choi
, + .of_match_table = usb_extcon_dt_match, + }, +}; + +module_platform_driver(usb_extcon_driver); + +MODULE_AUTHOR(Roger Quadros rog...@ti.com); +MODULE_DESCRIPTION(USB GPIO extcon driver); +MODULE_LICENSE(GPL v2); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-02-02 Thread Chanwoo Choi
Hi Roger, Looks good to me. Applied it on v3.21 queue. Thanks, Chanwoo Choi On 02/02/2015 07:21 PM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Chanwoo Choi
Hi Roger, On 02/02/2015 06:09 PM, Roger Quadros wrote: Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote: Felipe Chanwoo, On 26/01/15 14:15, Roger Quadros wrote: The recommended name

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-02 Thread Chanwoo Choi
On 02/02/2015 07:01 PM, Roger Quadros wrote: On 02/02/15 11:55, Chanwoo Choi wrote: Hi Roger, On 02/02/2015 06:09 PM, Roger Quadros wrote: Chanwoo, On 02/02/15 07:04, Chanwoo Choi wrote: Hi Roger, On 01/30/2015 11:05 PM, Roger Quadros wrote: Hi, On 30/01/15 13:04, Roger Quadros wrote

Re: [PATCH 1/5] extcon: gpio-usb: Introduce gpio usb extcon driver

2015-01-20 Thread Chanwoo Choi
Hi Roger, On 01/20/2015 02:52 AM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable for this purpose as it needs to be taught to understand USB cable states and

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-26 Thread Chanwoo Choi
Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need some clarification on one comment. On 26/01/15 15:56, Chanwoo Choi wrote: Hi Roger, This patch looks good to me. But I add some comment. If you modify some comment, I'll apply

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Chanwoo Choi
, + }, +}; + +module_platform_driver(usb_extcon_driver); + +MODULE_AUTHOR(Roger Quadros rog...@ti.com); +MODULE_DESCRIPTION(USB GPIO extcon driver); +MODULE_LICENSE(GPL v2); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-02-01 Thread Chanwoo Choi
the specific cable name(USB-Host or USB-HOST) without any standard way. So, I have plan to define common cable name in extcon header file by using capital letter. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-02-01 Thread Chanwoo Choi
Hi Roger, On 01/30/2015 11:03 PM, Roger Quadros wrote: On 30/01/15 02:11, Chanwoo Choi wrote: Hi Roger, On 01/28/2015 09:15 PM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-27 Thread Chanwoo Choi
Hi Roger, On 01/28/2015 12:38 AM, Roger Quadros wrote: Chanwoo, On 27/01/15 03:54, Chanwoo Choi wrote: Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need some clarification on one comment. On 26/01/15 15:56, Chanwoo Choi wrote: Hi

Re: [PATCH] phy: exynos5-usbdrd: Add to support for Exynos5433 SoC

2015-03-16 Thread Chanwoo Choi
) + #define EXYNOS5_PHY_ENABLE BIT(0) #define EXYNOS5_MIPI_PHY_S_RESETNBIT(1) I tested this patch for USB on Exynos5433-based board. Tested-by: Chanwoo Choi cw00.c...@samsung.com Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Chanwoo Choi
for extcon cable name as soon because it has potential isseu about the conflict of extcon cable name between subsystems. So, I recommend to use a captical letter as USB-HOST instead of USB-Host. If other extcon driver don't use the captical letter, I'll fix it. [snip] Thanks, Chanwoo Choi

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-29 Thread Chanwoo Choi
Hi Roger, On 01/29/2015 08:26 PM, Roger Quadros wrote: Chanwoo, On 29/01/15 03:49, Chanwoo Choi wrote: Hi Roger, We need to discuss one point about 'id_irqwake'. I don't recommend to use 'id_irqwake' field. And I catch build warning by using select keywork in Kconfig. It is my wrong

Re: [PATCH v2 1/4] extcon: usb-gpio: register extcon device before IRQ registration

2015-04-01 Thread Chanwoo Choi
, Chanwoo Choi cheers, -roger --- drivers/extcon/extcon-usb-gpio.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c index 3f0bad3..f6aa99d 100644 --- a/drivers/extcon/extcon

Re: [PATCH v3 1/4] extcon: usb-gpio: register extcon device before IRQ registration

2015-04-02 Thread Chanwoo Choi
device\n); - return ret; - } - platform_set_drvdata(pdev, info); device_init_wakeup(dev, 1); Applied this patch for v4.1-rc. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Chanwoo Choi
On 04/14/2015 07:38 PM, Roger Quadros wrote: On 14/04/15 13:31, Chanwoo Choi wrote: On 04/14/2015 07:02 PM, Roger Quadros wrote: Fixed Kishon's id. On 14/04/15 13:01, Roger Quadros wrote: On 10/04/15 12:18, Chanwoo Choi wrote: On 04/10/2015 05:46 PM, Robert Baldyga wrote: On 04/10/2015 10

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-14 Thread Chanwoo Choi
On 04/14/2015 07:02 PM, Roger Quadros wrote: Fixed Kishon's id. On 14/04/15 13:01, Roger Quadros wrote: On 10/04/15 12:18, Chanwoo Choi wrote: On 04/10/2015 05:46 PM, Robert Baldyga wrote: On 04/10/2015 10:10 AM, Chanwoo Choi wrote: On 04/10/2015 04:45 PM, Robert Baldyga wrote: On 04/10

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Chanwoo Choi
Hi Peter, On 04/16/2015 10:59 AM, Peter Chen wrote: On Wed, Apr 15, 2015 at 06:26:23PM +0900, Chanwoo Choi wrote: Hi Roger and Peter, On 04/15/2015 04:50 PM, Roger Quadros wrote: On 15/04/15 06:27, Peter Chen wrote: On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: On 04/14

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Chanwoo Choi
On 04/16/2015 04:13 PM, Ivan T. Ivanov wrote: Hi, On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: Hi Peter, On 04/16/2015 10:59 AM, Peter Chen wrote: Ok, from USB point, external id/vbus value can't decide which role the controller will be, the controller driver will decide

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Chanwoo Choi
On 04/16/2015 05:01 PM, Peter Chen wrote: On Thu, Apr 16, 2015 at 04:59:31PM +0900, Chanwoo Choi wrote: On 04/16/2015 04:13 PM, Ivan T. Ivanov wrote: Hi, On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: Hi Peter, On 04/16/2015 10:59 AM, Peter Chen wrote: Ok, from USB point

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-15 Thread Chanwoo Choi
Hi Roger and Peter, On 04/15/2015 04:50 PM, Roger Quadros wrote: On 15/04/15 06:27, Peter Chen wrote: On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote: On 04/14/2015 07:38 PM, Roger Quadros wrote: On 14/04/15 13:31, Chanwoo Choi wrote: On 04/14/2015 07:02 PM, Roger Quadros wrote

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-08 Thread Chanwoo Choi
] none |H|L + * [3] USB USB-HOST |L|H + * [4] USB-HOST |L|L + * [snip] Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-09 Thread Chanwoo Choi
Hi Robert, On 04/09/2015 04:57 PM, Robert Baldyga wrote: Hi Chanwoo, On 04/09/2015 04:12 AM, Chanwoo Choi wrote: Hi Robert, [snip] But, I have one question about case[3] If id is low and vbus is high, this patch will update the state of both USB and USB-HOST cable as attached state

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
On 06/11/2015 06:33 PM, Chanwoo Choi wrote: Hi, On 06/11/2015 05:59 PM, Hans de Goede wrote: Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
Hi, On 06/11/2015 06:38 PM, Hans de Goede wrote: Hi, On 11-06-15 11:33, Chanwoo Choi wrote: Hi, On 06/11/2015 05:59 PM, Hans de Goede wrote: Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
Hi, On 06/11/2015 05:59 PM, Hans de Goede wrote: Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I add the comment about extcon-related code

Re: [PATCH v5 2/7] phy-sun4i-usb: Add extcon support for the otg phy (phy0)

2015-06-14 Thread Chanwoo Choi
Choi cw00.c...@samsung.com Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type

2015-06-11 Thread Chanwoo Choi
Dear Greg, On 06/12/2015 01:27 PM, Greg KH wrote: On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote: This patch just redefine the unique id of supported external connectors without 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to indicate

Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type

2015-06-11 Thread Chanwoo Choi
Dear Greg, On 06/12/2015 01:29 PM, Greg KH wrote: On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote: This patch just redefine the unique id of supported external connectors without 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to indicate

[PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type

2015-06-11 Thread Chanwoo Choi
header file which includes the unique id of supported external connectors. - include/dt-bindings/extcon/extcon.h Fixes: 2a9de9c0f08d (extcon: Use the unique id for external connector instead of string) Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- Dear Greg, I sent pull-request[1] of extcon

[PATCH 5/5] usb: phy: msm-usb: Replace deprecated API of extcon

2015-06-30 Thread Chanwoo Choi
, char *) - extcon_get_cable_state_(*edev, id) Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/usb/phy/phy-msm-usb.c | 20 ++-- include/linux/usb/msm_hsusb.h | 2 +- 2 files changed, 11

[PATCH 4/5] usb: renesas_usbhs: Replace deprecated API of extcon

2015-06-30 Thread Chanwoo Choi
Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/usb/renesas_usbhs/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index e8bf40808b39..7b98e1d9194c 100644 --- a/drivers/usb/renesas_usbhs

[PATCH 3/5] usb: phy: tahvo: Use devm_extcon_dev_[allocate|register]() and replace deprecated API

2015-06-30 Thread Chanwoo Choi
...@linuxfoundation.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/usb/phy/phy-tahvo.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c index b40d6a87d694..ab5d364f6e8c 100644

[PATCH 1/5] usb: dwc3: omap: Replace deprecated API of extcon

2015-06-30 Thread Chanwoo Choi
, char *) - extcon_get_cable_state_(*edev, id) Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/usb/dwc3/dwc3-omap.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions

[PATCH 0/5] usb: Replace deprecated API of extcon

2015-06-30 Thread Chanwoo Choi
, unsigned int id, bool cable_state); Depends on: This patch-set is based on latest linux.git[1] because this patch-set have the dependency of extcon patches for Linux v4.2. [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ Chanwoo Choi (5): usb: dwc3

[PATCH 2/5] usb: phy: omap-otg: Replace deprecated API of extcon

2015-06-30 Thread Chanwoo Choi
, char *) - extcon_get_cable_state_(*edev, id) Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/usb/phy/phy-omap-otg.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
, .driver = { .of_match_table= sun4i_usb_phy_of_match, -.name = sun4i-usb-phy, +.name = DRIVER_NAME, } }; module_platform_driver(sun4i_usb_phy_driver); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Chanwoo Choi
Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I add the comment about extcon-related code. Firstly, I'd like you to implment the extcon driver for phy-sun4i-usb device in drivers/extcon

Re: [PATCH] extcon: fix phy-tahvo driver for extcon API change

2015-05-21 Thread Chanwoo Choi
Dear Felipe, If you review this patch, I'll apply it on extcon tree. Best Regards, Chanwoo Choi On 05/21/2015 06:39 PM, Arnd Bergmann wrote: Today, the API for the extcon drivers was changed, along with all drivers in drivers/extcon. However, one extcon driver instead lives in drivers/usb

Re: [PATCH 2/2] extcon: Fix extcon_cable_get_state() from getting old state after notification

2015-07-31 Thread Chanwoo Choi
this by first changing the extcon state variable and then notifying listeners. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/extcon/extcon.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Applied it. Thanks, Chanwoo Choi diff --git a/drivers/extcon/extcon.c

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-27 Thread Chanwoo Choi
Hi Roger, On 07/27/2015 07:39 PM, Roger Quadros wrote: Chanwoo, On 10/07/15 18:54, Chanwoo Choi wrote: Hi Roger, Thanks for your working. I'll review, test and apply it on next week because I'm on vacation now. Can you please take this for -rc cycle? Thanks. I'm sorry for delay

Re: [PATCH] usb: phy: omap-otg: fix uninitialized pointer

2015-10-27 Thread Chanwoo Choi
xtcon = extcon; > otg_dev->id_nb.notifier_call = omap_otg_id_notifier; > otg_dev->vbus_nb.notifier_call = omap_otg_vbus_notifier; > > Thanks for your fixes. Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> Regards, Chanwoo Choi -- To unsubscri

Re: [PATCH] extcon: add MAX3355 driver

2015-10-22 Thread Chanwoo Choi
>> >>> Use of_get_gpio() or of_get_gpio_flags(). >> >> OK, I'll use the first one. > >No, I won't due to not being able to use "gpios" anymore. OK. I add the comment on upper. You can use the gpiod API. > > [...] > >>>> + >>&

Re: [PATCH] extcon: add MAX3355 driver

2015-11-09 Thread Chanwoo Choi
Hello, I received the reply from you after too long time (17~18day). You better to reply it more a little more quickly if you have the question or new patches. On 2015년 11월 10일 03:24, Sergei Shtylyov wrote: > Hello. > > On 10/23/2015 08:56 AM, Chanwoo Choi wrote: > >>

Re: [PATCH] extcon: add MAX3355 driver

2015-10-20 Thread Chanwoo Choi
Hi Sergei, I think this patch is too much delay. I recommend you better to develop this driver based on latest extcon-next branch[1]. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next Thanks, Chanwoo Choi On 2015년 10월 21일 03:20, Sergei Shtylyov wrote

Re: [PATCH 1/5] usb: dwc3: omap: Replace deprecated API of extcon

2015-07-10 Thread Chanwoo Choi
Hi Felipe, On Mon, Jul 6, 2015 at 7:23 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Jul 01, 2015 at 01:11:30PM +0900, Chanwoo Choi wrote: This patch removes the deprecated notifier API of extcon framwork and then use the new extcon API with the unique id to indicate the each external

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-10 Thread Chanwoo Choi
Hi Roger, Thanks for your working. I'll review, test and apply it on next week because I'm on vacation now. Thanks, Chanwoo Choi On Tue, Jul 7, 2015 at 3:06 PM, Roger Quadros rog...@ti.com wrote: Users of find_cable_index_by_name() will cause a kernel hang as the while loop counter is never

Re: [PATCHv2 1/2] extcon: add driver for Intel USB mux

2015-12-03 Thread Chanwoo Choi
License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#ifndef _INTEL_USB_MUX_H > +#define _INTEL_USB_MUX_H > + > +#include > + > +struct intel_usb_mux; > + > +#ifdef CONFIG_EXTCON_INTEL_USB > +struct intel_usb_mux *intel_usb_mux_register(struct device *de

Re: [PATCHv2 1/2] extcon: add driver for Intel USB mux

2015-12-06 Thread Chanwoo Choi
tcon_set_cable_state(). I think that you should divide it according to role. Again, the usage case of extcon have to consist of both provider extcon driver and client extcon driver. If there is no provider extcon driver, client extcon driver don't receive the any notification of external connector from provider extc

Re: [PATCHv2 1/2] extcon: add driver for Intel USB mux

2015-12-07 Thread Chanwoo Choi
Hi, On 2015년 12월 07일 21:52, Heikki Krogerus wrote: > Hi, > > On Mon, Dec 07, 2015 at 10:24:22AM +0900, Chanwoo Choi wrote: >> Hi, >> >> On 2015년 12월 04일 17:51, Heikki Krogerus wrote: >>> Hi, >>> >>>> I do never want to add

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-16 Thread Chanwoo Choi
return 0; > +} > + > +static int max3355_remove(struct platform_device *pdev) > +{ > + struct max3355_data *data = platform_get_drvdata(pdev); > + > + gpiod_set_value_cansleep(data->shdn_gpiod, 0); > + > + return 0; > +} > + > +static const struct of_device_id max3355_match_table[] = { > + { .compatible = "maxim,max3355", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, max3355_match_table); > + > +static struct platform_driver max3355_driver = { > + .probe = max3355_probe, > + .remove = max3355_remove, > + .driver = { > + .name = "extcon-max3355", > + .of_match_table = max3355_match_table, > + .owner = THIS_MODULE, You don't need to add the 'owner'. > + }, > +}; > + > +module_platform_driver(max3355_driver); > + > +MODULE_AUTHOR("Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>"); > +MODULE_DESCRIPTION("Maxim MAX3355 extcon driver"); > +MODULE_LICENSE("GPL v2"); Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-16 Thread Chanwoo Choi
Hi, On 2015년 12월 17일 11:16, Chanwoo Choi wrote: > Hi Sergei, > > On 2015년 12월 17일 03:07, Sergei Shtylyov wrote: >> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to >> enable a system with an integrated USB OTG dual-role transceiver to >> funct

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

2015-12-14 Thread Chanwoo Choi
uble space between words. You should fix it. Thanks, Chanwoo Choi > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > > --- > The patch is against the 'extcon-next' branch of the 'extcon.git' repo. > > Changes in version 2: > - added the US

Re: [PATCH] extcon-usb-gpio: add enable pin support

2015-12-10 Thread Chanwoo Choi
Hi Sergei, On 2015년 12월 11일 08:07, Sergei Shtylyov wrote: > Sometimes there's a real OTG chip behind the USB ID signal mapped to a GPIO > pin: in my case it's Maxim Integrated MAX3355E which integrates Vbus charge > pump and comparators and passes thru the ID signal from an OTG connector.

Re: [PATCH v5] extcon: add Maxim MAX3355 driver

2015-12-20 Thread Chanwoo Choi
Hi, On 2015년 12월 21일 02:15, Sergei Shtylyov wrote: > Hello. > > On 12/20/2015 05:31 PM, Chanwoo Choi wrote: > >> This patch depend on GPIOLIB configuration as following: >> I modified it with following diff and applied it. >> >> diff --git a/drivers/ext

Re: [PATCH] extcon: max3355: kill unneeded #include's

2015-12-20 Thread Chanwoo Choi
ers/extcon/extcon-max3355.c > @@ -11,14 +11,9 @@ > > #include > #include > -#include > #include > -#include > #include > -#include > #include > -#include > -#include > > struct max3355_data { > struct extcon_dev *edev; > I combine i

Re: [PATCH v5] extcon: add Maxim MAX3355 driver

2015-12-21 Thread Chanwoo Choi
On 2015년 12월 21일 20:01, Sergei Shtylyov wrote: > Hello. > > On 12/21/2015 5:38 AM, Chanwoo Choi wrote: > >>>> This patch depend on GPIOLIB configuration as following: >>>> I modified it with following diff and applied it. >>>> >>>>

Re: [PATCH v5] extcon: add Maxim MAX3355 driver

2015-12-22 Thread Chanwoo Choi
On 2015년 12월 22일 20:15, Sergei Shtylyov wrote: > Hello. > > On 12/22/2015 4:13 AM, Chanwoo Choi wrote: > >>>>>> This patch depend on GPIOLIB configuration as following: >>>>>> I modified it with following diff and applied it. >>>>&g

Re: [PATCH v5] extcon: add Maxim MAX3355 driver

2015-12-20 Thread Chanwoo Choi
omparators to Thanks, Chanwoo Choi On Sat, Dec 19, 2015 at 8:17 AM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: > Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > enable a system with an integrated USB OTG dual-role transceiver to > functio

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-17 Thread Chanwoo Choi
On 2015년 12월 18일 06:20, Sergei Shtylyov wrote: > Hello. > > On 12/17/2015 05:34 AM, Chanwoo Choi wrote: > >>> On 2015년 12월 17일 03:07, Sergei Shtylyov wrote: >>>> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to >>>> enable

Re: [PATCH v4] extcon: add Maxim MAX3355 driver

2015-12-17 Thread Chanwoo Choi
Hi Sergei, Except for just one comment below, Looks good to me. Acked-by: Chanwoo Choi <cw00.c...@samsung.com> I'll wait for a few days to get the review from DT maintainer before applying it on extcon-next branch. On 2015년 12월 18일 07:47, Sergei Shtylyov wrote: > Maxim Integrated MAX3

Re: [PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory

2015-11-19 Thread Chanwoo Choi
Hi, The same patch was already reviewed and applied on usb.git repository[1] [1] https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes=2c2025b41aeff57963f9ae2dd909fea704c625ab Thanks, Chanwoo Choi On 2015년 11월 20일 08:43, Heinrich Schuchardt wrote: > The curr

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Chanwoo Choi
Hi Lu, On 2016년 03월 17일 16:16, Lu Baolu wrote: > Hi Chanwoo, > > On 03/17/2016 02:07 PM, Chanwoo Choi wrote: >> Hi Lu, >> >> To handle extcon (external connector), I implemented the unique id >> for each external connector on patch[1] instead of using the

Re: [RFC PATCH 1/4] usb: chipidea: Do not rely on OTG while using extcon

2016-03-19 Thread Chanwoo Choi
"USB-HOST") == true) > + ci->role = CI_ROLE_HOST; > + } > } > } else { > ci->role = ci->roles[CI_ROLE_HOST] > @@ -1021,6 +1025,12 @@ static int ci_hdrc_probe(

Re: [PATCH v4 3/7] usb: mux: add common code for Intel dual role port mux

2016-03-19 Thread Chanwoo Choi
- USB Port Mux definitions > + * > + * Copyright (C) 2016 Intel Corporation > + * > + * Author: Lu Baolu <baolu...@linux.intel.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public

  1   2   >