On 18.07.2013 11:40, Stefan Roese wrote:
On 07/18/2013 11:18 AM, Kishon Vijay Abraham I wrote:
I'm testing musb as OTG on beagleboard (old one, not Beagle-xm). And
using the latest kernel.org version with this patch applied I see the
following messages while booting (repeatedly):
[
Hi Aaro,
On 24.07.2013 20:51, Aaro Koskinen wrote:
On Tue, Jul 16, 2013 at 08:57:10PM +0300, Aaro Koskinen wrote:
Here are full details:
Kernel v3.11-rc1 and the following USB fixes:
ARM: omap2: fix musb usage for n8x0
musb: omap: Fix: pass all the resources to musb core
[...]
On 25.07.2013 02:30, Aaro Koskinen wrote:
On Wed, Jul 24, 2013 at 09:04:28PM +0200, Daniel Mack wrote:
On 24.07.2013 20:51, Aaro Koskinen wrote:
When I revert fe4cb0912f8e737f8e4b8b38b9e692f8062f5423 and
8b125df5b24cfb0ec7fa1971e343cc0badc1827d, it works like before (3.10):
I'm now running
On 29.07.2013 20:20, Alan Stern wrote:
data_ep_set_params() checks snd_usb_endpoint_implicit_feedback_sink()
in three places. It looks like only the second place is correct.
Can you verify whether the other two are right, and explain to me if
they are?
Which version are you looking at?
Hi Aaro,
On 06.08.2013 19:06, Aaro Koskinen wrote:
Peripheral-only mode got broken in v3.11-rc1 because of unknown reasons.
Given that you have a board that is affected, could you investigate a
little maybe? I would have done it a long time ago, but I don't have
access to such hardware
whether it was ever used.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 5233804..f20218e 100644
--- a/drivers/usb/musb/musb_dsps.c
Hi Alan,
On 13.08.2013 23:06, Alan Stern wrote:
On Mon, 12 Aug 2013, Alan Stern wrote:
On Mon, 12 Aug 2013, Takashi Iwai wrote:
So... Clemens, Daniel, Eldad, could you guys review the latest version
of Alan's patch? I'd love to sort this out for 3.12.
Here's a revised version of the patch
On 13.08.2013 14:40, Daniel Mack wrote:
dsps_suspend() and dsps_resume() are called with the device that has the
glue assigned as drvdata. Using dev-parent seems wrong and causes a
NULL pointer exception on an AM33xx board.
The code was introduced by commit c68bb4c6 (usb: musb: dsps: control
Commit 7e8d5cd93fac (USB: Add EHCI support for MX27 and MX31 based
boards) introduced code that could potentially lead to a NULL pointer
dereference on driver removal.
Fix this by checking for the value of pdata before dereferencing it.
Signed-off-by: Daniel Mack zon...@gmail.com
Reported
driver used 8
packets per URB whereas the patched driver used 22. This updated patch
should fix that problem.
I gave this patch a try and I can confirm that it results in a
sigificant improvement for small sample buffers.
So feel free to add my
Tested-by: Daniel Mack zon...@gmail.com
Thanks
On 11.09.2013 14:53, Ankit Agarwal wrote:
On Sun, Sep 8, 2013 at 8:27 PM, Daniel Mack zon...@gmail.com
mailto:zon...@gmail.com wrote:
On 02.09.2013 12:51, Ankit Agarwal wrote:
I am using alsa pcm player to listen to audio. The alsa pcm
crashes with
the error: ALSA sound
readable.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 7c82b92..53d1d31 100644
--- a/drivers/dma/cppi41.c
+++ b
Makes the code more readable and compact. No functional change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 5469a15
Fix a misspelled function name.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 53d1d31..5469a15 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma
/after the resume cycle, but I'm hoping to make
progress here soon.
Thanks,
Daniel
Daniel Mack (5):
dma: cppi41: pass around device instead of platform_device
dma: cppi41: s/deinit_cpii41/deinit_cppi41/
dma: cppi41: add shortcut to pdev-dev in cppi41_dma_probe()
dma: cppi41: only allocate
into an operable state after resume.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 36
1 file changed, 36 insertions(+)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 3347321..a1d162d 100644
--- a/drivers/dma/cppi41.c
+++ b
mem_decs (I guess it was
only there to make the code comply to the 80-chars CodingSytle rule).
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
On 21.09.2013 20:14, Sergei Shtylyov wrote:
On 09/20/2013 05:43 PM, Daniel Mack wrote:
This patch adds support for suspend/resume functionality to the cppi41
DMA driver. The steps neccessary to make the system resume properly were
figured out by hefty trial-and-error. The code as it stands
Fix a misspelled function name.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 53d1d31..5469a15 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma
readable.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 7c82b92..53d1d31 100644
--- a/drivers/dma/cppi41.c
+++ b
/after the resume cycle, but I'm hoping to make
progress here soon.
Thanks,
Daniel
v1 - v2:
* Patch #5: depend on CONFIG_PM_SLEEP rather than on
CONFIG_PM and use SIMPLE_DEV_PM_OPS
(Reported by Sergei Shtylyov)
Daniel Mack (5):
dma: cppi41: pass around device instead
Makes the code more readable and compact. No functional change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 5469a15
mem_decs (I guess it was
only there to make the code comply to the 80-chars CodingSytle rule).
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
into an operable state after resume.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 3347321..59dfa8e 100644
--- a/drivers/dma/cppi41.c
+++ b
On 22.09.2013 16:25, Sergei Shtylyov wrote:
On 22-09-2013 15:57, Daniel Mack wrote:
+#ifdef CONFIG_PM_SLEEP
[...]
+static SIMPLE_DEV_PM_OPS(cppi41_pm_ops, cppi41_suspend, cppi41_resume);
+
+#define DEV_PM_OPS (cppi41_pm_ops)
+#else
+#define DEV_PM_OPS NULL
+#endif
You don't need
This makes am35x_pm_ops const and will stub the struct out in case
CONFIG_PM_SLEEP is not set.
Signed-off-by: Daniel Mack zon...@gmail.com
---
I'm resending this series because I've just learned that
SIMPLE_DEV_PM_OPS will stub itself out in case CONFIG_PM_SLEEP is
not set. That makes
This removes the DEV_PM_OPS macro and brings this file in line with the
other musb platform drivers.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/ux500.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/musb/ux500.c b/drivers/usb
This makes bfin_pm_ops const and will stub the struct out in case
CONFIG_PM_SLEEP is not set.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/blackfin.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb
This makes omap2430_pm_ops const and will stub the struct out in case
CONFIG_PM_SLEEP is not set.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/omap2430.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers
SIMPLE_DEV_PM_OPS
(Reported by Sergei Shtylyov)
Daniel Mack (5):
dma: cppi41: pass around device instead of platform_device
dma: cppi41: s/deinit_cpii41/deinit_cppi41/
dma: cppi41: add shortcut to pdev-dev in cppi41_dma_probe()
dma: cppi41: only allocate descriptor memory once
dma
Fix a misspelled function name.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 53d1d31..5469a15 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma
mem_decs (I guess it was
only there to make the code comply to the 80-chars CodingSytle rule).
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 25 ++---
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
Makes the code more readable and compact. No functional change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 5469a15
On 22.09.2013 16:59, Sergei Shtylyov wrote:
On 22-09-2013 18:43, Daniel Mack wrote:
This makes omap2430_pm_ops const and will stub the struct out in case
CONFIG_PM_SLEEP is not set.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/omap2430.c | 15 +--
1
On 23.09.2013 06:09, Vinod Koul wrote:
On Sun, Sep 22, 2013 at 04:50:04PM +0200, Daniel Mack wrote:
+#ifdef CONFIG_PM_SLEEP
a
+static int cppi41_suspend(struct device *dev)
+{
+struct cppi41_dd *cdd = dev_get_drvdata(dev);
+
+cppi_writel(0, cdd-usbss_mem + USBSS_IRQ_CLEARR
Hi Sarah,
On 24.09.2013 01:41, Sarah Sharp wrote:
The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I
plug in my USB headset. It worked fine on 3.11-rc4 (not sure about
vanilla 3.11).
Trying to manually load the driver fails:
sarah@xanatos:~$ sudo modprobe snd-usb-audio
-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c | 17 -
include/linux/usb/musb.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 2b9f4b4..f17604e 100644
--- a/drivers/usb/musb
called directly.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c| 7 +++
drivers/usb/musb/musb_core.h| 3 +++
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_virthub.c | 13 -
4 files changed, 20 insertions(+), 5 deletions(-)
diff
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb
only works with CONFIG_MUSB_PIO_ONLY
set. The cppi41 driver needs some more love to make this work. I'll
work on that next.
Thanks,
Daniel
Daniel Mack (4):
usb: musb: move port reset to worker
usb: musb: call musb_port_suspend from musb_bus_suspend
usb: musb: conditionally restore and resume
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
This makes am35x_pm_ops const and will stub the struct out in case
CONFIG_PM_SLEEP is not set.
Signed-off-by: Daniel Mack zon...@gmail.com
---
I'm resending this series because I've just learned that
SIMPLE_DEV_PM_OPS will stub itself out in case CONFIG_PM_SLEEP is
not set. That makes
This makes bfin_pm_ops const and will stub the struct out in case
CONFIG_PM_SLEEP is not set.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/blackfin.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb
This removes the DEV_PM_OPS macro and brings this file in line with the
other musb platform drivers.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/ux500.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/musb/ux500.c b/drivers/usb
On 26.09.2013 15:08, Daniel Mack wrote:
I've been working on some patches that allow suspending and resuming
the musb-dsps platform. This was tested for host mode only.
With these patches applied, I can successfully bring an AM335x board
to suspend with a USB media connected, and access
Hi Sebastian,
sorry for the long delay, I got distracted by other things.
On 26.09.2013 10:26, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-09-22 16:50:03 [+0200]:
cdd-cd and cdd-descs_phys are allocated DESCS_AREAS times from
init_descs() and freed as often from purge_descs
Use cppi41_pop_desc() when appropriate instead of open-coding the same
functionality again. That makes the code more readable. The function has
to be moved some lines up for this change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 23 +++
1 file
With active users over suspend/resume cycles, it turns out that
more registers, in particular DMA_TDFDQ and RXHPCRA0, have to be
restored on resume.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers
a comment on this? I'll post the musb patches
that are necessary as well now, and I'd appreciate more testers here.
Many thanks,
Daniel
Daniel Mack (3):
dma: cppi41: restore more registers
dma: cppi41: use cppi41_pop_desc() where possible
dma: cppi41: move -EAGAIN in tear_down
drivers/dma
to false.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 7747bf7..6decf34 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma/cppi41.c
@@ -586,6 +586,9
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c | 17 -
include/linux/usb/musb.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 2b9f4b4..f17604e 100644
--- a/drivers/usb/musb
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git
called directly.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c| 7 +++
drivers/usb/musb/musb_core.h| 3 +++
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_virthub.c | 13 -
4 files changed, 20 insertions(+), 5 deletions(-)
diff
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb
mode and CPPI41 enabled configurations,
together with my cppi41 patches that I posted here:
http://marc.info/?l=linux-usbm=138063429219730w=2
More testing is certainly appreciated.
Thanks,
Daniel
Daniel Mack (5):
usb: musb: move port reset to worker
usb: musb: call musb_port_suspend from
On 01.10.2013 16:59, Felipe Balbi wrote:
On Tue, Oct 01, 2013 at 03:39:57PM +0200, Daniel Mack wrote:
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core
This patch makes the edma driver resume correctly after suspend. Tested
on an AM33xx platform with cyclic audio streams.
The code was shamelessly taken from an ancient BSP tree.
Signed-off-by: Daniel Mack zon...@gmail.com
---
arch/arm/common/edma.c | 133
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb
On 30.09.2013 18:25, Felipe Balbi wrote:
On Fri, Sep 27, 2013 at 08:47:10PM +0200, Daniel Mack wrote:
So are you happy with this v2?
It's just a cosmetic cleanup after all ...
I can't see v2 anywhere... The only version I have is the one with
DEV_PM_OPS still in it.
Seen them this time
Hi Sebastian,
On 02.10.2013 10:29, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:31:11 [+0200]:
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 7747bf7..6decf34 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma/cppi41.c
@@ -586,6 +586,9 @@ static int
On 02.10.2013 12:20, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:31:08 [+0200]:
Patch #3, however, gives me headaches. I can't fully explain what's
going on, but I can tell for sure that if fixes a problem that I stared
on for many hours.
The problem is that on resume
On 02.10.2013 12:49, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:39:54 [+0200]:
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Sorry for asking this stupid
On 02.10.2013 12:46, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:39:53 [+0200]:
musb_port_reset() sleeps, so we can't call it from atomic context. It
is, however, called from places inside musb_hub_control() while
musb-lock is held, which leads to a scheduling while atomic
On 02.10.2013 12:25, Sebastian Andrzej Siewior wrote:
On 10/02/2013 11:19 AM, Daniel Mack wrote:
Once the system is booted up and the USB media is detected, I send the
system to sleep mode with cat mem /sys/power/state. After wakeup, I
access the media by mounting and unmounting it once
On 02.10.2013 14:01, Sebastian Andrzej Siewior wrote:
On 10/02/2013 01:14 PM, Daniel Mack wrote:
On 02.10.2013 12:49, Sebastian Andrzej Siewior wrote:
What happens if the device is unplugged while the host is suspended and
not there on resume?
That condition is detected and a full teardown
On 01.10.2013 21:32, Thomas Pugliese wrote:
This patch updates snd_usb_audio_create also support devices whose
speed == USB_SPEED_WIRELESS.
Interesting. What device are you testing this with?
Daniel
Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com
---
sound/usb/card.c |1
On 09.10.2013 08:41, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:31:08 [+0200]:
Patch #1 restores more registers on resume time.
Patch #2 is a cosmetic cleanup that emerged while digging through the
driver and gaining a basic idea of how it's implemented. Nothing fancy
On 09.10.2013 09:28, Sebastian Andrzej Siewior wrote:
On 10/09/2013 09:23 AM, Daniel Mack wrote:
Ok, thank you very much for the update :) I can of course test
alternative patches if you have any.
Could you actually reproduce the issue I described by sending your board
to suspend?
No, I
October 2013 09:58 AM, Joel Fernandes wrote:
On 10/01/2013 10:04 AM, Daniel Mack wrote:
AFAIK, Suspend/resume should be quick. Allocating and
deallocating on every iterating would be useless and time
consuming.
Nobody said allocate and deallocate on every iteration. Allocate
once during
On 10.10.2013 19:03, Sebastian Andrzej Siewior wrote:
On 10/10/2013 06:37 PM, Daniel Mack wrote:
Other than that, please make sure not to call that function more than
once for dual role mode.
A small hint please. We need it once in the hub code. So the host mode
works if no gadget is loaded
: Daniel Mack zon...@gmail.com
Cc: Peter Korsgaard jac...@sunsite.dk
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
Looks good to me - successfully tested on my host-only board.
Tested-by: Daniel Mack zon...@gmail.com
I'll rebase my suspend patches on top of them, address
there perfectly so I am not sure that it is a regression :)
Cc: Daniel Mack zon...@gmail.com
Cc: Peter Korsgaard jac...@sunsite.dk
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
Is this critical for the -rc or should we add the stable tag here ?
People seem to have
Hi,
On 10/16/2013 12:50 PM, Sebastian Andrzej Siewior wrote:
this is a new series of bug fixing:
FWIW, I've tested this and your previous series in a host-only
environment and it seems to work just fine.
I'll rework my suspend patches on top of them.
Thanks again,
Daniel
--
To unsubscribe
On 10/17/2013 04:20 PM, Sebastian Andrzej Siewior wrote:
On 10/17/2013 04:19 PM, Sebastian Andrzej Siewior wrote:
This patch changes the logic here to look on both queues for the
descriptor.
Daniel, could please look if this solves your suspend / resume warnings?
Will do (hopefully)
is
not crucial for this series.
* added another cosmetic cleanup patch (#5)
Daniel Mack (5):
usb: musb: call musb_port_suspend from musb_bus_suspend
usb: musb: conditionally save and restore the context on suspend
usb: musb: dsps: add {tx,rx}_mode to wrapper
usb: musb: dsps: add support
, so
this function has to be made non-static.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.h| 1 +
drivers/usb/musb/musb_dsps.c| 59 +
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_virthub.c | 2 +-
4
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
Just a cosmetic thing, no functional change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index ce5bbc6
-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c | 17 -
include/linux/usb/musb.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index e5ad77d..fea6ecd 100644
--- a/drivers/usb/musb
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git
On 10/18/2013 11:58 AM, Sebastian Andrzej Siewior wrote:
On 10/18/2013 11:39 AM, Daniel Mack wrote:
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index da21a4e..ce5bbc6 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -632,11
On 10/18/2013 11:59 AM, Sebastian Andrzej Siewior wrote:
On 10/18/2013 11:39 AM, Daniel Mack wrote:
v3 of my musb_dsps suspend patches.
With these patches applied, I can successfully bring an AM335x board
to suspend with a USB media connected, and access it again after
resume.
This works
On 10/09/2013 10:14 PM, Joel Fernandes wrote:
On 10/09/2013 09:12 AM, Joel Fernandes wrote:
On 10/09/2013 02:38 AM, Daniel Mack wrote:
[..]
(And the 'v3' in the subject is really my bad, sorry - I only sent one
version of this patch ever).
I can respin the patch on top of the proper driver
On 10/18/2013 11:59 AM, Sebastian Andrzej Siewior wrote:
On 10/18/2013 11:39 AM, Daniel Mack wrote:
v3 of my musb_dsps suspend patches.
With these patches applied, I can successfully bring an AM335x board
to suspend with a USB media connected, and access it again after
resume.
This works
On 10/18/2013 11:03 AM, Daniel Mack wrote:
Hi Sebastian,
On 10/17/2013 04:36 PM, Sebastian Andrzej Siewior wrote:
On 10/17/2013 04:23 PM, Daniel Mack wrote:
Daniel, could please look if this solves your suspend / resume warnings?
Looking very good :)
dma: cppi41: add support
Include linux/dma-mapping.h to make the new functions available that are
used since 22d9d8e83 (DMA-API: usb: use dma_set_coherent_mask()).
Signed-off-by: Daniel Mack zon...@gmail.com
---
I got the following error while building for PXA platforms from Linus'
current git head:
drivers/usb/host
On 11/15/2013 02:01 PM, Russell King - ARM Linux wrote:
On Fri, Nov 15, 2013 at 09:45:16AM +0100, Daniel Mack wrote:
Include linux/dma-mapping.h to make the new functions available that are
used since 22d9d8e83 (DMA-API: usb: use dma_set_coherent_mask()).
Signed-off-by: Daniel Mack zon
‘dma_coerce_mask_and_coherent’ [-Werror=implicit-function-declaration]
drivers/usb/host/ohci-pxa27x.c:310:2: error: implicit declaration of function
‘DMA_BIT_MASK’ [-Werror=implicit-function-declaration]
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/host/ohci-pxa27x.c | 1 +
1 file changed, 1
On 01.03.2013 22:57, Daniel Mack wrote:
Hi Afzal, everyone,
On 03.11.2012 08:33, Mohammed, Afzal wrote:
* Daniel Mack, November 03, 2012 1:06 AM:
I'm testing these patches with an AM33xx board that has the first musb
port wired to an USB type A plug, but it doesn't yet work for me.
So
On 02.03.2013 17:05, Koen Kooi wrote:
On Fri, 2013-03-01 at 22:57 +0100, Daniel Mack wrote:
Hi Afzal, everyone,
On 03.11.2012 08:33, Mohammed, Afzal wrote:
* Daniel Mack, November 03, 2012 1:06 AM:
I'm testing these patches with an AM33xx board that has the first musb
port wired to an USB
Hi Peter,
On 03.03.2013 23:24, Peter Korsgaard wrote:
Daniel == Daniel Mack zon...@gmail.com writes:
Hi,
Daniel On my board, the USB is purely used as host interface, with a
Daniel type B plug soldered. In the DT, I'm using the following
Daniel sniplet in accordance
On 04.03.2013 00:53, Daniel Mack wrote:
Hi Peter,
On 03.03.2013 23:24, Peter Korsgaard wrote:
Daniel == Daniel Mack zon...@gmail.com writes:
Hi,
Daniel On my board, the USB is purely used as host interface, with a
Daniel type B plug soldered. In the DT, I'm using the following
Daniel
On 07.03.2013 13:51, Daniel Mack wrote:
On 04.03.2013 00:53, Daniel Mack wrote:
Hi Peter,
On 03.03.2013 23:24, Peter Korsgaard wrote:
Daniel == Daniel Mack zon...@gmail.com writes:
Hi,
Daniel On my board, the USB is purely used as host interface, with a
Daniel type B plug soldered
On 19.03.2013 14:27, Peter Korsgaard wrote:
Daniel == Daniel Mack zon...@gmail.com writes:
Hi,
I know this patch reintroduces bits that have been intentionally
removed before, in particular by 032ec49f53 (usb: musb: drop
useless board_mode usage), but I don't know how this usb
Hi Felipe,
On 03.04.2013 14:04, Felipe Balbi wrote:
(sorry, being really busy lately)
On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote:
I know this patch reintroduces bits that have been intentionally
removed before, in particular by 032ec49f53 (usb: musb: drop
useless
On 03.04.2013 14:04, Felipe Balbi wrote:
On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote:
Felipe, could you explain the background on how the dsps driver is
supposed to work in host mode at boot time with the rework of the driver
you did for 3.7? It might just be me
On 03.04.2013 15:12, Koen Kooi wrote:
Op 3 apr. 2013, om 15:09 heeft Felipe Balbi ba...@ti.com het
volgende geschreven:
Hi,
On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote:
On 03.04.2013 14:04, Felipe Balbi wrote:
On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote
On 03.04.2013 17:19, Michael Trimarchi wrote:
Hi Daniel
On 03/04/13 17:00, Daniel Mack wrote:
Hi Michael,
On 03.04.2013 16:11, Michael Trimarchi wrote:
On 03/04/13 15:55, Michael Trimarchi wrote:
On 03/04/13 12:23, Daniel Mack wrote:
Hi David,
On 03.04.2013 12:15, David Henningsson
With the hcd is now a direct member of struct musb, we can now simply
eliminate the musb_to_hcd() macro. There aren't that many users left
anyway, as some where already fixed up when parts were factored out to
musb_host.c
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb
1 - 100 of 404 matches
Mail list logo
