Hi,
On Wed, Jul 17, 2013 at 11:37:35AM -0400, Alan Stern wrote:
On Wed, 17 Jul 2013, Felipe Balbi wrote:
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Jul 15, 2013
Hi,
On Thu, Jul 18, 2013 at 04:33:43PM +0800, Rong Wang wrote:
On Wed, Jul 17, 2013 at 9:27 PM, Felipe Balbi ba...@ti.com wrote:
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon
it generically to our struct usb_gadget,
so the details are hidden from all UDC drivers.
Signed-off-by: Felipe Balbi ba...@ti.com
---
Tested on OMAP5 uEVM.
drivers/usb/gadget/udc-core.c | 11 ++-
include/linux/usb/gadget.h| 4
2 files changed, 14 insertions(+), 1 deletion(-)
diff
Hi,
On Thu, Jul 18, 2013 at 11:40:41AM +0300, Felipe Balbi wrote:
The question is since we default GADGET, so the g_mass_storage.ko is
installed early but connecting to a host PC
is randomly, But the udev has no idea when a host PC connects our
device.
So we
On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
Hi Felipe,
Thanks, I'll test the patch.
But sysfs_notify(gadget-dev.kobj, NULL, status), status or state ?
I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
good eyes, please send a patch which I'll queue on
On Thu, Jul 18, 2013 at 06:54:38PM +0800, Rong Wang wrote:
Hi Felipe,
Here's the patch. If you are OK with it, I'll send it to the list formally.
Thanks.
-
usb: gadget: udc-core: make udc
Hi,
On Thu, Jul 18, 2013 at 04:18:08PM -0700, Sarah Sharp wrote:
Hi Felipe,
My bad, this patch got dropped. I've refreshed it against Greg's
usb-next branch. Do you still want me to push this?
Again, my apologies for dropping this.
Sure, this is necessary, at least, for the
Hi,
On Thu, Jul 18, 2013 at 09:53:22AM -0400, Alan Stern wrote:
On Thu, 18 Jul 2013, Felipe Balbi wrote:
usb_gadget_set_state() will call sysfs_notify()
which might sleep. Some users might want to call
usb_gadget_set_state() from the very IRQ handler
which actually changes the gadget
Hi,
On Thu, Jul 18, 2013 at 09:50:37AM -0400, Alan Stern wrote:
On Thu, 18 Jul 2013, Felipe Balbi wrote:
yes. Only the UDC driver knows when the controller is moving among those
states.
Not quite. Only the gadget driver knows when the transition between
ADDRESS
-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/ep0.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index 007651c..7fa93f4 100644
--- a/drivers/usb/dwc3/ep0.c
+++ b/drivers/usb/dwc3/ep0.c
@@ -148,6 +148,7
Two fixes for the state tracking mechanism implemented
in DWC3. Reported by Alan Stern.
None of these patches will be going to this -rc cycle
since it falls into 'has never worked before' category
and aren't really major bugs anyway.
Felipe Balbi (2):
usb: dwc3: ep0: only change to ADDRESS
-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/ep0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index e9d099c..007651c 100644
--- a/drivers/usb/dwc3/ep0.c
+++ b/drivers/usb/dwc3/ep0.c
@@ -551,7 +551,7 @@ static int
Hi,
On Mon, Jul 22, 2013 at 10:55:28AM -0400, Alan Stern wrote:
On Mon, 22 Jul 2013, Felipe Balbi wrote:
before changing to configured state, we need
to wait until gadget driver has had a chance
to process the request.
In case of USB_GADGET_DELAYED_STATUS, that means
we need
Hi,
On Mon, Jul 22, 2013 at 10:53:50AM -0400, Alan Stern wrote:
On Mon, 22 Jul 2013, Felipe Balbi wrote:
indeed. Added a flush_work() call to usb_del_gadget_udc()
Also, what happens if two state transitions occur before the work queue
gets around to executing the work routine
Hi,
On Tue, Jul 23, 2013 at 10:06:15AM -0400, Alan Stern wrote:
@@ -148,6 +148,7 @@ static int __dwc3_gadget_ep0_queue(struct dwc3_ep
*dep,
direction = !dwc-ep0_expect_in;
dwc-delayed_status = false;
+
Hi,
On Tue, Jul 23, 2013 at 12:53:53PM -0400, Alan Stern wrote:
I see. Doesn't the mass-storage gadget also use delayed status when
going into the _un_configured state?
no it doesn't, we bail out early if config number is zero, look at
composite.c and you'll see in case of
On Mon, Jun 24, 2013 at 06:27:44PM +0300, Ivan T. Ivanov wrote:
From: Ivan T. Ivanov iiva...@mm-sol.com
Cc: Felipe Balbi ba...@ti.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: linux-usb@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Ivan T. Ivanov iiva...@mm
Hi,
On Mon, Jul 01, 2013 at 04:03:41PM -0600, Stephen Warren wrote:
On 06/28/2013 03:36 PM, Tuomas Tynkkynen wrote:
Hi,
Here's a few cleanup patches for the Tegra USB drivers, to be applied on top
of Mikko's two patch sets. It mostly deals with removing all usage of
platform
data
On Tue, Jul 09, 2013 at 06:47:07PM +0300, Ivan T. Ivanov wrote:
From: Ivan T. Ivanov iiva...@mm-sol.com
This patch fix compilation error and is an intermediate step
before the addition of DeviceTree support for newer targets.
Fix suggested here: https://lkml.org/lkml/2013/6/19/381
Cc:
On Wed, Jul 24, 2013 at 03:34:43PM +0300, Felipe Balbi wrote:
On Tue, Jul 09, 2013 at 06:47:07PM +0300, Ivan T. Ivanov wrote:
From: Ivan T. Ivanov iiva...@mm-sol.com
This patch fix compilation error and is an intermediate step
before the addition of DeviceTree support for newer targets
Hi,
On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote:
From: Ivan T. Ivanov iiva...@mm-sol.com
Use managed device resources to clean up the probe/remove
and get DT support for free.
Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com
---
drivers/usb/phy/phy-msm-usb.c | 78
On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov wrote:
From: Ivan T. Ivanov iiva...@mm-sol.com
This patch move global regulators variables to driver state
structire and move allocation of the regulators to be devm managed.
split into two patches please. One for moving the global
On Thu, Jul 18, 2013 at 07:04:14PM -0400, Scott Jiang wrote:
Reset endpoint data toggle would lead to failure for musb
RTL version 1.9 on blackfin.
is this specific to musb 1.9 or to blackfin ?
--
balbi
signature.asc
Description: Digital signature
Hi,
On Thu, Jul 25, 2013 at 02:10:46AM +0400, Sergei Shtylyov wrote:
+ compatible = xhci-platform;
It again looks somewhat like a driver name, not a device name.
What made you change the value from usb-xhci, Al? Look at
[eo]hci-omap.txt in that directory.
I asked. usb-xhci is
HI,
On Wed, Jul 24, 2013 at 10:54:47AM -0700, Sarah Sharp wrote:
+#ifdef CONFIG_PM
+static int xhci_plat_suspend(struct device *dev)
+{
+ struct usb_hcd *hcd = dev_get_drvdata(dev);
+ struct xhci_hcd *xhci = hcd_to_xhci(hcd);
+
+ return
Hi,
On Thu, Jul 25, 2013 at 04:40:51PM +0300, Ivan T. Ivanov wrote:
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 6d05085..111f454 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -64,8 +64,8 @@ static int
Hi,
On Fri, Jul 05, 2013 at 03:32:54PM +0200, Sebastian Andrzej Siewior wrote:
The am335x PHY code is well hidden in multiple places. The glue layer
uses the nop and does up/down in the background. This patch copies the
power on / power off part out of dsps so it can be removed later in
dsps.
On Fri, Jul 05, 2013 at 04:56:17PM +0200, Sebastian Andrzej Siewior wrote:
On 07/05/2013 04:41 PM, Ruchika Kharwar wrote:
On 07/05/2013 08:32 AM, Sebastian Andrzej Siewior wrote:
The memory address contains three pieces that is the reset module which
is currently the only one used and
Hi,
On Fri, Jul 05, 2013 at 03:32:56PM +0200, Sebastian Andrzej Siewior wrote:
dsps uses a nop driver which is added in dsps itself and does the PHY
on/off calls within dsps. Since those calls are now moved the nop driver
itself, we can now request the phy proper phy and remove those calls.
On Fri, Jul 05, 2013 at 03:32:57PM +0200, Sebastian Andrzej Siewior wrote:
This moves the two instances from the big node into two child nodes. The
glue layer ontop does almost nothing.
This could be two indepentant child nodes but I have no idea how
'ti,hwmods = usb_otg_hs;' affects the two
On Fri, Jul 05, 2013 at 03:32:58PM +0200, Sebastian Andrzej Siewior wrote:
Remove the instances variable, there is no single use of it.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
nice :-)
--
balbi
signature.asc
Description: Digital signature
On Wed, Jul 24, 2013 at 02:01:27PM -0400, Alan Stern wrote:
On Wed, 24 Jul 2013, Felipe Balbi wrote:
Hi,
On Tue, Jul 23, 2013 at 12:53:53PM -0400, Alan Stern wrote:
I see. Doesn't the mass-storage gadget also use delayed status when
going into the _un_configured state
On Mon, Jul 22, 2013 at 08:09:52PM +0200, Sebastian Andrzej Siewior wrote:
If the init / shutdown function of the phy moves out of dsps into the
phy driver, then dsps needs to call the callbacks of the phy driver to
ensure that this happens.
Signed-off-by: Sebastian Andrzej Siewior
On Mon, Jul 22, 2013 at 08:09:53PM +0200, Sebastian Andrzej Siewior wrote:
The am335x PHY code is well hidden in multiple places. The glue layer
uses the nop and does up/down in the background. This patch copies the
power on / power off part out of dsps so it can be removed later in
dsps. At
Hi,
On Thu, Jul 25, 2013 at 10:28:37AM -0500, Bin Liu wrote:
Sebastian,
On Thu, Jul 25, 2013 at 10:16 AM, Sebastian Andrzej Siewior
bige...@linutronix.de wrote:
On 07/25/2013 05:12 PM, Bin Liu wrote:
Sebastian,
Hi Bin,
Is it really there or was it never there and it has been
Hi,
On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote:
This resolves the following valid build warning:
drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used
uninitialized in this function [-Wmaybe-uninitialized]
I switched from ? : to !! mostly to save from
On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote:
On Thu, Jul 25, 2013 at 9:14 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote:
This resolves the following valid build warning:
drivers/usb/gadget/at91_udc.c:1685:34
On Tue, Jul 16, 2013 at 02:20:51PM +0200, Andrzej Pietrasiewicz wrote:
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
return -ENOLOG;
--
balbi
signature.asc
Description: Digital signature
On Tue, Jul 16, 2013 at 02:21:23PM +0200, Andrzej Pietrasiewicz wrote:
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
return -ENOLOG;
--
balbi
signature.asc
Description: Digital signature
On Tue, Jul 16, 2013 at 02:21:24PM +0200, Andrzej Pietrasiewicz wrote:
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
return -ENOLOG;
--
balbi
signature.asc
Description: Digital signature
On Tue, Jul 16, 2013 at 02:21:25PM +0200, Andrzej Pietrasiewicz wrote:
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
return -ENOLOG;
--
balbi
signature.asc
Description: Digital signature
On Thu, Jul 18, 2013 at 11:53:05AM +0300, Roger Quadros wrote:
Till now we were modelling the RESET line as a voltage regulator and
using the regulator framework to manage it.
[1] introduces a GPIO based reset controller driver. We use that
to manage the PHY reset line, at least for DT
Hi,
On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey Khoroshilov wrote:
mv_u3d_nuke() expects to be calles with ep-u3d-lock held,
because mv_u3d_done() does. But mv_u3d_ep_disable() calls it
without lock that can lead to unpleasant consequences.
Found by Linux Driver Verification project
On Fri, Jul 19, 2013 at 12:28:13PM +0200, Andrzej Pietrasiewicz wrote:
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Introduced by commit 59835a (usb: gadget: multi: use
function framework for ACM.)
Signed-off-by:
Hi,
On Mon, Jul 15, 2013 at 05:28:56PM -0600, Stephen Warren wrote:
On 07/15/2013 01:53 PM, Tuomas Tynkkynen wrote:
Hi,
Here's a V2 of the few cleanup patches for the Tegra USB drivers, to be
applied
on top of Mikko's two patch sets. It mostly deals with removing all usage of
Hi,
On Thu, Jul 25, 2013 at 09:38:08PM +0300, Tuomas Tynkkynen wrote:
Use the new of_usb_get_phy_mode helper function for parsing phy_type
from the device tree.
Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com
Reviewed-by: Stephen Warren swar...@nvidia.com
Tested-by: Stephen Warren
Hi,
On Thu, Jul 25, 2013 at 10:11:16PM +0300, Tuomas Tynkkynen wrote:
Use the new of_usb_get_phy_mode helper function for parsing phy_type
from the device tree.
Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com
Reviewed-by: Stephen Warren swar...@nvidia.com
Tested-by: Stephen Warren
Hi,
On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote:
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 607bef8..50c833f 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -384,21 +384,6 @@ static int dwc3_probe(struct platform_device
On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote:
On Thu, 25 Jul 2013, Greg KH wrote:
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote:
From: Manu Gautam mgau...@codeaurora.org
The USB Embedded High-speed Host Electrical Test (EHSET) defines the
Hi,
On Fri, Jul 26, 2013 at 09:48:26AM +0300, Ivan T. Ivanov wrote:
Also, this is not *modifying* what was passed, just skipping the xHCI
address space so we don't request_mem_region() an area we won't really
handle and prevent xhci-hcd.ko from probing.
Hmm? platform_get_resource()
On Thu, Jul 25, 2013 at 01:59:51PM -0700, Olof Johansson wrote:
On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi ba...@ti.com wrote:
On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote:
That's what the code does today, and I wasn't trying to second-guess
their decisions
Hi,
On Fri, Jul 26, 2013 at 05:59:22PM +0800, Scott Jiang wrote:
Hi Balbi,
On Thu, Jul 18, 2013 at 07:04:14PM -0400, Scott Jiang wrote:
Reset endpoint data toggle would lead to failure for musb
RTL version 1.9 on blackfin.
is this specific to musb 1.9 or to blackfin ?
I'm not sure
On Fri, Jul 26, 2013 at 03:31:34PM +0300, Ivan T. Ivanov wrote:
Hi Felipe,
On Thu, 2013-07-25 at 16:43 +0300, Ivan T. Ivanov wrote:
On Wed, 2013-07-24 at 15:39 +0300, Felipe Balbi wrote:
On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov wrote:
From: Ivan T. Ivanov iiva...@mm
On Fri, Jul 26, 2013 at 09:23:35AM -0700, Olof Johansson wrote:
On Fri, Jul 26, 2013 at 2:54 AM, Felipe Balbi ba...@ti.com wrote:
On Thu, Jul 25, 2013 at 01:59:51PM -0700, Olof Johansson wrote:
On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi ba...@ti.com wrote:
On Thu, Jul 25, 2013 at 09:18
Hi,
On Fri, Jul 26, 2013 at 06:44:23PM +, Paul Zimmerman wrote:
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Friday, July 26, 2013 2:54 AM
Also, this is not *modifying* what was passed, just skipping the xHCI
address space so we don't request_mem_region() an area we won't
Hi Greg,
Here's my second set of fixes. Nothing major, mostly
related to recent conversion to configfs on the gadget
framework.
Let me know if you want me to change anything.
The following changes since commit 690c70bab1ebab0782cf9c316b726e2dddebc411:
usb: phy: omap-usb3: fix dpll clock
On Fri, Jul 26, 2013 at 10:15:54PM +0200, Sebastian Andrzej Siewior wrote:
The nop driver isn't a do-nothing-stub but supports a couple functions
like clock on/off or is able to use a voltage regulator. This patch
simply renames the driver to generic since it is easy possible to
extend it by a
On Fri, Jul 26, 2013 at 10:15:55PM +0200, Sebastian Andrzej Siewior wrote:
This patch copies the phy support bits from dsps into the generic phy
driver. Most code can be re-used except for the on/off.
The additional am335x can be removed once we have a phy driver that does
more than this.
Hi,
On Mon, Jul 29, 2013 at 10:04:21AM +0300, Ivan T. Ivanov wrote:
motg-irq = platform_get_irq(pdev, 0);
- if (!motg-irq) {
+ if (motg-irq 0) {
looks like this particular hunk isn't part of $subject.
--
balbi
signature.asc
Description: Digital signature
Hi,
On Fri, Jul 26, 2013 at 07:26:05PM +0400, Alexey Khoroshilov wrote:
On 07/25/2013 09:30 PM, Felipe Balbi wrote:
On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey Khoroshilov wrote:
mv_u3d_nuke() expects to be calles with ep-u3d-lock held,
because mv_u3d_done() does
On Mon, Jul 29, 2013 at 05:15:58PM +0400, Alexey Khoroshilov wrote:
On 07/29/2013 04:52 PM, Felipe Balbi wrote:
Hi,
On Fri, Jul 26, 2013 at 07:26:05PM +0400, Alexey Khoroshilov wrote:
On 07/25/2013 09:30 PM, Felipe Balbi wrote:
On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey
On Mon, Jul 29, 2013 at 04:52:12PM +0300, Felipe Balbi wrote:
On Mon, Jul 29, 2013 at 05:15:58PM +0400, Alexey Khoroshilov wrote:
On 07/29/2013 04:52 PM, Felipe Balbi wrote:
Hi,
On Fri, Jul 26, 2013 at 07:26:05PM +0400, Alexey Khoroshilov wrote:
On 07/25/2013 09:30 PM, Felipe Balbi
Hi,
On Fri, Jul 26, 2013 at 02:33:38PM +0530, Kishon Vijay Abraham I wrote:
Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating
MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the
device name of the controller had *.auto* in it. Since with
Hi,
On Mon, Jul 29, 2013 at 08:59:26PM +0530, Kishon Vijay Abraham I wrote:
Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while
creating
MUSB core device. So in usb_bind_phy (binds the controller with the PHY),
the
device name of the controller had *.auto* in it.
On Mon, Jul 29, 2013 at 09:24:46AM -0600, Stephen Warren wrote:
On 06/28/2013 06:33 AM, Mikko Perttunen wrote:
Add vbus-supply as an optional property for host mode phy-tegra-usb PHYs.
Felipe, I see that you didn't merge this one patch from this series. Was
there a reason for that? At this
Hi,
On Tue, Jul 30, 2013 at 10:44:48AM +0530, Kishon Vijay Abraham I wrote:
On Mon, Jul 29, 2013 at 08:59:26PM +0530, Kishon Vijay Abraham I wrote:
Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while
creating
MUSB core device. So in usb_bind_phy (binds the controller
. In order to fix
the error, we update the IS_ENABLED() check in
include/linux/usb/of.h to reflect the condition
where of.c is built.
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Felipe Balbi ba...@ti.com
---
include/linux/usb/of.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi,
On Tue, Jul 30, 2013 at 11:41:23AM +0530, Kishon Vijay Abraham I wrote:
diff --git a/arch/arm/mach-omap2/board-2430sdp.c
b/arch/arm/mach-omap2/board-2430sdp.c
index 244d8a5..17bb076 100644
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@
On Mon, Jul 29, 2013 at 02:44:13PM -0700, Julius Werner wrote:
This patch simplifies the way the phy-samsung-usb code finds the correct
power management register to enable PHY clock gating. Previously, the
code would calculate the register address from a device tree supplied
base address and
Hi,
On Tue, Jul 30, 2013 at 11:55:04AM +0530, Kishon Vijay Abraham I wrote:
On Tue, Jul 30, 2013 at 11:41:23AM +0530, Kishon Vijay Abraham I wrote:
diff --git a/arch/arm/mach-omap2/board-2430sdp.c
b/arch/arm/mach-omap2/board-2430sdp.c
index 244d8a5..17bb076 100644
---
On Tue, Jul 30, 2013 at 07:54:02AM +0800, Wei Yongjun wrote:
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return -EINVAL in the vendor param set error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
this
On Tue, Jul 30, 2013 at 09:10:12AM +0300, Mikko Perttunen wrote:
On 07/30/2013 12:23 AM, Felipe Balbi wrote:
* PGP Signed by an unknown key
Hi,
On Tue, Jul 30, 2013 at 12:19:32AM +0300, Felipe Balbi wrote:
On Mon, Jul 29, 2013 at 09:24:46AM -0600, Stephen Warren wrote:
On 06/28/2013 06
On Tue, Jul 30, 2013 at 09:38:44AM +0300, Mikko Perttunen wrote:
Signed-off-by: Mikko Perttunen mperttu...@nvidia.com
return -ENOLOG;
sorry, I can't apply without a commit log. Please mention that the
previous commit had a typo which you're fixing.
--
balbi
signature.asc
Description:
On Sun, Jul 21, 2013 at 08:46:53AM -0700, Greg KH wrote:
On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote:
On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote:
Hi,
On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote:
Hi,
On Saturday 20 of July 2013
Hi,
On Tue, Jul 30, 2013 at 12:16:20PM +0530, Kishon Vijay Abraham I wrote:
the list of controller device (names) it can support (PHY framework does
not
maintain a separate list for binding like how we had in USB PHY
library). e.g.
Hi,
On Tue, Jul 30, 2013 at 05:00:18PM +0900, Jingoo Han wrote:
diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
index 8747fa6..d42ec85 100644
--- a/drivers/usb/host/ohci-omap.c
+++ b/drivers/usb/host/ohci-omap.c
@@ -191,7 +191,8 @@ static void start_hnp(struct
On Tue, Jul 30, 2013 at 01:41:23PM +0530, Kishon Vijay Abraham I wrote:
On Tuesday 30 July 2013 12:46 PM, Felipe Balbi wrote:
Hi,
On Tue, Jul 30, 2013 at 12:16:20PM +0530, Kishon Vijay Abraham I wrote:
the list of controller device (names) it can support (PHY framework
does
-self.controller);
no need to break the line here.
Hi Felipe Balbi,
I did it in order to remove the following checkpatch warning. :(
WARNING: line over 80 characters
#194: FILE: usb/host/ohci-omap.c:194:
+ struct omap_usb_config *config =
dev_get_platdata(hcd-self.controller
On Tue, Jul 30, 2013 at 05:54:26PM +0900, Jingoo Han wrote:
On Tuesday, July 30, 2013 5:44 PM, Felipe Balbi wrote:
On Tue, Jul 30, 2013 at 05:37:03PM +0900, Jingoo Han wrote:
diff --git a/drivers/usb/host/ohci-omap.c
b/drivers/usb/host/ohci-omap.c
index 8747fa6..d42ec85 100644
.
quite a few typos here, could you fix them ?
other than that, looks good to my eyes:
Reviewed-by: Felipe Balbi ba...@ti.com
--
balbi
signature.asc
Description: Digital signature
On Tue, Jul 30, 2013 at 07:54:55PM +0530, George Cherian wrote:
On 7/30/2013 2:23 PM, Sebastian Andrzej Siewior wrote:
On 07/30/2013 07:19 AM, George Cherian wrote:
So from what I see now, it is most likely the easiest thing to just add
that wakeup to the phy driver I posted. Do you agree?
Hi,
On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote:
IMHO we need a lookup method for PHYs, just like for clocks,
regulators, PWMs or even i2c busses because there are complex cases
when passing just a name using platform data will not work. I would
second what
Use the wrapper function for retrieving the
platform_data instead of accessing dev-platform_data
directly.
Inspired-by: Jingoo Han jg1@samsung.com
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi,
On Wed, Jul 31, 2013 at 06:26:24PM +0800, Scott Jiang wrote:
On Thu, Jul 18, 2013 at 07:04:14PM -0400, Scott Jiang wrote:
Reset endpoint data toggle would lead to failure for musb
RTL version 1.9 on blackfin.
is this specific to musb 1.9 or to blackfin ?
I'm not sure about
On Wed, Jul 31, 2013 at 05:34:52PM +0400, Sergei Shtylyov wrote:
Hello.
On 31-07-2013 10:22, Felipe Balbi wrote:
Use the wrapper function for retrieving the
platform_data instead of accessing dev-platform_data
directly.
Inspired-by: Jingoo Han jg1@samsung.com
Signed-off
Hi,
On Wed, Jul 31, 2013 at 11:45:48PM +0400, Sergei Shtylyov wrote:
Sergei, Felipe, do you have a strong preference on this name? Or should
I take the patch as is?
I've already said I don't have a strong preference.
I don't have a strong preference either, just think that adding the
: Felipe Balbi ba...@ti.com
usb: gadget: add transfer support flags for struct usb_ep
NYET-Signed-off-by: Felipe Balbi ba...@ti.com
---
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index f168eae..0bc3621 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
Hi,
On Thu, Aug 01, 2013 at 12:29:55PM +0300, Felipe Balbi wrote:
Hi folks,
as we all know naming conventions are fragile and easy to break. We've
had weird endpoint naming conventions for far too long in the gadget
framework.
I'm trying to come up with means to get rid of that and, one
On Thu, Aug 01, 2013 at 11:47:56AM +0200, Sebastian Andrzej Siewior wrote:
On 08/01/2013 11:29 AM, Felipe Balbi wrote:
Hi folks,
Hi felipe,
as we all know naming conventions are fragile and easy to break.
We've had weird endpoint naming conventions for far too long in the
gadget
Hi
On Thu, Aug 01, 2013 at 12:31:55PM +0200, Andrzej Pietrasiewicz wrote:
On Wednesday, June 12, 2013 5:17 PM Felipe Balbi wrote:
Hi,
This is a note to let you know that the patch:
usb: gadget: cdc2: convert to new interface of f_ecm
has been applied to my tree and can
Hi,
On Thu, Aug 01, 2013 at 12:40:47PM +0200, Andrzej Pietrasiewicz wrote:
This fixes commit a38a275030086d95306555e544fc7c0e65ccd00e.
The invocation of usb_get_function_instance() is in cdc_bind()
and should not be repeated in cdc_do_config().
Signed-off-by: Andrzej Pietrasiewicz
Hi,
On Thu, Aug 01, 2013 at 11:44:59AM -0400, Alan Stern wrote:
On Thu, 1 Aug 2013, Felipe Balbi wrote:
Hi folks,
as we all know naming conventions are fragile and easy to break. We've
had weird endpoint naming conventions for far too long in the gadget
framework.
I'm trying
Hi,
On Thu, Aug 01, 2013 at 11:58:30AM -0400, Alan Stern wrote:
The endpoint naming convention currently determines type and direction.
It works okay for simple cases but not for more complicated ones. For
example, it can't handle endpoints that support bulk or interrupt but
not
Hi,
+linux-usb
Always add linux-usb
On Fri, Aug 02, 2013 at 05:33:32AM +, Wang, Yu Y wrote:
We are the USB3 driver developers from Intel. And also base on
Synopsys DWC USB3 OTG controller.
good to see Intel is also using my driver.
We base on your driver to enabled hibernation feature
Hi,
On Fri, Aug 02, 2013 at 01:15:33PM +0800, Qiao Zhou wrote:
On 08/01/2013 06:21 PM, Qiao Zhou wrote:
v2-v1:
stop pcm stream instead of wake up the sleep thread, which is more
reasonable.
Qiao Zhou (1):
usb: gadget: audio file: wake up sleep thread when device unbind
Hi,
On Fri, Aug 02, 2013 at 04:33:12PM +0900, Jingoo Han wrote:
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
when the CONFIG_PM_SLEEP
Hi,
On Thu, Aug 01, 2013 at 02:54:35PM +0530, Sachin Kamat wrote:
Updated the documentation as per the latest driver implementation.
While at it also fixed some trivial typos.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
this can go through DeviceTree maintainers:
Acked-by: Felipe
Hi,
On Thu, Aug 01, 2013 at 07:07:50PM +0200, Boris BREZILLON wrote:
@@ -1851,6 +1860,12 @@ fail3:
fail2:
free_irq(udc-udp_irq, udc);
fail1:
+ if (IS_ENABLED(CONFIG_COMMON_CLK) !IS_ERR(udc-uclk))
+ clk_put(udc-uclk);
+ if (!IS_ERR(udc-fclk))
+
On Fri, Aug 02, 2013 at 04:47:04PM +0900, Jingoo Han wrote:
On Friday, August 02, 2013 4:38 PM, Felipe Balbi wrote:
On Fri, Aug 02, 2013 at 04:33:12PM +0900, Jingoo Han wrote:
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP
Hi,
On Thu, Aug 01, 2013 at 05:52:04PM -0700, Julius Werner wrote:
This patch simplifies the way the phy-samsung-usb code finds the correct
power management register to enable PHY clock gating. Previously, the
code would calculate the register address from a device tree supplied
base address
1 - 100 of 7378 matches
Mail list logo
