Re: Build regressions/improvements in v3.11-rc3

2013-07-30 Thread Geert Uytterhoeven
On Tue, 30 Jul 2013, Geert Uytterhoeven wrote: JFYI, when comparing v3.11-rc3 to v3.11-rc2[3], the summaries are: - build errors: +38/-14 + arch/powerpc/kvm/book3s_emulate.c: error: 'bat' may be used uninitialized in this function [-Werror=uninitialized]: = 349:2 + arch/powerpc/kvm

[PATCH 1/4] usb: gadget: USB_FUSB300 should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `fusb300_set_idma': drivers/usb/gadget/fusb300_udc.c:946: undefined reference to `usb_gadget_map_request' drivers/usb/gadget/fusb300_udc.c:958: undefined reference to `usb_gadget_unmap_request' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org

[PATCH 2/4] usb: gadget: USB_R8A66597 should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
to `usb_gadget_map_request' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/gadget/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index d2e6f4f..3c1cadd 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig

[PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma-mapping.h:93: undefined reference to `dma_supported' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/chipidea/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 3/4] usb: gadget: USB_NET2272_DMA should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/gadget/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 3c1cadd..324dc61 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus

Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-27 Thread Geert Uytterhoeven
On Tue, Aug 27, 2013 at 9:16 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Aug 19, 2013 at 09:24:01AM +0800, Peter Chen wrote: On Sun, Aug 18, 2013 at 10:20:44PM +0200, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma

[PATCH 12/12] usb: host: Remove superfluous name casts

2013-11-12 Thread Geert Uytterhoeven
device_driver.name is const char * Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org --- drivers/usb/host/imx21-hcd.c|2 +- drivers/usb/host/isp116x-hcd.c |2 +- drivers/usb/host/isp1362-hcd.c

[PATCH] usb: gadget: multi: Mark {cdc,rndis}_config_register() __init

2013-04-24 Thread Geert Uytterhoeven
harmless, as {cdc,rndis}_config_register() are only called from multi_bind(), which is annotated with __ref. Mark {cdc,rndis}_config_register() with the __init annotation to kill the warning. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- Note: I did not verify that multi_bind

Re: [PATCH 01/28] Remove CPU_MMP3

2014-02-11 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus

[PATCH] USB2NET : SR9800 : Use %zu to format size_t

2014-02-17 Thread Geert Uytterhoeven
On 32-bit: drivers/md/bcache/bset.c: In function ‘bch_dump_bset’: drivers/md/bcache/bset.c:27: warning: format ‘%li’ expects type ‘long int’, but argument 3 has type ‘int’ Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/net/usb/sr9800.c |2 +- 1 file changed, 1 insertion

[PATCH] usb: musb: USB_MUSB_DUAL_ROLE/USB_MUSB_GADGET should depend on HAS_DMA

2014-02-21 Thread Geert Uytterhoeven
:(.text+0x35a9c8): undefined reference to `dma_sync_single_for_cpu' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/musb/Kconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 688dc8bb192d..8b789792f6fa 100644

Re: SPDX-License-Identifier

2014-02-25 Thread Geert Uytterhoeven
suspect going to happen! That's gonna be a BIG Linux Lawyer Summit ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [BUG] 2.6.24-git usb reset problems

2008-01-30 Thread Geert Uytterhoeven
; unsigned short use_sg; int resid; With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone:+32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: [EMAIL

Re: Build regressions/improvements in v3.5

2012-08-03 Thread Geert Uytterhoeven
On Fri, Aug 3, 2012 at 4:06 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: JFYI, when comparing v3.5 to v3.5-rc7[3], the summaries are: - build errors: +6/-9 - build warnings: +105/-5443 + drivers/staging/ccg/../../usb/gadget/f_mass_storage.c: error: implicit declaration of function

[PATCH] console/font: Refactor font support code selection logic

2013-05-15 Thread Geert Uytterhoeven
to `.find_font' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/media/platform/Kconfig |2 +- drivers/staging/media/solo6x10/Kconfig |2 ++ drivers/usb/misc/sisusbvga/Kconfig |1 + drivers/video/console/Kconfig | 12 ++-- drivers/video

[PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Geert Uytterhoeven
for other busses (e.g. MOUSE_SYNAPTICS_I2C) already handle this in a similar way. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/input/joystick/Kconfig|3 +-- drivers/input/misc/Kconfig| 15 +-- drivers/input/mouse/Kconfig |9 +++-- drivers

[PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

2013-07-10 Thread Geert Uytterhoeven
`.exit.text' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o make[3]: *** [vmlinux] Error 1 Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/gadget/fotg210-udc.c |4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

2013-07-11 Thread Geert Uytterhoeven
On Wed, Jul 10, 2013 at 11:52 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: On 07/11/2013 01:45 AM, Geert Uytterhoeven wrote: When builtin (CONFIG_USB_FOTG210_UDC=y): LD drivers/usb/gadget/built-in.o WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-07-11 Thread Geert Uytterhoeven
incorrectly doesn't depend on HAS_DMA. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer

[PATCH 3/6] usb: gadget: USB_MV_UDC should depend on HAS_DMA

2013-07-11 Thread Geert Uytterhoeven
/usb/gadget/mv_udc_core.c:2317: undefined reference to `dma_free_coherent' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/gadget/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index

[PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA

2013-07-11 Thread Geert Uytterhoeven
reference to `dma_map_single' drivers/usb/gadget/udc-core.c:74: undefined reference to `dma_mapping_error' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- This one is very debatable: probably the parts using the DMA API should be factored out, instead of disabling the whole USB gadget

[PATCH 1/6] usb: dwc3: USB_DWC3 should depend on HAS_DMA

2013-07-11 Thread Geert Uytterhoeven
reference to `dma_alloc_coherent' drivers/usb/dwc3/gadget.c:2667: undefined reference to `dma_free_coherent' drivers/usb/dwc3/gadget.c:2674: undefined reference to `dma_free_coherent' drivers/usb/dwc3/gadget.c:2678: undefined reference to `dma_free_coherent' Signed-off-by: Geert Uytterhoeven ge...@linux

[PATCH 4/6] usb: gadget: USB_FOTG210_UDC should depend on HAS_DMA

2013-07-11 Thread Geert Uytterhoeven
to `dma_sync_single_for_cpu' drivers/usb/gadget/fotg210-udc.c:376: undefined reference to `dma_unmap_single' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/gadget/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index

Re: [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA

2013-07-12 Thread Geert Uytterhoeven
Hi Alan, On Thu, Jul 11, 2013 at 5:51 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 11 Jul 2013, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma-mapping.h:93: undefined reference to `dma_supported' include/linux

[PATCH/RFC] usb: gadget: CONFIG_USB_S3C_HSOTG should depend on HAS_DMA

2014-05-06 Thread Geert Uytterhoeven
to optimize the check away, causing a link error. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- Perhaps the DMA code should be removed completely, as its unused, or be protected by #ifdef CONFIG_HAS_DMA instead? drivers/usb/gadget/Kconfig |1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH/RFC] usb: gadget: CONFIG_USB_S3C_HSOTG should depend on HAS_DMA

2014-05-06 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-19 Thread Geert Uytterhoeven
()? If you want to keep it, I would rewrite it as for (data = 0, j = 3; j = 0; j--) { if ((j + index) fw-size) data |= fw-data[index + j] (8 * j); } Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH 3/3] Documentation: dt-bindings: update xhci-platform DT binding for R-Car H2 and M2

2014-05-19 Thread Geert Uytterhoeven
is available in the R-Car H2 and M2 SoCs. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [PATCH 1/3] usb: host: xhci-plat: add xhci_plat_start()

2014-05-19 Thread Geert Uytterhoeven
() function. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, May 20, 2014 at 11:35 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: (2014/05/19 20:58), Geert Uytterhoeven wrote: On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: snip +config USB_XHCI_RCAR + tristate

Re: [Celinux-dev] PDF documentation

2012-10-17 Thread Geert Uytterhoeven
get my hands on. They will disappear from the web. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I

Re: [PATCH] usb: usb5303: make use of uninitialized err variable

2014-06-11 Thread Geert Uytterhoeven
On Mon, Jun 2, 2014 at 7:45 PM, Emil Goode emilgo...@gmail.com wrote: The variable err is not initialized here, this patch uses it to store an eventual error value from devm_clk_get(). Signed-off-by: Emil Goode emilgo...@gmail.com Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje

Re: [PATCH] usb: usb5303: make use of uninitialized err variable

2014-07-10 Thread Geert Uytterhoeven
Goode emilgo...@gmail.com Acked-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/usb/misc/usb3503.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) This patch fails to apply to my tree :( You've already applied commit ec5734c41bee2ee7c938a8f34853d31cada7e67a Author

[PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA

2014-08-29 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `usbhsg_dma_map_ctrl': mod_gadget.c:(.text+0x53b226): undefined reference to `usb_gadget_map_request' mod_gadget.c:(.text+0x53b242): undefined reference to `usb_gadget_unmap_request' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers

Re: [PATCH v2] usb: renesas_usbhs: fix driver dependencies

2014-09-01 Thread Geert Uytterhoeven
...@samsung.com Cc: Simon Horman ho...@verge.net.au Cc: Magnus Damm magnus.d...@gmail.com --- v2: - s/ARCH_SH/SUPERH/ (thanks to Sergei Shtylyov) Acked-by: Geert Uytterhoeven geert+rene...@glider.be Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots

Re: [GIT PULL] USB changes for v3.18 merge window

2014-09-29 Thread Geert Uytterhoeven
' undeclared here (not in a function) make[5]: *** [drivers/usb/gadget/function/uvc_v4l2.o] Error 1 http://kisskb.ellerman.id.au/kisskb/buildresult/12028115/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal

[PATCH] usb: gadget: USB_GADGET_XILINX should depend on HAS_DMA

2014-10-09 Thread Geert Uytterhoeven
: In function `xudc_read_fifo': udc-xilinx.c:(.text+0x54ff4a): undefined reference to `dma_sync_single_for_cpu' drivers/built-in.o: In function `xudc_ep_queue': udc-xilinx.c:(.text+0x550e7c): undefined reference to `usb_gadget_map_request' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers

Re: [PATCH] usb: host: xhci-plat: fix suspend/resume on xhci-rcar

2014-10-10 Thread Geert Uytterhoeven
looks like an area for improvement. As the individual udelay() calls wait for only 1 us, the __bad_udelay() sanity check Use only for very small delays ( 2 msec) doesn't kick in. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

[PATCH/TRIVIAL 4/4] uwb: Remove bogus colon after newline from debug message

2014-10-23 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Cc: linux-usb@vger.kernel.org --- drivers/uwb/rsv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/uwb/rsv.c b/drivers/uwb/rsv.c index 0887ae982783b7df..536ad42b0a4b1d7e 100644 --- a/drivers/uwb/rsv.c +++ b

Re: [PATCH] extcon: add MAX3355 driver

2014-12-11 Thread Geert Uytterhoeven
On Thu, Dec 11, 2014 at 2:46 AM, Chanwoo Choi cw00.c...@samsung.com wrote: Could you send the datasheet of MAX3355E to me? First Google hit: http://datasheets.maximintegrated.com/en/ds/MAX3355E.pdf Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: usb: gadget: hid: add configfs support

2014-12-15 Thread Geert Uytterhoeven
to use 2^8-1 for the first two limits, and 2^16 (without -1) for the third limit. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm

Re: [PATCH] usb: gadget: hid: consistently use 2^n - 1 for max values

2014-12-15 Thread Geert Uytterhoeven
On Mon, Dec 15, 2014 at 1:50 PM, Andrzej Pietrasiewicz andrze...@samsung.com wrote: A maximum value which fits in 16 bits, unsigned, is 65535. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s

Re: [PATCH 4/4] PM: Eliminate CONFIG_PM_RUNTIME

2014-12-19 Thread Geert Uytterhoeven
CONFIG_PM_STD_PARTITION=/dev/hda3 -CONFIG_PM_RUNTIME=y +CONFIG_PM=y ^^^ Now we have two of them CONFIG_CPU_FREQ=y CONFIG_CPU_FREQ_DEBUG=y CONFIG_CPU_FREQ_STAT=m Other defconfig files may be affected, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots

Re: [PATCH v2] renesas_usbhs: fix platform init error message

2015-01-05 Thread Geert Uytterhoeven
-lpatches, publish them in a git tree, and ask GregKH to pull a branch or tag from your git tree, 3. You ack all accepted patches, so GregKH knows which patches to apply. Which way to choose depends on the volume of patches. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven

Re: [PATCH 1/4] usb: renesas_usbhs: fix spinlock recursion by usbhsf_dma_complete()

2015-02-10 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus Torvalds

Re: [PATCH 4/4] usb: renesas_usbhs: add support for USB-DMAC

2015-02-10 Thread Geert Uytterhoeven
, has_usb_dmac) len 0x7) goto usbhsf_pio_prepare_push; So the has_usb_dmac flags indicates that DMA addresses are not limited to 8-byte alignment. Can't this be handled by looking at a dma_mask, as set by the DMAC? Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

2015-02-16 Thread Geert Uytterhoeven
(). +*/ + local_irq_save(flags); usb_gadget_giveback_request(uep-ep, ureq-req); + local_irq_restore(flags); } static void usbhsg_queue_done(struct usbhs_priv *priv, struct usbhs_pkt *pkt) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven

Re: [PATCH] usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()

2015-01-30 Thread Geert Uytterhoeven
it also causes other problems? The return value of usbhsf_dma_chan_get() is not checked for an error code in many callsites. Reported-by: Simon Horman ho...@verge.net.au Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Acked-by: Geert Uytterhoeven ge...@linux-m68k.org

[PATCH] usb: phy: Remove the phy-rcar-gen2-usb driver

2015-04-28 Thread Geert Uytterhoeven
: Renesas R-Car Gen2 PHY driver). Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- drivers/usb/phy/Kconfig | 13 -- drivers/usb/phy/Makefile| 1 - drivers/usb/phy/phy-rcar-gen2-usb.c | 246 include/linux

Re: [PATCH] usb: phy: rcar-gen2-usb: Fix USBHS_UGSTS_LOCK value

2015-04-28 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus Torvalds

Re: [PATCH] usb: phy: Remove the phy-rcar-gen2-usb driver

2015-04-28 Thread Geert Uytterhoeven
Hi Felipe, On Tue, Apr 28, 2015 at 6:50 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Apr 28, 2015 at 02:04:07PM +0200, Geert Uytterhoeven wrote: The phy-rcar-gen2-usb driver, which supports legacy platform data only, is no longer used since commit a483dcbfa21f919c (ARM: shmobile: lager

Re: [PATCH] usb: phy: rcar-gen2-usb: Fix USBHS_UGSTS_LOCK value

2015-04-28 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [PATCH v2 2/2] usb: renesas_usbhs: Add support for R-Car E2

2015-05-18 Thread Geert Uytterhoeven
On Mon, May 18, 2015 at 1:04 PM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: This patch adds a compatible string to support for R-Car E2. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Acked-by: Geert Uytterhoeven geert+rene...@glider.be in patch 2

Re: [PATCH] usb: renesas_usbhs: Revise the binding document about the dma-names

2015-04-09 Thread Geert Uytterhoeven
this patch fixes the actual code of renesas_usbhs driver to handle the new dma-names. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Acked-by: Geert Uytterhoeven geert+rene...@glider.be Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: [PATCH v2] usb: phy: msm: Add D+/D- lines route control

2015-08-03 Thread Geert Uytterhoeven
configuration sequence values. This is related to Device Mode Eye Diagram test. Start address at which these values will be written is ULPI_EXT_VENDOR_SPECIFIC. Value of -1 is reserved as Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven

Re: [PATCH/RFC] usb: gadget: udc: core: Fix argument of dma_map_single for IOMMU

2015-07-13 Thread Geert Uytterhoeven
something that has already been accepted into Felipe's tree? That commit ID does not refer to Shimoda-san's patch, but to the HEAD of Felipe's testing/next branch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [GIT PULL] On-demand device probing

2015-10-24 Thread Geert Uytterhoeven
while people still stumble on obscure subsystems and drivers not supporting probe deferral. Usually they don't fail with a big bang, so everything seems fine. E.g. last week's "of_mdiobus_register_phy() and deferred probe" (https://lkml.org/lkml/2015/10/22/377). Gr{oetje,eeting}s,

Re: [GIT PULL] On-demand device probing

2015-10-19 Thread Geert Uytterhoeven
deferred messages up to > that point, and secondly printing the reason why the remaining > deferrals are happening. > > That should be a small number of new lines plus a one-line change > in subsystems and drivers. Apart from the extra round we probably can't get rid of, that sounds OK to

Re: [GIT PULL] On-demand device probing

2015-10-21 Thread Geert Uytterhoeven
rollers are > enumerated in a special way. What does "in a special way" mean? Can you please be more specific? Can you have interrupt controllers that depend on clocks, pin controllers, and PM domains? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There'

[PATCH 3/3] gpio: rcar: Remove obsolete platform data support

2015-10-07 Thread Geert Uytterhoeven
irq_parent down while we're at it, to prevent gaps on 64-bit. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- Commit 4baadb9e05c68962 is now in arm-soc/for-next. --- drivers/gpio/gpio-rcar.c| 77 +++-- include/linux/platform_data/

[PATCH 0/3] gpio: rcar: Remove obsolete platform data support

2015-10-07 Thread Geert Uytterhoeven
ta anymore, hence this driver removes platform data configuration. Unfortunately the platform data header file is used in a few other places, so we have to fix these first to avoid breaking the build. Thanks! Geert Uytterhoeven (3): usb: renesas_usbhs: Remove unneeded #include pinctrl: sh

[PATCH 1/3] usb: renesas_usbhs: Remove unneeded #include

2015-10-07 Thread Geert Uytterhoeven
This header file will be removed soon. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- Please schedule for v4.3, or provide an Ack, so it can go in through the GPIO tree. Thanks! --- drivers/usb/renesas_usbhs/rcar2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[PATCH 2/3] pinctrl: sh-pfc: Stop including

2015-10-07 Thread Geert Uytterhoeven
This header file will be removed soon. Copy the helper macro RCAR_GP_PIN(), which is used by the pinctrl drivers only, to sh_pfc.h, and drop the #include. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 1 - drivers/pinctrl/sh-p

[PATCH] lan78xx: Fix ladv/radv error handling in lan78xx_link_reset()

2015-09-04 Thread Geert Uytterhoeven
codes to "u16" variables makes them positive, ignoring the errors. Hence use "int" instead. Drop the "unlikely"s (unlikely considered harmful) and propagate the actual error values instead of overriding them to -EIO while we're at it. Signed-off-by: Geert Uytt

Re: [PATCH v2 2/2] usb: renesas_usbhs: Add support for R-Car H3

2015-09-29 Thread Geert Uytterhoeven
-dmac), this patch > sets the "type" of renesas_usbhs_driver_param to USBHS_TYPE_RCAR_GEN2. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Acked-by: Geert Uytterhoeven <geert+rene...@glider.be> Gr{oetje,eeting}s, Geer

Re: [PATCH 1/4] usb: host: xhci-rcar: add xhci_rcar_is_compatible() function

2015-10-05 Thread Geert Uytterhoeven
so simplify the code to match specific firmware paths to the various compatible entries. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But w

[PATCH] usb: phy: Remove unused Renesas R-Car (Gen1) USB PHY driveer

2015-12-04 Thread Geert Uytterhoeven
iver using the generic PHY framework should be written, as was done for R-Car Gen2. Remove the driver for good. Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/usb/phy/Kconfig| 13 -- drivers/usb/phy/Makefile | 1 - drivers/usb/ph

Re: [PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23]

2015-12-10 Thread Geert Uytterhoeven
nd just have "renesas,usbhs-r8a7792". This won't work with the new driver, as the driver doesn't match again "renesas,usbhs-r8a7792". The same applies to r8a7793. Do we care about this - in upstream? Probably not. - in the BSP? It seems to have r8a7790/r8a7791 usbhs only, though. Gr{oet

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

2015-12-15 Thread Geert Uytterhoeven
Hi Sergei, On Tue, Dec 15, 2015 at 12:54 PM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: > On 12/15/2015 2:28 PM, Geert Uytterhoeven wrote: >>>> You are mixing 2 and 1 spaces between words, don't do that. >>> >>> Care to just explain

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-15 Thread Geert Uytterhoeven
device >> >+- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device >> >+ >> >+When compatible with the generic version, nodes must list the >> >+SoC-specific version corresponding to the platform first followed >> >+by

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

2015-12-15 Thread Geert Uytterhoeven
gt;>> >>> >>> I'll consider doing that if you care to explain what's the problem >>> with >>> my spacing. TIA. >> >> >> You are mixing 2 and 1 spaces between words, don't do that. > > Care to just explain why? It makes the

Re: [uml-devel] [PATCH 1/2] usb: support building without CONFIG_HAS_DMA

2016-02-15 Thread Geert Uytterhoeven
allyesconfig kernels for m68k/Sun-3. I'll clean it up and send it... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm

[PATCH 3/3] usb: dwc2: USB_DWC2 should depend on HAS_DMA

2016-02-15 Thread Geert Uytterhoeven
If NO_DMA=y: ERROR: "usb_gadget_map_request" [drivers/usb/dwc2/dwc2.ko] undefined! ERROR: "usb_gadget_unmap_request" [drivers/usb/dwc2/dwc2.ko] undefined! ERROR: "bad_dma_ops" [drivers/usb/dwc2/dwc2.ko] undefined! Add a dependency on HAS_DMA to f

[PATCH 1/3] usb: core: Allow compilation on platforms where NO_DMA=y

2016-02-15 Thread Geert Uytterhoeven
sb/core/usbcore.ko] undefined! ERROR: "dma_pool_create" [drivers/usb/core/usbcore.ko] undefined! Add a few checks for CONFIG_HAS_DMA to fix this. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- drivers/usb/core/buffer.c | 18 -- drivers/us

[PATCH 2/3] usb: host: Some host drivers should depend on HAS_DMA

2016-02-15 Thread Geert Uytterhoeven
quot; [drivers/usb/host/ehci-platform.ko] undefined! ERROR: "dma_pool_destroy" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR: "bad_dma_ops" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR: "dma_pool_free" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR:

[PATCH 0/3] usb: Allow compilation on platforms where NO_DMA=y

2016-02-15 Thread Geert Uytterhoeven
This patch series allows to compile USB on platforms where NO_DMA=y. I've been using it for quite a while to make allmodconfig/allyesconfig build for m68k/sun3. Thanks for your comments! Geert Uytterhoeven (3): usb: core: Allow compilation on platforms where NO_DMA=y usb: host: Some host

Re: [PATCH 1/3] usb: core: Allow compilation on platforms where NO_DMA=y

2016-02-15 Thread Geert Uytterhoeven
Hi Vegard, On Mon, Feb 15, 2016 at 12:49 PM, Vegard Nossum <vegard.nos...@oracle.com> wrote: > On 02/15/2016 12:21 PM, Geert Uytterhoeven wrote: >> If NO_DMA=y: >> >> ERROR: "dma_pool_destroy" [drivers/usb/core/usbcore.ko] undefined! >> ERROR:

[PATCH v2 0/3] usb: Allow compilation on platforms where NO_DMA=y

2016-02-16 Thread Geert Uytterhoeven
description that this actually allows using USB on UML, - Add Acked-by. Thanks! Geert Uytterhoeven (3): usb: core: Allow compilation on platforms where NO_DMA=y usb: host: Host drivers relying on DMA should depend on HAS_DMA usb: dwc2: USB_DWC2 should depend on HAS_DMA drivers/usb/core

[PATCH v2 1/3] usb: core: Allow compilation on platforms where NO_DMA=y

2016-02-16 Thread Geert Uytterhoeven
drivers/usb/core/usbcore.ko] undefined! Add a few checks for CONFIG_HAS_DMA to fix this. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Acked-by: Vegard Nossum <vegard.nos...@oracle.com> --- v2: - Replace remaining #ifdefs by IS_ENABLED() checks, - Add to patch descrip

[PATCH v2 2/3] usb: host: Host drivers relying on DMA should depend on HAS_DMA

2016-02-16 Thread Geert Uytterhoeven
quot; [drivers/usb/host/ehci-platform.ko] undefined! ERROR: "dma_pool_destroy" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR: "bad_dma_ops" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR: "dma_pool_free" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR:

[PATCH v2 3/3] usb: dwc2: USB_DWC2 should depend on HAS_DMA

2016-02-16 Thread Geert Uytterhoeven
If NO_DMA=y: ERROR: "usb_gadget_map_request" [drivers/usb/dwc2/dwc2.ko] undefined! ERROR: "usb_gadget_unmap_request" [drivers/usb/dwc2/dwc2.ko] undefined! ERROR: "bad_dma_ops" [drivers/usb/dwc2/dwc2.ko] undefined! Add a dependency on HAS_DMA to f

Re: [PATCH v2 1/3] usb: core: Allow compilation on platforms where NO_DMA=y

2016-02-21 Thread Geert Uytterhoeven
Hi Greg, On Sun, Feb 21, 2016 at 5:23 AM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Feb 16, 2016 at 04:10:57PM +0100, Geert Uytterhoeven wrote: >> Some platforms don't have DMA, but we should still be able to build USB >> drivers for these platfo

[PATCH v3] usb: host: Host drivers relying on DMA should depend on HAS_DMA

2016-02-22 Thread Geert Uytterhoeven
quot; [drivers/usb/host/ehci-platform.ko] undefined! ERROR: "dma_pool_destroy" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR: "bad_dma_ops" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR: "dma_pool_free" [drivers/usb/host/ehci-hcd.ko] undefined! ERROR:

Re: [PATCH] usb: host: xhci-plat: add firmware for the R-Car M3 xHCI controllers

2016-04-12 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Apr 12, 2016 at 8:42 AM, Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> wrote: > This patch adds a firmware for the USB 3.0 host controllers of Renesas > R-Car M3 SoC. I guess you mean "R-Car M3-W"? Gr{oetje,eeting}s,

[PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-20 Thread Geert Uytterhoeven
the check for runtime_auto by #ifdef CONFIG_PM to fix this. Fixes: a59f8c5b048dc938 ("lan78xx: add ndo_get_stats64") Reported-by: Guenter Roeck <li...@roeck-us.net> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- Alternatively, we can add a dev_pm_runtime_aut

Re: [PATCH v8 4/4] power: wm831x_power: Support USB charger current limit management

2016-03-27 Thread Geert Uytterhoeven
*/ > + best = 0; > + for (i = 0; i < ARRAY_SIZE(wm831x_usb_limits); i++) { > + if (limit >= wm831x_usb_limits[i] && > + wm831x_usb_limits[best] < wm831x_usb_limits[i]) > + best = i; > + } > + > + dev_dbg(w

Re: [RFC 08/15] rtc: at91sam9: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Geert Uytterhoeven
did, all other RTC drivers would also fail. So UML has no RTC. Should/can it use RTC_DRV_GENERIC? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with te

Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Geert Uytterhoeven
es HAS_IOMEM afaik. No systems around with HV-based DMA? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. B

Re: [PATCH] usb: gadget: renesas_usb3: Use ARCH_RENESAS

2016-03-02 Thread Geert Uytterhoeven
more > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Geert Uytterhoeven <geert+rene...@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-25 Thread Geert Uytterhoeven
Hi Shimoda-san, On Thu, Apr 21, 2016 at 2:57 PM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > On Thu, Apr 21, 2016 at 12:27 PM, Yoshihiro Shimoda > <yoshihiro.shimoda...@renesas.com> wrote: >>> > [1.565605] xhci-hcd ee00.usb: xHCI Host Controller

Re: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-25 Thread Geert Uytterhoeven
select USB_XHCI_RCAR if USB_XHCI_HCD > > if ARCH_RENESAS > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index efa77c1..010d2b7 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -105,6 +105,7 @@ config ARCH_R

[PATCH 49/54] MAINTAINERS: Add file patterns for usb device tree bindings

2016-05-22 Thread Geert Uytterhoeven
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org --- Please apply this patch directly

Re: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

2016-04-21 Thread Geert Uytterhoeven
t value being in the DTS, there's some timer code that doesn't take this into account. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to jour

Re: [PATCH] usb: renesas_usbhs: add a compatible string for r8a7796

2016-08-25 Thread Geert Uytterhoeven
On Wed, Aug 24, 2016 at 9:39 AM, Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> wrote: > This patch adds support for r8a7796 (R-Car M3-W). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Acked-by: Geert Uytterhoeven <geert+rene...@glide

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Geert Uytterhoeven
build-testing is really all you need. Any > problems caused by adding 'const' to a definition will be seen by build > errors or warnings. Unfortunately in this particular case they could lead to failures that can only be detected at runtime, when failing o write to a read-only piece of m

Re: [PATCH] usb: musb: mark PM functions as __maybe_unused

2016-11-28 Thread Geert Uytterhoeven
usb_dev_pm_ops- 92 +92 musb_runtime_suspend - 36 +36 Total: Before=13091, After=15435, chg +17.91% Doh... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH] usb: musb: mark PM functions as __maybe_unused

2016-11-28 Thread Geert Uytterhoeven
Hi Arnd, On Mon, Nov 28, 2016 at 11:54 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Monday, November 28, 2016 11:51:37 AM CET Geert Uytterhoeven wrote: >> On Tue, Nov 22, 2016 at 3:30 PM, Arnd Bergmann <a...@arndb.de> wrote: >> > Building without CONFI

[PATCH] USB: serial: cp210x: Use tcflag_t to fix incompatible pointer type

2016-11-21 Thread Geert Uytterhoeven
(tty->driver_data, ^ drivers/usb/serial/cp210x.c:35:13: note: expected 'unsigned int *' but argument is of type 'tcflag_t *' static void cp210x_get_termios_port(struct usb_serial_port *port, ^ Consistently use tcflag_t to fix this. Signed-off-by: Geert Uytterhoe

[PATCH] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

2016-12-14 Thread Geert Uytterhoeven
f81534_port_private.phy_num. Use an intermediate variable of type int to fix this. While at it, forward the actual error code instead of converting it to -ENODEV. Fixes: 0c9bd6004d258d46 ("USB: serial: add Fintek F81532/534 driver") Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org&

  1   2   3   >