Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of_phy_provider_register(struct device *dev, + struct module *owner, struct phy * (*of_xlate)(struct device *dev, + struct of_phandle_args *args)); +struct phy_provider

Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. However using the old USB PHY library cannot be completely removed

Re: [PATCH]USB: usb-skeleton.c: add retry for nonblocking read

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 10:34:33PM +0800, Chen Wang wrote: Opps, I find my email address is still wrong. Let me correct it and post again. The mailing list does not accept html messages, and I can't accept a patch in html format. Please read the file, Documentation/email_clients.txt for some

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 02:29:52PM +0530, Kishon Vijay Abraham I wrote: Hi, On Thursday 18 July 2013 12:50 PM, Greg KH wrote: On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of_phy_provider_register(struct device *dev, + struct module

Re: [PATCH]USB: usb-skeleton.c: add retry for nonblocking read

2013-07-18 Thread Greg KH
On Fri, Jul 19, 2013 at 10:20:07AM +0800, Chen Wang wrote: Thanks, I resent my patch today after reading the doc, it does help. The email still use the same subject, not sure if this will submerge my latest submission, do I need to use a new subject, though I have not thought of a better new

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: +ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy anywhere in it? You rely on the sender to never send a duplicate name.id pair? Why not create your own ids based on the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: + ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy

Re: [PATCH] usbserial: append Petatel NP10T device to GSM modems list

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 10:21:23AM +0300, Daniil Bolsun wrote: This patch was tested on 3.10.1 kernel. Same models of Petatel NP10T modems have different device IDs. Unfortunately they have no additional revision information on a board which may treat them as different devices. Currently

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 08:49:32AM +0530, Kishon Vijay Abraham I wrote: Hi, On Saturday 20 July 2013 05:20 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM

Re: Clock speed on RasPi?

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 10:04:16PM +, Paul Zimmerman wrote: Hi Stephen, With the mainline kernel, /proc/cpuinfo shows a bogoMips of ~460. The downstream raspberrypi.org kernel shows ~690. Changing the arm_freq setting in /boot/config.txt has no affect. Any idea why the difference? You

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-20 Thread Greg KH
On Sun, Jul 21, 2013 at 02:52:09AM +0200, Tom Gundersen wrote: Most of the information in usb.ids is now contained in udev's hwdb. First attempt to query hwdb before falling back on the old file. This would allow distributions to no longer ship (most of) usb.ids by default, but rather keep

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you can get to, then put the pointer there, don't use a name

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:01:11PM +0200, Tom Gundersen wrote: On Sun, Jul 21, 2013 at 3:34 AM, Greg KH gre...@linuxfoundation.org wrote: Can this mean I can drop the usb.ids file from the usbutils package? I can't remember where hwdb is generated from, does it rely on the usb.ids file

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:05:31PM +0200, Kay Sievers wrote: However, hwdb only contains vendor, product, class, subclass and protocol. So if you drop usb.ids the rest of the information will be lost. Maybe split the rest out into a separate file and ship only that? Or is there a way

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote: On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 05:49:05PM +0200, Kay Sievers wrote: On Sun, Jul 21, 2013 at 5:36 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, Jul 21, 2013 at 01:05:31PM +0200, Kay Sievers wrote: However, hwdb only contains vendor, product, class, subclass and protocol. So if you drop

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 02:59:41PM -0500, sgtcapslock wrote: I took Alan's excellent advice and read a good bit of that book last night. Definitely some good authors there! After pondering Alan's diagnosis for a bit, I went to inspect the usbhid driver code, and wound up creating a patch

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-22 Thread Greg KH
On Mon, Jul 22, 2013 at 12:55:18PM +0530, Kishon Vijay Abraham I wrote: The issue (or one of the issues) in this discussion is that Greg does not like the idea of using names or IDs to associate PHYs with controllers, because they are too prone to duplications or other

Re: EHCI driver breaks at 6 endpoints

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 01:33:25PM +, Stoddard, Nate (GE Healthcare) wrote: Hello, We are attempting to create a system that will support 8 full speed USB devices each sending a 64-byte transfer every 1ms via interrupt endpoints. When we connect 5 full speed USB devices our USB host use

Re: a small patch that fixes the ohci warn irq nobody cared on shutdown.

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 07:13:02AM +, Caizhiyong wrote: Hi: Here's a small patch that fixes the ohci shutdown. The patch is against v3.4.54. 3.4 is quite old, and we can't add new patches to it that are not also in Linus's tree. Can you verify that 3.11-rc2 also needs this patch,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here.

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 09:58:34PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 23 July 2013 09:48 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer in the first place, right? IMHO it would be better if you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote: On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: I fully agree that a simple, single string will not scale even in some, not so uncommon cases

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.) I got copied in very late so don't have most of the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: That's not so bad, as long as you let the phy core use whatever name it wants for the device when it registers it with sysfs. Yes, in regulator core consumer names are completely separated from this. Regulator core simply

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-23 Thread Greg KH
On Thu, Jun 27, 2013 at 03:34:52PM +0530, navin patidar wrote: dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar

Re: [PATCH 3/3] staging: dwc2: Don't touch the dma_mask when dma is disabled

2013-07-23 Thread Greg KH
On Fri, Jul 19, 2013 at 11:34:24AM +0200, Matthijs Kooijman wrote: There was some code that cleared the dma_mask when dma was disabled in the driver. Given that clearing the mask doesn't actually tell the usb core we're not using dma, and a previous commit explicitely sets the

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-23 Thread Greg KH
On Wed, Jul 17, 2013 at 12:35:46PM -0700, Paul Zimmerman wrote: The transfer scheduler in the dwc2 driver is pretty basic, not to mention buggy. It works fairly well with just a couple of devices plugged in, but if you add, say, multiple devices with periodic endpoints, the scheduler breaks

Re: [PATCH 4/7] staging: usbip: add option for usbipd to save its process id.

2013-07-23 Thread Greg KH
On Mon, Jul 08, 2013 at 07:43:30PM -0600, Anthony Foiani wrote: Anthony Foiani anthony.foi...@gmail.com writes: Introduce option -P / --pid to request that usbipd save its PID to a file while running. I've already spotted one problem with this patch: +

Re: [PATCH 5/7] staging: usbip: set server port via option.

2013-07-23 Thread Greg KH
On Mon, Jul 08, 2013 at 07:47:20PM -0600, Anthony Foiani wrote: Anthony Foiani anthony.foi...@gmail.com writes: Add an option -p / --port to specify the TCP port to listen on. This is unfortunate, as port is also used to indicate which usbip port is in use by a particular connection.

Re: EHCI driver breaks at 6 endpoints

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 10:34:06PM +, Stoddard, Nate (GE Healthcare) wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Tuesday, July 23, 2013 10:27 AM To: Stoddard, Nate (GE Healthcare) Cc: linux-usb@vger.kernel.org Subject: Re: EHCI driver

Re: [PATCH V4 00/11] USB: OHCI:Properly handle ohci_suspend()routine in bus glue

2013-07-23 Thread Greg KH
On Mon, Jul 22, 2013 at 03:21:31PM +0530, manjunath wrote: On Monday 22 July 2013 03:02 PM, Manjunath Goudar wrote: Suspend scenario in case of ohci bus glue was not properly handled as it was not suspending generic part of ohci controller. Calling explicitly the ohci_suspend()routine will

Re: Kernel panic with Gadget CDC/ECM

2013-07-23 Thread Greg KH
On Wed, Jul 24, 2013 at 09:38:02AM +0800, tong li wrote: Hello, I run our board(not a common one) as a Gadget CDC/ECM device with linux-3.0.39. Any chance to use a newer (i.e. something the community can help with), kernel version? Or, if you are stuck with 3.0, please get support from

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 04:30:29AM -0500, Josef Schimke wrote: wrt that: 1. Am I on the right track thinking like that? 2. Does the USB stuff in the kernel already have a way to test this? 3. If not, I'm really stumped about how I can do this, so any advice would be great. :p Aside

Re: usb cdc-acm driver cause windows xp sp3 blue screen randomly

2013-07-24 Thread Greg KH
On Wed, Jul 24, 2013 at 08:11:05PM +0800, Yingchun Li wrote: Hi, I have a cdc-acm usb device, used for transfering data to/from windows PC, for windows PC, and I use the Documentation/usb/linux-cdc-acm.inf to load the windows driver(which is the usbser.sys). On PC, there is an

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-24 Thread Greg KH
On Wed, Jul 24, 2013 at 12:38:13AM -0500, Josef Schimke wrote: On 07/23/2013 09:57 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 04:30:29AM -0500, Josef Schimke wrote: wrt that: 1. Am I on the right track thinking like that? 2. Does the USB stuff in the kernel already have a way to test

Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

2013-07-24 Thread Greg KH
On Wed, Jun 26, 2013 at 02:29:45PM +0800, Li, Zhen-Hua wrote: From: Li, Zhen-Hua zhen-h...@hp.com There's another patch trying to fix this warning: Controller not stopped yet!. It is : 997ff893603c6455da4c5e26ba1d0f81adfecdfc . I don't think it is appropriate to avoid auto-stop for all

Re: [PATCH 2/2] Remove static sizing of usb_device_id arrays

2013-07-24 Thread Greg KH
On Sat, Jun 22, 2013 at 08:55:59PM +0200, Anders Hammarquist wrote: Signed-off-by: Anders Hammarquist i...@iko.pp.se --- drivers/usb/serial/ti_usb_3410_5052.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) This patch, and your previous one, are no

Re: [PATCH v2] usb: host: Faraday fotg210-hcd driver

2013-07-24 Thread Greg KH
On Wed, Jun 19, 2013 at 07:53:04PM +, Yuan-Hsin Chen wrote: FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210 host is an ehci-like controller with some differences. First, register layout of FOTG210 is incompatible with EHCI. Furthermore, FOTG210 is lack of

Re: usb cdc-acm driver cause windows xp sp3 blue screen randomly

2013-07-24 Thread Greg KH
On Thu, Jul 25, 2013 at 10:06:16AM +0800, Yingchun Li wrote: Ok, but the linux-cdc-acm.inf is provieded by us, so I think there should be something I can learn. A .inf file should not crash the kernel, if so, something is really wrong with their operating system :) good luck, greg k-h -- To

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-24 Thread Greg KH
On Thu, Jul 25, 2013 at 10:19:31AM +0530, navin patidar wrote: -pr_warning(Unable to start control thread\n); +struct device *dev; + +if (ud-side == USBIP_STUB) +dev = container_of(ud, struct stub_device, ud)-udev-dev; +else +

Re: Patch queue status?

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 11:34:22AM -0400, Alan Stern wrote: Greg: What's the status of your USB patch queue? I've seen a bunch of notices about patches being applied -- is the queue empty yet? No it isn't empty yet, I tried to pick out most of the 3.11 patches from it for USB already, but

Re: Patch queue status?

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 12:44:29PM -0400, Alan Stern wrote: On Thu, 25 Jul 2013, Greg KH wrote: On Thu, Jul 25, 2013 at 11:34:22AM -0400, Alan Stern wrote: Greg: What's the status of your USB patch queue? I've seen a bunch of notices about patches being applied -- is the queue

Re: [PATCH 1/3] USB: mos7840: fix race in register handling

2013-07-25 Thread Greg KH
On Sun, Jun 30, 2013 at 08:42:07PM +0200, Johan Hovold wrote: Fix race in mos7840_get_reg which unconditionally manipulated the control urb (which may already be in use) by adding a control-urb busy flag. Cc: sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com ---

Re: usbtmc / 3.9.x: Reading from Siglent SDS1xxx returned random host memory

2013-07-25 Thread Greg KH
On Sun, Jul 14, 2013 at 11:32:13PM +0200, Florian Knodt wrote: Hello, Am 14.07.2013 23:04, schrieb Greg KH: So does 3.10.1 work properly for you? No, with the latest kernel it does no longer return any data for larger requests on this scope, but it thus also stopped leaking random RAM

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Greg KH
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB Embedded High-speed Host Electrical Test (EHSET) defines the SINGLE_STEP_SET_FEATURE test as follows: 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 2) The host

Re: Suunto ANT+ stick

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 01:23:54PM +0200, Steinar H. Gunderson wrote: Hi, I have a Suunto ANT+ stick (designed to communicate with various training equipment) that works as a USB serial device. Unfortunately, it seems like its PCI IDs are missing; it doesn't come up unless I add vendor= and

Re: [PATCH] usb: udc: add gadget state kobject uevent

2013-07-26 Thread Greg KH
On Fri, Jul 26, 2013 at 01:56:19PM +0800, Barry Song wrote: 2013/7/18 Felipe Balbi ba...@ti.com: On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote: Hi Felipe, Thanks, I'll test the patch. But sysfs_notify(gadget-dev.kobj, NULL, status), status or state ? I notice that

Re: [PATCH v3] usb: host: Faraday fotg210-hcd driver

2013-07-26 Thread Greg KH
On Fri, Jul 26, 2013 at 09:52:56AM +, Feng-Hsin Chiang wrote: FOTG210 is an OTG controller which can be configured as an USB2.0 host. FOTG210 host is an ehci-like controller with some differences. First, register layout of FOTG210 is incompatible with EHCI. Furthermore, FOTG210 is lack of

I've now caught up on my pending USB patches

2013-07-26 Thread Greg KH
Hi all, I've now caught up on all pending USB patches that were sent to me, with the exception of Ming's EHCI patches, which I need to test further next week. If you've sent me something, that I haven't applied, please resend it, as it's probably lost somewhere. thanks, greg k-h -- To

Re: [PATCH 2/3] USB: mos7840: fix device-type detection

2013-07-26 Thread Greg KH
On Fri, Jul 26, 2013 at 11:55:18AM +0200, Johan Hovold wrote: Fix race in device-type detection introduced by commit 0eafe4de (USB: serial: mos7840: add support for MCS7810 devices) which used a static variable to hold the device type. Move type detection to probe and use serial data to

Re: [PATCH] USB: mos7840: fix pointer casts

2013-07-27 Thread Greg KH
On Sat, Jul 27, 2013 at 01:34:42PM +0200, Johan Hovold wrote: Silence compiler warnings on 64-bit systems introduced by commit 05cf0dec (USB: mos7840: fix race in led handling) which uses the usb-serial data pointer to temporarily store the device type during probe but failed to add the

Re: [PATCH] USB: mos7840: fix pointer casts

2013-07-27 Thread Greg KH
On Sat, Jul 27, 2013 at 08:09:29AM -0700, Greg KH wrote: On Sat, Jul 27, 2013 at 01:34:42PM +0200, Johan Hovold wrote: Silence compiler warnings on 64-bit systems introduced by commit 05cf0dec (USB: mos7840: fix race in led handling) which uses the usb-serial data pointer to temporarily

Re: [PATCH 0/2] usb: chipidea: fixes for v3.11-rc3

2013-07-29 Thread Greg KH
On Mon, Jul 29, 2013 at 01:09:55PM +0300, Alexander Shishkin wrote: Hi, Here are two small chipidea fixes for v3.11. Thanks, now applied. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: USB Interrupt Transaction Scheduling

2013-07-29 Thread Greg KH
On Mon, Jul 29, 2013 at 08:43:01PM +, Stoddard, Nate (GE Healthcare) wrote: According to the USB 2.0 specification, 19 full speed interrupt endpoints (@ 64 bytes) can be scheduled. I have a couple of questions about this specification and the Linux kernel's implementation: 1. Does

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread Greg KH
On Tue, Jul 30, 2013 at 04:28:54PM +0800, Hayes Wang wrote: Allocate the transfer buffer in probe(), and use the buffer for usb control transfer. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r815x.c | 117 +--- 1 file

Re: [PATCH v3 2/3] net/usb/r8152: replace USB buffer from stack to DMA-able

2013-07-30 Thread Greg KH
On Tue, Jul 30, 2013 at 04:28:55PM +0800, Hayes Wang wrote: Allocate the required transfer buffer for usb_control_msg. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 91 +++-- 1 file changed, 66 insertions(+), 25

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread Greg KH
On Tue, Jul 30, 2013 at 04:28:54PM +0800, Hayes Wang wrote: Allocate the transfer buffer in probe(), and use the buffer for usb control transfer. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r815x.c | 117 +--- 1 file

Re: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy

2013-07-30 Thread Greg KH
On Tue, Jul 30, 2013 at 11:15:20AM +0300, Felipe Balbi wrote: look at Greg's and my reply to that email. but finally Greg agreed to what Tomasz proposed no? that's not what I see in the thread. I see Greg agreed to regulator's own IDs being sequentially created, but he mentions device

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread Greg KH
On Tue, Jul 30, 2013 at 11:33:29AM -0700, David Miller wrote: From: Greg KH gre...@linuxfoundation.org Date: Tue, 30 Jul 2013 07:00:59 -0700 This call is so slow, you can afford to make a call to kmalloc for the data, as it sure just did for other structures it needed :) I told him

[GIT PATCH] USB fixes for 3.11-rc4

2013-07-30 Thread Greg KH
The following changes since commit 2c7b871b9102c497ba8f972aa5d38532f05b654d: usb: Clear both buffers when clearing a control transfer TT buffer. (2013-07-25 11:37:13 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/

Re: [PATCH v4 1/5] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-31 Thread Greg KH
On Wed, Jul 31, 2013 at 05:21:22PM +0800, Hayes Wang wrote: Some USB buffers use stack which may not be DMA-able. Use the buffers from kmalloc to replace those one. Signed-off-by: Hayes Wang hayesw...@realtek.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from

Re: [PATCH v4 4/5] net/usb/r8152: make sure the USB buffer is DMA-able

2013-07-31 Thread Greg KH
On Wed, Jul 31, 2013 at 05:21:25PM +0800, Hayes Wang wrote: Allocate the required memory before calling usb_control_msg. And the additional memory copy is necessary. Signed-off-by: Hayes Wang hayesw...@realtek.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from

Re: [PATCH 2/8] pl2303: fix+improve the divsor based baud rate encoding method

2013-08-01 Thread Greg KH
On Tue, Jul 30, 2013 at 09:49:05PM +0200, Frank Schäfer wrote: Based on the formula in the code description, Reinhard Max and me have investigated the devices behavior / functional principle of the divisor based baud rate encoding method. It turned out, that (although beeing a good starting

Re: lsusb doesn't handle 32 bits Usage tags.

2013-08-01 Thread Greg KH
On Sun, Jul 07, 2013 at 09:32:55PM +0200, pchavent wrote: On Sun, 7 Jul 2013 10:37:59 -0700, Greg KH wrote: On Sun, Jul 07, 2013 at 07:17:40PM +0200, pchavent wrote: Hi. lsusb doesn't handle 32 bits Usage tags. I've tried to do a patch but i'm not confident in its implementation. Do

Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework

2013-08-01 Thread Greg KH
On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote: +static int phy_get_id(void) +{ + int ret; + int id; + + ret = ida_pre_get(phy_ida, GFP_KERNEL); + if (!ret) + return -ENOMEM; + + ret = ida_get_new(phy_ida, id); + if (ret 0) +

Re: [PATCH v2 6/8] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-08-01 Thread Greg KH
On Wed, Jul 31, 2013 at 04:44:43PM -0400, Alan Stern wrote: On Wed, 31 Jul 2013, Tomasz Figa wrote: Alan, Greg, On Tuesday 23 of July 2013 01:49:23 Tomasz Figa wrote: This patch modifies the ohci-s3c2410 driver to prepare and unprepare clocks in addition to enabling and disabling,

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 12:48:48AM -0700, Joe Perches wrote: There are several drivers in drivers/net/usb/ that do not have specific MAINTAINERS that should have emails forwarded to the linux-usb mailing list. Add a section for those drivers. Signed-off-by: Joe Perches j...@perches.com

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 11:51:07AM +0200, Oliver Neukum wrote: On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: hello, I'm reading code of usb core and driver model/sysfs. I believe they are designed with OOP. Yes, much of the code is OO. However, we usually don't overwrite methods.

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Greg KH
On Fri, Aug 02, 2013 at 09:56:17AM +0800, Chen Wang wrote: On Thu, 2013-08-01 at 10:34 -0400, Alan Stern wrote: On Thu, 1 Aug 2013, Oliver Neukum wrote: On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: hello, I'm reading code of usb core and driver model/sysfs. I believe they

Re: [PATCHv2 1/2][usbutils] lsusb: port to hwdb

2013-08-01 Thread Greg KH
On Wed, Jul 24, 2013 at 12:37:30PM +0200, Tom Gundersen wrote: Most of the information in usb.ids is now contained in udev's hwdb. Read the information from the hwdb instead of usb.ids. This would allow distributions to no longer ship (most of) usb.ids by default, but rather keep all the usb

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 01:09:55AM -0700, Joe Perches wrote: On Thu, 2013-08-01 at 15:56 +0800, Greg KH wrote: On Thu, Aug 01, 2013 at 12:48:48AM -0700, Joe Perches wrote: There are several drivers in drivers/net/usb/ that do not have specific MAINTAINERS that should have emails

Re: [PATCH] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-01 Thread Greg KH
On Thu, Aug 01, 2013 at 08:50:10PM -0700, Joe Perches wrote: On Fri, 2013-08-02 at 11:30 +0800, Greg KH wrote: On Thu, Aug 01, 2013 at 01:09:55AM -0700, Joe Perches wrote: Lots of maintainers don't apply patches. I have no idea what you are meaning here. Just that maintainers aren't

Re: [PATCH resend] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-02 Thread Greg KH
On Thu, Aug 01, 2013 at 09:03:32PM -0700, Joe Perches wrote: There are several drivers in drivers/net/usb/ that do not have specific MAINTAINERS that should have emails forwarded to the linux-usb mailing list. Add a section for those drivers. Thanks, I'll queue this up next week for the

Re: [PATCH] staging: ozwpan: Fix farewell report.

2013-08-02 Thread Greg KH
On Fri, Aug 02, 2013 at 12:04:16PM +0100, Rupesh Gujare wrote: This patch fixes issues reported by Dan here:- http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-August/040052.html Please list the issues in the patch changelog itself, as sometimes you don't have web access,

Re: new USB serial device: Garmin USB ANT stick

2013-08-03 Thread Greg KH
On Sat, Aug 03, 2013 at 09:32:00AM -0700, Scott Alfter wrote: I have a Garmin USB ANT stick that shows up in lsusb as the following: Bus 009 Device 002: ID 0fcf:1008 Dynastream Innovations, Inc. Mini stick Suunto It's a wireless serial device that talks to Garmin's GPS watches so you can

Re: usb 1.1 device fails on some usb3 hardware due to command error

2013-08-03 Thread Greg KH
On Sat, Aug 03, 2013 at 12:06:51PM +0200, Volker Schroer wrote: Hello, attaching a funcube dongle ( an usb 1.1 device which is used in software defined radio ) to an usb 3 port fails an some hardeware. Here is an extract of the dmesg log: What kernel version are you using? Aug 2

Re: Regression: USB memory stick stalls and no longer automounts under 3.11-rc1

2013-08-05 Thread Greg KH
On Mon, Aug 05, 2013 at 12:18:55PM -0400, Alan Stern wrote: On Mon, 5 Aug 2013, [ISO-8859-1] Alex Villac??s Lasso wrote: https://bugzilla.kernel.org/show_bug.cgi?id=60685 Posting in the mailing list as requested by Greg Kroah-Hartman mailto:g...@kroah.com Problem description:

Re: Reg: USB: ehci-omap: Suspend the controller during idle.

2013-08-06 Thread Greg KH
On Tue, Aug 06, 2013 at 06:25:32PM +0530, Bharathraj Nagaraju wrote: Dear All, We are working on omap4470 based device,kernel-3.0.31 is running on this. Have you tried the 3.10 kernel for this? I think you might find that this already is resolved there, as lots of pm USB work has

Re: 045e:0745 [HP TouchSmart tm2t-2200] No scancode for several keys of Microsoft Comfort Desktop 5000

2013-08-06 Thread Greg KH
On Tue, Aug 06, 2013 at 11:57:17AM -0700, Ari Fogel wrote: [1]. Summary: 045e:0745 [HP TouchSmart tm2t-2200] No scancode for several keys of Microsoft Comfort Desktop 5000 [2]. Link to original bug report in launchpad: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1168224 [2].

Re: I've now caught up on my pending USB patches

2013-08-06 Thread Greg KH
On Wed, Aug 07, 2013 at 08:44:49AM +0800, Ming Lei wrote: Hi Greg, On Fri, Aug 2, 2013 at 9:19 AM, Ming Lei tom.leim...@gmail.com wrote: Hi Greg, On Sat, Jul 27, 2013 at 5:17 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, I've now caught up on all pending USB patches

Re: [PATCH 0/2] lsusb LPM BESL support

2013-08-07 Thread Greg KH
On Wed, Aug 07, 2013 at 12:12:26PM -0700, Alexandra Yates wrote: *** BLURB HERE *** What is supposed to go here? -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-07 Thread Greg KH
On Wed, Aug 07, 2013 at 11:24:46PM +0400, Бойко Максим wrote: From: Maksim Boyko maksim.a.bo...@gmail.com Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525. The similar patch was previously reported for Logitech HD Webcam C310 (see

Re: 'Siano Mobile Silicon' firmware doesn't load in 3.10.x

2013-08-08 Thread Greg KH
On Thu, Aug 08, 2013 at 05:52:53PM +0200, mario tillmann wrote: With the latest kernel 3.10.x I get an error message when loading the firmware sms1xxx-hcw-55xxx-dvbt-02.fw: smscore_load_firmware_family2: line: 986: sending MSG_SMS_DATA_VALIDITY_REQ expecting 0xcfed1755 smscore_onresponse:

Re: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-08 Thread Greg KH
Note, I don't apply RFC patches, and rarely review them. Why are you claiming that is what this is, when it is in the 3rd version already? greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [RFC v2] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-08 Thread Greg KH
On Thu, Aug 08, 2013 at 05:24:46PM -0700, Alexandra Yates wrote: Modified the xHCI roothub descriptor to return USB2.0 extension descriptor Best Effort Service Latency (BESL) and Deep Best Effort Service Latency (DBESL) values when set on the xHCI host. On link power management the BESL and

Re: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-09 Thread Greg KH
On Fri, Aug 09, 2013 at 08:51:30AM -0700, Sarah Sharp wrote: On Thu, Aug 08, 2013 at 04:11:46PM -0700, Greg KH wrote: Note, I don't apply RFC patches, and rarely review them. Why are you claiming that is what this is, when it is in the 3rd version already? This is a new approach from

Re: 3.10.4: kmemleak in usb_get_bos_descriptor()?

2013-08-09 Thread Greg KH
On Thu, Aug 08, 2013 at 10:07:19PM +0200, Martin MOKREJŠ wrote: Hi, I get plenty of these in /sys/kernel/debug/kmemleak: unreferenced object 0x88019f675268 (size 32): comm usb-storage, pid 11411, jiffies 4310515592 (age 1538.100s) hex dump (first 32 bytes): 05 0f 16 00 02 07

Re: [PATCH v4 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-09 Thread Greg KH
On Fri, Aug 09, 2013 at 02:12:17PM -0700, David Miller wrote: From: Ming Lei ming@canonical.com Date: Thu, 8 Aug 2013 21:48:21 +0800 This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support

[GIT PATCH] USB fixes for 3.11-rc5

2013-08-09 Thread Greg KH
The following changes since commit c095ba7224d8edc71dcef0d655911399a8bd4a3f: Linux 3.11-rc4 (2013-08-04 13:46:46 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.11-rc5 for you to fetch changes up to

Re: The USB Driver Appears to be Looping

2013-08-11 Thread Greg KH
On Sun, Aug 11, 2013 at 02:25:48PM -0700, Thomas D. Dean wrote: [1.] One line summary of the problem: [Bug 1151622] [ASUS P9X79 PRO] The usb driver appears to fail [2.] Full description of the problem/report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1151622 The console

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 06:18:00PM +, Paul Zimmerman wrote: From: popcornmix [mailto:popcorn...@gmail.com] Sent: Monday, August 12, 2013 6:39 AM On Mon, Aug 12, 2013 at 8:40 AM, Matthijs Kooijman matth...@stdin.nl wrote: Paul, did you try the patch without this hunk? Dom,

Re: [PATCH 4/4] Documentation sysfs-bus-usb: Document all files used by libusb

2013-08-12 Thread Greg KH
On Sat, Aug 03, 2013 at 04:37:51PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/ABI/testing/sysfs-bus-usb | 38 + 1 file changed, 38 insertions(+) This patch doesn't apply at all, can you redo it against the

Re: [PATCH V2] USB: EHCI: make ehci-w90X900 a separate driver

2013-08-12 Thread Greg KH
...@rowland.harvard.edu Cc: Greg KH g...@kroah.com Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org V2: -Arranged #include's in alphabetical order. -Replaced w90p910 by w90x900 because it is supports all series of w90x900. drivers/usb/host/Kconfig|2 +- drivers

Re: [PATCH V2] USB: OHCI: make ohci-nxp a separate driver

2013-08-12 Thread Greg KH
started with usb, current scenario replaced usb with ohci for proper naming. Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Signed-off-by: Deepak Saxena dsax...@linaro.org Acked-by: Alan Stern st...@rowland.harvard.edu Cc: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-12 Thread Greg KH
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: This patch fixes crash issue when there is quick cycle of de-enumeration enumeration due to loss of wireless link. It is found that sometimes new device (or coming back device) returns very fast, even before USB core read out

  1   2   3   4   5   6   7   8   9   10   >