On Tue, Feb 09, 2016 at 07:01:20PM +0200, Heikki Krogerus wrote:
> Hi,
>
> The OS, or more precisely the user space, needs to be able to control
> a few things regarding USB Type-C ports. The first thing that must be
> allowed to be controlled is the data role. USB Type-C ports will
> select the d
Felipe,
On 05/05/2016 11:50 PM, Felipe Balbi wrote:
Hi Guenter,
Guenter Roeck writes:
On Tue, Feb 09, 2016 at 07:01:20PM +0200, Heikki Krogerus wrote:
Hi,
The OS, or more precisely the user space, needs to be able to control
a few things regarding USB Type-C ports. The first thing that
On 05/06/2016 01:08 AM, Heikki Krogerus wrote:
Hi,
On Wed, May 04, 2016 at 08:05:44PM -0700, Guenter Roeck wrote:
On Tue, Feb 09, 2016 at 07:01:20PM +0200, Heikki Krogerus wrote:
Hi,
The OS, or more precisely the user space, needs to be able to control
a few things regarding USB Type-C ports
Hello Heikki,
On 05/06/2016 01:29 AM, Heikki Krogerus wrote:
On Fri, May 06, 2016 at 01:05:05AM -0700, Guenter Roeck wrote:
[ ... ]
I know there has been a lengthy discussion about the patch set, but I may
have missed the conclusion. Is there some reason to _not_ advance it
that I may have
Heikki,
On 05/06/2016 01:08 AM, Heikki Krogerus wrote:
Hi,
[ ... ]
I don't have not made any new code for the class driver yet, but I'm
attempting to prepare v2 next week.
Would it make sense to send feedback about v1 now, or should I wait for v2 ?
Thanks,
Guenter
--
To unsubscribe from
Hi,
On Wed, May 11, 2016 at 12:40:11PM +0300, Heikki Krogerus wrote:
> On Tue, May 10, 2016 at 08:14:34PM -0700, Guenter Roeck wrote:
> > Heikki,
> >
> > On 05/06/2016 01:08 AM, Heikki Krogerus wrote:
> > > Hi,
> > >
> > [ ... ]
> > >
Hi,
On Fri, May 13, 2016 at 05:23:21PM +0300, Heikki Krogerus wrote:
> Hi,
>
> On Wed, May 11, 2016 at 07:47:18AM -0700, Guenter Roeck wrote:
> > Hi,
> >
> > On Wed, May 11, 2016 at 12:40:11PM +0300, Heikki Krogerus wrote:
> > > On Tue, May 10, 2016 at 0
On Wed, May 18, 2016 at 02:13:30AM +0200, Heinrich Schuchardt wrote:
> (!count || count < 4) is always true.
Even if count >= 4 ?
Guenter
> So let's remove the coding which is dead at least since 2005.
>
> Signed-off-by: Heinrich Schuchardt
>
> ---
> drivers/net/usb/pegasus.c | 53 ---
Hello Heikki,
On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote:
> The purpose of this class is to provide unified interface for user
> space to get the status and basic information about USB Type-C
> Connectors in the system, control data role swapping, and when USB PD
> is availabl
On Fri, May 20, 2016 at 01:47:03PM +0300, Heikki Krogerus wrote:
> On Thu, May 19, 2016 at 10:53:04AM -0700, Guenter Roeck wrote:
> > Hello Heikki,
> >
> > On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote:
> > > The purpose of this class is to prov
On 05/20/2016 06:37 AM, Oliver Neukum wrote:
On Fri, 2016-05-20 at 14:24 +0300, Heikki Krogerus wrote:
On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote:
Please explain. How does that express DRP but prefered master?
Sorry but I'm not sure what you mean here. If the port is capab
Hi Oliver,
On 05/20/2016 11:43 PM, Oliver Neukum wrote:
On Fri, 2016-05-20 at 22:51 -0700, Guenter Roeck wrote:
On 05/20/2016 06:37 AM, Oliver Neukum wrote:
On Fri, 2016-05-20 at 14:24 +0300, Heikki Krogerus wrote:
On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote:
Please
On 05/22/2016 10:34 PM, Oliver Neukum wrote:
On Sun, 2016-05-22 at 08:54 -0700, Guenter Roeck wrote:
Hi Oliver,
On 05/20/2016 11:43 PM, Oliver Neukum wrote:
On Fri, 2016-05-20 at 22:51 -0700, Guenter Roeck wrote:
On 05/20/2016 06:37 AM, Oliver Neukum wrote:
On Fri, 2016-05-20 at 14:24 +0300
On 05/23/2016 06:58 AM, Oliver Neukum wrote:
On Mon, 2016-05-23 at 06:27 -0700, Guenter Roeck wrote:
Good question. I originally added a sysfs attribute
'preferred-mode' to
my code, but then concluded that this is supposed to be provided
by the platform and added it as platform da
On Mon, May 23, 2016 at 05:55:04PM +0200, Oliver Neukum wrote:
> On Mon, 2016-05-23 at 07:43 -0700, Guenter Roeck wrote:
> > On 05/23/2016 06:58 AM, Oliver Neukum wrote:
>
> > > Now I am confused. Are you saying that the choice of Alternate Mode does
> > &
On Mon, May 23, 2016 at 01:25:19PM +0200, Oliver Neukum wrote:
> On Mon, 2016-05-23 at 12:57 +0300, Heikki Krogerus wrote:
> > Hi Oliver,
> >
> > On Fri, May 20, 2016 at 04:19:59PM +0200, Oliver Neukum wrote:
> > > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
> > > > Like I've told so
On 05/19/2016 05:44 AM, Heikki Krogerus wrote:
The purpose of this class is to provide unified interface for user
space to get the status and basic information about USB Type-C
Connectors in the system, control data role swapping, and when USB PD
is available, also power role swapping and Alterna
On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote:
> The purpose of this class is to provide unified interface for user
> space to get the status and basic information about USB Type-C
> Connectors in the system, control data role swapping, and when USB PD
> is available, also power r
On 05/25/2016 04:30 AM, Heikki Krogerus wrote:
Hi,
On Tue, May 24, 2016 at 06:42:09AM -0700, Guenter Roeck wrote:
+struct typec_capability {
+ enum typec_data_rolerole;
+ unsigned intusb_pd:1;
+ struct typec_altmode*alt_modes;
+ unsigned int
On 05/25/2016 04:51 AM, Heikki Krogerus wrote:
On Tue, May 24, 2016 at 12:28:26PM -0700, Guenter Roeck wrote:
On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote:
The purpose of this class is to provide unified interface for user
space to get the status and basic information about
On Wed, May 25, 2016 at 04:20:56PM +0200, Oliver Neukum wrote:
> On Wed, 2016-05-25 at 17:04 +0300, Heikki Krogerus wrote:
>
> > I'm not against leaving the responsibility of registering the alternate
> > modes to the drivers. I'm a little bit worried about relying then on
> > the drivers to also
On Wed, May 25, 2016 at 02:28:46PM +0300, Heikki Krogerus wrote:
> Hi,
>
> On Tue, May 24, 2016 at 02:51:40PM +0200, Oliver Neukum wrote:
> > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
> >
> > Hi,
> >
> > as this discussion seems to go in circles, I am starting anew
> > at the top
From: Guenter Roeck
New API functions (calls into class code)
typec_set_usb_role()
typec_set_pwr_role()
typec_set_vconn_role()
typec_set_pwr_opmode()
Modified API functions (calls into class code):
typec_register_port(dev, cap
On 05/27/2016 12:55 AM, Heikki Krogerus wrote:
Hi,
[ ... ]
---
This patch applies on top of '[RFC PATCHv2] usb: USB Type-C Connector Class'
from Heikki Krogerus. It provided the changes I made to get the code
operational.
drivers/usb/type-c/typec.c | 134 ++
On Tue, May 31, 2016 at 11:31:21AM +0300, Heikki Krogerus wrote:
> Hi Oliver,
>
> On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote:
> > On Mon, 2016-05-30 at 16:19 +0300, Heikki Krogerus wrote:
> > > Hi guys,
> > >
> > > I'm attaching a diff instead of full v3. I'm not yet adding att
On Tue, May 31, 2016 at 03:43:56PM +0300, Heikki Krogerus wrote:
> On Tue, May 31, 2016 at 03:09:01PM +0300, Heikki Krogerus wrote:
> > On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote:
> > > On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote:
> > > > Hi Oliver,
> > > >
> > > >
On 06/01/2016 02:04 AM, Oliver Neukum wrote:
On Wed, 2016-06-01 at 11:23 +0300, Heikki Krogerus wrote:
I think we can still add them later if they are still seen as
necessity later on, tough I seriously doubt it. It would not be
ideal, but adding an attribute should not really break anything,
ri
On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver Neukum wrote:
> On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
> > Just noticed that the "active" file is for now read only, but it needs
> > to be changed to writable. That file will of course provide means for
> > the userspace to Exit a
On 06/01/2016 11:24 PM, Oliver Neukum wrote:
On Wed, 2016-06-01 at 06:34 -0700, Guenter Roeck wrote:
The class code would not explicitly learn about the reset,
but it would be informed about the exited modes.
That has drawbacks
Playing devils advocate a bit here
- it doesn't tel
On Thu, Jun 02, 2016 at 01:18:53PM +0300, Heikki Krogerus wrote:
> On Wed, Jun 01, 2016 at 04:29:26PM -0700, Guenter Roeck wrote:
> > On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver Neukum wrote:
> > > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
> > > >
On 06/03/2016 06:21 AM, Heikki Krogerus wrote:
Hi,
On Thu, Jun 02, 2016 at 09:12:19AM -0700, Guenter Roeck wrote:
On Thu, Jun 02, 2016 at 01:18:53PM +0300, Heikki Krogerus wrote:
On Wed, Jun 01, 2016 at 04:29:26PM -0700, Guenter Roeck wrote:
On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver
subsystems do the same, ie create the
> > subsystem
> > device(s) during registration with the subsystem, so this is in line with
> > other
> > kernel code.
> >
> > Should I send you a follow-up patch on top of yours ?
>
> Sure. I'm a little bit stuc
On Thu, Jun 02, 2016 at 02:48:09PM +0800, Frank Wang wrote:
> Signed-off-by: Frank Wang
> ---
>
> Changes in v2:
> - Changed vbus_host optional property from gpio to regulator.
> - Specified vbus_otg-supply optional property.
> - Specified otg_id and otg_bvalid property.
>
> .../bindings/phy
On Thu, Jun 02, 2016 at 02:48:10PM +0800, Frank Wang wrote:
> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block
> than rk3288 and before, and most of phy-related registers are also
> different from the past, so a new phy driver is required necessarily.
>
> Signed-off-by: Frank Wang
On Thu, Jun 02, 2016 at 02:48:10PM +0800, Frank Wang wrote:
> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block
> than rk3288 and before, and most of phy-related registers are also
> different from the past, so a new phy driver is required necessarily.
>
> Signed-off-by: Frank Wang
On Mon, Jun 06, 2016 at 04:45:09PM +0300, Heikki Krogerus wrote:
> Hi,
>
> On Fri, Jun 03, 2016 at 10:20:01PM +0200, Pavel Machek wrote:
> > On Thu 2016-05-19 15:44:54, Heikki Krogerus wrote:
> > > The purpose of this class is to provide unified interface for user
> > > space to get the status and
On Tue, Jun 7, 2016 at 2:54 AM, Heiko Stübner wrote:
> Hi Frank,
>
> Am Montag, 6. Juni 2016, 17:20:04 schrieb Frank Wang:
>> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block
>> than rk3288 and before, and most of phy-related registers are also
>> different from the past, so a new
On Mon, Jun 06, 2016 at 04:28:08PM +0300, Heikki Krogerus wrote:
[ ... ]
>
> I would prefer lower case letters. I don't know the SIDs there are at
> them moment, other then Display Port. Do you know them?
>
SIDs:
0xff00 - power delivery
0xff01 - displayport
0xff02 - MHL
On Tue, Jun 07, 2016 at 04:12:29PM +0200, Heiko Stübner wrote:
> Hi Guenter,
>
> Am Dienstag, 7. Juni 2016, 06:19:45 schrieb Guenter Roeck:
> > On Tue, Jun 7, 2016 at 2:54 AM, Heiko Stübner wrote:
> > > Hi Frank,
> > >
> > > Am Montag, 6. Juni 2016, 17:
On 06/11/2016 12:05 AM, Oliver Neukum wrote:
On Fri, 2016-06-10 at 17:34 +0300, Heikki Krogerus wrote:
+static ssize_t
+preferred_role_store(struct device *dev, struct device_attribute
*attr,
+const char *buf, size_t size)
+{
+ struct typec_port *port = to_typec_port(de
On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote:
> Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang:
>> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block
>> than rk3288 and before, and most of phy-related registers are also
>> different from the past, so a new phy driver
On 06/12/2016 07:10 PM, Frank Wang wrote:
The newer SoCs (rk3366, rk3399) take a different usb-phy IP block
than rk3288 and before, and most of phy-related registers are also
different from the past, so a new phy driver is required necessarily.
Signed-off-by: Frank Wang
---
[ ... ]
+
+stat
On Tue, Jun 14, 2016 at 6:14 PM, Frank Wang wrote:
> Hi Heiko & Guenter,
>
>
> On 2016/6/14 22:00, Heiko Stübner wrote:
>>
>> Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck:
>>>
>>> On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote
On 06/15/2016 06:47 PM, Frank Wang wrote:
Hi Guenter & Heiko,
On 2016/6/15 23:47, Guenter Roeck wrote:
On Tue, Jun 14, 2016 at 6:14 PM, Frank Wang wrote:
Hi Heiko & Guenter,
On 2016/6/14 22:00, Heiko Stübner wrote:
Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck:
On
On 06/16/2016 07:09 PM, Frank Wang wrote:
The newer SoCs (rk3366, rk3399) take a different usb-phy IP block
than rk3288 and before, and most of phy-related registers are also
different from the past, so a new phy driver is required necessarily.
Signed-off-by: Frank Wang
Suggested-by: Guenter
Hi Frank,
On 06/16/2016 11:43 PM, Frank Wang wrote:
Hi Guenter,
On 2016/6/17 12:59, Guenter Roeck wrote:
On 06/16/2016 07:09 PM, Frank Wang wrote:
The newer SoCs (rk3366, rk3399) take a different usb-phy IP block
than rk3288 and before, and most of phy-related registers are also
different
On Sun, Jun 19, 2016 at 6:27 PM, Frank Wang wrote:
> Hi Guenter,
>
>
> On 2016/6/17 21:20, Guenter Roeck wrote:
>>
>> Hi Frank,
>>
>> On 06/16/2016 11:43 PM, Frank Wang wrote:
>>>
>>> Hi Guenter,
>>>
>>> On 2016/6/17 12:59,
Hi Frank,
On Sun, Jun 19, 2016 at 8:32 PM, Frank Wang wrote:
> Hi Heiko & Guenter,
>
>
> On 2016/6/20 11:00, Guenter Roeck wrote:
>>
>> On Sun, Jun 19, 2016 at 6:27 PM, Frank Wang
>> wrote:
>>>
>>> Hi Guenter,
>>>
>>>
>>
On 06/21/2016 06:08 AM, Oliver Neukum wrote:
On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
The purpose of this class is to provide unified interface for user
space to get the status and basic information about USB Type-C
Connectors in the system, control data role swapping, and when
On Tue, Jun 21, 2016 at 09:43:20PM +0200, Oliver Neukum wrote:
> On Tue, 2016-06-21 at 06:24 -0700, Guenter Roeck wrote:
> > On 06/21/2016 06:08 AM, Oliver Neukum wrote:
> > > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
> > >> The purpose of this class i
On Tue, Jun 21, 2016 at 05:51:49PM +0300, Heikki Krogerus wrote:
> Hi,
>
> I'm considering all the RFCs I send after v1 as v2 (I don't remember
> how many I send). Hope this is OK and hope there is nothing big
> missing anymore (or broken).
>
> Sorry about the delay. I've been really busy with so
On 06/22/2016 02:51 AM, Heikki Krogerus wrote:
Hi Guenter,
On Tue, Jun 21, 2016 at 03:25:55PM -0700, Guenter Roeck wrote:
On Tue, Jun 21, 2016 at 05:51:49PM +0300, Heikki Krogerus wrote:
Hi,
I'm considering all the RFCs I send after v1 as v2 (I don't remember
how many I send). Ho
Hi,
On Tue, Jun 21, 2016 at 05:51:50PM +0300, Heikki Krogerus wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and when USB P
On 06/23/2016 05:00 AM, Heikki Krogerus wrote:
Hi Oliver,
On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote:
On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote:
On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote:
No it's not. DRP means a port that can operate as
-by: Frank Wang
> Suggested-by: Heiko Stuebner
> Suggested-by: Guenter Roeck
> Suggested-by: Doug Anderson
Reviewed-by: Guenter Roeck
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 06/27/2016 05:13 AM, Heikki Krogerus wrote:
Hi,
On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote:
May be I am missing user or usage of the driver.. I see this driver is
providing limited information of the Type-C connectors or the port
partner
Yes, this interface can't provide dir
On 06/28/2016 06:12 AM, Heikki Krogerus wrote:
On Mon, Jun 27, 2016 at 06:39:46AM -0700, Guenter Roeck wrote:
On 06/27/2016 05:13 AM, Heikki Krogerus wrote:
Hi,
On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote:
May be I am missing user or usage of the driver.. I see this driver is
On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and when the port s
On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and when the port s
On Fri, Jul 01, 2016 at 03:05:35PM +0300, Heikki Krogerus wrote:
> On Fri, Jul 01, 2016 at 10:13:48AM +0300, Heikki Krogerus wrote:
> > Hi Guenter,
> >
> > On Thu, Jun 30, 2016 at 03:02:20PM -0700, Guenter Roeck wrote:
> > > > +static ssize_t
> > >
On Fri, Jul 01, 2016 at 10:38:03AM +0300, Heikki Krogerus wrote:
> On Thu, Jun 30, 2016 at 10:10:25AM -0700, Guenter Roeck wrote:
> > On Wed, Jun 29, 2016 at 04:38:37PM +0300, Heikki Krogerus wrote:
> > > The purpose of USB Type-C connector class is to provide
> > > uni
On 07/03/2016 12:38 PM, Heikki Krogerus wrote:
On Fri, Jul 01, 2016 at 07:33:12AM -0700, Guenter Roeck wrote:
On Fri, Jul 01, 2016 at 03:05:35PM +0300, Heikki Krogerus wrote:
I've updated my github branch with a commit where both of these issues
should be fixed. Can you give it a try?
On 11/21/2016 06:23 AM, Heikki Krogerus wrote:
On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote:
Hi Greg,
On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote:
+static void typec_partner_release(struct device *dev)
+{
+ struct typec_port *port = to_typec_port(dev->paren
freed.
Also free the virt_devices starting from max slot_id as children
more commonly have higher slot_id than parent.
CC:
Signed-off-by: Mathias Nyman
---
Guenter Roeck, does this work for you?
A rework of how tt_info is stored and used might be needed,
but that will take some time and won'
venient when used
> with sysfs attributes.
>
> Signed-off-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
> ---
> include/linux/string.h | 10 ++
> lib/string.c | 26 ++
> 2 files changed, 36 insertions(+)
>
> diff --git a
hen the port supports
> USB Power Delivery, also control over power role swapping
> and Alternate Modes.
>
> Signed-off-by: Heikki Krogerus
Just a couple of nitpicks, otherwise
Reviewed-by: Guenter Roeck
Guenter
> ---
> Documentation/ABI/testing/sysfs-class-typec | 2
w anything about the chip.
Couple of questions below, otherwise
Reviewed-by: Guenter Roeck
> ---
> drivers/usb/typec/Kconfig | 14 ++
> drivers/usb/typec/Makefile | 1 +
> drivers/usb/typec/typec_wcove.c | 372
>
> 3 file
venient when used
> with sysfs attributes.
>
> Signed-off-by: Heikki Krogerus
Tested-by: Guenter Roeck
> ---
> include/linux/string.h | 10 ++
> lib/string.c | 26 ++
> 2 files changed, 36 insertions(+)
>
> diff --git a/include/
hen the port supports
> USB Power Delivery, also control over power role swapping
> and Alternate Modes.
>
> Signed-off-by: Heikki Krogerus
Tested-by: Guenter Roeck
> ---
> Documentation/ABI/testing/sysfs-class-typec | 222 ++
> Documentation/usb/typec.txt
Hello Heikki,
On 11/22/2016 06:11 AM, Heikki Krogerus wrote:
[ ... ]
+
+struct typec_port *typec_register_port(struct device *dev,
+ const struct typec_capability *cap)
+{
+ struct typec_port *port;
+ int ret;
+ int id;
+
+ port = kzal
freed.
Also free the virt_devices starting from max slot_id as children
more commonly have higher slot_id than parent.
CC:
Signed-off-by: Mathias Nyman
---
Guenter Roeck, does this work for you?
Sorry, I didn't have time this week. I'll test it first thing next week.
Guenter
A rew
On Mon, Nov 28, 2016 at 04:23:23PM +0200, Heikki Krogerus wrote:
> On Mon, Nov 28, 2016 at 11:19:32AM +0100, Oliver Neukum wrote:
> > On Thu, 2016-11-24 at 11:57 +0200, Heikki Krogerus wrote:
> > > On Wed, Nov 23, 2016 at 09:12:04PM -0800, Guenter Roeck wrote:
> >
>
from hibernate, and all virt_devices are freed.
>
> Also free the virt_devices starting from max slot_id as children
> more commonly have higher slot_id than parent.
>
> CC:
> Signed-off-by: Mathias Nyman
>
> ---
>
> Guenter Roeck, does this work for you?
>
will still return an error, but it will do so
only after the long reset timeout.
Cc: Douglas Anderson
Signed-off-by: Guenter Roeck
---
drivers/usb/core/hub.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
On Wed, Nov 30, 2016 at 11:19:10AM +0200, Heikki Krogerus wrote:
> Hi Greg,
>
> On Tue, Nov 29, 2016 at 05:27:44PM +0100, Greg KH wrote:
> > > +struct typec_cable {
> > > + struct device dev;
> > > + enum typec_plug_typetype;
> > > + u32 vdo;
> > > + unsigned int
venient when used
> with sysfs attributes.
>
> Signed-off-by: Heikki Krogerus
> Reviewed-by: Guenter Roeck
> Tested-by: Guenter Roeck
> ---
> include/linux/string.h | 10 ++
> lib/string.c | 26 ++
> 2 files changed, 36 insert
On Wed, Nov 30, 2016 at 01:41:24PM +0200, Mathias Nyman wrote:
> On 28.11.2016 22:24, Guenter Roeck wrote:
> >On Wed, Nov 23, 2016 at 02:24:27PM +0200, Mathias Nyman wrote:
> >>the tt_info provided by a HS hub might be in use to by a child device
> >>Make sure we free
On 12/15/2016 03:50 AM, Heikki Krogerus wrote:
On Wed, Dec 07, 2016 at 02:52:31PM +0200, Heikki Krogerus wrote:
Hi Oliver,
On Wed, Dec 07, 2016 at 10:46:48AM +0100, Oliver Neukum wrote:
On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote:
Hi,
At least for my part I very much
On 12/19/2016 06:45 AM, Heikki Krogerus wrote:
The purpose of USB Type-C connector class is to provide
unified interface for the user space to get the status and
basic information about USB Type-C connectors on a system,
control over data role swapping, and when the port supports
USB Power Delive
On Fri, Jan 06, 2017 at 12:54:05PM +0200, Heikki Krogerus wrote:
> Hi guys,
>
> On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote:
> > > +static ssize_t
> > > +typec_altmode_roles_show(struct device *dev, struct device_attribute
> > > *attr,
> > > + char *buf)
> > >
Hello Heikki,
On Thu, Jan 05, 2017 at 02:01:18PM +0300, Heikki Krogerus wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and
On 01/10/2017 12:54 AM, Heikki Krogerus wrote:
Hi Guenter,
On Mon, Jan 09, 2017 at 08:59:32AM -0800, Guenter Roeck wrote:
+/**
+ * typec_register_partner - Register a USB Type-C Partner
+ * @port: The USB Type-C Port the partner is connected to
+ * @desc: Description of the partner
On Tue, Jan 10, 2017 at 04:46:12PM +0200, Heikki Krogerus wrote:
> On Tue, Jan 10, 2017 at 05:50:04AM -0800, Guenter Roeck wrote:
> > On 01/10/2017 12:54 AM, Heikki Krogerus wrote:
> > > Hi Guenter,
> > >
> > > On Mon, Jan 09, 2017 at 0
On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and when the port s
On Mon, Jan 23, 2017 at 04:44:23PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Heikki Krogerus writes:
> > +static void typec_report_identity(struct device *dev)
> > +{
> > + sysfs_notify(&dev->kobj, "identity", "id_header");
> > + sysfs_notify(&dev->kobj, "identity", "cert_stat");
> > + sysfs_
On Thu, Sep 8, 2016 at 3:29 AM, Heikki Krogerus
wrote:
> Hi Steve,
>
> On Wed, Sep 07, 2016 at 10:00:28PM -0400, Steve Schefter wrote:
>> Hi Heikki.
>>
>> I'm seeing an issue with the USB-C TCPCI driver. On startup, I get a panic
>> with the following error and stack dump.
>>
>> Unable to handle
Hi Steve,
On Thu, Sep 8, 2016 at 9:32 AM, Steve Schefter wrote:
> Hi Guenter.
>
>> I think (hope) I did mention that the tcpci patch was compile tested
>> only. Apologies if not. I'll try to get to it today and send a fix,
>> though it will obviously only be a workaround (config data is platform
On Thu, Sep 8, 2016 at 12:21 PM, Guenter Roeck wrote:
> Hi Steve,
>
> On Thu, Sep 8, 2016 at 9:32 AM, Steve Schefter wrote:
>> Hi Guenter.
>>
>>> I think (hope) I did mention that the tcpci patch was compile tested
>>> only. Apologies if not. I&#
On Thu, Sep 8, 2016 at 12:35 PM, Guenter Roeck wrote:
> On Thu, Sep 8, 2016 at 12:21 PM, Guenter Roeck wrote:
>> Hi Steve,
>>
>> On Thu, Sep 8, 2016 at 9:32 AM, Steve Schefter wrote:
>>> Hi Guenter.
>>>
>>>> I think (hope) I did mentio
Hi Steve,
On Thu, Sep 8, 2016 at 12:42 PM, Steve Schefter wrote:
> Hi Guenter.
>
>>> I would be interested in seeing the test driver, either on the list or
>>> privately if you are not comfortable with a general release.
>>>
>> Please try to clone
>> https://chromium.googlesource.com/chromiumos/t
On Thu, Sep 01, 2016 at 02:49:47PM +0300, Heikki Krogerus wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and when the port s
hen the port supports
> USB Power Delivery, also control over power role swapping
> and Alternate Modes.
>
> Signed-off-by: Heikki Krogerus
Reviewed-by: Guenter Roeck
Tested-by: Guenter Roeck
> ---
> Documentation/ABI/testing/sysfs-class-typec | 218 ++
ous; I'll leave it up to you if
you want send a new version.
Reviewed-by: Guenter Roeck
> ---
> drivers/usb/typec/Kconfig | 14 ++
> drivers/usb/typec/Makefile | 1 +
> drivers/usb/typec/typec_wcove.c | 368
>
Maybe add
On Fri, Sep 9, 2016 at 5:26 PM, Jun Li wrote:
> Hi Guenter,
>
>> -Original Message-
>> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
>> ow...@vger.kernel.org] On Behalf Of Guenter Roeck
>> Sent: Wednesday, August 24, 2016 5:11 AM
>> To:
On Sun, Sep 11, 2016 at 7:16 PM, Jun Li wrote:
> Hi Guenter
>
>> -Original Message-----
>> From: Guenter Roeck [mailto:gro...@google.com]
>> Sent: Saturday, September 10, 2016 10:23 AM
>> To: Jun Li
>> Cc: Guenter Roeck ; Felipe Balbi
>> ; Chandra S
Hi folks,
In dwc3-of-simple.c:dwc3_of_simple_remove(), I see the following code.
for (i = 0; i < simple->num_clocks; i++) {
clk_unprepare(simple->clks[i]);
clk_put(simple->clks[i]);
}
What I don't understand is why clk_unprepare() is called instead
Hi Felipe,
On Mon, Sep 12, 2016 at 10:05:00PM +0300, Felipe Balbi wrote:
>
> Hi Guenter,
>
> Guenter Roeck writes:
> > Hi folks,
> >
> > In dwc3-of-simple.c:dwc3_of_simple_remove(), I see the following code.
> >
> >
On 09/12/2016 10:35 PM, Felipe Balbi wrote:
Hi,
Guenter Roeck writes:
Should it be clk_disable_unprepare(), or maybe something like the
following
if (!pm_runtime_status_suspended(dev))
clk_disable_unprepare();
else
clk_unprepare();
I'
On Thu, Sep 29, 2016 at 7:35 AM, Jun Li wrote:
> Hi Guenter,
>
>> -Original Message-
>> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
>> ow...@vger.kernel.org] On Behalf Of Guenter Roeck
>> Sent: Wednesday, August 24, 2016 5:11 AM
>> To:
On Thu, Sep 29, 2016 at 11:41 PM, Jun Li wrote:
> Hi,
>
>> -Original Message-----
>> From: Guenter Roeck [mailto:gro...@google.com]
>> Sent: Friday, September 30, 2016 12:37 AM
>> To: Jun Li
>> Cc: Guenter Roeck ; Felipe Balbi
>> ; Chandra Sekha
1 - 100 of 505 matches
Mail list logo
