Correct use of devnum in supports_autosuspend documentation, the sysfs path
contains busnum-port.port.port not busnum-devnum (which is the usb bus device
address).
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/ABI/testing/sysfs-bus-usb | 2 +-
1 file changed, 1 insertion
Hi All,
Here is a resend of a usb patchset I wrote a while back. This new version
incorporate the documentation fixes (spelling) and documentation improvements
suggested in the reviews of v1.
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a
de Goede hdego...@redhat.com
---
drivers/usb/core/config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 7199adc..a6b2cab 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -424,7 +424,8
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/ABI/testing/sysfs-bus-usb | 38 +
1 file changed, 38 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-usb
b/Documentation/ABI/testing/sysfs-bus-usb
index c117dda..8835ac3 100644
The config descriptors as read from /proc/bus/usb/BBB/DDD are in *bus* endian
format. Correct proc_usb_info.txt to correctly reflect that.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/usb/proc_usb_info.txt | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff
Hi All,
This patch adds documentation for all sysfs files used by libusb.
Changes in v2:
-Spelling fixes
-Add text about writing to bConfigurationValue, suggested by Alan Stern
Changes in v3:
-Rebase on latest usb-next
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/ABI/testing/sysfs-bus-usb | 38 +
1 file changed, 38 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-usb
b/Documentation/ABI/testing/sysfs-bus-usb
index 9c8926c..b0b9bb4 100644
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 103 ++
include/uapi/linux/usbdevice_fs.h | 7 +++
2 files changed, 110 insertions(+)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 94e7839
This is a preparation patch for adding support for bulk streams.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 737e3c1
have
garbage in there (as it was unused until now in the bulk case), will not
break
2) This patch does not add support for allocating / freeing bulk-streams, that
is done in a follow up patch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 4
Hi All,
As discussed a long while back, usbfs is currently missing bulk streams
support, and we ought to fix this. So this patch extends the usbfs API with
bulk stream support. Please review.
Note this patch-set is compile-tested only, since I don't have access to
any USB-3 devices using bulk
This is a preparation patch for adding support for bulk streams to usbfs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 28 ++--
include/linux/usb.h| 1 +
2 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/core
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index c7e946f..94e7839 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb
Hi,
On 08/14/2013 12:18 PM, Johan Hovold wrote:
On Wed, Aug 14, 2013 at 11:17:57AM +0200, Hans de Goede wrote:
+What: /sys/bus/usb/devices/.../busnum
+KernelVersion: 2.6.22
+Description:
+ Bus-number of the USB-bus the device is connected to.
+
+What: /sys/bus
Hi All,
This patch adds documentation for all sysfs files used by libusb.
Changes in v2:
-Spelling fixes
-Add text about writing to bConfigurationValue, suggested by Alan Stern
Changes in v3:
-Rebase on latest usb-next
Changes in v4:
-Improve the wording for the descriptors text, suggested by
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/ABI/testing/sysfs-bus-usb | 38 +
1 file changed, 38 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-usb
b/Documentation/ABI/testing/sysfs-bus-usb
index 9c8926c..0053ae2 100644
Hi,
On 08/14/2013 08:21 PM, Greg KH wrote:
On Wed, Aug 14, 2013 at 02:32:01PM +0200, Hans de Goede wrote:
Hi All,
As discussed a long while back, usbfs is currently missing bulk streams
support, and we ought to fix this. So this patch extends the usbfs API with
bulk stream support. Please
Hi,
On 08/15/2013 12:42 PM, Hans de Goede wrote:
snip
What device did you find? I have yet to see a shipping device with
streams...
I don't know about streams, I'm hoping that having a uasp device means it will
also use streams. So far I've been unable to get my hands on anything doing
Hi,
On 08/15/2013 06:00 PM, Sarah Sharp wrote:
On Wed, Aug 14, 2013 at 02:32:03PM +0200, Hans de Goede wrote:
- /* Streams only apply to bulk endpoints. */
- for (i = 0; i num_eps; i++)
+ for (i = 0; i num_eps; i++) {
+ /* Streams only apply to bulk endpoints
Hi,
On 08/22/2013 12:54 AM, Sarah Sharp wrote:
On Thu, Aug 15, 2013 at 10:33:42PM +0200, Hans de Goede wrote:
Hi,
On 08/15/2013 12:42 PM, Hans de Goede wrote:
snip
What device did you find? I have yet to see a shipping device with
streams...
I don't know about streams, I'm hoping
Hi All,
I'm very happy to announce libusbx-1.0.17-rc1.
2013-08-28: v1.0.17-rc1
* Hotplug callbacks now always get passed a libusb_context, even if it is
the default context. Previously NULL would be passed for the default context,
but since the first context created is the default context,
Cc: Greg KH gre...@linuxfoundation.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/ABI/stable/sysfs-bus-usb | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/ABI/stable/sysfs-bus-usb
b/Documentation/ABI/stable/sysfs-bus-usb
index 6b59aea..a596414
Cc: Greg KH gre...@linuxfoundation.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/ABI/stable/sysfs-bus-usb | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Documentation/ABI/stable/sysfs-bus-usb
b/Documentation/ABI/stable/sysfs-bus-usb
index a596414
Cc: Greg KH gre...@linuxfoundation.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
Documentation/ABI/stable/sysfs-bus-usb | 126 +++
Documentation/ABI/testing/sysfs-bus-usb | 127
2 files changed, 126 insertions(+), 127
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index c7e946f..94e7839 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb
Hi All,
As discussed a long while back, usbfs is currently missing bulk streams
support, and we ought to fix this. So this patch extends the usbfs API with
bulk stream support.
Note this patch-set is compile-tested only atm. I now have an USB-3 disk dock
which actually supports UAS and up to 4
This is a preparation patch for adding support for bulk streams.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 737e3c1
have
garbage in there (as it was unused until now in the bulk case), will not
break
2) This patch does not add support for allocating / freeing bulk-streams, that
is done in a follow up patch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 4
This is a preparation patch for adding support for bulk streams to usbfs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 40 +++-
include/linux/usb.h| 1 +
2 files changed, 32 insertions(+), 9 deletions(-)
diff --git
The hcd-driver free_streams method can return an error, so lets properly
propagate that.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 11 +++
include/linux/usb.h| 2 +-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/core
Hi,
On 08/30/2013 08:09 PM, Greg KH wrote:
On Fri, Aug 30, 2013 at 02:03:59PM +0200, Hans de Goede wrote:
The hcd-driver free_streams method can return an error, so lets properly
propagate that.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 11
Hi All,
I'm very happy to announce libusbx-1.0.17.
2013-09-06: v1.0.17
* Hotplug callbacks now always get passed a libusb_context, even if it is
the default context. Previously NULL would be passed for the default context,
but since the first context created is the default context, and most
Hi,
On 09/08/2013 01:37 PM, Frank Dierich wrote:
Hi,
I have an ASUS A8JP Notebook with Ubuntu 12.04 with the following build in
webcam
Bus 001 Device 004: ID 0ac8:0321 Z-Star Microelectronics Corp. Vimicro
generic vc0321 Camera
The camera is working nice with Cheese and kernels before
Hi,
On 09/17/2013 08:25 PM, Frank Dierich wrote:
On 09/09/2013 02:09 PM, Hans de Goede wrote:
Thanks for the bug report, looking at the bug reports, they all report an error
of -71 which is
EPROTO, which typically means something is wrong at the USB level.
And nothing has changed
,
2.6.37.6, 2.6.38.8, 2.6.39.4, 3.0.94, 3.1.10. In all later kernels I have
tested (3.2.50, 3.4.60, 3.10.10, 3.11.0, 3.12.0-rc1) Cheese shows for some
seconds a green and noisy image and crashes then with a segmentation fault.
Hans de Goede supposed that the error is caused by usb sub-system because
are
always available. They do not require any locking. The same is true
of the cached interface string descriptor, because it is not
deallocated until the usb_host_interface structure is destroyed.
Signed-off-by: Alan Stern st...@rowland.harvard.edu
CC: Hans de Goede hdego...@redhat.com
Looks
gustavo.pado...@collabora.co.uk
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/bluetooth/btusb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 8e16f0a..d0b3d90 100644
--- a/drivers/bluetooth/btusb.c
502f769662978a2fe99d0caed5e53e3006107381.
Cc: Shuah Khan shuah...@samsung.com
Cc: Gustavo Padovan gustavo.pado...@collabora.co.uk
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/bluetooth/btusb.c | 1 -
1 file changed, 1 deletion(-)
Patch has been applied to bluetooth.git. Thanks.
why
Before this a device needing ie 32 stream ctxs would end up with an entry from
the small_streams_pool which has 256 bytes entries, where as 32 stream ctxs
need 512 bytes. Things actually keep running for a surprisingly long time
before crashing because of this.
Signed-off-by: Hans de Goede hdego
.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-mem.c | 53 ++---
drivers/usb/host/xhci.h | 2 ++
2 files changed, 42 insertions(+), 13 deletions(-)
diff --git a/drivers/usb
0x81
, streams are already disabled!
[ 96.982400] xhci_hcd :01:00.0: WARN xhci_free_streams() called with
non-streams endpoint
But it is better to also warn about the actual cause of this later warnings.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 23
Hi All,
After spending 1.5 weeks debugging issues with xhci streams which would
hard-freeze my machine every 5 minutes, I'm very happy to present this
patch set, with which usb 3 streams are fully stable for me, including
using them from userspace through qemu usb redirection (I'll post
kernel
.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-ring.c | 5 -
drivers/usb/host/xhci.h | 3 ++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 1ad397f..bed4cfa 100644
--- a/drivers/usb
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-ring.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 411da1f..1ad397f 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b
the Nec
writes the ptr to both the ep and stream contexts when streams are used.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-ring.c | 22 +++---
drivers/usb/host/xhci.h | 1 +
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git
Hi All,
As a result of all my streams work, I've started to wonder if it would not
be better to leave bulk endpoints with streams disabled until streams are
allocated. It seems to me that allowing to submit non stream bulk transfers
on stream eps is not useful, and could even be harmful if it
The ss_ep_comp bmAttributes filed can contain more info then just the
streams, use usb_ss_max_streams to properly get max streams.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 102dbd2..107e107 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb
This is a preparation patch for adding support for bulk streams.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 7dfaa87
This is a preparation patch for adding support for bulk streams to usbfs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 40 +++-
include/linux/usb.h| 1 +
2 files changed, 32 insertions(+), 9 deletions(-)
diff --git
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 113 ++
include/uapi/linux/usbdevice_fs.h | 7 +++
2 files changed, 120 insertions(+)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 107e107
have
garbage in there (as it was unused until now in the bulk case), will not
break
2) This patch does not add support for allocating / freeing bulk-streams, that
is done in a follow up patch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 4
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 9795a21..bd5acdd 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2077,8
Hi All,
I'm very happy to present the (hopefully) final version of my patch set
for adding bulk stream support to usbfs. I've tested this using an uas device
redirected to a qemu vm (which uses usbfs to access the device), and with
the xhci fixes I send yesterday this works well.
This patch set
Documentation/usb/bulk-streams.txt says:
All stream IDs will be deallocated when the driver releases the interface, to
ensure that drivers that don't support streams will be able to use the endpoint
This commit actually implements this.
Signed-off-by: Hans de Goede hdego...@redhat.com
So that it can be used in other places too.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/config.c | 1 -
include/linux/usb.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index a6b2cab
trust userspace to get this right, so enforce it by killing any
urbs still pending on the interface.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index
Hi,
On 10/04/2013 05:35 PM, Alan Stern wrote:
On Fri, 4 Oct 2013, Hans de Goede wrote:
This is a preparation patch for adding support for bulk streams to usbfs.
+ for (i = 0; i num_eps; i++)
+ eps[i]-has_streams = 1;
--- a/include/linux/usb.h
+++ b/include/linux
Hi,
On 10/04/2013 05:37 PM, Alan Stern wrote:
On Fri, 4 Oct 2013, Hans de Goede wrote:
Documentation/usb/bulk-streams.txt says:
All stream IDs will be deallocated when the driver releases the interface, to
ensure that drivers that don't support streams will be able to use the endpoint
Hi,
On 10/04/2013 05:44 PM, Alan Stern wrote:
On Fri, 4 Oct 2013, Hans de Goede wrote:
+static int parse_usbdevfs_streams(struct usb_device *dev,
+ struct usbdevfs_streams __user *streams,
+ unsigned int *num_streams_ret
Hi,
On 10/04/2013 08:43 PM, Alan Stern wrote:
On Fri, 4 Oct 2013, Hans de Goede wrote:
+ struct usb_host_endpoint *ep, *eps[USB_MAXENDPOINTS];
That's a big array to put on the stack: 30 entries each containing 8
bytes (on a 64-bit arch).
I was wondering about this myself when I
Hi,
On 10/02/2013 08:39 PM, Sarah Sharp wrote:
On Wed, Oct 02, 2013 at 10:22:52AM -0400, Alan Stern wrote:
snip
We should consider this before rushing into a new API.
Yes, I agree. :) That's why I'd like to see some cases in the media
drivers code where it could benefit from changing the
Hi All,
While working on uas (to test usb 3 bulk streams) I added a LOGICAL_UNIT_RESET
at uas probe time for testing purposes, this exercises the uas driver
task mgmt code, and sometimes fails because usb_wait_anchor_empty_timeout
(unexpectedly) returns before the last anchored urbs completion
And do so in a way which ensures that any fields added in the future will
also get properly zero-ed.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/usb.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 8ad6e7e..2b5d08b
handler (rtlwifi).
So I have come up with this patch instead, which adds the ability to
suspend wakeups of usb_wait_anchor_empty_timeout() waiters to the usb_anchor
functionality, and uses this in __usb_hcd_giveback_urb() to delay wake-ups
until the completion handler has run.
Signed-off-by: Hans de
Hi all,
Here is v2 of my patch-set for adding bulk stream support to usbfs. I've
tested this using an uas device redirected to a qemu vm (which uses usbfs to
access the device), and with the xhci fixes I send a while back this works
well.
This patch set has the following changes compared to v1:
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 149cdf1..15d935d 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2080,8
have
garbage in there (as it was unused until now in the bulk case), will not
break
2) This patch does not add support for allocating / freeing bulk-streams, that
is done in a follow up patch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 4
This is a preparation patch for adding support for bulk streams to usbfs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 40 +++-
include/linux/usb.h| 1 +
2 files changed, 32 insertions(+), 9 deletions(-)
diff --git
This is a preparation patch for adding support for bulk streams.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index e1ebbd1
trust userspace to get this right, so enforce it by killing any
urbs still pending on the interface.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index
Documentation/usb/bulk-streams.txt says:
All stream IDs will be deallocated when the driver releases the interface, to
ensure that drivers that don't support streams will be able to use the endpoint
This commit actually implements this.
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 00487a0..bfb2821 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 118 ++
include/uapi/linux/usbdevice_fs.h | 7 +++
2 files changed, 125 insertions(+)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index bfb2821
So that it can be used in other places too.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/config.c | 1 -
include/linux/usb.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index a6b2cab
Hi,
Thanks for the quick review!
On 10/09/2013 07:00 PM, Oliver Neukum wrote:
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote:
So I have come up with this patch instead, which adds the ability to
suspend wakeups of usb_wait_anchor_empty_timeout() waiters to the usb_anchor
Hi,
On 10/10/2013 09:04 PM, Sarah Sharp wrote:
On Fri, Oct 04, 2013 at 12:29:43AM +0200, Hans de Goede wrote:
Hi All,
Hi Hans,
After spending 1.5 weeks debugging issues with xhci streams which would
hard-freeze my machine every 5 minutes, I'm very happy to present this
patch set
are moved to
make them static.]
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-mem.c | 132 +---
drivers/usb/host/xhci.h
Note this patch is probably best squashed into the original
For streams the dequeue ptr must be read from the stream ctx patch.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host
Note this patch is probably best squashed into my
usb-core: Track if an endpoint has streams patch.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/usb.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 1c924eb..a4c8406 100644
Hi,
On 10/17/2013 06:42 PM, Sarah Sharp wrote:
All right, so we have a couple sparse warnings with this patch.
On Thu, Oct 17, 2013 at 01:40:15PM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
fun-streams-fixes
head:
-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 080851d..11e3679 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb
- Rename labels to properly reflect this
- Don't skip free-ing the streams when scsi_init_shared_tag_map fails
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/storage
The cmd endpoint never has streams, so the stream_id parameter is unused.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 286225e
usb_device_reset is called, and taking this lock will also
protect the usage of the resetting flag in the pre and post reset handlers.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff
-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 6436486..286225e 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb
it all that ugly :)
I've also run various tests and it seems to work as advertised (I've not
managed to trigger the error path though AFAIK).
Acked-by: Hans de Goede hdego...@redhat.com
Sarah Sharp
drivers/usb/host/xhci-mem.c | 106 +---
1 file changed
usb_submit_urb
failure.
With this fixed the uas code works nicely with an uas device plugged into
an ehci port.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/storage/uas.c b
Hi,
Ignore please I accidentally left some debugging in here,
expect a v2 shortly.
Regards,
Hans
On 10/17/2013 11:22 PM, Hans de Goede wrote:
I thought it would be a good idea to also test uas with usb-2, and it turns out
it ws, as it did not work. The problem is that the uas driver
usb_submit_urb
failure.
With this fixed the uas code works nicely with an uas device plugged into
an ehci port.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb
Hi,
On 10/18/2013 04:01 PM, Alan Stern wrote:
On Thu, 17 Oct 2013, Hans de Goede wrote:
I thought it would be a good idea to also test uas with usb-2, and it turns out
it ws, as it did not work. The problem is that the uas driver was passing the
bEndpointAddress' direction bit
Hi All,
Here is v2 of this patch, new in v2:
-use usb_endpoint_num() to get the endpoint num, rather then masking ourselves
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at
usb_submit_urb failure.
With this fixed the uas code works nicely with an uas device plugged into
an ehci port.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers
Hi,
On 10/21/2013 09:21 AM, Oliver Neukum wrote:
On Thu, 2013-10-17 at 20:49 +0200, Hans de Goede wrote:
The uas driver is only capable of dealing with an usb-reset it has triggered
itself, fix the pre and post reset return values to reflect this.
What happens if you get an external reset
Hi All,
Here is v2 of my uas: Deal with externally triggered reset, and fix reset
locking patch, now split into 2 patches.
Besides being split into 2 patches, this new version should deal properly
with externally triggered resets. Note this is RFC only for now, as I'm
travelling without access
Handle usb-device resets not triggered from uas_eh_bus_reset_handler(), when
this happens, disable cmd queuing during the reset, and wait for existing
requests to finish in pre_reset.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 47
Fix the uas_eh_bus_reset_handler not properly taking the usbdev lock
before calling usb_device_reset, the usb-core expects this lock to be
taken when usb_device_reset is called.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 9 +
1 file changed, 9
Hi,
On 10/22/2013 08:52 PM, Oliver Neukum wrote:
On Tue, 2013-10-22 at 16:58 +0100, Hans de Goede wrote:
Handle usb-device resets not triggered from uas_eh_bus_reset_handler(), when
this happens, disable cmd queuing during the reset, and wait for existing
requests to finish in pre_reset.
Hm
Hi All,
This is / should be my final set of uas fixes. After this set my uas
to-do list is empty and uas should be in good shape to go into 3.14 .
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
This is a preparation patch for teaching usb-storage to not bind to
uas devices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 40
drivers/usb/storage/uas.c| 40 ++--
2
1 - 100 of 1177 matches
Mail list logo
