It is required by the OMAP glue driver, but it already depends
on it. The core driver should not depend on it. This will
allow the use of the PCI glue driver again.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/Kconfig | 1 -
1 file changed, 1 deletion
Add PCI id for Intel BayTrail.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/dwc3-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 9b13812..997ebe4 100644
--- a/drivers/usb/dwc3/dwc3
It's not used anymore.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
include/linux/usb/intel_mid_otg.h | 180 --
1 file changed, 180 deletions(-)
delete mode 100644 include/linux/usb/intel_mid_otg.h
diff --git a/include/linux/usb
Remove an extra return from the bottom.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/phy/phy-generic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index 68c5548..2b96311 100644
--- a/drivers
Hi,
phy-generic broke dwc3-pci after the gpio support was added. The last
patch is fixing that issue. The other two are just cleanups.
Thanks,
Heikki Krogerus (3):
usb: phy: generic: fix a compiler warning
usb: phy: generic: clean up the probe function
usb: dwc3: fix the glue drivers
Just because it annoys me.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/phy/phy-generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index fce3a9e..68c5548 100644
Hi,
On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote:
Why would you need to know if the PHY drivers are needed or not
explicitly in your controller driver?
because, one way or another, they all do need it. Except for quirky ones
like AM437x where a USB3 IP was hardwired into
Hi,
On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote:
On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote:
On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote:
For the controller drivers the PHYs are just a resource like any
other. The controller drivers
,
that contain commit 69e848c2090aebba5698a1620604c7dccb448684
Intel xhci: Support EHCI/xHCI port switching.
Signed-off-by: Chew, Chiau Ee chiau.ee.c...@intel.com
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/ehci-pci.c |3
On Tue, May 21, 2013 at 10:37:55AM -0400, Alan Stern wrote:
On Tue, 21 May 2013, Heikki Krogerus wrote:
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 595d210..a5708d9 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -322,7
On Tue, May 21, 2013 at 04:26:43PM +0400, Sergei Shtylyov wrote:
Like the xHCI controller on Intel Panther Point and Lynx Point
chipsets, the xHCI controller on Intel BayTrail has also ports that
can be switched between the EHCI host controller.
s/between/to/
OK. Thanks,
--
heikki
--
Hi Sarah,
On Fri, May 24, 2013 at 09:55:25AM -0700, Sarah Sharp wrote:
At this point the port switchover quirk is getting unwieldy. I know of
at least two more platforms that will need the switchover quirk, and
it's silly to keep adding them to the list.
Heikki, can you change the code to
Hi,
On Tue, Aug 28, 2012 at 03:03:12PM +0800, Richard Zhao wrote:
+static int mxs_phy_set_host(struct usb_otg *otg, struct usb_bus *host)
+{
Shouldn't you at least save the host pointer?
otg-host = host;
+ return 0;
+}
+
+static int mxs_phy_set_peripheral(struct usb_otg *otg,
+
is
not enabled.
Reported-by: Chew, Chiau Ee chiau.ee.c...@intel.com
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
include/linux/phy/phy.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
Hi,
On Tue, Apr 15, 2014 at 06:24:11PM +0530, Vivek Gautam wrote:
I had seen your patches in the mailing list, but i don't see any
updated version of these patches.
Are you planning to work on this above mentioned patch-series any time soon ?
I'm sorry, I forgot this completely. I have not
This allows resources such as GPIOs and clocks, which can be
matched based on the device name when requested, to be
assigned even when PLATFORM_DEVID_AUTO is used.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/base
On some platforms a PHY may need to be handled also in the
host controller driver. Exynos5420 SoC requires some PHY
tuning based on the USB speed. This patch delivers dwc3's
PHYs to the xhci platform device when it's created.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc
The users of the old method are now converted to the new one.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/phy/phy-bcm-kona-usb2.c | 2 +-
drivers/phy/phy-core.c | 45 +++--
drivers/phy/phy-exynos-dp-video.c | 2
Provide complete association for the phy and it's user
(musb) with the new phy lookup method.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Tony Lindgren t...@atomide.com
---
arch/arm/mach-omap2/twl-common.c | 18 --
1 file changed, 8 insertions(+), 10
in clkdev.c.
Vivek needs to handle the phys of dwc3 also in xhci driver on
Exynos5420 SoC, so I'm resending these now.
Heikki Krogerus (6):
phy: safer to_phy() macro
phy: improved lookup method
arm: omap3: twl: use the new lookup method with usb phy
phy: remove the old lookup method
base
This makes to_phy() macro work with other variable names
besides dev.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
include/linux/phy/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 2760744
Removes the need for the phys to be aware of their users
even when not using DT. The method is copied from clkdev.c.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
Documentation/phy.txt | 66 ---
drivers/phy/phy-core.c | 135
This driver is based on drivers/power/isp1704_power.c. It
simply converts the original driver to ulpi driver.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/phy/ulpi/Kconfig| 10 +
drivers/phy/ulpi/Makefile | 1 +
drivers/phy/ulpi/isp1704_ulpi.c | 446
Registers ULPI interface with the ULPI abstraction layer if
the HSPHY type is ULPI, which will create phy instance for
usb2.
Depends on Kishon's patch set adding support for generic PHY
framework.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/Kconfig | 7
at this stage, before I make any drivers on top of
this thing. The isp1704_ulpi.c I made just as an example for now.
Thanks,
Heikki Krogerus (3):
phy: add USB ULPI abstraction layer
usb: dwc3: add ULPI interface support
phy: ulpi: add support for NXP ISP170X USB PHY
drivers/phy/Kconfig
layer allows runtime detection. This makes it
possible to take advantage of vendor specific functions of
the PHYs with product specific drivers without the need for
platform or device specific quirks.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/phy/Kconfig
Hi,
On Mon, Dec 02, 2013 at 04:20:51PM +0530, Kishon Vijay Abraham I wrote:
Hi,
On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote:
ULPI PHY is an USB2 PHY that is accessed from the USB
controller. ULPI PHYs allow discovery based on vendor and
product ids which allows binding
Hi,
On Mon, Dec 02, 2013 at 04:24:31PM +0530, Kishon Vijay Abraham I wrote:
Hi,
On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote:
snip
diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile
index dd17601..8bb82bc 100644
--- a/drivers/usb/dwc3/Makefile
+++ b
Hi,
On Mon, Dec 02, 2013 at 04:33:26PM +0530, Kishon Vijay Abraham I wrote:
Hi,
On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote:
Hi guys,
PCI does not give any information about the PHY but we still need to
be able to take advantage of any possible vendor specific
On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote:
@@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct
usb_phy_gen_xceiv *nop,
{
int err;
+ if (nop-ulpi_vbus 0) {
+ unsigned int flags = 0;
+
+ if (nop-ulpi_vbus 0x1)
Hi,
On Thu, Oct 17, 2013 at 09:54:26AM -0500, Felipe Balbi wrote:
On Wed, Oct 16, 2013 at 04:27:26PM +0300, Roger Quadros wrote:
On 10/16/2013 04:10 PM, Kishon Vijay Abraham I wrote:
Do you know if there are users of dwc3 other than exynos5250 and omap5?
If not, we should get rid of the
Hi Kishon,
On Wed, Oct 16, 2013 at 01:24:12AM +0530, Kishon Vijay Abraham I wrote:
+ count = of_property_match_string(node, phy-names, usb2-phy);
+ if (count = 0 || (pdata pdata-usb2_generic_phy)) {
+ dwc-usb2_generic_phy = devm_phy_get(dev, usb2-phy);
+ if
Hi Chris,
On Wed, Dec 04, 2013 at 03:16:21PM +0800, Chris Ruehl wrote:
On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote:
On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote:
@@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct
usb_phy_gen_xceiv *nop
Hi guys,
Kishon, sorry I did not see this v3 set.
On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
There can be systems which does not have an external phy, so get
phy only if no quirks are added that indicates the PHY is not present.
Introduced two quirk flags to
Hi,
On Thu, Dec 05, 2013 at 12:04:46PM +0530, Kishon Vijay Abraham I wrote:
On Wednesday 04 December 2013 08:10 PM, Heikki Krogerus wrote:
On Mon, Nov 25, 2013 at 03:31:24PM +0530, Kishon Vijay Abraham I wrote:
There can be systems which does not have an external phy, so get
phy only
Hi,
On Fri, Dec 06, 2013 at 02:15:30PM -0600, Felipe Balbi wrote:
On Tue, Dec 03, 2013 at 12:39:50PM +0200, Heikki Krogerus wrote:
On Thu, Oct 17, 2013 at 09:54:26AM -0500, Felipe Balbi wrote:
On Wed, Oct 16, 2013 at 04:27:26PM +0300, Roger Quadros wrote:
On 10/16/2013 04:10 PM, Kishon
Hi,
On Mon, Dec 09, 2013 at 12:43:37PM +0530, Kishon Vijay Abraham I wrote:
On Thursday 05 December 2013 01:28 PM, Heikki Krogerus wrote:
On Thu, Dec 05, 2013 at 12:04:46PM +0530, Kishon Vijay Abraham I wrote:
On Wednesday 04 December 2013 08:10 PM, Heikki Krogerus wrote:
On Mon, Nov 25, 2013
Hi,
On Tue, Dec 10, 2013 at 04:25:25PM +0530, Vivek Gautam wrote:
@@ -170,6 +189,15 @@ static int xhci_plat_probe(struct platform_device *pdev)
}
/*
+ * The parent of the xhci-plat device may pass in a PHY via
+ * platform data. If it exists, store it in our struct
Hi,
On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote:
Some PHY controllers may need to tune PHY post-initialization,
so that the PHY consumers can call phy-tuning at appropriate
point of time.
Signed-off-by: vivek Gautam gautam.vi...@samsung.com
---
drivers/phy/phy-core.c |
Hi,
On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote:
On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus
I think setup instead of tune is much more clear and reusable.
I think setup will look more like first time setting up the phy,
which is rather served by init callback
Hi,
On Mon, Dec 09, 2013 at 11:26:04AM +0200, Heikki Krogerus wrote:
Can you guys explain why is something like this needed? Like with
clocks and gpios, the device drivers shouldn't need to care any more
if the platform has the phys or not. -ENODEV tells you your platform
Shouldn't we
.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/dwc3-exynos.c | 1 +
drivers/usb/dwc3/dwc3-pci.c| 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 8b20c70..28c8ad7 100644
--- a/drivers
Hi Felipe,
On Tue, Jan 21, 2014 at 08:47:25AM -0600, Felipe Balbi wrote:
On Tue, Jan 21, 2014 at 03:41:38PM +0530, Kishon Vijay Abraham I wrote:
Since PHYs for dwc3 is optional (not all SoCs that have DWC3 use PHYs),
do not return from probe if the USB PHY library returns -ENODEV as that
On Mon, Jul 14, 2014 at 07:55:43AM -0700, Greg Kroah-Hartman wrote:
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 9e9227e..e856bc4 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -177,11 +177,45 @@ struct platform_object {
*/
The users of the old method are now converted to the new one.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
---
drivers/phy/phy-bcm-kona-usb2.c | 2 +-
drivers/phy/phy-core.c | 45
requested them.
By naming the device already in platform_device_alloc, the
resources can be assigned before platform_device_add is
called.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/base/platform.c | 69
Removes the need for the phys to be aware of their users
even when not using DT. The method is copied from clkdev.c.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
---
Documentation/phy.txt | 66 ---
drivers
On some platforms a PHY may need to be handled also in the
host controller driver. Exynos5420 SoC requires some PHY
tuning based on the USB speed. This patch delivers dwc3's
PHYs to the xhci platform device when it's created.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested
Provide complete association for the phy and it's user
(musb) with the new phy lookup method.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
arch/arm/mach-omap2/twl-common.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/arch/arm/mach
This makes to_phy() macro work with other variable names
besides dev.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
---
include/linux/phy/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/phy
On Mon, Aug 25, 2014 at 01:11:34PM +0530, Vivek Gautam wrote:
Please squash the attached diff which removes the 'init_data' field
from some of the other instances
of devm_phy_create() in few other drivers.
This should prevent any build errors that i could see with multi_v7_defconfig.
OK, I'll
The users of the old method are now converted to the new one.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
---
drivers/phy/phy-bcm-kona-usb2.c | 2 +-
drivers/phy/phy-berlin-sata.c| 2 +-
drivers/phy/phy-core.c
On Thu, Sep 11, 2014 at 08:56:15PM +0530, Kishon Vijay Abraham I wrote:
+static struct phy_lookup twl4030_usb_lookup = {
+ .phy_name = phy-twl4030_usb.0,
+ .dev_id = musb-hdrc.0,
+ .con_id = usb,
};
Can use PHY_LOOKUP no?
I'll fix this.
Thanks,
--
On Thu, Sep 11, 2014 at 09:03:06PM +0530, Kishon Vijay Abraham I wrote:
+static struct phy *phy_find(struct device *dev, const char *con_id)
+{
+ const char *dev_id = dev ? dev_name(dev) : NULL;
+ int match, best_found = 0, best_possible = 0;
+ struct phy *phy = ERR_PTR(-ENODEV);
On Fri, Sep 12, 2014 at 07:41:56PM +0530, Kishon Vijay Abraham I wrote:
I don't think create lookup should be in host init. If it's dt boot, the
binding should be in dt data or for other boot modes the bindig should be
done
in the board file. This just seems hacky to me.
So are you
On Fri, Sep 12, 2014 at 08:16:01PM +0530, Kishon Vijay Abraham I wrote:
Assume you have 2 phys in your system..
static struct phy_lookup usb_lookup = {
.phy_name = phy-usb.0,
.dev_id = usb.0,
.con_id = usb,
};
static struct phy_lookup sata_lookup =
On Tue, Sep 16, 2014 at 12:07:00PM +0530, Kishon Vijay Abraham I wrote:
Hi,
On Monday 15 September 2014 05:36 PM, Heikki Krogerus wrote:
On Fri, Sep 12, 2014 at 07:41:56PM +0530, Kishon Vijay Abraham I wrote:
I don't think create lookup should be in host init. If it's dt boot
On Mon, Sep 15, 2014 at 03:35:08PM +0300, Heikki Krogerus wrote:
On Fri, Sep 12, 2014 at 08:16:01PM +0530, Kishon Vijay Abraham I wrote:
Assume you have 2 phys in your system..
static struct phy_lookup usb_lookup = {
.phy_name = phy-usb.0,
.dev_id = usb.0
On Mon, Sep 22, 2014 at 05:07:55PM +0530, Kishon Vijay Abraham I wrote:
On Thursday 18 September 2014 03:55 PM, Heikki Krogerus wrote:
On Mon, Sep 15, 2014 at 03:35:08PM +0300, Heikki Krogerus wrote:
On Fri, Sep 12, 2014 at 08:16:01PM +0530, Kishon Vijay Abraham I wrote:
Assume you have 2
On Tue, Sep 23, 2014 at 04:33:09PM +0530, Kishon Vijay Abraham I wrote:
Hi,
On Tuesday 23 September 2014 04:23 PM, Heikki Krogerus wrote:
On Mon, Sep 22, 2014 at 05:07:55PM +0530, Kishon Vijay Abraham I wrote:
On Thursday 18 September 2014 03:55 PM, Heikki Krogerus wrote:
On Mon, Sep 15
From: Alan Cox a...@linux.intel.com
The device controller is the same but it has different PCI ID. Add this new
ID to the driver's list of supported IDs.
Signed-off-by: Alan Cox a...@linux.intel.com
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Signed-off-by: Heikki Krogerus
If the probe drivers have already set the dma_mask, not
replacing the value.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/core.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
Most devices are configured for 32-bit DMA addresses.
Setting the mask to 32-bit here removes the need for the
drivers to do it separately.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Rafael J. Wysocki r...@rjwysocki.net
---
drivers/acpi/acpi_platform.c | 2 ++
1 file
DMA mask for all the ACPI platform devices.
Heikki Krogerus (3):
ACPI / platform: provide default DMA mask
usb: dwc3: core: only setting the dma_mask when needed
usb: dwc3: add ACPI support
drivers/acpi/acpi_platform.c | 2 ++
drivers/usb/dwc3/core.c | 18 +++---
2 files
Adds ACPI ID used on newer Intel SoCs.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/core.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index d08cac5..c2cf2d8 100644
--- a/drivers/usb/dwc3
Assume you have 2 phys in your system..
static struct phy_lookup usb_lookup = {
.phy_name = phy-usb.0,
.dev_id = usb.0,
.con_id = usb,
};
static struct phy_lookup sata_lookup = {
.phy_name = sata-usb.1,
.dev_id =
Adding ACPI ID used on newer Intel SoCs.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/core.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index d08cac5..88e29f5 100644
--- a/drivers/usb
A question, the dwc3 controller is the PCI-E device in my platform,
but the class code of PCI header is 0x0c0330, the same with xHC.
That's because it need to meet the windows enviroment. The dwc3
controller acted as only host mode to bind with windows xhci driver.
But on linux,
The users of the old method are now converted to the new one.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
---
drivers/phy/phy-bcm-kona-usb2.c | 2 +-
drivers/phy/phy-berlin-sata.c| 2 +-
drivers/phy/phy-core.c
On some platforms a PHY may need to be handled also in the
host controller driver. Exynos5420 SoC requires some PHY
tuning based on the USB speed. This patch delivers dwc3's
PHYs to the xhci platform device when it's created.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested
device is always the actual
physical device.
- Using PHY_LOOKUP macro in twl-common.c as suggested by Kishon.
Changes since v2:
- Calling ida_simple_remove in release function as pointed out by Greg
Heikki Krogerus (6):
phy: safer to_phy() macro
phy: improved lookup method
arm: omap3: twl
requested them.
By naming the device already in platform_device_alloc, the
resources can be assigned before platform_device_add is
called.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/base/platform.c | 69
This makes to_phy() macro work with other variable names
besides dev.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
---
include/linux/phy/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/phy
Removes the need for the phys to be aware of their users
even when not using DT. The method is copied from clkdev.c.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
---
Documentation/phy.txt | 66 ---
drivers
Provide complete association for the phy and it's user
(musb) with the new phy lookup method.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
arch/arm/mach-omap2/twl-common.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach
Hi Vivek,
On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote:
Hi Heikki, Kishon,
How about adding the change in attached patch [1] on top of this patch.
Just introduced the phy pointer in phy_lookup structure, and
modified phy_find() accordingly.
[1] Attachment:
On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote:
How about adding the change in attached patch [1] on top of this patch.
Just introduced the phy pointer in phy_lookup structure, and
modified phy_find() accordingly.
I would be fine if we used the phy pointer to match, but if we
On Tue, Nov 18, 2014 at 10:49:18AM +0530, Kishon Vijay Abraham I wrote:
On Monday 17 November 2014 09:10 PM, Heikki Krogerus wrote:
On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote:
How about adding the change in attached patch [1] on top of this patch.
Just introduced the phy
The users of the old method are now converted to the new one.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/phy/phy-bcm-kona-usb2.c | 2 +-
drivers/phy/phy-berlin-sata.c| 2 +-
drivers/phy/phy-core.c | 49
/dwc3/host.c) to pass the phy's to xhci.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/base/platform.c | 69 +
1 file changed, 41 insertions(+), 28 deletions(-)
diff --git
On some platforms a PHY may need to be handled also in the
host controller driver. Exynos5420 SoC requires some PHY
tuning based on the USB speed. This patch delivers dwc3's
PHYs to the xhci platform device when it's created.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested
Separates registration of the phy and the lookup. The method
is copied from clkdev.c,
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
Documentation/phy.txt | 60 ++-
drivers/phy/phy-core.c | 84
Creates the lookup separately. Hard coding the consumer as
it can't be anything else except musb.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/phy/phy-twl4030-usb.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-twl4030
The driver does no use it any more.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
arch/arm/mach-omap2/twl-common.c | 12 +---
include/linux/i2c/twl.h | 2 --
2 files changed, 1 insertion(+), 13 deletions(-)
diff --git a/arch/arm/mach-omap2/twl-common.c b
of the phy itself. The parent device is always the actual
physical device.
- Using PHY_LOOKUP macro in twl-common.c as suggested by Kishon.
Changes since v2:
- Calling ida_simple_remove in release function as pointed out by Greg
Heikki Krogerus (7):
phy: safer to_phy() macro
phy: improved lookup
This makes to_phy() macro work with other variable names
besides dev.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Tested-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Felipe Balbi ba...@ti.com
---
include/linux/phy/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Add PCI IDs for Intel Sunrise Point PCH.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/dwc3-pci.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 7c4faf7..b642a2f 100644
--- a/drivers
Hi David,
On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote:
+static int tusb1210_power_on(struct phy *phy)
+{
+ struct tusb1210 *tusb = phy_get_drvdata(phy);
+
+ gpiod_set_value_cansleep(tusb-gpio_reset, 1);
+ gpiod_set_value_cansleep(tusb-gpio_cs, 1);
+
+ /*
Hi David,
What exactly are we breaking here? The USB on BYT-CR does not work yet
with the mainline kernel, or does it? To enable it, I already
suggested the BYT quirk (attached again).
It used to work with mainline with minor restrictions. It stopped
working (and I failed
You can't really compare a bus like i2c, which can't enumerate devices
natively, to ULPI which can.
why not ? The BIOS might not need to use the PHY (or USB) at all, it can
very well decide to never turn it on, right ?
If ULPI was seen as a bus, then no. BIOS would have
Hi David, Felipe,
why would you have dwc3 mess around with the PHY's gpios ? Doesn't look
very good.
..but unfortunately we can't use the bus without it :(. We depend on
being able to read the vendor and product id's in the bus driver.
Doesn't the ugly platform device case
Registers ULPI interface with the ULPI bus if HSPHY type is
ULPI.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/Kconfig | 7
drivers/usb/dwc3/Makefile | 4 ++
drivers/usb/dwc3/core.c | 9 +++-
drivers/usb/dwc3
into deferred probe
when there are no phys.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/phy/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
index ccfdfb2..2f9735b 100644
--- a/drivers/usb/phy
Hi,
On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote:
On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote:
diff --git a/drivers/phy/ulpi/tusb1210.c b/drivers/phy/ulpi/tusb1210.c
new file mode 100644
index 000..ac77f98
--- /dev/null
+++ b/drivers/phy
On Tue, Jan 20, 2015 at 09:23:37AM -0600, Felipe Balbi wrote:
Hi,
On Tue, Jan 20, 2015 at 11:18:21AM +0200, Heikki Krogerus wrote:
Registers ULPI interface with the ULPI bus if HSPHY type is
ULPI.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Felipe Balbi ba
On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote:
Hi,
On Tue, Jan 20, 2015 at 11:18:22AM +0200, Heikki Krogerus wrote:
TUSB1210 ULPI PHY has vendor specific register for eye
diagram tuning. On some platforms the system firmware has
set optimized value to it. In order
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index a8c9062..66cbf38 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -879,6 +879,10 @@ static int dwc3_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, dwc);
On Thu, Feb 12, 2015 at 05:44:20PM -0800, Stephen Boyd wrote:
On 01/23/15 07:12, Heikki Krogerus wrote:
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index e614ef6..753cb08 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -1176,6 +1176,19
On Mon, Jan 26, 2015 at 11:23:37AM -0800, David Cohen wrote:
On Mon, Jan 26, 2015 at 02:55:03PM +0200, Heikki Krogerus wrote:
On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote:
+static int tusb1210_power_on(struct phy *phy)
+{
+ struct tusb1210 *tusb
look at your patch again. In case DWC3_ULPI isn't enabled, this file
won't be linked at all. You're using stubs, so taht's fine.
In case it _is_ enabled, you're breaking out early if you can't register
ulpi interface, meaning you're exitting probe() (which, in fact, seems
wrong as I want to
1 - 100 of 937 matches
Mail list logo
