Re: [PATCH] usb: musb: fix context save over suspend.

NeilBrown ne...@suse.de writes: On Tue, 12 Feb 2013 13:03:36 -0800 Kevin Hilman khil...@linaro.org wrote: NeilBrown ne...@suse.de writes: [...] My patch was fixing a real hang when musb was built-in (or loaded), in host-mode (mini-A cable attached) but no devices attached. I just tried

Re: regression(ti platforms): next-20140210 (ehci?)

Roger Quadros rog...@ti.com writes: +devicetree On 02/10/2014 05:59 PM, Nishanth Menon wrote: Hi, A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various TI platforms: Note: crane and sdp2430 are not expected to pass with

Re: regression(ti platforms): next-20140210 (ehci?)

Nishanth Menon n...@ti.com writes: On 02/10/2014 12:28 PM, Kevin Hilman wrote: Roger Quadros rog...@ti.com writes: +devicetree On 02/10/2014 05:59 PM, Nishanth Menon wrote: Hi, A quick note to report that I saw regression in today's next tag (logs indicate around EHCI) boot on various

Re: [PATCH v2 0/2] ohci-/ehci-platform: Change compatible string to generic-?hci

original series, but if you want them separate to preserve history that is fine too. I tested this series on top of next-20140211 on the OMAP platforms where I noticed the regressions, and confirm it fixes the problem. Tested-by: Kevin Hilman khil...@linaro.org Kevin -- To unsubscribe from this list

Re: [PATCH] OMAP: config : disable the usb host configuration in omap2plus_defconfig

Kevin Hilman khil...@ti.com writes: Keshava Munegowda keshava_mgo...@ti.com writes: The usb host is disabled in the omap2 build; This is because usb host is causing the retention to break in cpu idle. ... and causes warnings during boot, and hangs in suspend, can't suspend using NFSroot

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Munegowda, Keshava keshava_mgo...@ti.com writes: On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel I have sent that patch to disable the ehci in

Re: Removing vestiges of CONFIG_USB_SUSPEND

Hi Alan, Alan Stern st...@rowland.harvard.edu writes: Felipe and Kevin: While removing the remaining usages of USB_SUSPEND (things that I missed in the original patch), I noticed that arch/arm/configs/omap2plus_defconfig does not enable PM_RUNTIME -- even though it currently does enable

Re: [RFC PATCH 2/6] mfd: omap-usb-host: Put pins in IDLE state on suspend

Hi Roger, Roger Quadros rog...@ti.com writes: In order to support wake up from suspend use the pinctrl framework to put the USB host pins in IDLE state during suspend. CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com You should use helpers for this now in

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

Hi Roger, Roger Quadros rog...@ti.com writes: Runtime suspend the controller during bus suspend and resume it during bus resume. This will ensure that the USB Host power domain enters lower power state and does not prevent the SoC from endering deeper sleep states. Remote wakeup will come

Re: [RFC PATCH 5/6] ARM: dts: omap3beagle-xm: Add idle state pins for USB host

Roger Quadros rog...@ti.com writes: Add the Idle state pins for USB host and enable WAKEUP on DIR, DAT0-3, so that the PHY can wakeup the OMAP SoC from sleep on any USB activity (e.g. remote wakeup or connect/disconnect). CC: Benoît Cousson b-cous...@ti.com Signed-off-by: Roger Quadros

Re: [PATCH] USB: OHCI: make ohci-da8xx a separate driver

by then DaVinci maintainer Kevin Hilman. Yes I saw your patch that is what I mentioned in patch description. We will wait for DaVinci maintainer response,what he will suggest. Note that Sekhar Nori (now Cc'd) is the primary maintainer of davinci, and I'll defer the final decision to him. However

Re: [PATCH 4/6] mfd: omap-usb-host: Put pins in IDLE state on suspend

On 07/10/2013 05:23 PM, Roger Quadros wrote: In order to support wake up from suspend use the pinctrl framework to put the USB host pins in IDLE state during suspend. CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com [...] @@ -608,6 +618,14 @@ static int

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

Alan Stern st...@rowland.harvard.edu writes: On Tue, 19 Nov 2013, Ulf Hansson wrote: At the moment, system PM is already affecting behaviour of runtime PM since it is preventing runtime suspend during system suspend. Sure. And that behavior is documented. In any case, it's a bug for

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

Alan Stern st...@rowland.harvard.edu writes: On Tue, 19 Nov 2013, Kevin Hilman wrote: Alan Stern st...@rowland.harvard.edu writes: On Tue, 19 Nov 2013, Ulf Hansson wrote: At the moment, system PM is already affecting behaviour of runtime PM since it is preventing runtime suspend

Re: [PATCH] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

Josh Cartwright jo...@codeaurora.org writes: Both the PM_RUNTIME and PM_SLEEP callbacks call into the common msm_otg_{suspend,resume} routines, however these routines are only being built when CONFIG_PM_SLEEP. In addition, msm_otg_{suspend,resume} also depends on msm_hsusb_config_vddcx(),

Re: [PATCH 00/16] OMAP USB Host cleanup

Roger Quadros rog...@ti.com writes: Hi, This patchset addresses the following - Avoid addressing clocks one by one by name and use a for loop + bunch of cleanups. - Get number of channels/ports dynamically either from revision register or from platform data. Avoids getting clocks that

Re: [PATCH 00/16] OMAP USB Host cleanup

Roger Quadros rog...@ti.com writes: Kevin, On 11/16/2012 10:08 PM, Kevin Hilman wrote: Roger Quadros rog...@ti.com writes: Hi, This patchset addresses the following - Avoid addressing clocks one by one by name and use a for loop + bunch of cleanups. - Get number of channels/ports

Re: [PATCH 4/4] PM: Eliminate CONFIG_PM_RUNTIME

into a user-selectable option and drop the former entirely from the tree. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Acked-by: Kevin Hilman khil...@linaro.org I assume you're planning to get this in early in the v3.19-rc cycle

Re: [RESEND PATCH 2/2] ARM: at91/dt: update udc compatible strings

Nicolas Ferre nicolas.fe...@atmel.com writes: From: Boris Brezillon boris.brezil...@free-electrons.com at91sam9g45, at91sam9x5 and sama5 SoCs should not use atmel,at91sam9rl-udc for their USB device compatible property since this compatible is attached to a specific hardware bug fix.

Re: [RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy)

Hi Krzystof, Krzysztof Kozlowski writes: > Introduction > > This patchset tries to fix probing of usb3503 on Arndale board > if the Samsung PHY driver is probed later (or built as a module). > > *The patchset was not tested on Arndale board.* > I don't have

Re: [PATCH v5 0/5] da8xx USB PHY platform devices and clocks (was "da8xx UBS clocks")

On Wed, May 25, 2016 at 6:18 AM, Sekhar Nori wrote: > On Monday 23 May 2016 08:44 PM, David Lechner wrote: >> On 05/09/2016 06:46 PM, David Lechner wrote: >>> v5 changes: renamed "usbphy" to "usb_phy" or "usb-phy" as appropriate >>> [...] >> >> What should I be doing to keep

Re: [PATCH v3 3/3] usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in dsps

Bin Liu writes: > On Thu, Jan 19, 2017 at 11:06:59AM +0100, Alexandre Bailon wrote: >> Despite the CPPI 4.1 is a generic DMA, it is tied to USB. >> On the dsps, CPPI 4.1 interrupt's registers are in USBSS (the MUSB glue). >> Currently, to enable / disable and clear interrupts, the

Re: [PATCH v5 0/5] da8xx USB PHY platform devices and clocks (was "da8xx UBS clocks")

David, On Wed, Aug 17, 2016 at 4:35 AM, Kishon Vijay Abraham I <kis...@ti.com> wrote: > > Hi Kevin, > > On Saturday 13 August 2016 02:54 AM, Kevin Hilman wrote: > > On Wed, May 25, 2016 at 6:18 AM, Sekhar Nori <nsek...@ti.com> wrote: > >> On Monday 23

Re: [PATCH 1/7] clk: gxbb: expose USB clocks

On Wed, Sep 7, 2016 at 3:14 PM, Stephen Boyd wrote: > On 09/07, Martin Blumenstingl wrote: >> On Wed, Sep 7, 2016 at 2:33 AM, Stephen Boyd wrote: >> > On 09/04, Martin Blumenstingl wrote: >> >> USB0_DDR_BRIDGE and USB1_DDR_BRIDGE1 are needed for the

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: > On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks <ben.do...@codethink.co.uk> wrote: >> On 08/09/16 21:42, Kevin Hilman wrote: >>> >>> Ben Dooks <ben.do...@codethink.co.uk> writes: >>

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: > On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman <khil...@baylibre.com> wrote: >> However, the problem with all of the solutions proposed (runtime PM ones >> included) is that we're forcing a board-speci

Re: [PATCH v2 5/6] ARM64: meson-gxbb-p20x: Enable USB Nodes

Martin Blumenstingl writes: > From: Jerome Brunet > > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Jerome Brunet nit: subject should have "ARM64: dts:" prefix.

Re: [PATCH v2 1/6] usb: dwc2: add support for Meson8b and GXBB SoCs

On Wed, Sep 14, 2016 at 11:12 AM, John Youn <john.y...@synopsys.com> wrote: > On 9/14/2016 9:11 AM, Kevin Hilman wrote: >> Hi John, >> >> Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: >> >>> From: Jerome Brunet <jbru...@bayli

Re: [PATCH v2 1/6] usb: dwc2: add support for Meson8b and GXBB SoCs

On Wed, Sep 14, 2016 at 11:26 AM, John Youn <john.y...@synopsys.com> wrote: > On 9/14/2016 11:17 AM, Kevin Hilman wrote: >> On Wed, Sep 14, 2016 at 11:12 AM, John Youn <john.y...@synopsys.com> wrote: >>> On 9/14/2016 9:11 AM, Kevin Hilman wrote: >>>&

Re: [PATCH 1/7] clk: gxbb: expose USB clocks

Stephen Boyd writes: > On 09/04, Martin Blumenstingl wrote: >> USB0_DDR_BRIDGE and USB1_DDR_BRIDGE1 are needed for the related >> dwc2 usb controller. USB, USB0 and USB1 are needed for the PHYs. >> Expose these clocks to DT and comment out in clk driver. >> >>

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

Ben Dooks <ben.do...@codethink.co.uk> writes: > On 08/09/16 20:52, Martin Blumenstingl wrote: >> On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman <khil...@baylibre.com> wrote: >>>> + phy = devm_phy_create(>dev, NULL, _meson_usb2_ops); >>>> + if

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: > On Fri, Sep 9, 2016 at 10:36 PM, Martin Blumenstingl > <martin.blumensti...@googlemail.com> wrote: >> On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman <khil...@baylibre.com> wrote: >>>

Re: [PATCH v6 0/3] da8xx USB PHY platform devices and clocks

Bin Liu writes: > On Tue, Sep 06, 2016 at 02:19:52PM -0500, Bin Liu wrote: >> Hi Greg and Alan, >> >> On Mon, Sep 05, 2016 at 03:00:30PM -0500, David Lechner wrote: >> > Just resending to get these merged into usb. The phy parts of this patch >> > series >> > have already been

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

Martin Blumenstingl writes: > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel wrote: [...] >>> I added Philipp and Hans to this thread - maybe they can comment on this. >>> To sum it up, our problem is: >>> - there are two separate

Re: [PATCH v2 6/6] ARM64: meson-gxbb-vega-s95: Enable USB Nodes

Martin Blumenstingl writes: > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Martin Blumenstingl > Signed-off-by: Jerome Brunet Applied (after

Re: [PATCH v6 1/3] usb: ohci-da8xx: Remove code that references mach

Hi Greg, On Mon, Sep 5, 2016 at 10:00 PM, David Lechner wrote: > Including mach/* is frowned upon in device drivers, so get rid of it. > > This replaces usb20_clk and code that pokes CFGCHIP2 with a proper phy > driver. > > Signed-off-by: David Lechner

Re: [PATCH v2] ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes

Brian Kim writes: > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Brian Kim > --- > This patch was written on Kevin Hilman's repository[1] and branch[2]: > [1]

Re: [PATCH v2 2/6] Documentation: dt-bindings: Add documentation for the Meson USB2 PHYs

Rob Herring writes: > On Sun, Sep 11, 2016 at 03:41:07PM +0200, Martin Blumenstingl wrote: >> Add the documentation for the bindings for the Meson8b and GXBB USB2 >> PHYs. >> >> Signed-off-by: Martin Blumenstingl >> --- >>

Re: [PATCH v2 3/6] phy: meson: add USB2 PHY support for Meson8b and GXBB

Kishon Vijay Abraham I <kis...@ti.com> writes: > Hi Kevin, > > On Wednesday 14 September 2016 09:36 PM, Kevin Hilman wrote: >> Kishon, >> >> Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: >> >>> This is a new

Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes

Brian Kim writes: > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Brian Kim Thanks for the patch. In the future, please state what branch the patch should apply to when not using mainline.

Re: [PATCH v3 2/4] usb: musb: core: added helper function for parsing DT

>post_root_reset_end(musb); > } > > +/* gets the "dr_mode" property from DT and converts it into musb_mode > + * if the property is not found or not recognized returns MUSB_OTG > + */ nit: multi-line comment style > +extern enum musb_mode musb_get_mode(struct devic

Re: [RESEND PATCH v6 4/4] usb: musb: da8xx: Add a primary support of PM runtime

Alexandre Bailon writes: > Currently, MUSB DA8xx glue driver doesn't have PM runtime support. > Because the CPPI 4.1 is using the same clock as MUSB DA8xx and > CPPI 4.1 is a child of MUSB DA8xx glue, add support of PM runtime > to the DA8xx glue driver in order to let the