Re: [PATCH v2,3/5] dt-bindings: mtu3: add devicetree bindings

2016-06-03 Thread Matthias Brugger
On 31/05/16 07:52, Chunfeng Yun wrote: add a DT binding doc for MediaTek USB3 DRD driver Signed-off-by: Chunfeng Yun --- Documentation/devicetree/bindings/usb/mtu3.txt | 85 1 file changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/u

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-11-23 Thread Matthias Brugger
Hi Hongzhou, On 12/05/16 04:55, Hongzhou Yang wrote: On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: Hi, On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: On Tue, May

Re: [PATCH 1/1] usb: return error code when platform_get_irq fails

2016-11-30 Thread Matthias Brugger
= platform_get_irq(pdev, 0); - if (irq < 0) + if (irq < 0) { + ret = irq; goto disable_clk; + } /* Initialize dma_mask and coherent_dma_mask to 32-bits */ ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); Reviewed-by: Ma

Re: [PATCH 2/6] usb: mtu3: add reference clock

2017-01-19 Thread Matthias Brugger
On 18/01/17 07:08, Chunfeng Yun wrote: usually, the reference clock comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3.h |1 + drivers/usb/mtu3/mtu3_plat.c | 21 +++-- 2 files c

Re: [PATCH 4/6] arm64: dts: mt8173: add reference clock for usb

2017-01-19 Thread Matthias Brugger
On 19/01/17 10:37, Greg Kroah-Hartman wrote: On Wed, Jan 18, 2017 at 02:08:25PM +0800, Chunfeng Yun wrote: add 26M reference clock for ssusb and xhci nodes Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi |6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [PATCH v2, 6/6] dt-bindings: phy-mt65xx-usb: add support for new version phy

2017-01-24 Thread Matthias Brugger
Hi Chunfeng, On 01/20/2017 09:18 AM, Chunfeng Yun wrote: add a new compatible string for "mt2712", and move reference clock into each port node; Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 91 +--- 1 file changed, 77 insertions(+), 14

Re: [PATCH 2/6] usb: mtu3: add reference clock

2017-01-24 Thread Matthias Brugger
On 01/20/2017 03:20 AM, Chunfeng Yun wrote: On Thu, 2017-01-19 at 13:22 +0100, Matthias Brugger wrote: On 18/01/17 07:08, Chunfeng Yun wrote: usually, the reference clock comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun

Re: [RESEND PATCH v6, 3/5] usb: xhci-mtk: make IPPC register optional

2016-10-10 Thread Matthias Brugger
On 09/21/2016 07:54 AM, Chunfeng Yun wrote: Make IPPC register optional to support host side of dual-role mode, due to it is moved into common glue layer for simplification. Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 36 +--- 1 file change

Re: [RESEND PATCH v6, 4/5] usb: Add MediaTek USB3 DRD Driver

2016-10-11 Thread Matthias Brugger
On 10/11/2016 05:14 AM, Chunfeng Yun wrote: On Mon, 2016-10-10 at 13:00 +0200, Matthias Brugger wrote: On 09/21/2016 07:54 AM, Chunfeng Yun wrote: This patch adds support for the MediaTek USB3 controller integrated into MT8173. It can be configured as Dual-Role Device (DRD), Peripheral Only

Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver

2016-10-28 Thread Matthias Brugger
Hi Chunfeng, On 10/19/2016 04:28 AM, Chunfeng Yun wrote: These patches introduce the MediaTek USB3 dual-role controller driver. The driver can be configured as Dual-Role Device (DRD), Peripheral Only and Host Only (xHCI) modes. It works well with Mass Storage, RNDIS and g_zero on FS/HS and SS.

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-24 Thread Matthias Brugger
On 24/08/16 00:03, Rafał Miłecki wrote: From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the specified USB port. This can can useful for various home routers that have USB port(s) and a proper LED telling user a device is conn

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-24 Thread Matthias Brugger
On 24/08/16 13:02, Rafał Miłecki wrote: On 24 August 2016 at 12:49, Matthias Brugger wrote: On 24/08/16 00:03, Rafał Miłecki wrote: [...] +static int usbport_trig_notify(struct notifier_block *nb, unsigned long action, + void *data) +{ + struct

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Matthias Brugger
On 25/08/16 10:03, Jacek Anaszewski wrote: zOn 08/24/2016 07:52 PM, Rafał Miłecki wrote: From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the specified USB port. This can can useful for various home routers that have USB port

Re: [PATCH 2/6] usb: xhci-mtk: use __maybe_unused to hide pm functions

2016-03-04 Thread Matthias Brugger
id defining the structure when CONFIG_PM is not set without the #ifdef. Signed-off-by: Arnd Bergmann --- Reviewed-by: Matthias Brugger drivers/usb/host/xhci-mtk.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host

Re: [PATCH] phy: phy-mt65xx-usb3: add support for mt2701 platform

2016-04-08 Thread Matthias Brugger
On 08/04/16 11:13, Chunfeng Yun wrote: A new compatible string, "mediatek,mt2701-u3phy", is added. Some register settings to avoid RX sensitivity level degradation which may arise on mt8173 platform are separated from other platforms. Signed-off-by: Chunfeng Yun --- .../devicetree/bindings

Re: [PATCH v2 1/2] dt-bindings: phy-mt65xx-usb: add support for mt2701 platform

2016-04-13 Thread Matthias Brugger
On 11/04/16 09:41, Chunfeng Yun wrote: A new compatible string, "mediatek,mt2701-u3phy", is added. Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Matthias Brugger

[PATCH] usb/musb/omap2430.c Delete unused variable

2012-08-16 Thread Matthias Brugger
Signed-off-by: Matthias Brugger --- drivers/usb/musb/omap2430.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 5fdb9da..2d207c6 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c

[PATCH] usb/musb/omap2430.c Delete unused variable.

2012-08-16 Thread Matthias Brugger
Variable ret is always evaluated as true, so we don't need to check it. Signed-off-by: Matthias Brugger --- drivers/usb/musb/omap2430.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 5fdb9da..2d

Re: [v2 PATCH 6/6] usb: mtu3: get optional clock by devm_clk_get_optional()

2019-04-12 Thread Matthias Brugger
On 10/04/2019 08:47, Chunfeng Yun wrote: > Use devm_clk_get_optional() to get optional clock > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- > v2: new patch, merged into this series from > https://patchwork.kernel.org/patch/10878235/ > --

Re: [PATCH v2 5/9] usb: xhci-mtk: remove dummy wakeup debounce clocks

2017-10-13 Thread Matthias Brugger
On 10/13/2017 10:26 AM, Chunfeng Yun wrote: The wakeup debounce clocks for each ports in fact are not needed, so remove them. Signed-off-by: Chunfeng Yun --- Reviewed-by: Matthias Brugger drivers/usb/host/xhci-mtk.c | 33 - drivers/usb/host/xhci

Re: [PATCH v2 6/9] usb: xhci-mtk: add optional mcu and dma bus clocks

2017-10-13 Thread Matthias Brugger
On 10/13/2017 10:26 AM, Chunfeng Yun wrote: There are mcu_bus and dma_bus clocks needed to be controlled by driver on some SoCs, so add them as optional ones Signed-off-by: Chunfeng Yun --- Reviewed-by: Matthias Brugger drivers/usb/host/xhci-mtk.c | 79

Re: [PATCH v2 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks and add optional ones

2017-10-13 Thread Matthias Brugger
On 10/13/2017 10:26 AM, Chunfeng Yun wrote: Remove dummy clocks for usb wakeup and add optional ones for MCU_BUS_CK and DMA_BUS_CK. Signed-off-by: Chunfeng Yun Acked-by: Rob Herring --- Reviewed-by: .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 18 -- 1 file

Re: [PATCH v2 2/3] phy: phy-mtk-tphy: add configurable parameters for slew rate calibrate

2018-03-13 Thread Matthias Brugger
On 03/12/2018 06:25 AM, Chunfeng Yun wrote: > There are two parameters, ref_clk and coefficient, for U2 slew rate > calibrate which may vary on different SoCs, here allow them to be > configurable > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- >

Re: [PATCH v2 3/3] dt-bindings: phy-mtk-tphy: add properties for U2 slew rate calibrate

2018-03-13 Thread Matthias Brugger
On 03/12/2018 06:25 AM, Chunfeng Yun wrote: > Add two properties of ref_clk and coefficient used by U2 slew rate > calibrate which may vary on different SoCs > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- > Documentation/devicetree/bindings/phy/ph

Re: [PATCH v5 1/9] phy: phy-mt65xx-usb3: improve RX detection stable time

2017-05-10 Thread Matthias Brugger
I took DTS parts for v4.12-next. Sorry for the late response. Matthias On 06/04/17 12:28, Kishon Vijay Abraham I wrote: On Friday 31 March 2017 01:05 PM, Chunfeng Yun wrote: The default value of RX detection stable time is 10us, and this margin is too big for some critical cases which cause U

Re: [PATCH] usb: mtu3: Handle return value of clk_prepare_enable

2017-06-10 Thread Matthias Brugger
On 09/06/17 14:03, Arvind Yadav wrote: clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/usb/mtu3/mtu3_plat.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) Reviewed-by: Matthias Brugger

Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file

2017-08-14 Thread Matthias Brugger
On 08/11/2017 09:00 AM, Chunfeng Yun wrote: On Thu, 2017-08-10 at 21:54 -0500, Rob Herring wrote: On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote: The mt8173-mtu3.txt actually holds the bindings for all mediatek SoCs with usb3 DRD IP, so add a generic compatible and change the na

Re: [PATCH v2 3/4] usb: musb: Extract set toggle as a separate interface

2019-01-15 Thread Matthias Brugger
On 15/01/2019 02:43, min@mediatek.com wrote: > From: Min Guo > > Add a common interface for set data toggle > > Signed-off-by: Min Guo > --- > drivers/usb/musb/musb_host.c | 37 +++-- > 1 file changed, 23 insertions(+), 14 deletions(-) > > diff --git a/d

Re: [RESEND PATCH v2 2/2] usb: xhci-mtk: add an optional xhci_ck clock

2019-08-23 Thread Matthias Brugger
On 23/08/2019 08:40, Chunfeng Yun wrote: > Some SoCs may have an optional clock xhci_ck (125M or 200M), it > usually uses the same PLL as sys_ck, so support it. > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- > v2 no changes > --- > drivers/