Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Ming Lei
On Thu, Jul 18, 2013 at 9:30 AM, Gioh Kim gioh@lge.com wrote: Thanks for your reply. -Original Message- From: Ming Lei [mailto:tom.leim...@gmail.com] Sent: Wednesday, July 17, 2013 5:52 PM To: 김기오 Cc: Alan Stern; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Mark

Re: How should we handle isochronous underruns?

2013-07-18 Thread Ming Lei
because it is HCD-independent function, so it is better to provide the information from usbcore and let HCD use it if HCD needs the flag. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Ming Lei
On Thu, Jul 18, 2013 at 10:08 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 18 Jul 2013, Ming Lei wrote: I guess that HC could have a use-after-free problem like following situation. 1. A qtd which is not at the queue head should be removed in qh_completions(). 2

Re: [PATCH 1/2] usb: class: move checking 'actual' code block into checking 'buffer[1]' code block

2013-07-18 Thread Ming Lei
Hi Chen Gang, On Fri, Jul 19, 2013 at 12:21 PM, Chen Gang gang.c...@asianux.com wrote: Hello Maintainers: Please help check this patch when you have time. Looks your patch is correct, and I think Greg will handle your patch when usb-next tree is open. Thanks, -- Ming Lei -- To unsubscribe

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 1:44 AM, Clemens Ladisch clem...@ladisch.de wrote: Alan Stern wrote: On Thu, 18 Jul 2013, Ming Lei wrote: On Thu, Jul 18, 2013 at 3:24 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 4 Jul 2013, Alan Stern wrote: On Thu, 4 Jul 2013, Ming Lei wrote: I had

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: On Fri, Jul 19, 2013 at 1:44 AM, Clemens Ladisch clem...@ladisch.de wrote: In any case, there must be _some_ mechanism to explicitly restart a stream. I do not really care if this is some URB flag

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 6:30 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: if (list_empty (stream-td_list)) { if (running from hcd interrupt or tasklet context) underrun

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 6:36 PM, Ming Lei tom.leim...@gmail.com wrote: On Fri, Jul 19, 2013 at 6:30 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote: Ming Lei wrote: if (list_empty (stream-td_list

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 11:50 AM, Ming Lei tom.leim...@gmail.com wrote: On Thu, Jul 18, 2013 at 10:08 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 18 Jul 2013, Ming Lei wrote: I guess that HC could have a use-after-free problem like following situation. 1. A qtd which

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Fri, Jul 19, 2013 at 10:53 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 19 Jul 2013, Ming Lei wrote: Even we can introduce one flag of 'completing' in 'struct urb' to check if the USB's submit is called inside its own complete(), by which we can check if resubmission

Re: How should we handle isochronous underruns?

2013-07-19 Thread Ming Lei
On Sat, Jul 20, 2013 at 11:57 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 20 Jul 2013, Ming Lei wrote: Trying to check the context of an URB submission strikes me as not robust at all. Who knows what tricks drivers will get up to in the future? Firstly, it shouldn't

Re: How should we handle isochronous underruns?

2013-07-21 Thread Ming Lei
On Sun, Jul 21, 2013 at 2:00 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 20 Jul 2013, Ming Lei wrote: No, we don't have to change every driver using isochronous URBs. Many of them set URB_ISO_ASAP on every URB -- in fact, AFAIK snd-usb-audio is the only one that has been fixed

Re: How should we handle isochronous underruns?

2013-07-22 Thread Ming Lei
On Sun, Jul 21, 2013 at 11:28 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sun, 21 Jul 2013, Ming Lei wrote: On Sun, Jul 21, 2013 at 2:00 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 20 Jul 2013, Ming Lei wrote: No, we don't have to change every driver using

Re: How should we handle isochronous underruns?

2013-07-22 Thread Ming Lei
On Mon, Jul 22, 2013 at 11:09 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 22 Jul 2013, Ming Lei wrote: Not exactly. The HCD has to keep track of the next available time slot for the endpoint. Some special value, like -1, will indicate that no stream is running yet. So

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-24 Thread Ming Lei
that, and driver may have to support SG and non-SG at the same time for working well on all HCs. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-24 Thread Ming Lei
On Thu, Jul 25, 2013 at 1:10 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2013-07-25 at 10:28 +0800, Ming Lei wrote: It depends if size of sg buffer(except for last one) in the sg list can be divided by usb endpoint's max packet size(512 or 1024), at least there is the constraint

[PATCH 2/2] USBNET: increase max rx/tx qlen for improving USB3 thoughtput

2013-07-24 Thread Ming Lei
. Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/usbnet.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index d74de07..e4811d7 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -355,6

[PATCH 0/2] USBNET: max rx/tx qlen change

2013-07-24 Thread Ming Lei
|3 +++ 4 files changed, 55 insertions(+), 8 deletions(-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] USBNET: centralize computing of max rx/tx qlen

2013-07-24 Thread Ming Lei
of usbnet_update_max_qlen(), and calls it in above path. Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/asix_devices.c |3 +++ drivers/net/usb/ax88179_178a.c |3 +++ drivers/net/usb/usbnet.c | 45 +--- include/linux/usb/usbnet.h |3 +++ 4

Re: [PATCH 0/2] USBNET: max rx/tx qlen change

2013-07-25 Thread Ming Lei
Hi, On Thu, Jul 25, 2013 at 3:38 PM, Oliver Neukum oneu...@suse.de wrote: On Thu, 2013-07-25 at 13:47 +0800, Ming Lei wrote: Hi, There are two patches on computing max rx/tx qlen, and fix one performance problem on USB3 NIC. I am afraid bisectability on SS is impaired. Otherwise

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-25 Thread Ming Lei
On Thu, Jul 25, 2013 at 7:01 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2013-07-25 at 13:25 +0800, Ming Lei wrote: On Thu, Jul 25, 2013 at 1:10 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2013-07-25 at 10:28 +0800, Ming Lei wrote: It depends if size of sg buffer

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Ming Lei
Hi Greg, On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote: The patch does the below improvement: - think QH_STATE_COMPLETING as unlinking state since all

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Ming Lei
On Fri, Jul 26, 2013 at 4:55 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jul 26, 2013 at 04:52:36AM +0800, Ming Lei wrote: Hi Greg, On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: On Wed

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-07-26 Thread Ming Lei
urb of desc-response. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 35/50] media: usb: cx231xx: spin_lock in complete() cleanup

2013-07-27 Thread Ming Lei
On Fri, Jul 26, 2013 at 10:28 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 07/11/2013 11:05 AM, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: linux

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread Ming Lei
is you can avoid to access runtime-suspended device from ethtool. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-31 Thread Ming Lei
call during high memory pressure can fail. I'd rather the potential failure happen at one time, probe time. In any event, Ming Lei has suggested using usbnet_{read,write}_cmd() instead, which sounds like a good solution to this problem. Those do per-call allocs too. Sigh... Ok I won't fight

[PATCH 0/4] USB USBNET: loose DMA SG check and support usbnet DMA SG

2013-07-31 Thread Ming Lei
deletions(-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/4] USBNET: support DMA SG

2013-07-31 Thread Ming Lei
avoid move or copy data over the whole skb. Secondaly, the patch supports passing the skb fragment buffers to usb stack directly via urb-sg. Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/usbnet.c | 48 ++-- include/linux/usb

[PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-07-31 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous buffers. Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/host/xhci.c |4 1 file changed, 4 insertions(+) diff --git

[PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-07-31 Thread Ming Lei
, CPU utilization decreased much in iperf test at client mode. Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/ax88179_178a.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index

Re: [PATCH 0/4] USB USBNET: loose DMA SG check and support usbnet DMA SG

2013-07-31 Thread Ming Lei
On Wed, Jul 31, 2013 at 7:12 PM, Oliver Neukum oneu...@suse.de wrote: On Wed, 2013-07-31 at 18:51 +0800, Ming Lei wrote: Hi, This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers support this kind of sg buffers

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-07-31 Thread Ming Lei
On Wed, Jul 31, 2013 at 8:47 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jul 31, 2013 at 06:51:49PM +0800, Ming Lei wrote: This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-07-31 Thread Ming Lei
On Wed, Jul 31, 2013 at 11:15 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Wed, 2013-07-31 at 16:02 +0200, Oliver Neukum wrote: On Wed, 2013-07-31 at 21:50 +0800, Ming Lei wrote: In the usbnet case, the driver already supports non-sg well. Actually, all current drivers should support

Re: issues with commit usbnet: mcs7830: apply usbnet_link_change

2013-07-31 Thread Ming Lei
/show_bug.cgi?id=60662 Thanks for the report. Looks you didn't provide any debug info, could you apply the attachment patch and post the 'dmesg' info when you reproduce the bug. Thanks, -- Ming Lei usbnet-link-dgb.patch Description: Binary data

Re: issues with commit usbnet: mcs7830: apply usbnet_link_change

2013-07-31 Thread Ming Lei
On Wed, Jul 31, 2013 at 11:49 PM, Ming Lei ming@canonical.com wrote: On Wed, Jul 31, 2013 at 5:56 PM, Till Schmalmack t...@schmalmack.net wrote: Hello Ming, I am experiencing issues with the usbnet commits you did for the 3.10 kernel, in particular with 4be74c13 usbnet: mcs7830: apply

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-07-31 Thread Ming Lei
or 1024 bytes. Now Sarah Sharp(xHCD maintainer) has Acked patch 2/4, and confirmed SG is supported on xHCD, so I appreciate that you network guys may review the network related changes in patch 3/4 and 4/4, then we can move on, :-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-08-01 Thread Ming Lei
On Thu, Aug 1, 2013 at 1:04 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2013-08-01 at 12:41 +0800, Ming Lei wrote: From my trace result, lots of linear SKBs are cloned or header-cloned, so it needs skb copy too. Is it normal in xmit path to see cloned SKBs for driver? If not, I

Re: I've now caught up on my pending USB patches

2013-08-01 Thread Ming Lei
, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 1/5] USB: HCD: support giveback of URB in tasklet context

2013-08-01 Thread Ming Lei
On Fri, Aug 2, 2013 at 11:28 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote: 1), for drivers, they don't care if the complete() is called in hard irq context or softirq context What about those 50+ patches you had that changed

[PATCH v1 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-02 Thread Ming Lei
/xhci.c|4 include/linux/usb.h| 11 ++- include/linux/usb/usbnet.h |1 + 6 files changed, 65 insertions(+), 4 deletions(-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

[PATCH v1 1/4] USB: introduce usb_device_no_sg_limit() helper

2013-08-02 Thread Ming Lei
...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/core/urb.c |3 ++- include/linux/usb.h| 11 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index e75115a..7a88ae8 100644 --- a/drivers/usb

[PATCH v1 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-02 Thread Ming Lei
From: Ming Lei tom.leim...@gmail.com This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so TSO can be enabled and skb fragment buffers can be passed to usb stack via urb-sg directly

[PATCH v1 2/4] USB: XHCI: mark no_sg_limit

2013-08-02 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous buffers. Cc: Alan Stern st...@rowland.harvard.edu Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/host/xhci.c |4

[PATCH v1 3/4] USBNET: support DMA SG

2013-08-02 Thread Ming Lei
Hutchings bhutchi...@solarflare.com Cc: Grant Grundler grund...@google.com Cc: Freddy Xin fre...@asix.com.tw Cc: Oliver Neukum oneu...@suse.de Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/usbnet.c | 38

Re: [PATCH v1 3/4] USBNET: support DMA SG

2013-08-03 Thread Ming Lei
On Sun, Aug 4, 2013 at 3:07 AM, David Miller da...@davemloft.net wrote: From: Oliver Neukum oneu...@suse.de Date: Sat, 03 Aug 2013 07:56:53 +0200 On Sat, 2013-08-03 at 10:46 +0800, Ming Lei wrote: @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, entry

Re: [PATCH v1 1/4] USB: introduce usb_device_no_sg_limit() helper

2013-08-03 Thread Ming Lei
On Sat, Aug 3, 2013 at 11:53 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 3 Aug 2013, Ming Lei wrote: Some host controllers(such as xHCI) can support building packet from discontinuous buffers, so introduce one flag and helper for this kind of host controllers, then the feature

Re: [PATCH v1 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-03 Thread Ming Lei
On Sat, Aug 3, 2013 at 10:46 AM, Ming Lei ming@canonical.com wrote: Hi, This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support this kind of sg buffers. Previously we added check[1

[PATCH v2 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-05 Thread Ming Lei
...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/core/urb.c |3 ++- include/linux/usb.h| 11 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index e75115a..c77ec78 100644 --- a/drivers/usb

[PATCH v2 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-05 Thread Ming Lei
+-- drivers/usb/core/urb.c |3 ++- drivers/usb/host/xhci.c|4 include/linux/usb.h| 11 ++- include/linux/usb/usbnet.h |1 + 6 files changed, 66 insertions(+), 4 deletions(-) Thanks, -- Ming Lei

[PATCH v2 2/4] USB: XHCI: mark no_sg_constraint

2013-08-05 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_constraint since xHCI supports building packet from discontinuous buffers. Cc: Alan Stern st...@rowland.harvard.edu Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/host/xhci.c |4

[PATCH v2 3/4] USBNET: support DMA SG

2013-08-05 Thread Ming Lei
Hutchings bhutchi...@solarflare.com Cc: Grant Grundler grund...@google.com Cc: Freddy Xin fre...@asix.com.tw Cc: Oliver Neukum oneu...@suse.de Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/usbnet.c | 39

[PATCH v2 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-05 Thread Ming Lei
...@rowland.harvard.edu Cc: Freddy Xin fre...@asix.com.tw Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/ax88179_178a.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index fb0caa2..7a96326 100644

Re: [PATCH v2 3/4] USBNET: support DMA SG

2013-08-05 Thread Ming Lei
On Mon, Aug 5, 2013 at 5:14 PM, Oliver Neukum oneu...@suse.de wrote: On Mon, 2013-08-05 at 16:47 +0800, Ming Lei wrote: @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, entry = (struct skb_data *) skb-cb; entry-urb = urb; entry-dev = dev

Re: [PATCH v2 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-05 Thread Ming Lei
On Mon, Aug 5, 2013 at 10:07 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 5 Aug 2013, Ming Lei wrote: Some host controllers(such as xHCI) can support building packet from discontinuous buffers, so introduce one flag and helper for this kind of host controllers, then the feature

[PATCH v3 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-05 Thread Ming Lei
++- include/linux/usb/usbnet.h |1 + 6 files changed, 68 insertions(+), 5 deletions(-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH v3 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-05 Thread Ming Lei
...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/core/urb.c |3 ++- include/linux/usb.h|8 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index e75115a..c77ec78 100644 --- a/drivers

[PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-05 Thread Ming Lei
...@rowland.harvard.edu Cc: Freddy Xin fre...@asix.com.tw Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/ax88179_178a.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index fb0caa2..7a96326 100644

[PATCH v3 2/4] USB: XHCI: mark no_sg_constraint

2013-08-05 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_constraint since xHCI supports building packet from discontinuous buffers. Cc: Alan Stern st...@rowland.harvard.edu Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/host/xhci.c |4

[PATCH v3 3/4] USBNET: support DMA SG

2013-08-05 Thread Ming Lei
Hutchings bhutchi...@solarflare.com Cc: Grant Grundler grund...@google.com Cc: Freddy Xin fre...@asix.com.tw Cc: Oliver Neukum oneu...@suse.de Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/usbnet.c | 45

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-06 Thread Ming Lei
On Tue, Aug 6, 2013 at 8:22 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2013-08-06 at 08:52 +0800, Ming Lei wrote: This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-06 Thread Ming Lei
usbnet devices may have random MAC address assigned in every probe(). Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: I've now caught up on my pending USB patches

2013-08-06 Thread Ming Lei
Hi Greg, On Fri, Aug 2, 2013 at 9:19 AM, Ming Lei tom.leim...@gmail.com wrote: Hi Greg, On Sat, Jul 27, 2013 at 5:17 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, I've now caught up on all pending USB patches that were sent to me, with the exception of Ming's EHCI patches, which I

Re: VM Kernel bug with CONFIG_DEBUG_VM

2013-08-07 Thread Ming Lei
); + if (PageSlab(page)) + break; + flush_dcache_page(page); + } } /* complete() can reenter this HCD */ Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

[PATCH v4 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-08 Thread Ming Lei
/core/urb.c |3 ++- drivers/usb/host/xhci.c|4 include/linux/usb.h|8 ++- include/linux/usb/usbnet.h |1 + 6 files changed, 64 insertions(+), 5 deletions(-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe

[PATCH v4 2/4] USB: XHCI: mark no_sg_constraint

2013-08-08 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_constraint since xHCI supports building packet from discontinuous buffers. Cc: Alan Stern st...@rowland.harvard.edu Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/host/xhci.c |4

[PATCH v4 3/4] USBNET: support DMA SG

2013-08-08 Thread Ming Lei
Hutchings bhutchi...@solarflare.com Cc: Grant Grundler grund...@google.com Cc: Freddy Xin fre...@asix.com.tw Cc: Alan Stern st...@rowland.harvard.edu Acked-by: Oliver Neukum oneu...@suse.de Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/usbnet.c | 45

[PATCH v4 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-08 Thread Ming Lei
...@rowland.harvard.edu Cc: Freddy Xin fre...@asix.com.tw Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/ax88179_178a.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index fb0caa2..3569293 100644 --- a/drivers

[PATCH v4 1/4] USB: introduce usb_device_no_sg_constraint() helper

2013-08-08 Thread Ming Lei
...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/core/urb.c |3 ++- include/linux/usb.h|8 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index e75115a..c77ec78 100644 --- a/drivers

[PATCH] usb: isp1760: avoid to flush_dcache_page on slab page

2013-08-08 Thread Ming Lei
be mapped to userspace. This patch fixes one kernel panic when CONFIG_DEBUG_VM is set. Cc: Catalin Marinas catalin.mari...@arm.com Tested-by: Christoffer Dall christoffer.d...@linaro.org Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/host/isp1760-hcd.c |4 +++- 1 file changed, 3

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-08 Thread Ming Lei
On Fri, Aug 9, 2013 at 8:18 AM, Grant Grundler grund...@google.com wrote: Ming, We are splitting hairs now. :) I want to be clear I think your changes are good and the rest of this conversation is just to learn something new. On Thu, Aug 8, 2013 at 4:48 PM, Ming Lei ming@canonical.com

[PATCH v1 02/49] USB: sg: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/core/message.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core

[PATCH v1 00/49] USB: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
deletions(-) Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v1 04/49] USB: cdc-wdm: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Oliver Neukum oli...@neukum.org Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/class/cdc-wdm.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/usb

[PATCH v1 01/49] USB: skeleton: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/usb-skeleton.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c

[PATCH v1 03/49] USB: devio: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/core/devio.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core

[PATCH v1 07/49] USB: misc: uss720: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so prepare for the comming change. Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/misc/uss720.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index

[PATCH v1 05/49] USB: usblp: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Pete Zaitcev zait...@kotori.zaitcev.us Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/class/usblp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH v1 06/49] USB: adutux: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Lisa Nguyen l...@xenapiadmin.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/misc/adutux.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc

[PATCH v1 08/49] USB: iowarrior: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/misc/iowarrior.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c

[PATCH v1 14/49] USB: serial: io_edgeport: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/io_edgeport.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/usb

[PATCH v1 16/49] USB: serial: mos7720: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/mos7720.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial

[PATCH v1 15/49] USB: serial: io_ti: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/io_ti.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/io_ti.c

[PATCH v1 17/49] USB: serial: mos77840: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/mos7840.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial

[PATCH v1 12/49] USB: serial: cyberjack: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Matthias Bruestle and Harald Welte supp...@reiner-sct.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/cyberjack.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions

[PATCH v1 10/49] USB: legousbtower: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Juergen Stuber starb...@users.sourceforge.net Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/misc/legousbtower.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v1 09/49] USB: ldusb: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/misc/ldusb.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index

[PATCH v1 13/49] USB: serial: digi_acceleportldusb: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Peter Berger pber...@brimson.com Cc: Al Borchers alborch...@steinerpoint.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/digi_acceleport.c | 23 +-- 1 file changed

[PATCH v1 18/49] USB: serial: quatech2: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/quatech2.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial

[PATCH v1 11/49] USB: usbtest: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/misc/usbtest.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c

[PATCH v1 20/49] USB: serial: symbolserial: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/symbolserial.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial

[PATCH v1 22/49] USB: serial: usb_wwan: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/usb_wwan.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial

[PATCH v1 21/49] USB: serial: ti_usb_3410_5052: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/ti_usb_3410_5052.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb

[PATCH v1 19/49] USB: serial: sierra: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/usb/serial/sierra.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial

[PATCH v1 23/49] hid: usbhid: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Jiri Kosina jkos...@suse.cz Cc: linux-in...@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com --- drivers/hid/usbhid/hid-core.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH v1 25/49] BT: bfusb: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to read_lock_irqsave(). Cc: Marcel Holtmann mar...@holtmann.org Cc: Gustavo Padovan gust...@padovan.org Cc: Johan Hedberg johan.hedb...@gmail.com Cc: linux-blueto...@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com

[PATCH v1 26/49] input: cm109: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-in...@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com --- drivers/input/misc/cm109.c | 10 ++ 1 file changed, 6 insertions(+), 4

[PATCH v1 28/49] USBNET: cdc-phonet: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: net...@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/cdc-phonet.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/cdc-phonet.c b

[PATCH v1 30/49] USBNET: kaweth: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: net...@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/kaweth.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/kaweth.c b/drivers

[PATCH v1 29/49] USBNET: hso: prepare for enabling irq in complete()

2013-08-17 Thread Ming Lei
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: net...@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/hso.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git

  1   2   3   4   5   6   7   8   >