Re: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-12 Thread Nicolas Ferre
BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/gadget/at91_udc.c | 17 - drivers/usb/gadget/at91_udc.h |2 +- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb

Re: [PATCH v2] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-12 Thread Nicolas Ferre
IS_ENABLED(CONFIG_COMMON_CLK) to isolate new at91 clk support Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Well, for this v2 as well: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com (even if it is too late) Bye, --- drivers/usb/host/ohci-at91.c | 23

Re: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-13 Thread Nicolas Ferre
On 12/08/2013 22:42, boris brezillon : Hello Nicolas, On 12/08/2013 15:52, Nicolas Ferre wrote: On 01/08/2013 08:18, Boris BREZILLON : The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci

Re: [PATCH 4/7] pcmcia: at91_cf: fix deferred probe from __init

2013-09-23 Thread Nicolas Ferre
-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks Johan. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/pcmcia/at91_cf.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions

Re: [PATCH v4 01/17] ARM: at91: move at91_pmc.h to include/linux/clk/at91_pmc.h

2013-10-16 Thread Nicolas Ferre
-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- arch/arm/mach-at91/at91rm9200.c|2 +- arch/arm/mach-at91/at91sam9260.c |2 +- arch/arm/mach-at91/at91sam9261.c |2 +- arch/arm

Re: [PATCH v4 02/17] ARM: at91: add Kconfig options for common clk support

2013-10-16 Thread Nicolas Ferre
framework. Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks --- arch/arm/mach-at91/Kconfig| 21 + arch/arm/mach-at91/Kconfig.non_dt |6 ++ arch/arm/mach-at91/Makefile |2 +- arch/arm/mach-at91/generic.h |3 ++- arch/arm/mach

Re: [PATCH v4 03/17] clk: at91: add PMC base support

2013-10-17 Thread Nicolas Ferre
...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/clk/Makefile |1 + drivers/clk/at91/Makefile |5 + drivers/clk/at91/pmc.c| 283 + drivers/clk/at91/pmc.h| 58 ++ 4 files changed, 347 insertions

Re: [PATCH v4 04/17] clk: at91: add PMC macro file for dt definitions

2013-10-17 Thread Nicolas Ferre
On 11/10/2013 10:41, Boris BREZILLON : This patch adds a new macro file for PMC macros. This macro file includes the definitions of SR (status register) bit offsets and will be use to reference PMC irqs. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre

Re: [PATCH v4 05/17] clk: at91: add PMC main clock

2013-10-17 Thread Nicolas Ferre
BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/clk/at91/Makefile |1 + drivers/clk/at91/clk-main.c | 189 +++ drivers/clk/at91/pmc.c |5 ++ drivers/clk/at91/pmc.h |3 + 4 files

Re: [PATCH v4 07/17] clk: at91: add PMC master clock

2013-10-17 Thread Nicolas Ferre
clock output rate These characteristics are checked during rate change to avoid over/underclocking. These characteristics are described in atmel's SoC datasheet in Electrical Characteristics paragraph. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe

Re: [PATCH v4 08/17] clk: at91: add PMC system clocks

2013-10-17 Thread Nicolas Ferre
-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/clk/at91/Makefile |1 + drivers/clk/at91/clk-system.c | 193 + drivers/clk/at91/pmc.c|5 ++ drivers/clk/at91/pmc.h|3

Re: [PATCH v4 06/17] clk: at91: add PMC pll clocks

2013-10-17 Thread Nicolas Ferre
Characteristics paragraph. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/clk/at91/Makefile |2 +- drivers/clk/at91/clk-pll.c| 545 + drivers/clk/at91/clk-plldiv.c | 137

Re: [PATCH v4 09/17] clk: at91: add PMC peripheral clocks

2013-10-17 Thread Nicolas Ferre
-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/clk/at91/Makefile |2 +- drivers/clk/at91/clk-peripheral.c | 407 + drivers/clk/at91/pmc.c|9 + drivers/clk/at91/pmc.h

Re: [PATCH v4 10/17] clk: at91: add peripheral clk macros for peripheral clk dt bindings

2013-10-17 Thread Nicolas Ferre
On 11/10/2013 11:53, Boris BREZILLON : This patch adds the peripheral divisors macros (for sam9x5 compatible IPs) which will be used by peripheral clk dt definitions. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- include/dt

Re: [PATCH v4 11/17] clk: at91: add PMC programmable clocks

2013-10-17 Thread Nicolas Ferre
to the appropriate peripheral (see atmel's datasheets). Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/clk/at91/Makefile |2 + drivers/clk/at91/clk-programmable.c | 423

Re: [PATCH v4 12/17] clk: at91: add PMC utmi clock

2013-10-17 Thread Nicolas Ferre
On 11/10/2013 12:22, Boris BREZILLON : This adds new at91 utmi clock implementation using common clk framework. This clock is a pll with a fixed factor (x40). It is used as a source for usb clock. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe

Re: [PATCH v4 13/17] clk: at91: add PMC usb clock

2013-10-17 Thread Nicolas Ferre
my: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com +#endif { /*sentinel*/ } }; diff --git a/drivers/clk/at91/pmc.h b/drivers/clk/at91/pmc.h index 3ba9503..eba7334 100644 --- a/drivers/clk/at91/pmc.h +++ b/drivers/clk/at91/pmc.h @@ -96,4 +96,13 @@ extern void __init

Re: [PATCH v4 14/17] clk: at91: add PMC smd clock

2013-10-17 Thread Nicolas Ferre
On 11/10/2013 13:27, Boris BREZILLON : This patch adds at91 smd (Soft Modem) clock implementation using common clk framework. Not used by any driver right now. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- arch/arm/mach-at91

Re: [PATCH v4 15/17] clk: at91: add PMC clk device tree binding doc.

2013-10-17 Thread Nicolas Ferre
On 11/10/2013 13:38, Boris BREZILLON : This patch adds new at91 clks dt bindings documentation. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com It seems good Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- .../devicetree/bindings/clock/at91-clock.txt | 328

Re: [PATCH v5 13/17] clk: at91: add PMC usb clock

2013-10-18 Thread Nicolas Ferre
On 17/10/2013 18:55, Boris BREZILLON : This patch adds new at91 usb clock implementation using common clk framework. This clock is used to clock usb ports (ohci, ehci and udc). Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Ok, this one

Re: [PATCH v4 00/17] ARM: at91: move to common clk framework

2013-10-18 Thread Nicolas Ferre
.h rename {arch/arm/mach-at91/include/mach = include/linux/clk}/at91_pmc.h (98%) -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: ehci-atmel: add usb_clk for transition to CCF

2013-11-04 Thread Nicolas Ferre
. This configuration was formely done in mach-at91/clock.c, but will be bypassed when moving to common clk framework. This patch adds support for usb clock retrieval and configuration only if CCF is enabled (CONFIG_COMMON_CLK). Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre

Re: [PATCH 1/6] usb: gadget: atmel: remove unused DMA_ADDR_INVALID

2013-03-14 Thread Nicolas Ferre
missing? Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] usb: gadget: atmel: remove unused DMA_ADDR_INVALID

2013-03-14 Thread Nicolas Ferre
On 03/14/2013 09:56 AM, Felipe Balbi : DMA_ADDR_INVALID isn't (and shouldn't) be used anymore, let's remove it. Signed-off-by: Felipe Balbi ba...@ti.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks Felipe. Bye. --- drivers/usb/gadget/atmel_usba_udc.h | 6 -- 1 file

Re: [PATCH v3 5/7] USB: EHCI: make ehci-atmel a separate driver

2013-03-30 Thread Nicolas Ferre
missed the patch itself but I reviewed it on the mailing-list archive. So, here is my: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks a lot for having taking care of this driver. Best regards, @@ -15,6 +15,19 @@ #include linux/platform_device.h #include linux/of.h #include linux

[PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-02-12 Thread Nicolas Ferre
jjhib...@traphandler.com Acked-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Cc: stable sta...@vger.kernel.org # 3.4 --- drivers/usb/gadget/at91_udc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers

Re: [PATCH v2 1/2] USB: at91: fix the number of endpoint parameter

2014-02-19 Thread Nicolas Ferre
data for non-dt kernel, or parse from dt node. Signed-off-by: Bo Shen voice.s...@atmel.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- Changes in v2: - Make the commit message more clearer. drivers/usb/gadget/atmel_usba_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v2 2/2] USB: at91: using USBA_NR_DMAS for DMA channels

2014-02-19 Thread Nicolas Ferre
. So, define a new micro USBA_NR_DMAs for DMA channels. And the s/micro/macro/ USBA_NR_ENDPOINS is not used anymore, remove it at the same time. Signed-off-by: Bo Shen voice.s...@atmel.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- Changes in v2: - Make the commit message more

Re: [PATCH] usb: gadget: atmel_usba: fix crash when no endpoint are specified

2014-02-28 Thread Nicolas Ferre
. So, okay. Acked-by: Nicolas Ferre nicolas.fe...@atmel.com return eps; err: return ERR_PTR(ret); -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-03-12 Thread Nicolas Ferre
On 12/02/2014 14:03, Nicolas Ferre : From: Jean-Jacques Hiblot jjhib...@traphandler.com When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resource table. Also don't expect the number of resource to be always

Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-03-12 Thread Nicolas Ferre
On 12/03/2014 16:31, Greg Kroah-Hartman : On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote: On 12/02/2014 14:03, Nicolas Ferre : From: Jean-Jacques Hiblot jjhib...@traphandler.com When using dt resources retrieval (interrupts and reg properties) there is no predefined order

[PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval

2014-03-12 Thread Nicolas Ferre
jjhib...@traphandler.com Acked-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Cc: stable sta...@vger.kernel.org # 3.4 --- drivers/usb/gadget/at91_udc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers

Re: [PATCH 1/7] usb: gadget: atmel_usba_udc: Remove redundant platform_set_drvdata()

2013-05-06 Thread Nicolas Ferre
On 06/05/2013 13:37, Sachin Kamat : Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Nicolas Ferre nicolas.fe...@atmel.com Acked-by: Nicolas Ferre

Re: [PATCH 1/7] USB: gadget: atmel_usba: move global struct usba_ep usba_ep to struct usba_udc

2013-05-23 Thread Nicolas Ferre
On 23/05/2013 04:23, Bo Shen : Hi J, On 5/21/2013 00:25, Jean-Christophe PLAGNIOL-VILLARD wrote: so we can have multiple usb gadget instance Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-usb@vger.kernel.org

Re: [RFC 00/50] ARM: at91: move to common clk framework

2013-06-07 Thread Nicolas Ferre
create mode 100644 drivers/clk/at91/clk-usb.c create mode 100644 drivers/clk/at91/clk-utmi.c rename arch/arm/mach-at91/include/mach/at91_pmc.h = include/linux/clk/at91.h (76%) -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH] USB: ohci-at91: fix PIO handling in relation with number of ports

2012-09-04 Thread Nicolas Ferre
On 08/29/2012 11:49 AM, Nicolas Ferre : If the number of ports present on the SoC/board is not the maximum and that the platform data is not filled with all data, there is an easy way to mess the PIO setup for this interface. This quick fix addresses mis-configuration in USB host platform data

Re: [PATCH] usb: gadget: at91_udc: fix dt support

2012-09-07 Thread Nicolas Ferre
On 09/07/2012 03:27 PM, Fabio Porcedda : Don't fail the initialization check for the platform_data if there is avaiable an associated device tree node. Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks, bye, --- drivers/usb

Re: [PATCH v2] usb: gadget: at91_udc: dt: fix platform_data check

2012-09-11 Thread Nicolas Ferre
based board (PRO3-EVK). Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Cc: Stable sta...@vger.kernel.org [v3.4+] Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Felipe, Greg, can we queue this one for 3.6-final ? Best regards

Re: [PATCH v2] usb: gadget: at91_udc: dt: fix platform_data check

2012-09-12 Thread Nicolas Ferre
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/12/2012 08:14 AM, Felipe Balbi : Hi, On Tue, Sep 11, 2012 at 02:20:19PM +0200, Nicolas Ferre wrote: On 09/11/2012 02:07 PM, Fabio Porcedda : Don't fail the initialization check for the platform_data if there is avaiable an associated

Re: [PATCH] USB: ohci-at91: fix null pointer in ohci_hcd_at91_overcurrent_irq

2012-09-24 Thread Nicolas Ferre
...@jotron.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks a *lot* Joachim for having chased this bug! Alan, Greg, this one is 3.6 last minute material... I Hope that it can make it! --- Note: If 6fffb77c goes into stable please either include this patch also or fold it into 6fffb77c

Re: [PATCH] USB: ohci-at91: fix null pointer in ohci_hcd_at91_overcurrent_irq

2012-09-25 Thread Nicolas Ferre
On 09/24/2012 07:34 PM, Greg KH : On Mon, Sep 24, 2012 at 09:44:31AM +0200, Nicolas Ferre wrote: This patches fixed the issue by adding the gpio valid check. Signed-off-by: Joachim Eastwood joachim.eastw...@jotron.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks a *lot* Joachim

Re: [PATCH] USB: ohci-at91: fix null pointer in ohci_hcd_at91_overcurrent_irq

2012-09-27 Thread Nicolas Ferre
On 09/25/2012 03:40 PM, Greg KH : On Tue, Sep 25, 2012 at 11:48:43AM +0200, Nicolas Ferre wrote: On 09/24/2012 07:34 PM, Greg KH : On Mon, Sep 24, 2012 at 09:44:31AM +0200, Nicolas Ferre wrote: This patches fixed the issue by adding the gpio valid check. Signed-off-by: Joachim Eastwood

Re: [PATCH 14/24] USB: ohci: merge ohci_finish_controller_resume with ohci_resume

2012-10-05 Thread Nicolas Ferre
HCD_FLAG_HW_ACCESSIBLE, which is now handled by ohci_resume(). Signed-off-by: Florian Fainelli flor...@openwrt.org --- drivers/usb/host/ohci-at91.c |2 +- Seems ok for AT91, so Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks Florian, bye, drivers/usb/host/ohci-ep93xx.c |2

Re: [PATCH] usb: gadget: atmel_usba: always test udc-driver

2014-05-09 Thread Nicolas Ferre
...@free-electrons.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks, --- drivers/usb/gadget/atmel_usba_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index 9f65324f9ae0

Re: [PATCH v6 00/16] ARM: at91: move to common clk framework

2013-12-02 Thread Nicolas Ferre
create mode 100644 include/dt-bindings/clk/at91.h rename {arch/arm/mach-at91/include/mach = include/linux/clk}/at91_pmc.h (98%) -- 1.7.9.5 -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

2013-12-03 Thread Nicolas Ferre
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/host/ohci-at91.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 7aec6ca..c406f1e 100644 --- a/drivers/usb/host/ohci-at91

Re: [PATCH 1/3] usb: ohci-at91: fix irq and iomem resource retrieval

2013-12-03 Thread Nicolas Ferre
to avoid resource type mismatch. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/host/ohci-at91.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

2013-12-03 Thread Nicolas Ferre
On 03/12/2013 15:07, Boris BREZILLON : Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks Boris for these fixes. Alan, Greg, can you take

Re: [PATCH 05/12] USB: ohci-at91: Use devm_*() functions

2013-12-11 Thread Nicolas Ferre
-rsrc_len); usb_put_hcd(hcd); - - if (IS_ENABLED(CONFIG_COMMON_CLK)) - clk_put(uclk); - clk_put(hclk); - clk_put(fclk); - clk_put(iclk); fclk = iclk = hclk = NULL; } -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/2] usb: gadget: atmel_usba: Fix sparse warning

2013-12-16 Thread Nicolas Ferre
@samsung.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks. --- drivers/usb/gadget/atmel_usba_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index 409a055..55ae5ef 100644

Re: [PATCH 1/2] USB: at91: fix the number of endpoint parameter

2014-01-17 Thread Nicolas Ferre
On 17/01/2014 03:59, Bo Shen : In sama5d3 SoC, there are 16 endpoints. As the USBA_NR_ENDPOINTS is only 7. So, fix it for sama5d3 SoC using the udc-num_ep. Signed-off-by: Bo Shen voice.s...@atmel.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/gadget

Re: [PATCH 2/2] USB: at91: using USBA_NR_DMAS for DMA channels

2014-01-17 Thread Nicolas Ferre
-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/gadget/atmel_usba_udc.c | 2 +- drivers/usb/gadget/atmel_usba_udc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index 7e67a81..5cded1c

Re: [PATCH 1/2] USB: at91: fix the number of endpoint parameter

2014-01-21 Thread Nicolas Ferre
)) { if (ep_is_control(udc-usba_ep[i])) usba_control_irq(udc, udc-usba_ep[i]); -- 1.8.5.2 Best Regards, Bo Shen Best Regards, Bo Shen -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCHv2 1/6] arch: Change defconfigs to point to g_mass_storage.

2012-11-02 Thread Nicolas Ferre
+- arch/arm/configs/at91sam9g20_defconfig |2 +- For AT91 related defconfigs: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com arch/arm/configs/corgi_defconfig |2 +- arch/arm/configs/davinci_all_defconfig |2 +- arch/arm/configs/h7202_defconfig

Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h

2012-11-16 Thread Nicolas Ferre
: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- arch/arm/include/asm/mach/serial_at91.h | 33 - arch/avr32/include/asm/mach/serial_at91.h | 33 - drivers/tty/serial/atmel_serial.c | 18 --- 3 files

Re: [PATCH 119/493] usb: remove use of __devexit_p

2012-11-20 Thread Nicolas Ferre
Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org [..] drivers/usb/host/ehci-atmel.c| 2 +- drivers/usb/host/ohci-at91.c | 2 +- For Atmel: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com [..] diff --git a/drivers/usb/c67x00/c67x00-drv.c b

Re: [PATCH 22/25] usb/at91_udc: don't use [delayed_]work_pending()

2013-01-07 Thread Nicolas Ferre
-by: Tejun Heo t...@kernel.org Cc: Andrew Victor li...@maxim.org.za Cc: Nicolas Ferre nicolas.fe...@atmel.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Cc: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Cc: Felipe Balbi ba...@ti.com Cc: linux-usb@vger.kernel.org --- Please let

Re: [PATCH 2/2] USB: gadget: at91_adc: fix pullup pin validity check

2013-01-07 Thread Nicolas Ferre
On 12/23/2012 07:08 PM, Jean-Christophe PLAGNIOL-VILLARD : Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-usb@vger.kernel.org --- drivers/usb/gadget/at91_udc.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v4] usb: gadget: at91_udc: move prepare clk into process context

2014-08-13 Thread Nicolas Ferre
there for the same reason. Move clock preparation and setting clock rate into process context (at91udc_probe). Signed-off-by: Ronald Wahl ronald.w...@raritan.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- v3 - v4: - no code changes - update commit message - add changelog v2 - v3

[RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-11-19 Thread Nicolas Ferre
there for the same reason. Move clock preparation and setting clock rate into process context (at91udc_probe). Signed-off-by: Ronald Wahl ronald.w...@raritan.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com Acked-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Nicolas Ferre

Re: [PATCH 1/2] USB: gadget: udc: atmel: change setting for DMA

2014-12-18 Thread Nicolas Ferre
...@atmel.com Seems okay, even if I am not used to these aspects: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com I would also add a stable tag to these patches, something like this: Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver) Cc: sta...@vger.kernel.org # always been there... Felipe, Can you

Re: [PATCH 2/2] USB: gadget: udc: atmel: fix possible IN hang issue

2014-12-18 Thread Nicolas Ferre
, this bit RXRDY has been cleared. So, after the receive_data() function return, this bit should not be cleared again, or else it may cause the accessing FIFO corrupt, which will make the data loss. Signed-off-by: Bo Shen voice.s...@atmel.com Seems okay: Acked-by: Nicolas Ferre nicolas.fe

Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context

2014-12-19 Thread Nicolas Ferre
Le 19/12/2014 15:02, Ronald Wahl a écrit : On 19.12.2014 14:51, Luis Henriques wrote: Hi Felipe, On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote: On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote: From: Ronald Wahl ronald.w...@raritan.com Commit

Re: [PATCHv6 5/5] USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support

2015-02-05 Thread Nicolas Ferre
= { .remove = __exit_p(usba_udc_remove), .driver = { .name = atmel_usba_udc, + .pm = usba_udc_pm_ops, .of_match_table = of_match_ptr(atmel_udc_dt_ids), }, }; -- Nicolas Ferre -- To unsubscribe

Re: [PATCHv6 4/5] USB: gadget: atmel_usba_udc: Prepare for IRQ single edge support

2015-02-05 Thread Nicolas Ferre
usba_udc_errata *errata; +const struct usba_udc_caps *caps; int irq; int vbus_pin; int vbus_pin_inverted; -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCHv3 1/2] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state

2015-01-20 Thread Nicolas Ferre
Le 20/01/2015 12:02, Sylvain Rochet a écrit : Hello, On Mon, Jan 19, 2015 at 12:55:47PM -0600, Felipe Balbi wrote: On Mon, Jan 19, 2015 at 03:09:44PM +0100, Nicolas Ferre wrote: Le 18/01/2015 18:24, Sylvain Rochet a écrit : If vbus gpio is high at init, we should set vbus_prev to true

Re: [PATCHv6 0/6] USB: host: Atmel OHCI and EHCI drivers improvements

2015-01-20 Thread Nicolas Ferre
/host/ohci-at91.c | 126 ++ 2 files changed, 154 insertions(+), 74 deletions(-) As already mentioned for the v5, I'm okay with the whole series: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com So Sylvain, as said by Alan, I think you can now collect all

Re: [PATCHv3 1/2] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state

2015-01-19 Thread Nicolas Ferre
...@finsecur.com Indeed: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com We can also add the following tags: Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver) Cc: sta...@vger.kernel.org # 2.6.x-ish Bye, --- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCHv3 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

2015-01-19 Thread Nicolas Ferre
devstatus; Otherwise, it looks okay, so once little corrections done, you can add my: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks, bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 00/12] Atmel matrix, SMC and UDC rework

2015-01-15 Thread Nicolas Ferre
kernel support usb: gadget: at91_udc: Update DT binding documentation usb: gadget: at91_udc: Allocate udc instance I'm fine with all this: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Great, I plan to add them all to the at91-3.20-drivers branch now. Thanks, best regards

Re: [PATCHv6 2/5] USB: gadget: atmel_usba_udc: Request an auto disabled Vbus signal IRQ instead of an auto enabled IRQ request followed by IRQ disable

2015-01-23 Thread Nicolas Ferre
___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

[RESEND PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2015-01-09 Thread Nicolas Ferre
value Signed-off-by: Songjun Wu songjun...@atmel.com [nicolas.fe...@atmel.com: reworked the commit message] Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver) Cc: sta...@vger.kernel.org # 2.6.x-ish --- Felipe, I tried to collect all

Re: [PATCHv6 2/5] USB: gadget: atmel_usba_udc: Request an auto disabled Vbus signal IRQ instead of an auto enabled IRQ request followed by IRQ disable

2015-02-05 Thread Nicolas Ferre
. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com Suggested-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 9 ++--- 1

Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

2015-03-18 Thread Nicolas Ferre
parent clock (the usb clock), thus preventing any rate change because of 1/ Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Alan Stern st...@rowland.harvard.edu Acked-by: Nicolas Ferre nicolas.fe...@atmel.com and: Fixes: 3440ef169100 (ARM: at91/dt: fix USB high

Re: [PATCH 2/5] USB: host: ohci-at91: remove useless uclk clock

2015-03-23 Thread Nicolas Ferre
boris.brezil...@free-electrons.com Acked-by: Alan Stern st...@rowland.harvard.edu Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Hi Alan, As I don't have any other drivers patch for 4.1, would you mind taking this patch with your tree? I'll take care of the remaining ones dealing with Device Tree

Re: [PATCHv7 0/4] USB: gadget: atmel_usba_udc: PM driver improvements

2015-03-04 Thread Nicolas Ferre
drivers/usb/gadget/udc/atmel_usba_udc.h | 4 + 2 files changed, 159 insertions(+), 53 deletions(-) -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 0/2] ARM: at91: dt: at91sam9n12ek: enable udp device

2015-03-04 Thread Nicolas Ferre
Shen (2): ARM: at91: dt: at91sam9n12: add udp device node ARM: at91: dt: at91sam9n12ek: enable udp Any comments for this patch series? (aka ping?) Hi, For the 2 patches: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com And I've just taken these 2 patches on top of the at91-4.1-dt branch

Re: [PATCHv7 4/4] USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support

2015-03-04 Thread Nicolas Ferre
-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 57 + 1 file changed, 57 insertions(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 999e2f2..d019b6c 100644

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-04-28 Thread Nicolas Ferre
in a follow-up patch. I'm fine with this too. Is this targetted at v4.2 ? Yes, although we may move it to the soc specific include directories to avoid adding more to linux/ BTW, Ben, what _oc_ stands for in the new macro name? Bye, -- Nicolas Ferre -- To unsubscribe from this list: send

[RESEND PATCH 1/2] ARM: at91/dt: trivial: fix USB udc compatible string

2015-06-17 Thread Nicolas Ferre
To please checkpatch and the tiresome reader, add the atmel, prefix to the USB udc compatible string. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com Cc: sta...@vger.kernel.org #4.0+ --- Documentation/devicetree/bindings/usb/atmel-usb.txt | 6 +++--- 1 file changed, 3 insertions(+), 3

[RESEND PATCH 2/2] ARM: at91/dt: update udc compatible strings

2015-06-17 Thread Nicolas Ferre
-electrons.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com Tested-by: Bo Shen voice.s...@atmel.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Cc: sta...@vger.kernel.org #4.0+ --- Hi, This patch was forgotten while dealing with the series usb: atmel_usba_udc: Rework errata

Re: [PATCH] usb: gadget: atmel: fix build warning

2015-05-28 Thread Nicolas Ferre
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks Felipe! Bye, --- drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 4c01953a0869

Re: [RESEND PATCH 2/2] ARM: at91/dt: update udc compatible strings

2015-07-02 Thread Nicolas Ferre
Le 01/07/2015 22:35, Kevin Hilman a écrit : Nicolas Ferre nicolas.fe...@atmel.com writes: From: Boris Brezillon boris.brezil...@free-electrons.com at91sam9g45, at91sam9x5 and sama5 SoCs should not use atmel,at91sam9rl-udc for their USB device compatible property since this compatible

Re: [PATCH 0/5] USB: atmel: rework clock handling

2015-05-22 Thread Nicolas Ferre
: remove useless usb clock ^ can be queued in at91-4.2-dt. They will go through the arm-soc route. And BTW: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks Boris, bye. .../devicetree/bindings/usb/atmel-usb.txt | 25 ++ arch/arm/boot/dts/at91rm9200.dtsi

Re: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

2015-07-08 Thread Nicolas Ferre
Le 07/07/2015 16:02, Robert Baldyga a écrit : Add missing return value check. In case of error print debug message and return error code. Signed-off-by: Robert Baldyga r.bald...@samsung.com Yes, it's indeed missing: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks, bye

Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

2015-09-30 Thread Nicolas Ferre
>>>> >>>> drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘usba_start’: >>>> drivers/usb/gadget/udc/atmel_usba_udc.c:1783:25: error: ‘USBA_ENABLE_MASK’ >>>> undeclared (first use in this function) >>>> usba_writel(udc,

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

2015-09-30 Thread Nicolas Ferre
es (and DT modifications like the 06/16 patch actually). So, I think that Alexandre would agree with me that we should take the whole series with us through the arm-soc tree. An alternative would be to delay the inclusion of the USB part a little bit... Thanks for the heads-up Felipe, Bye, -- N

Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

2015-09-30 Thread Nicolas Ferre
Le 30/09/2015 18:53, Sudip Mukherjee a écrit : > On Wed, Sep 30, 2015 at 06:34:28PM +0200, Nicolas Ferre wrote: >> Le 30/09/2015 18:24, Sudip Mukherjee a écrit : >>> On Wed, Sep 30, 2015 at 11:04:54AM -0500, Felipe Balbi wrote: >>>> On Wed, Sep 23, 2015 at 09:22:48P

Re: [PATCH] usb: gadget: atmel: remove useless include

2015-09-18 Thread Nicolas Ferre
Le 10/08/2015 16:29, Alexandre Belloni a écrit : > Definitions from linux/platform_data/atmel.h are not used, remove the > include. > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> > --

Re: [PATCH] usb: gadget: at91_udc: move at91_udc_data in at91_udc.h

2015-09-18 Thread Nicolas Ferre
Le 10/08/2015 16:46, Alexandre Belloni a écrit : > struct at91_udc_data is now only used inside the driver, move it to its > include. > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Thank

[PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

2015-09-18 Thread Nicolas Ferre
model when driver is bound to a device tree as well. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> Fixes: 47bef3865115 ("usb: gadget: atmel_usba_udc: add ep capabilities support") Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> --- Felipe, As you've just

Re: [PATCH] USB: host: ohci-at91: fix a crash in ohci_hcd_at91_overcurrent_irq

2015-12-03 Thread Nicolas Ferre
: ohci-at91: merge loops in > ohci_hcd_at91_drv_probe) Yes, with: Cc: sta...@vger.kernel.org # 4.3+ > Reported-by: Peter Rosin <p...@axentia.se> > Tested-by: Peter Rosin <p...@axentia.se> > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-b

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-08 Thread Nicolas Ferre
Le 08/06/2016 12:04, Nicolas Ferre a écrit : > Le 08/06/2016 06:15, Wenyou Yang a écrit : >> In order to the save power consumption, as a workaround, suspend >> forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI >> Interrupt Configuration Register in the SFRs w

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-08 Thread Nicolas Ferre
under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + */ > +#ifndef __AT91_SFR_H__ > +#define __AT91_SFR_H__ > + > +#define SFR_DDRCFG 0x04/* DDR Configuration Register */ > +/* 0x08 ~ 0x0c:

Re: [PATCH v3 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node

2016-06-08 Thread Nicolas Ferre
reg = <0x0040 0x10>; > interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>; > clocks = <_clk>, <_clk>, <>; > Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-03 Thread Nicolas Ferre
t;> That may be why you need this now, but that is irrelevant to having a chip >> specific >> compatible string. > > Maybe a property is better. It seems that it's not an issue to the binding that Rob is talking about but the description that you used: "for SAMA5D2 which can force suspend". Don't modify it to use a property for this: a compatible sting makes a lot of sense. So just listing the new compatible string is enough. If the "force suspend" is not needed anymore in next product, we will come back to the "atmel,at91rm9200-ohci" compatible string or add a new one if needed... bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-06-21 Thread Nicolas Ferre
be done before the USB clock is disabled, > resume after the USB clock is enabled. > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Alan, can you take it as it doesn't have dependency on the at91 material anymore. Th

Re: [PATCH 4/6] usb: ehci-atmel: use __maybe_unused to hide pm functions

2016-03-02 Thread Nicolas Ferre
uses a __maybe_unused > annotation to let the compiler know it can silently drop > the function definition. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> > --- > drivers/usb/host/ehci-atmel.c | 6 ++ > 1 f

Re: [PATCH 3/6] usb: ohci-at91: use __maybe_unused to hide pm functions

2016-03-02 Thread Nicolas Ferre
uses a __maybe_unused > annotation to let the compiler know it can silently drop > the function definition. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Thanks Arnd, bye. > --- > drivers/usb/host/ohci-at91.c |

Re: [PATCH 1/2] usb: gadget: udc: at91: use PTR_ERR_OR_ZERO()

2016-03-29 Thread Nicolas Ferre
Le 29/03/2016 11:28, Felipe Balbi a écrit : > coccicheck found this pattern which could be > converted to PTR_ERR_OR_ZERO(). No functional > changes. > > Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Tha

  1   2   >