Re: usb cdc-acm driver cause windows xp sp3 blue screen randomly

2013-07-25 Thread Oliver Neukum
On Thu, 2013-07-25 at 10:06 +0800, Yingchun Li wrote: Ok, but the linux-cdc-acm.inf is provieded by us, so I think there should be something I can learn. Thanks anyway! And the driver binds and operates. The inf file works. The kernel driver is buggy. The driver comes from the vendor. As such

Re: [PATCH 0/2] USBNET: max rx/tx qlen change

2013-07-25 Thread Oliver Neukum
On Thu, 2013-07-25 at 13:47 +0800, Ming Lei wrote: Hi, There are two patches on computing max rx/tx qlen, and fix one performance problem on USB3 NIC. I am afraid bisectability on SS is impaired. Otherwise this looks good. Regards Oliver -- To unsubscribe from this

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-07-25 Thread Oliver Neukum
On Thu, 2013-07-25 at 17:30 +0300, Oleksii Shevchuk wrote: Randomly after returning from S3 or enabling powersaving this trace goes to dmesg: [13115.552920] [a02f3a30] usb_submit_urb+0x360/0x370 [usbcore] [13115.552922] [a042fe96] wdm_int_callback+0x1c6/0x200 [cdc_wdm]

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-07-25 Thread Oliver Neukum
On Thu, 2013-07-25 at 18:45 +0300, Oleksii Shevchuk wrote: lspci -s 00:14.0 -vvv No. It happens with the wdm driver. What net device are you using? Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH 0/2] USBNET: max rx/tx qlen change

2013-07-26 Thread Oliver Neukum
On Thu, 2013-07-25 at 22:19 +0800, Ming Lei wrote: Hi, On Thu, Jul 25, 2013 at 3:38 PM, Oliver Neukum oneu...@suse.de wrote: On Thu, 2013-07-25 at 13:47 +0800, Ming Lei wrote: Hi, There are two patches on computing max rx/tx qlen, and fix one performance problem on USB3 NIC. I am

Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-28 Thread Oliver Neukum
On Sat, 2013-07-27 at 20:21 -0700, David Miller wrote: From: Hayes Wang hayesw...@realtek.com Date: Thu, 25 Jul 2013 15:59:02 +0800 Some USB buffers use stack which may not be DMA-able. Use the buffers from kmalloc to replace those one. Signed-off-by: Hayes Wang hayesw...@realtek.com

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-29 Thread Oliver Neukum
On Fri, 2013-07-26 at 09:54 -0700, Andy Lutomirski wrote: This is kernel 3.9.9-302.fc19.x86_64. I plugged in a BN Nook (a usb mass storage device), used it, and ejected it. This makes suspend fail: [50135.265514] PM: Entering freeze sleep [50135.265517] Suspending console(s) (use

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-29 Thread Oliver Neukum
On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: In addition to my earlier comment, the patch below should be applied. It will fix your immediate problem, although not in the best way. Alan, I think your diagnosis is correct, but not the fix. This is run even in the runtime case. We

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Oliver Neukum
On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: On Mon, 29 Jul 2013, Oliver Neukum wrote: On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: In addition to my earlier comment, the patch below should be applied. It will fix your immediate problem, although not in the best way

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Oliver Neukum
On Tue, 2013-07-30 at 13:00 -0400, Alan Stern wrote: That's why I said the patch would fix the immediate problem but it wasn't the best solution. You do agree that the patch is correct, as far as it goes? It will allow the system to sleep. But it seems to me that a genuine error while

Re: [PATCH 0/4] USB USBNET: loose DMA SG check and support usbnet DMA SG

2013-07-31 Thread Oliver Neukum
On Wed, 2013-07-31 at 18:51 +0800, Ming Lei wrote: Hi, This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers support this kind of sg buffers. Cool. One question though. It makes sense to use sg only if all elements

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-31 Thread Oliver Neukum
On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: On Mon, 29 Jul 2013, Oliver Neukum wrote: On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: In addition to my earlier comment, the patch below should be applied. It will fix your immediate problem, although not in the best way

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-07-31 Thread Oliver Neukum
On Wed, 2013-07-31 at 21:50 +0800, Ming Lei wrote: In the usbnet case, the driver already supports non-sg well. Actually, all current drivers should support non-sg well because urb-sg wasn't introduced for very long time. We can think it as a new feature or DMA enhancement for xHCI

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-08-01 Thread Oliver Neukum
On Thu, 2013-08-01 at 15:30 +0800, Greg Kroah-Hartman wrote: On Wed, Jul 31, 2013 at 09:40:26AM -0700, Sarah Sharp wrote: On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-01 Thread Oliver Neukum
On Thu, 2013-08-01 at 17:13 +0800, Chen Wang wrote: hello, I'm reading code of usb core and driver model/sysfs. I believe they are designed with OOP. Yes, much of the code is OO. However, we usually don't overwrite methods. So, do we have any UML design diagrams for better No. The code was

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-01 Thread Oliver Neukum
8c90d860652aa99e6e60d9b32bc3aa8d4db9efa5 Mon Sep 17 00:00:00 2001 From: Oliver Neukum oneu...@suse.de Date: Thu, 1 Aug 2013 10:08:20 +0200 Subject: [PATCH] sd: error handling during flushing caches It makes no sense to flush the cache of a device without medium. Errors during suspend must be handled according

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Oliver Neukum
On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: On Thu, 1 Aug 2013, Oliver Neukum wrote: On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: More importantly, if we already know that the medium is not present or has been changed since it was last used, then there's no reason

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Oliver Neukum
On Fri, 2013-08-02 at 09:54 -0400, Alan Stern wrote: On Fri, 2 Aug 2013, Oliver Neukum wrote: On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: On Thu, 1 Aug 2013, Oliver Neukum wrote: On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: More importantly, if we already

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-08-05 Thread Oliver Neukum
On Thu, 2013-07-25 at 18:53 +0300, Oleksii Shevchuk wrote: Thank you, could you try the attached patch? Regards Oliver From 0b46b7c8cd1747470d7ed874b3a130090d4d7d3c Mon Sep 17 00:00:00 2001 From: Oliver Neukum oneu...@suse.de Date: Mon, 5 Aug 2013 09:13:51 +0200 Subject

Re: [PATCH v2 3/4] USBNET: support DMA SG

2013-08-05 Thread Oliver Neukum
On Mon, 2013-08-05 at 16:47 +0800, Ming Lei wrote: @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, entry = (struct skb_data *) skb-cb; entry-urb = urb; entry-dev = dev; - entry-length = length; usb_fill_bulk_urb (urb, dev-udev,

Re: [PATCH v3 3/4] USBNET: support DMA SG

2013-08-06 Thread Oliver Neukum
urb-sg. Cc: Eric Dumazet eric.duma...@gmail.com Cc: Ben Hutchings bhutchi...@solarflare.com Cc: Grant Grundler grund...@google.com Cc: Freddy Xin fre...@asix.com.tw Cc: Oliver Neukum oneu...@suse.de Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Ming Lei ming@canonical.com Acked

Re: device failing to enumerate with XHCI

2013-08-10 Thread Oliver Neukum
On Fri, 2013-08-09 at 14:14 -0700, Sarah Sharp wrote: On Thu, Jul 04, 2013 at 03:35:13PM +0200, Oliver Neukum wrote: Hi, this is a Kinetic device for gesture recognition. It enumerates with EHCI. Under XHCI it fails miserably. Hi Oliver, Sorry for not looking at this log sooner

dealing with enclosures that don't handle READ_CAPACITY10

2013-08-12 Thread Oliver Neukum
Hi, I got a bug report about an enclosure that mishandles READ_CAPACITY10. I don't want to introduce yet another quirk. So what about basing this on USB version? Regards Oliver From 58cb3cd4b8a58d986b74e0a41d52de989dbe64bc Mon Sep 17 00:00:00 2001 From: Oliver Neukum

Re: dealing with enclosures that don't handle READ_CAPACITY10

2013-08-12 Thread Oliver Neukum
On Mon, 2013-08-12 at 10:36 -0400, Alan Stern wrote: On Mon, 12 Aug 2013, Oliver Neukum wrote: Hi, I got a bug report about an enclosure that mishandles READ_CAPACITY10. I don't want to introduce yet another quirk. So what about basing this on USB version? @@ -211,8 +212,12

Re: [PATCH net-next 1/3] net/usb/r8152: support aggregation

2013-08-13 Thread Oliver Neukum
On Tue, 2013-08-13 at 20:32 +0800, hayeswang wrote: Oliver Neukum [mailto:oneu...@suse.de] Sent: Tuesday, August 13, 2013 4:49 PM To: Hayeswang Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org Subject: Re: [PATCH net-next 1/3] net/usb/r8152: support

Re: [PATCH] USB: WUSBCORE: clear RPIPE stall for control endpoints

2013-08-14 Thread Oliver Neukum
On Tue, 2013-08-13 at 11:40 -0500, Thomas Pugliese wrote: static void wa_xfer_result_chew(struct wahc *wa, struct wa_xfer *xfer) { @@ -1488,17 +1532,38 @@ error_submit_buf_in: seg-result = result; kfree(wa-buf_in_urb-sg); error_sg_alloc: + __wa_xfer_abort(xfer);

Re: USB suspend/resume sequence

2013-08-14 Thread Oliver Neukum
On Wed, 2013-08-14 at 13:24 +0530, Vivek Gautam wrote: Hi all, Going through the power suspend/resume sequence of USB, got hit by a doubt. I am not able to figure out how the USB core driver takes care of It doesn't. devices and root-hubs across suspend/resume. Are the device contexts

Re: USB suspend/resume sequence

2013-08-14 Thread Oliver Neukum
On Wed, 2013-08-14 at 14:46 +0530, Vivek Gautam wrote: Hi, devices and root-hubs across suspend/resume. Are the device contexts saved somewhere and then restored back on resume ? Usually not. The state of interfaces are the responsibility of interface drivers (colloquially called

Re: [PATCH 2/2] input: misc: New USB eBeam input driver

2013-08-21 Thread Oliver Neukum
On Fri, 2013-08-16 at 22:25 +0200, Yann Cantin wrote: +/* IRQ */ +static int ebeam_read_data(struct ebeam_device *ebeam, unsigned char *pkt) +{ + +/* + * Packet description : 8 bytes + * + * nop packet : FF FF FF FF FF FF FF FF + * + * pkt[0] : Sensors + * bit 1 : ultrasound signal

Re: [PATCH] net: usbnet: update addr_assign_type if appropriate

2013-08-24 Thread Oliver Neukum
-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v3 03/18] xhci: refactor TRB_ENABLE_SLOT case into function

2013-08-24 Thread Oliver Neukum
On Fri, 2013-08-23 at 11:15 +0300, Xenia Ragiadakou wrote: This patch refactors the code in TRB_ENABLE_SLOT switch case in handle_cmd_completion() into a fuction named xhci_handle_cmd_enable_slot(). Hi, it would be nice, in fact probably a requirement, for the commit message to explain what

Re: [usb-storage] Re: dealing with enclosures that don't handle READ_CAPACITY10

2013-09-04 Thread Oliver Neukum
On Mon, 2013-08-19 at 09:50 +0200, Hannes Reinecke wrote: On 08/12/2013 03:17 PM, Oliver Neukum wrote: Hi, I got a bug report about an enclosure that mishandles READ_CAPACITY10. I don't want to introduce yet another quirk. So what about basing this on USB version? Hmm. You _sure_

Re: [PATCH 1/3] USB: use percpu counter to count submitted URBs per device

2013-09-04 Thread Oliver Neukum
On Mon, 2013-08-19 at 10:23 -0700, Greg Kroah-Hartman wrote: Please, use perf, and other things, to find out where real problems are Actually, first thing about the design. in the USB stack. I'm sure there are locations that we can improve on, but until you get some real numbers, it's going

Re: [PATCH 4/5] uas: add dead request list

2013-09-05 Thread Oliver Neukum
On Mon, 2013-09-02 at 13:25 +0200, Gerd Hoffmann wrote: +static void uas_zap_dead(struct uas_dev_info *devinfo) +{ + struct uas_cmd_info *cmdinfo; + struct uas_cmd_info *temp; + struct list_head list; + unsigned long flags; + + spin_lock_irq(uas_lists_lock);

Re: [PATCH] HID: New hid-cp2112 driver.

2013-09-05 Thread Oliver Neukum
On Wed, 2013-08-21 at 15:11 -0500, David Barksdale wrote: From: David Barksdale dbarksd...@uplogix.com +static int cp2112_wait(struct cp2112_device *dev, atomic_t *avail) +{ + int ret = 0; + + ret = wait_event_interruptible_timeout(dev-wait, + atomic_read(avail),

Re: [RFC] USB: cdc-wdm: Extend and improve subdriver interface

2013-09-05 Thread Oliver Neukum
On Tue, 2013-08-20 at 12:35 +0200, Bjørn Mork wrote: bjorn@nemi:~$ mbimcli -d /dev/cdc-wdm0 --query-packet-service-state How does that work internally? So I propose that we add something like this to cdc-wdm instead of extending the If you think the speed will also be handled at a

Re: [RFC] USB: cdc-wdm: Extend and improve subdriver interface

2013-09-06 Thread Oliver Neukum
On Fri, 2013-09-06 at 12:19 +0200, Bjørn Mork wrote: I assume this separate channel for device management was added to MBIM because it wouldn't scale to keep adding new CDC notifications and requests. The MBIM management protocol is easily extended by adding new commands and services,

report about XHCI needing extremely long to sleep

2013-09-13 Thread Oliver Neukum
Hi, I have a report from a customer about an XHCI which needs a ten times increase of timeout in @@ -904,7 +904,7 @@ int xhci_suspend(struct xhci_hcd *xhci) command = ~CMD_RUN; xhci_writel(xhci, command, xhci-op_regs-command); if (xhci_handshake(xhci, xhci-op_regs-status,

Re: Ejected Nook (usb mass storage) prevents suspend

2013-09-13 Thread Oliver Neukum
On Fri, 2013-09-13 at 06:37 -0700, Andy Lutomirski wrote: What's the status of this? Do I still need to test it? I won't have access to the Nook that triggered it the first time for a couple weeks, but I could try to find another device like that. It works for me. I'll push upstream in a

Re: usbnet transmit path problems

2013-09-16 Thread Oliver Neukum
On Thu, 2013-09-12 at 09:56 +0800, Ming Lei wrote: On Thu, Sep 12, 2013 at 12:05 AM, David Laight david.lai...@aculab.com wrote: Patches are always welcome, :-) Indeed, I think your patch, if no better alternatives come up soon, should be taken. None of this is helping me sort out why

Re: [PATCH 1/3] net: usb: cdc_ether: Use wwan interface for Telit modules

2013-09-16 Thread Oliver Neukum
On Mon, 2013-09-16 at 11:47 +0200, Fabio Porcedda wrote: Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Cc: sta...@vger.kernel.org # 3.0+ as far back as it applies cleanly Acked-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH 2/3] net: usb: cdc_ether: fix checkpatch errors and warnings

2013-09-16 Thread Oliver Neukum
On Mon, 2013-09-16 at 11:47 +0200, Fabio Porcedda wrote: Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Acked-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 3/3] net: usb: cdc_ether: use usb.h macros whenever possible

2013-09-16 Thread Oliver Neukum
On Mon, 2013-09-16 at 11:47 +0200, Fabio Porcedda wrote: Use USB_DEVICE_AND_INTERFACE_INFO and USB_VENDOR_AND_INTERFACE_INFO macros to reduce boilerplate. Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Acked-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send

Re: [PATCH] USBNET: fix handling padding packet

2013-09-18 Thread Oliver Neukum
-allocated padding packet at the end of the sg list, so padding packet can be sent to device if drivers require that. Reported-by: David Laight david.lai...@aculab.com Cc: Oliver Neukum oli...@neukum.org Signed-off-by: Ming Lei ming@canonical.com Acked-by: Oliver Neukum oli...@neukum.org

Re: [PATCH] USBNET: fix handling padding packet

2013-09-18 Thread Oliver Neukum
On Wed, 2013-09-18 at 17:52 +0200, Bjørn Mork wrote: No modern device should need the padding. No old device will be able to use the SG feature as implemented. You only enable it on USB3, don't On XHCI. you? If this feature is restricted to USB3 capable devices, then it most certainly can

Re: [PATCH] USBNET: fix handling padding packet

2013-09-19 Thread Oliver Neukum
On Wed, 2013-09-18 at 20:56 +0200, Bjørn Mork wrote: Oliver Neukum oneu...@suse.de wrote: No, USB 3.0 uses no companion controllers, so you can have devices of any speed connected to it. Ah, right. I don't own such modern hardware, but I should have known this anyway. This still

Re: Huawei Wireless data modem in Freescale i.MX6 Board

2013-09-30 Thread Oliver Neukum
On Mon, 2013-09-30 at 08:37 +, Thomas TJ wrote: I'm trying to connect Huawei wireless data modem in Freescale i.MX6 Board. It's detected as a usb device and the result of lsusb is Bus 002 Device 007: ID 12d1:140b Huawei Technologies Co., Ltd. EC1260 Wireless Data Modem HSD USB Card This

Re: [PATCH V5 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-09-30 Thread Oliver Neukum
On Mon, 2013-09-30 at 04:50 +, Enrico Mioso wrote: +static int huawei_cdc_ncm_manage_power(struct usbnet *usbnet_dev, int on) +{ + struct huawei_cdc_ncm_state *drvstate = (void *)usbnet_dev-data; + int rv = 0; + + if ((on atomic_add_return(1, drvstate-pmcount) == 1) || +

Re: [PATCH] xhci: extra long delay for S4

2013-09-30 Thread Oliver Neukum
On Mon, 2013-09-30 at 05:33 -0700, Greg KH wrote: On Mon, Sep 30, 2013 at 02:25:29PM +0200, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de Some controllers really do need much longer than the standard allows. Signed-off-by: Oliver Neukum oneu...@suse.de

Re: [PATCH 1/2] usb-anchor: Ensure poisened gets initialized to 0

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: And do so in a way which ensures that any fields added in the future will also get properly zero-ed. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: So I have come up with this patch instead, which adds the ability to suspend wakeups of usb_wait_anchor_empty_timeout() waiters to the usb_anchor functionality, and uses this in __usb_hcd_giveback_urb() to delay wake-ups until the

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
On Wed, 2013-10-09 at 19:45 +0200, Hans de Goede wrote: Hi, Thanks for the quick review! On 10/09/2013 07:00 PM, Oliver Neukum wrote: On Wed, 2013-10-09 at 17:01 +0200, Hans de Goede wrote: So I have come up with this patch instead, which adds the ability to suspend wakeups

Re: [PATCH 2/2] usb-anchor: Delay usb_wait_anchor_empty_timeout wake up till completion is done

2013-10-09 Thread Oliver Neukum
() to delay wake-ups until the completion handler has run. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] usbnet: fix error return code in usbnet_probe()

2013-10-12 Thread Oliver Neukum
-by: Oliver Neukum oneu...@suse.de -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] uas: Deal with externally triggered reset, and fix reset locking

2013-10-21 Thread Oliver Neukum
On Thu, 2013-10-17 at 20:49 +0200, Hans de Goede wrote: The uas driver is only capable of dealing with an usb-reset it has triggered itself, fix the pre and post reset return values to reflect this. What happens if you get an external reset? This is bad, because we cannot rule it out, for

Re: [PATCH 2/2] uas: Fix reset handling for externally triggered reset

2013-10-22 Thread Oliver Neukum
On Tue, 2013-10-22 at 16:58 +0100, Hans de Goede wrote: Handle usb-device resets not triggered from uas_eh_bus_reset_handler(), when this happens, disable cmd queuing during the reset, and wait for existing requests to finish in pre_reset. Hm. The most likely reason for resetting a device is a

Re: [PATCH 4/4] usb: wusbcore: change WA_SEGS_MAX to a legal value

2013-10-24 Thread Oliver Neukum
On Wed, 2013-10-23 at 14:44 -0500, Thomas Pugliese wrote: change WA_SEGS_MAX to a number that is legal according to the WUSB spec. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com This should go to stable. Regards Oliver -- To unsubscribe from this list:

Re: [PATCH 1/4] usb: wusbcore: set the RPIPE wMaxPacketSize value correctly

2013-10-24 Thread Oliver Neukum
On Wed, 2013-10-23 at 16:14 -0500, Thomas Pugliese wrote: On Thu, 24 Oct 2013, Sergei Shtylyov wrote: Hello. On 10/23/2013 11:44 PM, Thomas Pugliese wrote: For isochronous endpoints, set the RPIPE wMaxPacketSize value using wOverTheAirPacketSize from the endpoint companion

Re: [PATCH] usb: cdc-wdm: ignore speed change notifications

2013-10-29 Thread Oliver Neukum
On Tue, 2013-10-29 at 09:52 +0100, Bjørn Mork wrote: The only notification supported by the Device Management class is Response Available. But this driver is also used as a subdriver of other CDC classes, allowing notifications like Speed Change and Network Connection. This results in log

Re: [PATCH] USB: cdc-wdm: support back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications

2013-10-30 Thread Oliver Neukum
of USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications received and decrement the count and submit the urb for the next response each time userspace completes a read the response. Signed-off-by: Greg Suarez gsua...@smithmicro.com Acked-by: Oliver Neukum oneu...@suse.de -- To unsubscribe from this list: send the line

Re: [PATCH V5 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-11-04 Thread Oliver Neukum
On Fri, 2013-11-01 at 12:35 +0100, Bjørn Mork wrote: So I believe we should do the update unconditionally, and but skip usb_autopm_put_interface if the get failed. Accordingly, these functions should always return 0 (not that there is anything currently checking the return anyway). I'll

Re: CDC-ACM device issue

2013-11-06 Thread Oliver Neukum
On Tue, 2013-11-05 at 21:16 +, Luke-Jr wrote: I am trying to interface with the HEX devices sold by http://technobit.eu/ which appear as CDC-ACM devices, but give an I/O error whenever I try to open them, with some rather unclear error description in dmesg: [10526714.860052] usb 5-2:

conversion to dynamic debug and CONFIG_USB_DEBUG

2013-11-07 Thread Oliver Neukum
. Regards Oliver commit f2577039517e85a99cb54d9267cd7997530d74b4 Author: Oliver Neukum oneu...@suse.de Date: Thu Nov 7 16:28:33 2013 +0100 USB: remove DEBUG for drivers based on the master config option Dynamic debugging should be off by default. If drivers need

compilation of OHCI

2013-11-07 Thread Oliver Neukum
Hi, can someone explain to me why OHCI compiles in that strange manner? Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: compilation of OHCI

2013-11-07 Thread Oliver Neukum
On Thu, 2013-11-07 at 14:05 -0500, Alan Stern wrote: On Thu, 7 Nov 2013, Oliver Neukum wrote: Hi, can someone explain to me why OHCI compiles in that strange manner? Please be more specific: Which aspect of the strangeness are you interested in? :-) The strangeness of compilation

Re: compilation of OHCI

2013-11-07 Thread Oliver Neukum
On Thu, 2013-11-07 at 13:00 -0800, Greg KH wrote: On Thu, Nov 07, 2013 at 08:07:07PM +0100, Oliver Neukum wrote: The strangeness of compilation by #include That was David Brownell's style of coding at the time (you can see it also in the gadget drivers, although most of that has been

Re: conversion to dynamic debug and CONFIG_USB_DEBUG

2013-11-08 Thread Oliver Neukum
On Thu, 2013-11-07 at 07:56 -0800, Greg KH wrote: EHCI looks like it can be easily fixed, OHCI will take some more work, as will UHCI. The other minor hcd drivers should be easy to resolve as well, like I did previously with some of the other ones. I'll gladly take patches for all of that

Re: [PATCH] usbnet: fix race condition caused spinlock bad magic issue

2013-11-11 Thread Oliver Neukum
On Mon, 2013-11-11 at 11:08 +0800, wangbiao wrote: From: wang, biao biao.w...@intel.com Date: Mon, 11 Nov 2013 10:23:40 +0800 Subject: [PATCH] usbnet: fix race condition caused spinlock bad magic issue there is race between usbnet_terminate_urbs and usbnet_bh, when unlink_wakeup used in

Re: [PATCH] usbnet: fix status interrupt urb handling

2013-11-13 Thread Oliver Neukum
On Wed, 2013-11-13 at 10:09 +0100, Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote: Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf sierra_net: keep status interrupt URB active, sierra_net triggers status interrupt

converting uhci to full dynamic debug

2013-11-13 Thread Oliver Neukum
Hi, if I want to convert UHCI to full dynamic debugging, how should I deal with the debug module parameter? Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: converting uhci to full dynamic debug

2013-11-13 Thread Oliver Neukum
On Wed, 2013-11-13 at 15:20 +, David Laight wrote: if I want to convert UHCI to full dynamic debugging, how should I deal with the debug module parameter? Change the default state of the flag? I could, but how would that help? I need to have the basic decision whether to retain the

Re: converting uhci to full dynamic debug

2013-11-13 Thread Oliver Neukum
On Wed, 2013-11-13 at 15:37 +, David Laight wrote: if I want to convert UHCI to full dynamic debugging, how should I deal with the debug module parameter? Change the default state of the flag? I could, but how would that help? I need to have the basic decision whether to

Re: [RFC 1/2] uhci: change dependency for debug parameter

2013-11-13 Thread Oliver Neukum
On Thu, 2013-11-14 at 05:31 +0900, Greg KH wrote: On Wed, Nov 13, 2013 at 06:13:06PM +0100, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de To allow a full switch to dynamic debugging make the debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG

Re: [RFC 1/2] uhci: change dependency for debug parameter

2013-11-14 Thread Oliver Neukum
On Wed, 2013-11-13 at 17:11 -0500, Alan Stern wrote: On Thu, 14 Nov 2013, Greg KH wrote: On Wed, Nov 13, 2013 at 06:13:06PM +0100, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de To allow a full switch to dynamic debugging make the debug parameter conditional

Re: [PATCH V3] usbnet: fix race condition caused spinlock bad magic issue

2013-11-14 Thread Oliver Neukum
to avoid it. Signed-off-by: wang, biao biao.w...@intel.com Signed-off-by: Zhang, Di di.zh...@intel.com Acked-by: Oliver Neukum oli...@neukum.org -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFCv4 01/24] ohci: remove conditional compilation

2013-11-14 Thread Oliver Neukum
On Thu, 2013-11-14 at 11:44 -0500, Alan Stern wrote: On Thu, 14 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de Conditional compilation for debugging is removed in favor of dynamic debugging. To do so 1. the support for debugfs is always compiled 2

Re: [RFCv4 06/24] ehci: convert dbg_status() to dynamic debugging

2013-11-14 Thread Oliver Neukum
On Thu, 2013-11-14 at 11:54 -0500, Alan Stern wrote: On Thu, 14 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de Rewrite it so that the status is evaluated only if the printk is actually executed. Signed-off-by: Oliver Neukum oneu...@suse.de How come you

Re: [RFCv4 07/24] ehci: use new dbg_status() unconditionally

2013-11-14 Thread Oliver Neukum
On Thu, 2013-11-14 at 11:59 -0500, Alan Stern wrote: On Thu, 14 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de With the new dbg_status() the interrupt handler doesn't need conditional compilation Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers

Re: [RFCv4 21/24] uhci: remove conditional compilation

2013-11-14 Thread Oliver Neukum
On Thu, 2013-11-14 at 13:05 -0500, Alan Stern wrote: On Thu, 14 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de It has become unnecessary by #define trickery Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/uhci-hcd.c | 2 -- 1 file

Re: [RFCv4 04/24] ohci: no conditional debugging in root hub hadling

2013-11-14 Thread Oliver Neukum
On Thu, 2013-11-14 at 11:44 -0500, Alan Stern wrote: On Thu, 14 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de With dynamic debugging the selection is done in user space Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/ohci-hub.c | 5

Re: [RFCv4 15/24] uhci: change dependency for debug parameter

2013-11-14 Thread Oliver Neukum
On Thu, 2013-11-14 at 13:04 -0500, Alan Stern wrote: On Thu, 14 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de To allow a full switch to dynamic debugging make the debug parameter conditional on defined(DEBUF) || defined(DYNAMIC_DEBUG) Signed-off-by: Oliver

Re: [RFCv4 05/24] ehci: no conditional compilation for interestingness

2013-11-14 Thread Oliver Neukum
On Thu, 2013-11-14 at 11:49 -0500, Alan Stern wrote: On Thu, 14 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de The decision about what is interesting is done in user space when dynamic debugging is used. Signed-off-by: Oliver Neukum oneu...@suse.de

Re: [RFCv5] kill #undef OHCI_VERBOSE_DEBUG

2013-11-15 Thread Oliver Neukum
On Fri, 2013-11-15 at 18:03 +0400, Sergei Shtylyov wrote: Hello. On 15-11-2013 16:59, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de Perhaps you meant [OHCI_]VERBOSE_DEBUG in the subject? Also, you've posted the patch twice for some reason, once as part

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 13:13:58 Ming Lei wrote: IMO, there is a minor fault in the error handling path of uvc_status_start() inside uvc_v4l2_open(), and the 'users' count should have been decreased before usb_autopm_put_interface(). In theory, the warning can be triggered when the device

[PATCH] uvc: fix race of open and suspend in error case

2013-01-10 Thread Oliver Neukum
Ming Lei reported: IMO, there is a minor fault in the error handling path of uvc_status_start() inside uvc_v4l2_open(), and the 'users' count should have been decreased before usb_autopm_put_interface(). In theory, the warning can be triggered when the device is opened just between

Re: [PATCH] CDC_NCM adding support IFF_NOARP for buggy device

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 21:59:28 Wei Shuai wrote: Hi, I am afraid this is done in an unclean manner. diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 71b6e92..9903f79 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -545,6 +545,7 @@

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 10:20:42 Alan Stern wrote: On Thu, 10 Jan 2013, Oliver Neukum wrote: In the long run it is probably a good idea to pass duplicated URBs to usbmon by a special code path. I'd prefer to add extra information to the WARN_ONCE message. Even though it would

Re: Linux 3.8-rc1 - another regression on USB :-(

2013-01-12 Thread Oliver Neukum
On Saturday 12 January 2013 14:16:02 Andreas Mohr wrote: Greg, Linus, It sounds insane, but after banging on the issue I have found out that USB problem is caused (also in vanilla kernel) with a config change: USB-all built as modules - bad USB USB core built in, UHCI/EHCI modules -

Re: USB device cannot be reconnected and khubd blocked for more than 120 seconds

2013-01-13 Thread Oliver Neukum
On Sunday 13 January 2013 18:42:49 Alex Riesen wrote: On Sun, Jan 13, 2013 at 5:56 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sun, 13 Jan 2013, Alex Riesen wrote: Yes, almost. What about khubd hanging when machine is shutdown? What about it? I have trouble understanding all the

Re: USB device cannot be reconnected and khubd blocked for more than 120 seconds

2013-01-14 Thread Oliver Neukum
On Monday 14 January 2013 11:47:57 Ming Lei wrote: [ 181.175323] echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message. [ 181.183624] modprobeD c04f1920 0 2462 2461 0x [ 181.183685] [c04f1920] (__schedule+0x5fc/0x6d4) from [c005eba4]

Re: Linux 3.8-rc1 - another regression on USB :-(

2013-01-16 Thread Oliver Neukum
On Tuesday 15 January 2013 23:26:20 Woody Suwalski wrote: The modules are insmoded in a fixed order: usb-common, usbcore, xhci-hcd, ehci-hcd, uhci-hcd, ohci-hcd, usbhid, usb_storage,... If all USB is built as modules - I get read errors from USB drives when accessing squash image, boot

Re: [PATCH v7 0/6] solve deadlock caused by memory allocation with I/O

2013-01-17 Thread Oliver Neukum
On Thursday 17 January 2013 09:28:14 Ming Lei wrote: - we still need some synchronization to avoid accessing the storage between sys_sync and device suspend, just like system sleep case, pm_restrict_gfp_mask is needed even sys_sync has been done inside enter_state().

Re: usb3.0 device recognized as usb2.1

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 16:36:29 kishon wrote: Bus 001 Device 004: ID 152d:2509 JMicron Technology Corp. / JMicron USA Technology Corp. JMS539 SuperSpeed SATA II 3.0G Bridge Device Descriptor: You are connecting to the wrong port. Try connecting to bus2 which seems to have usb3. Bus

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 15:25:47 Bjørn Mork wrote: Adding support for the MBIM mode in some Sierra Wireless devices. Some Sierra Wireless firmwares support CDC MBIM but have no CDC Union funtional descriptor. This violates the MBIM specification, but we can easily work around the bug by

Re: [usb-storage] Re: USB storage suspend

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 14:09:26 Alan Stern wrote: The autosuspend delay at the USB level probably should be set to 0; then the autosuspend delay at the SCSI disk level will control the actual power changes. What about things like lsusb? Should we better not go down quite to zero? Note

Re: [usb-storage] Re: USB storage suspend

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 11:58:28 Sarah Sharp wrote: Isn't there a sysfs file to control the polling rate for removable media? I don't remember where is it though. (I seem to ask about mass /sys/block/$DEVICE/events_poll_msecs HTH Oliver -- To unsubscribe from this

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Oliver Neukum
On Monday 21 January 2013 15:47:13 Bjørn Mork wrote: But I wonder if this isn't really a generic problem in usbnet. The FLAG_MULTI_PACKET test here seems completely bogus: if (length % dev-maxpacket == 0) { if (!(info-flags FLAG_SEND_ZLP)) {

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 16:28:48 Bjørn Mork wrote: Agreed. But I believe the condition should be if (!(info-flags FLAG_SEND_ZLP) !(info-flags FLAG_MULTI_PACKET)) { .. } else { urb-transfer_flags |= URB_ZERO_PACKET; } to ensure that we send the ZLP in this case.

Re: [PATCH net 3/3] net: cdc_ncm: fix error path for single interface probing

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 16:50:40 Bjørn Mork wrote: commit bbc8d92 (net: cdc_ncm: add Huawei devices) implemented support for devices with a single combined control and data interface. Fix up the error path so that we do not double release such interfaces in case of probing failures. Hi

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote: Specification says: NCM/MBIM shall not send ZLP if buffer size is dwNtbOutMaxSize. The problem is: dwNtbOutMaxSize value is negotiated between host and device NCM/MBIM entities and usbnet has no knowledge about it. Adding one

  1   2   3   4   5   6   7   8   9   10   >