Re: [PATCH 1/1] subsystem:usb

2016-09-01 Thread Randy Dunlap
On 09/01/16 17:20, James wrote: > This patch fixes a NULL pointer dereference caused by a race codition in the > probe > function of the legousbtower driver. The probe function does not deregister > the > usb interface after an error receiving the devices firmware ID. The device > file > registe

Re: [PATCH v3 2/2] usb: gadget: reword configuration choices

2017-03-10 Thread Randy Dunlap
On 03/10/17 05:11, Romain Izard wrote: > As USB_CONFIGFS is not a part of the "USB Gadget Drivers" choice > anymore, the name for the option and its attached description needs to > be more descriptive. It appears one level higher in the configuration > menu, and without the context provided by the

Re: [PATCH] USB: Build usb_speed_string unconditionally

2012-08-20 Thread Randy Dunlap
On 08/20/12 12:58, Andi Kleen wrote: > On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote: >> On Mon, 20 Aug 2012, Andi Kleen wrote: >> >>> From: Andi Kleen >>> >>> The usb core uses usb_speed_string(). But it's only selected >>> for USB_GADGET. Enable it unconditionally. >> >> What are y

Re: linux-next: Tree for Jun 18 usb/chipidea)

2013-06-18 Thread Randy Dunlap
On 06/18/13 00:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20130617: > on i386: # CONFIG_USB_PHY is not set drivers/built-in.o: In function `ci_hdrc_probe': core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode' chipidea needs to depend on or select some kind of U

Re: [PATCH v2 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-19 Thread Randy Dunlap
On 06/19/13 00:20, Peter Chen wrote: > on i386: > > drivers/built-in.o: In function `ci_hdrc_probe': > core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode' > > Signed-off-by: Peter Chen Reported-by: Randy Dunlap Acked-by: Randy Dunlap Tha

[PATCH] usb: fix build warning in pci-quirks.h when CONFIG_PCI is not enabled

2013-07-23 Thread Randy Dunlap
From: Randy Dunlap Fix warning when CONFIG_PCI is not enabled (from commit 296365781903226a3fb8758901eaeec09d2798e4). drivers/usb/host/pci-quirks.h: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] Signed-off-by: Randy Dunlap

Re: linux-next: Tree for Aug 15 (usb/phy/phy-am335x-control.c)

2013-08-15 Thread Randy Dunlap
On 08/14/13 23:58, Stephen Rothwell wrote: > Hi all, > > Changes since 20130814: > on i386 and x86_64: drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration] -- ~Randy -- To unsubscribe from this list: send the lin

Re: [PATCH] usb: phy: am335x-control: make it compile with

2013-08-16 Thread Randy Dunlap
t as an excercice to figure out that this happens only with > CONFIG_BUG=n. As a fix I replace it with WARN_ON(). And there is a space > before return so fix this, too. > > Reported-by: Randy Dunlap > Signed-off-by: Sebastian Andrzej Siewior Acked-by: Randy Dunlap Thanks. >

Re: linux-next: Tree for Oct 15 (usb gadget f_mass_storage and storage_common)

2013-10-15 Thread Randy Dunlap
On 10/15/13 07:02, Thierry Reding wrote: > Hi all, > > I've uploaded today's linux-next tree to the master branch of the > repository below: > > git://gitorious.org/thierryreding/linux-next.git > > A next-20131015 tag is also provided for convenience. > > Gained a new conflict, but noth

Re: Errot compiling 3.1.-rc4

2013-10-15 Thread Randy Dunlap
On 10/15/13 14:48, jpliste wrote: > Hello, > > I get a compile error with the kernel 3.12-rc4 : > > Kernel: arch/x86/boot/bzImage is ready (#8) > ERROR: "devm_regmap_init_i2c" [drivers/usb/misc/usb3503.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > If I set

[PATCH] usb: fix misc/usb3503.c build error

2013-10-17 Thread Randy Dunlap
From: Randy Dunlap Fix usb3503 build error - it uses an interface that is provided by REGMAP_I2C, so it needs to select that symbol. drivers/built-in.o: In function `usb3503_i2c_probe': usb3503.c:(.text+0x1b2519): undefined reference to `devm_regmap_init_i2c' Reported-by: JP P

Re: linux-next: Tree for Nov 20 (usb/gadget/storage_common.c)

2013-11-20 Thread Randy Dunlap
On 11/19/13 18:28, Stephen Rothwell wrote: > Hi all, > > Please do *not* add any v3.14 material to linux-next until after > v3.13-rc1 is released. > > Changes since 20131119: > on x86_64: when CONFIG_BLOCK is not enabled: drivers/usb/gadget/storage_common.c: In function 'fsg_lun_open': drivers

Re: linux-next: Tree for Apr 4 (usb/gadget/configfs)

2013-04-04 Thread Randy Dunlap
On 04/04/13 00:22, Stephen Rothwell wrote: > Hi all, > > Changes since 20130403: > on x86_64, when CONFIG_BUG is not enabled: CC [M] drivers/usb/gadget/configfs.o drivers/usb/gadget/configfs.c: In function 'config_usb_cfg_unlink': drivers/usb/gadget/configfs.c:442:2: error: implicit declara

Re: linux-next: Tree for Apr 23 (usb storage)

2013-04-23 Thread Randy Dunlap
On 04/23/13 01:00, Stephen Rothwell wrote: > Hi all, > > Changes since 20130422: > on i386, when CONFIG_PM_RUNTIME is not enabled so REALTEK_AUTOPM is not enabled: drivers/usb/storage/realtek_cr.c: In function 'realtek_cr_destructor': drivers/usb/storage/realtek_cr.c:942:11: error: 'struct rts

Re: [PATCH] linux-next:usb-stor:realtek_cr:Fix compile error

2013-04-28 Thread Randy Dunlap
7;realtek_cr_destructor': > drivers/usb/storage/realtek_cr.c:942:11: error: 'struct rts51x_chip' has no > member named 'us' > > Signed-off-by: Wei WANG Reported-by: Randy Dunlap Acked-by: Randy Dunlap Thanks. > --- > drivers/usb/storage/realtek

Re: linux-next: Tree for May 7 (usb/chipidea)

2013-05-07 Thread Randy Dunlap
On 05/06/13 20:49, Stephen Rothwell wrote: > Hi all, > > Please do not add any v3.11 destined work to your linux-next included > branches until after v3.10-rc1 is released. > > I am receiving a (un)reasonable number of conflicts from there being > multiple copies of some commits in various trees.

Re: [PATCH 1/1] usb: chipidea: Improve kconfig

2013-05-08 Thread Randy Dunlap
On 05/08/13 03:02, Peter Chen wrote: > Randy Dunlap reported below problem > at i386: >> drivers/built-in.o: In function `ci_hdrc_host_init': >> (.text+0x2ce75c): undefined reference to `ehci_init_driver' > >> When USB_EHCI_HCD=m and USB_CHIPIDEA=y. > &

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Randy Dunlap
On 05/31/13 15:34, Andy Shevchenko wrote: > On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >> This patch fixes a format specifier warning. dma_addr_t can be either >> u32 or u64 so we should cast to the largest type and change the format >> specifier to %llx. > > dma_addr_t is derived from p

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Randy Dunlap
On 06/01/13 13:31, Joe Perches wrote: > On Sat, 2013-06-01 at 21:09 +0200, Emil Goode wrote: >> I see, will send a second version. > > Hey Emil. > > I believe you can not use %pa with a dma_addr_t > because that could be a different size than a > phy_addr_t. > > (the vsprintf cast and deref is t

[PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK

2013-12-09 Thread Randy Dunlap
From: Randy Dunlap Make USB_CONFIGFS_MASS_STORAGE depend on BLOCK just like the other gadget MASS_STORAGE options do. This fixes the following build errors that occur when BLOCK is not enabled: drivers/usb/gadget/storage_common.c: In function 'fsg_lun_open': drivers/usb/gadget/storag

Re: [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK

2013-12-09 Thread Randy Dunlap
On 12/09/13 11:21, Felipe Balbi wrote: > On Mon, Dec 09, 2013 at 11:18:25AM -0800, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Make USB_CONFIGFS_MASS_STORAGE depend on BLOCK just like the other >> gadget MASS_STORAGE options do. This fixes the following build erro

Re: [PATCH] USB: chipidea: correct spelling mistakes in comment

2013-12-31 Thread Randy Dunlap
On 12/31/13 08:57, Rahul Bedarkar wrote: > > Signed-off-by: Rahul Bedarkar > --- > drivers/usb/chipidea/ci_hdrc_pci.c | 2 +- > drivers/usb/chipidea/core.c| 4 ++-- > drivers/usb/chipidea/udc.c | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers

Re: [PATCH] USB: core: correct spelling mistakes in comments and warning

2013-12-31 Thread Randy Dunlap
On 12/31/13 10:14, Rahul Bedarkar wrote: > > Signed-off-by: Rahul Bedarkar > --- > drivers/usb/core/buffer.c | 2 +- > drivers/usb/core/devio.c| 2 +- > drivers/usb/core/hcd.c | 2 +- > drivers/usb/core/hub.c | 6 +++--- > drivers/usb/core/hub.h | 2 +- > drivers/usb/core/me

Re: [PATCH] USB: core: correct spelling mistakes in comments and warning

2013-12-31 Thread Randy Dunlap
On 12/31/13 12:27, Sergei Shtylyov wrote: > Hello. > > On 12/31/2013 09:30 PM, Randy Dunlap wrote: > >>> Signed-off-by: Rahul Bedarkar >>> --- >>> drivers/usb/core/buffer.c | 2 +- >>> drivers/usb/core/devio.c| 2 +- >>> driver

Re: mmotm 2014-01-02-14-35 uploaded (musb)

2014-01-03 Thread Randy Dunlap
On 01/02/14 14:36, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2014-01-02-14-35 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm

Re: [PATCH v1] USB: chipidea: correct spelling mistakes in comment

2014-01-03 Thread Randy Dunlap
On 01/03/14 12:37, Greg KH wrote: > On Wed, Jan 01, 2014 at 10:02:34AM +0530, Rahul Bedarkar wrote: >> Changes are as follows: > > Changes for what, this patch? > >> 1. Reverted drivers/usb/chipidea/ci_hdrc_pci.c as zeroes and zeros either >> are acceptable > > What do you mean, you don't touch

Re: mmotm 2014-01-02-14-35 uploaded (musb)

2014-01-03 Thread Randy Dunlap
On 01/03/14 12:02, Felipe Balbi wrote: > On Fri, Jan 03, 2014 at 09:57:50AM -0800, Randy Dunlap wrote: >> On 01/02/14 14:36, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2014-01-02-14-35 has been uploaded to >>> >>>http://www.o

Re: [PATCH] USB: wusbcore: correct spelling mistakes in comments and error string

2014-01-03 Thread Randy Dunlap
On 01/03/14 21:47, Rahul Bedarkar wrote: > > Signed-off-by: Rahul Bedarkar > --- > drivers/usb/wusbcore/cbaf.c | 2 +- > drivers/usb/wusbcore/crypto.c | 2 +- > drivers/usb/wusbcore/devconnect.c | 4 ++-- > drivers/usb/wusbcore/security.c | 2 +- > drivers/usb/wusbcore/wa-hc.h

Re: [PATCH v2] USB: wusbcore: correct spelling mistakes in comments and error string

2014-01-04 Thread Randy Dunlap
On 01/03/14 23:07, Rahul Bedarkar wrote: > > Signed-off-by: Rahul Bedarkar Acked-by: Randy Dunlap Thanks. > --- > drivers/usb/wusbcore/cbaf.c | 2 +- > drivers/usb/wusbcore/crypto.c | 2 +- > drivers/usb/wusbcore/devconnect.c | 4 ++-- > drivers/usb/wusbc

Re: [PATCH] USB: core: correct spelling mistakes in comments and warning

2014-01-04 Thread Randy Dunlap
On 01/03/14 21:54, Rahul Bedarkar wrote: > Signed-off-by: Rahul Bedarkar Acked-by: Randy Dunlap Thanks. > --- > drivers/usb/core/buffer.c | 2 +- > drivers/usb/core/devio.c| 2 +- > drivers/usb/core/hcd.c | 2 +- > drivers/usb/core/hub.c | 7 --- > d

[PATCH] usb.h: fix kernel-doc warning

2007-12-03 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix kernel-doc warning in usb.h: Warning(linux-2.6.24-rc3-git7//include/linux/usb.h:166): No description found for parameter 'sysfs_files_created' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- include/linux/usb.h |

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread Randy Dunlap
On Sat, 5 Jan 2008 18:41:39 +0300 Al Boldi wrote: > > Select SCSI for USB Mass Storage support. > > > Cc: David Brownell <[EMAIL PROTECTED]> > Cc: Greg KH <[EMAIL PROTECTED]> > Cc: Andrew Morton <[EMAIL PROTECTED]> > Signed-off-by: Al Boldi <[EMAIL PROTECTED]> > > --- > > --- 23.a/drivers/usb

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread Randy Dunlap
Sam Ravnborg wrote: On Sat, Jan 05, 2008 at 11:03:30PM +0200, Adrian Bunk wrote: On Sat, Jan 05, 2008 at 11:30:24AM -0800, Randy Dunlap wrote: On Sat, 5 Jan 2008 18:41:39 +0300 Al Boldi wrote: Select SCSI for USB Mass Storage support. Cc: David Brownell <[EMAIL PROTECTED]> Cc: G

Re: [PATCH 2/5] USB Kconfig: Select SCSI for USB Mass Storage support

2008-01-05 Thread Randy Dunlap
Stefan Richter wrote: Adrian Bunk wrote: Whether or not an option requires an additional subsystem like e.g. SCSI or SSB are hardware and implementation details we shouldn't bother kconfig users with. What is an implementation detail and what is not? In the end, everything that we configure

Re: [PATCH 0/5] USB Kconfig: Reorganize USB Kconfig Menu

2008-01-13 Thread Randy Dunlap
On Sun, 13 Jan 2008 12:50:16 +0100 Stefan Richter wrote: > Greg KH wrote: > > On Sat, Jan 12, 2008 at 01:20:46PM +0300, Al Boldi wrote: > >> Greg KH wrote: > >>> On Sat, Jan 05, 2008 at 06:40:38PM +0300, Al Boldi wrote: > Reorganize USB Kconfig Menu, and move USB_GADGET out into the Device >

Re: [PATCH 01/05] cypress_m8: Feature buffer fixes

2008-02-11 Thread Randy Dunlap
On Mon, 11 Feb 2008 10:02:52 -0600 (CST) Mike Isely wrote: > On Mon, 11 Feb 2008, Randy Dunlap wrote: > > > On Sun, 10 Feb 2008 20:23:14 -0600 (CST) Mike Isely wrote: > > > > > > > > cypress_m8: Feature buffer fixes > > > > > > From: Mike

Re: [PATCH 01/05] cypress_m8: Feature buffer fixes

2008-02-11 Thread Randy Dunlap
On Sun, 10 Feb 2008 20:23:14 -0600 (CST) Mike Isely wrote: > > cypress_m8: Feature buffer fixes > > From: Mike Isely <[EMAIL PROTECTED]> > > Don't hardcode the feature buffer size; use sizeof() instead. That > way we can easily specify the size in a single spot. Speaking of the > feature buff

[PATCH] usb: convert usb.h struct usb_device to kernel-doc

2008-02-13 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Convert struct usb_device to use kernel-doc notation. Please especially check the @filelist and @usb_classdev descriptions. Fix a few other kernel-doc lines that should be all on one line but were on multiple lines. Signed-off-by: Randy Dunlap &

Re: [PATCH] usb: convert usb.h struct usb_device to kernel-doc

2008-02-13 Thread Randy Dunlap
uspend: for delayed autosuspends > > Typo: the variable is just "autosuspend". "delayed_work" is part of > the structure tag. Thanks, Alan. Updated patch... Any more comments/corrections? --- From: Randy Dunlap <[EMAIL PROTECTED]> Convert struct usb_device to us

Re: "# CONFIG_USB_SUPPORT is not set" but "CONFIG_USB_OHCI_LITTLE_ENDIAN=y" int he same kernel .config file

2014-12-22 Thread Randy Dunlap
On 12/22/14 09:31, Toralf Förster wrote: > On 12/22/2014 06:16 PM, Greg KH wrote: >> If you delete it, does it come back with a 'make oldconfig'? > > it comes back, even on a vanilla kernel (KVM guest): > > n22kvm-clone linux # uname -a > Linux n22kvm-clone 3.19.0-rc1 #1 SMP Sun Dec 21 18:03:48 C

Re: linux-next: Tree for Dec 31 (usb/dwc2)

2015-01-01 Thread Randy Dunlap
On 12/30/14 17:29, Stephen Rothwell wrote: > Hi all, > > There will only be intermittent releases of linux-next between now and > Jan 5. > > Changes since 20141226: > on i386, when CONFIG_USB=m, CONFIG_USB_GADGET=y, and CONFIG_USB_DWC2=y: drivers/built-in.o: In function `_dwc2_hcd_urb_dequeue'

Re: [RESEND PATCH v2] documentation: docbook: document process of writing an musb glue layer

2014-04-07 Thread Randy Dunlap
On 04/05/2014 11:42 AM, Apelete Seketeli wrote: > Document the process of writing an musb glue layer by taking the > Ingenic JZ4740 glue layer as an example, as it seems more simple than > most glue layers due to the basic feature set of the JZ4740 USB device > controller. > > Signed-off-by: Apele

Re: linux-next: Tree for Jul 31 (usb/phy/phy-qcom-8x16-usb.c)

2015-07-31 Thread Randy Dunlap
On 07/30/15 22:47, Stephen Rothwell wrote: > Hi all, > > Changes since 20150730: > on i386: when CONFIG_EXTCON=m: drivers/built-in.o: In function `phy_8x16_remove': phy-qcom-8x16-usb.c:(.text+0x24170a): undefined reference to `extcon_unregister_interest' drivers/built-in.o: In function `phy_

[PATCH -next] usb: phy: fix phy-qcom-8x16-usb build

2015-09-10 Thread Randy Dunlap
From: Randy Dunlap Fix build errors that happen when USB_QCOM_8X16_PHY=y and EXTCON=m: drivers/built-in.o: In function `phy_8x16_init': phy-qcom-8x16-usb.c:(.text+0x86ef4): undefined reference to `extcon_get_cable_state' drivers/built-in.o: In function `phy_8x16_probe': phy-

Re: randconfig build error with next-20140909, in drivers/usb/dwc2/platform.c

2014-09-09 Thread Randy Dunlap
On 09/09/14 07:46, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/usb/dwc2/platform.o: In function `dwc2_platform_driver_init': > platform.c:(.init.text+0x0): multiple definition of `init_module' > drivers/usb/dwc2/gadget.o:gadget.c:(.init.text+0x0): first def

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-28 Thread Randy Dunlap
On 10/27/14 06:13, Tomi Valkeinen wrote: > On 27/10/14 13:59, Jani Nikula wrote: > >>> While doing 'depends on' instead of 'select' is an "easy" fix for this, >>> I do dislike it quite a bit. It's a major pain to go around the kernel >>> config, trying to find all the dependencies that a particula

Re: Build Errors when building usb directory

2014-07-18 Thread Randy Dunlap
On 07/18/2014 10:45 AM, Nick Krause wrote: > Hey Greg and others, > When I built the usb directory today to check a patch I am also > sending to. I seem to hitting > a few compiler errors and a lot of warnings. I am going to attach a > file of my log of this build. > Cheers Nick > Hi, What comm

Re: Build Errors when building usb directory

2014-07-18 Thread Randy Dunlap
On 07/18/2014 12:59 PM, Nick Krause wrote: > On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap wrote: >> On 07/18/2014 10:45 AM, Nick Krause wrote: >>> Hey Greg and others, >>> When I built the usb directory today to check a patch I am also >>> sending to. I seem

Re: linux-next: Tree for Mar 23 (usb gadget f_printer)

2015-03-23 Thread Randy Dunlap
On 03/23/15 01:34, Stephen Rothwell wrote: > Hi all, > > Changes since 20150320: > on x86_64: drivers/built-in.o: In function `printer_func_unbind': f_printer.c:(.text+0x56e25f): undefined reference to `usb_free_all_descriptors' drivers/built-in.o: In function `printer_attr_release': f_printer

[PATCH -next] usb/misc: fix chaoskey build, needs HW_RANDOM

2015-04-02 Thread Randy Dunlap
From: Randy Dunlap Fix build errors when HW_RANDOM is not enabled: drivers/built-in.o: In function `chaoskey_disconnect': chaoskey.c:(.text+0x5f3f00): undefined reference to `hwrng_unregister' drivers/built-in.o: In function `chaoskey_probe': chaoskey.c:(.text+0x5f42a6): undefin

Re: linux-next: Tree for Mar 19 (usb/dwc2)

2015-03-19 Thread Randy Dunlap
On 03/19/15 00:28, Stephen Rothwell wrote: > Hi all, > > Changes since 20150318: > on i386: drivers/built-in.o: In function `dwc2_pci_remove': pci.c:(.text+0x37ecf1): undefined reference to `usb_phy_generic_unregister' drivers/built-in.o: In function `dwc2_pci_probe': pci.c:(.text+0x37ee8d): un

g_dbgp + u_serial: WARNING when unloading g_dbgp module

2019-03-16 Thread Randy Dunlap
Linux v5.0-11053-gebc551f2b8f9 of March 12, on x86_64: with CONFIG_USB_G_DBGP=m # CONFIG_USB_G_DBGP_PRINTK is not set CONFIG_USB_G_DBGP_SERIAL=y CONFIG_USB_U_SERIAL=m Loading g_dbgp module and then unloading it causes: WARNING: CPU: 0 PID: 24523 at ../drivers/usb/gadget/function/u_serial.c:1195

Re: not seeing console logs using usb serial

2019-05-02 Thread Randy Dunlap
On 5/2/19 8:41 AM, Shiv Dev wrote: > Hi, > > I am using a USB serial cable and want to see the kernel logs on the > console, and towards that have the below line in /etc/default/grub > > console=ttyUSB0,115200 console=tty0 > > Hardware: Intel compute stick > OS : ubuntu 18.04 > kernel : 4.1

Re: linux-next: Tree for Mar 21 (usb/dwc3)

2018-03-21 Thread Randy Dunlap
On 03/21/2018 01:25 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180320: > on i386: ERROR: "__tracepoint_dwc3_gadget_generic_cmd" [drivers/usb/dwc3/dwc3.ko] undefined! ERROR: "__tracepoint_dwc3_ep_queue" [drivers/usb/dwc3/dwc3.ko] undefined! ERROR: "__tracepoint_dwc3_free_request

[PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

2018-04-16 Thread Randy Dunlap
From: Randy Dunlap The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB Makefile does not currently build drivers/usb/common/ (where USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify the USB Makefile to always descend into drivers/usb/common/ to build its configured targets

Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

2018-04-17 Thread Randy Dunlap
On 04/17/18 02:01, Hans de Goede wrote: > Hi, > > On 17-04-18 07:14, Randy Dunlap wrote: >> From: Randy Dunlap >> >> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB >> Makefile does not currently build drivers/usb/common/ (where >> USB_ROLE_S

Re: linux-next: Tree for May 8 (usb: typec...)

2018-05-08 Thread Randy Dunlap
On 05/07/2018 10:22 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180507: > on x86_64: WARNING: unmet direct dependencies detected for TYPEC_TCPCI Depends on [n]: STAGING [=y] && TYPEC_TCPM [=y] && I2C [=n] Selected by [y]: - TYPEC_RT1711H [=y] && STAGING [=y] && TYPEC_TCPM [=

Re: [RFC PATCH v3 3/5] usb: typec: Bus type for alternate modes

2018-05-12 Thread Randy Dunlap
On 05/11/2018 06:18 AM, Heikki Krogerus wrote: > Introducing a simple bus for the alternate modes. Bus allows > binding drivers to the discovered alternate modes the > partners support. > > Signed-off-by: Heikki Krogerus > --- > Documentation/ABI/obsolete/sysfs-class-typec | 48 +++ > Documenta

Re: [PATCH/RFC v3 1/4] base: devcon: add a new API to find the graph

2018-05-14 Thread Randy Dunlap
On 05/14/2018 02:15 AM, Yoshihiro Shimoda wrote: > This patch adds a new API "device_connection_find_by_graph()" to > find device connection by using graph. > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/driver-api/device_connection.rst | 4 +-- > drivers/base/devcon.c

Re: USB Floppy Disk Driver

2018-05-14 Thread Randy Dunlap
On 05/14/2018 05:51 PM, Joshua Hudson wrote: > Has anybody tried the USB floppy disk driver in awhile? I just did to > read an old disk, and I couldn't read a single byte. > > I started thinking maybe the hardware's bad, but dd didn't raise en > error even after I pulled it out and got "USB Discon

Re: [PATCH 02/12] usb: usbtmc: Support Read Status Byte with SRQ per file handle

2018-05-17 Thread Randy Dunlap
On 05/17/2018 09:20 AM, Greg KH wrote: >> +file_data = kzalloc(sizeof(*file_data), GFP_KERNEL); >> +if (!file_data) >> +return -ENOMEM; >> + >> +pr_debug("%s - called\n", __func__); > Please do not add "tracing" functions like this. The kernel has a > wonderful built-in fun

Re: linux-next: Tree for May 17 (usb/gadget/udc/aspeed-vhub/)

2018-05-17 Thread Randy Dunlap
On 05/17/2018 12:06 AM, Stephen Rothwell wrote: > > The usb-gadget tree gained a conflict against the usb tree. > on x86_64: drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': hub.c:(.text+0x3a7): undefined reference to `usb_gadget_get_string' CONFIG_LIB_USBCOM

Re: [PATCH v2 2/3] Documentation: usb: add documentation for USB CCID Gadget Device

2018-05-27 Thread Randy Dunlap
Hi, I have a few documentation comments below... On 05/26/2018 02:19 PM, Marcus Folkesson wrote: > Add documentation to give a brief description on how to use the > CCID Gadget Device. > This includes a description for all attributes followed by an example on > how to setup the device with Config

[PATCH -next] usb: build drivers/usb/common/ when USB_SUPPORT is set

2017-11-17 Thread Randy Dunlap
From: Randy Dunlap PHY drivers can use ULPI interfaces when CONFIG_USB (which is host side support) is not enabled, so also build drivers/usb/ when CONFIG_USB_SUPPORT is enabled so that drivers/usb/common/ is built. ERROR: "ulpi_unregister_driver" [drivers/phy/ti/phy-tusb1210.ko]

Re: [PATCH v4 08/73] xarray: Add documentation

2017-12-11 Thread Randy Dunlap
On 12/05/2017 04:40 PM, Matthew Wilcox wrote: > From: Matthew Wilcox > > This is documentation on how to use the XArray, not details about its > internal implementation. > > Signed-off-by: Matthew Wilcox > --- > Documentation/core-api/index.rst | 1 + > Documentation/core-api/xarray.rst | 2

Re: linux-next: Tree for Dec 14 (usb/dwc3)

2017-12-14 Thread Randy Dunlap
On 12/13/2017 11:06 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20171213: > on i386: ERROR: "__tracepoint_dwc3_writel" [drivers/usb/dwc3/dwc3.ko] undefined! ERROR: "__tracepoint_dwc3_readl" [drivers/usb/dwc3/dwc3.ko] undefined! I can send the randconfig file is you need it. --

Re: Naming of tag operations in the XArray

2017-12-18 Thread Randy Dunlap
On 12/15/2017 04:34 AM, Matthew Wilcox wrote: > On Thu, Dec 14, 2017 at 08:22:14PM -0800, Matthew Wilcox wrote: >> On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote: >>>> +A freshly-initialised XArray contains a ``NULL`` pointer at every index. >>>> +Eac

Re: Storing errors in the XArray

2017-12-18 Thread Randy Dunlap
On 12/15/2017 09:10 AM, Matthew Wilcox wrote: > On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote: >>> +The XArray does not support storing :c:func:`IS_ERR` pointers; some >>> +conflict with data values and others conflict with entries the XArray >>> +uses

Re: linux-next: Tree for Jan 11 (usb/mtu3/)

2018-01-11 Thread Randy Dunlap
On 01/10/18 22:18, Stephen Rothwell wrote: > Hi all, > > Changes since 20180110: > on i386 or x86_64: ../drivers/usb/mtu3/mtu3_plat.c: In function 'mtu3_suspend': ../drivers/usb/mtu3/mtu3_plat.c:462:2: error: implicit declaration of function 'ssusb_wakeup_set' [-Werror=implicit-function-declar

Re: linux-next: Tree for Jan 15 (drivers/usb/mtu3/)

2018-01-15 Thread Randy Dunlap
On 01/14/2018 09:44 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180112: > on i386: ../drivers/usb/mtu3/mtu3_plat.c: In function 'mtu3_suspend': ../drivers/usb/mtu3/mtu3_plat.c:462:2: error: implicit declaration of function 'ssusb_wakeup_set' [-Werror=implicit-function-declaration

Re: [PATCH 04/12] usb: common: Small class for USB role switches

2018-02-16 Thread Randy Dunlap
On 02/16/2018 02:47 AM, Hans de Goede wrote: > From: Heikki Krogerus > > diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c > new file mode 100644 > index ..923e3721d183 > --- /dev/null > +++ b/drivers/usb/common/roles.c > @@ -0,0 +1,305 @@ > +// SPDX-License-Identi

Re: [PATCH v2 09/12] usb: roles: Add Intel xHCI USB role switch driver

2018-02-25 Thread Randy Dunlap
On 02/25/2018 07:25 AM, Hans de Goede wrote: > diff --git a/drivers/usb/roles/Kconfig b/drivers/usb/roles/Kconfig > new file mode 100644 > index ..f5a5e6f79f1b > --- /dev/null > +++ b/drivers/usb/roles/Kconfig > @@ -0,0 +1,14 @@ > +if USB_ROLE_SWITCH > + > +config USB_ROLES_INTEL_XHCI

Re: [PATCH v2 12/12] extcon: axp288: Set USB role where necessary

2018-02-25 Thread Randy Dunlap
Hi, On 02/25/2018 07:25 AM, Hans de Goede wrote: > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index a7bca4207f44..de15bf55895b 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -30,7 +30,8 @@ config EXTCON_ARIZONA > > config EXTCON_AXP288 > tr

Re: [PATCH v2 01/12] drivers: base: Unified device connection lookup

2018-02-25 Thread Randy Dunlap
On 02/25/2018 07:24 AM, Hans de Goede wrote: > From: Heikki Krogerus > > Several frameworks - clk, gpio, phy, pmw, etc. - maintain > lookup tables for describing connections and provide custom > API for handling them. This introduces a single generic > lookup table and API for the connections. >

Re: [PATCH v2 03/12] usb: typec: API for controlling USB Type-C Multiplexers

2018-02-25 Thread Randy Dunlap
On 02/25/2018 07:25 AM, Hans de Goede wrote: > From: Heikki Krogerus > > --- > Documentation/driver-api/usb/typec.rst | 73 +++-- > drivers/usb/typec/Makefile | 1 + > drivers/usb/typec/{typec.c => class.c} | 70 > drivers/usb/typec/mux.c| 188

Re: [PATCH v4 01/12] drivers: base: Unified device connection lookup

2018-02-26 Thread Randy Dunlap
On 02/26/2018 10:39 AM, Hans de Goede wrote: > diff --git a/include/linux/connection.h b/include/linux/connection.h > new file mode 100644 > index ..0b4430eae53a > --- /dev/null > +++ b/include/linux/connection.h > @@ -0,0 +1,33 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#ifndef _

Re: [balbi-usb:testing/next 46/49] undefined reference to `extcon_get_edev_by_phandle'

2017-04-08 Thread Randy Dunlap
On 04/08/17 09:29, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git > testing/next > head: 9653f750a746d5abc4bc054d818eb32d1351eae9 > commit: d5a80bad699c94703a0306edd250f65cfd050580 [46/49] usb: dwc3: Add > dual-role support > config: x86_64-rand

Re: [PATCH 0/8] PID allocation IDR implementation

2017-07-14 Thread Randy Dunlap
On 07/14/2017 08:51 AM, Gargi Sharma wrote: > On Fri, Jul 14, 2017 at 4:52 PM, Greg KH wrote: >> On Fri, Jul 14, 2017 at 09:03:08AM +0530, Gargi Sharma wrote: >>> This patchset contains patches for PID allocation. Individual patches >>> in the series break the kernel. But once, the patchset is app

[PATCH] usb: gadget: udc: fix snps_udc_plat.c build errors

2017-09-11 Thread Randy Dunlap
From: Randy Dunlap Fix build errors that happen when CONFIG_EXTCON=m and CONFIG_USB_SNP_UDC_PLAT=y by preventing that combination in Kconfig. CONFIG_EXTCON can still be disabled or enabled for this driver since has stubs for the disabled case, but if CONFIG_EXTCON=m, USB_SNP_UDC_PLAT is

Re: Interfacing a camera to UVC

2017-09-14 Thread Randy Dunlap
On 09/14/17 09:56, Rail Shafigulin wrote: > On Thu, Sep 14, 2017 at 2:21 AM, Oliver Neukum wrote: >> Hi, >> >> either the camera (to be precise: an interface of it) advertises >> itself as UVC compliant and implements the UVC standard. If that >> is the case the existing kernel driver will work an

Re: [PATCH 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-08-24 Thread Randy Dunlap
On 08/24/2018 12:59 PM, Ajay Gupta wrote: > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig > index e36d6c7..5136aeb 100644 > --- a/drivers/usb/typec/ucsi/Kconfig > +++ b/drivers/usb/typec/ucsi/Kconfig > @@ -23,6 +23,16 @@ config TYPEC_UCSI > > if TYPEC_UCSI > > +c

Re: linux-next: Tree for Aug 31 (drivers/usb/gadget/udc/renesas_usb3)

2018-08-31 Thread Randy Dunlap
On 08/30/2018 08:03 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180830: > on i386: drivers/usb/gadget/udc/renesas_usb3.o: In function `renesas_usb3_probe': renesas_usb3.c:(.text+0x16da): undefined reference to `usb_of_get_companion_dev' Full randconfig file is attached. -- ~Ra

[PATCH] usb: typec: fix kernel-doc parameter warning

2018-09-02 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning (13 times): ../drivers/usb/typec/class.c:1497: warning: Excess function parameter 'drvdata' description in 'typec_port_register_altmode' Signed-off-by: Randy Dunlap Cc: Heikki Krogerus --- drivers/usb/typec/class.c |1

[PATCH] usb/dwc3/gadget: fix kernel-doc parameter warning

2018-09-02 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning: ../drivers/usb/dwc3/gadget.c:510: warning: Excess function parameter 'dwc' description in 'dwc3_gadget_start_config' Signed-off-by: Randy Dunlap Cc: Felipe Balbi --- drivers/usb/dwc3/gadget.c |1 - 1 file changed, 1 dele

[PATCH] linux/mod_devicetable.h: fix kernel-doc missing notation for typec_device_id

2018-09-03 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning for missing struct member description: ../include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id' Fixes: 8a37d87d72f0c ("usb: typec: Bus type for alterna

[PATCH] usb/typec: fix kernel-doc notation warning for typec_match_altmode

2018-09-03 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warning for missing function parameter 'mode' description: ../drivers/usb/typec/bus.c:268: warning: Function parameter or member 'mode' not described in 'typec_match_altmode' Also fix typos for same function documentation. Fi

Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD

2018-10-08 Thread Randy Dunlap
On 10/8/18 8:20 AM, Alan Stern wrote: > On Mon, 8 Oct 2018, Greg Kroah-Hartman wrote: > >> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote: >>> A spanking new machine I just got has all but one USB ports wired as 3.0. >>> Booting defconfig resulted in no keyboard or mouse, which was

usbip_vudc: BUG kmalloc-2048 (Not tainted): Poison overwritten

2018-10-13 Thread Randy Dunlap
Kernel 4.19-rc7, on x86_64: Load usbip_vudc module, then unload (rmmod) it. Load it again: [ 169.042156] calling init+0x0/0x1000 [usbip_vudc] @ 1697 [ 169.042396] = [ 169.043678] probe of usbip-vudc.0 returned 1 aft

Re: [PATCH] usbip:vudc: BUG kmalloc-2048 (Not tainted): Poison overwritten

2018-10-18 Thread Randy Dunlap
id=1693 > [ 169.057852]kobject_put+0x86/0x1b0 > [ 169.057853]0xc0c30a96 > [ 169.057855]__x64_sys_delete_module+0x157/0x240 > > Fix it to call platform_device_del() instead and let put_vudc_device() do > the platform_device_put(). > > Reported-b

Re: [RFC PATCH 1/5] driver core: Add fwnode member to struct device_connection

2018-10-24 Thread Randy Dunlap
On 10/24/18 8:05 AM, Heikki Krogerus wrote: > This will prepare the device connection API for connections > described in firmware. > > Signed-off-by: Heikki Krogerus > --- > include/linux/device.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/device.h b/include/li

Re: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-23 Thread Randy Dunlap
Hi, Here are a few Kconfig text corrections. On 12/23/18 7:13 AM, Pawel Laszczak wrote: > diff --git a/drivers/usb/cdns3/Kconfig b/drivers/usb/cdns3/Kconfig > new file mode 100644 > index ..4adfd87811e8 > --- /dev/null > +++ b/drivers/usb/cdns3/Kconfig > @@ -0,0 +1,44 @@ > +config US