[PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Richard Leitner
Replace all hardcoded ttyGS strings with the PREFIX macro. Therefore the PREFIX definition is moved to u_serial.h. Furthermore the modified files are checkpatch.pl compliant now. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- drivers/usb/gadget/f_acm.c| 49

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hello, thanks for your reply! On Fri, 27 Jun 2014 10:46:28 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: Replace all hardcoded ttyGS strings with the PREFIX macro. Why? Because IMHO if PREFIX is available

[PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h Signed-off-by: Richard Leitner richard.leit...@skidata.com --- v2: removed checkpatch.pl resovling (will be in a separate

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 08:41:18 + David Laight david.lai...@aculab.com wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h Lots

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 09:08:01 + David Laight david.lai...@aculab.com wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-07-01 Thread Richard Leitner
On Mon, 30 Jun 2014 07:45:43 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-07-01 Thread Richard Leitner
On Tue, 1 Jul 2014 09:31:49 +0200 Richard Leitner richard.leit...@skidata.com wrote: On Mon, 30 Jun 2014 07:45:43 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact

[PATCH] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-07-18 Thread Richard Leitner
Replace the VDBG and DBG macro with the kernels proper debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c f_serial.c Signed-off-by: Richard Leitner richard.leit...@skidata.com --- drivers/usb/gadget/f_acm.c| 41 - drivers/usb/gadget/f_obex.c

[RFC] usb: gadget: serial: remove PREFIX macro

2014-07-18 Thread Richard Leitner
have ignored this because of the hardcoded strings. Due to the fact the usage of this PREFIX instead of the hardcoded strings in all debug calls would have resulted in a hard to read/grep code it is removed completely. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- note: previous

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, this patch was lying around for some time... are there any comments or objections on this? regards, richard On Fri, 18 Jul 2014 11:39:46 +0200 Richard Leitner richard.leit...@skidata.com wrote: Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, On Mon, 11 Aug 2014 08:50:34 -0500 Felipe Balbi ba...@ti.com wrote: On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote: Hi, this patch was lying around for some time... are there any comments or objections on this? you realise we're still in the middle of the merge

[PATCH v2] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-08-21 Thread Richard Leitner
Replace the VDBG and DBG macro with the kernels proper debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c f_serial.c Signed-off-by: Richard Leitner richard.leit...@skidata.com --- v2: - rebased on Linux v3.17-rc1 - fixed some PARENTHESIS_ALIGNMENT checkpatch.pl warnings --- drivers

[PATCH] usb: gadget: serial: remove PREFIX macro

2014-08-21 Thread Richard Leitner
have ignored this. Due to the fact the usage of this PREFIX in all debug calls would have resulted in a hard to read/grep code it is removed completely. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- changes from RFC to PATCH: - rebased on v3.17-rc1 - fixed some

Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
On 02/05/2017 08:42 AM, Greg KH wrote: > On Fri, Feb 03, 2017 at 11:55:24AM +0100, Richard Leitner wrote: >> +/** >> + * ascii2utf16le() - Helper routine for producing UTF-16LE string >> descriptors >> + * @s: Null-terminated ASCII (actually ISO-8859-1) string >&

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 02:59 PM, Greg KH wrote: > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: >> On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: >>> From: Richard Leitner <d...@g0hl1n.net> >> >> If you want to fix the above you have to

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: From: Richard Leitner &l

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 08:20 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200

[RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-02 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devi

[PATCH v3 0/3] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
for ascii2desc in drivers/usb/core/hcd.c - remove platform data support from usb251xb driver CHANGES v2: - fix max-{b,s}p-current property name - add descriptor string handling from platform_data - fix non-dt handling Richard Leitner (3): lib/string

[PATCH v3 3/3] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devi

[PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
For USB string descriptors we need to convert ASCII strings to UTF16-LE. Therefore make a simple helper function (based on ascii2desc from drivers/usb/core/hcd.c) for that purpose. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- include/linux/string.h | 1 + lib/st

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
On 02/06/2017 04:40 PM, Alan Stern wrote: > On Mon, 6 Feb 2017, Richard Leitner wrote: >> So it would be OK to include linux/nls.h and use utf8s_to_utf16s() in >> drivers/usb/{core/hcd.c,misc/usb251xb.c}? > > Well, we already include linux/nls.h in drivers/usb/core/messag

[PATCH v3 2/3] usb: core: hcd: use ascii2utf16le() in ascii2desc()

2017-02-06 Thread Richard Leitner
As string.c now provides ascii2utf16le() use it in ascii2desc() for converting the string descriptor. Furthermore fix checkpatch.pl issues in ascii2desc(). Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- drivers/usb/core/hcd.c | 22 ++ 1 file chang

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
On 02/06/2017 04:12 PM, Alan Stern wrote: > On Mon, 6 Feb 2017, Richard Leitner wrote: > >> For USB string descriptors we need to convert ASCII strings to UTF16-LE. >> Therefore make a simple helper function (based on ascii2desc from >> drivers/usb/core/hcd.c) for that pu

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-08 Thread Richard Leitner
On 02/06/2017 05:48 PM, Sergei Shtylyov wrote: > Hello! > > On 02/06/2017 05:03 PM, Richard Leitner wrote: > >> For USB string descriptors we need to convert ASCII strings to UTF16-LE. >> Therefore make a simple helper function (based on ascii2desc from &

[PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
From: Richard Leitner <d...@g0hl1n.net> This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. Furthermore add myself as a main

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 09:52 AM, Richard Leitner wrote: > From: Richard Leitner <d...@g0hl1n.net> Please drop/ignore that "From". This patch is from: Richard Leitner <richard.leit...@skidata.com> > > This patch adds a driver for configuration of the Micro

Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Richard Leitner
Hi Greg, On 02/03/2017 10:03 AM, Greg KH wrote: > On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote: >> This patch adds a driver for configuration of the Microchip USB251xB/xBi >> USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus >> co

[PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- CHANGES v2:

[PATCH 1/3] usb: usb251xb: remove max_{power,current}_{sp,bp} properties

2017-02-21 Thread Richard Leitner
-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 20 -- drivers/usb/misc/usb251xb.c| 24 -- 2 files changed, 4 insertions(+), 40 deletions(-) diff --git a/Documentation/devi

[PATCH 2/3] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-02-21 Thread Richard Leitner
Rename oc-delay-* to oc-delay-us and make it expect a time value. Furthermore add -ms suffix to power-on-time. These changes were suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bi

[PATCH 3/3] doc: dt-bindings: usb251xb: mark reg as required

2017-02-21 Thread Richard Leitner
Mark the reg property as required and furthermore fix some typos and spellings in the documentation. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 23 +++--- 1 file changed, 12 insertions(+), 11 del

[PATCH 0/3] usb: misc: improve USB251xB/xBi dt bindings

2017-02-21 Thread Richard Leitner
This patchset improves/fixes the USB251xB/xBi devicetree bindings as recommended by Rob Herring. Richard Leitner (3): usb: usb251xb: remove max_{power,current}_{sp,bp} properties usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time doc: dt-bindings: usb251xb: mark reg

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-15 Thread Richard Leitner
On 02/16/2017 03:30 AM, Rob Herring wrote: On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-21 Thread Richard Leitner
On 02/21/2017 03:37 PM, Rob Herring wrote: > On Thu, Feb 16, 2017 at 12:36 AM, Richard Leitner <m...@g0hl1n.net> wrote: >> On 02/16/2017 03:30 AM, Rob Herring wrote: >>> >>> On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: >>>> &g

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-09 Thread Richard Leitner
On 02/08/2017 09:16 PM, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: >> Should I keep my inline {clr,set}_bit_in_byte() >> functions an use BIT() in there, or delete them and use BIT() >> directly >> in usb251xb_get_ofdata() ?

[PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-10 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- CHANGES v5:

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-27 Thread Richard Leitner
On 02/27/2017 10:48 AM, Jan Lübbe wrote: > On Di, 2017-02-21 at 15:57 +0100, Richard Leitner wrote: >>>>> This is a lot of properties. Are you really finding a need for all of >>>>> them? Is this to handle h/w designers too cheap to put down the EEPROM? >>&g

[PATCH v2 2/4] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-03-06 Thread Richard Leitner
Rename oc-delay-* to oc-delay-us and make it expect a time value. Furthermore add -ms suffix to power-on-time. There changes were suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bi

[PATCH v2 1/4] usb: usb251xb: remove max_{power,current}_{sp,bp} properties

2017-03-06 Thread Richard Leitner
-by: Richard Leitner <richard.leit...@skidata.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 20 -- drivers/usb/misc/usb251xb.c| 24 -- 2 files changed, 4 insertions(+),

[PATCH v2 3/4] doc: dt-bindings: usb251xb: mark reg as required

2017-03-06 Thread Richard Leitner
Mark the reg property as required and furthermore fix some typos and spellings in the documentation. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 23 +++--- 1 file changed, 12 insertions(+), 11 del

[PATCH v2 4/4] MAINTAINERS: usb251xb: remove reference inexistent file

2017-03-06 Thread Richard Leitner
The platform_data header file was dropped in the merged version of the USB251xB driver. Therefore remove its reference from the MAINTAINERS file. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAI

[PATCH v2 0/4] usb: misc: fix/improve USB251xB/xBi dt bindings

2017-03-06 Thread Richard Leitner
MAINTAINERS Richard Leitner (4): usb: usb251xb: remove max_{power,current}_{sp,bp} properties usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time doc: dt-bindings: usb251xb: mark reg as required MAINTAINERS: usb251xb: remove reference inexistent file Documentation/devicetree

Re: [PATCH 6/9] USB: misc: remove unneeded MODULE_VERSION() usage

2017-07-19 Thread Richard Leitner
-Speed Hub Controller" > -#define DRIVER_VERSION "1.0" > > struct usb251xb { > struct device *dev; As I'm pretty new to kernel development I don't know if it's needed/wanted in this case, but if so please feel free to add Acked-by: Richard Leitner &l

Re: Microchip USB Hub Driver Harmonization

2017-05-17 Thread Richard Leitner
On 05/17/2017 06:01 PM, Krzysztof Kozlowski wrote: On Wed, May 17, 2017 at 12:58:38PM +0200, Richard Leitner wrote: ... 1. Currently usb251xb uses i2c_smbus_*, usb3503 uses regmap_* and usb4604 uses i2c_master_* functions for the hub configuration. What would be the preferred solution

Microchip USB Hub Driver Harmonization

2017-05-17 Thread Richard Leitner
Hello, due to the fact (all?) the Microchip (former SMSC) USB hubs share the same I2C configuration interface, I'm currently working on harmonizing those USB Hub drivers. Currently this affects the usb251xb, usb3503 and usb4604 drivers. To avoid preventable efforts (and patch versions) I have some

Re: [PATCH 2/9 v2] usb: usb251xb: Add USB251x specific port count setting

2017-10-04 Thread Richard Leitner
On 09/16/2017 12:42 PM, Serge Semin wrote: > USB251xb as well as USB2517 datasheet states, that all these > hubs differ by number of ports declared as the last digit in the > model name. So USB2512 got two ports, USB2513 - three, and so on. > Such setting must be reflected in the device specific

Re: [PATCH 4/9 v2] usb: usb251xb: Add 5,6,7 ports boost settings

2017-10-04 Thread Richard Leitner
fore we just initialize it with > default zeros. > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> > --- > drivers/usb/misc/usb251xb.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > Looks good to me. Feel free to add: Acked-by: Richa

Re: [PATCH 8/9 v2] usb: usb251xb: Add max power/current dts property support

2017-10-04 Thread Richard Leitner
On 09/21/2017 07:10 PM, Serge Semin wrote: > On Thu, Sep 21, 2017 at 11:26:04AM -0500, Rob Herring wrote: >> On Wed, Sep 20, 2017 at 4:27 PM, Serge Semin wrote: ... >>> These are different parameters of the device. They got different >>>

Re: [PATCH 1/9 v2] usb: usb251xb: Add USB2517i specific struct and IDs

2017-10-04 Thread Richard Leitner
Hi Serge, On 09/16/2017 12:42 PM, Serge Semin wrote: > There are USB2517 and USB2517i hubs, which have almost the same > registers space as already supported USB251xbi series. The difference > it in DIDs and in few functions. This patch adds the USB2517/i data > structures to the driver, so it

Re: [PATCH 03/10 v3] usb: usb251xb: Add USB251x specific port count setting

2017-10-23 Thread Richard Leitner
%u doesn't exist\n", + port); ... and here. } } Otherwise feel free to add: Acked-by: Richard Leitner <richard.leit...@skidata.com> regards, Richard.L -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/10 v3] usb: usb251xb: Add USB2517i specific struct and IDs

2017-10-23 Thread Richard Leitner
"USB251xB/xBi/7i" but here you have "USB251xB/xBi/7i"... #define USB251XB_ADDR_SERIAL_STRING_LEN 0x15 #define USB251XB_ADDR_SERIAL_STRING 0x92 ... @@ -590,5 +609,5 @@ static struct i2c_driver usb251xb_i2c_driver = { module_i2c_driver(usb251xb_i2

Re: [PATCH 09/10 v3] usb: usb251xb: Add max power/current dts property support

2017-10-23 Thread Richard Leitner
Hi, again some nit-picks below... On 10/22/2017 10:38 PM, Serge Semin wrote: This parameters may be varied in accordance with hardware specifics. So lets add the corresponding settings to the usb251xb driver dts specification. Signed-off-by: Serge Semin ---

[PATCH v2] usb: core: introduce per-port over-current counters

2018-02-20 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> For some userspace applications information on the number of over-current conditions at specific USB hub ports is relevant. In our case we have a series of USB hardware (using the cp210x driver) which communicates using a proprietary pr

Re: [PATCH] usb: core: introduce per-port over-current counters

2018-02-19 Thread Richard Leitner
Hi, On 02/19/2018 02:53 PM, Felipe Balbi wrote: > > Hi, > > Richard Leitner <d...@g0hl1n.net> writes: > >> From: Richard Leitner <richard.leit...@skidata.com> >> >> For some userspace applications information on the number of >> over-curre

[PATCH] usb: core: introduce per-port over-current counters

2018-02-19 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> For some userspace applications information on the number of over-current conditions at specific USB hub ports is relevant. Therefore introduce a oc_counter in the usb port struct which is exported via sysfs. Signed-off-by: Richard L

Re: [PATCH] usb: core: introduce per-port over-current counters

2018-02-19 Thread Richard Leitner
On 02/19/2018 04:59 PM, Greg KH wrote: > On Mon, Feb 19, 2018 at 01:01:07PM +0100, Richard Leitner wrote: >> From: Richard Leitner <richard.leit...@skidata.com> >> >> For some userspace applications information on the number of >> over-current conditions at s

Re: [PATCH v2] usb: core: introduce per-port over-current counters

2018-02-20 Thread Richard Leitner
On 02/20/2018 12:55 PM, Felipe Balbi wrote: > > Hi, > > Richard Leitner <d...@g0hl1n.net> writes: >> From: Richard Leitner <richard.leit...@skidata.com> >> >> For some userspace applications information on the number of >> over-current

Re: [PATCH v2] usb: core: introduce per-port over-current counters

2018-03-13 Thread Richard Leitner
+What: /sys/bus/usb/devices/.../(hub >> interface)/portX/over_current_count >> +Date: February 2018 >> +Contact:Richard Leitner <richard.leit...@skidata.com> >> +Description: >> +Most hubs are able to detect over-current situati

[PATCH 0/3] usb: host: pci: PCI ID consolidation

2018-03-14 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> Centralize some hardcoded PCI IDs as definitions in the global include/linux/pci_ids.h file. This is done to reduce the amount of scattered PCI ID definitions and hardcoded values across the kernel. Richard Leitner (3): usb: host: pc

[PATCH 1/3] usb: host: pci: use existing Intel PCI ID macros

2018-03-14 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> Instead of the hardcoded hexadecimal PCI IDs use the existing macros from pci_ids.h for Intel IDs. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- drivers/usb/host/pci-quirks.c | 10 +- drivers/usb/hos

[PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic

2018-03-14 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> Replace the hardcoded PCI vendor ID of Netlogic with a definition in pci_ids.h Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- drivers/usb/host/pci-quirks.c | 2 +- include/linux/pci_ids.h | 2 ++ 2 file

[PATCH 3/3] usb: host: pci: replace hardcoded renesas PCI IDs

2018-03-14 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> Introduce Renesas uPD72020{1,2} PCI device IDs in pci_ids.h and replace the harcoded values with them. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- drivers/usb/host/pci-quirks.c | 6 -- drivers/usb/host/xhci

Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic

2018-03-14 Thread Richard Leitner
On 03/14/2018 11:48 AM, Greg KH wrote: > On Wed, Mar 14, 2018 at 11:29:32AM +0100, Richard Leitner wrote: >> From: Richard Leitner <richard.leit...@skidata.com> >> >> Replace the hardcoded PCI vendor ID of Netlogic with a definition in >> pci_ids.h > > Why

[PATCH v3] usb: core: introduce per-port over-current counters

2018-03-14 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> For some userspace applications information on the number of over-current conditions at specific USB hub ports is relevant. In our case we have a series of USB hardware (using the cp210x driver) which communicates using a proprietary pr

Re: [PATCH 3/3] usb: host: pci: replace hardcoded renesas PCI IDs

2018-03-14 Thread Richard Leitner
On 03/14/2018 11:49 AM, Greg KH wrote: > On Wed, Mar 14, 2018 at 11:29:33AM +0100, Richard Leitner wrote: >> From: Richard Leitner <richard.leit...@skidata.com> >> >> Introduce Renesas uPD72020{1,2} PCI device IDs in pci_ids.h and replace >> the harcoded v

Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic

2018-03-15 Thread Richard Leitner
On 03/15/2018 10:26 AM, Oliver Neukum wrote: > Am Mittwoch, den 14.03.2018, 16:44 +0100 schrieb Richard Leitner: >> On 03/14/2018 04:27 PM, Oliver Neukum wrote: >>> Am Mittwoch, den 14.03.2018, 14:31 +0100 schrieb Richard Leitner: >>>> >>> Well, but it do

Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic

2018-03-14 Thread Richard Leitner
Hi Oliver, thank you for your feedback! On 03/14/2018 01:17 PM, Oliver Neukum wrote: > Am Mittwoch, den 14.03.2018, 11:29 +0100 schrieb Richard Leitner: >> From: Richard Leitner <richard.leit...@skidata.com> >> >> Replace the hardcoded PCI vendor ID of Netlogic with a

Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic

2018-03-14 Thread Richard Leitner
On 03/14/2018 04:27 PM, Oliver Neukum wrote: > Am Mittwoch, den 14.03.2018, 14:31 +0100 schrieb Richard Leitner: >> Hi Oliver, >> thank you for your feedback! >> >> On 03/14/2018 01:17 PM, Oliver Neukum wrote: >>> Am Mittwoch, den 14.03.2018, 11:29 +010

[PATCH v4] usb: core: introduce per-port over-current counters

2018-03-20 Thread Richard Leitner
From: Richard Leitner <richard.leit...@skidata.com> For some userspace applications information on the number of over-current conditions at specific USB hub ports is relevant. In our case we have a series of USB hardware (using the cp210x driver) which communicates using a proprietary pr