Re: [PATCH v3 0/6] Generic PHY Framework

2013-04-19 Thread Sekhar Nori
Hi Kishon, On 3/20/2013 2:41 PM, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY

Re: [PATCH] USB: OHCI: make ohci-da8xx a separate driver

2013-07-02 Thread Sekhar Nori
ago and it was refused by then DaVinci maintainer Kevin Hilman. Yes I saw your patch that is what I mentioned in patch description. We will wait for DaVinci maintainer response,what he will suggest. Note that Sekhar Nori (now Cc'd) is the primary maintainer of davinci, and I'll defer

Re: [PATCH v4] Enable USB peripheral on dm365 EVM

2012-10-08 Thread Sekhar Nori
Hi Constantine, On 10/4/2012 9:52 PM, Constantine Shulyupin wrote: From: Constantine Shulyupin co...@makelinux.com Signed-off-by: Constantine Shulyupin co...@makelinux.com --- Note: USBPHY_CTL_PADDR and USBPHY_CLKFREQ_24MHZ are defined in board-dm365-evm.c because davinci.h can't be

Re: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc

2012-10-11 Thread Sekhar Nori
On 10/11/2012 12:05 PM, Heiko Schocher wrote: Hello Manjunathappa On 11.10.2012 07:42, Manjunathappa, Prakash wrote: Hi, On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote: From: Constantine Shulyupinco...@makelinux.com Remove USB configuration in arch/arm/mach-davinci/usb.c

Re: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc

2012-10-23 Thread Sekhar Nori
On 10/8/2012 6:47 PM, Constantine Shulyupin wrote: From: Constantine Shulyupin co...@makelinux.com Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST and set MUSB_OTG configuration by default because this

Re: [PATCH v3 5/7] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss

2014-07-03 Thread Sekhar Nori
tested on my DRA7x EVM. Boot log here: http://paste.ubuntu.com/7741337/ Tested-by: Sekhar Nori nsek...@ti.com Thanks, Sekhar -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH 2/2] ARM: dts: am437x-gp-evm: Add pinctrl states for usb

2015-08-31 Thread Sekhar Nori
m: move pins to core dwc3] Signed-off-by: Sekhar Nori <nsek...@ti.com> --- arch/arm/boot/dts/am437x-gp-evm.dts | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts index 84aa30c3235a..2

[PATCH 1/2] usb: dwc3: support for pinctrl state change during system sleep

2015-08-31 Thread Sekhar Nori
Add support for USB DRVVBUS pinctrl state change during suspend/resume. This helps is conserving power during system sleep. Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/usb/dwc3/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/us

[PATCH 0/2] AM437x: USB DWC3: save power during system sleep

2015-08-31 Thread Sekhar Nori
- to-RAM for AM437x available. Dave Gerlach (1): ARM: dts: am437x-gp-evm: Add pinctrl states for usb Sekhar Nori (1): usb: dwc3: support for pinctrl state change during system sleep arch/arm/boot/dts/am437x-gp-evm.dts | 30 ++ drivers/usb/dwc3/core.c

Re: [PATCH v5 4/7] phy: da8xx-usb: new driver for DA8xx SoC USB PHY

2016-06-10 Thread Sekhar Nori
vid Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-06-24 Thread Sekhar Nori
On Wednesday 22 June 2016 10:37 PM, David Lechner wrote: > On 05/25/2016 06:15 AM, Sekhar Nori wrote: >> On Tuesday 10 May 2016 10:14 PM, David Lechner wrote: >>> On 05/10/2016 06:26 AM, Sergei Shtylyov wrote: >>>> On 5/10/2016 2:46 AM, David Lechner wrote

Re: [PATCH v3 00/16] da8xx USB clocks

2016-04-11 Thread Sekhar Nori
Hi David, On Thursday 07 April 2016 09:59 PM, David Lechner wrote: > Any further comments before I submit a v4 patchset? Particularly on > patches 3 and 4 which are new in this v3 submission and have not been > commented on yet. I applied some patches which could be applied independently without

Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers.

2016-04-11 Thread Sekhar Nori
On Monday 28 March 2016 10:12 PM, Sergei Shtylyov wrote: > Hello. > > On 03/28/2016 06:02 PM, David Lechner wrote: > +/* register offsets */ +#define CFGCHIP_REG(n)(n * 4) +#define CFGCHIP0_REGCFGCHIP_REG(0) +#define CFGCHIP1_REG

Re: [PATCH v3 03/16] ARM: davinici: da8xx: move usb code to new file

2016-04-11 Thread Sekhar Nori
o have this in a separate file. This way we don't have a bunch of #ifdefs for all of the da8xx stuff. While at it, fix some checkpatch warnings coming from existing code. Signed-off-by: David Lechner <da...@lechnology.com> [nsek...@ti.com: typo and checkpatch fixes] Signed-off-by: Sekhar Nori

Re: [PATCH v3 01/16] dt: davinci: use proper address after @

2016-04-11 Thread Sekhar Nori
On Friday 25 March 2016 05:21 AM, David Lechner wrote: > TI has been using the physical address in DT after the @ in device nodes. > The device tree convention is to use the same address that is used for > the reg property. This updates all davinci DT files to use the proper > convention. > >

Re: [PATCH v3 04/16] ARM: davinci: Move clock init after ioremap.

2016-04-11 Thread Sekhar Nori
On Friday 25 March 2016 05:21 AM, David Lechner wrote: > Some clocks (such as the USB PHY clocks in DA8xx) will need to use iomem. > The davinci_common_init() function must be called before the ioremap, so > the clock init is now split out as separate function. > > Signed-off-by: David Lechner

Re: [PATCH v3 05/16] ARM: davinci: add set_parent callback for mux clocks

2016-04-11 Thread Sekhar Nori
On Friday 25 March 2016 05:21 AM, David Lechner wrote: > Introduce a set_parent callback that will be used for mux clocks, such as > the USB PHY muxes and the async3 clock domain mux. > > Signed-off-by: David Lechner > --- > > v3 changes: none. > > >

Re: [PATCH v3 06/16] ARM: davinci: da850: use clk->set_parent for async3

2016-04-11 Thread Sekhar Nori
On Friday 25 March 2016 05:21 AM, David Lechner wrote: > The da850 family of processors has an async3 clock domain that can be > muxed to either pll0_sysclk2 or pll1_sysclk2. Now that the davinci clocks > have a set_parent callback, we can use this to control the async3 mux > instead of a

Re: [PATCH v2 00/11] da8xx USB clocks

2016-03-23 Thread Sekhar Nori
Hi David, On Thursday 17 March 2016 07:09 PM, Sergei Shtylyov wrote: > On 3/17/2016 5:26 AM, David Lechner wrote: > >> OK, ready for round two. > >You're quick... :-) > >> I've added a new callback in the davinci clocks so that they can properly >> handle clock muxing. The clock functions

Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-23 Thread Sekhar Nori
On Wednesday 23 March 2016 11:15 PM, David Lechner wrote: > On 03/23/2016 11:56 AM, Sekhar Nori wrote: >>> >>> +static struct clk usb_ref_clk = { >>> +.name= "usb_ref_clk", >>> +.rate= 4800, >>> +.set_ra

Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

2016-03-23 Thread Sekhar Nori
On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > This is a new phy driver for the SoC USB controllers on the TI DA8XX > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > The USB 2.0 PHY also allows overriding the VBUS and ID pins. > > Signed-off-by: David Lechner

Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3

2016-03-23 Thread Sekhar Nori
On Wednesday 23 March 2016 10:50 PM, David Lechner wrote: > On 03/23/2016 10:56 AM, Sekhar Nori wrote: >> On Thursday 17 March 2016 07:56 AM, David Lechner wrote: >>> The da850 family of processors has an async3 clock domain that can be >>> muxed to either pll0_s

Re: [PATCH v2 05/11] dt-bindings: Add bindings for phy-da8xx-usb

2016-03-23 Thread Sekhar Nori
On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > Device tree binding for new phy-da8xx-usb driver. > > Signed-off-by: David Lechner > --- > > v2 changes: This is new patch in v2. > > > .../devicetree/bindings/phy/phy-da8xx-usb.txt | 34 >

Re: [PATCH v2 04/11] ARM: davinci: da8xx: add usb phy clocks

2016-03-23 Thread Sekhar Nori
On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > Up to this point, the USB phy clock configuration was handled manually in > the board files and in the usb drivers. This adds proper clocks so that > the usb drivers can use clk_get and clk_enable and not have to worry about > the details.

Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3

2016-03-24 Thread Sekhar Nori
On Thursday 24 March 2016 12:02 AM, David Lechner wrote: > On 03/23/2016 12:29 PM, Sekhar Nori wrote: >> >> Alright, I guess 'can be called' in the comment should have used >> stronger language :) How about late registration of USB clocks as I >> suggested. It should

Re: [PATCH v2 03/11] ARM: davinci: da850: use clk->set_parent for async3

2016-03-23 Thread Sekhar Nori
On Thursday 17 March 2016 07:56 AM, David Lechner wrote: > The da850 family of processors has an async3 clock domain that can be > muxed to either pll0_sysclk2 or pll1_sysclk2. Now that the davinci clocks > have a set_parent callback, we can use this to control the async3 mux > instead of a

Re: [PATCH v5 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-05-25 Thread Sekhar Nori
On Tuesday 10 May 2016 10:14 PM, David Lechner wrote: > On 05/10/2016 06:26 AM, Sergei Shtylyov wrote: >> On 5/10/2016 2:46 AM, David Lechner wrote: >> >>> The CFGCHIP registers are used by a number of devices, so using a syscon >>> device to share them. The first consumer of this will by the >>>

Re: [PATCH v5 0/5] da8xx USB PHY platform devices and clocks (was "da8xx UBS clocks")

2016-05-25 Thread Sekhar Nori
On Monday 23 May 2016 08:44 PM, David Lechner wrote: > On 05/09/2016 06:46 PM, David Lechner wrote: >> v5 changes: renamed "usbphy" to "usb_phy" or "usb-phy" as appropriate >> >> David Lechner (5): >>ARM: davinci: da8xx: add usb phy clocks >>ARM: davinci: da8xx: Add CFGCHIP syscon platform

Re: [PATCH v2] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-24 Thread Sekhar Nori
lso, "ARM: " prefix should be capitalized . > > Signed-off-by: Alexandre Bailon <abai...@baylibre.com> > Suggested-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-19 Thread Sekhar Nori
On Thursday 19 January 2017 07:39 PM, Alexandre Bailon wrote: > Add usb20 to the list of clock supported by PM runtime. > > Signed-off-by: Alexandre Bailon > --- > arch/arm/mach-davinci/pm_domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v3 5/5] usb: musb: da8xx: Add a primary support of PM runtime

2017-01-19 Thread Sekhar Nori
On Thursday 19 January 2017 10:12 PM, Sergei Shtylyov wrote: > On 01/19/2017 05:08 PM, Alexandre Bailon wrote: > >> Currently, DA8xx doesn't support PM runtime. >> In addition, the glue driver is managing the clock itself. >> But the CPPI DMA needs to manage this clock too. >> Add support to PM

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

2017-01-20 Thread Sekhar Nori
On Thursday 19 January 2017 11:01 PM, Alexandre Bailon wrote: > On 01/19/2017 05:49 PM, Grygorii Strashko wrote: >> On 01/19/2017 09:08 AM, Alexandre Bailon wrote: >>> On 01/19/2017 03:48 PM, Sekhar Nori wrote: >>>> On Thursday 19 January 2017 07:39 PM, Alexandre

Re: [PATCH/RFT v2 06/17] ARM: davinci: da8xx: Fix some redefined symbol warnings

2016-10-25 Thread Sekhar Nori
fined symbol warnings. > Remove the old macros. > > Signed-off-by: Alexandre Bailon <abai...@baylibre.com> This is a v4.9-rc bug fix. Can you please post it as a separate patch for Greg to pick up? You can add: Acked-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar -- To

Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-10-25 Thread Sekhar Nori
On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote: > Hi Sekar, > > On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori <nsek...@ti.com> wrote: >> On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: >>> From: David Lechner <da...@lechnology.com> &g

Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot

2016-10-25 Thread Sekhar Nori
On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: > From: Axel Haslam > > The phy framework requests an optional "phy" regulator. If it does > not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot > for the omap138-lcdk board, this would

Re: [PATCH/RFT v2 03/17] ARM: davinci: da8xx: Add USB PHY platform declaration

2016-10-25 Thread Sekhar Nori
On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: > +static struct platform_device da8xx_usb_phy = { > + .name = "da8xx-usb-phy", > + .id = 0, There is a single phy control in the system for both 1.1 and 2.0 PHYs. so this can be a singular device (id

Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable

2016-10-25 Thread Sekhar Nori
On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: > diff --git a/arch/arm/mach-davinci/usb-da8xx.c > b/arch/arm/mach-davinci/usb-da8xx.c > index 9e41a7f..982e105 100644 > --- a/arch/arm/mach-davinci/usb-da8xx.c > +++ b/arch/arm/mach-davinci/usb-da8xx.c > @@ -53,11 +53,19 @@ int

Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-10-25 Thread Sekhar Nori
On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: > From: David Lechner > > The CFGCHIP registers are used by a number of devices, so using a syscon > device to share them. The first consumer of this will by the phy-da8xx-usb > driver. > > Signed-off-by:

Re: [PATCH/RFT v2 00/17] Add DT support for ohci-da8xx

2016-10-25 Thread Sekhar Nori
Hi Axel, On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: > From: Axel Haslam > > The purpose of this patch series is to add DT support and modernize > the ohci-da8xx glue driver without breaking the non-DT boot, > which is still used in unconverted davinci

Re: [PATCH/RFT v2 12/17] USB: ochi-da8xx: Use a regulator for vbus/overcurrent

2016-10-25 Thread Sekhar Nori
On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: > From: Axel Haslam > > Currently, the da8xx ohci driver uses a set of gpios and callbacks in > board files to handle vbus and overcurrent irqs form the power supply. > However, this does not play nice when

Re: [PATCH v2 1/3] ARM: davinci: da8xx: Fix ohci device name

2016-11-23 Thread Sekhar Nori
On Thursday 03 November 2016 09:33 PM, Axel Haslam wrote: > While the clk lookup table is making reference to "ohci" > other subsystems (such as phy) are trying to match "ohci.0" > > Since there is a single ohci instance, instead of changing > the clk name, change the dev id to -1, and add the

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-15 Thread Sekhar Nori
On Wednesday 16 November 2016 02:28 AM, Tony Lindgren wrote: > * Sekhar Nori <nsek...@ti.com> [161115 00:35]: >> If pm_runtime_get_sync() fails due to callback error, then >> rpm_callback() sets dev.power.runtime_error to an error value which gets >>

Re: [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device nodeg

2016-11-15 Thread Sekhar Nori
On Wednesday 16 November 2016 02:49 AM, Bin Liu wrote: > On Tue, Nov 15, 2016 at 04:16:02PM +0530, Sekhar Nori wrote: >> On Thursday 03 November 2016 09:29 PM, Alexandre Bailon wrote: >>> This adds the device tree node for the usb otg >>> controller present i

Re: [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node

2016-11-16 Thread Sekhar Nori
On Wednesday 16 November 2016 04:05 PM, Alexandre Bailon wrote: > On 11/15/2016 11:46 AM, Sekhar Nori wrote: >> On Thursday 03 November 2016 09:29 PM, Alexandre Bailon wrote: >>> This adds the device tree node for the usb otg >>> controller present in the da850 fam

Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node

2016-11-21 Thread Sekhar Nori
On Monday 21 November 2016 03:57 PM, Axel Haslam wrote: > On Mon, Nov 21, 2016 at 3:42 AM, David Lechner wrote: >> On 11/07/2016 02:39 PM, Axel Haslam wrote: >>> >>> This adds the ohci device node for the da850 soc. >>> It also enables it for the omapl138 hawk board. >>> >>>

Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node

2016-11-21 Thread Sekhar Nori
On Monday 21 November 2016 04:16 PM, Sekhar Nori wrote: >>> In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci >>> >> tree, the alias for the musb device is usb0. So, I think we should use >>> >> usb1 >>> >> h

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-15 Thread Sekhar Nori
On Saturday 12 November 2016 12:58 AM, Tony Lindgren wrote: > If we return early on pm_runtime_get() error, we need to also call > pm_runtime_put_noidle() as pointed out in a musb related thread > by Johan Hovold . This is to keep the PM runtime > use counts happy. > > Fixes:

Re: [PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node

2016-11-15 Thread Sekhar Nori
On Thursday 03 November 2016 09:29 PM, Alexandre Bailon wrote: > This adds the device tree node for the usb otg > controller present in the da850 family of SoC's. > This also enables the otg usb controller for the lcdk board. > > Signed-off-by: Alexandre Bailon > --- >

Re: [PATCH v5 0/2] platform: Add DT support for DA8xx

2016-11-20 Thread Sekhar Nori
On Wednesday 16 November 2016 04:37 PM, Alexandre Bailon wrote: > This add and enable the usb otg for da850 and da850-lcdk. > This series depends on "driver: dd DT support for DA8xx" patch set. I see that Bin has already applied this. > If this series is applied before the "usb: musb: da8xx: Fix

Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

2016-10-26 Thread Sekhar Nori
On Tuesday 25 October 2016 09:23 PM, David Lechner wrote: > Hi Sekhar, > > On 10/25/2016 05:17 AM, Sekhar Nori wrote: >> On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote: >>> Hi Sekar, >>> >>> On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori <nse

Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable

2016-10-26 Thread Sekhar Nori
On Tuesday 25 October 2016 09:35 PM, David Lechner wrote: > On 10/25/2016 05:12 AM, Sekhar Nori wrote: >> On Monday 24 October 2016 10:16 PM, ahas...@baylibre.com wrote: >>> diff --git a/arch/arm/mach-davinci/usb-da8xx.c >>> b/arch/arm/mach-davinci/usb-da8xx.c >&g

Re: [PATCH 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

2016-11-03 Thread Sekhar Nori
On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote: > To be consistent on the usb driver for the davinci > platform follow the example of musb, and add the > "-da8xx" postfix to the driver name. > > Signed-off-by: Axel Haslam > --- > drivers/usb/host/ohci-da8xx.c |

Re: [PATCH 0/3] fix ohci phy name

2016-11-03 Thread Sekhar Nori
On Thursday 03 November 2016 01:54 PM, Axel Haslam wrote: > Hi Sekhar, David, > > It might make sense to have this patch series, > squashed into a single patch, would you agree, > or do you prefer it as is: one-per-subsystem? Patches in the current form are okay. Some coordination is required in

Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

2016-11-03 Thread Sekhar Nori
Hi Kishon, On Thursday 03 November 2016 10:20 PM, Kishon Vijay Abraham I wrote: > > > On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote: >> There is only one ohci on the da8xx series of chips, >> so remove the ".0" when creating the phy. Also add >> the "-da8xx" postfix to be consistent

Re: [PATCH 2/3] usb: musb: Add a quirk to preserve MUSB_DEVCTL during suspend

2016-12-06 Thread Sekhar Nori
On Monday 05 December 2016 10:17 PM, Bin Liu wrote: > On Fri, Dec 02, 2016 at 03:23:50PM +0100, Alexandre Bailon wrote: >> On 11/29/2016 06:56 PM, Bin Liu wrote: >>> On Tue, Nov 29, 2016 at 06:41:04PM +0100, Alexandre Bailon wrote: On 11/29/2016 05:16 PM, Bin Liu wrote: > Hi, > >

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

2017-01-11 Thread Sekhar Nori
On Tuesday 10 January 2017 09:19 PM, Tony Lindgren wrote: > * Alexandre Bailon <abai...@baylibre.com> [170110 07:23]: >> On 01/10/2017 11:05 AM, Sekhar Nori wrote: >>> On DA8xx, CPPI 4.1 DMAengine is not an independent system resource, but >>> embedded within th

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

2017-01-11 Thread Sekhar Nori
On Tuesday 10 January 2017 07:15 PM, Alexandre Bailon wrote: > On 01/09/2017 07:26 PM, Sergei Shtylyov wrote: >>> +0x201000 0x1000 >>> +0x202000 0x1000 >>> +0x204000 0x4000>; >>> +reg-names = "glue", "controller", >>> +

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

2017-01-10 Thread Sekhar Nori
On Tuesday 10 January 2017 03:08 PM, Alexandre Bailon wrote: > On 01/09/2017 07:08 PM, Grygorii Strashko wrote: >> >> >> On 01/09/2017 10:06 AM, Alexandre Bailon wrote: >>> The da8xx has a cppi41 dma controller. >>> This is add the glue layer required to make it work on da8xx, >>> as well some

Re: [RESEND PATCH v6 4/4] usb: musb: da8xx: Add a primary support of PM runtime

2017-03-29 Thread Sekhar Nori
On Tuesday 28 March 2017 06:09 AM, Kevin Hilman wrote: > Alexandre Bailon writes: > >> Currently, MUSB DA8xx glue driver doesn't have PM runtime support. >> Because the CPPI 4.1 is using the same clock as MUSB DA8xx and >> CPPI 4.1 is a child of MUSB DA8xx glue, add support

[PATCH] usb: hcd: use correct device pointer for dma ops

2017-04-03 Thread Sekhar Nori
different device pointers. Fix it. Fixes: a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus") Reported-by: Carlos Hernandez <c...@ti.com> Acked-by: Roger Quadros <rog...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/usb/core/hcd.c | 2 +-

Re: [PATCH] ARM: davinci: Add the clock for the CPPI 4.1 DMA engine

2017-04-04 Thread Sekhar Nori
On Wednesday 29 March 2017 09:39 PM, Alexandre Bailon wrote: > The CPPI 4.1 DMA is sharing its clock with the USB OTG, > and most of the time, the clock will be enabled by USB. > But during the init of the DMA, USB is not enabled (waiting for DMA), > and then we must enable the clock before to do

Re: [PATCH v2] ARM: davinci: Add the clock for the CPPI 4.1 DMA engine

2017-04-12 Thread Sekhar Nori
On Friday 07 April 2017 11:01 PM, Alexandre Bailon wrote: > > > On 04/07/2017 06:15 PM, Alexandre Bailon wrote: >> >> >> On 04/07/2017 04:36 PM, Sekhar Nori wrote: >>> On Wednesday 05 April 2017 10:47 PM, Alexandre Bailon wrote: >>>> The CP

Re: [PATCH] usb: dwc3: gadget: delay unmap of bounced requests

2017-04-10 Thread Sekhar Nori
Hi Felipe, On Monday 10 April 2017 05:53 PM, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> From: Janusz Dziedzic >>> >>> In the case of bounced ep0 requests, we must delay DMA operation until >>> after ->complete() otherwise we might

Re: [PATCH v2] ARM: davinci: Add the clock for the CPPI 4.1 DMA engine

2017-04-07 Thread Sekhar Nori
On Wednesday 05 April 2017 10:47 PM, Alexandre Bailon wrote: > The CPPI 4.1 DMA is sharing its clock with the USB OTG, > and most of the time, the clock will be enabled by USB. > But during the init of the DMA, USB is not enabled (waiting for DMA), > and then we must enable the clock before doing

Re: [PATCH 1/2] usb: musb: musb_cppi41: Fix the address of teardown and autoreq registers

2017-08-14 Thread Sekhar Nori
On Monday 14 August 2017 07:01 PM, Sekhar Nori wrote: > Hi, > > On Sunday 13 August 2017 05:34 PM, Alexandre Bailon wrote: >> The DA8xx and DSPS platforms don't use the same address for few registers. >> On Da8xx, this is causing some issues (e.g. teardown that doesn'

Re: [PATCH 1/2] usb: musb: musb_cppi41: Fix the address of teardown and autoreq registers

2017-08-14 Thread Sekhar Nori
Hi, On Sunday 13 August 2017 05:34 PM, Alexandre Bailon wrote: > The DA8xx and DSPS platforms don't use the same address for few registers. > On Da8xx, this is causing some issues (e.g. teardown that doesn't work). > Configure the address of the register during the init and use them instead > of

Re: Warning dump on OMAP-L138 when g_zero module is removed

2017-07-10 Thread Sekhar Nori
On Thursday 06 July 2017 10:43 PM, Alexandre Bailon wrote: > On 06/29/2017 03:50 PM, Sekhar Nori wrote: >> Hi Alexandre, Bin, >> >> With latest linux-next, I see a warning dump when I remove g_zero[1] on >> OMAP-L138 LCDK board. I am building the kernel

Warning dump on OMAP-L138 when g_zero module is removed

2017-06-29 Thread Sekhar Nori
Hi Alexandre, Bin, With latest linux-next, I see a warning dump when I remove g_zero[1] on OMAP-L138 LCDK board. I am building the kernel with davinci_all_defconfig. It is not present in latest mainline because the warnings are introduced with CPPI DMA getting enabled in latest -next.

Re: [PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match

2017-08-08 Thread Sekhar Nori
On Tuesday 08 August 2017 07:50 PM, Roger Quadros wrote: > On 17/05/17 11:15, Sekhar Nori wrote: >> Calculate wMaxPacketSize before endpoint matching the >> descriptor is found. >> >> This allows audio gadget to be used with controllers >> which have a shorta

Re: Warning dump on OMAP-L138 when g_zero module is removed

2017-08-06 Thread Sekhar Nori
Hi Alexandre, On Sunday 06 August 2017 01:37 AM, Alexandre Bailon wrote: > Hi Sekhar, > On 07/21/2017 05:18 PM, Alexandre Bailon wrote: >> Hi Sekhar, >> >> On 07/10/2017 01:00 PM, Sekhar Nori wrote: >>> On Thursday 06 July 2017 10:43 PM, Alexandre Bailon wrote: &g

[PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match

2017-05-17 Thread Sekhar Nori
which has a MUSB HS controller with endpoints having max packet size much less than 1023 or 1024. See mode_2_cfg in drivers/usb/musb/musb_core.c Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/usb/gadget/function/f_uac2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 del

Re: [RESEND PATCH v5] ARM: dts: da850: Add the CPPI 4.1 DMA to the USB OTG controller

2017-05-25 Thread Sekhar Nori
On Friday 19 May 2017 07:03 PM, Alexandre Bailon wrote: > This adds the CPPI 4.1 DMA controller to the USB OTG controller. > > Changes since v2: > - Fixed the the property reg-names (had glue register defined) > - Removed few useless property > > Signed-off-by: Alexandre Bailon

Re: [RESEND PATCH v5] ARM: dts: da850: Add the CPPI 4.1 DMA to the USB OTG controller

2017-05-30 Thread Sekhar Nori
On Thursday 25 May 2017 02:41 PM, Sekhar Nori wrote: > On Friday 19 May 2017 07:03 PM, Alexandre Bailon wrote: >> This adds the CPPI 4.1 DMA controller to the USB OTG controller. >> >> Changes since v2: >> - Fixed the the property reg-names (had glue register define

Re: [PATCH] usb: musb: musb_cppi41: Update an error message

2017-05-01 Thread Sekhar Nori
Hi Alexandre, On Friday 28 April 2017 09:34 PM, Alexandre Bailon wrote: > If dma_request_slave_channel() failed to return a channel, > then the driver will print an error and request to defer probe. > Update the error message to explain we are defrering probe. > > Signed-off-by: Alexandre Bailon

Re: [PATCH] usb: musb: musb_cppi41: Update an error message

2017-05-02 Thread Sekhar Nori
On Tuesday 02 May 2017 06:24 PM, Bin Liu wrote: > On Tue, May 02, 2017 at 11:21:54AM +0530, Sekhar Nori wrote: >> Hi Alexandre, >> >> On Friday 28 April 2017 09:34 PM, Alexandre Bailon wrote: >>> If dma_request_slave_channel() failed to return a channel, >>&

Re: [PATCH v2 0/4] Update MUSB CPPI 4.1 driver to correctly manage the DA8xx

2017-09-26 Thread Sekhar Nori
vice mode (msc and ecm) have been tested. Tested-by: Sekhar Nori <nsek...@ti.com> Tested on DA850 LCDK using g_ether (module probe and removal) and g_ether (fast ping traffic test). It will be nice if this can go into v4.14-rc cycle as these are important fixes for DA850 platform. Thanks,

Re: [PATCH 1/2] usb: musb: musb_cppi41: Fix the address of teardown and autoreq registers

2017-09-04 Thread Sekhar Nori
On Monday 14 August 2017 07:06 PM, Sekhar Nori wrote: > On Monday 14 August 2017 07:01 PM, Sekhar Nori wrote: >> Hi, >> >> On Sunday 13 August 2017 05:34 PM, Alexandre Bailon wrote: >>> The DA8xx and DSPS platforms don't use the same address for few registers. >

Re: [PATCH 1/3] usb: musb: gadget: fix to_musb_request() to not return NULL

2018-04-25 Thread Sekhar Nori
On Thursday 19 April 2018 01:35 AM, Bin Liu wrote: > The gadget function drivers should ensure the usb_request parameter > passed in is not NULL. UDC core doesn't check if it is NULL, so MUSB > driver shouldn't have to check it either. > > Convert to_musb_request() to a simple macro to not

Re: [PATCH 1/3] usb: musb: gadget: fix to_musb_request() to not return NULL

2018-04-25 Thread Sekhar Nori
On Thursday 26 April 2018 11:23 AM, Sekhar Nori wrote: > On Thursday 19 April 2018 01:35 AM, Bin Liu wrote: >> The gadget function drivers should ensure the usb_request parameter >> passed in is not NULL. UDC core doesn't check if it is NULL, so MUSB >> driver shouldn't ha