Re: [PATCH 1/2] usb-audio: correct speed checking

2016-05-08 Thread Takashi Iwai
On Wed, 04 May 2016 14:18:39 +0200, Oliver Neukum wrote: > > Allow handling SS+ USB devices correctly. > > Signed-off-by: Oliver Neukum Thanks, applied both patches now. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Sun, 25 Nov 2012 23:01:27 +0100, Clemens Ladisch wrote: > > Jonathan Nieder wrote: > > Some USB MIDI keyboards fail to operate after a USB autosuspend. > > Make that *all* USB MIDI devices with input ports. > > This is not a bug in the device, but one of the many bugs introduced > with the au

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 13:35:31 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote:> At Sun, 25 Nov 2012 23:01:27 +0100, > > Clemens Ladisch wrote: > >> > >> Jonathan Nieder wrote: > >>> Some USB MIDI keyboards fail to operate after a USB autosuspen

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 14:43:13 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Clemens Ladisch wrote: > >> Takashi Iwai wrote: > >>> Clemens Ladisch wrote: > >>>> I'm working on a fix that adds proper power management for input ports,

Re: [alsa-devel] Jack sensing in snd_usb_audio ?

2016-10-18 Thread Takashi Iwai
On Wed, 12 Oct 2016 18:15:04 +0200, Bastien Nocera wrote: > > On Wed, 2016-10-12 at 18:06 +0200, Clemens Ladisch wrote: > > Bastien Nocera wrote: > > > On Wed, 2016-10-12 at 14:43 +0200, Clemens Ladisch wrote: > > > > Bastien Nocera wrote: > > > > > " > > > > > A change of state in the audio funct

Re: [alsa-devel] Jack sensing in snd_usb_audio ?

2016-10-18 Thread Takashi Iwai
On Tue, 18 Oct 2016 15:33:42 +0200, Felipe Ferreri Tonello wrote: > > Hi Takashi > > On 18/10/16 13:07, Takashi Iwai wrote: > > On Wed, 12 Oct 2016 18:15:04 +0200, > > Bastien Nocera wrote: > >> > >> On Wed, 2016-10-12 at 18:06 +0200, Clemens Ladisch wr

Re: [PATCH] ALSA: usb: caiaq: audio: don't print error when allocating urb fails

2016-08-11 Thread Takashi Iwai
On Thu, 11 Aug 2016 22:40:11 +0200, Wolfram Sang wrote: > > kmalloc will print enough information in case of failure. > > Signed-off-by: Wolfram Sang Applied, thanks. Takashi > --- > sound/usb/caiaq/audio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/usb/caiaq/audio.c b/s

Re: Fwd: Regression: Line6 Toneport stops working on 4.10-rc5

2017-02-06 Thread Takashi Iwai
On Mon, 06 Feb 2017 11:18:44 +0100, Greg KH wrote: > > On Mon, Feb 06, 2017 at 01:01:56PM +0300, Igor Zinovev wrote: > > Hello again! > > > > Thanks for the advice, but bisecting the whole tree took me quite a > > while and I ended up stuck because booting on some bisect states has > > led my sys

Re: Fwd: Regression: Line6 Toneport stops working on 4.10-rc5

2017-02-06 Thread Takashi Iwai
On Mon, 06 Feb 2017 12:04:29 +0100, Andrej Kruták wrote: > > On Mon, Feb 6, 2017 at 12:01 PM, Takashi Iwai wrote: > > On Mon, 06 Feb 2017 11:18:44 +0100, > > Greg KH wrote: > >> > >> On Mon, Feb 06, 2017 at 01:01:56PM +0300, Igor Zinovev wrote: > >>

Re: [PATCH] ALSA: line6: Always setup isochronous transfer properties

2017-02-06 Thread Takashi Iwai
On Mon, 06 Feb 2017 20:34:58 +0100, Andrej Krutak wrote: > > While not all line6 devices currently support PCM, it causes no > harm to 'have it prepared'. > > This also fixes toneport, which only has PCM - in which case > we previously skipped the USB transfer properties detection completely. >

Re: [PATCH] ALSA: line6: Always setup isochronous transfer properties

2017-02-07 Thread Takashi Iwai
On Mon, 06 Feb 2017 22:54:59 +0100, Andrej Kruták wrote: > > On Mon, Feb 6, 2017 at 10:19 PM, Takashi Iwai wrote: > > On Mon, 06 Feb 2017 20:34:58 +0100, > > Andrej Krutak wrote: > >> > >> While not all line6 devices currently support PCM, it caus

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

2013-07-11 Thread Takashi Iwai
> > Cc: Jaroslav Kysela > > Cc: Takashi Iwai > > Cc: alsa-de...@alsa-project.org > > Signed-off-by: Ming Lei > > --- > > sound/usb/usx2y/usbusx2yaudio.c |4 > > 1 file changed, 4 insertions(+) > > > diff --git a/sound/usb/usx2y/usbus

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

2013-07-11 Thread Takashi Iwai
At Thu, 11 Jul 2013 22:13:35 +0800, Ming Lei wrote: > > On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai wrote: > > At Thu, 11 Jul 2013 17:08:30 +0400, > > Sergei Shtylyov wrote: > >> > >> On 11-07-2013 13:06, Ming Lei wrote: > >> > >> > Co

Re: Buffer size for ALSA USB PCM audio

2013-07-24 Thread Takashi Iwai
At Wed, 24 Jul 2013 10:41:43 -0400 (EDT), Alan Stern wrote: > > I have been studying the data_ep_set_params() function in > sound/usb/endpoint.c. This is the routine that calculates the number > of samples and I/O requests to keep on the USB hardware queue for PCM > audio, based on the ALSA param

Re: Buffer size for ALSA USB PCM audio

2013-07-24 Thread Takashi Iwai
At Wed, 24 Jul 2013 11:22:00 -0400 (EDT), Alan Stern wrote: > > On Wed, 24 Jul 2013, Takashi Iwai wrote: > > > At Wed, 24 Jul 2013 10:41:43 -0400 (EDT), > > Alan Stern wrote: > > > > > > I have been studying the data_ep_set_params() function in > >

Re: Buffer size for ALSA USB PCM audio

2013-07-25 Thread Takashi Iwai
At Wed, 24 Jul 2013 11:43:58 -0400 (EDT), Alan Stern wrote: > > On Wed, 24 Jul 2013, Takashi Iwai wrote: > > > > I don't understand. Consider a simple playback example. Suppose the > > > user wants to keep the latency low, so he requests 2 periods per > >

Re: Buffer size for ALSA USB PCM audio

2013-07-29 Thread Takashi Iwai
At Thu, 25 Jul 2013 10:50:49 -0400 (EDT), Alan Stern wrote: > > On Thu, 25 Jul 2013, Takashi Iwai wrote: > > > > Besides, what's the reason for allocating 10 URBs if you're not going > > > to submit more than 2 of them at a time? > > > > I d

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-07-29 Thread Takashi Iwai
At Mon, 29 Jul 2013 21:23:15 +0200, Daniel Mack wrote: > > On 29.07.2013 20:20, Alan Stern wrote: > > data_ep_set_params() checks snd_usb_endpoint_implicit_feedback_sink() > > in three places. It looks like only the second place is correct. > > > > Can you verify whether the other two are right

Re: [alsa-devel] [PATCH] 6fire: fix DMA issues with URB transfer_buffer usage

2013-08-07 Thread Takashi Iwai
At Tue, 06 Aug 2013 14:53:24 +0300, Jussi Kivilinna wrote: > > Patch fixes 6fire not to use stack as URB transfer_buffer. URB buffers need to > be DMA-able, which stack is not. Furthermore, transfer_buffer should not be > allocated as part of larger device structure because DMA coherency issues an

Re: [alsa-devel] [PATCH] 6fire: fix DMA issues with URB transfer_buffer usage

2013-08-07 Thread Takashi Iwai
At Wed, 7 Aug 2013 15:59:07 +0200, Torsten Schenk wrote: > > On Wed, 07 Aug 2013 14:43:43 +0200 > Takashi Iwai wrote: > > > At Tue, 06 Aug 2013 14:53:24 +0300, > > Jussi Kivilinna wrote: > > > > > > Patch fixes 6fire not to use stack as URB transfe

Re: [PATCH] 6fire: fix URB transfer buffer for midi output

2013-08-07 Thread Takashi Iwai
[Cc'ed to linux-usb ML] At Wed, 7 Aug 2013 16:51:49 +0200, Torsten Schenk wrote: > > Patch fixes URB transfer buffer allocation for midi output to be DMA-able. Is this really needed? That is, can't a transfer buffer be at middle of kmalloc'ed space, but must be always the head of the kmalloc'ed

Re: [PATCH] 6fire: fix URB transfer buffer for midi output

2013-08-07 Thread Takashi Iwai
At Wed, 7 Aug 2013 13:38:20 -0400 (EDT), Alan Stern wrote: > > On Wed, 7 Aug 2013, Takashi Iwai wrote: > > > [Cc'ed to linux-usb ML] > > > > At Wed, 7 Aug 2013 16:51:49 +0200, > > Torsten Schenk wrote: > > > > > > Patch fixes URB t

Re: [alsa-devel] [PATCH] 6fire: fix URB transfer buffer for midi output

2013-08-08 Thread Takashi Iwai
At Thu, 08 Aug 2013 09:16:27 +0200, Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Alan Stern wrote: > >> A buffer _can_ be in the middle of a kmalloc'ed space, but the CPU must > >> not access any of the fields around it that might occupy the same cache

Re: [alsa-devel] [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-08 Thread Takashi Iwai
At Wed, 07 Aug 2013 23:24:46 +0400, Бойко Максим wrote: > > From: Maksim Boyko > > Add the volume control quirk for avoiding the kernel warning for Logitech HD > Webcam C525. > The similar patch was previously reported for Logitech HD Webcam C310 (see > 36691e1be6ec551eef4a5225f126a281f8c051c2

Re: [alsa-devel] [PATCH] usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-12 Thread Takashi Iwai
At Sat, 10 Aug 2013 12:20:02 +0400, Maksim A. Boyko wrote: > > Add the volume control quirk for avoiding the kernel warning > for the Logitech HD Webcam C525 > as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2 > for the Logitech HD Webcam C310. > > Reported-by: Maksim Boyko > Tes

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-12 Thread Takashi Iwai
At Thu, 1 Aug 2013 13:37:45 -0400 (EDT), Alan Stern wrote: > > On Mon, 29 Jul 2013, Clemens Ladisch wrote: > > > Alan Stern wrote: > > > Clemens remarked some time ago that keeping the queue full would be > > > trivial, if only he knew how full it needed to be. The answer to that > > > is given

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-12 Thread Takashi Iwai
At Mon, 12 Aug 2013 10:53:36 -0400 (EDT), Alan Stern wrote: > > On Mon, 12 Aug 2013, Takashi Iwai wrote: > > > > Here's what I've got. In turns out the predicting the optimum number > > > of URBs needed is extremely difficult. I decided it would be better t

Re: [PATCH v1 45/49] sound: usb: caiaq: prepare for enabling irq in complete()

2013-08-19 Thread Takashi Iwai
At Sun, 18 Aug 2013 00:25:10 +0800, Ming Lei wrote: > > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Jaroslav Kysela > Cc: Takashi Iwai Acked-by: Takashi Iwai thanks, Takashi > Cc: alsa-de...@alsa-project.org &g

Re: [PATCH v1 44/49] sound: usb: midi: prepare for enabling irq in complete()

2013-08-19 Thread Takashi Iwai
At Sun, 18 Aug 2013 00:25:09 +0800, Ming Lei wrote: > > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Jaroslav Kysela > Cc: Takashi Iwai Acked-by: Takashi Iwai thanks, Takashi > Cc: Clemens Ladisch > Cc: alsa-de...@a

[PATCH] xhci: Fix spurious wakeups after S5 on Haswell

2013-09-09 Thread Takashi Iwai
evice to PCI D3 at shutdown and remove ops. The PCI D3 call is based on the initial fix patch by Oliver Neukum. Cc: Oliver Neukum Signed-off-by: Takashi Iwai --- drivers/usb/host/xhci-pci.c | 14 ++ drivers/usb/host/xhci.c | 18 +- drivers/usb/host/xhci.h

[PATCH v2] xhci: Fix spurious wakeups after S5 on Haswell

2013-09-09 Thread Takashi Iwai
evice to PCI D3 at shutdown and remove ops. The PCI D3 call is based on the initial fix patch by Oliver Neukum. Cc: Oliver Neukum Signed-off-by: Takashi Iwai --- v1->v2: forgot to refresh the patch before submission, sorry. drivers/usb/host/xhci-pci.c | 14 ++ drivers/usb/hos

Re: [PATCH v2] xhci: Fix spurious wakeups after S5 on Haswell

2013-09-10 Thread Takashi Iwai
At Tue, 10 Sep 2013 08:38:50 -0700, Sarah Sharp wrote: > > On Tue, Sep 10, 2013 at 08:24:51AM +0200, Takashi Iwai wrote: > > Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show > > mysterious wakeups after shutdown occasionally. After discussing with > &

Re: [PATCH v2] xhci: Fix spurious wakeups after S5 on Haswell

2013-09-11 Thread Takashi Iwai
At Tue, 10 Sep 2013 17:48:37 +0200, Takashi Iwai wrote: > > At Tue, 10 Sep 2013 08:38:50 -0700, > Sarah Sharp wrote: > > > > On Tue, Sep 10, 2013 at 08:24:51AM +0200, Takashi Iwai wrote: > > > Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show

[PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

2013-09-11 Thread Takashi Iwai
CI D3 at shutdown and remove ops. The PCI D3 call is based on the initial fix patch by Oliver Neukum. v1->v2: forgot to refresh the patch before submission v2->v3: reduce the workaround, just call xhci_reset(); also use D3hot Cc: Oliver Neukum Signed-off-by: Takashi Iwai --- drivers/us

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

2013-09-11 Thread Takashi Iwai
At Wed, 11 Sep 2013 10:54:40 -0400 (EDT), Alan Stern wrote: > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show > > mysterious wakeups after shutdown occasionally. After discussing with > > BIOS enginee

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

2013-09-11 Thread Takashi Iwai
At Wed, 11 Sep 2013 18:04:41 +0200, Takashi Iwai wrote: > > At Wed, 11 Sep 2013 11:45:08 -0400 (EDT), > Alan Stern wrote: > > > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > > > At Wed, 11 Sep 2013 10:54:40 -0400 (EDT), > > > Alan Stern wrote:

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

2013-09-11 Thread Takashi Iwai
At Wed, 11 Sep 2013 11:45:08 -0400 (EDT), Alan Stern wrote: > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > At Wed, 11 Sep 2013 10:54:40 -0400 (EDT), > > Alan Stern wrote: > > > > > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > > >

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

2013-09-11 Thread Takashi Iwai
elow is the v4 patch with these cleanups. thanks, Takashi --- From: Takashi Iwai Subject: [PATCH v4] xhci: Fix spurious wakeups after S5 on Haswell Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show mysterious wakeups after shutdown occasionally. After discussing with BIOS engin

Re: Cannot load snd-usb-audio on 3.12-rc2

2013-09-26 Thread Takashi Iwai
At Mon, 23 Sep 2013 16:41:07 -0700, Sarah Sharp wrote: > > The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I > plug in my USB headset. It worked fine on 3.11-rc4 (not sure about > vanilla 3.11). > > Trying to manually load the driver fails: > > sarah@xanatos:~$ sudo modprobe

Re: [PATCH] sound: usb: add support for wireless USB devices

2013-10-07 Thread Takashi Iwai
At Tue, 1 Oct 2013 14:32:15 -0500, Thomas Pugliese wrote: > > This patch updates snd_usb_audio_create also support devices whose > speed == USB_SPEED_WIRELESS. > > Signed-off-by: Thomas Pugliese Thanks, applied now. (BTW, please add the maintainers explicitly to Cc at the next time.) Takas

Re: [PATCH] sound: usb: support wireless devices in snd_usb_parse_datainterval

2013-10-07 Thread Takashi Iwai
At Tue, 1 Oct 2013 14:32:57 -0500, Thomas Pugliese wrote: > > Hi, > This patch adds support for dev speed USB_SPEED_WIRELESS in > snd_usb_parse_datainterval which allows the usb sound core to create > ISO urbs with the correct number and size of buffers. > > Signed-off-by: Thomas Pugliese T

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Takashi Iwai
At Tue, 8 Oct 2013 13:38:26 -0400 (EDT), Alan Stern wrote: > > On Tue, 8 Oct 2013 baum...@hotmail.com wrote: > > > Hello, > > > > please help me with the bug for my Logitech Headset; > > > > https://bugzilla.kernel.org/show_bug.cgi?id=62691 > > > > Bug ID: 62691 > > Summary: no reset_resume fo

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Takashi Iwai
At Wed, 09 Oct 2013 10:41:57 +0200, Clemens Ladisch wrote: > > Takashi Iwai wrote: > >> On Tue, 8 Oct 2013 baum...@hotmail.com wrote: > >>> https://bugzilla.kernel.org/show_bug.cgi?id=62691 > >>> > >>> Summary: no reset_resume for driver snd-usb

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-09 Thread Takashi Iwai
At Wed, 09 Oct 2013 11:13:44 +0200, Takashi Iwai wrote: > > At Wed, 09 Oct 2013 10:41:57 +0200, > Clemens Ladisch wrote: > > > > Takashi Iwai wrote: > > >> On Tue, 8 Oct 2013 baum...@hotmail.com wrote: > > >>> https://bugzilla.kernel.org/s

Re: Cannot load snd-usb-audio on 3.12-rc2

2013-10-10 Thread Takashi Iwai
At Wed, 9 Oct 2013 13:01:08 -0700, Sarah Sharp wrote: > > On Thu, Sep 26, 2013 at 10:36:29AM +0200, Takashi Iwai wrote: > > At Mon, 23 Sep 2013 16:41:07 -0700, > > Sarah Sharp wrote: > > > > > > The snd-usb-audio driver no longer loads properly on 3.12-rc2

Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2013-10-20 Thread Takashi Iwai
At Sun, 20 Oct 2013 23:18:13 +0200, wrote: > > On 2013-10-09 11:16 (CEST,UTC+2), Takashi Iwai wrote: > >>>> diff --git a/sound/usb/card.c b/sound/usb/card.c > >>>> index 9d9de8d..c591a83 100644 > >>>> --- a/sound/usb/card.c > >>>&g

Re: usb audio race at disconnect time

2012-10-11 Thread Takashi Iwai
[Added Daniel and Clemens in the loop] At Thu, 11 Oct 2012 17:17:59 +0200, Matthieu CASTET wrote: > > Hi, > > while doing some monkey tests on a product we found races in usb audio code > when > the device in unplugged from usb (on linus master tree). > > This can be reproduced with usb_audio_

Re: [alsa-devel] usb audio race at disconnect time

2012-10-12 Thread Takashi Iwai
At Thu, 11 Oct 2012 18:41:52 +0200, Takashi Iwai wrote: > > [Added Daniel and Clemens in the loop] > > At Thu, 11 Oct 2012 17:17:59 +0200, > Matthieu CASTET wrote: > > > > Hi, > > > > while doing some monkey tests on a product we found races in usb

[PATCH 0/2] USB-audio disconnection race fixes

2012-10-12 Thread Takashi Iwai
Hi, these two patches are for fixing races at disconnection of USB audio devices. The first patch tries to close the race at open/close, and the next is for other PCM and mixer ops in usb-audio driver. It seems working as far as I've tested with Matthieu's test cases. thanks, Takashi -- To un

[PATCH 1/2] ALSA: PCM: Fix some races at disconnection

2012-10-12 Thread Takashi Iwai
Fix races at PCM disconnection: - while a PCM device is being opened or closed - while the PCM state is being changed without lock in prepare, hw_params, hw_free ops Signed-off-by: Takashi Iwai --- sound/core/pcm.c| 7 ++- sound/core/pcm_native.c | 16 2 files

[PATCH 2/2] ALSA: usb-audio: Fix races at disconnection

2012-10-12 Thread Takashi Iwai
others; the device speed is now cached in subs->speed instead of accessing to chip->dev The accesses in PCM open and close don't need the mutex protection because these are already handled in the core PCM disconnection code. Signed-off-by: Takashi Iwai --- sound/usb/card.h | 1 +

Re: usb audio race at disconnect time

2012-10-13 Thread Takashi Iwai
At Fri, 12 Oct 2012 17:42:19 +0200, Matthieu CASTET wrote: > > Hi, > > > Takashi Iwai a écrit : > > [Added Daniel and Clemens in the loop] > > > > > > I don't think this is needed. > > > > So... the below is a quick hack I did without

[PATCH 0/2] USB-audio disconnection race fixes (v2)

2012-10-15 Thread Takashi Iwai
Hi, this is a series of fixes for the disconnection races in USB-audio. A couple of new patches to improve and cover more points since the previous patch set. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mor

[PATCH 1/4] ALSA: PCM: Fix some races at disconnection

2012-10-15 Thread Takashi Iwai
Fix races at PCM disconnection: - while a PCM device is being opened or closed - while the PCM state is being changed without lock in prepare, hw_params, hw_free ops Signed-off-by: Takashi Iwai --- sound/core/pcm.c| 7 ++- sound/core/pcm_native.c | 16 2 files

[PATCH 2/4] ALSA: usb-audio: Fix races at disconnection (v2)

2012-10-15 Thread Takashi Iwai
others; the device speed is now cached in subs->speed instead of accessing to chip->dev The accesses in PCM open and close don't need the mutex protection because these are already handled in the core PCM disconnection code. Signed-off-by: Takashi Iwai --- v1->v2: fix unbalanced mut

[PATCH 3/4] ALSA: usb-audio: Use rwsem for disconnect protection

2012-10-15 Thread Takashi Iwai
Replace mutex with rwsem for codec->shutdown protection so that concurrent accesses are allowed. Also add the protection to snd_usb_autosuspend() and snd_usb_autoresume(), too. Signed-off-by: Takashi Iwai --- sound/usb/card.c | 12 sound/usb/mixer.c| 12 ++-- so

[PATCH 4/4] ALSA: usb-audio: Fix races at disconnection in mixer_quirks.c

2012-10-15 Thread Takashi Iwai
Similar like the previous commit, cover with chip->shutdown_rwsem and chip->shutdown checks. Signed-off-by: Takashi Iwai --- sound/usb/mixer_quirks.c | 58 ++-- 1 file changed, 51 insertions(+), 7 deletions(-) diff --git a/sound/usb/mixer_quir

Re: usb audio race at disconnect time

2012-10-15 Thread Takashi Iwai
At Mon, 15 Oct 2012 19:41:40 +0200, Matthieu CASTET wrote: > > Hi Takashi, > > Takashi Iwai a écrit : > > At Fri, 12 Oct 2012 17:42:19 +0200, > > Matthieu CASTET wrote: > >> Hi, > >> > >> > >> Takashi Iwai a écrit : > >>>

Re: usb audio race at disconnect time

2012-10-16 Thread Takashi Iwai
At Mon, 15 Oct 2012 20:45:44 +0200, Takashi Iwai wrote: > > At Mon, 15 Oct 2012 19:41:40 +0200, > Matthieu CASTET wrote: > > > > Hi Takashi, > > > > Takashi Iwai a écrit : > > > At Fri, 12 Oct 2012 17:42:19 +0200, > > > Matthieu CASTET wrote: &

Re: usb audio race at disconnect time

2012-10-16 Thread Takashi Iwai
At Tue, 16 Oct 2012 18:01:13 +0200, Matthieu CASTET wrote: > > Takashi Iwai a écrit : > > At Mon, 15 Oct 2012 19:41:40 +0200, > > Matthieu CASTET wrote: > >> Hi Takashi, > >> > >> But I believe I found other races in the alsa char device handlin

Re: usb audio race at disconnect time

2012-10-19 Thread Takashi Iwai
At Thu, 18 Oct 2012 17:39:05 +0200, Matthieu CASTET wrote: > > Takashi Iwai a écrit : > > At Tue, 16 Oct 2012 18:01:13 +0200, > > Matthieu CASTET wrote: > >> Takashi Iwai a écrit : > >>> At Mon, 15 Oct 2012 19:41:40 +0200, > >>> Matthieu C

[PATCH 0/2] Yet more USB-audio disconnection race fixes

2012-10-19 Thread Takashi Iwai
Hi, these two patches are applied on the top of previous four patches for fixing races at disconnection of USB-audio devices. These rather cover the core codes than USB-specific. The whole six patches are found in topic/usb-disconnect-fix branch of sound-unstable git tree, too. git://git.kerne

[PATCH 1/2] ALSA: Add a reference counter to card instance

2012-10-19 Thread Takashi Iwai
-by: Takashi Iwai --- include/sound/core.h | 3 +++ sound/core/compress_offload.c | 9 ++-- sound/core/control.c | 3 +++ sound/core/hwdep.c| 5 - sound/core/init.c | 50 ++- sound/core/oss/mixer_oss.c

[PATCH 2/2] ALSA: Avoid endless sleep after disconnect

2012-10-19 Thread Takashi Iwai
When disconnect callback is called, each component should wake up sleepers and check card->shutdown flag for avoiding the endless sleep blocking the proper resource release. Signed-off-by: Takashi Iwai --- sound/core/control.c | 2 ++ sound/core/hwdep.c | 7 +++ sound/core/

Re: usb audio race at disconnect time

2012-10-29 Thread Takashi Iwai
At Thu, 18 Oct 2012 17:39:05 +0200, Matthieu CASTET wrote: > > Takashi Iwai a écrit : > > At Tue, 16 Oct 2012 18:01:13 +0200, > > Matthieu CASTET wrote: > >> Takashi Iwai a écrit : > >>> At Mon, 15 Oct 2012 19:41:40 +0200, > >>> Matthieu C

Re: usb audio race at disconnect time

2012-10-30 Thread Takashi Iwai
At Tue, 30 Oct 2012 11:52:33 +0100, Matthieu CASTET wrote: > > > Takashi Iwai a écrit : > >> Thanks, > >> > >> the first tests seems ok. > >> We will do more strees test. > > > > Do you have any good/bad test result? > > If no

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-11-07 Thread Takashi Iwai
At Wed, 7 Nov 2012 12:34:43 -0500 (EST), Alan Stern wrote: > > On Mon, 5 Nov 2012, Christof Meerwald wrote: > > > BTW, I have been able to reproduce the problem on a completely > > different machine (also running Ubuntu 12.10, but different hardware). > > The important thing appears to be that th

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-11-07 Thread Takashi Iwai
At Thu, 08 Nov 2012 01:42:59 +0100, Daniel Mack wrote: > > On 07.11.2012 20:19, Takashi Iwai wrote: > > At Wed, 7 Nov 2012 12:34:43 -0500 (EST), > > Alan Stern wrote: > >> > >> On Mon, 5 Nov 2012, Christof Meerwald wrote: > >> > >>> BTW,

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-11-07 Thread Takashi Iwai
At Wed, 7 Nov 2012 15:37:17 -0500 (EST), Alan Stern wrote: > > On Wed, 7 Nov 2012, Takashi Iwai wrote: > > > > What is the right solution for this problem? > > > > How about the patch below? (It's for 3.6, and won't be applied cleanly > > to 3

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-11-08 Thread Takashi Iwai
- thanks for explaining :) OK, thanks for checking. FWIW, below is the patch I applied now to for-linus branch. Renamed the function, added the comment and put NULL check to the function to simplify. Takashi --- From: Takashi Iwai Subject: [PATCH] ALSA: usb-audio: Fix crash at re-preparing the PCM

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-11-08 Thread Takashi Iwai
At Thu, 8 Nov 2012 10:55:50 -0500 (EST), Alan Stern wrote: > > On Thu, 8 Nov 2012, Takashi Iwai wrote: > > > At Thu, 08 Nov 2012 08:31:35 +0100, > > Daniel Mack wrote: > > (snip) > > > >> We can't simply stop both endpoints in the prepare callback.

Re: Sound+USB: deadlock problem

2012-11-13 Thread Takashi Iwai
At Tue, 13 Nov 2012 09:26:17 +0100, Jiri Slaby wrote: > > Hello, > > I've just plugged+unplugged+plugged my USB audio card and the audio > subsystem got stuck: Which kernel? If it's older than 3.7-rc5, could you try 3.7-rc5? Takashi > > INFO: task khubd:440 blocked for more than 120 seconds

Re: Sound+USB: deadlock problem

2012-11-13 Thread Takashi Iwai
At Tue, 13 Nov 2012 09:30:10 +0100, Jiri Slaby wrote: > > On 11/13/2012 09:28 AM, Takashi Iwai wrote: > > At Tue, 13 Nov 2012 09:26:17 +0100, > > Jiri Slaby wrote: > >> > >> Hello, > >> > >> I've just plugged+unplugged+plugg

Re: Sound+USB: deadlock problem

2012-11-13 Thread Takashi Iwai
At Tue, 13 Nov 2012 10:39:14 +0100, Jiri Slaby wrote: > > On 11/13/2012 09:45 AM, Takashi Iwai wrote: > > At Tue, 13 Nov 2012 09:30:10 +0100, > > Jiri Slaby wrote: > >> > >> On 11/13/2012 09:28 AM, Takashi Iwai wrote: > >>> At Tue, 13

Re: xHCI quirk increases module load time

2013-12-05 Thread Takashi Iwai
At Tue, 3 Dec 2013 16:17:15 -0800, Sarah Sharp wrote: > > On Tue, Dec 03, 2013 at 01:13:15PM -0800, Greg KH wrote: > > On Tue, Dec 03, 2013 at 01:08:08PM -0800, Sarah Sharp wrote: > > > Yeah, it doesn't make much sense to me either. But I can reproduce the > > > behavior on my Lenovo x230 if I ad

[PATCH] xhci: Add quirks module option

2013-12-09 Thread Takashi Iwai
It makes easier for debugging some hardware specific issues. Note that this option won't override the value to be set. That is, you can turn quirks on by this option but cannot turn them off if set by the driver. Signed-off-by: Takashi Iwai --- I noticed the lack of quirks module o

[PATCH] xhci: Limit the spurious wakeup fix only to HP machines

2013-12-09 Thread Takashi Iwai
confirmed explicitly only on HP machines, it'd be safer to apply it only to limited machines. As a wild guess, limiting to machines with HP PCI SSID should suffice. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=66171 Cc: Signed-off-by: Takashi Iwai --- drivers/usb/host/xhci-pci.c

[PATCH v2] xhci: Limit the spurious wakeup fix only to HP machines

2013-12-09 Thread Takashi Iwai
S5 wakeups have been confirmed only on HP machines, it'd be safer to apply it only to limited machines. As a wild guess, limiting to machines with HP PCI SSID should suffice. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=66171 Cc: Signed-off-by: Takashi Iwai --- v1->v2: Fix bug des

Re: USB sound auto-suspend not working

2013-12-18 Thread Takashi Iwai
At Tue, 17 Dec 2013 14:55:48 -0800, Sarah Sharp wrote: > > Hi Oliver and Takashi, > > I've noticed that in the last couple kernel releases or so, I can't get > USB webcams to suspend. It turns out that the USB sound interface is > keeping the device active, even when the device is not playing so

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2014-01-07 Thread Takashi Iwai
At Mon, 06 Jan 2014 14:34:28 +0200, Denis Turischev wrote: > > Hi Sarah, > > On 01/03/2014 02:03 AM, Sarah Sharp wrote: > > Denis, do all of Compulab's Haswell systems reboot on shutdown? Are > > they all running a Phoenix BIOS? Can you send me the output of `sudo > > lspci -vvv -s` for the xHC

Re: Fwd: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2014-01-13 Thread Takashi Iwai
hange, so there is no functional change. That being said, you just need to ignore the kernel messages in the old kernels. Or, feel free to submit the commit [0a56b4fa6844: USB: change dev_warn about missing reset-resume to dev_dbg] to stable kernel. Takashi > > Thanks, Bernhard > >

Re: Fwd: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2014-01-20 Thread Takashi Iwai
r values. This might work in some cases like S3 (where the device is kept more or less powered on), but it'll be definitely broken in some cases like S4. Takashi > > Thanks, Bernhard > > > On 2014-01-13 10:55, Takashi Iwai wrote: > > > At Sat, 11 Jan 2014 11:08:39 +

Re: Fwd: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2014-01-20 Thread Takashi Iwai
At Mon, 20 Jan 2014 09:45:58 +0100, Takashi Iwai wrote: > > At Sun, 19 Jan 2014 21:30:58 +0100, > wrote: > > > > Hello, > > > > there must be a misunderstanding; > > > > There is a functional change, because with the line/patch ".reset_res

Re: Fwd: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2014-01-22 Thread Takashi Iwai
At Wed, 22 Jan 2014 18:12:45 +0100, wrote: > > On 2014-01-20 17:07, Takashi Iwai wrote: > > At Mon, 20 Jan 2014 09:45:58 +0100, > > Takashi Iwai wrote: > >> > >> At Sun, 19 Jan 2014 21:30:58 +0100, > >> wrote: > >>> > >>> Hell

Re: usb audio suspend support

2007-12-14 Thread Takashi Iwai
At Fri, 14 Dec 2007 13:33:22 +0100, Oliver Neukum wrote: > > Hi, > > this patch implements suspend/resume support for USB audio devices. > It works with the microphone in my camera. > > Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Thanks, I applied it to ALSA HG tree now. Takashi > >

Re: Fwd: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2014-03-25 Thread Takashi Iwai
At Tue, 25 Mar 2014 20:21:34 +0100, wrote: > > On 2014-01-22 18:16 CET (UTC+1), Takashi Iwai wrote: > > At Wed, 22 Jan 2014 18:12:45 +0100, > > wrote: > >> > >> On 2014-01-20 17:07, Takashi Iwai wrote: > >>> At Mon, 20 Jan 2014 09:45:58 +0100, &g

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Takashi Iwai
At Tue, 20 May 2014 12:47:36 +0300, Mathias Nyman wrote: > > On 05/20/2014 04:01 AM, Greg KH wrote: > > On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: > >> From: Dan Williams > >> > >> Add a command line switch for disabling ehci port switchover. Useful > >> for working around /

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Takashi Iwai
At Tue, 20 May 2014 11:25:37 -0700, Dan Williams wrote: > > On Tue, May 20, 2014 at 2:51 AM, Takashi Iwai wrote: > > At Tue, 20 May 2014 12:47:36 +0300, > > Mathias Nyman wrote: > >> > >> On 05/20/2014 04:01 AM, Greg KH wrote: > >> > On Thu, May 0

Re: Race in snd-usb-audio driver

2014-06-25 Thread Takashi Iwai
[Adding Daniel to Cc] At Tue, 24 Jun 2014 13:52:14 -0400 (EDT), Alan Stern wrote: > > Takashi and Clemens: > > The snd-usb-audio driver has a race between close and disconnect. A > patch I have been testing reliably triggers this race on my machine and > reveals a use-after-free bug. > > This

Re: Race in snd-usb-audio driver

2014-06-25 Thread Takashi Iwai
At Wed, 25 Jun 2014 10:59:29 -0400 (EDT), Alan Stern wrote: > > On Wed, 25 Jun 2014, Takashi Iwai wrote: > > > [Adding Daniel to Cc] > > > > At Tue, 24 Jun 2014 13:52:14 -0400 (EDT), > > Alan Stern wrote: > > > > > > Takashi and Clemens: >

Re: [PATCH 1/1] usb: gadget: f_uac2: Fix pcm sample size selection

2014-07-03 Thread Takashi Iwai
f the code runtime->hw.period_bytes_min = 2 * uac2->p_prm.max_psize / runtime->hw.periods_min; But this is mostly irrelevant with this patch, so for this patch: Reviewed-by: Takashi Iwai thanks, Takashi > --- > drivers/usb/gadget/f_

[PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
[The fix suggested by Hannes] Fixes: 5ee0f803cc3a ('usbcore: don't log on consecutive debounce failures of the same port') Reported-by: Hannes Reinecke Signed-off-by: Takashi Iwai --- drivers/usb/core/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2014 15:13:24 +0200, Takashi Iwai wrote: > > The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce > failures of the same port] added the check of the reliable port, but > it also replaced the device argument to dev_err() wrongly, which leads > t

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2014 10:35:58 -0400 (EDT), Alan Stern wrote: > > On Tue, 19 Aug 2014, Takashi Iwai wrote: > > > The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce > > failures of the same port] added the check of the reliable port, but > > it also

[PATCH] usbcore: Reduce redundant error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
Alan Stern pointed out that the port number shown in the error message from hub_port_connect() is redundant. This patch removes it, essentially reverts to the state before the commit 5ee0f803cc3a. Signed-off-by: Takashi Iwai --- I wasn't sure whether this deserves Cc to stable. Feel fr

[PATCH v2] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
don't log on consecutive debounce failures of the same port') Reported-by: Hannes Reinecke Cc: Signed-off-by: Takashi Iwai --- v1->v2: cleanup the error message drivers/usb/core/hub.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/core/hub.c b/dr

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2014 10:25:20 -0500, Greg Kroah-Hartman wrote: > > On Tue, Aug 19, 2014 at 10:15:37AM -0500, Greg Kroah-Hartman wrote: > > On Tue, Aug 19, 2014 at 04:46:31PM +0200, Takashi Iwai wrote: > > > At Tue, 19 Aug 2014 10:35:58 -0400 (EDT), > > > Alan Stern

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-19 Thread Takashi Iwai
At Tue, 19 May 2015 19:42:55 +0200, Oliver Neukum wrote: > > On Tue, 2015-05-19 at 19:13 +0200, Takashi Iwai wrote: > > At Tue, 19 May 2015 10:26:46 -0400 (EDT), > > Alan Stern wrote: > > > > > > > > > Of just have request_firmware() > &

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-20 Thread Takashi Iwai
ontains patches. > > It would be nice if we could tell request_firmware() if it is optional or > mandatory firmware. Or if it should just cache the status of a missing > firmware as well. OK, below is a quick hack to record the failed f/w files, too. Not sure whether this helps, though

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-20 Thread Takashi Iwai
At Wed, 20 May 2015 16:42:44 -0700, Laura Abbott wrote: > > On 05/20/2015 05:44 AM, Takashi Iwai wrote: > > At Wed, 20 May 2015 11:46:31 +0200, > > Marcel Holtmann wrote: > >> > >> Hi Oliver, > >> > >>>> The data is cached in RAM. Mo

  1   2   3   >