Re: [PATCH] option: Add support for Quectel EP06

2018-02-08 Thread Johan Hovold
On Sun, Feb 04, 2018 at 07:24:22PM +0100, Bjørn Mork wrote: > Johan Hovold writes: > >> IIRC I considered just dumping the BIT(x) into the .driver_info but > >> then we'd only have 16 bits for each of send_setup and reserved on 32- > >> bit arches and I wasn't sure that was

Re: [PATCH] option: Add support for Quectel EP06

2018-02-04 Thread Bjørn Mork
Johan Hovold writes: > IIRC we have already started reusing entries, but the names have not > always been made generic in the process. I think Bjørn may have proposed > a generic naming scheme at some point, but that essentially just meant > we encoded the two masks in the

Re: [PATCH] option: Add support for Quectel EP06

2018-02-03 Thread Johan Hovold
On Wed, Jan 31, 2018 at 04:35:34PM -0600, Dan Williams wrote: > On Wed, 2018-01-31 at 16:32 -0600, Dan Williams wrote: > > On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > > > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > > > Hi Johan, > > > > > > > > On Wed, Jan

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Wed, 2018-01-31 at 16:32 -0600, Dan Williams wrote: > On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > > Hi Johan, > > > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold > > > wrote: > > > >

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > Hi Johan, > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold > > wrote: > > > This will probably have to do for now, but we already have > > >

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Johan Hovold
On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > Hi Johan, > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold wrote: > > This will probably have to do for now, but we already have another > > blacklist struct with the same content which we could rename and > >

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Kristian Evensen
Hi Johan, On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold wrote: > This will probably have to do for now, but we already have another > blacklist struct with the same content which we could rename and > reuse. I noticed the same, but wasn't quite sure about the policy on

Re: [PATCH] option: Add support for Quectel EP06

2018-01-30 Thread Johan Hovold
On Tue, Jan 30, 2018 at 03:06:38PM +0100, Kristian Evensen wrote: > The Quectel EP06 is a Cat. 6 LTE modem, and the interface mapping is as > follows: > > 0: Diag > 1: NMEA > 2: AT > 3: Modem > > Interface 4 is QMI and interface 5 is ADB, so they are blacklisted. > > Signed-off-by: Kristian

[PATCH] option: Add support for Quectel EP06

2018-01-30 Thread Kristian Evensen
The Quectel EP06 is a Cat. 6 LTE modem, and the interface mapping is as follows: 0: Diag 1: NMEA 2: AT 3: Modem Interface 4 is QMI and interface 5 is ADB, so they are blacklisted. Signed-off-by: Kristian Evensen --- drivers/usb/serial/option.c | 7 +++ 1 file