Re: [PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-11 Thread Sergei Shtylyov

Hello!

On 12/11/2016 02:45 PM, Jassi Brar wrote:


From: Jassi Brar 

Fix a typo bug that prevents creation of
streaming_{interval,maxpacket,maxburst} nodes for invalid 'aname' node.

Fixes: 76e0da34 ("usb-gadget/uvc: use per-attribute show and store methods")


   The must be at least 12 digits, the format is standardized.


Signed-off-by: Jassi Brar 
Cc: sta...@vger.kernel.org
Reviewed-by: Laurent Pinchart 

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-11 Thread Jassi Brar
From: Jassi Brar 

Fix a typo bug that prevents creation of
streaming_{interval,maxpacket,maxburst} nodes for invalid 'aname' node.

Fixes: 76e0da34 ("usb-gadget/uvc: use per-attribute show and store methods")
Signed-off-by: Jassi Brar 
Cc: sta...@vger.kernel.org
Reviewed-by: Laurent Pinchart 
---
 drivers/usb/gadget/function/uvc_configfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/uvc_configfs.c 
b/drivers/usb/gadget/function/uvc_configfs.c
index ecb5614..158849e 100644
--- a/drivers/usb/gadget/function/uvc_configfs.c
+++ b/drivers/usb/gadget/function/uvc_configfs.c
@@ -2245,7 +2245,7 @@ end:  
\
return ret; \
 }  \
\
-UVC_ATTR(f_uvc_opts_, cname, aname)
+UVC_ATTR(f_uvc_opts_, cname, cname)
 
 #define identity_conv(x) (x)
 
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-02 Thread Laurent Pinchart
On Friday 02 Dec 2016 07:56:32 Greg KH wrote:
> On Fri, Dec 02, 2016 at 11:52:02AM +0530, Jassi Brar wrote:
> > From: Jassi Brar 
> > 
> > Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents
> > creation of streaming_{interval,maxpacket,maxburst} nodes for
> > invalid 'aname' node.
> > 
> > Signed-off-by: Jassi Brar 
> 
> Fixes: tag?
> cc: stable tag?
> 
> Come on, you know better than this...

Apart from that,

Reviewed-by: Laurent Pinchart 

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-02 Thread Sergei Shtylyov

Hello!

On 12/2/2016 9:22 AM, Jassi Brar wrote:


From: Jassi Brar 

Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents


   scripts/checkpatch.pl didn't complain about the commit citing style?
You forgot to specify the summary line enclosed in ("").


creation of streaming_{interval,maxpacket,maxburst} nodes for
invalid 'aname' node.

Signed-off-by: Jassi Brar 

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-01 Thread Greg KH
On Fri, Dec 02, 2016 at 11:52:02AM +0530, Jassi Brar wrote:
> From: Jassi Brar 
> 
> Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents
> creation of streaming_{interval,maxpacket,maxburst} nodes for
> invalid 'aname' node.
> 
> Signed-off-by: Jassi Brar 

Fixes: tag?
cc: stable tag?

Come on, you know better than this...

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

2016-12-01 Thread Jassi Brar
From: Jassi Brar 

Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents
creation of streaming_{interval,maxpacket,maxburst} nodes for
invalid 'aname' node.

Signed-off-by: Jassi Brar 
---
 drivers/usb/gadget/function/uvc_configfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/uvc_configfs.c 
b/drivers/usb/gadget/function/uvc_configfs.c
index ecb5614..158849e 100644
--- a/drivers/usb/gadget/function/uvc_configfs.c
+++ b/drivers/usb/gadget/function/uvc_configfs.c
@@ -2245,7 +2245,7 @@ end:  
\
return ret; \
 }  \
\
-UVC_ATTR(f_uvc_opts_, cname, aname)
+UVC_ATTR(f_uvc_opts_, cname, cname)
 
 #define identity_conv(x) (x)
 
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html