Re: [PATCH] usbip: vudc: fix: Clear already_seen flag also for ep0
Hi, On 12/01/2016 06:26 PM, Sergei Shtylyov wrote: > Hello! > > On 12/01/2016 07:20 PM, Krzysztof Opasiak wrote: > >> ep_list inside gadget structure doesn't contain ep0. >> It is stored separately in ep0 field. >> >> This causes an urb hang if gadget driver decides to >> delay setup handling. On host side this is visible as >> timeout error when setting configuration. >> >> This bug can be reproduced using for example any gadget >> with mass storage function. >> >> Fixes: abdb2957 ("usbip: vudc: Add vudc_transfer") > >At least 12 digits please, the format is standardized. You are right. I forgot about this and just used a short-id. I will post a fix in a minute. Thank you. -- Krzysztof Opasiak Samsung R Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usbip: vudc: fix: Clear already_seen flag also for ep0
Hello! On 12/01/2016 07:20 PM, Krzysztof Opasiak wrote: ep_list inside gadget structure doesn't contain ep0. It is stored separately in ep0 field. This causes an urb hang if gadget driver decides to delay setup handling. On host side this is visible as timeout error when setting configuration. This bug can be reproduced using for example any gadget with mass storage function. Fixes: abdb2957 ("usbip: vudc: Add vudc_transfer") At least 12 digits please, the format is standardized. Signed-off-by: Krzysztof Opasiak[...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usbip: vudc: fix: Clear already_seen flag also for ep0
ep_list inside gadget structure doesn't contain ep0. It is stored separately in ep0 field. This causes an urb hang if gadget driver decides to delay setup handling. On host side this is visible as timeout error when setting configuration. This bug can be reproduced using for example any gadget with mass storage function. Fixes: abdb2957 ("usbip: vudc: Add vudc_transfer") Signed-off-by: Krzysztof Opasiak--- drivers/usb/usbip/vudc_transfer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/usbip/vudc_transfer.c b/drivers/usb/usbip/vudc_transfer.c index aba6bd4..bc0296d 100644 --- a/drivers/usb/usbip/vudc_transfer.c +++ b/drivers/usb/usbip/vudc_transfer.c @@ -339,6 +339,8 @@ static void v_timer(unsigned long _vudc) total = timer->frame_limit; } + /* We have to clear ep0 flags separately as it's not on the list */ + udc->ep[0].already_seen = 0; list_for_each_entry(_ep, >gadget.ep_list, ep_list) { ep = to_vep(_ep); ep->already_seen = 0; -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html